D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-01 Thread Roman Geints
romangeints created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangeints requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D15887

AFFECTED FILES
  klipper/klipper.cpp

To: romangeints
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-02 Thread Roman Geints
romangeints updated this revision to Diff 42713.
romangeints added a comment.


  Renamed a variable, removed extra parentheses

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15887?vs=42689&id=42713

REVISION DETAIL
  https://phabricator.kde.org/D15887

AFFECTED FILES
  klipper/klipper.cpp

To: romangeints, #plasma, davidedmundson
Cc: romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-05 Thread Roman Geints
romangeints added a comment.


  So, should I rewrite this in terms of `qBound` & `availableGeometry`?

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-06 Thread Roman Geints
romangeints updated this revision to Diff 42988.
romangeints added a comment.


  I've figured extra adjustments are not necessary at all, QMenu::popup 
 
does enough already.
  
  Screencast: https://streamable.com/jonoj

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15887?vs=42713&id=42988

REVISION DETAIL
  https://phabricator.kde.org/D15887

AFFECTED FILES
  klipper/klipper.cpp

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread Roman Geints
romangeints added a comment.


  Am I right thinking no further action is expected from me?

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D15887: Fix Klipper popup opening on default screen instead of at cursor position

2018-10-19 Thread Roman Geints
romangeints added a comment.


  roman...@gmail.com

REVISION DETAIL
  https://phabricator.kde.org/D15887

To: romangeints, #plasma, davidedmundson
Cc: mvourlakos, romangeints, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart