Re: [opensource-dev] Review Request: STORM-316 Add missing "sort by name" and "sort by recent" options for folders
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/27/#review44 --- For me 'Sort Folders by Most Recent' works only when 'Sort Items by Most Recent' is checked. Though I can't figure out what's wrong with this patch. - Seth On 2010-12-16 03:33:51, Kitty Barnett wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/27/ > --- > > (Updated 2010-12-16 03:33:51) > > > Review request for Viewer. > > > Summary > --- > > Changes the UI (and needs additional translation), but it's a viewer 1 option > that was missed by STORM-316. > > Existing "Sort by (Name|Most Recent)" => "Sort Items by (Name|Most Recent)" > > Split "Folders always by name" in two options to match what was done for > inventory items and added "Sort Folders by (Name|Most Recent)" menu options. > > > This addresses bug STORM-316. > http://jira.secondlife.com/browse/STORM-316 > > > Diffs > - > > indra/newview/llpanelmaininventory.cpp UNKNOWN > indra/newview/skins/default/xui/en/menu_inventory_gear_default.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/27/diff > > > Testing > --- > > > Thanks, > > Kitty > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/ --- Review request for Viewer. Summary --- Fixed LLDir unit test which failed for some complex wildcard combinations. Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir. This code has been run on Linux only. It should be tested under other platforms and more test cases should be provided. For example changing directory contents while iterating through it. This addresses bug STORM-550. http://jira.secondlife.com/browse/STORM-550 Diffs - indra/cmake/Boost.cmake 794ad1fc71d1 indra/llvfs/CMakeLists.txt 794ad1fc71d1 indra/llvfs/lldiriterator.h PRE-CREATION indra/llvfs/lldiriterator.cpp PRE-CREATION indra/llvfs/tests/lldir_test.cpp 794ad1fc71d1 Diff: http://codereview.secondlife.com/r/32/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/ --- (Updated 2010-12-20 13:47:20.663157) Review request for Viewer. Changes --- - Added supported glob wildcards matching description. - Fixed leading '*' translation to regex to avoid matching leading '.' in file names. - Fixed '?' escaping. - Added incorrect braces usage handling. Added related test cases. - Fixed character ranges complementation with '!'. Added related test cases. Summary --- Fixed LLDir unit test which failed for some complex wildcard combinations. Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir. This code has been run on Linux only. It should be tested under other platforms and more test cases should be provided. For example changing directory contents while iterating through it. This addresses bug STORM-550. http://jira.secondlife.com/browse/STORM-550 Diffs (updated) - indra/cmake/Boost.cmake 794ad1fc71d1 indra/llvfs/CMakeLists.txt 794ad1fc71d1 indra/llvfs/lldiriterator.h PRE-CREATION indra/llvfs/lldiriterator.cpp PRE-CREATION indra/llvfs/tests/lldir_test.cpp 794ad1fc71d1 Diff: http://codereview.secondlife.com/r/32/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-797) Parcel SLURL rendering
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/69/ --- Review request for Viewer. Summary --- Added parcel SLURL rendering with human readable parcel names. - Added parcel info observer to LLUrlEntryParcel. - Added notifying LLUrlEntryParcel by LLRemoteParcelInfoProcessor when parcel data arrives. - Added notifying LLUrlEntryParcel about user login, changing host and viewer connection state to use this data in remote parcel requests. This addresses bug STORM-797. http://jira.secondlife.com/browse/STORM-797 Diffs - indra/llui/llurlentry.h 27dae7b01a81 indra/llui/llurlentry.cpp 27dae7b01a81 indra/llui/tests/llurlentry_stub.cpp 27dae7b01a81 indra/newview/llagent.cpp 27dae7b01a81 indra/newview/llappviewer.cpp 27dae7b01a81 indra/newview/llremoteparcelrequest.cpp 27dae7b01a81 indra/newview/llstartup.cpp 27dae7b01a81 indra/newview/tests/llremoteparcelrequest_test.cpp 27dae7b01a81 Diff: http://codereview.secondlife.com/r/69/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/ --- (Updated Jan. 4, 2011, 12:38 p.m.) Review request for Viewer. Changes --- - Added a boost::regex member variable not to translate the mask to a regex on every call to next(). - Moved iterator initialization and exceptions handling to the constructor. Summary --- Fixed LLDir unit test which failed for some complex wildcard combinations. Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir. This code has been run on Linux only. It should be tested under other platforms and more test cases should be provided. For example changing directory contents while iterating through it. This addresses bug STORM-550. http://jira.secondlife.com/browse/STORM-550 Diffs (updated) - indra/cmake/Boost.cmake 27dae7b01a81 indra/llvfs/CMakeLists.txt 27dae7b01a81 indra/llvfs/lldiriterator.h PRE-CREATION indra/llvfs/lldiriterator.cpp PRE-CREATION indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 Diff: http://codereview.secondlife.com/r/32/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations
> On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote: > > indra/llvfs/lldiriterator.cpp, lines 152-155 > > <http://codereview.secondlife.com/r/32/diff/2/?file=129#file129line152> > > > > This method of tracking escapes and brackets isn't quite correct, I > > think... consider translating a string input containing an escaped > > backslash or an escaped bracket. > > Escaping characters like backslash or a square bracket seems to work as expected. For example the pattern "file[0-9].abc" used as a mask argument for iterator constructor will match files: "file\1.abc", "file\2.abc", etc. The bracket can be escaped by a preceding double backslash "\\[". > On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote: > > indra/llvfs/lldiriterator.cpp, line 99 > > <http://codereview.secondlife.com/r/32/diff/2/?file=129#file129line99> > > > > There should be a unit test for this translation. All unit tests for directory iterator depend on the result of this translation. Looks like most common cases are covered. Does it need some additional test cases? what kind of cases should be added? > On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote: > > indra/llvfs/lldiriterator.cpp, lines 67-80 > > <http://codereview.secondlife.com/r/32/diff/2/?file=129#file129line67> > > > > It would be better to make the boost::regex a member variable - rather > > than translate the mask to a regex on every call to next, translate it once > > in the constructor. Updated in diff r3. > On Dec. 23, 2010, 7:21 a.m., Oz Linden wrote: > > indra/llvfs/lldiriterator.h, lines 55-56 > > <http://codereview.secondlife.com/r/32/diff/2/?file=128#file128line55> > > > > Why not use '^' for the negation qualifier here? It's more familiar > > (at least to unix users) '!' is defined in pattern matching rules on glob(7) man page, but it could be easily replaced with '^' if it is needed. - Seth ------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/#review80 --- On Jan. 4, 2011, 12:38 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/32/ > --- > > (Updated Jan. 4, 2011, 12:38 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed LLDir unit test which failed for some complex wildcard combinations. > Added a class implementing directory entries iteration with pattern matching > which is used in unit tests instead of LLDir::getNextFileInDir. > > This code has been run on Linux only. It should be tested under other > platforms and more test cases should be provided. For example changing > directory contents while iterating through it. > > > This addresses bug STORM-550. > http://jira.secondlife.com/browse/STORM-550 > > > Diffs > - > > indra/cmake/Boost.cmake 27dae7b01a81 > indra/llvfs/CMakeLists.txt 27dae7b01a81 > indra/llvfs/lldiriterator.h PRE-CREATION > indra/llvfs/lldiriterator.cpp PRE-CREATION > indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 > > Diff: http://codereview.secondlife.com/r/32/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations
> On Jan. 5, 2011, 11:34 a.m., Oz Linden wrote: > > Just one policy question with this... > > > > This implementation uses llwarns for various errors in the glob expression. > > > > Given that I expect that the glob expression will normally (always?) be > > hard coded (I hope no one will accept a pattern as input from the user and > > pass it on unverified), should these use llerrs so that the error cannot be > > missed (it crashes)? > > > > Other than that, this looks good now. Not sure about the policy on llerrs but as far as I remember we were trying not to overuse it, using only for fatal errors. If someone eventually will accept a pattern as the user input this might cause unexpected crashes, so I thought warnings would be enough to trace the error while hard coding the patterns, though if llerrs will work better in this case warnings could be replaced. - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/#review112 ------- On Jan. 5, 2011, 8:33 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/32/ > --- > > (Updated Jan. 5, 2011, 8:33 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed LLDir unit test which failed for some complex wildcard combinations. > Added a class implementing directory entries iteration with pattern matching > which is used in unit tests instead of LLDir::getNextFileInDir. > > This code has been run on Linux only. It should be tested under other > platforms and more test cases should be provided. For example changing > directory contents while iterating through it. > > > This addresses bug STORM-477. > http://jira.secondlife.com/browse/STORM-477 > > > Diffs > - > > indra/cmake/Boost.cmake 27dae7b01a81 > indra/llvfs/CMakeLists.txt 27dae7b01a81 > indra/llvfs/lldiriterator.h PRE-CREATION > indra/llvfs/lldiriterator.cpp PRE-CREATION > indra/llvfs/tests/lldir_test.cpp 27dae7b01a81 > > Diff: http://codereview.secondlife.com/r/32/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/ --- (Updated Jan. 11, 2011, 8:27 a.m.) Review request for Viewer. Changes --- - Changed llwarns with llerrs in LLDirIterator and removed 2 unit tests that started to cause llerrs. - Replaced all existing usages of LLDir::getNextFileInDir() with the new directory iterator object. - Removed platform specific LLDir::getNextFileInDir() implementation. Summary (updated) --- - Re-implemented LLDir::getNextFileInDir() as an iterator object. - Added a class implementing directory entries iteration with pattern matching which is used in unit tests instead of LLDir::getNextFileInDir. - Fixed LLDir unit test which failed for some complex wildcard combinations. - Replaced all existing usages of LLDir::getNextFileInDir() with the new directory iterator object. - Removed platform specific LLDir::getNextFileInDir() implementation. This addresses bug STORM-477. http://jira.secondlife.com/browse/STORM-477 Diffs (updated) - indra/cmake/Boost.cmake bceb13778d1d indra/integration_tests/llui_libtest/llui_libtest.cpp bceb13778d1d indra/linux_updater/linux_updater.cpp bceb13778d1d indra/llvfs/CMakeLists.txt bceb13778d1d indra/llvfs/lldir.h bceb13778d1d indra/llvfs/lldir.cpp bceb13778d1d indra/llvfs/lldir_linux.h bceb13778d1d indra/llvfs/lldir_linux.cpp bceb13778d1d indra/llvfs/lldir_mac.h bceb13778d1d indra/llvfs/lldir_mac.cpp bceb13778d1d indra/llvfs/lldir_solaris.h bceb13778d1d indra/llvfs/lldir_solaris.cpp bceb13778d1d indra/llvfs/lldir_win32.h bceb13778d1d indra/llvfs/lldir_win32.cpp bceb13778d1d indra/llvfs/lldiriterator.h PRE-CREATION indra/llvfs/lldiriterator.cpp PRE-CREATION indra/llvfs/tests/lldir_test.cpp bceb13778d1d indra/newview/llappviewer.cpp bceb13778d1d indra/newview/llappviewerlinux.cpp bceb13778d1d indra/newview/llfloateruipreview.cpp bceb13778d1d indra/newview/lllogchat.cpp bceb13778d1d indra/newview/llviewermedia.cpp bceb13778d1d indra/newview/llwaterparammanager.cpp bceb13778d1d indra/newview/llwlparammanager.cpp bceb13778d1d indra/viewer_components/updater/tests/llupdaterservice_test.cpp bceb13778d1d Diff: http://codereview.secondlife.com/r/32/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/ --- Review request for Viewer. Summary --- Added "Restore Item" context menu entry for landmarks and folders in Trash category in Places->My Landmarks->My Inventory accordion tab. This addresses bug STORM-383. http://jira.secondlife.com/browse/STORM-383 Diffs - indra/newview/llpanellandmarks.h 422f636c3343 indra/newview/llpanellandmarks.cpp 422f636c3343 indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343 indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml 422f636c3343 Diff: http://codereview.secondlife.com/r/77/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/ --- (Updated Jan. 17, 2011, 8:17 a.m.) Review request for Viewer. Changes --- Minor style-related changes. Added comments. Summary --- Added "Restore Item" context menu entry for landmarks and folders in Trash category in Places->My Landmarks->My Inventory accordion tab. This addresses bug STORM-383. http://jira.secondlife.com/browse/STORM-383 Diffs (updated) - indra/newview/llpanellandmarks.h 422f636c3343 indra/newview/llpanellandmarks.cpp 422f636c3343 indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343 indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml 422f636c3343 Diff: http://codereview.secondlife.com/r/77/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-383) Context menu cannot be open for Landmark that are located in the My inventory->Trash folder
> On Jan. 16, 2011, 7:37 a.m., Vadim ProductEngine wrote: > > indra/newview/llpanellandmarks.cpp, lines 1127-1132 > > <http://codereview.secondlife.com/r/77/diff/1/?file=436#file436line1127> > > > > Why are the checks for are_all_items_in_trash and > > are_any_items_in_trash different? > > > > I guess it should be something like: > > > > bool item_in_trash = listenerp->isItemInTrash() && *iter != trash_id; > > are_all_items_in_trash &= item_in_trash; > > are_any_items_in_trash |= item_in_trash; Probably it will look more pretty this way. But the checks should remain different in order not to enable "Restore Item" when Trash folder is selected and not to display an empty menu when some of the selected items are in Trash and some aren't. - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/77/#review170 --- On Jan. 17, 2011, 8:17 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/77/ > --- > > (Updated Jan. 17, 2011, 8:17 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Added "Restore Item" context menu entry for landmarks and folders in Trash > category in Places->My Landmarks->My Inventory accordion tab. > > > This addresses bug STORM-383. > http://jira.secondlife.com/browse/STORM-383 > > > Diffs > - > > indra/newview/llpanellandmarks.h 422f636c3343 > indra/newview/llpanellandmarks.cpp 422f636c3343 > indra/newview/skins/default/xui/en/menu_places_gear_folder.xml 422f636c3343 > indra/newview/skins/default/xui/en/menu_places_gear_landmark.xml > 422f636c3343 > > Diff: http://codereview.secondlife.com/r/77/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-373 "Rename" context menu option disabled for incomplete inventory items
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/101/#review187 --- Ship it! Looks good to me. Seems like adding another observer is necessary to deal with this issue. - Seth On Jan. 18, 2011, 8:20 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/101/ > --- > > (Updated Jan. 18, 2011, 8:20 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Refresh the inventory context menu (which enables the "Rename" option) after > the selected item(s) gets fetched. > > I'm a bit worried by adding another inventory observer to each inventory > panel, but I couldn't come up with a solution which is more elegant and > affects performance less. > > > This addresses bug STORM-373. > http://jira.secondlife.com/browse/STORM-373 > > > Diffs > - > > indra/newview/llfolderview.h 422f636c3343 > indra/newview/llfolderview.cpp 422f636c3343 > indra/newview/llinventorypanel.h 422f636c3343 > indra/newview/llinventorypanel.cpp 422f636c3343 > > Diff: http://codereview.secondlife.com/r/101/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-465 Missing Strings from strings.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/108/#review208 --- Ship it! No missing string warnings while looking through the menu with this patch. - Seth On Jan. 19, 2011, 8:30 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/108/ > --- > > (Updated Jan. 19, 2011, 8:30 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Made all keys localizable. > > > This addresses bug STORM-465. > http://jira.secondlife.com/browse/STORM-465 > > > Diffs > - > > indra/newview/skins/default/xui/en/strings.xml 38465c40c060 > > Diff: http://codereview.secondlife.com/r/108/diff > > > Testing > --- > > Tested on Linux. No keys produce the warning for me. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: TestCapabilityProvider build fix.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/123/ --- Review request for Viewer and Nyx Linden. Summary --- Fixed TestCapabilityProvider build issue. Diffs - indra/newview/tests/llcapabilitylistener_test.cpp 26c09ad4293e Diff: http://codereview.secondlife.com/r/123/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: make PREHASH variables char const* const
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review259 --- I'm ok with changing declarations of some pointers to _PREHASH_ strings and setting them to NULL as they are not de-referenced and not really used in tests now. But I'm not sure about changes to code generating all the other _PREHASH_ declarations because it's not yet clear how they should be re-generated. - Seth On Jan. 22, 2011, 7:40 a.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/100/ > --- > > (Updated Jan. 22, 2011, 7:40 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > --- > > For the reason for this change, see > https://jira.secondlife.com/browse/VWR-24487 and > https://jira.secondlife.com/browse/VWR-24522 > > What I did: > In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant > pointers to constants by search/replace. Then I tried to compile and added > const qualifiers in dependent code as needed to stop the compiler complaining. > > Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files > have been generated from the message template. Because this generation might > not have been a one-off thing, I changed the generating code, too, so it > won't override this change here when the generation happens the next time. > However, that part of the code is not called by Viewer, although the relevant > function — dump_prehash_files() — ends up in the Viewer binary. That function > probably gets called by the simulator, when one runs the latter with > -prehash. (See > https://bitbucket.org/lindenlab/viewer-development/src/fc7e5dcf3059/indra/llmessage/message.cpp#cl-2532 > ) > > > This addresses bug VWR-24487. > http://jira.secondlife.com/browse/VWR-24487 > > > Diffs > - > > doc/contributions.txt fc7e5dcf3059 > indra/llmessage/message.cpp fc7e5dcf3059 > indra/llmessage/message_prehash.h fc7e5dcf3059 > indra/llmessage/message_prehash.cpp fc7e5dcf3059 > indra/llprimitive/llprimitive.h fc7e5dcf3059 > indra/llprimitive/llprimitive.cpp fc7e5dcf3059 > indra/llprimitive/llvolumemessage.h fc7e5dcf3059 > indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 > indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 > indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 > > Diff: http://codereview.secondlife.com/r/100/diff > > > Testing > --- > > Compiled (standalone, 64bit Linux) with and without LL_TESTS. > Started the viewer, logged in, walked and flew around a bit. Everything seems > to work. > > > Locally set _PREHASH_AgentData and _PREHASH_AgentID to (char const*)0x1 in > indra/llui/tests/llurlentry_stub.cpp and > indra/newview/tests/llremoteparcelrequest_test.cpp to verify they actually > are never dereferenced, even when not NULL, so that using NULL pointers > instead of place holder data won't change what code paths gets tested. Both > tests binaries executed without crashes and all the contained tests passed. > > Locally invoked start_messaging_system() with b_dump_prehash_file == true > instead of FALSE, to see what would be generated after my change to > dump_prehash_files(). > The message_prehash.(h|cpp) generated by that had the correct type qualifiers > and formatting, but some lines were removed or added compared to the modified > files from the source tree. That probably means that the files aren't fully > synchronized with the message template file in the source tree. Because the > "added" constants are spread all over the file, while the "removed" ones were > at the end, I'd wager that message_prehash.(h|cpp) in the viewer source tree > are actually more up-to-date than the message template file in the source > tree. > > > Thanks, > > Boroondas > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/126/ --- Review request for Viewer. Summary --- Changed displaying the permissions of inventory items inside an object to show the permissions which will be granted to the next owner of the item. The permissions affected by this issue can be seen in Content tab of Tools floater which is open by selecting Edit in object's context menu. If agent can't perform certain actions on the item a respective suffix will be added to the item's name e.g. (no copy), (no modify) or(no transfer). This issue affects viewer 1.23 too. Could it be expected behavior? This addresses bug STORM-379. http://jira.secondlife.com/browse/STORM-379 Diffs - indra/newview/llpanelobjectinventory.cpp b542f8134a2b Diff: http://codereview.secondlife.com/r/126/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-610 Changes to Environment Editor: water color change is not saved
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/125/#review264 --- Ship it! Looks good to me. Seems that adding two more setting were necessary while editor presets are not persistent across sessions. - Seth On Jan. 27, 2011, 1:20 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/125/ > --- > > (Updated Jan. 27, 2011, 1:20 p.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > --- > > Now when you change water color or density, the changes are saved until you > switch to another water preset. > > > This addresses bug STORM-610. > http://jira.secondlife.com/browse/STORM-610 > > > Diffs > - > > indra/newview/app_settings/settings.xml b542f8134a2b > indra/newview/llwaterparammanager.h b542f8134a2b > indra/newview/llwaterparammanager.cpp b542f8134a2b > > Diff: http://codereview.secondlife.com/r/125/diff > > > Testing > --- > > Played with presets and sliders. The new behavior seems fine to me, although > it may be confusing that basic water settings are persistent, while sky > settings aren't. > > While working on this bug I've almost (~80%) implemented STORM-326 > (Persistent water/sky settings), so if anyone is interested I'd be happy to > complete that work. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-316) Debug: Inventory.Folders by Name/Sort by Date/Sort by Name/System Folders to Top Do not apply and settings changes do not persist after relogging
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/128/ --- Review request for Viewer and Vadim ProductEngine. Summary --- - Added "Sort Folders Always by Name" setting. - Removed unused settings Inventory.Folders by Name/Sort by Date/Sort by Name/System Folders to Top. This addresses bug STORM-316. http://jira.secondlife.com/browse/STORM-316 Diffs - indra/newview/llpanelmaininventory.cpp b542f8134a2b indra/newview/skins/default/xui/en/menu_inventory_gear_default.xml b542f8134a2b Diff: http://codereview.secondlife.com/r/128/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Added "sort folders by name" option to inventory menu.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/130/#review285 --- The code looks good but I've uploaded nearly the same patch a day before: https://codereview.secondlife.com/r/128/. It is related to STORM-316 and includes some other code cleanup needed for that issue. It also adds "sort folders by name" option to inventory menu so perhaps we should go for my patch? - Seth On Jan. 29, 2011, 1:55 p.m., Kiptic Horsley wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/130/ > --- > > (Updated Jan. 29, 2011, 1:55 p.m.) > > > Review request for Viewer. > > > Summary > --- > > The constants SO_FOLDERS_BY_NAME (llinventoryfilter.h line 71) and > sort_folders_by_name (llpanelmaininventory.cpp line 125) already existed, so > added an option to use them to the inventory menu > (menu_inventory_gear_default.xml) and updated llpanelmaininventory.cpp to > handle the new option. > > > This addresses bug STORM-219. > http://jira.secondlife.com/browse/STORM-219 > > > Diffs > - > > indra/newview/llpanelmaininventory.cpp fe7fe04ccc9a > indra/newview/skins/default/xui/en/menu_inventory_gear_default.xml > fe7fe04ccc9a > > Diff: http://codereview.secondlife.com/r/130/diff > > > Testing > --- > > > Thanks, > > Kiptic > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-433) Friendship offer shifted up and placed over "Second Life" text
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/138/ --- Review request for Viewer. Summary --- Fixed reshaping notification panel with friendship offer when it is inserted into IM chat. This addresses bug STORM-433. http://jira.secondlife.com/browse/STORM-433 Diffs - indra/newview/llchathistory.cpp 2fe9d48e5881 indra/newview/lltoastnotifypanel.cpp 2fe9d48e5881 Diff: http://codereview.secondlife.com/r/138/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-379) Content permissions aren't refreshed in the "Buy copy of" floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/126/#review330 --- Closing this request for now because it is meant to be fix the other way. See STORM-379. - Seth On Jan. 27, 2011, 4:05 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/126/ > --- > > (Updated Jan. 27, 2011, 4:05 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Changed displaying the permissions of inventory items inside an object to > show the permissions which will be granted to the next owner of the item. > > The permissions affected by this issue can be seen in Content tab of Tools > floater which is open by selecting Edit in object's context menu. If agent > can't perform certain actions on the item a respective suffix will be added > to the item's name e.g. (no copy), (no modify) or(no transfer). > > This issue affects viewer 1.23 too. Could it be expected behavior? > > > This addresses bug STORM-379. > http://jira.secondlife.com/browse/STORM-379 > > > Diffs > - > > indra/newview/llpanelobjectinventory.cpp b542f8134a2b > > Diff: http://codereview.secondlife.com/r/126/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-680 (Avaline callers are added to the Recent list)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/146/#review349 --- Ship it! - Seth On Feb. 8, 2011, 11:26 a.m., Paul ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/146/ > --- > > (Updated Feb. 8, 2011, 11:26 a.m.) > > > Review request for Viewer. > > > Summary > --- > > - When accepting an avaline call, add a caller to the recent list as > AvalineListItem > > - When adding item to the LLRecentPeople, check whether item with the same > phone number exists and delete it if exists. This is need to avoid > duplication in the Recent list of the panel People. > > > This addresses bug STORM-680. > http://jira.secondlife.com/browse/STORM-680 > > > Diffs > - > > indra/newview/llavatarlist.h 33fc9ed99d29 > indra/newview/llavatarlist.cpp 33fc9ed99d29 > indra/newview/llrecentpeople.h 33fc9ed99d29 > indra/newview/llrecentpeople.cpp 33fc9ed99d29 > indra/newview/llvoicechannel.h 33fc9ed99d29 > indra/newview/llvoicechannel.cpp 33fc9ed99d29 > > Diff: http://codereview.secondlife.com/r/146/diff > > > Testing > --- > > > Thanks, > > Paul > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-949) please remove actual usernames from XUI files
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/151/ --- Review request for Viewer. Summary --- Actual usernames are replaced with "TestString PleaseIgnore" in EN locale with setting translate="false" flag for affected widgets. Translated phrases with actual usernames are removed from XUI files in other locales. This addresses bug STORM-949. http://jira.secondlife.com/browse/STORM-949 Diffs - indra/newview/skins/default/xui/da/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/da/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/da/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/da/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/da/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/da/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/da/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/de/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/de/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/de/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/de/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/de/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_chat_header.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_instant_message.xml 58fdb5218596 indra/newview/skins/default/xui/de/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/de/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/en/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/en/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/en/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/en/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/en/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_chat_header.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_instant_message.xml 58fdb5218596 indra/newview/skins/default/xui/en/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/en/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/es/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/es/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/es/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/es/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/es/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/es/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/es/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/fr/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/fr/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/fr/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/fr/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/fr/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_chat_header.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_edit_profile.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_instant_message.xml 58fdb5218596 indra/newview/skins/default/xui/fr/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/fr/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/it/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/it/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/it/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/it/panel_profile_view.xml 58fdb5218596 indra/newview/skins/default/xui/it/sidepanel_task_info.xml 58fdb5218596 indra/newview/skins/default/xui/ja/floater_about_land.xml 58fdb5218596 indra/newview/skins/default/xui/ja/floater_inventory_item_properties.xml 58fdb5218596 indra/newview/skins/default/xui/ja/floater_tools.xml 58fdb5218596 indra/newview/skins/default/xui/ja/inspect_avatar.xml 58fdb5218596 indra/newview/skins/default/xui/ja/inspect_group.xml 58fdb5218596 indra/newview/skins/default/xui/ja/panel_activeim_row.xml 58fdb5218596 indra/newview/skins/default/xui/ja/panel_chat_header.xml 58fdb5218596 indr
[opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/ --- Review request for Viewer. Summary --- - Added creating own calling card for the user to be able to share it with other residents. - Moved calling cards synchronization with friends list to the viewer start up. Previously synchronized upon opening the Friends tab in People side panel. - Calling cards for non-friends are not removed upon calling cards synchronization with friends list. - Enabled "Share" menu item for calling cards in inventory. This addresses bug STORM-28. http://jira.secondlife.com/browse/STORM-28 Diffs - indra/newview/llfriendcard.h c10d5e37db1e indra/newview/llfriendcard.cpp c10d5e37db1e indra/newview/llinventoryfunctions.cpp c10d5e37db1e indra/newview/llpanelpeople.cpp c10d5e37db1e Diff: http://codereview.secondlife.com/r/159/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1015) Unable to select right Login Landmark when it's name is not unique
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/165/ --- Review request for Viewer. Summary --- Fixed the ability to select an item from combo list if its name is not unique. Updating combo box label upon list item selection does not search the item by label but takes the label of currently selected item instead. This addresses bug STORM-1015. http://jira.secondlife.com/browse/STORM-1015 Diffs - indra/llui/llcombobox.h 1bc100746447 indra/llui/llcombobox.cpp 1bc100746447 Diff: http://codereview.secondlife.com/r/165/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/ --- Review request for Viewer. Summary --- Fixed text editor to display the embedded widgets only if they are in the currently visible area of a text document. This addresses bug STORM-721. http://jira.secondlife.com/browse/STORM-721 Diffs - indra/llui/lltextbase.cpp 767feb16f05f Diff: http://codereview.secondlife.com/r/169/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
> On March 1, 2011, 4:01 p.m., Boroondas Gupte wrote:
> > indra/llui/lltextbase.cpp, lines 1044-1052
> > <http://codereview.secondlife.com/r/169/diff/1/?file=1014#file1014line1044>
> >
> > Only tangent to your code, but is the scoping (the "{" and "}") here
> > doing anything useful? (It causes the "clip" object to be destructed one
> > line earlier, but is that the intention?)
> >
> > Also, it seems the "clip" object is never used. Does it do all its work
> > in its constructor?
The clip object here does all its work in the constructor (see usage example in
lllocalcliprect.h) - it clips the area inside which GL objects are rendered.
I tried to change the logic as little as possible so I moved the call to
LLUICtrl::draw() to render the document view after drawText() is called to
avoid possible blinking caused by hiding some of the embedded widgets. In case
when LLUICtrl::draw() is called prior to drawText() some embedded widgets
located outside visible document area will appear for a single frame before
they are hidden in drawText().
- Seth
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/169/#review398
---
On March 1, 2011, 1:53 p.m., Seth ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/169/
> ---
>
> (Updated March 1, 2011, 1:53 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Fixed text editor to display the embedded widgets only if they are in the
> currently visible area of a text document.
>
>
> This addresses bug STORM-721.
> http://jira.secondlife.com/browse/STORM-721
>
>
> Diffs
> -
>
> indra/llui/lltextbase.cpp 767feb16f05f
>
> Diff: http://codereview.secondlife.com/r/169/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Seth
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/ --- (Updated March 2, 2011, 8:47 a.m.) Review request for Viewer. Changes --- Corrected spelling. Summary --- - Added creating own calling card for the user to be able to share it with other residents. - Moved calling cards synchronization with friends list to the viewer start up. Previously synchronized upon opening the Friends tab in People side panel. - Calling cards for non-friends are not removed upon calling cards synchronization with friends list. - Enabled "Share" menu item for calling cards in inventory. This addresses bug STORM-28. http://jira.secondlife.com/browse/STORM-28 Diffs (updated) - indra/newview/llfriendcard.h 767feb16f05f indra/newview/llfriendcard.cpp 767feb16f05f indra/newview/llinventoryfunctions.cpp 767feb16f05f indra/newview/llpanelpeople.cpp 767feb16f05f Diff: http://codereview.secondlife.com/r/159/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-28) As a User, I want the ability to send my calling card to others
> On March 1, 2011, 7:04 p.m., Merov Linden wrote: > > I've nothing against lazy evaluation (I actually like that) but I don't > > like "static bool" showing up in the middle of the code to execute a piece > > of initialization once. Is that really something that should be done *once* > > per instance of the application or *once* per instantiation of the object? > > I'd prefer to have that synchronization done in the constructor or in an > > init method or at least have the bool a class or object member (as > > adequate) that's set to true on instantiation. The code with "static bool" is not new, I've just moved it to sync the calling card with friends list on viewer start up. LLInventoryFriendCardObserver::changed() is used to make sure the inventory became usable since the viewer had started, so this is not a part of LLInventoryFriendCardObserver initialization but rather an action that should be taken once per viewer session. When working on the patch I didn't replace this static with a member because it was not meant to be used elsewhere. - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/159/#review401 --- On March 2, 2011, 8:47 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/159/ > --- > > (Updated March 2, 2011, 8:47 a.m.) > > > Review request for Viewer. > > > Summary > --- > > - Added creating own calling card for the user to be able to share it with > other residents. > - Moved calling cards synchronization with friends list to the viewer start > up. Previously synchronized upon opening the Friends tab in People side panel. > - Calling cards for non-friends are not removed upon calling cards > synchronization with friends list. > - Enabled "Share" menu item for calling cards in inventory. > > > This addresses bug STORM-28. > http://jira.secondlife.com/browse/STORM-28 > > > Diffs > - > > indra/newview/llfriendcard.h 767feb16f05f > indra/newview/llfriendcard.cpp 767feb16f05f > indra/newview/llinventoryfunctions.cpp 767feb16f05f > indra/newview/llpanelpeople.cpp 767feb16f05f > > Diff: http://codereview.secondlife.com/r/159/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
> On March 3, 2011, 11:45 a.m., Richard Nelson wrote: > > indra/llui/lltextbase.cpp, line 604 > > <http://codereview.secondlife.com/r/169/diff/1/?file=1014#file1014line604> > > > > this will still display views that are partially outside of the visible > > rect > > > > what you want to do iscall mDocumentView->draw() inside the block that > > has the clip operation and then hide the mDocumentView when calling > > LLUICtrl::draw. > > > > The clip rect in the block with drawText() call is not enabled for the editors without a scroller and even enabling it and calling mDocumentView->draw() inside that block cuts off the bottom of the last visible line of text (see screenshot at https://jira.secondlife.com/secure/attachment/48565/clipped_text.png). With allow_scroll="false" & clip_partial="true" settings for the editor we lose one text line and if there are icons on the first line they will be clipped anyway because the top of such icons exceeds the top limit of the visible rect. - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review409 --- On March 1, 2011, 1:53 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/169/ > --- > > (Updated March 1, 2011, 1:53 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed text editor to display the embedded widgets only if they are in the > currently visible area of a text document. > > > This addresses bug STORM-721. > http://jira.secondlife.com/browse/STORM-721 > > > Diffs > - > > indra/llui/lltextbase.cpp 767feb16f05f > > Diff: http://codereview.secondlife.com/r/169/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/ --- (Updated March 4, 2011, 10:30 a.m.) Review request for Viewer and Richard Nelson. Changes --- Added Richard Nelson to reviewers. Richard, please, see the comment above. Should we hide all views which are partially outside of the visible rect? Summary --- Fixed text editor to display the embedded widgets only if they are in the currently visible area of a text document. This addresses bug STORM-721. http://jira.secondlife.com/browse/STORM-721 Diffs - indra/llui/lltextbase.cpp 767feb16f05f Diff: http://codereview.secondlife.com/r/169/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/179/#review439
---
Ship it!
- Seth
On March 7, 2011, 9:16 a.m., Vadim ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/179/
> ---
>
> (Updated March 7, 2011, 9:16 a.m.)
>
>
> Review request for Viewer and Seth ProductEngine.
>
>
> Summary
> ---
>
> Let the user know what's wrong with external editor.
>
> Added meaningful messages for the following errors:
> * Editor not specified.
> * Error parsing command line.
> * Specified binary not found.
> * Editor failed to run.
>
> All the messages are translatable.
>
>
> This addresses bug STORM-1018.
> http://jira.secondlife.com/browse/STORM-1018
>
>
> Diffs
> -
>
> indra/newview/llexternaleditor.h ef2df52563bb
> indra/newview/llexternaleditor.cpp ef2df52563bb
> indra/newview/llfloateruipreview.cpp ef2df52563bb
> indra/newview/llpreviewscript.cpp ef2df52563bb
> indra/newview/skins/default/xui/en/floater_ui_preview.xml ef2df52563bb
> indra/newview/skins/default/xui/en/panel_script_ed.xml ef2df52563bb
> indra/newview/skins/default/xui/en/strings.xml ef2df52563bb
>
> Diff: http://codereview.secondlife.com/r/179/diff
>
>
> Testing
> ---
>
> Test cases:
> 1. Use a path containing spaces without enclosing it with double quotes
> (/path to/editor).
>Expected: the "not found" message.
> 2. Specify empty path ().
>Expected: the "not found" message.
> 3. Try using an odd number of double quotes ("/path to/editor "%s").
>Expected: the "parse error" message.
> 4. Specifying a nonexistent editor (/non/existent/editor).
>Expected: the "not found" message.
> 5. Specify a valid editor path (/usr/bin/editor).
>Expected: the editor is executed.
>
> The command can be specified with the ExternalEditor debug setting or an
> environment variable: LL_SCRIPT_EDITOR for script editor and LL_XUI_EDITOR
> for the XUI preview tool. In the latter case you can also override the
> command via the "Editor Path" floater input field.
>
>
> Thanks,
>
> Vadim
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- Review request for Viewer. Summary --- Fixed "More" link being toggled in expandable textbox after reshaping. This addresses bug STORM-250. http://jira.secondlife.com/browse/STORM-250 Diffs - indra/newview/llexpandabletextbox.h aed94e854443 indra/newview/llexpandabletextbox.cpp aed94e854443 Diff: http://codereview.secondlife.com/r/198/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- (Updated March 15, 2011, 9:21 a.m.) Review request for Viewer. Changes --- Fixed a bug in previous patch version. Summary --- Fixed "More" link being toggled in expandable textbox after reshaping. This addresses bug STORM-250. http://jira.secondlife.com/browse/STORM-250 Diffs (updated) - indra/newview/llexpandabletextbox.h b761ed94eb26 indra/newview/llexpandabletextbox.cpp b761ed94eb26 Diff: http://codereview.secondlife.com/r/198/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- (Updated March 16, 2011, 5:19 p.m.) Review request for Viewer. Summary --- Fixed "More" link being toggled in expandable textbox after reshaping. This addresses bug STORM-250. http://jira.secondlife.com/browse/STORM-250 Diffs (updated) - indra/newview/llexpandabletextbox.h b761ed94eb26 indra/newview/llexpandabletextbox.cpp b761ed94eb26 Diff: http://codereview.secondlife.com/r/198/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater
On March 16, 2011, 7:30 a.m., Seth ProductEngine wrote:
> > So the new method might become something like
> >
> > void LLExpandableTextBox::LLTextBoxEx::hideOrShowExpandTextAsNeeded()
> > {
> > // Restore the text box contents to calculate the text height properly,
> > // otherwise if a part of the text is hidden under "More" link
> > // getTextPixelHeight() returns only the height of currently visible
> > text
> > // including the "More" link.
> > hideExpandText();
> >
> > // Show the expander if we need it, depending on text
> > // contents height. If not, keep it hidden.
> > if (getTextPixelHeight() > getRect().getHeight())
> > {
> > showExpandText();
> > }
> > }
Yes, there's no need to call hideExpandText() for two times is a row. I like
this version of hideOrShowExpandTextAsNeeded(). Thanks!
- Seth
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/#review465
---
On March 16, 2011, 5:19 p.m., Seth ProductEngine wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/198/
> ---
>
> (Updated March 16, 2011, 5:19 p.m.)
>
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> Fixed "More" link being toggled in expandable textbox after reshaping.
>
>
> This addresses bug STORM-250.
> http://jira.secondlife.com/browse/STORM-250
>
>
> Diffs
> -
>
> indra/newview/llexpandabletextbox.h b761ed94eb26
> indra/newview/llexpandabletextbox.cpp b761ed94eb26
>
> Diff: http://codereview.secondlife.com/r/198/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Seth
>
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1016 Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/175/#review477 --- Ship it! Docking the side panels on ctrl+shift+w seems to be the appropriate way to fix this crash. - Seth On March 17, 2011, 9:24 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/175/ > --- > > (Updated March 17, 2011, 9:24 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > --- > > Reason: The shortcut closes all floaters, including those wrapping undocked > sidepanels. > The sidepanels get destroyed as well, while they are still referenced by the > side tray. > > Fix: Dock (i.e. move to side tray) the sidepanel before its floater gets > destroyed. > > > This addresses bug STORM-1016. > http://jira.secondlife.com/browse/STORM-1016 > > > Diffs > - > > indra/llui/llfloater.h ef2df52563bb > indra/llui/llfloater.cpp ef2df52563bb > indra/newview/llsidetray.cpp ef2df52563bb > > Diff: http://codereview.secondlife.com/r/175/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- (Updated March 17, 2011, 4:19 p.m.) Review request for Viewer. Changes --- Updated comments, added jira ticket reference. Summary --- Fixed "More" link being toggled in expandable textbox after reshaping. This addresses bug STORM-250. http://jira.secondlife.com/browse/STORM-250 Diffs (updated) - indra/newview/llexpandabletextbox.h d32171ae1288 indra/newview/llexpandabletextbox.cpp d32171ae1288 Diff: http://codereview.secondlife.com/r/198/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
> On March 3, 2011, 11:45 a.m., Richard Nelson wrote: > > indra/llui/lltextbase.cpp, line 604 > > <http://codereview.secondlife.com/r/169/diff/1/?file=1014#file1014line604> > > > > this will still display views that are partially outside of the visible > > rect > > > > what you want to do iscall mDocumentView->draw() inside the block that > > has the clip operation and then hide the mDocumentView when calling > > LLUICtrl::draw. > > > > > > Seth ProductEngine wrote: > The clip rect in the block with drawText() call is not enabled for the > editors without a scroller and even enabling it and calling > mDocumentView->draw() inside that block cuts off the bottom of the last > visible line of text (see screenshot at > https://jira.secondlife.com/secure/attachment/48565/clipped_text.png). > > With allow_scroll="false" & clip_partial="true" settings for the editor > we lose one text line and if there are icons on the first line they will be > clipped anyway because the top of such icons exceeds the top limit of the > visible rect. > > Richard Nelson wrote: > With allow_scroll="false" and clip_partial="true", you shouldn't lose a > line of text, so that sounds like the bug to fix. If icons on the first line > are being clipped, you could increase the v_pad attribute to leave enough > room, although the size of the icon should be accounted for in the text > layout, so that is either another bug or related to the first bug above. > > I'd strongly suggest fixing those issues instead of using your proposed > fix. Visibility of the text and widgets embedded within the text should be > handled in the same way if possible. > > I'll let you know if I find any obvious source of these problems. > > Applying clip_partial="true" does not clip the icons on the first line but clips the last line in case with the particular "user_details" textbox in avatar inspector because its height is less than the height of three text lines, but I think this is how "clip_partial" is supposed too work, so it's not a bug. It is the clip rect in LLTextBase::draw() that cuts the icons in the first line because they exceed the document view rect if no positive v_pad is applied. So I'm waiting for your fix. Thanks! - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review409 --- On March 4, 2011, 10:30 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/169/ > --- > > (Updated March 4, 2011, 10:30 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Fixed text editor to display the embedded widgets only if they are in the > currently visible area of a text document. > > > This addresses bug STORM-721. > http://jira.secondlife.com/browse/STORM-721 > > > Diffs > - > > indra/llui/lltextbase.cpp 767feb16f05f > > Diff: http://codereview.secondlife.com/r/169/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1086) Agent's own calling card created on startup is placed into Friends/All folder instead of Calling Cards
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/216/ --- Review request for Viewer and Vadim ProductEngine. Summary --- Agent's own calling card created on startup is placed into Calling Cards folder. If there is an agent's calling card found within Calling Cards and sub-folders no more copies of this calling card are created. This addresses bug STORM-1086. http://jira.secondlife.com/browse/STORM-1086 Diffs - indra/newview/llfriendcard.cpp 039e1f72b314 Diff: http://codereview.secondlife.com/r/216/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1097) Empty floater created upon docking Places side panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/219/ --- Review request for Viewer. Summary --- Fixed opening a floater containing a detached side bar tab. This addresses bug STORM-1097. http://jira.secondlife.com/browse/STORM-1097 Diffs - indra/newview/llsidetray.cpp a8639217816b Diff: http://codereview.secondlife.com/r/219/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/ --- Review request for Viewer. Summary --- First pass implementation of syncing the animations and sounds before the gesture starts playing. The actual playing of animations and sounds of a gesture starts only when all needed animations and sound files are loaded into viewer cache. This reduces the delay between animations and sounds meant to be played simultaneously but may increase the delay between the moment a gesture is triggered and the moment it starts playing. This addresses bug STORM-380. http://jira.secondlife.com/browse/STORM-380 Diffs - indra/newview/llgesturemgr.h 6c15f820c3b9 indra/newview/llgesturemgr.cpp 6c15f820c3b9 Diff: http://codereview.secondlife.com/r/231/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.h, lines 161-164
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1326#file1326line161>
> >
> > Please use tabs for indentation and spaces for alignment. (Here, that'd
> > be only one tab followed by 32 spaces.) Whatever you did here looks wrong
> > whether I set tab display length to 4 or 8.
Corrected indentation here and for the method declared above.
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.cpp, lines 536-537
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line536>
> >
> > If the iterator will not be used outside the loop, please declare it
> > with the assignment in the for's braces.
>
> Oz Linden wrote:
> I don't see any reason to make that distinction.
Seems like it may look confusing if the iterator is not used outside the loop,
so moved its declaration inside braces.
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.cpp, line 549
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line549>
> >
> > I'm not sure what you mean by "if it stops". Maybe that the currently
> > handled gesture step stops the animation? If so, maybe write
> >
> > // Don't request the animation if this step stops it or if it is
> > already in Static VFS
Corrected.
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.cpp, lines 582-587
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line582>
> >
> > Why are STEP_CHAT and STEP_WAIT mentioned when they don't do anything
> > and we do have a default step that also doesn't do anything?
> >
> > If all cases are supposed to be explicitly handled, we might want to
> > make sure of that with:
> > // [...]
> > case STEP_CHAT:
> > case STEP_WAIT:
> > {
> > break;
> > }
> > default:
> > {
> > // We should never get here.
> > llassert(false);
> > }
> > }
> >
> > (... or maybe just some terminal output.)
Added the STEP_EOF for a complete list of step types and a warning for the
default case.
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.cpp, lines 763-764
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line763>
> >
> > s/is/if/
Changed "is: to "if". Is that correct?
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.cpp, lines 765-766
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line765>
> >
> > Hmm ... so with the current change, a gesture's playback could
> > potentially be delayed forever due to assets for other gestures being
> > loaded?
For now starting each new gesture resets the list of pending assets downloads
so if the last started gesture's asset are loaded successfully the playback
will continue. This should probably need a better way to handle the cases of
some assets not being loaded due to some kind of error. The current behavior is
not suppressing the gesture playback due to any data loading delays. Should we
follow this behavior?
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote:
> > indra/newview/llgesturemgr.cpp, lines 1194-1197
> > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line1194>
> >
> > Can a gesture reference other asset types than animations and sounds?
> > And if it can, shouldn't those be removed from mLoadingAssets, too, once
> > loaded?
> >
> > If it can but shouldn't maybe some terminal output would be appropriate
> > here.
It shouldn't reference other asset types and there are specific callback
procedures to handle animation and sound assets so added an assert for the
default case.
- Seth
---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/#review506
---
On March 25, 2011, 5:33 p.m., Seth ProductEngine wrote:
>
> ---
Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played
> On March 28, 2011, 4:06 a.m., Oz Linden wrote: > > indra/newview/llgesturemgr.cpp, lines 572-578 > > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line572> > > > > Same possible race as above Moved inserting the id into the mLoadingAssets prior to requesting asset data. The getAssetData() request could potentially lead to memory leaks in some cases. Should this be a separate jira? - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review508 --- On March 25, 2011, 5:33 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/231/ > --- > > (Updated March 25, 2011, 5:33 p.m.) > > > Review request for Viewer. > > > Summary > --- > > First pass implementation of syncing the animations and sounds before the > gesture starts playing. > The actual playing of animations and sounds of a gesture starts only when all > needed animations and sound files are loaded into viewer cache. This reduces > the delay between animations and sounds meant to be played simultaneously but > may increase the delay between the moment a gesture is triggered and the > moment it starts playing. > > > This addresses bug STORM-380. > http://jira.secondlife.com/browse/STORM-380 > > > Diffs > - > > indra/newview/llgesturemgr.h 6c15f820c3b9 > indra/newview/llgesturemgr.cpp 6c15f820c3b9 > > Diff: http://codereview.secondlife.com/r/231/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/ --- (Updated March 28, 2011, 12:21 p.m.) Review request for Viewer. Changes --- Fixes according to the feedback on revision 1. Summary --- First pass implementation of syncing the animations and sounds before the gesture starts playing. The actual playing of animations and sounds of a gesture starts only when all needed animations and sound files are loaded into viewer cache. This reduces the delay between animations and sounds meant to be played simultaneously but may increase the delay between the moment a gesture is triggered and the moment it starts playing. This addresses bug STORM-380. http://jira.secondlife.com/browse/STORM-380 Diffs (updated) - indra/newview/llgesturemgr.h b3cfba00a29b indra/newview/llgesturemgr.cpp b3cfba00a29b Diff: http://codereview.secondlife.com/r/231/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.cpp, lines 765-766 > > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line765> > > > > Hmm ... so with the current change, a gesture's playback could > > potentially be delayed forever due to assets for other gestures being > > loaded? > > Seth ProductEngine wrote: > For now starting each new gesture resets the list of pending assets > downloads so if the last started gesture's asset are loaded successfully the > playback will continue. This should probably need a better way to handle the > cases of some assets not being loaded due to some kind of error. The current > behavior is not suppressing the gesture playback due to any data loading > delays. Should we follow this behavior? > > Boroondas Gupte wrote: > Ah, I thought assets would only be removed from the list when they > finished loading. If it were so, someone always triggering a new gesture > (with new assets) before all previously queued assets have been loaded could > thus prevent the list from becoming empty and thereby delay playback of all > gestures forever, even although assets for most gestures would already be > available. This could happen even in the case of no assets failing to load. > > Emptying the list (is that line 532 in the new > indra/newview/llgesturemgr.cpp ?) when a new gesture comes in avoids this. > Off course it isn't really the Right Thing To Do(TM), but if the behavior > will in no case be worse than the current code, we can go for this until > pending downloads are checked separately for each queued gesture. The latter > can probably be achieved by maintaining a separate list of pending assets for > each gesture and start playing a gesture when its own list has become empty. Yes, it's line 532 but probably there should be a loading assets map that holds assets for each gesture. > On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.cpp, lines 1194-1197 > > <http://codereview.secondlife.com/r/231/diff/1/?file=1327#file1327line1194> > > > > Can a gesture reference other asset types than animations and sounds? > > And if it can, shouldn't those be removed from mLoadingAssets, too, once > > loaded? > > > > If it can but shouldn't maybe some terminal output would be appropriate > > here. > > Seth ProductEngine wrote: > It shouldn't reference other asset types and there are specific callback > procedures to handle animation and sound assets so added an assert for the > default case. > > Boroondas Gupte wrote: > Is this already checked somewhere before here, or could a bogus gesture > trigger that assert? If the latter, a clean-up step and some terminal output > would be friendlier than an assert, as we don't want the ability to 'shoot > down' a Viewer by providing invalid data from remote. That assert could only be triggered by requesting an asset type other that animation or sound with onAssetLoadComplete() callback, not by the invalid data from server. This callback can only handle those two types, for other types we don't know how to clean up a void pointer to user_data arg. - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review506 --- On March 28, 2011, 12:21 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/231/ > --- > > (Updated March 28, 2011, 12:21 p.m.) > > > Review request for Viewer. > > > Summary > --- > > First pass implementation of syncing the animations and sounds before the > gesture starts playing. > The actual playing of animations and sounds of a gesture starts only when all > needed animations and sound files are loaded into viewer cache. This reduces > the delay between animations and sounds meant to be played simultaneously but > may increase the delay between the moment a gesture is triggered and the > moment it starts playing. > > > This addresses bug STORM-380. > http://jira.secondlife.com/browse/STORM-380 > > > Diffs > - > > indra/newview/llgesturemgr.h b3cfba00a29b > indra/newview/llgesturemgr.cpp b3cfba00a29b > > Diff: http://codereview.secondlife.com/r/231/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/ --- (Updated March 31, 2011, 10:18 a.m.) Review request for Viewer. Changes --- - Fixed checking the pending downloads for each playing gesture separately. - Fixed calling assets callback to clean up the void pointer in getAssetData() and avoid potential memory leaks. Summary (updated) --- Added syncing animations and sounds before the gesture starts playing. The actual playing of animations and sounds of a gesture starts only when all needed animations and sound files are loaded into viewer cache. This reduces the delay between animations and sounds meant to be played simultaneously but may increase the delay between the moment a gesture is triggered and the moment it starts playing. Fixed calling assets callback to clean up the void pointer in getAssetData() and avoid potential memory leaks. This addresses bug STORM-380. http://jira.secondlife.com/browse/STORM-380 Diffs (updated) - indra/llmessage/llassetstorage.cpp d30636c2a83a indra/newview/llgesturemgr.h d30636c2a83a indra/newview/llgesturemgr.cpp d30636c2a83a Diff: http://codereview.secondlife.com/r/231/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/ --- Review request for Viewer. Summary --- Fixed IM history to use the resident's user name for the log file name. Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers. This addresses bug STORM-941. http://jira.secondlife.com/browse/STORM-941 Diffs - indra/llui/llurlaction.h d30636c2a83a indra/llui/llurlaction.cpp d30636c2a83a indra/newview/llgiveinventory.cpp d30636c2a83a indra/newview/llimview.cpp d30636c2a83a indra/newview/llnotificationhandler.h d30636c2a83a indra/newview/llnotificationhandlerutil.cpp d30636c2a83a Diff: http://codereview.secondlife.com/r/249/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/250/ --- Review request for Viewer. Summary --- Fix for text box clipping in a textbox without a scroller. Published on behalf of Richard Linden: This patch makes clipping work consistently with text and embedded widgets. The widgets will only be displayed if the corresponding text they are embedded in is displayed. There is also a new param "clip" for text widgets that can be used to disable clipping entirely. I introduced this as a potential work around due to the fact that we *used* to assume that text was never clipped in the vertical direction unless we had scrolling turned on. This hasn't been the case for over a year, but now we can selectively turn off vertical text clipping with (clip="false") if we have to. This addresses bug STORM-721. http://jira.secondlife.com/browse/STORM-721 Diffs - indra/llui/lltextbase.h d30636c2a83a indra/llui/lltextbase.cpp d30636c2a83a Diff: http://codereview.secondlife.com/r/250/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
> On March 16, 2011, 12:39 a.m., Richard Nelson wrote: > > So I've found some underlying problems with text extents measurement and > > clipping and I'm working on a fix now...hopefully I'll have something > > tomorrow Published the patch by Richard Nelson at https://codereview.secondlife.com/r/250/ - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/169/#review463 --- On March 4, 2011, 10:30 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/169/ > --- > > (Updated March 4, 2011, 10:30 a.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Fixed text editor to display the embedded widgets only if they are in the > currently visible area of a text document. > > > This addresses bug STORM-721. > http://jira.secondlife.com/browse/STORM-721 > > > Diffs > - > > indra/llui/lltextbase.cpp 767feb16f05f > > Diff: http://codereview.secondlife.com/r/169/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.
> On April 5, 2011, 9:02 a.m., Wolfpup Lowenhar wrote: > > indra/llui/llurlaction.h, line 81 > > <http://codereview.secondlife.com/r/249/diff/1/?file=1396#file1396line81> > > > > Having this here looks to be the best way to prevent generating a > > Legacy named P2P system message during said conversation that has been > > started by a person that DOSE NOT have Display Names turned on as there is > > one SYSTEM message that would seem to be coming from no where and this > > looks like it is its source. I guess Vadim is right about moving the method. Seems that just stripping a UUID part of a given SLURL doesn't really belong here, but moving it won't affect the patch functionality. Wolfpup, do you have some objections against moving the method or some suggestions about the functionality changes? - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/#review550 --- On April 4, 2011, 4:30 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/249/ > --- > > (Updated April 4, 2011, 4:30 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed IM history to use the resident's user name for the log file name. > Added conversions from legacy names or SLURLs with avatar id to the user > names in cases of logging P2P sessions and inventory offers. > > > This addresses bug STORM-941. > http://jira.secondlife.com/browse/STORM-941 > > > Diffs > - > > indra/llui/llurlaction.h d30636c2a83a > indra/llui/llurlaction.cpp d30636c2a83a > indra/newview/llgiveinventory.cpp d30636c2a83a > indra/newview/llimview.cpp d30636c2a83a > indra/newview/llnotificationhandler.h d30636c2a83a > indra/newview/llnotificationhandlerutil.cpp d30636c2a83a > > Diff: http://codereview.secondlife.com/r/249/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-721) Information about resident is displayed incorrectly in mini-inspector if there are any resident or group SLURLs
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/250/#review555 --- Ship it! - Seth On April 5, 2011, 9 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/250/ > --- > > (Updated April 5, 2011, 9 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Fix for text box clipping in a textbox without a scroller. > > Published on behalf of Richard Linden: > This patch makes clipping work consistently with text and embedded widgets. > The widgets will only be displayed if the corresponding text they are > embedded in is displayed. There is also a new param "clip" for text widgets > that can be used to disable clipping entirely. I introduced this as a > potential work around due to the fact that we *used* to assume that text was > never clipped in the vertical direction unless we had scrolling turned on. > This hasn't been the case for over a year, but now we can selectively turn > off vertical text clipping with (clip="false") if we have to. > > > This addresses bug STORM-721. > http://jira.secondlife.com/browse/STORM-721 > > > Diffs > - > > indra/llui/lltextbase.h d30636c2a83a > indra/llui/lltextbase.cpp d30636c2a83a > > Diff: http://codereview.secondlife.com/r/250/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/ --- (Updated April 7, 2011, 4:16 p.m.) Review request for Viewer. Changes --- Fixed resolving IM session participants names prior to writing messages to the log file to avoid temporary log files which could possibly appear if user names were not resolved before the first message had been written to the log. Summary --- Fixed IM history to use the resident's user name for the log file name. Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers. This addresses bug STORM-941. http://jira.secondlife.com/browse/STORM-941 Diffs (updated) - indra/newview/llgiveinventory.cpp d30636c2a83a indra/newview/llimview.h d30636c2a83a indra/newview/llimview.cpp d30636c2a83a indra/newview/llnotificationhandler.h d30636c2a83a indra/newview/llnotificationhandlerutil.cpp d30636c2a83a Diff: http://codereview.secondlife.com/r/249/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1118 Viewer crashes when user tries to upload image without JFIF header
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/255/#review574 --- Ship it! Looks good to me. - Seth On April 7, 2011, 4:20 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/255/ > --- > > (Updated April 7, 2011, 4:20 p.m.) > > > Review request for Viewer. > > > Summary > --- > > * Added checks for image file contents not matching the file extension (e.g. > a bitmap named file.jpg). > * Added checks for abnormally short files to avoid crashes when parsing them. > > > This addresses bug STORM-1118. > http://jira.secondlife.com/browse/STORM-1118 > > > Diffs > - > > indra/llimage/llimagedimensionsinfo.h 33ca961b0870 > indra/llimage/llimagedimensionsinfo.cpp 33ca961b0870 > > Diff: http://codereview.secondlife.com/r/255/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1042) Disabled 'Save' button at the 'Create Landmark' panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/261/ --- Review request for Viewer. Summary --- Fixed the inventory observers of newly added items. Removed pieces of code marked as fix for DEV-20328 but could not check for the regression. This addresses bug STORM-1042. http://jira.secondlife.com/browse/STORM-1042 Diffs - Diff: http://codereview.secondlife.com/r/261/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-1042) Disabled 'Save' button at the 'Create Landmark' panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/261/ --- (Updated April 8, 2011, 5 p.m.) Review request for Viewer. Summary --- Fixed the inventory observers of newly added items. Removed pieces of code marked as fix for DEV-20328 but could not check for the regression. This addresses bug STORM-1042. http://jira.secondlife.com/browse/STORM-1042 Diffs (updated) - indra/newview/llinventorymodel.h d30636c2a83a indra/newview/llinventorymodel.cpp d30636c2a83a indra/newview/llinventorymodelbackgroundfetch.cpp d30636c2a83a indra/newview/llinventoryobserver.h d30636c2a83a indra/newview/llinventoryobserver.cpp d30636c2a83a Diff: http://codereview.secondlife.com/r/261/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-1042) Disabled 'Save' button at the 'Create Landmark' panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/261/ --- (Updated April 11, 2011, 9:27 a.m.) Review request for Viewer. Summary (updated) --- Fixed the inventory observers of newly added items. The problem was caused by an outdated message name stored in LLInventoryObserver::mMessageName and not updated properly in LLInventoryModel::notifyObservers(). The message name used in LLInventoryAddedObserver::changed() was the name of the message most recently passed by LLInventoryModel::notifyObservers(), instead of the name of the latest actually received message. Using the most recent message name in this case fixed the problem. This addresses bug STORM-1042. http://jira.secondlife.com/browse/STORM-1042 Diffs - indra/newview/llinventorymodel.h d30636c2a83a indra/newview/llinventorymodel.cpp d30636c2a83a indra/newview/llinventorymodelbackgroundfetch.cpp d30636c2a83a indra/newview/llinventoryobserver.h d30636c2a83a indra/newview/llinventoryobserver.cpp d30636c2a83a Diff: http://codereview.secondlife.com/r/261/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/ --- (Updated April 13, 2011, 8:11 a.m.) Review request for Viewer. Changes --- Removed asynchronous writes to temporary IM log file depending on name cache responses. Looks like there is no need for requesting names from cache or the name is already in cache in some cases, so no need for a callback. Summary (updated) --- Fixed IM history to use the resident's user name for the log file name. Added conversions from legacy names or SLURLs with avatar id to the user names in cases of logging P2P sessions and inventory offers. Removed asynchronous writes to temporary IM log file depending on name cache responses. This addresses bug STORM-941. http://jira.secondlife.com/browse/STORM-941 Diffs (updated) - indra/newview/llgiveinventory.cpp 4b5d458c03e8 indra/newview/llimview.h 4b5d458c03e8 indra/newview/llimview.cpp 4b5d458c03e8 indra/newview/llnotificationhandlerutil.cpp 4b5d458c03e8 indra/newview/llviewermessage.cpp 4b5d458c03e8 Diff: http://codereview.secondlife.com/r/249/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-229) Loading Scripts takes a long time and stalls Viewer
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/273/ --- Review request for Viewer and Richard Nelson. Summary --- Partial fix for selected text indentation in script editor stalling the viewer: disabled updating text segments until all indentation commands are executed. Looks like the viewer is not stalled but the indentation still works rather slow. Diffs - indra/llui/lltexteditor.cpp 9c0506d10226 Diff: http://codereview.secondlife.com/r/273/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-320) Script Editor in Viewer 2.0+ "tabs" incorrectly
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/274/ --- Review request for Viewer and Richard Nelson. Summary --- Fixed navigation with arrow keys through the text with enabled word-wrapping. Steps to repro at https://jira.secondlife.com/browse/STORM-320?focusedCommentId=244113&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-244113 This addresses bug STORM-320. http://jira.secondlife.com/browse/STORM-320 Diffs - indra/llui/lltextbase.cpp 9c0506d10226 Diff: http://codereview.secondlife.com/r/274/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played
> On April 1, 2011, 4:22 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.cpp, lines 1215-1229 > > <http://codereview.secondlife.com/r/231/diff/2-3/?file=1347#file1347line1215> > > > > hasLoadingAssets calls set::find in a loop (which is logarithmic in the > > set's size) > > > > so we have N * M * log(L) behavior for update(). This might not be too > > bad, as the number of queued gestures N, the number of steps per gesture M > > and the number of loading assets L are probably all small most of the time, > > and the inner loop is exited via return once the first match has been > > found. But I still wonder whether it might pay off to e.g. make the > > gestures observers of their pending assets. > > > > Looks like making gestures observers of their pending assets will not allow to remove the nested loops completely. When an asset is loaded we still have to iterate through all the gestures for which this asset had been requested and remove it from each gesture's pending asset list. This also increases the memory usage because we store separate lists of assets which may have duplicates. Also making gesture an observer adds the need in tracking its lifetime. Deriving LLMultiGesture from boost::signals2::trackable for that purpose will require LLAssetStorage refactoring to use boost::signals2 for connecting the callbacks. > On April 1, 2011, 4:22 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.h, lines 168-170 > > <http://codereview.secondlife.com/r/231/diff/3/?file=1373#file1373line168> > > > > Shouldn't this be a (non-static) method of LLMulitGesture taking no > > argument, rather than a static member of LLGestureMgr taking a pointer to a > > gesture? > > > > Also, the gesture should not be changed by that, should it? If > > possible, make the argument type pointer-to-const (or, if you make it a > > method of LLMultiGesture as suggested, make it a const method). It could be a non-static method of LLMulitGesture if a gesture would be an observer of its own pending assets, or if a gesture would check pending assets from the list stored at LLGestureMgr. In this case the LLMulitGesture class becomes more complicated without any gain in performance because this is the same check that LLGestureMgr::hasLoadingAssets() does. - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review531 --- On March 31, 2011, 10:18 a.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/231/ > --- > > (Updated March 31, 2011, 10:18 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Added syncing animations and sounds before the gesture starts playing. > The actual playing of animations and sounds of a gesture starts only when all > needed animations and sound files are loaded into viewer cache. This reduces > the delay between animations and sounds meant to be played simultaneously but > may increase the delay between the moment a gesture is triggered and the > moment it starts playing. > > Fixed calling assets callback to clean up the void pointer in getAssetData() > and avoid potential memory leaks. > > > This addresses bug STORM-380. > http://jira.secondlife.com/browse/STORM-380 > > > Diffs > - > > indra/llmessage/llassetstorage.cpp d30636c2a83a > indra/newview/llgesturemgr.h d30636c2a83a > indra/newview/llgesturemgr.cpp d30636c2a83a > > Diff: http://codereview.secondlife.com/r/231/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (SH-1549) About land floater needs to be reconfigured to match the new accounting design
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/314/ --- Review request for Viewer. Summary --- SH-1549 WIP About Land floater reconfigured to match the new accounting design. - New About Land floater Objects tab XUI. - Support for both the new and the old accounting systems simultaneously. - Added accounting info observer to update the UI upon parcel quota information arrival. TODO: - Clean up the region caps usage. I couldn't find the region with working "AccountingParcel" and "AccountingSelection" caps to test the quota manager and to make sure which capability to use. - Make "Weight details..." button functional. This addresses bug SH-1549. Diffs - indra/newview/llaccountingquotamanager.h 292d11f88649 indra/newview/llaccountingquotamanager.cpp 292d11f88649 indra/newview/llfloaterland.h 292d11f88649 indra/newview/llfloaterland.cpp 292d11f88649 indra/newview/skins/default/xui/en/floater_about_land.xml 292d11f88649 Diff: http://codereview.secondlife.com/r/314/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Changes to fix CHOP-662.
> On June 21, 2011, 7:57 a.m., Alain Linden wrote: > > indra/llvfs/tests/lldiriterator_test.cpp, line 46 > > <http://codereview.secondlife.com/r/357/diff/1/?file=3024#file3024line46> > > > > Personally, I dislike referencing jira items in code comments. Its > > referencing something ephemeral in something that will long out live it. > > Boroondas Gupte wrote: > In general I'd agree, but here my interpretation was that this test was > inspired by a specific issue. Should in that case the whole issue description > be copied into the comment? > > Alain Linden wrote: > The way I see it, the code remains long after the jira is dead and > forgotten. As much as possible, code commentary should stand alone. This > test makes sense regardless of what jira inspired it, so why bother > mentioning it? Years from now a developer reading this code won't care about > the jira. That's my opinion. There is a test file where LLDirIterator is used: llvfs\tests\lldir_test.cpp. May be this unit test could be placed there? - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review795 --- On June 20, 2011, 8:21 p.m., Squire Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/357/ > --- > > (Updated June 20, 2011, 8:21 p.m.) > > > Review request for Viewer, Oz Linden, Seth ProductEngine, and Alain Linden. > > > Summary > --- > > Changes to fix CHOP-662. CHOP-662 was caused by the recent addition of > lldiriterator.cpp which is used to iterate over directories. It takes a mask > in the form of a glob string to use as a pattern for which files to iterate > over. > > Unfortunately, as originally implemented, it converted the glob to a regex > pattern without escaping any legal glob characters which are illegal regex > characters. As a result if the passed in mask was an illegal regex it would > fail and llerrs would cause a crash. > > In CHOP-662 this happens whenever a group name has, e.g. a '+' character at > the beginning. When logging in the viewer would attempt to load the group > chat log file which would result in a glob starting with a '+' character and > in turn to an illegal regex in lldiriterator. > > Also, the chat code was doing nothing to ensure that illegal glob characters > were not being passed to the lldiriterator constructor. > > > This addresses bug CHOP-662. > http://jira.secondlife.com/browse/CHOP-662 > > > Diffs > - > > doc/contributions.txt e8f2a53c3d6e > indra/llvfs/CMakeLists.txt e8f2a53c3d6e > indra/llvfs/lldiriterator.cpp e8f2a53c3d6e > indra/llvfs/tests/lldiriterator_test.cpp PRE-CREATION > indra/newview/lllogchat.cpp e8f2a53c3d6e > > Diff: http://codereview.secondlife.com/r/357/diff > > > Testing > --- > > Added a unit test for lldiriterator which checks for construction failures on > examples of the most common group names which were causing the crashes. > > > Thanks, > > Squire > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: Changes to fix CHOP-662.
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/357/#review803 --- Ship it! The glob to regex conversion was not initially supposed to accept user input as its argument that's why it lacked the checks for valid glob expressions. But now it looks like these checks are necessary for this case. - Seth On June 20, 2011, 8:21 p.m., Squire Linden wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/357/ > --- > > (Updated June 20, 2011, 8:21 p.m.) > > > Review request for Viewer, Oz Linden, Seth ProductEngine, and Alain Linden. > > > Summary > --- > > Changes to fix CHOP-662. CHOP-662 was caused by the recent addition of > lldiriterator.cpp which is used to iterate over directories. It takes a mask > in the form of a glob string to use as a pattern for which files to iterate > over. > > Unfortunately, as originally implemented, it converted the glob to a regex > pattern without escaping any legal glob characters which are illegal regex > characters. As a result if the passed in mask was an illegal regex it would > fail and llerrs would cause a crash. > > In CHOP-662 this happens whenever a group name has, e.g. a '+' character at > the beginning. When logging in the viewer would attempt to load the group > chat log file which would result in a glob starting with a '+' character and > in turn to an illegal regex in lldiriterator. > > Also, the chat code was doing nothing to ensure that illegal glob characters > were not being passed to the lldiriterator constructor. > > > This addresses bug CHOP-662. > http://jira.secondlife.com/browse/CHOP-662 > > > Diffs > - > > doc/contributions.txt e8f2a53c3d6e > indra/llvfs/CMakeLists.txt e8f2a53c3d6e > indra/llvfs/lldiriterator.cpp e8f2a53c3d6e > indra/llvfs/tests/lldiriterator_test.cpp PRE-CREATION > indra/newview/lllogchat.cpp e8f2a53c3d6e > > Diff: http://codereview.secondlife.com/r/357/diff > > > Testing > --- > > Added a unit test for lldiriterator which checks for construction failures on > examples of the most common group names which were causing the crashes. > > > Thanks, > > Squire > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1481 Jerky transition when switching region from fixed sky to a day cycle
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/382/#review846 --- Ship it! Looks good to me. - Seth On July 6, 2011, 5:37 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/382/ > --- > > (Updated July 6, 2011, 5:37 p.m.) > > > Review request for Viewer. > > > Summary > --- > > When uploading new region environment settings, we must also update the > region sun phase/flags. > If we do this too early we may get jerky transition from fixed sky to a day > cycle. > > That is caused by the simulator re-sending the region info, which in turn > makes us > re-request and display old region environment settings while the new ones > haven't been applied yet. > > The fix is to send the sun phase update only when new environment settings > have been applied. > > > This addresses bug STORM-1481. > http://jira.secondlife.com/browse/STORM-1481 > > > Diffs > - > > indra/newview/llfloaterregioninfo.h UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > indra/newview/llregioninfomodel.cpp UNKNOWN > indra/newview/llviewermessage.cpp UNKNOWN > indra/newview/llviewerregion.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/382/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1483 Unable to delete the last water/sky/day preset
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/384/#review848 --- Ship it! - Seth On July 7, 2011, 8:33 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/384/ > --- > > (Updated July 7, 2011, 8:33 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed a wrong condition. > > > This addresses bug STORM-1483. > http://jira.secondlife.com/browse/STORM-1483 > > > Diffs > - > > indra/newview/llfloaterdeleteenvpreset.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/384/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1484 No way to apply changes in estate settings like Allow public access or Allow Voice Chat after merging WLRS
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/385/#review850 --- Ship it! - Seth On July 7, 2011, 10:44 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/385/ > --- > > (Updated July 7, 2011, 10:44 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Restored Apply button in the Estate tab of the REGION / ESTATE floater. > > > This addresses bug STORM-1484. > http://jira.secondlife.com/browse/STORM-1484 > > > Diffs > - > > indra/newview/skins/default/xui/en/panel_region_estate.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/385/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1460 (Cursor doesn't go to the input field on the Find Floater due to lack of window focus)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/386/#review852 --- Ship it! Looks good. - Seth On July 8, 2011, 5:16 a.m., Paul ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/386/ > --- > > (Updated July 8, 2011, 5:16 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Reason: > Focus didn't go to the browser > > Solution: > Set the focus to the browser if a page is loaded and a floater containing a > browser has a focus > > > This addresses bug storm-1460. > http://jira.secondlife.com/browse/storm-1460 > > > Diffs > - > > indra/newview/llfloatersearch.h 68ad362920c1 > indra/newview/llfloatersearch.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/386/diff > > > Testing > --- > > > Thanks, > > Paul > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review856 --- Ship it! Looks good. Works for me. - Seth On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > --- > > (Updated July 10, 2011, 6:24 p.m.) > > > Review request for Viewer. > > > Summary > --- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations > that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that > file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > - > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > --- > > Switched to French, relogged, changed to default mode and logged out. Applied > this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded > build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and > Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > > Thanks, > > Boroondas > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane
> On July 11, 2011, 8:56 a.m., Seth ProductEngine wrote: > > Looks good. > > Works for me. > > Boroondas Gupte wrote: > Thanks for reviewing. As you write "Works for me.", I assume you tested > it, too? Which languages did you try? I tested for German and Spanish. - Seth --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/387/#review856 --- On July 10, 2011, 6:24 p.m., Boroondas Gupte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/387/ > --- > > (Updated July 10, 2011, 6:24 p.m.) > > > Review request for Viewer. > > > Summary > --- > > The layout_panels containing the buttons didn't have unique names. > Renamed them so that their names are now unique within their parent > element. > > Removed the share_btn element and containing layout_panel from translations > that contained it, as it doesn't occur in the English version. > > The English file mixed tabs and spaces. Converted tabs to spaces for that > file. > > Stripped trailing whitespace from the English file. > > > This addresses bug STORM-1403. > http://jira.secondlife.com/browse/STORM-1403 > > > Diffs > - > > doc/contributions.txt 2204db549295 > indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 > indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 > > Diff: http://codereview.secondlife.com/r/387/diff > > > Testing > --- > > Switched to French, relogged, changed to default mode and logged out. Applied > this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded > build, as I still cannot complete a build again.) > > Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and > Teleport buttons were now labeled in French. > > Not tested: > * Funktionality of the buttons. > * Languages other than French. > > > Thanks, > > Boroondas > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1502 Disable "Delete Water/Sky/Day Preset" dialogs if no user presets exist
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/392/#review871 --- Ship it! Looks pretty straightforward. - Seth On July 13, 2011, 2:06 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/392/ > --- > > (Updated July 13, 2011, 2:06 a.m.) > > > Review request for Viewer. > > > Summary > --- > > This patch disables the corresponding menu items when no user-created WL > presets exist. > > > This addresses bug STORM-1502. > http://jira.secondlife.com/browse/STORM-1502 > > > Diffs > - > > indra/newview/llviewermenu.cpp UNKNOWN > indra/newview/skins/default/xui/en/menu_viewer.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/392/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1234) In Nearby Chat, Group Chat and IM Chat, URL selection frequently fails to grab last character
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/394/ --- Review request for Viewer and Richard Nelson. Summary --- Fixed text editor selection which was skipping the last character in line. Added handling of the wrapped lines case when calculating the starting position for selection. The bug is a regression caused by the fix of STORM-320 which was dealing with calculating the position of the input cursor while navigating through the lines of text with word wrapping enabled. This addresses bug STORM-1234. http://jira.secondlife.com/browse/STORM-1234 Diffs - indra/llui/lltextbase.cpp 68ad362920c1 Diff: http://codereview.secondlife.com/r/394/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-519 ( "Delete" is enabled in the context menu for folders which contain worn items)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/396/#review876 --- Ship it! Straightforward fix. - Seth On July 14, 2011, 2:15 a.m., Paul ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/396/ > --- > > (Updated July 14, 2011, 2:15 a.m.) > > > Review request for Viewer. > > > Summary > --- > > - Disable "Delete" menu item in case selected folder contains non-removable > items. > > > This addresses bug storm-519. > http://jira.secondlife.com/browse/storm-519 > > > Diffs > - > > indra/newview/llinventorybridge.cpp 68ad362920c1 > > Diff: http://codereview.secondlife.com/r/396/diff > > > Testing > --- > > > Thanks, > > Paul > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1506 Regions set to Fixed Sun with viewers < 2.8 are not reset correctly when set to use a Day Cycle
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/397/#review881 --- Ship it! Looks good overall. - Seth On July 15, 2011, 9:13 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/397/ > --- > > (Updated July 15, 2011, 9:13 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Reset the estate to global sun when changing region environment settings. > > By the way, moved estate info storage from the REGION/ESTATE floater to a > model class. > > > This addresses bug STORM-1506. > http://jira.secondlife.com/browse/STORM-1506 > > > Diffs > - > > indra/newview/CMakeLists.txt UNKNOWN > indra/newview/llestateinfomodel.h PRE-CREATION > indra/newview/llestateinfomodel.cpp PRE-CREATION > indra/newview/llfloaterauction.cpp UNKNOWN > indra/newview/llfloaterregioninfo.h UNKNOWN > indra/newview/llfloaterregioninfo.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/397/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
[opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/ --- Review request for Viewer. Summary --- Hard coded dates made localizable under Group Profile Land/Assets. Added a function for parsing a date string of specific format. Added strings defining the date format in Group Profile Land/Assets that should be localized. This addresses bug STORM-1221. http://jira.secondlife.com/browse/STORM-1221 Diffs - indra/newview/lldateutil.h d8c37b383028 indra/newview/lldateutil.cpp d8c37b383028 indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 indra/newview/skins/default/xui/en/strings.xml d8c37b383028 Diff: http://codereview.secondlife.com/r/400/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/#review888 --- indra/newview/lldateutil.h <http://codereview.secondlife.com/r/400/#comment927> Yes, there should be no "this" in this line. - Seth On July 18, 2011, 4:01 p.m., Seth ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/400/ > --- > > (Updated July 18, 2011, 4:01 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Hard coded dates made localizable under Group Profile Land/Assets. > > Added a function for parsing a date string of specific format. > Added strings defining the date format in Group Profile Land/Assets that > should be localized. > > > This addresses bug STORM-1221. > http://jira.secondlife.com/browse/STORM-1221 > > > Diffs > - > > indra/newview/lldateutil.h d8c37b383028 > indra/newview/lldateutil.cpp d8c37b383028 > indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 > indra/newview/skins/default/xui/en/strings.xml d8c37b383028 > > Diff: http://codereview.secondlife.com/r/400/diff > > > Testing > --- > > > Thanks, > > Seth > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: (STORM-1221) [HARD CODED] ALL LANGS Several strings are untranslated under Group Profile Land/Assets (French viewer)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/400/ --- (Updated July 19, 2011, 7:20 a.m.) Review request for Viewer. Changes --- Fixed typos. Removed irrelevant changes. Summary --- Hard coded dates made localizable under Group Profile Land/Assets. Added a function for parsing a date string of specific format. Added strings defining the date format in Group Profile Land/Assets that should be localized. This addresses bug STORM-1221. http://jira.secondlife.com/browse/STORM-1221 Diffs (updated) - indra/newview/lldateutil.h d8c37b383028 indra/newview/lldateutil.cpp d8c37b383028 indra/newview/llpanelgrouplandmoney.cpp d8c37b383028 indra/newview/skins/default/xui/en/strings.xml d8c37b383028 Diff: http://codereview.secondlife.com/r/400/diff Testing --- Thanks, Seth ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1451 "Login failed" message is empty in Danish
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/410/#review912 --- Ship it! Works for me. - Seth On July 22, 2011, 8:41 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/410/ > --- > > (Updated July 22, 2011, 8:41 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Straightforward notification template fix. > > > This addresses bug STORM-1451. > http://jira.secondlife.com/browse/STORM-1451 > > > Diffs > - > > indra/newview/skins/default/xui/da/notifications.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/410/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1408 [DE] Text truncation in Edit outfit floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/411/#review913 --- Ship it! Looks good. - Seth On July 22, 2011, 9:02 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/411/ > --- > > (Updated July 22, 2011, 9:02 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Overridden the Save button width for German. > > > This addresses bug STORM-1408. > http://jira.secondlife.com/browse/STORM-1408 > > > Diffs > - > > indra/newview/skins/default/xui/de/panel_outfit_edit.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/411/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/412/#review916 --- Ship it! Looks like a duplicate of https://codereview.secondlife.com/r/387 which deals with STORM-1403, the issue caused by the same widget naming problem. - Seth On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/412/ > --- > > (Updated July 22, 2011, 10:51 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Bug reason: incorrect reuse of an xml element name. > Fix: provided unique names for the buttons. > > > This addresses bug STORM-1404. > http://jira.secondlife.com/browse/STORM-1404 > > > Diffs > - > > indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN > indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/412/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1311 Place Profile only shows 2 lines and users have to click More link to see full description
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/409/#review918 --- Ship it! Looks good to me. - Seth On July 22, 2011, 7:42 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/409/ > --- > > (Updated July 22, 2011, 7:42 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Provide more space for parcel description in the Place Profile when coming > from search. > > This also affects the way teleport history items look. > > In the first place I tried to make the description occupy all available space > and follow viewer window shape. However that triggered numerous bugs in the > text widgets, which spoiled the whole fix. > So I'm coming up with a temporary hacky solution that should fit > the ticket requirements. > > > This addresses bug STORM-1311. > http://jira.secondlife.com/browse/STORM-1311 > > > Diffs > - > > indra/newview/llexpandabletextbox.h UNKNOWN > indra/newview/llexpandabletextbox.cpp UNKNOWN > indra/newview/llpanelplaceprofile.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/409/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-565 llGiveInventory window is suppressed if avatar in Busy mode
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/413/#review930 --- Ship it! Looks good. - Seth On July 25, 2011, 6:29 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/413/ > --- > > (Updated July 25, 2011, 6:29 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Allow inventory offers from objects in Busy mode. > > > This addresses bug STORM-565. > http://jira.secondlife.com/browse/STORM-565 > > > Diffs > - > > indra/newview/llviewermessage.cpp UNKNOWN > > Diff: http://codereview.secondlife.com/r/413/diff > > > Testing > --- > > Tried inventory offers from objects and avatars in normal and busy modes. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1529 Sound Devices floater is too narrow for its widgets
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/418/#review935 --- Ship it! The code looks perfect. No remarks, no objections. - Seth On July 26, 2011, 2:43 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/418/ > --- > > (Updated July 26, 2011, 2:43 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Made the Sound Devices floater wider. > It still doesn't look very nice (probably needs redesign), but the widgets > fit and work. > > > This addresses bug STORM-1529. > http://jira.secondlife.com/browse/STORM-1529 > > > Diffs > - > > indra/newview/skins/default/xui/en/floater_sound_devices.xml 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/418/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1405 Untranslated items in Sound Devices drop-down list
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/417/#review936 --- Ship it! Looks good to me. - Seth On July 26, 2011, 2:02 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/417/ > --- > > (Updated July 26, 2011, 2:02 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Localized the "No Device" and "Default System Device" strings in the sound > devices panel. > > By the way: > * Fixed improper localization of the "Default" device name which caused > saving a localized string in settings. > * Eliminated redundant getChild() calls. > > > This addresses bug STORM-1405. > http://jira.secondlife.com/browse/STORM-1405 > > > Diffs > - > > indra/newview/llpanelvoicedevicesettings.h 2f9a87538ca1 > indra/newview/llpanelvoicedevicesettings.cpp 2f9a87538ca1 > indra/newview/skins/default/xui/en/panel_sound_devices.xml 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/417/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/423/#review942 --- Ship it! Looks good. - Seth On July 29, 2011, 8:01 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/423/ > --- > > (Updated July 29, 2011, 8:01 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Disallow showing URL-like avatar display names as Web links in various places. > > Fixed in: > * People panel -> friend list > * IM toast > * Friend online/offline notification toasts > * IM well > * Avatar inspector > > > This addresses bug STORM-632. > http://jira.secondlife.com/browse/STORM-632 > > > Diffs > - > > indra/newview/skins/default/xui/en/inspect_avatar.xml abd84f85d848 > indra/newview/skins/default/xui/en/notifications.xml abd84f85d848 > indra/newview/skins/default/xui/en/panel_activeim_row.xml abd84f85d848 > indra/newview/skins/default/xui/en/panel_avatar_list_item.xml abd84f85d848 > indra/newview/skins/default/xui/en/panel_instant_message.xml abd84f85d848 > > Diff: http://codereview.secondlife.com/r/423/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1194 Web browser opens clicking URL-name of object in Object Contents floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/422/#review943 --- Ship it! Looks good. - Seth On July 29, 2011, 7:05 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/422/ > --- > > (Updated July 29, 2011, 7:05 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Object Contents floater: disabled links in the object name text box. > > > This addresses bug STORM-1194. > http://jira.secondlife.com/browse/STORM-1194 > > > Diffs > - > > indra/newview/skins/default/xui/en/floater_openobject.xml abd84f85d848 > > Diff: http://codereview.secondlife.com/r/422/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1473 [VIEWER DEV] ALL LANGS Untranslated Voice Morph Names in the French viewer
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/421/#review944 --- Ship it! Looks plausible. - Seth On July 29, 2011, 6:52 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/421/ > --- > > (Updated July 29, 2011, 6:52 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Localized voice morph names. > > > This addresses bug STORM-1473. > http://jira.secondlife.com/browse/STORM-1473 > > > Diffs > - > > indra/newview/llfloatervoiceeffect.cpp abd84f85d848 > indra/newview/skins/default/xui/en/floater_voice_effect.xml abd84f85d848 > > Diff: http://codereview.secondlife.com/r/421/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1436 [JP]"Contents" and "New Script" folder text are missing in "Content" tab for "Build" floater
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/420/#review946 --- Ship it! Looks good to me. - Seth On July 28, 2011, 7:29 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/420/ > --- > > (Updated July 28, 2011, 7:29 p.m.) > > > Review request for Viewer and Richard Nelson. > > > Summary > --- > > Fixed broken localization of "Contents" and "New Script" items in the > Contents tab of Build Tools. > The bug happened when the translations contained non-ASCII characters. > > Reason: Names of inventory items are limited to ASCII characters. > Fix: Leave names in English, localize them when displaying (on the fly). > > The fix only affects object's inventory (i.e. not agent inventory). > > > This addresses bug STORM-1436. > http://jira.secondlife.com/browse/STORM-1436 > > > Diffs > - > > indra/newview/llpanelcontents.cpp 2f9a87538ca1 > indra/newview/llpanelobjectinventory.cpp 2f9a87538ca1 > indra/newview/llviewerobject.cpp 2f9a87538ca1 > > Diff: http://codereview.secondlife.com/r/420/diff > > > Testing > --- > > Tested Japanese and Polish translations. The "Contents", "New Script", ""New > Script 1", "New Script 2", etc names were correctly localized. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1291 [STRING IN ENG] Gestos button. Many gestures. (part 2)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/426/#review947 --- Ship it! - Seth On Aug. 2, 2011, 8:40 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/426/ > --- > > (Updated Aug. 2, 2011, 8:40 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Localized common (unisex) gestures. > > > This addresses bug STORM-1291. > http://jira.secondlife.com/browse/STORM-1291 > > > Diffs > - > > indra/newview/llfloatergesture.cpp b87a6090fb74 > indra/newview/llviewerinventory.cpp b87a6090fb74 > indra/newview/skins/default/xui/en/strings.xml b87a6090fb74 > > Diff: http://codereview.secondlife.com/r/426/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1540 duplicated ID errors: floater_build_options.xml, floater_model_wizard.xml
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/431/#review951 --- Ship it! - Seth On Aug. 5, 2011, 9:13 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/431/ > --- > > (Updated Aug. 5, 2011, 9:13 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > --- > > Fixed numerous missing and duplicated names in floater_build_options.xml and > floater_model_wizard.xml. > > > This addresses bug STORM-1540. > http://jira.secondlife.com/browse/STORM-1540 > > > Diffs > - > > indra/newview/skins/default/xui/en/floater_build_options.xml 0fd2a1181a96 > indra/newview/skins/default/xui/en/floater_model_wizard.xml 0fd2a1181a96 > > Diff: http://codereview.secondlife.com/r/431/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1309 [TEXT ELLIPTED] Text overlaying in Buy Land floater in Portuguese localization
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/430/#review952 --- Ship it! Looks good to me. - Seth On Aug. 5, 2011, 7:53 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/430/ > --- > > (Updated Aug. 5, 2011, 7:53 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Misc i18n fixes in the Buy Land floater: > * Appended a space after the colon in "Last modified:". > It seems to have been mistakenly omitted by translators. > * Fixed timestamp (last modified date) value truncation. > * Proper truncation of region name, region type, estate name and estate owner > text. > o Use ellipses for truncation. > o Where applicable, set tooltip to contain the uncut text. > o Leave a few pixels of padding between the text and the floater right > border. > * Fixed maturity rating icon overlapping the floater right border. > The code that places it now takes into account possible region name text > truncation. > > > This addresses bug STORM-1309. > http://jira.secondlife.com/browse/STORM-1309 > > > Diffs > - > > indra/newview/llfloaterbuyland.cpp 0fd2a1181a96 > indra/newview/skins/default/xui/da/strings.xml 0fd2a1181a96 > indra/newview/skins/default/xui/de/strings.xml 0fd2a1181a96 > indra/newview/skins/default/xui/en/floater_buy_land.xml 0fd2a1181a96 > indra/newview/skins/default/xui/it/strings.xml 0fd2a1181a96 > indra/newview/skins/default/xui/nl/strings.xml 0fd2a1181a96 > indra/newview/skins/default/xui/pl/strings.xml 0fd2a1181a96 > indra/newview/skins/default/xui/pt/strings.xml 0fd2a1181a96 > indra/newview/skins/default/xui/zh/strings.xml 0fd2a1181a96 > > Diff: http://codereview.secondlife.com/r/430/diff > > > Testing > --- > > Tested locales: EN, DE, PT. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1554 Untranslatable gesture: /bow1
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/439/#review969 --- Ship it! - Seth On Aug. 12, 2011, 6:43 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/439/ > --- > > (Updated Aug. 12, 2011, 6:43 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed typo in a gesture name. > > > This addresses bug STORM-1554. > http://jira.secondlife.com/browse/STORM-1554 > > > Diffs > - > > indra/newview/llviewerinventory.cpp 2af4fbfc0c6e > indra/newview/skins/default/xui/en/strings.xml 2af4fbfc0c6e > > Diff: http://codereview.secondlife.com/r/439/diff > > > Testing > --- > > Translated the gesture and made sure the translation worked. > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1566 Sidebar windows no longer detach by right-clicking the tab
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/447/#review991 --- Ship it! Looks good to me. - Seth On Aug. 22, 2011, 8:08 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/447/ > --- > > (Updated Aug. 22, 2011, 8:08 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Reason: wrong name was used to look up the tab to detach. > > The regression was introduced in the fix of EXP-856 (changeset 9e650f2750b5). > > > This addresses bug STORM-1566. > http://jira.secondlife.com/browse/STORM-1566 > > > Diffs > - > > indra/newview/llsidetray.cpp 6e3de80dc3a1 > > Diff: http://codereview.secondlife.com/r/447/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1028 Speak button label not displaying at default window size
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/453/#review1004 --- Ship it! - Seth On Aug. 30, 2011, 4:51 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/453/ > --- > > (Updated Aug. 30, 2011, 4:51 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed chat bar occupying all available space by default. > > Changes: > - Make sure we initialize desired chat bar width before using it. > - Don't attempt shrinking chat bar by negative amount of pixels > (i.e. effectively extending it). This change may be irrelevant > to the bug I'm fixing, but won't hurt anyway. > - Restored my XML changes that had been lost in merges. > - Minor changes (var names, message text) to improve readability. > - Fixed a typo in comments. > > > This addresses bug STORM-1028. > http://jira.secondlife.com/browse/STORM-1028 > > > Diffs > - > > indra/newview/llbottomtray.h 3e6410286eef > indra/newview/llbottomtray.cpp 3e6410286eef > indra/newview/skins/default/xui/en/panel_bottomtray.xml 3e6410286eef > > Diff: http://codereview.secondlife.com/r/453/diff > > > Testing > --- > > Removed settings, verified that the default chat bar width is 250 px (maybe > too small but that's a separate issue, see JIRA). > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1576 Show button does not work in Inventory offer toast
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/455/#review1008 --- Ship it! - Seth On Aug. 31, 2011, 3:18 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/455/ > --- > > (Updated Aug. 31, 2011, 3:18 a.m.) > > > Review request for Viewer. > > > Summary > --- > > Fixed the button index, which became invalid after removing the IOR_BUSY > response in the recent fix of STORM-1543 (changeset 526d86e69101). > > > This addresses bug STORM-1576. > http://jira.secondlife.com/browse/STORM-1576 > > > Diffs > - > > indra/newview/skins/default/xui/en/notifications.xml 3e6410286eef > > Diff: http://codereview.secondlife.com/r/455/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-918 Changes in Group Role Titles or Assignments Not Reflected in Title Dropdown
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/461/#review1009 --- Ship it! Looks good to me. - Seth On Aug. 31, 2011, 10:43 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/461/ > --- > > (Updated Aug. 31, 2011, 10:43 a.m.) > > > Review request for Viewer and Paul ProductEngine. > > > Summary > --- > > Changes: > - Removed a useless (empty) notifyObservers() method. > - Fixed dummy widget creation. > - Removed a redundant getChild() call. We do the same in postBuild(), which > is called earlier. > - Fixing a potential bug: early return from LLGroupMgr::notifyObservers(). > Just noticed it while analyzing code. > - Update role titles in the General tab whenever they change in the Roles tab. > > Only the last change is 100% relevant. Please see Bitbucket for more > fine-grained change breakdown. > > > This addresses bug STORM-918. > http://jira.secondlife.com/browse/STORM-918 > > > Diffs > - > > indra/newview/llgroupmgr.cpp 3e6410286eef > indra/newview/llpanelgroup.h 3e6410286eef > indra/newview/llpanelgroupgeneral.h 3e6410286eef > indra/newview/llpanelgroupgeneral.cpp 3e6410286eef > indra/newview/llpanelgrouplandmoney.cpp 3e6410286eef > indra/newview/llpanelgrouproles.cpp 3e6410286eef > indra/newview/llpanelpeople.cpp 3e6410286eef > > Diff: http://codereview.secondlife.com/r/461/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1297 Clicking on Block in a dialog box from an object blocks by name
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/454/#review1010 --- Ship it! Looks good. - Seth On Aug. 30, 2011, 10:20 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/454/ > --- > > (Updated Aug. 30, 2011, 10:20 a.m.) > > > Review request for Viewer and Jonathan Yap. > > > Summary > --- > > Block object inventory offer by the object's owner ID. > Also did minor changes for better code readability. > > (submitting a fix by Jonathan Yap that I have cleaned up) > > > This addresses bug STORM-1297. > http://jira.secondlife.com/browse/STORM-1297 > > > Diffs > - > > doc/contributions.txt 3e6410286eef > indra/newview/llviewermessage.cpp 3e6410286eef > indra/newview/skins/default/xui/en/notifications.xml 3e6410286eef > > Diff: http://codereview.secondlife.com/r/454/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1587 A lot of notifications are shown in English for other locales in 3.0.3 Beta
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/465/#review1017 --- Ship it! looks good to me. - Seth On Sept. 7, 2011, 12:25 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/465/ > --- > > (Updated Sept. 7, 2011, 12:25 p.m.) > > > Review request for Viewer. > > > Summary > --- > > Make sure LLUI::setupPaths() gets called before initializing notifications. > > > This addresses bug STORM-1587. > http://jira.secondlife.com/browse/STORM-1587 > > > Diffs > - > > indra/newview/llappviewer.cpp 3d4dff671209 > > Diff: http://codereview.secondlife.com/r/465/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/464/#review1019 --- Ship it! Looks good to me. - Seth On Sept. 7, 2011, 10:05 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/464/ > --- > > (Updated Sept. 7, 2011, 10:05 a.m.) > > > Review request for Viewer and Oz Linden. > > > Summary > --- > > Removed usage of the deprecated Google Translate v1 API. > Implemented machine translation via Google Translate v2 and Bing Translate > APIs. > > > This addresses bug STORM-1577. > http://jira.secondlife.com/browse/STORM-1577 > > > Diffs > - > > indra/newview/CMakeLists.txt 8da01486a36a > indra/newview/app_settings/settings.xml 8da01486a36a > indra/newview/llfloaterpreference.h 8da01486a36a > indra/newview/llfloaterpreference.cpp 8da01486a36a > indra/newview/llfloatertranslationsettings.h PRE-CREATION > indra/newview/llfloatertranslationsettings.cpp PRE-CREATION > indra/newview/lltranslate.h 8da01486a36a > indra/newview/lltranslate.cpp 8da01486a36a > indra/newview/llviewerfloaterreg.cpp 8da01486a36a > indra/newview/llviewermessage.cpp 8da01486a36a > indra/newview/skins/default/xui/en/floater_translation_settings.xml > PRE-CREATION > indra/newview/skins/default/xui/en/panel_preferences_chat.xml 8da01486a36a > indra/newview/skins/default/xui/en/strings.xml 8da01486a36a > > Diff: http://codereview.secondlife.com/r/464/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
Re: [opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/466/#review1027 --- indra/newview/llfloatertranslationsettings.cpp <http://codereview.secondlife.com/r/466/#comment1042> Probably keystroke callback causes a bug with disabling the 'OK' button after successfull key verification upon moving the input cursor in line editor without actually editing the valid key. indra/newview/llfloatertranslationsettings.cpp <http://codereview.secondlife.com/r/466/#comment1043> Same problem as above. indra/newview/tests/lltranslate_test.cpp <http://codereview.secondlife.com/r/466/#comment1041> Tests 6 and 7 look exactly the same. Should do something different perhaps. - Seth On Sept. 12, 2011, 5:28 p.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/466/ > --- > > (Updated Sept. 12, 2011, 5:28 p.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > --- > > Replaced deprecated Google Translate v1 API with Google Translate v2 and Bing > Translate APIs. > > Changes after https://codereview.secondlife.com/r/464/: > * New translation preferences floater layout that supports API key > verification. > * Unit tests. > > > This addresses bug STORM-1577. > http://jira.secondlife.com/browse/STORM-1577 > > > Diffs > - > > indra/newview/CMakeLists.txt 8da01486a36a > indra/newview/app_settings/settings.xml 8da01486a36a > indra/newview/llfloaterpreference.h 8da01486a36a > indra/newview/llfloaterpreference.cpp 8da01486a36a > indra/newview/llfloatertranslationsettings.h PRE-CREATION > indra/newview/llfloatertranslationsettings.cpp PRE-CREATION > indra/newview/lltranslate.h 8da01486a36a > indra/newview/lltranslate.cpp 8da01486a36a > indra/newview/llviewerfloaterreg.cpp 8da01486a36a > indra/newview/llviewermessage.cpp 8da01486a36a > indra/newview/skins/default/xui/en/floater_translation_settings.xml > PRE-CREATION > indra/newview/skins/default/xui/en/panel_preferences_chat.xml 8da01486a36a > indra/newview/skins/default/xui/en/strings.xml 8da01486a36a > indra/newview/tests/lltranslate_test.cpp PRE-CREATION > > Diff: http://codereview.secondlife.com/r/466/diff > > > Testing > --- > > > Thanks, > > Vadim > > ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
