----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/175/#review477 -----------------------------------------------------------
Ship it! Docking the side panels on ctrl+shift+w seems to be the appropriate way to fix this crash. - Seth On March 17, 2011, 9:24 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/175/ > ----------------------------------------------------------- > > (Updated March 17, 2011, 9:24 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > ------- > > Reason: The shortcut closes all floaters, including those wrapping undocked > sidepanels. > The sidepanels get destroyed as well, while they are still referenced by the > side tray. > > Fix: Dock (i.e. move to side tray) the sidepanel before its floater gets > destroyed. > > > This addresses bug STORM-1016. > http://jira.secondlife.com/browse/STORM-1016 > > > Diffs > ----- > > indra/llui/llfloater.h ef2df52563bb > indra/llui/llfloater.cpp ef2df52563bb > indra/newview/llsidetray.cpp ef2df52563bb > > Diff: http://codereview.secondlife.com/r/175/diff > > > Testing > ------- > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
