Re: [opensource-dev] "Nearby" people tab

[Kadah Coba]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Are you above 1000m?

On 1/29/2011 3:50 PM, Dave Booth wrote:
> Whats the expected behavior of this tab of the people sidebar? I'm 
> currently sitting in a room with 14 other folks, half of whom are on my 
> flist and all within chat range - but this tab tells me "no one nearby". 
> Currently on Second Life 2.6.0 (21) Jan 29 2011 12:57:40 (Second 
> Life Development) but to be honest I dont think I've EVER seen that tab 
> populated, no matter what build or how crowded the venue.
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNRKpHAAoJEGUNvxojA31thvcIAI78LVkHyDYwejCbLaehmDAE
LlAe+mLqGyb1D7yO9NeAQkdhwNZSInKqdvKrHCMYQFifbQk/Z1aE+nYUoRoMa7/J
42Wo52L87mKEdA9fg7aPlWHEBgiP+d/6y5oK4hRDtJLcH1G6sHGSIeCFsvaTo2la
OEMzSP5l3N4c0hzxFeDR80YwPT1iYKrRqXdfUNhwyyQV3/QHrEnNmmkdk3dXSsQ2
hDpk9g3ui+uBh1zW/IzZ7RXgCPcMxHQdTONesLmeK1F9c6iLi4MIbrZ5WJkSGAtn
4kTyUeCPu8CTumXNX1n4pwKkO/gAyCXpifa4Aow/CGvjGyt2AY/SPcDmjvGJfzw=
=EZAf
-END PGP SIGNATURE-
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Extended Groups broken?

[Kadah Coba]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Thanks Soft, I was just noticing this issue this morning.

Could it have any relation to a problem I've been getting for over a
week with attachments on group notices never getting to my inventory
when I try to open then? I'm trying to test it but I cannot get it to
repro on purpose so I can file a jira on it.


On 2/20/2011 7:36 PM, Brian McGroarty wrote:
> Well, that was quick.
> 
> One login server had been previously disabled after having problems. It
> was repaired and brought back into rotation without a config update. If
> you see the problem again and you logged in after 8pm today (Sunday),
> please post the gMaxAgentGroups line below as well as the sim host
> you're on.
> 
> On Sun, Feb 20, 2011 at 7:25 PM, Brian McGroarty  > wrote:
> 
> I found at least one login host with the wrong number set. I'll push
> this to ops.
> 
> 
> On Sun, Feb 20, 2011 at 6:57 PM, Brian McGroarty  > wrote:
> 
> It might not be a viewer problem.
> 
> The group allowance is controlled by a config file on the login
> hosts and the sims. The supporting sim code has been around for
> some time, so the sim version shouldn't factor into it. It's
> more likely a config problem. With a current viewer, search
> SecondLife.log for a line containing "gMaxAgentGroups" and
> report what you see. Here's mine:
> 
> process_login_success_response: gMaxAgentGroups read from
> login.cgi: 42
> 
> Next, check what sim host you're on via Help->About... If you
> provide the log line and the sim host, several Lindens on this
> list can check for a config problem.
> 
> Also, some SL proxies don't pass new login fields properly. If
> you're using an inspector or similar, have a try without it.
> 
> 
> On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte
> mailto:trilobyte5...@gmail.com>> wrote:
> 
> Both the region I was on and the region I'd logged onto
>  were non-RC servers, running server version 11.02.08
> 220555.  Being that it worked fine when relogging using
> Viewer 2.5, it seems the bug is viewer-side rather than
> server-side.
> 
> On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote:
> 
>> Try logging into a non RC sim.  This seems to help that issue.
>>  
>> > From: trilobyte5...@gmail.com
>> 
>> > Date: Sun, 20 Feb 2011 15:51:47 -0800
>> > To: opensource-dev@lists.secondlife.com
>> 
>> > Subject: [opensource-dev] Extended Groups broken?
>>
>> > 
>> > I'm not sure if this broke in a previous build, but
>> extended groups functionality is broken in build 221543
>> (Mac client). I can see and access the 29 groups I
>> currently belong to, but the Viewer will not let me join
>> any new groups or accept a group invitation from another
>> resident. The only workaround I could find was to relog
>> using the Viewer 2.5 release.
>> > 
>> > I tried searching the JIRA, but there are so many
>> groups-related entries I've had no luck trying to find an
>> existing issue. Is anybody else having trouble adding
>> groups beyond 25?
>> > 
>> > TriloByte Zanzibar
>> > ___
>> > Policies and (un)subscribe information available here:
>> > http://wiki.secondlife.com/wiki/OpenSource-Dev
>> > Please read the policies before posting to keep
>> unmoderated posting privileges
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated
> posting privileges
> 
> 
> 
> 
> -- 
> Brian McGroarty | Linden Lab
> Sent from my Newton MP2100 via acoustic coupler
> 
> 
> 
> 
> -- 
> Brian McGroarty | Linden Lab
> Sent from my Newton MP2100 via acoustic coupler
> 
> 
> 
> 
> -- 
> Brian McGroarty | Linden Lab
> Sent from my Newton MP2100 via acoustic coupler
> 
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNYhaGAAoJEGUNvxojA31t9+kH/3oA

Re: [opensource-dev] Extended Groups broken?

[Kadah Coba]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Yes, I was getting repro while I was on the fallowing,
Second Life Server 11.02.08.220555
Second Life RC Magnum 11.02.15.221184 and the previous one
As well as the previous LeTigre (my home region was apparently moved to
release channel in the last rollout)

I've typically get it when I log in and have one or more notices from
offline; I almost never change regions before handling group notices, so
the failure is occuring with in the same region as which I log in. I've
had at least a dozen failures like that this week a lone.

In the tests we attempted today, the notices were sent from Second Life
Server 11.02.08.220555 and received in the above current versions for
both online and offline. Repro wasn't successful.

Is it possible that this could be a additional effect of SVC-6766?


On 2/20/2011 11:51 PM, Brian McGroarty wrote:
> It shouldn't be related. The only places I've see the cap referenced in
> sim code are in the group joining and creation logic.
> 
> Have you tried it with group notice attachment delivery and receipt on
> the different simulator versions?
> 
> On Sun, Feb 20, 2011 at 11:38 PM, Kadah Coba  <mailto:kadah.c...@gmail.com>> wrote:
> 
> Thanks Soft, I was just noticing this issue this morning.
> 
> Could it have any relation to a problem I've been getting for over a
> week with attachments on group notices never getting to my inventory
> when I try to open then? I'm trying to test it but I cannot get it to
> repro on purpose so I can file a jira on it.
> 
> 
> On 2/20/2011 7:36 PM, Brian McGroarty wrote:
>> Well, that was quick.
> 
>> One login server had been previously disabled after having
> problems. It
>> was repaired and brought back into rotation without a config
> update. If
>> you see the problem again and you logged in after 8pm today (Sunday),
>> please post the gMaxAgentGroups line below as well as the sim host
>> you're on.
> 
>> On Sun, Feb 20, 2011 at 7:25 PM, Brian McGroarty
> mailto:s...@lindenlab.com>
>> <mailto:s...@lindenlab.com <mailto:s...@lindenlab.com>>> wrote:
> 
>> I found at least one login host with the wrong number set.
> I'll push
>> this to ops.
> 
> 
>> On Sun, Feb 20, 2011 at 6:57 PM, Brian McGroarty
> mailto:s...@lindenlab.com>
>> <mailto:s...@lindenlab.com <mailto:s...@lindenlab.com>>> wrote:
> 
>> It might not be a viewer problem.
> 
>> The group allowance is controlled by a config file on the
> login
>> hosts and the sims. The supporting sim code has been
> around for
>> some time, so the sim version shouldn't factor into it. It's
>> more likely a config problem. With a current viewer, search
>> SecondLife.log for a line containing "gMaxAgentGroups" and
>> report what you see. Here's mine:
> 
>> process_login_success_response: gMaxAgentGroups read from
>> login.cgi: 42
> 
>> Next, check what sim host you're on via Help->About... If you
>> provide the log line and the sim host, several Lindens on this
>> list can check for a config problem.
> 
>> Also, some SL proxies don't pass new login fields properly. If
>> you're using an inspector or similar, have a try without it.
> 
> 
>> On Sun, Feb 20, 2011 at 5:52 PM, Trilo Byte
>> mailto:trilobyte5...@gmail.com>
> <mailto:trilobyte5...@gmail.com <mailto:trilobyte5...@gmail.com>>>
> wrote:
> 
>> Both the region I was on and the region I'd logged onto
>>  were non-RC servers, running server version 11.02.08
>> 220555.  Being that it worked fine when relogging using
>> Viewer 2.5, it seems the bug is viewer-side rather than
>> server-side.
> 
>> On Feb 20, 2011, at 4:02 PM, Keith Jaeger wrote:
> 
>>> Try logging into a non RC sim.  This seems to help
> that issue.
>>>
>>> > From: trilobyte5...@gmail.com
> <mailto:trilobyte5...@gmail.com>
>>> <mailto:trilobyte5...@gmail.com
> <mailto:trilobyte5...@gmail.com>>
>>> > Date: Sun, 20 Feb 2011 15:51:47 -0800
>>> > To: opensource-dev@lists.secondlife.com
> <mailto:opensource-dev@lists.secondlife.com>
>>> <mailto:opensource-dev@lists.secondlife.com
> <mailto:opensource-dev@lists.secondlife.com>>
>>> > Subject: [op

[opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/
---

Review request for Viewer.


Summary
---

This change makes it so setting an object for sale or modifying the price or 
sale type requires explicitly applying the changes. Default behavior before 
this patch is all sale info is committed to sim on change. After this patch the 
sale info will only get set or modified after hitting a "mark for sale" button. 
There is no change to removing an object from sale, unchecking "For sale" will 
be committed to sim without further user interation.

https://bitbucket.org/Kadah_Coba/vwr-21522
Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
German translation: 
https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588


This addresses bug VWR-21522.
http://jira.secondlife.com/browse/VWR-21522


Diffs
-

  indra/newview/llpanelpermissions.h b245a988d038 
  indra/newview/llpanelpermissions.cpp b245a988d038 
  indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 

Diff: http://codereview.secondlife.com/r/365/diff


Testing
---

(I had stuff here but Review Board kept deleting it every time I tried to save.)


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

> On June 29, 2011, 6:41 a.m., Oz Linden wrote:
> > indra/newview/llpanelpermissions.cpp, lines 477-480
> > <http://codereview.secondlife.com/r/365/diff/2/?file=3041#file3041line477>
> >
> > There's nothing else inside this 'else if' - why not add the check of 
> > update_sale_info to this statement rather than adding the nested if ?

The parent if ends with an 'else' that disables the inputs controls; a lot of 
the logic would need reworking. I'll poke it to see if can work the logic to 
handle this.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review824
-------


On June 27, 2011, 6:44 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 27, 2011, 6:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

> On June 29, 2011, 6:37 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 245
> > <http://codereview.secondlife.com/r/365/diff/2/?file=3041#file3041line245>
> >
> > Coding standard: rewrite as btn_mark_for_sale.

Will do. As far as the XUI names, is there a standard for those? I've noted 
several different styles used and floater_tools uses one of the oldest I've 
seen.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review825
---


On June 27, 2011, 6:44 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 27, 2011, 6:44 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/
---

(Updated June 29, 2011, 4:54 p.m.)


Review request for Viewer.


Changes
---

Added requested changes (I think I got them all)
Fixed issue where objects that are being actively changed by scripts would get 
prevented from being marked for sale


Summary
---

This change makes it so setting an object for sale or modifying the price or 
sale type requires explicitly applying the changes. Default behavior before 
this patch is all sale info is committed to sim on change. After this patch the 
sale info will only get set or modified after hitting a "mark for sale" button. 
There is no change to removing an object from sale, unchecking "For sale" will 
be committed to sim without further user interation.

https://bitbucket.org/Kadah_Coba/vwr-21522
Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
German translation: 
https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588


This addresses bug VWR-21522.
http://jira.secondlife.com/browse/VWR-21522


Diffs (updated)
-

  indra/newview/skins/default/xui/de/floater_tools.xml b245a988d038 
  indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
  indra/newview/llpanelpermissions.h b245a988d038 
  indra/newview/llpanelpermissions.cpp b245a988d038 

Diff: http://codereview.secondlife.com/r/365/diff


Testing
---

(I had stuff here but Review Board kept deleting it every time I tried to save.)


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

Review request for Viewer.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs
-

  doc/contributions.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmath/llcalc.h UNKNOWN 
  indra/llmath/llcalc.cpp UNKNOWN 
  indra/llmath/llcalcparser.h UNKNOWN 
  indra/llmath/llcalcparser.cpp UNKNOWN 
  indra/llui/lllineeditor.h UNKNOWN 
  indra/llui/lllineeditor.cpp UNKNOWN 
  indra/llui/llspinctrl.cpp UNKNOWN 
  indra/newview/llappviewer.cpp UNKNOWN 
  indra/newview/llpanelface.cpp UNKNOWN 
  indra/newview/llpanelobject.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1027
> > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line1027>
> >
> > CS: check_purchase or better check_purchase_cb

Same name is used else where in the legacy code, should I change both while I'm 
at it?


> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 1118
> > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line1118>
> >
> > dead code

Mistake while merging, will clean


> On June 30, 2011, 9:29 a.m., Vadim ProductEngine wrote:
> > indra/newview/llpanelpermissions.cpp, line 443
> > <http://codereview.secondlife.com/r/365/diff/2-3/?file=3041#file3041line443>
> >
> > Please separate comments from "//" with a space, i.e. write "// Check 
> > if..."

I don't think that was in the CS wiki doc. Will fix comments


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review831
---


On June 29, 2011, 4:54 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated June 29, 2011, 4:54 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/vwr-21522
> Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
> German translation: 
> https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588
> 
> 
> This addresses bug VWR-21522.
> http://jira.secondlife.com/browse/VWR-21522
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/de/floater_tools.xml b245a988d038 
>   indra/newview/skins/default/xui/en/floater_tools.xml b245a988d038 
>   indra/newview/llpanelpermissions.h b245a988d038 
>   indra/newview/llpanelpermissions.cpp b245a988d038 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/
---

(Updated June 30, 2011, 10:33 a.m.)


Review request for Viewer.


Changes
---

Requested CS changes.
Would you like a clean fork with this as one changeset? The current fork got 
too messy for my standards.


Summary
---

This change makes it so setting an object for sale or modifying the price or 
sale type requires explicitly applying the changes. Default behavior before 
this patch is all sale info is committed to sim on change. After this patch the 
sale info will only get set or modified after hitting a "mark for sale" button. 
There is no change to removing an object from sale, unchecking "For sale" will 
be committed to sim without further user interation.

https://bitbucket.org/Kadah_Coba/vwr-21522
Main Patch: https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/45df3e1e9f6f
German translation: 
https://bitbucket.org/Kadah_Coba/vwr-21522/changeset/01dc58391588


This addresses bug VWR-21522.
http://jira.secondlife.com/browse/VWR-21522


Diffs (updated)
-

  doc/contributions.txt UNKNOWN 
  indra/newview/llpanelpermissions.h UNKNOWN 
  indra/newview/llpanelpermissions.cpp UNKNOWN 
  indra/newview/skins/default/xui/de/floater_tools.xml UNKNOWN 
  indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 

Diff: http://codereview.secondlife.com/r/365/diff


Testing
---

(I had stuff here but Review Board kept deleting it every time I tried to save.)


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 11:56 a.m.)


Review request for Viewer.


Changes
---

Lets see if this diff wants to work.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmath/llcalc.h UNKNOWN 
  indra/llmath/llcalc.cpp UNKNOWN 
  indra/llmath/llcalcparser.h UNKNOWN 
  indra/llmath/llcalcparser.cpp UNKNOWN 
  indra/llui/lllineeditor.h UNKNOWN 
  indra/llui/lllineeditor.cpp UNKNOWN 
  indra/llui/llspinctrl.cpp UNKNOWN 
  indra/newview/llappviewer.cpp UNKNOWN 
  indra/newview/llpanelface.cpp UNKNOWN 
  indra/newview/llpanelobject.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 11:59 a.m.)


Review request for Viewer.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt 353807ed6a69 
  indra/llmath/CMakeLists.txt 353807ed6a69 
  indra/llmath/llcalc.h PRE-CREATION 
  indra/llmath/llcalc.cpp PRE-CREATION 
  indra/llmath/llcalcparser.h PRE-CREATION 
  indra/llmath/llcalcparser.cpp PRE-CREATION 
  indra/llui/lllineeditor.h 353807ed6a69 
  indra/llui/lllineeditor.cpp 353807ed6a69 
  indra/llui/llspinctrl.cpp 353807ed6a69 
  indra/newview/llappviewer.cpp 353807ed6a69 
  indra/newview/llpanelface.cpp 353807ed6a69 
  indra/newview/llpanelobject.cpp 353807ed6a69 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 1:49 p.m.)


Review request for Viewer.


Changes
---

Support for floor, ceil, modulo.
Fixed ABS.
Added more constants, SQRT_TWO_PI and SQRT3.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmath/llcalc.h UNKNOWN 
  indra/llmath/llcalc.cpp UNKNOWN 
  indra/llmath/llcalcparser.h UNKNOWN 
  indra/llmath/llcalcparser.cpp UNKNOWN 
  indra/llui/lllineeditor.h UNKNOWN 
  indra/llui/lllineeditor.cpp UNKNOWN 
  indra/llui/llspinctrl.cpp UNKNOWN 
  indra/newview/llappviewer.cpp UNKNOWN 
  indra/newview/llpanelface.cpp UNKNOWN 
  indra/newview/llpanelobject.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated June 30, 2011, 1:50 p.m.)


Review request for Viewer.


Changes
---

I have no idea why review board keeps breaking my diffs. Trying again.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  doc/contributions.txt 353807ed6a69 
  indra/llmath/CMakeLists.txt 353807ed6a69 
  indra/llmath/llcalc.h PRE-CREATION 
  indra/llmath/llcalc.cpp PRE-CREATION 
  indra/llmath/llcalcparser.h PRE-CREATION 
  indra/llmath/llcalcparser.cpp PRE-CREATION 
  indra/llui/lllineeditor.h 353807ed6a69 
  indra/llui/lllineeditor.cpp 353807ed6a69 
  indra/llui/llspinctrl.cpp 353807ed6a69 
  indra/newview/llappviewer.cpp 353807ed6a69 
  indra/newview/llpanelface.cpp 353807ed6a69 
  indra/newview/llpanelobject.cpp 353807ed6a69 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Searching in the world map clears the destination arrow but not the destination beacon

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/379/
---

Review request for Viewer.


Summary
---

A single line change to more completely clear the tracking beacon when text is 
entered in to the world map's search field.

https://bitbucket.org/Kadah_Coba/vwr-25753


This addresses bug VWR-25753.
http://jira.secondlife.com/browse/VWR-25753


Diffs
-

  indra/newview/llfloaterworldmap.cpp c7a4b7a24e05 

Diff: http://codereview.secondlife.com/r/379/diff


Testing
---

Built and ran, world map's search field fallowed the expected behavior 
described in VWR-25753.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated July 2, 2011, 10:21 p.m.)


Review request for Viewer.


Changes
---

Added the missing clears for the texture variables on no selection


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  indra/newview/llpanelobject.cpp 353807ed6a69 
  indra/newview/llpanelface.cpp 353807ed6a69 
  indra/newview/llappviewer.cpp 353807ed6a69 
  indra/llui/llspinctrl.cpp 353807ed6a69 
  indra/llui/lllineeditor.cpp 353807ed6a69 
  indra/llmath/llcalcparser.cpp PRE-CREATION 
  indra/llui/lllineeditor.h 353807ed6a69 
  doc/contributions.txt 353807ed6a69 
  indra/llmath/CMakeLists.txt 353807ed6a69 
  indra/llmath/llcalc.h PRE-CREATION 
  indra/llmath/llcalc.cpp PRE-CREATION 
  indra/llmath/llcalcparser.h PRE-CREATION 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llmath/llcalc.cpp, lines 58-59
> > <http://codereview.secondlife.com/r/377/diff/6/?file=6488#file6488line58>
> >
> > Why allocate dynamically?

I'm not sure, there's a lot of c++ voodoo going on in the original patch.


> On July 4, 2011, 1:01 p.m., Vadim ProductEngine wrote:
> > indra/llui/llspinctrl.cpp, lines 128-135
> > <http://codereview.secondlife.com/r/377/diff/6/?file=6493#file6493line128>
> >
> > dead code

Remove?


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/#review836
-------


On July 2, 2011, 10:21 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/377/
> ---
> 
> (Updated July 2, 2011, 10:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is a direct adaptation of Aimee Trescothick's contributed patch from 
> STORM-1315 for v-d. Adjustments were made where needed to make it work with 
> the newer boost and llui code. Some changes were made to the variable names 
> it uses on build; ie "PX" for x position instead of just "X".
> 
> Patch allows for imputing simple math equations in to the spinner controls. 
> On the build floater a series of variable names are available for using the 
> objects current values in equations, like "sx+3" will take the current X 
> scale and add 3.
> 
> Repo: https://bitbucket.org/Kadah_Coba/storm-1315
> Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370
> 
> 
> This addresses bug STORM-1315.
> http://jira.secondlife.com/browse/STORM-1315
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelobject.cpp 353807ed6a69 
>   indra/newview/llpanelface.cpp 353807ed6a69 
>   indra/newview/llappviewer.cpp 353807ed6a69 
>   indra/llui/llspinctrl.cpp 353807ed6a69 
>   indra/llui/lllineeditor.cpp 353807ed6a69 
>   indra/llmath/llcalcparser.cpp PRE-CREATION 
>   indra/llui/lllineeditor.h 353807ed6a69 
>   doc/contributions.txt 353807ed6a69 
>   indra/llmath/CMakeLists.txt 353807ed6a69 
>   indra/llmath/llcalc.h PRE-CREATION 
>   indra/llmath/llcalc.cpp PRE-CREATION 
>   indra/llmath/llcalcparser.h PRE-CREATION 
> 
> Diff: http://codereview.secondlife.com/r/377/diff
> 
> 
> Testing
> ---
> 
> Built and ran. Some testing done with simple equations on the build tools 
> floater to edit an object, no issues were observed.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1315: Ability to do simple math in numeric edit fields

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/377/
---

(Updated July 4, 2011, 2:22 p.m.)


Review request for Viewer.


Summary
---

This is a direct adaptation of Aimee Trescothick's contributed patch from 
STORM-1315 for v-d. Adjustments were made where needed to make it work with the 
newer boost and llui code. Some changes were made to the variable names it uses 
on build; ie "PX" for x position instead of just "X".

Patch allows for imputing simple math equations in to the spinner controls. On 
the build floater a series of variable names are available for using the 
objects current values in equations, like "sx+3" will take the current X scale 
and add 3.

Repo: https://bitbucket.org/Kadah_Coba/storm-1315
Changeset: https://bitbucket.org/Kadah_Coba/storm-1315/changeset/d33ca6edf370


This addresses bug STORM-1315.
http://jira.secondlife.com/browse/STORM-1315


Diffs (updated)
-

  indra/newview/llpanelobject.cpp 353807ed6a69 
  indra/newview/llpanelface.cpp 353807ed6a69 
  indra/newview/llappviewer.cpp 353807ed6a69 
  indra/llui/llspinctrl.cpp 353807ed6a69 
  indra/llui/lllineeditor.cpp 353807ed6a69 
  indra/llmath/llcalcparser.cpp PRE-CREATION 
  indra/llui/lllineeditor.h 353807ed6a69 
  indra/llmath/llcalc.cpp PRE-CREATION 
  indra/llmath/llcalcparser.h PRE-CREATION 
  indra/llmath/llcalc.h PRE-CREATION 
  indra/llmath/CMakeLists.txt 353807ed6a69 
  doc/contributions.txt 353807ed6a69 

Diff: http://codereview.secondlife.com/r/377/diff


Testing
---

Built and ran. Some testing done with simple equations on the build tools 
floater to edit an object, no issues were observed.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1480: Searching in the world map clears the destination arrow but not the destination beacon

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/379/
---

(Updated July 6, 2011, 2:55 p.m.)


Review request for Viewer.


Summary (updated)
---

A single line change to more completely clear the tracking beacon when text is 
entered in to the world map's search field.

https://bitbucket.org/Kadah_Coba/vwr-25753


This addresses bug VWR-25753.
http://jira.secondlife.com/browse/VWR-25753


Diffs
-

  indra/newview/llfloaterworldmap.cpp c7a4b7a24e05 

Diff: http://codereview.secondlife.com/r/379/diff


Testing
---

Built and ran, world map's search field fallowed the expected behavior 
described in VWR-25753.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/
---

(Updated July 21, 2011, 5:34 p.m.)


Review request for Viewer.


Summary (updated)
---

This change makes it so setting an object for sale or modifying the price or 
sale type requires explicitly applying the changes. Default behavior before 
this patch is all sale info is committed to sim on change. After this patch the 
sale info will only get set or modified after hitting a "mark for sale" button. 
There is no change to removing an object from sale, unchecking "For sale" will 
be committed to sim without further user interation.

https://bitbucket.org/Kadah_Coba/storm-1453


This addresses bug STORM-1453.
http://jira.secondlife.com/browse/STORM-1453


Diffs (updated)
-

  indra/newview/llpanelpermissions.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/365/diff


Testing
---

(I had stuff here but Review Board kept deleting it every time I tried to save.)


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review906
---


Made the requested changes. Allow setting object price without needing to 
commit the object for sale at the default 10L first.

- Kadah


On July 21, 2011, 5:34 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated July 21, 2011, 5:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/storm-1453
> 
> 
> This addresses bug STORM-1453.
> http://jira.secondlife.com/browse/STORM-1453
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

[Kadah Coba]

> On July 21, 2011, 5:35 p.m., Kadah Coba wrote:
> > Made the requested changes. Allow setting object price without needing to 
> > commit the object for sale at the default 10L first.
> 
> Wolfpup Lowenhar wrote:
> 1. Can the price be set to 0$L.
> 2. Dose this also fix it in the side tray?

1. Yes, anything <0 is clammed to 0$L.
2. Yeah, side tray... I could park a freight train in the blind spot I have 
there.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review906
---


On July 21, 2011, 5:34 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated July 21, 2011, 5:34 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/storm-1453
> 
> 
> This addresses bug STORM-1453.
> http://jira.secondlife.com/browse/STORM-1453
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/
---

(Updated July 22, 2011, 11:47 a.m.)


Review request for Viewer.


Changes
---

Updated for sidebar's object profile panel.


Summary
---

This change makes it so setting an object for sale or modifying the price or 
sale type requires explicitly applying the changes. Default behavior before 
this patch is all sale info is committed to sim on change. After this patch the 
sale info will only get set or modified after hitting a "mark for sale" button. 
There is no change to removing an object from sale, unchecking "For sale" will 
be committed to sim without further user interation.

https://bitbucket.org/Kadah_Coba/storm-1453


This addresses bug STORM-1453.
http://jira.secondlife.com/browse/STORM-1453


Diffs (updated)
-

  indra/newview/llpanelpermissions.cpp UNKNOWN 
  indra/newview/llsidepaneltaskinfo.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/365/diff


Testing
---

(I had stuff here but Review Board kept deleting it every time I tried to save.)


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/424/
---

Review request for Viewer.


Summary
---

Adds 2 features:

Adds the ability to use modifier keys to change the defined increment on 
LLSpinCtrl.
Alt: increment x10
Ctrl: increment x0.1
Shift: increment x0.01

Adds extra decimal places to position, size, and rotation on build floater.
Also changes LLPanelObject::sendPosition and LLPanelObject::sendScale to set 
smaller changes in the associated values, no change was needed for 
LLPanelObject::sendRotation. There should be no ill effects from this, changes 
are still only sent to sim on button release.

https://bitbucket.org/Kadah_Coba/storm-56


This addresses bug STORM-56.
http://jira.secondlife.com/browse/STORM-56


Diffs
-

  indra/llui/llspinctrl.cpp UNKNOWN 
  indra/newview/llpanelobject.cpp UNKNOWN 
  indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 

Diff: http://codereview.secondlife.com/r/424/diff


Testing
---

Same code has been in use on FS beta for some time. I have built and tested 
this myself on v-d.


Thanks,

Kadah

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/427/#review948
---


Works on windows within the IDE as long as 'package' is enabled (obviously) or 
the credits lists are blank (expected).

- Kadah


On Aug. 2, 2011, 10:40 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/427/
> ---
> 
> (Updated Aug. 2, 2011, 10:40 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> In the Help>About Second Life dialog, there are lists of users who have 
> contributed to the viewer and provided translations.  Prior to this change, 
> those lists had to be updated manually (and had not been updated in quite 
> some time).
> 
> Since we have a separate file (doc/contributions.txt) to track contributions, 
> and it is in an easily parseable format, this change modifies the viewer 
> build to construct a file (app_settings/contributors.txt) containing those 
> names, and another for the translators (app_settings/translators.txt) from a 
> new doc/translations.txt file (the contents of which are not complete in this 
> patch, but are sufficient for review and testing purposes).
> 
> I also removed the list of Lindens from the dialog, as it too had not been 
> updated in a long time and replaced it with a more generic statement.
> 
> 
> This addresses bug storm-1534.
> http://jira.secondlife.com/browse/storm-1534
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt abd84f85d848 
>   doc/translations.txt PRE-CREATION 
>   indra/newview/llfloaterabout.cpp abd84f85d848 
>   indra/newview/skins/default/xui/en/floater_about.xml abd84f85d848 
>   indra/newview/viewer_manifest.py abd84f85d848 
> 
> Diff: http://codereview.secondlife.com/r/427/diff
> 
> 
> Testing
> ---
> 
> So far built and tested only locally on my Mac... will set up a TeamCity 
> build for other platforms shortly and add a pointer here.  See screenshot on 
> the jira issue.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

[Kadah Coba]

> On Aug. 12, 2011, 10:09 a.m., Richard Nelson wrote:
> > We picked the precision values for those spinners based on what would 
> > survive the roundtrip via our precision-limited object update packets.  
> > Adding more precision will possibly result in confusion when the values 
> > don't respond the way you expect them to.  This is particularly a problem 
> > for rotation...position and scale could probably survive another decimal 
> > point...I haven't done the math.

This would explain what Vadim found as I couldn't see what could be the cause 
of that.


Perhaps updating such small increments frequently, i.e. with the low increment 
spinning, will led to small decimal accuracy being lost/ignored? This was 
something I always wondered about. Phoenix and many other viewers far older 
than it (I've only propagated the feature :P), had been using the extra 
decimals without any apparent problems. But that mag vector of 1/2 millimeter 
seemed to be there for more than just limiting the number of sent updates.

During one of the iterations of porting this to v-d, I had an XUI property for 
limiting the minimal increment of the spinner buttons. Lower decimal values 
could still be entered but they could not be "slid" to. So if changing an 
objects rotation, position or scale by an extra decimal or two occasionally and 
intentionally, by manually entering it, isn't a problem or too much of one, I 
could limit the spinner's minimum increment to the original default lowest 
decimal place, or a multiple there of.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/424/#review970
---


On July 29, 2011, 4:40 p.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/424/
> ---
> 
> (Updated July 29, 2011, 4:40 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Adds 2 features:
> 
> Adds the ability to use modifier keys to change the defined increment on 
> LLSpinCtrl.
> Alt: increment x10
> Ctrl: increment x0.1
> Shift: increment x0.01
> 
> Adds extra decimal places to position, size, and rotation on build floater.
> Also changes LLPanelObject::sendPosition and LLPanelObject::sendScale to set 
> smaller changes in the associated values, no change was needed for 
> LLPanelObject::sendRotation. There should be no ill effects from this, 
> changes are still only sent to sim on button release.
> 
> https://bitbucket.org/Kadah_Coba/storm-56
> 
> 
> This addresses bug STORM-56.
> http://jira.secondlife.com/browse/STORM-56
> 
> 
> Diffs
> -
> 
>   indra/llui/llspinctrl.cpp UNKNOWN 
>   indra/newview/llpanelobject.cpp UNKNOWN 
>   indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/424/diff
> 
> 
> Testing
> ---
> 
> Same code has been in use on FS beta for some time. I have built and tested 
> this myself on v-d.
> 
> 
> Thanks,
> 
> Kadah
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

[Kadah Coba]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

There's a 0.005 minimum requiment in the viewer for sending updates to
the sim. I'm wondering if there is a similar one sim side.

On 8/12/2011 12:09 PM, Tateru Nino wrote:
> I know that there are certain minimums for position updates. If you 
> move a prim less than the threshold value it appears to move in the 
> viewer, but the region considers the prim *not* to have moved. I 
> don't recall exactly what the threshold value is - 0.005, I think. 
> When you come back to the region another time, the prim isn't
> exactly in the position you thought it was in, as any updates below
> the threshold never 'took'.
> 
> That's one of several causes for so-called prim-drift (the prims look
> like they're in the right place now, but later they're mysteriously
> not quite where you think they should be).
> 
> My workaround for this has always been - that if I need to move a 
> prim such a small amount - to move it further away, and then apply 
> the larger delta to get it to where I needed it. That's always
> worked for me, even to some quite fine levels of precision.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOSE/4AAoJEIdLfPRu7qE208gIAKGZlS8DgL1Z+F49C15RFzWL
WeC52qL/tAJdmyx05+rgoMZjoWe7KJsrMCUuv8yJJDCapdFjdkTwR4WGRNWfw3xG
jF+Fe+TP4HYWxcu2uFlul4nCw/slpJukz44diJqQ3oNrEqfmARcrisO1PK91rlT9
CnXCQUQch156lXpJqfegfvWM/kD0bQlmlYdwymIH5WnqAsnO6rwpiFx1o+631yAR
QH1RfRSw5AAdQVcEPnb76T7JRJmW6kvrnWOizdUhFkwGrT8o8pFX8vWrUC931E6K
7r0JTRP5PFN9shF4Ay68UobFbrCMyYPk4qk3Sfcn3eZTWlMfLiAvV0SPMQYGLEQ=
=QNgA
-END PGP SIGNATURE-
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

[Kadah Coba]

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote:
> > found another glitch:
> > I'm developing scripts in eclipse with lslforge. When I "compile" a script 
> > in eclipse and then load it using this patch, tabstops are converted into 
> > IDunnoWhat (it shows as little squares in the script editor).
> >
> 
> Ima Mechanique wrote:
> I'm not familiar with lslforge, but I'll look into it. Are you sure 
> they're valid tabs? I ask because it handles tabs from LSL Editor without a 
> problem.
> 
> Ima Mechanique wrote:
> Looks like this is a bug I've introduced recently, as it is also 
> affecting my LSL Editor created files now. :-(
> Trying to track it down, as soon as I can work out how to go back to a 
> specific revision in Hg.
> 
> Ima Mechanique wrote:
> Damn.  SL's text editing windows do not like tabs. When copy/pasting the 
> tabs are converted to spaces, but not when inserting text. I'll look at 
> finding a way around this.

I don't remember any in-viewer text input ever liking \t particulary. It might 
be best, or at least easier or safer, to just convert them to spaces on import.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/516/#review1082
---


On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/516/
> ---
> 
> (Updated Nov. 22, 2011, 5:17 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Changes to allow opened script window to save/load to/from files on the users 
> computer.
> 
> 
> This addresses bug https://jira.secondlife.com/browse/storm-1708.
> 
> http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a1319d553db9 
>   indra/llui/lltexteditor.h a1319d553db9 
>   indra/llui/lltexteditor.cpp a1319d553db9 
>   indra/newview/llfilepicker.h a1319d553db9 
>   indra/newview/llfilepicker.cpp a1319d553db9 
>   indra/newview/llfloaternamedesc.h a1319d553db9 
>   indra/newview/llfloaternamedesc.cpp a1319d553db9 
>   indra/newview/llpreviewscript.h a1319d553db9 
>   indra/newview/llpreviewscript.cpp a1319d553db9 
>   indra/newview/llviewerfloaterreg.cpp a1319d553db9 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 
> 
> Diff: http://codereview.secondlife.com/r/516/diff
> 
> 
> Testing
> ---
> 
> Successfully opened and saved scripts from/to local files.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Allow scripts to be saved/loaded to/from files.

[Kadah Coba]

> On Nov. 20, 2011, 6:53 a.m., Lance Corrimal wrote:
> > found another glitch:
> > I'm developing scripts in eclipse with lslforge. When I "compile" a script 
> > in eclipse and then load it using this patch, tabstops are converted into 
> > IDunnoWhat (it shows as little squares in the script editor).
> >
> 
> Ima Mechanique wrote:
> I'm not familiar with lslforge, but I'll look into it. Are you sure 
> they're valid tabs? I ask because it handles tabs from LSL Editor without a 
> problem.
> 
> Ima Mechanique wrote:
> Looks like this is a bug I've introduced recently, as it is also 
> affecting my LSL Editor created files now. :-(
> Trying to track it down, as soon as I can work out how to go back to a 
> specific revision in Hg.
> 
> Ima Mechanique wrote:
> Damn.  SL's text editing windows do not like tabs. When copy/pasting the 
> tabs are converted to spaces, but not when inserting text. I'll look at 
> finding a way around this.
> 
> Kadah Coba wrote:
> I don't remember any in-viewer text input ever liking \t particulary. It 
> might be best, or at least easier or safer, to just convert them to spaces on 
> import.
> 
> Cron Stardust wrote:
> I use an external editor now for all my scripting (TextWrangler) and I 
> have set it to use only tabs for all indentation.  The viewer accepts it just 
> fine, and will even regurgitate the tabs when I open the same script in the 
> external editor sometime later.  However, if I try to edit the text using the 
> in-world editor it will mangle the tabs every time.  So my suggestion is 
> this: don't worry about tabs when saving or loading scripts - leave the text 
> as-is.  If it's too annoying (which I think it is) than a JIRA entry should 
> be made, unless there is one already, to request that the SL text editor 
> support real tabs (\t) in the text.  That's where the real problem domain is, 
> not here, IMHO.
> 
> Ima Mechanique wrote:
> @Kadah, @Cron. Guys, tabs are now handled as noted it the last diff 
> (below). Are you suggesting I should remove the conversion?
> Personally I like using tabs in my external editors, but hate the boxes 
> in SL's editor.
> 
> @Cron. What editor is that? I've only tried live editing externally with 
> LSL Editor, set to use UTF-8 and only indent with tabs, but the tabs only 
> show as boxes in SL which I find defeats the purpose of clear indentation 
> (and ugly too).

I had the mistaken impression from my experience that part of that issue was at 
least the fault of more than just the UI text editor controls. I was only 
making the point cause the tab issue and the fact that most external editors 
use \t for tabs, is likely going to lead to "I uploaded a script and now I 
can't edit it properly in-viewer, thus the uploader is broken". 
I'd like \t to be preserved on the uploads and simple have a jira regarding the 
text editor's poor handling of \t linked to STORM-1708, then get that fixed 
separately.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/516/#review1082
---


On Nov. 22, 2011, 5:17 p.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/516/
> ---
> 
> (Updated Nov. 22, 2011, 5:17 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Changes to allow opened script window to save/load to/from files on the users 
> computer.
> 
> 
> This addresses bug https://jira.secondlife.com/browse/storm-1708.
> 
> http://jira.secondlife.com/browse/https://jira.secondlife.com/browse/storm-1708
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a1319d553db9 
>   indra/llui/lltexteditor.h a1319d553db9 
>   indra/llui/lltexteditor.cpp a1319d553db9 
>   indra/newview/llfilepicker.h a1319d553db9 
>   indra/newview/llfilepicker.cpp a1319d553db9 
>   indra/newview/llfloaternamedesc.h a1319d553db9 
>   indra/newview/llfloaternamedesc.cpp a1319d553db9 
>   indra/newview/llpreviewscript.h a1319d553db9 
>   indra/newview/llpreviewscript.cpp a1319d553db9 
>   indra/newview/llviewerfloaterreg.cpp a1319d553db9 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml a1319d553db9 
> 
> Diff: http://codereview.secondlife.com/r/516/diff
> 
> 
> Testing
> ---
> 
> Successfully opened and saved scripts from/to local files.
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: VWR-17587: Added "Fly/Land on holding up/down" option under Move preferences

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/523/
---

Review request for Viewer.


Description
---

Quick patch to add back the long missing AutomaticFly aka "Fly/Land on holding 
up/down". The setting still existed but only has a debug setting with no 
exposure under preferences. This change only added a check box for it under 
Move preferences.

Repo: https://bitbucket.org/Kadah_Coba/vwr-17587
Changeset: https://bitbucket.org/Kadah_Coba/vwr-17587/changeset/2e717f07efbe


This addresses bug VWR-17587.
http://jira.secondlife.com/browse/VWR-17587


Diffs
-

  indra/newview/skins/default/xui/en/panel_preferences_move.xml a984f7ffeb4b 

Diff: http://codereview.secondlife.com/r/523/diff/diff


Testing
---

Patch was tested on Second Life 3.2.4.245931 and is diff against 3.2.5.


Thanks,

Kadah Coba

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1453: Prevent unintended 10L sale

[Kadah Coba]

> On April 6, 2012, 9:03 a.m., Oz Linden wrote:
> > indra/newview/llpanelpermissions.cpp, lines 486-487
> > <http://codereview.secondlife.com/r/365/diff/5/?file=6730#file6730line486>
> >
> > make the comments match the code

For what its worth, I've made the comments more verbose.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/365/#review910
---


On July 22, 2011, 11:47 a.m., Kadah Coba wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/365/
> ---
> 
> (Updated July 22, 2011, 11:47 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> This change makes it so setting an object for sale or modifying the price or 
> sale type requires explicitly applying the changes. Default behavior before 
> this patch is all sale info is committed to sim on change. After this patch 
> the sale info will only get set or modified after hitting a "mark for sale" 
> button. There is no change to removing an object from sale, unchecking "For 
> sale" will be committed to sim without further user interation.
> 
> https://bitbucket.org/Kadah_Coba/storm-1453
> 
> 
> This addresses bug STORM-1453.
> http://jira.secondlife.com/browse/STORM-1453
> 
> 
> Diffs
> -
> 
>   indra/newview/llpanelpermissions.cpp UNKNOWN 
>   indra/newview/llsidepaneltaskinfo.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/365/diff/diff
> 
> 
> Testing
> ---
> 
> (I had stuff here but Review Board kept deleting it every time I tried to 
> save.)
> 
> 
> Thanks,
> 
> Kadah Coba
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Remove requests for unused and non-existant ParcelMediaURLFilterList cap

[Kadah Coba]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/576/#review1212
---

Ship it!


Ship It!

- Kadah Coba


On April 17, 2012, 7:33 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/576/
> ---
> 
> (Updated April 17, 2012, 7:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Removed the requests and the associated callbacks
> 
> 
> This addresses bug storm-1838.
> 
> 
> Diffs
> -
> 
>   indra/newview/llviewerparcelmgr.h acfb0781d850 
>   indra/newview/llviewerparcelmgr.cpp acfb0781d850 
>   indra/newview/llviewerregion.cpp acfb0781d850 
> 
> Diff: http://codereview.secondlife.com/r/576/diff/diff
> 
> 
> Testing
> ---
> 
> Ran the resulting test viewer with no apparent ill effect.
> 
> 
> Thanks,
> 
> Oz Linden
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Remove requests for unused and non-existant ParcelMediaURLFilterList cap

[Kadah Coba]

> On April 17, 2012, 10:42 a.m., Kadah Coba wrote:
> > Ship It!

Looks good. But when I was looking over this for STORM-1843, I noticed that the 
calling function, LLViewerParcelMgr::processParcelProperties, would have to 
have been getting triggered by a server responce to have produced the issue 
(which I myself have gotten many times). So there is still the larger question 
of what would be causing so many ParcelProperties responses.
There is also a lot of related and unused old code behind 
"ParcelMediaURLFilter" that could be scrubbed as well.


- Kadah


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/576/#review1212
---


On April 17, 2012, 7:33 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/576/
> ---
> 
> (Updated April 17, 2012, 7:33 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> ---
> 
> Removed the requests and the associated callbacks
> 
> 
> This addresses bug storm-1838.
> 
> 
> Diffs
> -
> 
>   indra/newview/llviewerparcelmgr.h acfb0781d850 
>   indra/newview/llviewerparcelmgr.cpp acfb0781d850 
>   indra/newview/llviewerregion.cpp acfb0781d850 
> 
> Diff: http://codereview.secondlife.com/r/576/diff/diff
> 
> 
> Testing
> ---
> 
> Ran the resulting test viewer with no apparent ill effect.
> 
> 
> Thanks,
> 
> Oz Linden
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] macOS 10.14 deprecation of OpenGL, what does this mean for SL?

[Kadah Coba]

So just heard about this, not sure if this was known about before this.
https://developer.apple.com/macos/whats-new/

"Apps built using OpenGL and OpenCL will continue to run in macOS 10.14, 
but these legacy technologies are deprecated in macOS 10.14. Games and 
graphics-intensive apps that use OpenGL should now adopt Metal."


There's doing the same on iOS too, not that it effects us.

Knowing Apple's way, could likely assume 10.15 or 10.16 may not support 
OpenGL at all, or at worse, a later update of 10.14.x.


So what does this mean for us since its the thing we breath 
? Blue alert or do we 
change the bulb to red ?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] macOS 10.14 deprecation of OpenGL, what does this mean for SL?

[Kadah Coba]

On 6/4/2018 10:41 PM, Dahlia Trimble wrote:
> I can't believe that Apple will remove an API that so many 
> applications use.

I've seen Apple do worse in the past with less warning.

Apple disabled SSLv3 by default in iOS 9 and an OSX update (maybe around 
10.11, can't remember) without warning. This would have been fine since 
any updated server would also support TLS, except Apple screwed up 
somewhere and many Apple apps, like Mail, would still attempt to connect 
using SSLv3 but then fail with a typically Apple style unhelpful error 
when the OS doesn't allow it to use SSLv3 because the app's plist config 
doesn't allow for an exception.

I got around this by disabling SSLv3 and enforcing TLS only, which 
flagged dayed email for Apple users. Before I did that, if they updated 
to iOS9, they couldn't get email; after I made the changes, they 
required iOS9, and likely an account delete and readd on their phone 
because Apple.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] macOS 10.14 deprecation of OpenGL, what does this mean for SL?

[Kadah Coba]

Exactly. Apple just didn't tell us they were doing that and went to full 
disabled instead of starting with warnings like what browser and other 
apps did for a short while before defaulting to disabled. What didn't 
help is that Apple's disabled didn't work properly with their own apps 
as those would often still try to use SSLv3 instead of TLS when TLS was 
available, that was issue. lol


Over the years, I've dealt with Apple suddenly changing or 
"unsupporting" something and having all my Apple users at work unable to 
do or use some app anymore. Apple has gotten a bit better at this, 
having only done it every other year instead of several per.



On 6/5/2018 5:43 PM, Cinder Roxley wrote:
SSLv3 was disabled because it’s exploitable! 
https://www.us-cert.gov/ncas/alerts/TA14-290A


On June 5, 2018 at 4:05:36 PM, Kadah Coba (kadah.c...@gmail.com 
<mailto:kadah.c...@gmail.com>) wrote:



On 6/4/2018 10:41 PM, Dahlia Trimble wrote:
> I can't believe that Apple will remove an API that so many
> applications use.

I've seen Apple do worse in the past with less warning.

Apple disabled SSLv3 by default in iOS 9 and an OSX update (maybe around
10.11, can't remember) without warning. This would have been fine since
any updated server would also support TLS, except Apple screwed up
somewhere and many Apple apps, like Mail, would still attempt to connect
using SSLv3 but then fail with a typically Apple style unhelpful error
when the OS doesn't allow it to use SSLv3 because the app's plist config
doesn't allow for an exception.

I got around this by disabling SSLv3 and enforcing TLS only, which
flagged dayed email for Apple users. Before I did that, if they updated
to iOS9, they couldn't get email; after I made the changes, they
required iOS9, and likely an account delete and readd on their phone
because Apple.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting 
privileges



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Viewer Development Announcements

[Kadah Coba]

 Looks like the time and location was changed to 1PM EDT, which is 10AM 
SLT. Wish I had checked this before hand, I could have used the extra 
sleep ;P


St James Room - http://maps.secondlife.com/secondlife/SLCC%202/176/64/24


On 8/13/2010 11:49 AM, Oz Linden (Scott Lawrence) wrote:
As most of you probably know by now, from all the hint-dropping we've 
been doing, we've got some announcements to make.  Here's how it's 
going to go - on Sunday, the viewer development leads will be the noon 
(EDT) keynote address at SLCC.  You can watch and listen at any of the 
following in-world locations:


*Imperial Ballroom / The Hatch* -
http://maps.secondlife.com/secondlife/SLCC%201/245/8/23

*The Whitehall Room* -
http://maps.secondlife.com/secondlife/SLCC%203/136/161/31

*Stuart Room* -
http://maps.secondlife.com/secondlife/SLCC%201/158/149/31

*Thoreau Room* -
http://maps.secondlife.com/secondlife/SLCC%201/158/149/31

*St. James Room* -
http://maps.secondlife.com/secondlife/SLCC%202/176/42/24

*Whittier Room* -
http://maps.secondlife.com/secondlife/SLCC%204/183/239/25

You will need to be running a viewer that supports media on a prim.  
It's possible that we'll be able to take questions from in-world as 
well -  I'm not sure.


I will also be posting an announcement to this list some time shortly 
before that presentation, and at that time there will also be 
documentation and other resources publicly available.


My normal office hours for Monday are being replaced with a two hour 
open in-world meeting in the nearby Open Source Park from Noon to 2PM SLT:


http://maps.secondlife.com/secondlife/Hippotropolis/37/233/22

I hope that as many of you as possible will join us.  We're confident 
that the changes we've made are the beginning of a new and much better 
way of doing things both for Linden Lab and for the open source community.



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Viewer Development Announcements

[Kadah Coba]

 Nevermind, looks like the first board at the landing spot had times in 
some other timezone and it was at 7am SLT so I missed it. Any 
recordings, transcriptions of the this?


On 8/15/2010 9:11 AM, Kadah Coba wrote:
Looks like the time and location was changed to 1PM EDT, which is 10AM 
SLT. Wish I had checked this before hand, I could have used the extra 
sleep ;P


St James Room - http://maps.secondlife.com/secondlife/SLCC%202/176/64/24


On 8/13/2010 11:49 AM, Oz Linden (Scott Lawrence) wrote:
As most of you probably know by now, from all the hint-dropping we've 
been doing, we've got some announcements to make.  Here's how it's 
going to go - on Sunday, the viewer development leads will be the 
noon (EDT) keynote address at SLCC.  You can watch and listen at any 
of the following in-world locations:


*Imperial Ballroom / The Hatch* -
http://maps.secondlife.com/secondlife/SLCC%201/245/8/23

*The Whitehall Room* -
http://maps.secondlife.com/secondlife/SLCC%203/136/161/31

*Stuart Room* -
http://maps.secondlife.com/secondlife/SLCC%201/158/149/31

*Thoreau Room* -
http://maps.secondlife.com/secondlife/SLCC%201/158/149/31

*St. James Room* -
http://maps.secondlife.com/secondlife/SLCC%202/176/42/24

*Whittier Room* -
http://maps.secondlife.com/secondlife/SLCC%204/183/239/25

You will need to be running a viewer that supports media on a prim.  
It's possible that we'll be able to take questions from in-world as 
well -  I'm not sure.


I will also be posting an announcement to this list some time shortly 
before that presentation, and at that time there will also be 
documentation and other resources publicly available.


My normal office hours for Monday are being replaced with a two hour 
open in-world meeting in the nearby Open Source Park from Noon to 2PM 
SLT:


http://maps.secondlife.com/secondlife/Hippotropolis/37/233/22

I hope that as many of you as possible will join us.  We're confident 
that the changes we've made are the beginning of a new and much 
better way of doing things both for Linden Lab and for the open 
source community.



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Open Viewer Development Announcement

[Kadah Coba]

 http://wiki.secondlife.com/wiki/Snowstorm_Team
http://wiki.secondlife.com/wiki/Snowstorm_Project

It was just malformed formed, the document is easily enough to find.

On 8/15/2010 10:29 AM, Maximilian March wrote:
/*"Snowstorm operates in the open; the home page of the Snowstorm team 
is on the public wiki at" A BROKEN LINK!*/*

*
NOT a very reassuring feeling that the very first call-to-action link 
in such an important communication leads us to... a broken link.


Thank you, LL QA people, for being asleep at the wheel as usual. Well, 
at least you're consistent.


~The Original M~


On Sun, Aug 15, 2010 at 9:25 AM, Oz Linden (Scott Lawrence) 
mailto:o...@lindenlab.com>> wrote:



What’s Next For The Second Life Viewer?

Linden Lab spent the better part of the last two years revamping
the Second Life Viewer to create Viewer 2. Some of the changes
were important new features, and some were controversial - some
were both. The bulk of the design and engineering work was done
with only limited, indirect participation from the open source and
resident communities, which has left many in those communities
feeling alienated and disenfranchised.
In recent months we have released both Viewer 2 and a 2.1 update;
Linden Lab has also been through a major reorganization. We are
now evaluating the results of all of this work, and we are making
significant changes to the way we design and build the viewer.


Introducing Snowstorm

Linden Lab has created a new team whose goal is to develop the
Second Life Viewer in the open and in response to the needs of our
Residents. Here are our goals:

* Show Residents continuous visible progress
  o Work in the open by sharing not only our code, but our
process publicly -- this includes our backlog and our
discussion about it.
  o Engage with the open source community and aggressively
accept good work the community does into our product.
  o Release new ‘Development’ Viewers frequently -- our
initial target is bi-weekly.  All builds from the
‘Development’ branch are visible and available for
testing.

* Improve the user experience
  o Make continuous improvements to the design and
implementation of the Viewer’s user interface.
  o Import desirable patches and features from Snowglobe
and other Third Party Viewers.
  o Add small features and fixes that have high value and
low cost, while still remaining consistent with an
overall product vision.
* Renew and deepen our relationship with the community
  o Integrate community work directly into our main line
Viewer rather than routing it through Snowglobe first.
  o Demonstrate rapid responsiveness to feedback and
patches from community.
  o Engage continuously with the community to develop new
project proposals and provide resources that open
source developers need to be effective.


How Snowstorm Works

* Viewer development has moved to a single open source model

  o There are no longer internal ‘private’ and external
‘public’ versions. Viewer source (with the exception
of one wrapper library we cannot legally release), is
now in public Mercurial source repositories. All
viewer integration is happening in the Development
repository at
‘http://hg.secondlife.com/viewer-development’. It is
used by all Linden Lab viewer development teams, and
open source developers are encouraged to pull from
that repository and submit changes for integration to it.

* Code in the Development repository is now released under
  version 2 of the GNU LGPL

This allows community developers greater freedom to use the viewer
code, including incorporating it into products that also include
closed source.

* Accepted contributions go directly into the official Second
  Life Viewer

There is no longer a two-step process of contributing to Snowglobe
and then hoping that the contribution is imported to the Linden
viewer. Viewer development efforts within Linden Lab go through
the same integration queue and into the same repository that open
source contributions use.

* Innovations from Snowglobe are being imported to this new viewer

  o Some changes may be left behind or modified in order
to fit into Viewer 2; Linden Lab will work with open
source contributors to harmonize contributions with
the product goals of the Linden viewer. The plan is 

Re: [opensource-dev] Anti-Aliasing

[Kadah Coba]

  Yeah, me too. AA is buggy in 2, but its not working at all now.


On 8/26/2010 6:06 PM, Trilo Byte wrote:
> Is it just me, or is anti-aliasing broken in the last couple builds?
> 2.1.2 (208569) and 2.1.2 (208581)
>
> https://jira.secondlife.com/browse/VWR-20969
>
> TriloByte Zanzibar
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges