Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-14 Thread Jonathan Yap 


> On July 20, 2011, 11:14 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerobjectlist.cpp, line 96
> > 
> >
> > Is a global variable really the way to go here? Also, please add a 
> > short comment explaining the semantics of this variable.
> 
> Jonathan Yap wrote:
> Comment added.  Robin Cornelius suggested using a global variable.  If 
> you can think of a better way please let me know.
> 
> Boroondas Gupte wrote:
> A static class member variable would avoid littering the global 
> namespace. Though an issue I'm more worried about would remain: We might end 
> up converting the wrong object to a sculpty.
> 
> I think one could trigger a race condition by clicking the new sculpty 
> button, then very quickly clicking inworld, clicking one of the 
> non-scuplty prim buttons and clicking inworld again. In that case, it might 
> be undefined which of the two new objects become sculpties. Then again, users 
> who do insane clicking like that might not care either way, anyway.

I don't think rapid clicking as you suggest (even if the time was extremely 
close to the rezz time of the about to be created sculpt) is an issue -- the 
packet sent to the server to request the sculpt to be created and rezzed is 
going to generate a packet coming from the server with the initial object 
parameters.  I don't see how you could "get in front" of this return server 
packet with additional clicking.  I'm assuming the server processes packets 
coming from the viewer sequentially.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/317/#review895
---


On Aug. 3, 2011, 11:21 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/317/
> ---
> 
> (Updated Aug. 3, 2011, 11:21 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> As a Content Creator, I have to select a regular prim type and than choose 
> sculpt from a drop-down menu in order to create a sculpted prim.
> 
> I have added a new Sculpt icon to the list of available object types that can 
> be selected on the build menu.  You can now rez a sculpt the same way you do 
> a cube.
> 
> Possible issue: I made up a new Pcode used only by the viewer.
> 
> 
> This addresses bug STORM-49.
> http://jira.secondlife.com/browse/STORM-49
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt a36a329e77cc 
>   indra/llmath/llvolume.h a36a329e77cc 
>   indra/llprimitive/llprimitive.cpp a36a329e77cc 
>   indra/newview/llfloatertools.cpp a36a329e77cc 
>   indra/newview/lltoolplacer.cpp a36a329e77cc 
>   indra/newview/llviewerobjectlist.h a36a329e77cc 
>   indra/newview/llviewerobjectlist.cpp a36a329e77cc 
>   indra/newview/skins/default/textures/build/Object_Sculpt.png a36a329e77cc 
>   indra/newview/skins/default/textures/build/Object_Sculpt_Selected.png 
> a36a329e77cc 
>   indra/newview/skins/default/textures/textures.xml a36a329e77cc 
>   indra/newview/skins/default/xui/en/floater_tools.xml a36a329e77cc 
> 
> Diff: http://codereview.secondlife.com/r/317/diff
> 
> 
> Testing
> ---
> 
> Rezzed a sculpt both alone and with someone watching.
> 
> Rezzed sculpts as fast as I could click (poor mans load test).
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-49 As a Content Creator, I have to select a regular prim type and than choose sculpt from a drop-down menu in order to create a sculpted prim.

2011-08-14 Thread Jonathan Yap 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/317/
---

(Updated Aug. 14, 2011, 9:07 a.m.)


Review request for Viewer.


Changes
---

Converted global variable ConvertToSculpt from a global to a static class 
member per code review suggestion and pushed changes to bitbucket.


Summary
---

As a Content Creator, I have to select a regular prim type and than choose 
sculpt from a drop-down menu in order to create a sculpted prim.

I have added a new Sculpt icon to the list of available object types that can 
be selected on the build menu.  You can now rez a sculpt the same way you do a 
cube.

Possible issue: I made up a new Pcode used only by the viewer.


This addresses bug STORM-49.
http://jira.secondlife.com/browse/STORM-49


Diffs (updated)
-

  doc/contributions.txt a36a329e77cc 
  indra/llmath/llvolume.h a36a329e77cc 
  indra/llprimitive/llprimitive.cpp a36a329e77cc 
  indra/newview/llfloatertools.cpp a36a329e77cc 
  indra/newview/lltoolplacer.cpp a36a329e77cc 
  indra/newview/llviewerobjectlist.h a36a329e77cc 
  indra/newview/llviewerobjectlist.cpp a36a329e77cc 
  indra/newview/skins/default/textures/build/Object_Sculpt.png a36a329e77cc 
  indra/newview/skins/default/textures/build/Object_Sculpt_Selected.png 
a36a329e77cc 
  indra/newview/skins/default/textures/textures.xml a36a329e77cc 
  indra/newview/skins/default/xui/en/floater_tools.xml a36a329e77cc 

Diff: http://codereview.secondlife.com/r/317/diff


Testing
---

Rezzed a sculpt both alone and with someone watching.

Rezzed sculpts as fast as I could click (poor mans load test).


Thanks,

Jonathan

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

2011-08-14 Thread Kadah Coba 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

There's a 0.005 minimum requiment in the viewer for sending updates to
the sim. I'm wondering if there is a similar one sim side.

On 8/12/2011 12:09 PM, Tateru Nino wrote:
> I know that there are certain minimums for position updates. If you 
> move a prim less than the threshold value it appears to move in the 
> viewer, but the region considers the prim *not* to have moved. I 
> don't recall exactly what the threshold value is - 0.005, I think. 
> When you come back to the region another time, the prim isn't
> exactly in the position you thought it was in, as any updates below
> the threshold never 'took'.
> 
> That's one of several causes for so-called prim-drift (the prims look
> like they're in the right place now, but later they're mysteriously
> not quite where you think they should be).
> 
> My workaround for this has always been - that if I need to move a 
> prim such a small amount - to move it further away, and then apply 
> the larger delta to get it to where I needed it. That's always
> worked for me, even to some quite fine levels of precision.
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOSE/4AAoJEIdLfPRu7qE208gIAKGZlS8DgL1Z+F49C15RFzWL
WeC52qL/tAJdmyx05+rgoMZjoWe7KJsrMCUuv8yJJDCapdFjdkTwR4WGRNWfw3xG
jF+Fe+TP4HYWxcu2uFlul4nCw/slpJukz44diJqQ3oNrEqfmARcrisO1PK91rlT9
CnXCQUQch156lXpJqfegfvWM/kD0bQlmlYdwymIH5WnqAsnO6rwpiFx1o+631yAR
QH1RfRSw5AAdQVcEPnb76T7JRJmW6kvrnWOizdUhFkwGrT8o8pFX8vWrUC931E6K
7r0JTRP5PFN9shF4Ay68UobFbrCMyYPk4qk3Sfcn3eZTWlMfLiAvV0SPMQYGLEQ=
=QNgA
-END PGP SIGNATURE-
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] SLCC 2011 Sunday Notes & Pics

2011-08-14 Thread Sitearm 
; Hi! FYI... includes Sunday and Saturday notes both. Cheers! :) Site aka
James

http://sitearm.wordpress.com/2011/08/15/slcc-2011-sunday-notes-pics/
SLCC 2011 Sunday Notes &
Pics
August
15, 2011 — sitearm
 [image: View 
album]
SLCC 2011 
Sunday
 VIEW SLIDE 
SHOW
DOWNLOAD
ALL

[image: View 
album]
[image:
View 
album]
[image:
View 
album]
[image:
View 
album]
[image:
View 
album]
[image:
View 
album]
[image:
View 
album]

SLCC 2011 is “history,” complete and recorded. My feet are killing me!

Here [left] are a few more selected photos, including *Aliza Sherman’s* (SL:
Cybergrrl Oh) morning keynote, the *Linden Lab’s* (Product Team) keynote,
more Commerce & Marketing Track shots, lunch, and lindens.

I’ve posted, separately, slides from Future of Commerce in Second
Life,
American Cancer Society Relay for
Life,
and Creative Economy in Second
Life
.

Reflection

SLCC 2011 has been a good experience for *Live and Remote*, and *Resident
and Linden* attendees. My favorite quote at lunch, from a linden staffer,
was, “*We *[all 23 of us]* CHOSE to be here.*”

In other words, Residents and Lindens are eager and ready to *reconnect*. I
think this conference has been the *kick start* for that reconnecting to
happen. Kudos to *AvaCon* and *Linden Lab*!

Aha!’s

On a personal note, my head is swimming with *new words* for the day,
including “*economic mega-region*,” “*usability and engagement*”, “*economic
participation*,” and “*personal branding*.”

The afternoon keynote identified *Seven Product Team Contacts* for us to be
aware of:
Art – *Durian Linden*
Gaming – *Gez Linden*
Role Playing – *Esbee Linden*
Adult – *Charla Linen*
Education – *Geo Linden
*Music – *Nya Linden
*Fashion – *Cassandra Linden*

Concluding Thoughts

I was encouraged, again, by the *quality of the speakers* and the *energy of
the participants* (live and remote) to *re-engage* and *re-connect*.

Put *SLCC 2012*, *First or Second Weekend in August*, *Boston*, on your
calendars now. Watch for *more 2011 articles and pictures* this week. *
Recordings* of 2011 sessions will be available in about a week from the SL
Convention Web Site .

And a *final reflection*: *We are living in a world of turmoil and change,
in real life and second life. There is a new vision emerging, not formed
yet.