[opensource-dev] Review Request: STORM-565 llGiveInventory window is suppressed if avatar in Busy mode

2011-07-25 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/413/
---

Review request for Viewer.


Summary
---

Allow inventory offers from objects in Busy mode.


This addresses bug STORM-565.
http://jira.secondlife.com/browse/STORM-565


Diffs
-

  indra/newview/llviewermessage.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/413/diff


Testing
---

Tried inventory offers from objects and avatars in normal and busy modes.


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Seth ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/412/#review916
---

Ship it!


Looks like a duplicate of https://codereview.secondlife.com/r/387 which deals 
with STORM-1403, the issue caused by the same widget naming problem.

- Seth


On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/412/
> ---
> 
> (Updated July 22, 2011, 10:51 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Bug reason: incorrect reuse of an xml element name.
> Fix: provided unique names for the buttons.
> 
> 
> This addresses bug STORM-1404.
> http://jira.secondlife.com/browse/STORM-1404
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/412/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/414/
---

Review request for Viewer.


Summary
---

Localized sim product name (e.g. "Estate / Full Region") everywhere.


This addresses bug STORM-1220.
http://jira.secondlife.com/browse/STORM-1220


Diffs
-

  indra/newview/llfloaterbuyland.cpp UNKNOWN 
  indra/newview/llfloaterland.cpp UNKNOWN 
  indra/newview/llfloaterregioninfo.cpp UNKNOWN 
  indra/newview/llpanelplaceprofile.cpp UNKNOWN 
  indra/newview/llviewerregion.h UNKNOWN 
  indra/newview/llviewerregion.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/414/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-25 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/387/#review917
---


Rejecting this fix in favor of a duplicate (but I think better) one: 
https://codereview.secondlife.com/r/412/


indra/newview/skins/minimal/xui/da/panel_people.xml


Missing rename here.



indra/newview/skins/minimal/xui/da/panel_people.xml


Unclear why this was removed.



indra/newview/skins/minimal/xui/es/panel_people.xml


missing rename



indra/newview/skins/minimal/xui/fr/panel_people.xml


ditto



indra/newview/skins/minimal/xui/it/panel_people.xml


ditto



indra/newview/skins/minimal/xui/ja/panel_people.xml


ditto



indra/newview/skins/minimal/xui/pl/panel_people.xml


ditto



indra/newview/skins/minimal/xui/pt/panel_people.xml


ditto


- Vadim


On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/387/
> ---
> 
> (Updated July 18, 2011, 10:53 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The layout_panels containing the buttons didn't have unique names.
> Renamed them so that their names are now unique within their parent
> element.
> 
> Removed the share_btn element and containing layout_panel from translations 
> that contained it, as it doesn't occur in the English version.
> 
> The English file mixed tabs and spaces. Converted tabs to spaces for that 
> file.
> 
> Stripped trailing whitespace from the English file.
> 
> 
> This addresses bug STORM-1403.
> http://jira.secondlife.com/browse/STORM-1403
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 2204db549295 
>   indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 
> 
> Diff: http://codereview.secondlife.com/r/387/diff
> 
> 
> Testing
> ---
> 
> Switched to French, relogged, changed to default mode and logged out. Applied 
> this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded 
> build, as I still cannot complete a build again.)
> 
> Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and 
> Teleport buttons were now labeled in French.
> 
> Not tested:
> * Funktionality of the buttons.
> * Languages other than French.
> 
> Update:
> Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, 
> fr, it, ja, pl and pt:
> Verified for each language that
> * labels on all 4 buttons on that tab are translated (or as translated as in 
> the XML files. "IM" seems to be the wanted label for the chat button in most 
> of them.)
> * tool-tips of all 4 buttons are translated
> * all 4 buttons cause the action they're intended to cause when clicked
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1311 Place Profile only shows 2 lines and users have to click More link to see full description

2011-07-25 Thread Seth ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/409/#review918
---

Ship it!


Looks good to me.

- Seth


On July 22, 2011, 7:42 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/409/
> ---
> 
> (Updated July 22, 2011, 7:42 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Provide more space for parcel description in the Place Profile when coming 
> from search.
> 
> This also affects the way teleport history items look.
> 
> In the first place I tried to make the description occupy all available space
> and follow viewer window shape. However that triggered numerous bugs in the
> text widgets, which spoiled the whole fix.
> So I'm coming up with a temporary hacky solution that should fit
> the ticket requirements.
> 
> 
> This addresses bug STORM-1311.
> http://jira.secondlife.com/browse/STORM-1311
> 
> 
> Diffs
> -
> 
>   indra/newview/llexpandabletextbox.h UNKNOWN 
>   indra/newview/llexpandabletextbox.cpp UNKNOWN 
>   indra/newview/llpanelplaceprofile.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/409/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-25 Thread Boroondas Gupte 


> On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69
> > 
> >
> > Missing rename here.

For some reason I thought STORM-1403 was only about the "My Friends" tab of 
"People" floater, but re-reading the issue, it is indeed about all of the 
"People" floater, even thought the explicitly mentioned labels are all from the 
"My Friends" tab, so you are right that this element should have been renamed, 
too.


> On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/minimal/xui/da/panel_people.xml, lines 76-78
> > 
> >
> > Unclear why this was removed.

As mentioned in the description, share_btn doesn't seem to have any 
correspondence in the English-language master file 
indra/newview/skins/minimal/xui/en/panel_people.xml, so I think it should be 
removed from the translation files, too.


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/387/#review917
---


On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/387/
> ---
> 
> (Updated July 18, 2011, 10:53 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The layout_panels containing the buttons didn't have unique names.
> Renamed them so that their names are now unique within their parent
> element.
> 
> Removed the share_btn element and containing layout_panel from translations 
> that contained it, as it doesn't occur in the English version.
> 
> The English file mixed tabs and spaces. Converted tabs to spaces for that 
> file.
> 
> Stripped trailing whitespace from the English file.
> 
> 
> This addresses bug STORM-1403.
> http://jira.secondlife.com/browse/STORM-1403
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 2204db549295 
>   indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 
> 
> Diff: http://codereview.secondlife.com/r/387/diff
> 
> 
> Testing
> ---
> 
> Switched to French, relogged, changed to default mode and logged out. Applied 
> this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded 
> build, as I still cannot complete a build again.)
> 
> Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and 
> Teleport buttons were now labeled in French.
> 
> Not tested:
> * Funktionality of the buttons.
> * Languages other than French.
> 
> Update:
> Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, 
> fr, it, ja, pl and pt:
> Verified for each language that
> * labels on all 4 buttons on that tab are translated (or as translated as in 
> the XML files. "IM" seems to be the wanted label for the chat button in most 
> of them.)
> * tool-tips of all 4 buttons are translated
> * all 4 buttons cause the action they're intended to cause when clicked
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel

2011-07-25 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/415/
---

Review request for Viewer.


Summary
---

Made the button translatable by providing its layout stack with a unique name.


This addresses bug STORM-1233.
http://jira.secondlife.com/browse/STORM-1233


Diffs
-

  indra/newview/skins/default/xui/da/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/de/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/en/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/es/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/fr/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/it/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/ja/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/pl/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/pt/panel_places.xml e59aaade1113 
  indra/newview/skins/default/xui/zh/panel_places.xml e59aaade1113 

Diff: http://codereview.secondlife.com/r/415/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1403: ALL LANGS [TRANSLATED BUT IN EN] Light Viewer - Untranslated button names in People pane

2011-07-25 Thread Boroondas Gupte 


> On July 25, 2011, 7:50 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/minimal/xui/da/panel_people.xml, line 69
> > 
> >
> > Missing rename here.
> 
> Boroondas Gupte wrote:
> For some reason I thought STORM-1403 was only about the "My Friends" tab 
> of "People" floater, but re-reading the issue, it is indeed about all of the 
> "People" floater, even thought the explicitly mentioned labels are all from 
> the "My Friends" tab, so you are right that this element should have been 
> renamed, too.

Err ... wait ... this /is/ about the same 'My Friends' tab. (Sorry, it's a 
while ago I worked on this issue.) I did not rename this because I assumed that 
was the proper name for the layout_panel containing the im_btn, and that the 
following entries (for call and teleport) had duplicate names because they were 
copied from it. Looking at the name inconsistency, it might be that actually 
all 3 buttons have been copied from the group_chat_btn on the other tab.


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/387/#review917
---


On July 18, 2011, 10:53 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/387/
> ---
> 
> (Updated July 18, 2011, 10:53 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> The layout_panels containing the buttons didn't have unique names.
> Renamed them so that their names are now unique within their parent
> element.
> 
> Removed the share_btn element and containing layout_panel from translations 
> that contained it, as it doesn't occur in the English version.
> 
> The English file mixed tabs and spaces. Converted tabs to spaces for that 
> file.
> 
> Stripped trailing whitespace from the English file.
> 
> 
> This addresses bug STORM-1403.
> http://jira.secondlife.com/browse/STORM-1403
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 2204db549295 
>   indra/newview/skins/minimal/xui/da/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/de/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/en/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/es/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/it/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml 2204db549295 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml 2204db549295 
> 
> Diff: http://codereview.secondlife.com/r/387/diff
> 
> 
> Testing
> ---
> 
> Switched to French, relogged, changed to default mode and logged out. Applied 
> this patch with -p3 to SecondLife-i686-2.7.5.233393/ (I'm using a downloaded 
> build, as I still cannot complete a build again.)
> 
> Logged in, clicked 'Personnes' button, then 'MES AMIS' tab. The Call and 
> Teleport buttons were now labeled in French.
> 
> Not tested:
> * Funktionality of the buttons.
> * Languages other than French.
> 
> Update:
> Tested "My Friends" tab of "People" floater (basic mode) in da, de, en, es, 
> fr, it, ja, pl and pt:
> Verified for each language that
> * labels on all 4 buttons on that tab are translated (or as translated as in 
> the XML files. "IM" seems to be the wanted label for the chat button in most 
> of them.)
> * tool-tips of all 4 buttons are translated
> * all 4 buttons cause the action they're intended to cause when clicked
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/412/#review920
---



indra/newview/skins/minimal/xui/da/panel_people.xml


share_btn doesn't occur (yet?/anymore?) in the English original, so I think 
it should be removed from the translations, too, to be consistent.

(Ditto for languages other than 'da')


- Boroondas


On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/412/
> ---
> 
> (Updated July 22, 2011, 10:51 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Bug reason: incorrect reuse of an xml element name.
> Fix: provided unique names for the buttons.
> 
> 
> This addresses bug STORM-1404.
> http://jira.secondlife.com/browse/STORM-1404
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/412/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Vadim ProductEngine 


> On July 25, 2011, 9:59 a.m., Boroondas Gupte wrote:
> > indra/newview/skins/minimal/xui/da/panel_people.xml, lines 75-77
> > 
> >
> > share_btn doesn't occur (yet?/anymore?) in the English original, so I 
> > think it should be removed from the translations, too, to be consistent.
> > 
> > (Ditto for languages other than 'da')

It's up to the translation team to remove obsolete translations.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/412/#review920
---


On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/412/
> ---
> 
> (Updated July 22, 2011, 10:51 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Bug reason: incorrect reuse of an xml element name.
> Fix: provided unique names for the buttons.
> 
> 
> This addresses bug STORM-1404.
> http://jira.secondlife.com/browse/STORM-1404
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/412/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/412/#review923
---

Ship it!


> It's up to the translation team to remove obsolete translations.

In that case, no further concerns. Should we file a jira issue to make the 
translation team aware of the obsolete elements?

- Boroondas


On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/412/
> ---
> 
> (Updated July 22, 2011, 10:51 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Bug reason: incorrect reuse of an xml element name.
> Fix: provided unique names for the buttons.
> 
> 
> This addresses bug STORM-1404.
> http://jira.secondlife.com/browse/STORM-1404
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/412/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1233 Untranslated Profile button in the Places panel

2011-07-25 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/415/#review924
---

Ship it!


- Boroondas


On July 25, 2011, 9:54 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/415/
> ---
> 
> (Updated July 25, 2011, 9:54 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Made the button translatable by providing its layout stack with a unique name.
> 
> 
> This addresses bug STORM-1233.
> http://jira.secondlife.com/browse/STORM-1233
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/da/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/de/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/en/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/es/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/fr/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/it/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/ja/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/pl/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/pt/panel_places.xml e59aaade1113 
>   indra/newview/skins/default/xui/zh/panel_places.xml e59aaade1113 
> 
> Diff: http://codereview.secondlife.com/r/415/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/414/#review925
---



indra/newview/llfloaterland.cpp


+1 for moving this re-occurring code into a method. :-)



indra/newview/llfloaterland.cpp


Is it save to remove this NULL-check? AFAIK getChild<...>() can fail.



indra/newview/llfloaterregioninfo.cpp


Is it save to remove this NULL-check? AFAIK getChild<...>() can fail.



indra/newview/llviewerregion.h


Can (and maybe should) be made private now. I don't think any other class 
has a valid reason to use the unlocalized name.

Or just remove it, and use directly use mProductName in 
getLocalizedSimProductName().


- Boroondas


On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/414/
> ---
> 
> (Updated July 25, 2011, 7:36 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Localized sim product name (e.g. "Estate / Full Region") everywhere.
> 
> 
> This addresses bug STORM-1220.
> http://jira.secondlife.com/browse/STORM-1220
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloaterbuyland.cpp UNKNOWN 
>   indra/newview/llfloaterland.cpp UNKNOWN 
>   indra/newview/llfloaterregioninfo.cpp UNKNOWN 
>   indra/newview/llpanelplaceprofile.cpp UNKNOWN 
>   indra/newview/llviewerregion.h UNKNOWN 
>   indra/newview/llviewerregion.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/414/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1404 Light viewer: untranslated buttons in the People panel

2011-07-25 Thread Vadim ProductEngine 


> On July 25, 2011, 10:04 a.m., Boroondas Gupte wrote:
> > > It's up to the translation team to remove obsolete translations.
> > 
> > In that case, no further concerns. Should we file a jira issue to make the 
> > translation team aware of the obsolete elements?

Not sure whether it makes sense. I'll find out.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/412/#review923
---


On July 22, 2011, 10:51 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/412/
> ---
> 
> (Updated July 22, 2011, 10:51 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Bug reason: incorrect reuse of an xml element name.
> Fix: provided unique names for the buttons.
> 
> 
> This addresses bug STORM-1404.
> http://jira.secondlife.com/browse/STORM-1404
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/minimal/xui/da/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/de/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/en/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/es/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/fr/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/it/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/ja/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pl/panel_people.xml UNKNOWN 
>   indra/newview/skins/minimal/xui/pt/panel_people.xml UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/412/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Vadim ProductEngine 


> On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote:
> > indra/newview/llfloaterland.cpp, lines 2885-2886
> > 
> >
> > Is it save to remove this NULL-check? AFAIK getChild<...>() can fail.

Yes. getChild() never returns NULL: if the view is not found, a dummy widget is 
created and returned.


> On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerregion.h, line 195
> > 
> >
> > Can (and maybe should) be made private now. I don't think any other 
> > class has a valid reason to use the unlocalized name.
> > 
> > Or just remove it, and use directly use mProductName in 
> > getLocalizedSimProductName().

I can do it if you insist. However, I'm not sure that the sim product name is 
completely useless without translation. There is lots of stuff in the viewer 
not directly related to UI.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/414/#review925
---


On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/414/
> ---
> 
> (Updated July 25, 2011, 7:36 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Localized sim product name (e.g. "Estate / Full Region") everywhere.
> 
> 
> This addresses bug STORM-1220.
> http://jira.secondlife.com/browse/STORM-1220
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloaterbuyland.cpp UNKNOWN 
>   indra/newview/llfloaterland.cpp UNKNOWN 
>   indra/newview/llfloaterregioninfo.cpp UNKNOWN 
>   indra/newview/llpanelplaceprofile.cpp UNKNOWN 
>   indra/newview/llviewerregion.h UNKNOWN 
>   indra/newview/llviewerregion.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/414/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Boroondas Gupte 


> On July 25, 2011, 10:44 a.m., Boroondas Gupte wrote:
> > indra/newview/llviewerregion.h, line 195
> > 
> >
> > Can (and maybe should) be made private now. I don't think any other 
> > class has a valid reason to use the unlocalized name.
> > 
> > Or just remove it, and use directly use mProductName in 
> > getLocalizedSimProductName().
> 
> Vadim ProductEngine wrote:
> I can do it if you insist. However, I'm not sure that the sim product 
> name is completely useless without translation. There is lots of stuff in the 
> viewer not directly related to UI.

I certainly don't insist, merely suggest. As far as I have seen, after your 
change getSimProductName will only be used by getLocalizedSimProductName, so 
there is currently no other code needing it. I believe that any new code is 
more likely to need getLocalizedSimProductName than getSimProductName, so 
hiding the latter could avoid oversights. If someone knows he needs the 
unlocalized name (e.g. for logging, which we always do in English), they can 
still make getSimProductName public again, but has to make a conscious decision 
for that.

If you considered this and decided getSimProductName should stay public for 
now, anyway, I'll trust your judgment on that. For avoiding people picking the 
wrong method, making getSimProductName private or removing it is of course not 
the only possibility. Renaming getSimProductName to getEnglishSimProductName or 
getUnlocalizedSimProductName and/or adding some doxigen documentation 
indicating what it will return would probably serve the same purpose well 
enough.


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/414/#review925
---


On July 25, 2011, 7:36 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/414/
> ---
> 
> (Updated July 25, 2011, 7:36 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Localized sim product name (e.g. "Estate / Full Region") everywhere.
> 
> 
> This addresses bug STORM-1220.
> http://jira.secondlife.com/browse/STORM-1220
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloaterbuyland.cpp UNKNOWN 
>   indra/newview/llfloaterland.cpp UNKNOWN 
>   indra/newview/llfloaterregioninfo.cpp UNKNOWN 
>   indra/newview/llpanelplaceprofile.cpp UNKNOWN 
>   indra/newview/llviewerregion.h UNKNOWN 
>   indra/newview/llviewerregion.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/414/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Vadim ProductEngine 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/414/
---

(Updated July 25, 2011, 1:51 p.m.)


Review request for Viewer.


Changes
---

Removed LLViewerRegion::getSimProductName() so that it doesn't mistakenly
get used in UI code, thus causing localization bugs.


Summary
---

Localized sim product name (e.g. "Estate / Full Region") everywhere.


This addresses bug STORM-1220.
http://jira.secondlife.com/browse/STORM-1220


Diffs (updated)
-

  indra/newview/llfloaterbuyland.cpp e59aaade1113 
  indra/newview/llfloaterland.cpp e59aaade1113 
  indra/newview/llfloaterregioninfo.cpp e59aaade1113 
  indra/newview/llpanelplaceprofile.cpp e59aaade1113 
  indra/newview/llviewerregion.h e59aaade1113 
  indra/newview/llviewerregion.cpp e59aaade1113 

Diff: http://codereview.secondlife.com/r/414/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1220 Region / Estate > Covenant - Type of region is in EN: "Estate / Full Region"

2011-07-25 Thread Boroondas Gupte 

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/414/#review929
---

Ship it!


- Boroondas


On July 25, 2011, 1:51 p.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/414/
> ---
> 
> (Updated July 25, 2011, 1:51 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Localized sim product name (e.g. "Estate / Full Region") everywhere.
> 
> 
> This addresses bug STORM-1220.
> http://jira.secondlife.com/browse/STORM-1220
> 
> 
> Diffs
> -
> 
>   indra/newview/llfloaterbuyland.cpp e59aaade1113 
>   indra/newview/llfloaterland.cpp e59aaade1113 
>   indra/newview/llfloaterregioninfo.cpp e59aaade1113 
>   indra/newview/llpanelplaceprofile.cpp e59aaade1113 
>   indra/newview/llviewerregion.h e59aaade1113 
>   indra/newview/llviewerregion.cpp e59aaade1113 
> 
> Diff: http://codereview.secondlife.com/r/414/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges