Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/304/#review698
---



indra/newview/skins/default/xui/en/notifications.xml


I think you have uploaded the wrong diff for this code review.


- Jonathan


On May 15, 2011, 7:14 p.m., Wolfpup Lowenhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/304/
> ---
> 
> (Updated May 15, 2011, 7:14 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is for switching from using winres.h to windows.h so that the viewer can 
> be build no matter whether your using and Express or Professional version of 
> Visual Studio.
> 
> 
> This addresses bug STORM-859.
> http://jira.secondlife.com/browse/STORM-859
> 
> 
> Diffs
> -
> 
>   indra/newview/skins/default/xui/en/notifications.xml e9d656e4620e 
> 
> Diff: http://codereview.secondlife.com/r/304/diff
> 
> 
> Testing
> ---
> 
> I have built viewer-development locally with this modification using Visual 
> Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. 
> It logs in to SL just fine.
> I have done the following with the built viewer:
> 1. edited or created objects with no ill affects.
> 2. carried on conversations in Near By, Group and P2P with no ill affects.
> 3. Teleported to various sims and levels in those sims with no ill affect.
> 4. carried on Voice conversations with no ill affect.
> 5. moved things around in my inventory as well as rezed and taken objects 
> from and to my inventory with no ill affects.
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

[Wolfpup Lowenhar]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/304/
---

(Updated May 16, 2011, 4:16 a.m.)


Review request for Viewer.


Changes
---

sorry use wrong initial diff here is the correct diff


Summary
---

This is for switching from using winres.h to windows.h so that the viewer can 
be build no matter whether your using and Express or Professional version of 
Visual Studio.


This addresses bug STORM-859.
http://jira.secondlife.com/browse/STORM-859


Diffs (updated)
-

  doc/contributions.txt e9d656e4620e 
  indra/newview/res/resource.h e9d656e4620e 
  indra/newview/res/viewerRes.rc e9d656e4620e 

Diff: http://codereview.secondlife.com/r/304/diff


Testing
---

I have built viewer-development locally with this modification using Visual 
Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. 
It logs in to SL just fine.
I have done the following with the built viewer:
1. edited or created objects with no ill affects.
2. carried on conversations in Near By, Group and P2P with no ill affects.
3. Teleported to various sims and levels in those sims with no ill affect.
4. carried on Voice conversations with no ill affect.
5. moved things around in my inventory as well as rezed and taken objects from 
and to my inventory with no ill affects.


Thanks,

Wolfpup

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/304/#review699
---

Ship it!


Am I reading this comment right, that ...


indra/newview/res/viewerRes.rc


... this code here has been generated ...



indra/newview/res/viewerRes.rc


... from the block here (notabene in the same file)?


Assuming so, 'ship it', as your change in and of itself seems good, and you are 
changing the generating and the generated code consistently. (And other than 
STORM-1074, we don't seem to be touching code shared with the server, here.)

Though I must say that I am worried about this script/header in general (pre- 
and post-change equally), as generating code in another part of the same file 
is damn close to self-modifying code. A concept which, while very powerful and 
sometimes useful, is usually deemed bad practice or even plain dangerous.

I don't know whether it is considered save, normal and/or accepted for MS 
Visual C++ resource scripts. Maybe VS has some safeguards to ensure nothing too 
crazy happens through them?

- Boroondas


On May 16, 2011, 4:16 a.m., Wolfpup Lowenhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/304/
> ---
> 
> (Updated May 16, 2011, 4:16 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is for switching from using winres.h to windows.h so that the viewer can 
> be build no matter whether your using and Express or Professional version of 
> Visual Studio.
> 
> 
> This addresses bug STORM-859.
> http://jira.secondlife.com/browse/STORM-859
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e9d656e4620e 
>   indra/newview/res/resource.h e9d656e4620e 
>   indra/newview/res/viewerRes.rc e9d656e4620e 
> 
> Diff: http://codereview.secondlife.com/r/304/diff
> 
> 
> Testing
> ---
> 
> I have built viewer-development locally with this modification using Visual 
> Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. 
> It logs in to SL just fine.
> I have done the following with the built viewer:
> 1. edited or created objects with no ill affects.
> 2. carried on conversations in Near By, Group and P2P with no ill affects.
> 3. Teleported to various sims and levels in those sims with no ill affect.
> 4. carried on Voice conversations with no ill affect.
> 5. moved things around in my inventory as well as rezed and taken objects 
> from and to my inventory with no ill affects.
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-859 : winres.h isn't present within VC++ Express includes. Must be manually copied from win7 sdk example code.

[ardylay]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/304/#review700
---

Ship it!


I think I can approve of that.  It's essentially what we decided on at a 
meeting.  I think my point was to put the #define in with the rest of them 
instead of out in left field and this looks good to me now.

- ardy.lay


On May 16, 2011, 4:16 a.m., Wolfpup Lowenhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/304/
> ---
> 
> (Updated May 16, 2011, 4:16 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This is for switching from using winres.h to windows.h so that the viewer can 
> be build no matter whether your using and Express or Professional version of 
> Visual Studio.
> 
> 
> This addresses bug STORM-859.
> http://jira.secondlife.com/browse/STORM-859
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt e9d656e4620e 
>   indra/newview/res/resource.h e9d656e4620e 
>   indra/newview/res/viewerRes.rc e9d656e4620e 
> 
> Diff: http://codereview.secondlife.com/r/304/diff
> 
> 
> Testing
> ---
> 
> I have built viewer-development locally with this modification using Visual 
> Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. 
> It logs in to SL just fine.
> I have done the following with the built viewer:
> 1. edited or created objects with no ill affects.
> 2. carried on conversations in Near By, Group and P2P with no ill affects.
> 3. Teleported to various sims and levels in those sims with no ill affect.
> 4. carried on Voice conversations with no ill affect.
> 5. moved things around in my inventory as well as rezed and taken objects 
> from and to my inventory with no ill affects.
> 
> 
> Thanks,
> 
> Wolfpup
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: Update autobuilds default VC version to 2010

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/305/
---

Review request for Viewer.


Summary
---

Autobuild defaults to VC 2005 if the environment variable AUTOBUILD_VSVER is 
unset. Now that LL have moved to VC 2010 completely, shouldn't this become the 
default version?


Diffs
-

  autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 

Diff: http://codereview.secondlife.com/r/305/diff


Testing
---


Thanks,

Ima

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] rational behind resetting inventory focus?

[Erin Mallory]

Anyone know the rational behind the decision to make the inventory refocus 
every time someone comes on or offline (or receives a new group message)? This 
is becoming one of my larger annoyances (right up there with the texture picker 
often failing (again) and the accordions in the shape/clothing editing system) 
and slows me down when considerably when trying to sort inventory, build, etc. 
I'm just curious if anyone knows why this behavior was built in?
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: OPEN-67: make LLDirIterator implementation compatible to boost::filesystem v3 (as found in Boost 1.44 and newer)

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/307/
---

Review request for Viewer.


Summary
---

Some trickery needed to make this forward compatible to newer Boost versions 
while keeping compatibility to the currently used Boost version.


This addresses bug OPEN-67.
http://jira.secondlife.com/browse/OPEN-67


Diffs
-

  doc/contributions.txt 959f9340da92 
  indra/llvfs/lldiriterator.cpp 959f9340da92 

Diff: http://codereview.secondlife.com/r/307/diff


Testing
---

* Compiled Viewer (standalone) with Boost 1.46
* Started Viewer
* Logged in

Not tested:
* non-standalone
* other boost versions (At least one version <= 1.43 should be tested! 
Preferably the one LL currently uses.)


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Update autobuilds default VC version to 2010

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/305/#review701
---



autobuild/autobuild_tool_source_environment.py


This comment should probably be changed, too.


- Boroondas


On May 16, 2011, 10:04 a.m., Ima Mechanique wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/305/
> ---
> 
> (Updated May 16, 2011, 10:04 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Autobuild defaults to VC 2005 if the environment variable AUTOBUILD_VSVER is 
> unset. Now that LL have moved to VC 2010 completely, shouldn't this become 
> the default version?
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 
> 
> Diff: http://codereview.secondlife.com/r/305/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ima
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Update autobuilds default VC version to 2010

[Ima Mechanique]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/305/
---

(Updated May 16, 2011, 3:50 p.m.)


Review request for Viewer.


Changes
---

Changed comment associated with default value, per Boroondas suggestion.


Summary
---

Autobuild defaults to VC 2005 if the environment variable AUTOBUILD_VSVER is 
unset. Now that LL have moved to VC 2010 completely, shouldn't this become the 
default version?


Diffs (updated)
-

  autobuild/autobuild_tool_source_environment.py 2a560b1d8f95 

Diff: http://codereview.secondlife.com/r/305/diff


Testing
---


Thanks,

Ima

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges