----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/304/#review700 -----------------------------------------------------------
Ship it! I think I can approve of that. It's essentially what we decided on at a meeting. I think my point was to put the #define in with the rest of them instead of out in left field and this looks good to me now. - ardy.lay On May 16, 2011, 4:16 a.m., Wolfpup Lowenhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/304/ > ----------------------------------------------------------- > > (Updated May 16, 2011, 4:16 a.m.) > > > Review request for Viewer. > > > Summary > ------- > > This is for switching from using winres.h to windows.h so that the viewer can > be build no matter whether your using and Express or Professional version of > Visual Studio. > > > This addresses bug STORM-859. > http://jira.secondlife.com/browse/STORM-859 > > > Diffs > ----- > > doc/contributions.txt e9d656e4620e > indra/newview/res/resource.h e9d656e4620e > indra/newview/res/viewerRes.rc e9d656e4620e > > Diff: http://codereview.secondlife.com/r/304/diff > > > Testing > ------- > > I have built viewer-development locally with this modification using Visual > Studio 2010 Ultimate and have seen no ill affects as yet to the built viewer. > It logs in to SL just fine. > I have done the following with the built viewer: > 1. edited or created objects with no ill affects. > 2. carried on conversations in Near By, Group and P2P with no ill affects. > 3. Teleported to various sims and levels in those sims with no ill affect. > 4. carried on Voice conversations with no ill affect. > 5. moved things around in my inventory as well as rezed and taken objects > from and to my inventory with no ill affects. > > > Thanks, > > Wolfpup > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
