Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode

[Yoz Grahame]

On 16 March 2011 20:25, Yoz Grahame  wrote:

>
> You can switch between Basic and Advanced mode on the login screen.
> Switching currently requires a viewer restart; we're looking into ways to
> make that easier, though that may not be achievable for the 2.6 release.
>

Sorry, I should make sure to not get people's hopes up unduly: Switching
between modes without restart would require extensive additional work. We
all want it, but as yet we don't know if or when it'll happen.

-- Yoz
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/213/#review471
---

Ship it!


This change looks correct and well done. (Didn't test it yet, though.) Thanks!

I especially like the aspect that logging is moved from the callers to the 
callee, which makes the affected code cleaner.

I have some ideas on how to make this even better:
* Make it easier to see where the command starts, e.g. by adding a semicolon 
after the word "command" or by adding some color.
* In the dry-run case, should the log message indicate that nothing actually 
happens? (e.g. have it say "would execute" instead of "executing" if dry_run is 
true)

Both these suggestions would change expected behavior, so they are out of the 
scope of this issue. I'll file separate jira issues for them.

- Boroondas


On March 16, 2011, 8:19 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/213/
> ---
> 
> (Updated March 16, 2011, 8:19 p.m.)
> 
> 
> Review request for Viewer and Alain Linden.
> 
> 
> Summary
> ---
> 
> Extended the __call__ method of Executable to pass in the command type as a 
> string and the dry_run flag so that the logging of the command being run 
> could use the infrastructure there to exactly assemble the options and 
> arguments for the logging of the command to be run.  The callers then don't 
> need to do the logging separately or do anything with dry_run other than pass 
> it down to the executable.
> 
> 
> This addresses bug open-45.
> http://jira.secondlife.com/browse/open-45
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_tool_build.py abc1014d5ad6 
>   autobuild/autobuild_tool_configure.py abc1014d5ad6 
>   autobuild/executable.py abc1014d5ad6 
> 
> Diff: http://codereview.secondlife.com/r/213/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/#review472
---

Ship it!


Looks good. Please fix the two minor doc issues and submit.


indra/newview/llexpandabletextbox.h


The description seems to be inappropriate.



indra/newview/llexpandabletextbox.cpp


Please add the ticket reference.


- Vadim


On March 16, 2011, 5:19 p.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/198/
> ---
> 
> (Updated March 16, 2011, 5:19 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed "More" link being toggled in expandable textbox after reshaping.
> 
> 
> This addresses bug STORM-250.
> http://jira.secondlife.com/browse/STORM-250
> 
> 
> Diffs
> -
> 
>   indra/newview/llexpandabletextbox.h b761ed94eb26 
>   indra/newview/llexpandabletextbox.cpp b761ed94eb26 
> 
> Diff: http://codereview.secondlife.com/r/198/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/197/#review473
---

Ship it!


Looks good, apart from hard-coded radiuses and unclear purpose of the outer 
ring.


indra/newview/llnetmap.cpp


Please move these numbers to settings.


- Vadim


On March 12, 2011, 8 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/197/
> ---
> 
> (Updated March 12, 2011, 8 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add optional range ring to the mini-map -- one centered on you with a radius 
> of 20m to show local chat range.
> 
> By default the range ring is off.
> 
> To turn it on you right click on the mini-map and pick the menu entry "Range 
> Ring".
> 
> 
> This addresses bug Storm-1068.
> http://jira.secondlife.com/browse/Storm-1068
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt aed94e854443 
>   indra/newview/app_settings/settings.xml aed94e854443 
>   indra/newview/llnetmap.h aed94e854443 
>   indra/newview/llnetmap.cpp aed94e854443 
>   indra/newview/skins/default/colors.xml aed94e854443 
>   indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/197/diff
> 
> 
> Testing
> ---
> 
> Tested with another avatar.  When they are outside the ring they cannot see 
> my local chat and when they are inside it they can, so the ring's radius is 
> set correctly.
> 
> Flew over various types of land to make sure my color choice (blue @10%) was 
> always visible.
> 
> Enabled range ring, logged out and back on; range ring is still present on 
> mini-map.
> 
> Panned mini-map, range ring remains centered over avatar.
> 
> Used mouse wheel to zoom in and out as far as possible.  Size of range ring 
> varied with change in zoom level.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1025 Chat preferences > font size should increase size of input text as well

[Vadim Savchuk]

On 03/13/2011 02:42 AM, Jonathan Yap wrote:
This is an automatically generated e-mail. To reply, visit: 
http://codereview.secondlife.com/r/139/



Review request for Viewer.
By Jonathan Yap.

/Updated March 12, 2011, 4:42 p.m./


  Changes

Ignore this and the previous message--just changing the jira number from vwr to 
storm.  And yes, the diffs are messed up and I don't know how to fix that.


Try creating a new review request and closing the broken one as discarded.

--
Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode

[Daniel]

Does the "Advanced" menu in the "Advanced" mode get renamed to "Expert" 
or something to avoid confusion?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: fix for STORM-1049: [crashhunters] crash at LLViewerFetchedTexture::forceToSaveRawImage(int, bool)

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/193/#review474
---


Bao, please upload a diff.

- Vadim


On None, Xiaohong Bao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/193/
> ---
> 
> Review request for Viewer and Merov Linden.
> 
> 
> Summary
> ---
> 
> changeset: efc74a20699e
> Merov: I need to bug you again for a few more reviews for some crashes.
> 
> 
> This addresses bug storm-1049.
> http://jira.secondlife.com/browse/storm-1049
> 
> 
> Diffs
> -
> 
> 
> Diff: http://codereview.secondlife.com/r/193/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Xiaohong
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode

[Moriz Gupte]

Wondering if the ability to create a user's own spotlights is desirable?
That would add an extra control point to the UI which we do not want ... may
be. I think we will find that some UI features in the basic mode will
migrate to the advanced mode as they are found to be useful not only for
newcomers but also for advanced users. Let the migration dance between the
advanced and basic modes begin.

On Thu, Mar 17, 2011 at 8:00 AM, Daniel  wrote:

> Does the "Advanced" menu in the "Advanced" mode get renamed to "Expert"
> or something to avoid confusion?
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>



-- 
'Consider how the lilies grow. They do not labor or spin.'
*Rameshsharma Ramloll* PhD, *Research Associate Professor*, Idaho State
University, Pocatello, ID 83209 Tel: 208-282-5333
Blog ,
LinkedIn
, Play2Train 
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

[Cron Stardust]

> On March 17, 2011, 4:50 a.m., Vadim ProductEngine wrote:
> > indra/newview/llnetmap.cpp, lines 473-474
> > 
> >
> > Please move these numbers to settings.

Those two should be CHAT_NORMAL_RADIUS and CHAT_SHOUT_RADIUS respectively.  
Both are defined in indra_constants.h in the llcommon directory.


- Cron


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/197/#review473
---


On March 12, 2011, 8 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/197/
> ---
> 
> (Updated March 12, 2011, 8 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add optional range ring to the mini-map -- one centered on you with a radius 
> of 20m to show local chat range.
> 
> By default the range ring is off.
> 
> To turn it on you right click on the mini-map and pick the menu entry "Range 
> Ring".
> 
> 
> This addresses bug Storm-1068.
> http://jira.secondlife.com/browse/Storm-1068
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt aed94e854443 
>   indra/newview/app_settings/settings.xml aed94e854443 
>   indra/newview/llnetmap.h aed94e854443 
>   indra/newview/llnetmap.cpp aed94e854443 
>   indra/newview/skins/default/colors.xml aed94e854443 
>   indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/197/diff
> 
> 
> Testing
> ---
> 
> Tested with another avatar.  When they are outside the ring they cannot see 
> my local chat and when they are inside it they can, so the ring's radius is 
> set correctly.
> 
> Flew over various types of land to make sure my color choice (blue @10%) was 
> always visible.
> 
> Enabled range ring, logged out and back on; range ring is still present on 
> mini-map.
> 
> Panned mini-map, range ring remains centered over avatar.
> 
> Used mouse wheel to zoom in and out as far as possible.  Size of range ring 
> varied with change in zoom level.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands

[Alain Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/213/#review476
---


I don't like leaking these details into the executable interface.  I'd prefer 
to do this another way, but I'll have to think about precisely what that way is.

- Alain


On March 16, 2011, 8:19 p.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/213/
> ---
> 
> (Updated March 16, 2011, 8:19 p.m.)
> 
> 
> Review request for Viewer and Alain Linden.
> 
> 
> Summary
> ---
> 
> Extended the __call__ method of Executable to pass in the command type as a 
> string and the dry_run flag so that the logging of the command being run 
> could use the infrastructure there to exactly assemble the options and 
> arguments for the logging of the command to be run.  The callers then don't 
> need to do the logging separately or do anything with dry_run other than pass 
> it down to the executable.
> 
> 
> This addresses bug open-45.
> http://jira.secondlife.com/browse/open-45
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_tool_build.py abc1014d5ad6 
>   autobuild/autobuild_tool_configure.py abc1014d5ad6 
>   autobuild/executable.py abc1014d5ad6 
> 
> Diff: http://codereview.secondlife.com/r/213/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1016 Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/175/
---

(Updated March 17, 2011, 9:24 a.m.)


Review request for Viewer and Seth ProductEngine.


Summary
---

Reason: The shortcut closes all floaters, including those wrapping undocked 
sidepanels.
The sidepanels get destroyed as well, while they are still referenced by the 
side tray.

Fix: Dock (i.e. move to side tray) the sidepanel before its floater gets 
destroyed.


This addresses bug STORM-1016.
http://jira.secondlife.com/browse/STORM-1016


Diffs
-

  indra/llui/llfloater.h ef2df52563bb 
  indra/llui/llfloater.cpp ef2df52563bb 
  indra/newview/llsidetray.cpp ef2df52563bb 

Diff: http://codereview.secondlife.com/r/175/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-1016 Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/175/#review477
---

Ship it!


Docking the side panels on ctrl+shift+w seems to be the appropriate way to fix 
this crash.

- Seth


On March 17, 2011, 9:24 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/175/
> ---
> 
> (Updated March 17, 2011, 9:24 a.m.)
> 
> 
> Review request for Viewer and Seth ProductEngine.
> 
> 
> Summary
> ---
> 
> Reason: The shortcut closes all floaters, including those wrapping undocked 
> sidepanels.
> The sidepanels get destroyed as well, while they are still referenced by the 
> side tray.
> 
> Fix: Dock (i.e. move to side tray) the sidepanel before its floater gets 
> destroyed.
> 
> 
> This addresses bug STORM-1016.
> http://jira.secondlife.com/browse/STORM-1016
> 
> 
> Diffs
> -
> 
>   indra/llui/llfloater.h ef2df52563bb 
>   indra/llui/llfloater.cpp ef2df52563bb 
>   indra/newview/llsidetray.cpp ef2df52563bb 
> 
> Diff: http://codereview.secondlife.com/r/175/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

[Oz Linden]

> On March 12, 2011, 7:16 a.m., Oz Linden wrote:
> > indra/llcharacter/llbvhloader.cpp, line 1199
> > 
> >
> > I think it would be clearer to either add a new constant 
> > POSITION_MOTION_THRESHOLD_SQUARED or to write these like
> > 
> >  ... < (POSTION_MOTION_THRESHOLD*POSITION_MOTION_THRESHOLD).
> > 
> > (and same convention elsewhere)
> 
> Boroondas Gupte wrote:
> For this specific line, you probably mean ">", not "<", do you?
> 
> Also, what's the convention are you proposing? Grouping the multiplied 
> values together by braces? Or leaving away the spaces around the 
> multiplication operator?
> 
> Cron Stardust wrote:
> Oz, I was thinking along those lines (creating or changing the constant,) 
> but I wasn't sure if it would be within the scope of this.  After further 
> thought, and evaluating the input thus far, I've come to the conclusion that 
> it is within the scope.  A new diff incorporating the notes thus far 
> mentioned will be forthcoming.

I meant putting the constant being squared inside parens with no spaces.  
Really, if it's a constant I think it's probably better to make another 
constant with _SQUARED appended.

While I'm being nit-picky - I think it's clearer when wrapping an expression 
across lines to put the operator at the beginning of the second line instead of 
the end of the first line:

(dist_vec_squared(LLVector3(ki_prev->mPos), first_frame_pos) 
 > (POSITION_MOTION_THRESHOLD*POSITION_MOTION_THRESHOLD))


- Oz


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/199/#review448
---


On March 12, 2011, 11:54 p.m., Cron Stardust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/199/
> ---
> 
> (Updated March 12, 2011, 11:54 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> I looking at the code, trying to find out where/how to add a new feature, 
> when I tripped across one of these and it lit my mental warning bells off.  
> Vector distance comparisons should, IMHO, always be done squared.  So I did 
> some greppin, manual analysis, and some careful modification, and here's the 
> result.
> 
> 
> This addresses bug VWR-25126.
> http://jira.secondlife.com/browse/VWR-25126
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 344d4c6d7d7e 
>   indra/llcharacter/llbvhloader.cpp 344d4c6d7d7e 
>   indra/llcommon/indra_constants.h 344d4c6d7d7e 
>   indra/llmath/tests/llbbox_test.cpp 344d4c6d7d7e 
>   indra/newview/llagent.cpp 344d4c6d7d7e 
>   indra/newview/llfloaterchat.cpp 344d4c6d7d7e 
>   indra/newview/llhudeffectlookat.cpp 344d4c6d7d7e 
>   indra/newview/llhudeffectpointat.cpp 344d4c6d7d7e 
>   indra/newview/llmaniprotate.cpp 344d4c6d7d7e 
>   indra/newview/llmanipscale.cpp 344d4c6d7d7e 
>   indra/newview/llnetmap.cpp 344d4c6d7d7e 
>   indra/newview/llpanelpeople.cpp 344d4c6d7d7e 
>   indra/newview/llselectmgr.cpp 344d4c6d7d7e 
>   indra/newview/llspeakers.cpp 344d4c6d7d7e 
>   indra/newview/llviewerchat.cpp 344d4c6d7d7e 
>   indra/newview/llviewermessage.cpp 344d4c6d7d7e 
>   indra/newview/llviewerparceloverlay.cpp 344d4c6d7d7e 
>   indra/newview/llvoicevivox.cpp 344d4c6d7d7e 
>   indra/newview/llworld.cpp 344d4c6d7d7e 
> 
> Diff: http://codereview.secondlife.com/r/199/diff
> 
> 
> Testing
> ---
> 
> Compiled a test viewer and used it, undertaking some of my normal activities. 
>  Results felt good, but are currently anecdotal.  Any suggestions on how to 
> properly measure this (or even some actual measurement from those already 
> instrumented to measure these things,) would be great!
> 
> 
> Thanks,
> 
> Cron
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] merov's viewer-autobuild2010

[Twisted Laws]

I pulled down Merov's viewer-autobuild2010 as was suggested in the meeting 
yesterday 
and manually inserted fmod files and then ran
 
autobuild --debug configure -c OpenSourceRelWithDebInfo
 
autobuild --debug build -c OpenSourceRelWithDebInfo
 
logged in with LindenDeveloper.exe in the RelWithDebInfo directory.
 
I'm on Windows 7, with Visual Studio 10.0 Professional with a fresh pull from
bitbucket.org/merov_linden/viewer-autobuild2010 with autobuild up to date
 
YEAH!
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

[Cron Stardust]

> On March 12, 2011, 7:16 a.m., Oz Linden wrote:
> > indra/llcharacter/llbvhloader.cpp, line 1199
> > 
> >
> > I think it would be clearer to either add a new constant 
> > POSITION_MOTION_THRESHOLD_SQUARED or to write these like
> > 
> >  ... < (POSTION_MOTION_THRESHOLD*POSITION_MOTION_THRESHOLD).
> > 
> > (and same convention elsewhere)
> 
> Boroondas Gupte wrote:
> For this specific line, you probably mean ">", not "<", do you?
> 
> Also, what's the convention are you proposing? Grouping the multiplied 
> values together by braces? Or leaving away the spaces around the 
> multiplication operator?
> 
> Oz Linden wrote:
> I meant putting the constant being squared inside parens with no spaces.  
> Really, if it's a constant I think it's probably better to make another 
> constant with _SQUARED appended.
> 
> While I'm being nit-picky - I think it's clearer when wrapping an 
> expression across lines to put the operator at the beginning of the second 
> line instead of the end of the first line:
> 
> (dist_vec_squared(LLVector3(ki_prev->mPos), first_frame_pos) 
>  > (POSITION_MOTION_THRESHOLD*POSITION_MOTION_THRESHOLD))
>
> 
> Cron Stardust wrote:
> Oz, I was thinking along those lines (creating or changing the constant,) 
> but I wasn't sure if it would be within the scope of this.  After further 
> thought, and evaluating the input thus far, I've come to the conclusion that 
> it is within the scope.  A new diff incorporating the notes thus far 
> mentioned will be forthcoming.

Actually, it's not wrapped - that's a figment of your screen width. :)  
However, this is also now the old edition of the patch, the new revision 
changes POSITION_MOTION_THRESHOLD into POSITION_MOTION_THRESHOLD_SQUARED.


- Cron


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/199/#review448
---


On March 12, 2011, 11:54 p.m., Cron Stardust wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/199/
> ---
> 
> (Updated March 12, 2011, 11:54 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> I looking at the code, trying to find out where/how to add a new feature, 
> when I tripped across one of these and it lit my mental warning bells off.  
> Vector distance comparisons should, IMHO, always be done squared.  So I did 
> some greppin, manual analysis, and some careful modification, and here's the 
> result.
> 
> 
> This addresses bug VWR-25126.
> http://jira.secondlife.com/browse/VWR-25126
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt 344d4c6d7d7e 
>   indra/llcharacter/llbvhloader.cpp 344d4c6d7d7e 
>   indra/llcommon/indra_constants.h 344d4c6d7d7e 
>   indra/llmath/tests/llbbox_test.cpp 344d4c6d7d7e 
>   indra/newview/llagent.cpp 344d4c6d7d7e 
>   indra/newview/llfloaterchat.cpp 344d4c6d7d7e 
>   indra/newview/llhudeffectlookat.cpp 344d4c6d7d7e 
>   indra/newview/llhudeffectpointat.cpp 344d4c6d7d7e 
>   indra/newview/llmaniprotate.cpp 344d4c6d7d7e 
>   indra/newview/llmanipscale.cpp 344d4c6d7d7e 
>   indra/newview/llnetmap.cpp 344d4c6d7d7e 
>   indra/newview/llpanelpeople.cpp 344d4c6d7d7e 
>   indra/newview/llselectmgr.cpp 344d4c6d7d7e 
>   indra/newview/llspeakers.cpp 344d4c6d7d7e 
>   indra/newview/llviewerchat.cpp 344d4c6d7d7e 
>   indra/newview/llviewermessage.cpp 344d4c6d7d7e 
>   indra/newview/llviewerparceloverlay.cpp 344d4c6d7d7e 
>   indra/newview/llvoicevivox.cpp 344d4c6d7d7e 
>   indra/newview/llworld.cpp 344d4c6d7d7e 
> 
> Diff: http://codereview.secondlife.com/r/199/diff
> 
> 
> Testing
> ---
> 
> Compiled a test viewer and used it, undertaking some of my normal activities. 
>  Results felt good, but are currently anecdotal.  Any suggestions on how to 
> properly measure this (or even some actual measurement from those already 
> instrumented to measure these things,) would be great!
> 
> 
> Thanks,
> 
> Cron
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] merov's viewer-autobuild2010

[Ima Mechanique]

> 
> I pulled down Merov's viewer-autobuild2010 as was suggested in the meeting 
> yesterday 
> and manually inserted fmod files and then ran
>  
> autobuild --debug configure -c OpenSourceRelWithDebInfo
>  
> autobuild --debug build -c OpenSourceRelWithDebInfo
>  
> logged in with LindenDeveloper.exe in the RelWithDebInfo directory.
>  
> I'm on Windows 7, with Visual Studio 10.0 Professional with a fresh pull from
> bitbucket.org/merov_linden/viewer-autobuild2010 with autobuild up to date
>  
> YEAH!
> 

I tried the same, however this fails completely for VCE as the
configuration (only one supporting VC 2010) uses devenv which is not
available on any Express setup.

--
Ima Mechanique
ima.mechanique(at)blueyonder.co.uk


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] VWR-25188

[Erin Mallory]

Created https://jira.secondlife.com/browse/VWR-25188 as per grumpity's request 
for those like myself who are unable to get the 2.6.1 viewer to initialize at 
all... 
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

[Jonathan Yap]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/197/#review480
---


The code that creates a ring @ 100 meters has been removed and I changed the 
mystery constant 20.0 to CHAT_NORMAL_RADIUS.  Struggling with the diff hence 
that part is not updated.

- Jonathan


On March 12, 2011, 8 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/197/
> ---
> 
> (Updated March 12, 2011, 8 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add optional range ring to the mini-map -- one centered on you with a radius 
> of 20m to show local chat range.
> 
> By default the range ring is off.
> 
> To turn it on you right click on the mini-map and pick the menu entry "Range 
> Ring".
> 
> 
> This addresses bug Storm-1068.
> http://jira.secondlife.com/browse/Storm-1068
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt aed94e854443 
>   indra/newview/app_settings/settings.xml aed94e854443 
>   indra/newview/llnetmap.h aed94e854443 
>   indra/newview/llnetmap.cpp aed94e854443 
>   indra/newview/skins/default/colors.xml aed94e854443 
>   indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/197/diff
> 
> 
> Testing
> ---
> 
> Tested with another avatar.  When they are outside the ring they cannot see 
> my local chat and when they are inside it they can, so the ring's radius is 
> set correctly.
> 
> Flew over various types of land to make sure my color choice (blue @10%) was 
> always visible.
> 
> Enabled range ring, logged out and back on; range ring is still present on 
> mini-map.
> 
> Panned mini-map, range ring remains centered over avatar.
> 
> Used mouse wheel to zoom in and out as far as possible.  Size of range ring 
> varied with change in zoom level.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Suggested fix for OPEN-45

[Alain Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/215/
---

(Updated March 17, 2011, 3:02 p.m.)


Review request for Viewer, Oz Linden and Boroondas Gupte.


Summary
---

Suggested fix for OPEN-45.  I'd like to decouple Executable as much as possible 
from assumptions and state of autobuild.  To that end I added an optional 
argument to the __str__ method to accept an options list to insert into the 
command string.  The command string generated by __call__ and __str__ is now 
identical.  Incidentally I made the environment an optional argument to 
__call__ to make it more general and decouple it a little more from the rest of 
autobuild.


This addresses bug OPEN-45.
http://jira.secondlife.com/browse/OPEN-45


Diffs
-

  autobuild/autobuild_tool_build.py abc1014d5ad6 
  autobuild/autobuild_tool_configure.py abc1014d5ad6 
  autobuild/common.py abc1014d5ad6 
  autobuild/executable.py abc1014d5ad6 

Diff: http://codereview.secondlife.com/r/215/diff


Testing
---


Thanks,

Alain

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

[Lance Corrimal]

> On March 17, 2011, 11:46 a.m., Jonathan Yap wrote:
> > The code that creates a ring @ 100 meters has been removed and I changed 
> > the mystery constant 20.0 to CHAT_NORMAL_RADIUS.  Struggling with the diff 
> > hence that part is not updated.

I found both rings quite useful.
oh and btw I think the rings shouldn't be blue. At least not for me to find 
them useful... for sailing.


- Lance


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/197/#review480
---


On March 12, 2011, 8 a.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/197/
> ---
> 
> (Updated March 12, 2011, 8 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Add optional range ring to the mini-map -- one centered on you with a radius 
> of 20m to show local chat range.
> 
> By default the range ring is off.
> 
> To turn it on you right click on the mini-map and pick the menu entry "Range 
> Ring".
> 
> 
> This addresses bug Storm-1068.
> http://jira.secondlife.com/browse/Storm-1068
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt aed94e854443 
>   indra/newview/app_settings/settings.xml aed94e854443 
>   indra/newview/llnetmap.h aed94e854443 
>   indra/newview/llnetmap.cpp aed94e854443 
>   indra/newview/skins/default/colors.xml aed94e854443 
>   indra/newview/skins/default/xui/en/menu_mini_map.xml aed94e854443 
> 
> Diff: http://codereview.secondlife.com/r/197/diff
> 
> 
> Testing
> ---
> 
> Tested with another avatar.  When they are outside the ring they cannot see 
> my local chat and when they are inside it they can, so the ring's radius is 
> set correctly.
> 
> Flew over various types of land to make sure my color choice (blue @10%) was 
> always visible.
> 
> Enabled range ring, logged out and back on; range ring is still present on 
> mini-map.
> 
> Panned mini-map, range ring remains centered over avatar.
> 
> Used mouse wheel to zoom in and out as far as possible.  Size of range ring 
> varied with change in zoom level.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/
---

(Updated March 17, 2011, 4:19 p.m.)


Review request for Viewer.


Changes
---

Updated comments, added jira ticket reference.


Summary
---

Fixed "More" link being toggled in expandable textbox after reshaping.


This addresses bug STORM-250.
http://jira.secondlife.com/browse/STORM-250


Diffs (updated)
-

  indra/newview/llexpandabletextbox.h d32171ae1288 
  indra/newview/llexpandabletextbox.cpp d32171ae1288 

Diff: http://codereview.secondlife.com/r/198/diff


Testing
---


Thanks,

Seth

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/198/#review484
---

Ship it!


No further objections. Great work!

- Boroondas


On March 17, 2011, 4:19 p.m., Seth ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/198/
> ---
> 
> (Updated March 17, 2011, 4:19 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Fixed "More" link being toggled in expandable textbox after reshaping.
> 
> 
> This addresses bug STORM-250.
> http://jira.secondlife.com/browse/STORM-250
> 
> 
> Diffs
> -
> 
>   indra/newview/llexpandabletextbox.h d32171ae1288 
>   indra/newview/llexpandabletextbox.cpp d32171ae1288 
> 
> Diff: http://codereview.secondlife.com/r/198/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Seth
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Suggested fix for OPEN-45

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/215/#review485
---

Ship it!


Even better than my solution

- Oz


On March 17, 2011, 3:02 p.m., Alain Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/215/
> ---
> 
> (Updated March 17, 2011, 3:02 p.m.)
> 
> 
> Review request for Viewer, Oz Linden and Boroondas Gupte.
> 
> 
> Summary
> ---
> 
> Suggested fix for OPEN-45.  I'd like to decouple Executable as much as 
> possible from assumptions and state of autobuild.  To that end I added an 
> optional argument to the __str__ method to accept an options list to insert 
> into the command string.  The command string generated by __call__ and 
> __str__ is now identical.  Incidentally I made the environment an optional 
> argument to __call__ to make it more general and decouple it a little more 
> from the rest of autobuild.
> 
> 
> This addresses bug OPEN-45.
> http://jira.secondlife.com/browse/OPEN-45
> 
> 
> Diffs
> -
> 
>   autobuild/autobuild_tool_build.py abc1014d5ad6 
>   autobuild/autobuild_tool_configure.py abc1014d5ad6 
>   autobuild/common.py abc1014d5ad6 
>   autobuild/executable.py abc1014d5ad6 
> 
> Diff: http://codereview.secondlife.com/r/215/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alain
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges