Re: [opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/98/#review181
---

Ship it!


Looks good, given that this is a first pass implementation.

- Vadim


On Jan. 17, 2011, 1:24 p.m., Andrew ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/98/
> ---
> 
> (Updated Jan. 17, 2011, 1:24 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> First pass of saving of UI state into files.
> 
> Implemeted saving of floaters and bottombar buttons state into a named 
> layout. This layout is saved on disk into per-user folder. The folder with 
> layout contains LLSD files.
> 
> Currently the following features were implemeted:
> - Saving of bottomtray buttons order and visibility.
> - Saving floaters rect and visibility info (multiple instances of the same 
> floater are supported)
> - Saving of sidetray tabs state (docked/undocked).
> - UI for the feature.
> 
> TODO:
> - Add saving dock state for dockable floaters.
> - Add LL-created default layouts and support for them.
> - Refactor system of updating lists - get rid of ugly static dirty and it's 
> check in draw.
> - Add saving of sidetray open/closed state, open tab, etc.
> 
> 
> This addresses bug STORM-2.
> http://jira.secondlife.com/browse/STORM-2
> 
> 
> Diffs
> -
> 
>   indra/llui/llfloater.h 422f636c3343 
>   indra/llui/llfloaterreg.h 422f636c3343 
>   indra/newview/CMakeLists.txt 422f636c3343 
>   indra/newview/llbottomtray.h 422f636c3343 
>   indra/newview/llbottomtray.cpp 422f636c3343 
>   indra/newview/llfloaterlayouts.h PRE-CREATION 
>   indra/newview/llfloaterlayouts.cpp PRE-CREATION 
>   indra/newview/llsidetray.h 422f636c3343 
>   indra/newview/llsidetray.cpp 422f636c3343 
>   indra/newview/llviewerfloaterreg.cpp 422f636c3343 
>   indra/newview/llviewermenu.cpp 422f636c3343 
>   indra/newview/skins/default/xui/en/floater_layouts.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/floater_save_layout.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/98/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] STORM-243 - simulator version notifications

[Kent Quirk (Q Linden)]

Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow suppression of the toast that tells you the simulator 
version changed when you changed to a new region. 

I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator versions live on 
the grid at any time? I don't mean "I can think of an obscure scenario when 
someone might care." I mean does anyone really need a notification about this, 
or can we just delete it?

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Lance Corrimal]

Am Dienstag, 18. Januar 2011, 16:22:45 schrieb Kent Quirk (Q Linden):
> Hi, folks. I've just commented on STORM-243, which requests that we have
> Yet Another Option to allow suppression of the toast that tells you the
> simulator version changed when you changed to a new region.
> 
> I think we should delete it entirely. Does anyone care to still get that
> notification, now that there are usually 3 different simulator versions
> live on the grid at any time? I don't mean "I can think of an obscure
> scenario when someone might care." I mean does anyone really need a
> notification about this, or can we just delete it?


on the contrary, i'm trying to port a patch from henri beauchamps cool viewer 
that makes that notification more detailed, as in it tells you the version of 
the sim you entered and the version of the sim you left.


bye,
LC

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

[Opensource Obscure]

Just to say this new feature looks very promising!

A question. The 3rd note says
"the files associated with saved layouts will be LLSD text files, so you can
email or paste layouts into a notecard to share with other users".
(the note also explains why this is not the ideal behaviour ever,
and also why we have to deal with it for now)

This sounds even cooler! ...but - how would that process of
sharing LLSD files exactly work?
I mean, where will users have to put those LLSD files?

here is the scenario I'm thinking about:

- a "teacher" (or mentor, friend, etc) is explaining to a new user
how to build in SL
- the teacher shares with the new user an LLSD file that contains
an ideal layout for building, and says "put this in your SL folder"
- the new user is now confused: many newbies don't know
the difference between the software folder and the settings folder,
and they don't know where those are;
this gets even worst to solve for people trying to help them,
because pathnames are different across different operating systems,
across different releases of the same o.s. - or because of localization.

possible solutions:
- add another option in Preferences to choose the folder where we keep layouts
- add a menu command to choose a specific layout file  - then the viewer
would copy that file into the actual settings folder.

Opensource Obscure
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: make PREHASH variables char const* const

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/
---

Review request for Viewer.


Summary
---

For the reason for this change, see 
https://jira.secondlife.com/browse/VWR-24487 and 
https://jira.secondlife.com/browse/VWR-24522

What I did:
In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant 
pointers to constants by search/replace. Then I tried to compile and added 
const qualifiers in dependent code as needed to stop the compiler complaining.

Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files 
have been generated from the message template. If this generation wasn't a 
one-off thing, the generating code must be changed, too, so it won't override 
this change here when the generation happens the next time.


This addresses bug VWR-24487.
http://jira.secondlife.com/browse/VWR-24487


Diffs
-

  doc/contributions.txt fc7e5dcf3059 
  indra/llmessage/message_prehash.h fc7e5dcf3059 
  indra/llmessage/message_prehash.cpp fc7e5dcf3059 
  indra/llprimitive/llprimitive.h fc7e5dcf3059 
  indra/llprimitive/llprimitive.cpp fc7e5dcf3059 
  indra/llprimitive/llvolumemessage.h fc7e5dcf3059 
  indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 
  indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 
  indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 

Diff: http://codereview.secondlife.com/r/100/diff


Testing
---

Compiled (standalone, 64bit Linux) with and without LL_TESTS.
Started the viewer, logged in, walked and flew around a bit. Everything seems 
to work.


Thanks,

Boroondas

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[WolfPup Lowenhar]

Q,

I believe the jira in question was wanting to suppress the popup but not the
notification itself so that it would still show up in chat history if you
were logging it or kept your chat history open all the time.

 

From: opensource-dev-boun...@lists.secondlife.com
[mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Kent Quirk
(Q Linden)
Sent: Tuesday, January 18, 2011 10:23 AM
To: OpenSource Mailing List
Subject: [opensource-dev] STORM-243 - simulator version notifications

 

Hi, folks. I've just commented on STORM-243, which requests that we have Yet
Another Option to allow suppression of the toast that tells you the
simulator version changed when you changed to a new region.

I think we should delete it entirely. Does anyone care to still get that
notification, now that there are usually 3 different simulator versions live
on the grid at any time? I don't mean "I can think of an obscure scenario
when someone might care." I mean does anyone really need a notification
about this, or can we just delete it?

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges 

  _  

No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1191 / Virus Database: 1435/3387 - Release Date: 01/17/11

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Opensource Obscure]

I guess most people on this list are personally interested in that
notification. Still, I think we're a very non-representative sample
of the whole SL userbase - especially with regards to tech details.

Off by default, with freedom to choose would be the best;
a Debug Setting would probably be good enough (since interested
people are "techie" enough to know how to get there);
should I choose between yes/no I would say "no" - remove them as
most SL users aren't interested in that information and/or don't know
what it means.
IMO

Opensource Obscure

On Tue, Jan 18, 2011 at 16:22, Kent Quirk (Q Linden)  wrote:
> Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
> Another Option to allow suppression of the toast that tells you the simulator 
> version changed when you changed to a new region.
>
> I think we should delete it entirely. Does anyone care to still get that 
> notification, now that there are usually 3 different simulator versions live 
> on the grid at any time? I don't mean "I can think of an obscure scenario 
> when someone might care." I mean does anyone really need a notification about 
> this, or can we just delete it?
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Kent Quirk (Q Linden)]

Can you please explain why you care? Is there a reason why you want a 
notification?

On Jan 18, 2011, at 10:28 AM, Lance Corrimal wrote:

> Am Dienstag, 18. Januar 2011, 16:22:45 schrieb Kent Quirk (Q Linden):
>> Hi, folks. I've just commented on STORM-243, which requests that we have
>> Yet Another Option to allow suppression of the toast that tells you the
>> simulator version changed when you changed to a new region.
>> 
>> I think we should delete it entirely. Does anyone care to still get that
>> notification, now that there are usually 3 different simulator versions
>> live on the grid at any time? I don't mean "I can think of an obscure
>> scenario when someone might care." I mean does anyone really need a
>> notification about this, or can we just delete it?
> 
> 
> on the contrary, i'm trying to port a patch from henri beauchamps cool viewer 
> that makes that notification more detailed, as in it tells you the version of 
> the sim you entered and the version of the sim you left.
> 
> 
> bye,
> LC
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Kent Quirk (Q Linden)]

Everyone wants more options. Why should this be an option?

Just because you're interested in knowing the version number, do you really 
need a notification of it? What does that give you that checking About Second 
Life doesn't give you?

On Jan 18, 2011, at 10:40 AM, Opensource Obscure wrote:

> I guess most people on this list are personally interested in that
> notification. Still, I think we're a very non-representative sample
> of the whole SL userbase - especially with regards to tech details.
> 
> Off by default, with freedom to choose would be the best;
> a Debug Setting would probably be good enough (since interested
> people are "techie" enough to know how to get there);
> should I choose between yes/no I would say "no" - remove them as
> most SL users aren't interested in that information and/or don't know
> what it means.
> IMO
> 
> Opensource Obscure
> 
> On Tue, Jan 18, 2011 at 16:22, Kent Quirk (Q Linden)  
> wrote:
>> Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
>> Another Option to allow suppression of the toast that tells you the 
>> simulator version changed when you changed to a new region.
>> 
>> I think we should delete it entirely. Does anyone care to still get that 
>> notification, now that there are usually 3 different simulator versions live 
>> on the grid at any time? I don't mean "I can think of an obscure scenario 
>> when someone might care." I mean does anyone really need a notification 
>> about this, or can we just delete it?
>> 
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting 
>> privileges
>> 

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Stickman]

> on the contrary, i'm trying to port a patch from henri beauchamps cool viewer
> that makes that notification more detailed, as in it tells you the version of
> the sim you entered and the version of the sim you left.

As Lance said, the notice as it is right now isn't very useful.

If it actually had more information, such as maybe the version you
were at and the version you're going to and allows you to click it to
get to the release notes, it would be significantly useful.

In its current state, it's possibly confusing/annoying to the standard
user, and not useful enough to the technical user.

That wasn't your question, though.

If it's not going to become more useful, I'd be up for deleting it. If
I'm curious about versions, I'd go check it manually anyway. I have to
already, since it doesn't tell me.

Switching argument gears, I've often had the idea of SL having two
clients, the standard user and the technical developer. Unfortunately,
this is an extremely limited view, as there is a huge range of users.
The "modular client" idea that went through the list a while back,
where LL makes a core system with some default modules and everyone
can make whatever addons they wanted, seemed like a really good idea
that allows for these "two clients" and everything inbetween. It would
also let people contribute by just making a quick little module rather
than a full client. But that's a different topic.

What's LL's direction for SL, anyway? Do they want to cater to the
technical developer? The artistic developer? The window-shopping user?
Socially inclined chatters? Sight seers? Besides bringing things up to
current technology, it's hard to see where LL's trying to go, and that
makes it hard to suggest things that would be more useful.

Stickman
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Tateru Nino]

Speaking as an unrepresentative sample of... err... one, I find the 
popup very useful - but *only* in certain defined periods where I am 
intending that it be an important part of what I'm doing (and it 
sometimes is). At that point, I *would* like more detail (exactly what 
version am I arriving in and what version have I arrived from). The rest 
of the time - being 99.5% of the time, I'd prefer it to default to off, 
and not see the popup at all.

On 19/01/2011 2:22 AM, Kent Quirk (Q Linden) wrote:
> Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
> Another Option to allow suppression of the toast that tells you the simulator 
> version changed when you changed to a new region.
>
> I think we should delete it entirely. Does anyone care to still get that 
> notification, now that there are usually 3 different simulator versions live 
> on the grid at any time? I don't mean "I can think of an obscure scenario 
> when someone might care." I mean does anyone really need a notification about 
> this, or can we just delete it?
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>

-- 
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Tateru Nino]

Well, connect up the network message system with a small plugin stub in 
python or something, expose the popup API to it, and I'm sure we can 
each decide for ourselves what events and messages should and shouldn't 
generate popups and under what circumstances. Then, perhaps, we could 
expose a few more APIs like chat/chat-history - as an example.

On 19/01/2011 3:00 AM, Kent Quirk (Q Linden) wrote:
> Everyone wants more options. Why should this be an option?
>
> Just because you're interested in knowing the version number, do you really 
> need a notification of it? What does that give you that checking About Second 
> Life doesn't give you?
>
> On Jan 18, 2011, at 10:40 AM, Opensource Obscure wrote:
>
>> I guess most people on this list are personally interested in that
>> notification. Still, I think we're a very non-representative sample
>> of the whole SL userbase - especially with regards to tech details.
>>
>> Off by default, with freedom to choose would be the best;
>> a Debug Setting would probably be good enough (since interested
>> people are "techie" enough to know how to get there);
>> should I choose between yes/no I would say "no" - remove them as
>> most SL users aren't interested in that information and/or don't know
>> what it means.
>> IMO
>>
>> Opensource Obscure
>>
>> On Tue, Jan 18, 2011 at 16:22, Kent Quirk (Q Linden)  
>> wrote:
>>> Hi, folks. I've just commented on STORM-243, which requests that we have 
>>> Yet Another Option to allow suppression of the toast that tells you the 
>>> simulator version changed when you changed to a new region.
>>>
>>> I think we should delete it entirely. Does anyone care to still get that 
>>> notification, now that there are usually 3 different simulator versions 
>>> live on the grid at any time? I don't mean "I can think of an obscure 
>>> scenario when someone might care." I mean does anyone really need a 
>>> notification about this, or can we just delete it?
>>>
>>> ___
>>> Policies and (un)subscribe information available here:
>>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>>> Please read the policies before posting to keep unmoderated posting 
>>> privileges
>>>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>

-- 
Tateru Nino
http://dwellonit.taterunino.net/

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-373 "Rename" context menu option disabled for incomplete inventory items

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/101/
---

Review request for Viewer.


Summary
---

Refresh the inventory context menu (which enables the "Rename" option) after 
the selected item(s) gets fetched.

I'm a bit worried by adding another inventory observer to each inventory panel, 
but I couldn't come up with a solution which is more elegant and affects 
performance less.


This addresses bug STORM-373.
http://jira.secondlife.com/browse/STORM-373


Diffs
-

  indra/newview/llfolderview.h 422f636c3343 
  indra/newview/llfolderview.cpp 422f636c3343 
  indra/newview/llinventorypanel.h 422f636c3343 
  indra/newview/llinventorypanel.cpp 422f636c3343 

Diff: http://codereview.secondlife.com/r/101/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Lance Corrimal]

Am Dienstag, 18. Januar 2011 schrieb Stickman:
> > on the contrary, i'm trying to port a patch from henri beauchamps
> > cool viewer that makes that notification more detailed, as in it
> > tells you the version of the sim you entered and the version of
> > the sim you left.
> 
> As Lance said, the notice as it is right now isn't very useful.
> 
> If it actually had more information, such as maybe the version you
> were at and the version you're going to and allows you to click it
> to get to the release notes, it would be significantly useful.

that is what henri's version does.


bye,
LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Ann Otoole]

Doesn't it add some minor overhead to region crossings? I don't care about it. 
The message does not say what server version you just entered so it is mostly 
an 
annoyance. If I need version info I know where it is. 


What I would like to see is region rating and a single letter server version 
code on the map without having to mouse float.





From: Kent Quirk (Q Linden) 

Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow suppression of the toast that tells you the simulator 
version changed when you changed to a new region. 


I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator versions live on 
the grid at any time? I don't mean "I can think of an obscure scenario when 
someone might care." I mean does anyone really need a notification about this, 
or can we just delete it?


  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24100 Settings.xml: redundant entries and unnecessary tag

[Kent Quirk]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/18/#review182
---

Ship it!


These changes are all reasonable. Please go ahead.

- Kent


On Dec. 23, 2010, 12:12 p.m., Jonathan Yap wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/18/
> ---
> 
> (Updated Dec. 23, 2010, 12:12 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> I wrote two programs that use settings.xml to produce this massive table:
> http://wiki.secondlife.com/wiki/Debug_Settings
> 
> While doing this I found 4 places with duplicate entries and 1 entry that is 
> repeated 4 times.  There is also a pair of unnecessary tags.
> 
> Having these cleaned out would make running my program, and thus updating the 
> wiki table, easier.
> 
> I've erased all but the last entry for these redundant debug settings.
> 
> 
> This addresses bug vwr-24100.
> http://jira.secondlife.com/browse/vwr-24100
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 46a990f8296f 
> 
> Diff: http://codereview.secondlife.com/r/18/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Mmeting today... was: Re: AW Groupies meeting tomorrow on mesh asset interop format

[Lawson English]

Today's AWG meeting at 9:30 AM pacific coast time will be streamed live 
to:  http://www.metanomics.net/community_forum  topic will be an open 
file format for mesh distribution between various virtual worlds
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: STORM-243 Suppress version change message in the viewer

[Vadim ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/109/
---

Review request for Viewer.


Summary
---

Removed the "You just entered a region using a different server version..." 
pop-up notification.


This addresses bug STORM-243.
http://jira.secondlife.com/browse/STORM-243


Diffs
-

  indra/newview/app_settings/settings.xml 422f636c3343 
  indra/newview/llviewermessage.cpp 422f636c3343 
  indra/newview/skins/default/xui/da/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/de/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/es/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/fr/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/it/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/ja/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/nl/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/pl/notifications.xml 422f636c3343 
  indra/newview/skins/default/xui/pt/notifications.xml 422f636c3343 

Diff: http://codereview.secondlife.com/r/109/diff


Testing
---


Thanks,

Vadim

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Review Request: DN-202: More aggressive caching of display names

[Oz Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/104/
---

Review request for Viewer.


Summary
---

Changes the caching of avatar display names and other information from
the People API to be more aggressive.

The expiration time (which is derived from the cache controls of the
HTTP responses), is now treated primarily as a maximum time before
which the name information should be refreshed.  When the ::get method
is called on an entry older than its expiration time, an attempt is
made to refresh the entry; if that attempt returns a failure, the
cached entry is returned anyway.

In the event of error returns from the People API when there is no
cached entry, the legacy name system is queried to create temporary
results; these are never cached in the LLAvatarNameCache.  This
applies both to HTTP request errors and to names that the PeopleAPI
explicitly returns as error responses (the latter were the ones that
previously created "???" temporary names - these are never created
within the viewer now).

The only time that entries are actually removed from the cache is a
check made immediately after loading and every 20 minutes
(MAX_UNREFRESHED_TIME) thereafter: entries whose expiration time is
more than 20 minutes in the past are deleted.

Also added extensive logging, mostly at DEBUG level, under the "AvNameCache" 
tag. 


This addresses bug dn-202.
http://jira.secondlife.com/browse/dn-202


Diffs
-

  indra/llcommon/llavatarname.h 422f636c3343 
  indra/llcommon/llavatarname.cpp 422f636c3343 
  indra/llmessage/llavatarnamecache.h 422f636c3343 
  indra/llmessage/llavatarnamecache.cpp 422f636c3343 
  indra/newview/llappviewer.cpp 422f636c3343 
  indra/newview/llimview.cpp 422f636c3343 

Diff: http://codereview.secondlife.com/r/104/diff


Testing
---

Hung out in busy welcome areas to get lots of name requests.

Confirmed that refresh behavior was correct, and observed a number of
HTTP error returns (both 499 Timeout, the most common, and 404 Not
Found) from the People API.  Saw that the fallback was correct (many
examples of both falling back to a previously cached display name and
to the legacy name when no cache was available).  All of these were
then correctly refreshed (the next attempt was almost always
successful).

Observed only a couple of cases of the People API returning unresolved
names (the case that previously lead to "???" being used).  The
behavior was correct, but some more testing on a development grid
where this error is forced may be a good idea.

Moved to a nice quiet empty region, and observed that the cache
cleaning occurred correctly after 20 minutes.

Confirmed that cached values were saved and reloaded correctly.


Thanks,

Oz

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Erin Mallory]

I would also like to see the toast moved.  it can be useful and would be more 
useful if it had the actual version.  but i would like to see it on the chat 
history instead.  in fact... it would be nice to have an option to have ALL 
remaining system notifications be optionally shown in chat history instead of 
as toasts.  for one thing it would log better i think, for another...  well 
toasts bother a rather significant portion of sl.   those with some forms of 
epilepsy, migraines, some forms of add... to name a few...

Erin/aka Cummere

Date: Tue, 18 Jan 2011 08:35:01 -0800
From: missannoto...@yahoo.com
To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] STORM-243 - simulator version notifications



Doesn't it add some minor overhead to region crossings? I don't care about it. 
The message does not say what server version you just entered so it is mostly 
an annoyance. If I need version info I know where it is. 

What I would like to see is region rating and a single letter server version 
code on the map without having to mouse float.

From: Kent Quirk (Q Linden) 

Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow
 suppression of the toast that tells you the simulator version changed when you 
changed to a new region. 

I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator versions live on 
the grid at any time? I don't mean "I can think of an obscure scenario when 
someone might care." I mean does anyone really need a notification about this, 
or can we just delete it?











  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-243 Suppress version change message in the viewer

[Wolfpup Lowenhar]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/109/#review183
---


Looks good to me since this is the removal of the Pop-up message and not total 
removal of the message that I can see, so message should be in chat history.

- Wolfpup


On Jan. 18, 2011, 9:02 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/109/
> ---
> 
> (Updated Jan. 18, 2011, 9:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Removed the "You just entered a region using a different server version..." 
> pop-up notification.
> 
> 
> This addresses bug STORM-243.
> http://jira.secondlife.com/browse/STORM-243
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 422f636c3343 
>   indra/newview/llviewermessage.cpp 422f636c3343 
>   indra/newview/skins/default/xui/da/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/de/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/es/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/fr/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/it/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/ja/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/nl/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/pl/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/pt/notifications.xml 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/109/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-243 Suppress version change message in the viewer

[Vadim ProductEngine]

> On Jan. 18, 2011, 9:28 a.m., Wolfpup Lowenhar wrote:
> > Looks good to me since this is the removal of the Pop-up message and not 
> > total removal of the message that I can see, so message should be in chat 
> > history.

This change drops adding the chat history entry as well.


- Vadim


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/109/#review183
---


On Jan. 18, 2011, 9:02 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/109/
> ---
> 
> (Updated Jan. 18, 2011, 9:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Removed the "You just entered a region using a different server version..." 
> pop-up notification.
> 
> 
> This addresses bug STORM-243.
> http://jira.secondlife.com/browse/STORM-243
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 422f636c3343 
>   indra/newview/llviewermessage.cpp 422f636c3343 
>   indra/newview/skins/default/xui/da/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/de/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/es/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/fr/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/it/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/ja/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/nl/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/pl/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/pt/notifications.xml 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/109/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/74/#review185
---



indra/llimage/llpngwrapper.cpp


Typo : change "gama" to "gamma"


- Merov


On Jan. 9, 2011, 6:59 a.m., Thickbrick Sleaford wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/74/
> ---
> 
> (Updated Jan. 9, 2011, 6:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Current code composites RGBA PNG images that contain a bKGD chunk down to 
> RGB, discarding the alpha channel. This patch removes that code, since it 
> contradicts purpose of the bKGD chunk as described in the PNG spec and as 
> commonly used.
> 
> 
> This addresses bug VWR-24420.
> http://jira.secondlife.com/browse/VWR-24420
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt UNKNOWN 
>   indra/llimage/llpngwrapper.h UNKNOWN 
>   indra/llimage/llpngwrapper.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/74/diff
> 
> 
> Testing
> ---
> 
> Tested uploading the 2 images attached to VWR-24420 with and without the 
> patch. Before patch, "bad alpha.png" was uploaded as RGB, after patch, both 
> images were uploaded as RGBA.
> 
> 
> Thanks,
> 
> Thickbrick
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/74/#review186
---

Ship it!


Other than the typo, no problem with that code. Good to fix all those alpha 
upload scenarios.

- Merov


On Jan. 9, 2011, 6:59 a.m., Thickbrick Sleaford wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/74/
> ---
> 
> (Updated Jan. 9, 2011, 6:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Current code composites RGBA PNG images that contain a bKGD chunk down to 
> RGB, discarding the alpha channel. This patch removes that code, since it 
> contradicts purpose of the bKGD chunk as described in the PNG spec and as 
> commonly used.
> 
> 
> This addresses bug VWR-24420.
> http://jira.secondlife.com/browse/VWR-24420
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt UNKNOWN 
>   indra/llimage/llpngwrapper.h UNKNOWN 
>   indra/llimage/llpngwrapper.cpp UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/74/diff
> 
> 
> Testing
> ---
> 
> Tested uploading the 2 images attached to VWR-24420 with and without the 
> patch. Before patch, "bad alpha.png" was uploaded as RGB, after patch, both 
> images were uploaded as RGBA.
> 
> 
> Thanks,
> 
> Thickbrick
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Erin Mallory]

to rephrase, yes I like them, thought i'd rather see them on the chat history 
and have more detailed.  but i can live without them if the majority really 
want to see them gone altogether.  for me it helps me during certain testing 
and stuff to know when ive changed server versions but that's really about it. 

From: angel_of_crim...@hotmail.com
To: missannoto...@yahoo.com; q...@lindenlab.com; 
opensource-dev@lists.secondlife.com
Date: Tue, 18 Jan 2011 12:04:09 -0500
Subject: Re: [opensource-dev] STORM-243 - simulator version notifications








I would also like to see the toast moved.  it can be useful and would be more 
useful if it had the actual version.  but i would like to see it on the chat 
history instead.  in fact... it would be nice to have an option to have ALL 
remaining system notifications be optionally shown in chat history instead of 
as toasts.  for one thing it would log better i think, for another...  well 
toasts bother a rather significant portion of sl.   those with some forms of 
epilepsy, migraines, some forms of add... to name a few...

Erin/aka Cummere

Date: Tue, 18 Jan 2011 08:35:01 -0800
From: missannoto...@yahoo.com
To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] STORM-243 - simulator version notifications



Doesn't it add some minor overhead to region crossings? I don't care about it. 
The message does not say what server version you just entered so it is mostly 
an annoyance. If I need version info I know where it is. 

What I would like to see is region rating and a single letter server version 
code on the map without having to mouse float.

From: Kent Quirk (Q Linden) 

Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow
 suppression of the toast that tells you the simulator version changed when you 
changed to a new region. 

I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator versions live on 
the grid at any time? I don't mean "I can think of an obscure scenario when 
someone might care." I mean does anyone really need a notification about this, 
or can we just delete it?











  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-373 "Rename" context menu option disabled for incomplete inventory items

[Seth ProductEngine]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/101/#review187
---

Ship it!


Looks good to me. Seems like adding another observer is necessary to deal with 
this issue. 

- Seth


On Jan. 18, 2011, 8:20 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/101/
> ---
> 
> (Updated Jan. 18, 2011, 8:20 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Refresh the inventory context menu (which enables the "Rename" option) after 
> the selected item(s) gets fetched.
> 
> I'm a bit worried by adding another inventory observer to each inventory 
> panel, but I couldn't come up with a solution which is more elegant and 
> affects performance less.
> 
> 
> This addresses bug STORM-373.
> http://jira.secondlife.com/browse/STORM-373
> 
> 
> Diffs
> -
> 
>   indra/newview/llfolderview.h 422f636c3343 
>   indra/newview/llfolderview.cpp 422f636c3343 
>   indra/newview/llinventorypanel.h 422f636c3343 
>   indra/newview/llinventorypanel.cpp 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/101/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24320: Don't dump callstacks at clean exit of viewer.

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/89/#review188
---

Ship it!


I do think this can be suppressed. It's not extremely useful in clean exit 
situations.

- Merov


On Jan. 14, 2011, 1 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/89/
> ---
> 
> (Updated Jan. 14, 2011, 1 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> See http://jira.secondlife.com/browse/VWR-24320
> 
> 
> This addresses bug VWR-24320.
> http://jira.secondlife.com/browse/VWR-24320
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/llappviewer.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/89/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: DN-202: More aggressive caching of display names

[Leyla Farazha]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/104/#review189
---

Ship it!


Looks great. Couldn't find any issues, except there was a "chached" instead of 
cached in a comment.  We'd had issues in the past deleting expired entries from 
the cache, because the occasional synchronous call would come back without data 
the first time.  But it looks like it only deletes them once it's been 20 
minutes and there haven't been any fresh updates, which should be a pretty rare 
case, and it'll assure that we don't fall back to legacy names when we don't 
have to.  Thanks for working on this code Oz :-)

- Leyla


On Jan. 18, 2011, 9:02 a.m., Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/104/
> ---
> 
> (Updated Jan. 18, 2011, 9:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Changes the caching of avatar display names and other information from
> the People API to be more aggressive.
> 
> The expiration time (which is derived from the cache controls of the
> HTTP responses), is now treated primarily as a maximum time before
> which the name information should be refreshed.  When the ::get method
> is called on an entry older than its expiration time, an attempt is
> made to refresh the entry; if that attempt returns a failure, the
> cached entry is returned anyway.
> 
> In the event of error returns from the People API when there is no
> cached entry, the legacy name system is queried to create temporary
> results; these are never cached in the LLAvatarNameCache.  This
> applies both to HTTP request errors and to names that the PeopleAPI
> explicitly returns as error responses (the latter were the ones that
> previously created "???" temporary names - these are never created
> within the viewer now).
> 
> The only time that entries are actually removed from the cache is a
> check made immediately after loading and every 20 minutes
> (MAX_UNREFRESHED_TIME) thereafter: entries whose expiration time is
> more than 20 minutes in the past are deleted.
> 
> Also added extensive logging, mostly at DEBUG level, under the "AvNameCache" 
> tag. 
> 
> 
> This addresses bug dn-202.
> http://jira.secondlife.com/browse/dn-202
> 
> 
> Diffs
> -
> 
>   indra/llcommon/llavatarname.h 422f636c3343 
>   indra/llcommon/llavatarname.cpp 422f636c3343 
>   indra/llmessage/llavatarnamecache.h 422f636c3343 
>   indra/llmessage/llavatarnamecache.cpp 422f636c3343 
>   indra/newview/llappviewer.cpp 422f636c3343 
>   indra/newview/llimview.cpp 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/104/diff
> 
> 
> Testing
> ---
> 
> Hung out in busy welcome areas to get lots of name requests.
> 
> Confirmed that refresh behavior was correct, and observed a number of
> HTTP error returns (both 499 Timeout, the most common, and 404 Not
> Found) from the People API.  Saw that the fallback was correct (many
> examples of both falling back to a previously cached display name and
> to the legacy name when no cache was available).  All of these were
> then correctly refreshed (the next attempt was almost always
> successful).
> 
> Observed only a couple of cases of the People API returning unresolved
> names (the case that previously lead to "???" being used).  The
> behavior was correct, but some more testing on a development grid
> where this error is forced may be a good idea.
> 
> Moved to a nice quiet empty region, and observed that the cache
> cleaning occurred correctly after 20 minutes.
> 
> Confirmed that cached values were saved and reloaded correctly.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Oskar Linden]

It does have use for people testing server. I'd say make it optional, more
informative, and disabled by default.

__Oskar

On Tue, Jan 18, 2011 at 11:22 AM, Erin Mallory  wrote:

>  to rephrase, yes I like them, thought i'd rather see them on the chat
> history and have more detailed.  but i can live without them if the majority
> really want to see them gone altogether.  for me it helps me during certain
> testing and stuff to know when ive changed server versions but that's really
> about it.
>
> --
> From: angel_of_crim...@hotmail.com
> To: missannoto...@yahoo.com; q...@lindenlab.com;
> opensource-dev@lists.secondlife.com
> Date: Tue, 18 Jan 2011 12:04:09 -0500
>
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>
> I would also like to see the toast moved.  it can be useful and would be
> more useful if it had the actual version.  but i would like to see it on the
> chat history instead.  in fact... it would be nice to have an option to have
> ALL remaining system notifications be optionally shown in chat history
> instead of as toasts.  for one thing it would log better i think, for
> another...  well toasts bother a rather significant portion of sl.   those
> with some forms of epilepsy, migraines, some forms of add... to name a
> few...
>
> Erin/aka Cummere
>
> --
> Date: Tue, 18 Jan 2011 08:35:01 -0800
> From: missannoto...@yahoo.com
> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>
> Doesn't it add some minor overhead to region crossings? I don't care about
> it. The message does not say what server version you just entered so it is
> mostly an annoyance. If I need version info I know where it is.
>
> What I would like to see is region rating and a single letter server
> version code on the map without having to mouse float.
>
> --
> *From:* Kent Quirk (Q Linden) 
> **
> Hi, folks. I've just commented on STORM-243, which requests that we have
> Yet Another Option to allow suppression of the toast that tells you the
> simulator version changed when you changed to a new region.
>
> I think we should delete it entirely. Does anyone care to still get that
> notification, now that there are usually 3 different simulator versions live
> on the grid at any time? I don't mean "I can think of an obscure scenario
> when someone might care." I mean does anyone really need a notification
> about this, or can we just delete it?
>
>
>
> ___ Policies and (un)subscribe
> information available here: 
> http://wiki.secondlife.com/wiki/OpenSource-DevPlease read the policies before 
> posting to keep unmoderated posting
> privileges
> ___ Policies and (un)subscribe
> information available here: 
> http://wiki.secondlife.com/wiki/OpenSource-DevPlease read the policies before 
> posting to keep unmoderated posting
> privileges
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24333: Hardening against use of getLindenUserDir() before logging in.

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/91/#review190
---

Ship it!


I haven't search for all instances of getLindenUserDir() in the whole code but, 
reading the diff, this all looks good to me.

- Merov


On Jan. 14, 2011, 1:05 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/91/
> ---
> 
> (Updated Jan. 14, 2011, 1:05 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Without this patch, getLindenUserDir() is sometimes used without
> checking if it returns an empty value, resulting in trying to open
> an empty file and then gracefully recovering from that. So, this
> patch doesn't really fix a bug. However it might prevent one in the
> future. Note that this DID lead to a bug in Viewer 1 code, so it's
> possible. The main threat is that some singleton class that uses
> getLindenUserDir (indirectly) is instantiated before logging in:
> A singleton is only created once and when it is initialized with
> an empty getLindenUserDir() then that can remain.
> 
> This patch aborts when the viewer is compiled in debug mode (not
> in release mode, when it will do what it did before this patch)
> and when getLindenUserDir() is called before it was initialized,
> unless the developer explicitely passes 'true' (empty_ok) to
> getLindenUserDir, signaling that they considered the possibility
> that the function is being called before the user logged in.
> 
> 
> This addresses bug VWR-24333.
> http://jira.secondlife.com/browse/VWR-24333
> 
> 
> Diffs
> -
> 
>   indra/llvfs/lldir.h 422f636c3343 
>   indra/llvfs/lldir.cpp 422f636c3343 
>   indra/newview/llappviewer.cpp 422f636c3343 
>   indra/newview/llbottomtray.cpp 422f636c3343 
>   indra/newview/llfilepicker.cpp 422f636c3343 
>   indra/newview/llnavigationbar.cpp 422f636c3343 
>   indra/newview/llsearchhistory.h 422f636c3343 
>   indra/newview/llurlhistory.cpp 422f636c3343 
>   indra/newview/llviewerinventory.cpp 422f636c3343 
>   indra/newview/llviewermedia.cpp 422f636c3343 
>   indra/newview/llvoiceclient.cpp 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/91/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Erin Mallory]

could even bury the option in the debug console... most people that would need 
to turn it on would not likely keep flipping it I would think... 

Date: Tue, 18 Jan 2011 11:32:53 -0800
From: os...@lindenlab.com
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] STORM-243 - simulator version notifications

It does have use for people testing server. I'd say make it optional, more 
informative, and disabled by default.

__Oskar

On Tue, Jan 18, 2011 at 11:22 AM, Erin Mallory  
wrote:






to rephrase, yes I like them, thought i'd rather see them on the chat history 
and have more detailed.  but i can live without them if the majority really 
want to see them gone altogether.  for me it helps me during certain testing 
and stuff to know when ive changed server versions but that's really about it. 


From: angel_of_crim...@hotmail.com
To: missannoto...@yahoo.com; q...@lindenlab.com; 
opensource-dev@lists.secondlife.com

Date: Tue, 18 Jan 2011 12:04:09 -0500
Subject: Re: [opensource-dev] STORM-243 - simulator version notifications








I would also like to see the toast moved.  it can be useful and would be more 
useful if it had the actual version.  but i would like to see it on the chat 
history instead.  in fact... it would be nice to have an option to have ALL 
remaining system notifications be optionally shown in chat history instead of 
as toasts.  for one thing it would log better i think, for another...  well 
toasts bother a rather significant portion of sl.   those with some forms of 
epilepsy, migraines, some forms of add... to name a few...


Erin/aka Cummere

Date: Tue, 18 Jan 2011 08:35:01 -0800
From: missannoto...@yahoo.com
To: q...@lindenlab.com; opensource-dev@lists.secondlife.com

Subject: Re: [opensource-dev] STORM-243 - simulator version notifications



Doesn't it add some minor overhead to region crossings? I don't care about it. 
The message does not say what server version you just entered so it is mostly 
an annoyance. If I need version info I know where it is. 


What I would like to see is region rating and a single letter server version 
code on the map without having to mouse float.


From: Kent Quirk (Q Linden) 


Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow
 suppression of the toast that tells you the simulator version changed when you 
changed to a new region. 

I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator versions live on 
the grid at any time? I don't mean "I can think of an obscure scenario when 
someone might care." I mean does anyone really need a notification about this, 
or can we just delete it?












  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  

___

Policies and (un)subscribe information available here:

http://wiki.secondlife.com/wiki/OpenSource-Dev

Please read the policies before posting to keep unmoderated posting privileges



___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Kadah]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

What Oskar said.

Plus there are frequently (every RC roll?) bugs in one more more of the
RCs that will effect a user till they relog on to a different RC server.
- From November to mid-late December I was effected one or another bugs
like that when ever I'd logg in to my home region that was Le Tigre and
later on, Blue Steel.

On 1/18/2011 11:32 AM, Oskar Linden wrote:
> It does have use for people testing server. I'd say make it optional,
> more informative, and disabled by default.
> 
> __Oskar
> 
> On Tue, Jan 18, 2011 at 11:22 AM, Erin Mallory
> mailto:angel_of_crim...@hotmail.com>> wrote:
> 
> to rephrase, yes I like them, thought i'd rather see them on the
> chat history and have more detailed.  but i can live without them if
> the majority really want to see them gone altogether.  for me it
> helps me during certain testing and stuff to know when ive changed
> server versions but that's really about it.
> 
> 
> From: angel_of_crim...@hotmail.com 
> To: missannoto...@yahoo.com ;
> q...@lindenlab.com ;
> opensource-dev@lists.secondlife.com
> 
> Date: Tue, 18 Jan 2011 12:04:09 -0500
> 
> Subject: Re: [opensource-dev] STORM-243 - simulator version
> notifications
> 
> I would also like to see the toast moved.  it can be useful and
> would be more useful if it had the actual version.  but i would like
> to see it on the chat history instead.  in fact... it would be nice
> to have an option to have ALL remaining system notifications be
> optionally shown in chat history instead of as toasts.  for one
> thing it would log better i think, for another...  well toasts
> bother a rather significant portion of sl.   those with some forms
> of epilepsy, migraines, some forms of add... to name a few...
> 
> Erin/aka Cummere
> 
> 
> Date: Tue, 18 Jan 2011 08:35:01 -0800
> From: missannoto...@yahoo.com 
> To: q...@lindenlab.com ;
> opensource-dev@lists.secondlife.com
> 
> Subject: Re: [opensource-dev] STORM-243 - simulator version
> notifications
> 
> Doesn't it add some minor overhead to region crossings? I don't care
> about it. The message does not say what server version you just
> entered so it is mostly an annoyance. If I need version info I know
> where it is.
> 
> What I would like to see is region rating and a single letter server
> version code on the map without having to mouse float.
> 
> 
> *From:* Kent Quirk (Q Linden)  >
> **
> Hi, folks. I've just commented on STORM-243, which requests that we
> have Yet Another Option to allow suppression of the toast that tells
> you the simulator version changed when you changed to a new region.
> 
> I think we should delete it entirely. Does anyone care to still get
> that notification, now that there are usually 3 different simulator
> versions live on the grid at any time? I don't mean "I can think of
> an obscure scenario when someone might care." I mean does anyone
> really need a notification about this, or can we just delete it?
> 
> 
> 
> ___ Policies and
> (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
> policies before posting to keep unmoderated posting privileges
> ___ Policies and
> (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
> policies before posting to keep unmoderated posting privileges
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
> 
> 
> 
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNNe5bAAoJEIdLfPRu7qE2R+AIAJJ+h5AuKJaZXFVUbkKNe3GY
ziqBbj+rGtGYnY8gNwTFm15O6EQlQpCmO3LFTBEDWbXtkOk9NselM8/iw5sTKBHd
2KL8PdsSyi/WxBPrpkoniHRYLxamBVDu/htkPTheOIxg+tcBUQMHwbdzb

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

[Merov Linden]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/90/#review191
---



indra/newview/lltexturecache.cpp


validate_idx being used in a test later, it's not just for (validate_idx == 
0) that the behavior will be different. I need to understand better what that 
idx is all about or you need to give a bit more explanation before I approve 
this diff.


- Merov


On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/90/
> ---
> 
> (Updated Jan. 14, 2011, 1:02 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Trivial patch, just removes stupidity.
> 
> 
> This addresses bug VWR-24321.
> http://jira.secondlife.com/browse/VWR-24321
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/lltexturecache.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/90/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Lance Corrimal]

Am Dienstag, 18. Januar 2011 schrieb Oskar Linden:
> It does have use for people testing server. I'd say make it
> optional, more informative, and disabled by default.

seconded!

wrap it in an if(gSavedSettings.getBOOL() ), and make it more detailed 
with links to the release notes to both server versions involved, and 
maybe the sim hostnames as well...


bye,
LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Twisted Laws]

Personally I see no reason for it and a user could have a simple script they 
are wearing that triggers on changed, CHANGE_REGION, that tells them the 
version of the server if they are interested.  
 
default
{
  on_rez(integer start_param)
  {
 llOwnerSay(llGetRegionName + " " + llGetEnv("sim_channel") + " " + 
llGetEnv("sim_version"));
  }
   changed(integer change)
   {
  if(change & CHANGED_REGION)
 {
 llOwnerSay(llGetRegionName + " " + llGetEnv("sim_channel") + " " + 
llGetEnv("sim_version"));
 }
  }
}
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: STORM-243 Suppress version change message in the viewer

[Kent Quirk]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/109/#review192
---

Ship it!


We've had the discussion and the change looks solid.

- Kent


On Jan. 18, 2011, 9:02 a.m., Vadim ProductEngine wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/109/
> ---
> 
> (Updated Jan. 18, 2011, 9:02 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Removed the "You just entered a region using a different server version..." 
> pop-up notification.
> 
> 
> This addresses bug STORM-243.
> http://jira.secondlife.com/browse/STORM-243
> 
> 
> Diffs
> -
> 
>   indra/newview/app_settings/settings.xml 422f636c3343 
>   indra/newview/llviewermessage.cpp 422f636c3343 
>   indra/newview/skins/default/xui/da/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/de/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/es/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/fr/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/it/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/ja/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/nl/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/pl/notifications.xml 422f636c3343 
>   indra/newview/skins/default/xui/pt/notifications.xml 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/109/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vadim
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Link times

[Ponzu]

Can you make the links verbose and compare the options?  Also, why would
first and second links differ?

Could be that CV did a major revision of the make files, or CMake, or
whatever is being used.

On Sun, Jan 16, 2011 at 10:49 AM, Aleric Inglewood <
aleric.inglew...@gmail.com> wrote:

> I'm afraid that VWR-24366 won't reduce link times significantly.
>
> On Fri, Jan 14, 2011 at 11:49 PM, Boroondas Gupte
>  wrote:
> > On 01/14/2011 06:04 PM, Jonathan Welch wrote:
> >
> > I just did a quick study on link times for various viewers on my 2Gb XP
> > system
> >
> > Viewer  1st link  2nd link
> > CV 1.220:53  0:24
> > SG 1.5  3:30  2:07
> > V2.5 6:18  6:01
> >
> > The long time for 2.5 be due to VWR-24366. Dunno why linking Cool Viewer
> > (that's what "CV" stands for, isn't it?) is so much quicker than SG 1.5,
> > though.
> >
> > Good news: A fix is being reviewed at
> > https://codereview.secondlife.com/r/95/
> >
> > Cheers,
> > Boroondas
> >
> > ___
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/OpenSource-Dev
> > Please read the policies before posting to keep unmoderated posting
> > privileges
> >
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Trilo Byte]

+1 for making it a debug setting (to choose whether you see notifications).  

The server version info would still be available in Help -> About as well as 
World -> Place Profile -> Region/Estate

On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:

> could even bury the option in the debug console... most people that would 
> need to turn it on would not likely keep flipping it I would think... 
> 
> Date: Tue, 18 Jan 2011 11:32:53 -0800
> From: os...@lindenlab.com
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> 
> It does have use for people testing server. I'd say make it optional, more 
> informative, and disabled by default.
> 
> __Oskar
> 
> On Tue, Jan 18, 2011 at 11:22 AM, Erin Mallory  
> wrote:
> to rephrase, yes I like them, thought i'd rather see them on the chat history 
> and have more detailed.  but i can live without them if the majority really 
> want to see them gone altogether.  for me it helps me during certain testing 
> and stuff to know when ive changed server versions but that's really about 
> it. 
> 
> From: angel_of_crim...@hotmail.com
> To: missannoto...@yahoo.com; q...@lindenlab.com; 
> opensource-dev@lists.secondlife.com
> Date: Tue, 18 Jan 2011 12:04:09 -0500
> 
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> 
> I would also like to see the toast moved.  it can be useful and would be more 
> useful if it had the actual version.  but i would like to see it on the chat 
> history instead.  in fact... it would be nice to have an option to have ALL 
> remaining system notifications be optionally shown in chat history instead of 
> as toasts.  for one thing it would log better i think, for another...  well 
> toasts bother a rather significant portion of sl.   those with some forms of 
> epilepsy, migraines, some forms of add... to name a few...
> 
> Erin/aka Cummere
> 
> Date: Tue, 18 Jan 2011 08:35:01 -0800
> From: missannoto...@yahoo.com
> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> 
> Doesn't it add some minor overhead to region crossings? I don't care about 
> it. The message does not say what server version you just entered so it is 
> mostly an annoyance. If I need version info I know where it is. 
> 
> What I would like to see is region rating and a single letter server version 
> code on the map without having to mouse float.
> 
> From: Kent Quirk (Q Linden) 
> 
> Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
> Another Option to allow suppression of the toast that tells you the simulator 
> version changed when you changed to a new region. 
> 
> I think we should delete it entirely. Does anyone care to still get that 
> notification, now that there are usually 3 different simulator versions live 
> on the grid at any time? I don't mean "I can think of an obscure scenario 
> when someone might care." I mean does anyone really need a notification about 
> this, or can we just delete it?
> 
> 
> 
> ___ Policies and (un)subscribe 
> information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
> Please read the policies before posting to keep unmoderated posting 
> privileges 
> ___ Policies and (un)subscribe 
> information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev 
> Please read the policies before posting to keep unmoderated posting privileges
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
> 
> 
> ___ Policies and (un)subscribe 
> information available here:http://wiki.secondlife.com/wiki/OpenSource-Dev 
> Please read the policies before posting to keep unmoderated posting 
> privileges ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Liny Odell]

Make that +2 for a debug setting

On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte  wrote:
> +1 for making it a debug setting (to choose whether you see notifications).
>
> The server version info would still be available in Help -> About as well as
> World -> Place Profile -> Region/Estate
> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
>
> could even bury the option in the debug console... most people that would
> need to turn it on would not likely keep flipping it I would think...
>
> 
> Date: Tue, 18 Jan 2011 11:32:53 -0800
> From: os...@lindenlab.com
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>
> It does have use for people testing server. I'd say make it optional, more
> informative, and disabled by default.
>
> __Oskar
>
> On Tue, Jan 18, 2011 at 11:22 AM, Erin
> Mallory  wrote:
>
> to rephrase, yes I like them, thought i'd rather see them on the chat
> history and have more detailed.  but i can live without them if the majority
> really want to see them gone altogether.  for me it helps me during certain
> testing and stuff to know when ive changed server versions but that's really
> about it.
>
> 
> From: angel_of_crim...@hotmail.com
> To: missannoto...@yahoo.com; q...@lindenlab.com; opensource-dev@lists.secondlife.com
> Date: Tue, 18 Jan 2011 12:04:09 -0500
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>
> I would also like to see the toast moved.  it can be useful and would be
> more useful if it had the actual version.  but i would like to see it on the
> chat history instead.  in fact... it would be nice to have an option to have
> ALL remaining system notifications be optionally shown in chat history
> instead of as toasts.  for one thing it would log better i think, for
> another...  well toasts bother a rather significant portion of sl.   those
> with some forms of epilepsy, migraines, some forms of add... to name a
> few...
>
> Erin/aka Cummere
>
> 
> Date: Tue, 18 Jan 2011 08:35:01 -0800
> From: missannoto...@yahoo.com
> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>
> Doesn't it add some minor overhead to region crossings? I don't care about
> it. The message does not say what server version you just entered so it is
> mostly an annoyance. If I need version info I know where it is.
>
> What I would like to see is region rating and a single letter server version
> code on the map without having to mouse float.
>
> 
> From: Kent Quirk (Q Linden) 
>
> Hi, folks. I've just commented on STORM-243, which requests that we have Yet
> Another Option to allow suppression of the toast that tells you the
> simulator version changed when you changed to a new region.
>
> I think we should delete it entirely. Does anyone care to still get that
> notification, now that there are usually 3 different simulator versions live
> on the grid at any time? I don't mean "I can think of an obscure scenario
> when someone might care." I mean does anyone really need a notification
> about this, or can we just delete it?
>
>
>
> ___ Policies and (un)subscribe
> information available
> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
> policies before posting to keep unmoderated posting privileges
> ___ Policies and (un)subscribe
> information available
> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
> policies before posting to keep unmoderated posting privileges
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
>
> ___ Policies and (un)subscribe
> information available
> here:http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies
> before posting to keep unmoderated posting
> privileges ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Kent Quirk (Q Linden)]

It's not gonna be a debug setting. The information's available to put it on a 
HUD if you care.  We're pulling the feature and simplifying the viewer.

On Jan 18, 2011, at 4:35 PM, Liny Odell wrote:

> Make that +2 for a debug setting
> 
> On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte  wrote:
>> +1 for making it a debug setting (to choose whether you see notifications).
>> 
>> The server version info would still be available in Help -> About as well as
>> World -> Place Profile -> Region/Estate
>> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
>> 
>> could even bury the option in the debug console... most people that would
>> need to turn it on would not likely keep flipping it I would think...
>> 
>> 
>> Date: Tue, 18 Jan 2011 11:32:53 -0800
>> From: os...@lindenlab.com
>> To: opensource-dev@lists.secondlife.com
>> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>> 
>> It does have use for people testing server. I'd say make it optional, more
>> informative, and disabled by default.
>> 
>> __Oskar
>> 
>> On Tue, Jan 18, 2011 at 11:22 AM, Erin
>> Mallory  wrote:
>> 
>> to rephrase, yes I like them, thought i'd rather see them on the chat
>> history and have more detailed.  but i can live without them if the majority
>> really want to see them gone altogether.  for me it helps me during certain
>> testing and stuff to know when ive changed server versions but that's really
>> about it.
>> 
>> 
>> From: angel_of_crim...@hotmail.com
>> To: missannoto...@yahoo.com; q...@lindenlab.com; 
>> opensource-dev@lists.secondlife.com
>> Date: Tue, 18 Jan 2011 12:04:09 -0500
>> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>> 
>> I would also like to see the toast moved.  it can be useful and would be
>> more useful if it had the actual version.  but i would like to see it on the
>> chat history instead.  in fact... it would be nice to have an option to have
>> ALL remaining system notifications be optionally shown in chat history
>> instead of as toasts.  for one thing it would log better i think, for
>> another...  well toasts bother a rather significant portion of sl.   those
>> with some forms of epilepsy, migraines, some forms of add... to name a
>> few...
>> 
>> Erin/aka Cummere
>> 
>> 
>> Date: Tue, 18 Jan 2011 08:35:01 -0800
>> From: missannoto...@yahoo.com
>> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
>> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>> 
>> Doesn't it add some minor overhead to region crossings? I don't care about
>> it. The message does not say what server version you just entered so it is
>> mostly an annoyance. If I need version info I know where it is.
>> 
>> What I would like to see is region rating and a single letter server version
>> code on the map without having to mouse float.
>> 
>> 
>> From: Kent Quirk (Q Linden) 
>> 
>> Hi, folks. I've just commented on STORM-243, which requests that we have Yet
>> Another Option to allow suppression of the toast that tells you the
>> simulator version changed when you changed to a new region.
>> 
>> I think we should delete it entirely. Does anyone care to still get that
>> notification, now that there are usually 3 different simulator versions live
>> on the grid at any time? I don't mean "I can think of an obscure scenario
>> when someone might care." I mean does anyone really need a notification
>> about this, or can we just delete it?
>> 
>> 
>> 
>> ___ Policies and (un)subscribe
>> information available
>> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
>> policies before posting to keep unmoderated posting privileges
>> ___ Policies and (un)subscribe
>> information available
>> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
>> policies before posting to keep unmoderated posting privileges
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting
>> privileges
>> 
>> 
>> ___ Policies and (un)subscribe
>> information available
>> here:http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies
>> before posting to keep unmoderated posting
>> privileges ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting
>> privileges
>> 
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the p

Re: [opensource-dev] STORM-243 - simulator version notifications

[Stickman]

> simplifying the viewer.

Is this the answer to my question about the ultimate direction LL is
taking for the official client?

Stickman
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Erin Mallory]

I can live with that. I got much more important features /design issues to 
fight over.  :)  


> From: q...@lindenlab.com
> Date: Tue, 18 Jan 2011 16:37:34 -0500
> To: liny.od...@phoenixviewer.com
> CC: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> 
> It's not gonna be a debug setting. The information's available to put it on a 
> HUD if you care.  We're pulling the feature and simplifying the viewer.
> 
> On Jan 18, 2011, at 4:35 PM, Liny Odell wrote:
> 
> > Make that +2 for a debug setting
> > 
> > On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte  wrote:
> >> +1 for making it a debug setting (to choose whether you see notifications).
> >> 
> >> The server version info would still be available in Help -> About as well 
> >> as
> >> World -> Place Profile -> Region/Estate
> >> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
> >> 
> >> could even bury the option in the debug console... most people that would
> >> need to turn it on would not likely keep flipping it I would think...
> >> 
> >> 
> >> Date: Tue, 18 Jan 2011 11:32:53 -0800
> >> From: os...@lindenlab.com
> >> To: opensource-dev@lists.secondlife.com
> >> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> >> 
> >> It does have use for people testing server. I'd say make it optional, more
> >> informative, and disabled by default.
> >> 
> >> __Oskar
> >> 
> >> On Tue, Jan 18, 2011 at 11:22 AM, Erin
> >> Mallory  wrote:
> >> 
> >> to rephrase, yes I like them, thought i'd rather see them on the chat
> >> history and have more detailed.  but i can live without them if the 
> >> majority
> >> really want to see them gone altogether.  for me it helps me during certain
> >> testing and stuff to know when ive changed server versions but that's 
> >> really
> >> about it.
> >> 
> >> 
> >> From: angel_of_crim...@hotmail.com
> >> To: missannoto...@yahoo.com; q...@lindenlab.com; 
> >> opensource-dev@lists.secondlife.com
> >> Date: Tue, 18 Jan 2011 12:04:09 -0500
> >> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> >> 
> >> I would also like to see the toast moved.  it can be useful and would be
> >> more useful if it had the actual version.  but i would like to see it on 
> >> the
> >> chat history instead.  in fact... it would be nice to have an option to 
> >> have
> >> ALL remaining system notifications be optionally shown in chat history
> >> instead of as toasts.  for one thing it would log better i think, for
> >> another...  well toasts bother a rather significant portion of sl.   those
> >> with some forms of epilepsy, migraines, some forms of add... to name a
> >> few...
> >> 
> >> Erin/aka Cummere
> >> 
> >> 
> >> Date: Tue, 18 Jan 2011 08:35:01 -0800
> >> From: missannoto...@yahoo.com
> >> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
> >> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> >> 
> >> Doesn't it add some minor overhead to region crossings? I don't care about
> >> it. The message does not say what server version you just entered so it is
> >> mostly an annoyance. If I need version info I know where it is.
> >> 
> >> What I would like to see is region rating and a single letter server 
> >> version
> >> code on the map without having to mouse float.
> >> 
> >> 
> >> From: Kent Quirk (Q Linden) 
> >> 
> >> Hi, folks. I've just commented on STORM-243, which requests that we have 
> >> Yet
> >> Another Option to allow suppression of the toast that tells you the
> >> simulator version changed when you changed to a new region.
> >> 
> >> I think we should delete it entirely. Does anyone care to still get that
> >> notification, now that there are usually 3 different simulator versions 
> >> live
> >> on the grid at any time? I don't mean "I can think of an obscure scenario
> >> when someone might care." I mean does anyone really need a notification
> >> about this, or can we just delete it?
> >> 
> >> 
> >> 
> >> ___ Policies and (un)subscribe
> >> information available
> >> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
> >> policies before posting to keep unmoderated posting privileges
> >> ___ Policies and (un)subscribe
> >> information available
> >> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
> >> policies before posting to keep unmoderated posting privileges
> >> ___
> >> Policies and (un)subscribe information available here:
> >> http://wiki.secondlife.com/wiki/OpenSource-Dev
> >> Please read the policies before posting to keep unmoderated posting
> >> privileges
> >> 
> >> 
> >> ___ Policies and (un)subscribe
> >> information availa

Re: [opensource-dev] STORM-243 - simulator version notifications

[Latif Khalifa]

For the record:

+1 for making it optional, with a debug setting default to off.

The viewer has such wonderful instrumentation and debug facilities.
Removing them in the name of "simplifying" is a big mistake in my
opinion.

On Tue, Jan 18, 2011 at 10:37 PM, Kent Quirk (Q Linden)  
wrote:
> It's not gonna be a debug setting. The information's available to put it on a 
> HUD if you care.  We're pulling the feature and simplifying the viewer.
>
> On Jan 18, 2011, at 4:35 PM, Liny Odell wrote:
>
>> Make that +2 for a debug setting
>>
>> On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte  wrote:
>>> +1 for making it a debug setting (to choose whether you see notifications).
>>>
>>> The server version info would still be available in Help -> About as well as
>>> World -> Place Profile -> Region/Estate
>>> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
>>>
>>> could even bury the option in the debug console... most people that would
>>> need to turn it on would not likely keep flipping it I would think...
>>>
>>> 
>>> Date: Tue, 18 Jan 2011 11:32:53 -0800
>>> From: os...@lindenlab.com
>>> To: opensource-dev@lists.secondlife.com
>>> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>>>
>>> It does have use for people testing server. I'd say make it optional, more
>>> informative, and disabled by default.
>>>
>>> __Oskar
>>>
>>> On Tue, Jan 18, 2011 at 11:22 AM, Erin
>>> Mallory  wrote:
>>>
>>> to rephrase, yes I like them, thought i'd rather see them on the chat
>>> history and have more detailed.  but i can live without them if the majority
>>> really want to see them gone altogether.  for me it helps me during certain
>>> testing and stuff to know when ive changed server versions but that's really
>>> about it.
>>>
>>> 
>>> From: angel_of_crim...@hotmail.com
>>> To: missannoto...@yahoo.com; q...@lindenlab.com; 
>>> opensource-dev@lists.secondlife.com
>>> Date: Tue, 18 Jan 2011 12:04:09 -0500
>>> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>>>
>>> I would also like to see the toast moved.  it can be useful and would be
>>> more useful if it had the actual version.  but i would like to see it on the
>>> chat history instead.  in fact... it would be nice to have an option to have
>>> ALL remaining system notifications be optionally shown in chat history
>>> instead of as toasts.  for one thing it would log better i think, for
>>> another...  well toasts bother a rather significant portion of sl.   those
>>> with some forms of epilepsy, migraines, some forms of add... to name a
>>> few...
>>>
>>> Erin/aka Cummere
>>>
>>> 
>>> Date: Tue, 18 Jan 2011 08:35:01 -0800
>>> From: missannoto...@yahoo.com
>>> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
>>> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>>>
>>> Doesn't it add some minor overhead to region crossings? I don't care about
>>> it. The message does not say what server version you just entered so it is
>>> mostly an annoyance. If I need version info I know where it is.
>>>
>>> What I would like to see is region rating and a single letter server version
>>> code on the map without having to mouse float.
>>>
>>> 
>>> From: Kent Quirk (Q Linden) 
>>>
>>> Hi, folks. I've just commented on STORM-243, which requests that we have Yet
>>> Another Option to allow suppression of the toast that tells you the
>>> simulator version changed when you changed to a new region.
>>>
>>> I think we should delete it entirely. Does anyone care to still get that
>>> notification, now that there are usually 3 different simulator versions live
>>> on the grid at any time? I don't mean "I can think of an obscure scenario
>>> when someone might care." I mean does anyone really need a notification
>>> about this, or can we just delete it?
>>>
>>>
>>>
>>> ___ Policies and (un)subscribe
>>> information available
>>> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
>>> policies before posting to keep unmoderated posting privileges
>>> ___ Policies and (un)subscribe
>>> information available
>>> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
>>> policies before posting to keep unmoderated posting privileges
>>> ___
>>> Policies and (un)subscribe information available here:
>>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>>> Please read the policies before posting to keep unmoderated posting
>>> privileges
>>>
>>>
>>> ___ Policies and (un)subscribe
>>> information available
>>> here:http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies
>>> before posting to keep unmoderated posting
>>> privileges ___
>

Re: [opensource-dev] STORM-243 - simulator version notifications

[Liny Odell]

So LL is wanting those that want to know that they have enterd a
region running a different sim version to wear an object with yet
another script on their av? I have two words to say about that
:"script limits", and I'm going to leave it at that (there is already
enough discussion about it elsewhere).

On Tue, Jan 18, 2011 at 1:49 PM, Erin Mallory
 wrote:
> I can live with that. I got much more important features /design issues to
> fight over.  :)
>
>
>> From: q...@lindenlab.com
>> Date: Tue, 18 Jan 2011 16:37:34 -0500
>> To: liny.od...@phoenixviewer.com
>> CC: opensource-dev@lists.secondlife.com
>> Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
>>
>> It's not gonna be a debug setting. The information's available to put it
>> on a HUD if you care. We're pulling the feature and simplifying the viewer.
>>
>> On Jan 18, 2011, at 4:35 PM, Liny Odell wrote:
>>
>> > Make that +2 for a debug setting
>> >
>> > On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte 
>> > wrote:
>> >> +1 for making it a debug setting (to choose whether you see
>> >> notifications).
>> >>
>> >> The server version info would still be available in Help -> About as
>> >> well as
>> >> World -> Place Profile -> Region/Estate
>> >> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
>> >>
>> >> could even bury the option in the debug console... most people that
>> >> would
>> >> need to turn it on would not likely keep flipping it I would think...
>> >>
>> >> 
>> >> Date: Tue, 18 Jan 2011 11:32:53 -0800
>> >> From: os...@lindenlab.com
>> >> To: opensource-dev@lists.secondlife.com
>> >> Subject: Re: [opensource-dev] STORM-243 - simulator version
>> >> notifications
>> >>
>> >> It does have use for people testing server. I'd say make it optional,
>> >> more
>> >> informative, and disabled by default.
>> >>
>> >> __Oskar
>> >>
>> >> On Tue, Jan 18, 2011 at 11:22 AM, Erin
>> >> Mallory  wrote:
>> >>
>> >> to rephrase, yes I like them, thought i'd rather see them on the chat
>> >> history and have more detailed. but i can live without them if the
>> >> majority
>> >> really want to see them gone altogether. for me it helps me during
>> >> certain
>> >> testing and stuff to know when ive changed server versions but that's
>> >> really
>> >> about it.
>> >>
>> >> 
>> >> From: angel_of_crim...@hotmail.com
>> >> To: missannoto...@yahoo.com; q...@lindenlab.com;
>> >> opensource-dev@lists.secondlife.com
>> >> Date: Tue, 18 Jan 2011 12:04:09 -0500
>> >> Subject: Re: [opensource-dev] STORM-243 - simulator version
>> >> notifications
>> >>
>> >> I would also like to see the toast moved. it can be useful and would be
>> >> more useful if it had the actual version. but i would like to see it on
>> >> the
>> >> chat history instead. in fact... it would be nice to have an option to
>> >> have
>> >> ALL remaining system notifications be optionally shown in chat history
>> >> instead of as toasts. for one thing it would log better i think, for
>> >> another... well toasts bother a rather significant portion of sl. those
>> >> with some forms of epilepsy, migraines, some forms of add... to name a
>> >> few...
>> >>
>> >> Erin/aka Cummere
>> >>
>> >> 
>> >> Date: Tue, 18 Jan 2011 08:35:01 -0800
>> >> From: missannoto...@yahoo.com
>> >> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
>> >> Subject: Re: [opensource-dev] STORM-243 - simulator version
>> >> notifications
>> >>
>> >> Doesn't it add some minor overhead to region crossings? I don't care
>> >> about
>> >> it. The message does not say what server version you just entered so it
>> >> is
>> >> mostly an annoyance. If I need version info I know where it is.
>> >>
>> >> What I would like to see is region rating and a single letter server
>> >> version
>> >> code on the map without having to mouse float.
>> >>
>> >> 
>> >> From: Kent Quirk (Q Linden) 
>> >>
>> >> Hi, folks. I've just commented on STORM-243, which requests that we
>> >> have Yet
>> >> Another Option to allow suppression of the toast that tells you the
>> >> simulator version changed when you changed to a new region.
>> >>
>> >> I think we should delete it entirely. Does anyone care to still get
>> >> that
>> >> notification, now that there are usually 3 different simulator versions
>> >> live
>> >> on the grid at any time? I don't mean "I can think of an obscure
>> >> scenario
>> >> when someone might care." I mean does anyone really need a notification
>> >> about this, or can we just delete it?
>> >>
>> >>
>> >>
>> >> ___ Policies and
>> >> (un)subscribe
>> >> information available
>> >> here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the
>> >> policies before posting to keep unmoderated posting privileges
>> >> ___ Policies and
>> >> (un)subscribe
>> >> information available
>> >> he

Re: [opensource-dev] STORM-243 - simulator version notifications

[Sarah (Esbee) Kuehnle]

The data is available via LSL -
llGetEnv().
If you think about it, it makes much more sense for this to be a HUD for
Residents who are interested in the information. For casual Second Life
users, this information creates additional notification pop-ups and create
confusion for people who don't know or care that the regions they enter are
running different server versions.

This is not a feature belongs in the Viewer. If there's more data you want
out of llGetEnv(), I'd suggest filing an SVC feature request.

--Esbee


On Tue, Jan 18, 2011 at 4:49 PM, Erin Mallory
wrote:

>  I can live with that. I got much more important features /design issues to
> fight over.  :)
>
>
> > From: q...@lindenlab.com
> > Date: Tue, 18 Jan 2011 16:37:34 -0500
> > To: liny.od...@phoenixviewer.com
> > CC: opensource-dev@lists.secondlife.com
>
> > Subject: Re: [opensource-dev] STORM-243 - simulator version notifications
> >
> > It's not gonna be a debug setting. The information's available to put it
> on a HUD if you care. We're pulling the feature and simplifying the viewer.
> >
> > On Jan 18, 2011, at 4:35 PM, Liny Odell wrote:
> >
> > > Make that +2 for a debug setting
> > >
> > > On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte 
> wrote:
> > >> +1 for making it a debug setting (to choose whether you see
> notifications).
> > >>
> > >> The server version info would still be available in Help -> About as
> well as
> > >> World -> Place Profile -> Region/Estate
> > >> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
> > >>
> > >> could even bury the option in the debug console... most people that
> would
> > >> need to turn it on would not likely keep flipping it I would think...
> > >>
> > >> 
> > >> Date: Tue, 18 Jan 2011 11:32:53 -0800
> > >> From: os...@lindenlab.com
> > >> To: opensource-dev@lists.secondlife.com
> > >> Subject: Re: [opensource-dev] STORM-243 - simulator version
> notifications
> > >>
> > >> It does have use for people testing server. I'd say make it optional,
> more
> > >> informative, and disabled by default.
> > >>
> > >> __Oskar
> > >>
> > >> On Tue, Jan 18, 2011 at 11:22 AM, Erin
> > >> Mallory  wrote:
> > >>
> > >> to rephrase, yes I like them, thought i'd rather see them on the chat
> > >> history and have more detailed. but i can live without them if the
> majority
> > >> really want to see them gone altogether. for me it helps me during
> certain
> > >> testing and stuff to know when ive changed server versions but that's
> really
> > >> about it.
> > >>
> > >> 
> > >> From: angel_of_crim...@hotmail.com
> > >> To: missannoto...@yahoo.com; q...@lindenlab.com;
> opensource-dev@lists.secondlife.com
> > >> Date: Tue, 18 Jan 2011 12:04:09 -0500
> > >> Subject: Re: [opensource-dev] STORM-243 - simulator version
> notifications
> > >>
> > >> I would also like to see the toast moved. it can be useful and would
> be
> > >> more useful if it had the actual version. but i would like to see it
> on the
> > >> chat history instead. in fact... it would be nice to have an option to
> have
> > >> ALL remaining system notifications be optionally shown in chat history
> > >> instead of as toasts. for one thing it would log better i think, for
> > >> another... well toasts bother a rather significant portion of sl.
> those
> > >> with some forms of epilepsy, migraines, some forms of add... to name a
> > >> few...
> > >>
> > >> Erin/aka Cummere
> > >>
> > >> 
> > >> Date: Tue, 18 Jan 2011 08:35:01 -0800
> > >> From: missannoto...@yahoo.com
> > >> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
> > >> Subject: Re: [opensource-dev] STORM-243 - simulator version
> notifications
> > >>
> > >> Doesn't it add some minor overhead to region crossings? I don't care
> about
> > >> it. The message does not say what server version you just entered so
> it is
> > >> mostly an annoyance. If I need version info I know where it is.
> > >>
> > >> What I would like to see is region rating and a single letter server
> version
> > >> code on the map without having to mouse float.
> > >>
> > >> 
> > >> From: Kent Quirk (Q Linden) 
> > >>
> > >> Hi, folks. I've just commented on STORM-243, which requests that we
> have Yet
> > >> Another Option to allow suppression of the toast that tells you the
> > >> simulator version changed when you changed to a new region.
> > >>
> > >> I think we should delete it entirely. Does anyone care to still get
> that
> > >> notification, now that there are usually 3 different simulator
> versions live
> > >> on the grid at any time? I don't mean "I can think of an obscure
> scenario
> > >> when someone might care." I mean does anyone really need a
> notification
> > >> about this, or can we just delete it?
> > >>
> > >>
> > >>
> > >> ___ Policies and
> (un)subscribe
> > >> information avail

Re: [opensource-dev] STORM-243 - simulator version notifications

[Latif Khalifa]

Making the server version notifications feature disabled by default,
but keeping the option to enable it with more debug info in it
accomplishes the both sides nicely. It doesn't confuse the casual user
and it helps a pro make SL better.

Removing stuff just for the sake of simplicity, without considering
other criteria, is counter productive. You could remove "confusing"
statistics panel (ctrl-shift-1) next? After all the "casual Second
Life user" ¨must be mystified with it (and LSL can tell you time
dilation just fine). How about all the fast timers/texture console,
etc etc.

Again, instrumentation of the viewer for debugging is one of its strengths.

On Tue, Jan 18, 2011 at 10:58 PM, Sarah (Esbee) Kuehnle
 wrote:
> The data is available via LSL - llGetEnv(). If you think about it, it makes
> much more sense for this to be a HUD for Residents who are interested in the
> information. For casual Second Life users, this information creates
> additional notification pop-ups and create confusion for people who don't
> know or care that the regions they enter are running different server
> versions.
>
> This is not a feature belongs in the Viewer. If there's more data you want
> out of llGetEnv(), I'd suggest filing an SVC feature request.
>
> --Esbee
>
>
> On Tue, Jan 18, 2011 at 4:49 PM, Erin Mallory 
> wrote:
>>
>> I can live with that. I got much more important features /design issues to
>> fight over.  :)
>>
>>
>> > From: q...@lindenlab.com
>> > Date: Tue, 18 Jan 2011 16:37:34 -0500
>> > To: liny.od...@phoenixviewer.com
>> > CC: opensource-dev@lists.secondlife.com
>> > Subject: Re: [opensource-dev] STORM-243 - simulator version
>> > notifications
>> >
>> > It's not gonna be a debug setting. The information's available to put it
>> > on a HUD if you care. We're pulling the feature and simplifying the viewer.
>> >
>> > On Jan 18, 2011, at 4:35 PM, Liny Odell wrote:
>> >
>> > > Make that +2 for a debug setting
>> > >
>> > > On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte 
>> > > wrote:
>> > >> +1 for making it a debug setting (to choose whether you see
>> > >> notifications).
>> > >>
>> > >> The server version info would still be available in Help -> About as
>> > >> well as
>> > >> World -> Place Profile -> Region/Estate
>> > >> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
>> > >>
>> > >> could even bury the option in the debug console... most people that
>> > >> would
>> > >> need to turn it on would not likely keep flipping it I would think...
>> > >>
>> > >> 
>> > >> Date: Tue, 18 Jan 2011 11:32:53 -0800
>> > >> From: os...@lindenlab.com
>> > >> To: opensource-dev@lists.secondlife.com
>> > >> Subject: Re: [opensource-dev] STORM-243 - simulator version
>> > >> notifications
>> > >>
>> > >> It does have use for people testing server. I'd say make it optional,
>> > >> more
>> > >> informative, and disabled by default.
>> > >>
>> > >> __Oskar
>> > >>
>> > >> On Tue, Jan 18, 2011 at 11:22 AM, Erin
>> > >> Mallory  wrote:
>> > >>
>> > >> to rephrase, yes I like them, thought i'd rather see them on the chat
>> > >> history and have more detailed. but i can live without them if the
>> > >> majority
>> > >> really want to see them gone altogether. for me it helps me during
>> > >> certain
>> > >> testing and stuff to know when ive changed server versions but that's
>> > >> really
>> > >> about it.
>> > >>
>> > >> 
>> > >> From: angel_of_crim...@hotmail.com
>> > >> To: missannoto...@yahoo.com; q...@lindenlab.com;
>> > >> opensource-dev@lists.secondlife.com
>> > >> Date: Tue, 18 Jan 2011 12:04:09 -0500
>> > >> Subject: Re: [opensource-dev] STORM-243 - simulator version
>> > >> notifications
>> > >>
>> > >> I would also like to see the toast moved. it can be useful and would
>> > >> be
>> > >> more useful if it had the actual version. but i would like to see it
>> > >> on the
>> > >> chat history instead. in fact... it would be nice to have an option
>> > >> to have
>> > >> ALL remaining system notifications be optionally shown in chat
>> > >> history
>> > >> instead of as toasts. for one thing it would log better i think, for
>> > >> another... well toasts bother a rather significant portion of sl.
>> > >> those
>> > >> with some forms of epilepsy, migraines, some forms of add... to name
>> > >> a
>> > >> few...
>> > >>
>> > >> Erin/aka Cummere
>> > >>
>> > >> 
>> > >> Date: Tue, 18 Jan 2011 08:35:01 -0800
>> > >> From: missannoto...@yahoo.com
>> > >> To: q...@lindenlab.com; opensource-dev@lists.secondlife.com
>> > >> Subject: Re: [opensource-dev] STORM-243 - simulator version
>> > >> notifications
>> > >>
>> > >> Doesn't it add some minor overhead to region crossings? I don't care
>> > >> about
>> > >> it. The message does not say what server version you just entered so
>> > >> it is
>> > >> mostly an annoyance. If I need version info I know where it is.
>> > >>
>> > >> What I would like to see is region rating and a s

[opensource-dev] VS 2010 Express Build of Imprudence 1.4.0

[Nicky Perian]

Cross posting to IMPDEV and SLDEV lists.

Visual Studio Express 2010 build of Imprudence 1.4.0 is branched as impvc100 at
g...@github.com:NickyPerian/imprudence.git .

To complete the build cmake needs to be at version 2.8.1. Kitware corrected a 
bug related to VS2010 at 2.8.1 and it came back in the current versions but, is 
due to be fixed in version 2,8.4. 


The VS 2010 versions of libraries are in the downloads area of my public github 
account.

Boost 1.45 libraries and the includes with ticket 4073 patch applied to 
function_template.hpp.
File boost_1_45_VC100_libs_inc_patch4073.tar.bz2

json libraries and include with json_vc10.lib and json_vc10d.lib.
File jsonlib_VC100_libs_inc.tar.bz2

QT web kit 4.7.1 with llqtwebkit.lib and llqtwebkitd.lib.
File llqtwebkit-windows-qt4.7.1-20110117.tar.bz2
File llqtwebkit-windows-qt4.7.1-20110117.tar.bz2.md5sum

On the VS2010 release configuration the Properties->Linker->Debugging->Map File 
Name has a “:” in front of Release. This colon needs removed as it is carried 
though to a path that fails at link time.

Directories are set in the Properties Manager in VS2010. That is activated by 
the third icon over from the bottom just below the Solutions Manager window. By 
default $(ExecutablePath) is placed after the custom directories entries. If 
there is an easy way to change it to before the entries I could not find it So, 
I resorted to an edit of the line and moved $(ExecutablePath) to the beginning. 
This was to work around \cygwin\bin\link from running ahead of VS2010 link.

At this writing January 18, 2011 the llmediaplugintest project doesn't build. 
The viewer doesn't need it.
Workaround is remove it from building in the configuration manager.

To Do. Get test apps in llqtwebkit instructions to build under 2010.
Take lessons from above and get llmediaplugintest to build. 
Common factor beings glui32.lib and freeglut_static.lib.



  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] SOCIAL-452 - new size of web profile floater

[Hitomi Tiponi]

w/skins/default/xui/en/floater_layouts.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/floater_save_layout.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 
> 
> Diff: http://codereview.secondlife.com/r/98/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew
> 
>

-- next part --
An HTML attachment was scrubbed...
URL: 
http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/ea5e4514/attachment-0001.htm
 

--

Message: 2
Date: Tue, 18 Jan 2011 10:22:45 -0500
From: "Kent Quirk (Q Linden)" 
Subject: [opensource-dev] STORM-243 - simulator version notifications
To: OpenSource Mailing List 
Message-ID: <5941ed4a-7d5d-4008-9fc9-a68b33ef2...@lindenlab.com>
Content-Type: text/plain; charset=us-ascii

Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow suppression of the toast that tells you the simulator 
version changed when you changed to a new region. 


I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator versions live on 
the grid at any time? I don't mean "I can think of an obscure scenario when 
someone might care." I mean does anyone really need a notification about this, 
or can we just delete it?



--

Message: 3
Date: Tue, 18 Jan 2011 16:28:21 +0100
From: Lance Corrimal 
Subject: Re: [opensource-dev] STORM-243 - simulator version
notifications
To: opensource-dev@lists.secondlife.com
Message-ID: <201101181628.21597.lance.corri...@eregion.de>
Content-Type: Text/Plain;  charset="iso-8859-1"

Am Dienstag, 18. Januar 2011, 16:22:45 schrieb Kent Quirk (Q Linden):
> Hi, folks. I've just commented on STORM-243, which requests that we have
> Yet Another Option to allow suppression of the toast that tells you the
> simulator version changed when you changed to a new region.
> 
> I think we should delete it entirely. Does anyone care to still get that
> notification, now that there are usually 3 different simulator versions
> live on the grid at any time? I don't mean "I can think of an obscure
> scenario when someone might care." I mean does anyone really need a
> notification about this, or can we just delete it?


on the contrary, i'm trying to port a patch from henri beauchamps cool viewer 
that makes that notification more detailed, as in it tells you the version of 
the sim you entered and the version of the sim you left.


bye,
LC



--

Message: 4
Date: Tue, 18 Jan 2011 16:28:47 +0100
From: Opensource Obscure 
Subject: Re: [opensource-dev] Review Request: STORM-2 As a User, I
want to set my own default views with specific UI layout so I can
tailor my Viewer experience to the activities I'm most interested in.
To: Vadim ProductEngine 
Cc: Viewer 
Message-ID:

Content-Type: text/plain; charset=ISO-8859-1

Just to say this new feature looks very promising!

A question. The 3rd note says
"the files associated with saved layouts will be LLSD text files, so you can
email or paste layouts into a notecard to share with other users".
(the note also explains why this is not the ideal behaviour ever,
and also why we have to deal with it for now)

This sounds even cooler! ...but - how would that process of
sharing LLSD files exactly work?
I mean, where will users have to put those LLSD files?

here is the scenario I'm thinking about:

- a "teacher" (or mentor, friend, etc) is explaining to a new user
how to build in SL
- the teacher shares with the new user an LLSD file that contains
an ideal layout for building, and says "put this in your SL folder"
- the new user is now confused: many newbies don't know
the difference between the software folder and the settings folder,
and they don't know where those are;
this gets even worst to solve for people trying to help them,
because pathnames are different across different operating systems,
across different releases of the same o.s. - or because of localization.

possible solutions:
- add another option in Preferences to choose the folder where we keep layouts
- add a menu command to choose a specific layout file  - then the viewer
would copy that file into the actual settings folder.

Opensource Obscure


--

Message: 5
Date: Tue, 18 Jan 2011 15:29:44 -
From: "Boroondas Gupte" 
Subject: [opensource-dev] Review Request: make PREHASH variables char
const*const
To: "Viewer" ,"Boroondas Gupte"

Message-ID:
<20110118152944.26007.14045@domU-12-31-38-00-90-68.compute-1.internal>
Content-Type: text/plain; charset="

Re: [opensource-dev] SOCIAL-452

[Hitomi Tiponi]

oops - apologies for adding on the entire opensource-dev mail in my last 
message.  Forgot to cut it out.



  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Link times

[Kadah]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On windows I found that raiding 2 SSDs drops link times to negligible
levels for full links on 2.4, <1 minute. Normally my links are well over
20 minutes on the same system running compile from disk based raid10.

On 1/14/2011 9:04 AM, Jonathan Welch wrote:
> I just did a quick study on link times for various viewers on my 2Gb XP system
> 
> Viewer  1st link  2nd link
> CV 1.220:53  0:24
> SG 1.5  3:30  2:07
> V2.5 6:18  6:01
> 
> I watched my memory usage during the V2.5 link and did not see it get
> to an extremely low value.
> 
> The sizes of the .exe files are all pretty similar.
> 
> Does anyone have a recommendation on how to improve my link times?
> 1) Add 1Gb of memory (not clear if this would help, but it would be a
> cheap experiment)
> 2) ?
> 
> -Jonathan
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNNitHAAoJEIdLfPRu7qE2AOQH/0gDJoE3nEwQwkLQij7gTQAd
tahlsXfY/iBKPJNxNVqbfEmLQmhqh94CVHvMkIC5jyKTzHVHxRcGDrIGG6J8ngRr
tRXhd06P+7xFk+Pw0EUonNPzX/pBctPMQlxaETSwdzyguqujtfyzCiMX69Ag27h1
X1vDoyZaz2IlaGIS9tdBruG7W6xLpSipDT1vEBkWMn0nXzGAtesfWlBKborgS7TS
65pgpGKYa4wQOuqYhwen78466Mevmd1WpMj/qc4oA3pcFRU1/7O6pFxid+uCnNgg
s0yBR8zOwscJilBzy5/zlYhShv4IogBqTx4wHkkQGxVxwt2RF5oQCfx98nad0VE=
=nHj3
-END PGP SIGNATURE-
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Tateru Nino]

Then can we have some sort of method by which we can turn arbitrary 
viewer events into popups? Or would I be wasting my time with that?


On 19/01/2011 8:58 AM, Sarah (Esbee) Kuehnle wrote:
The data is available via LSL - llGetEnv() 
. If you think about it, it 
makes much more sense for this to be a HUD for Residents who are 
interested in the information. For casual Second Life users, this 
information creates additional notification pop-ups and create 
confusion for people who don't know or care that the regions they 
enter are running different server versions.


This is not a feature belongs in the Viewer. If there's more data you 
want out of llGetEnv(), I'd suggest filing an SVC feature request.


--Esbee


On Tue, Jan 18, 2011 at 4:49 PM, Erin Mallory 
mailto:angel_of_crim...@hotmail.com>> 
wrote:


I can live with that. I got much more important features /design
issues to fight over.  :)


> From: q...@lindenlab.com 
> Date: Tue, 18 Jan 2011 16:37:34 -0500
> To: liny.od...@phoenixviewer.com

> CC: opensource-dev@lists.secondlife.com


> Subject: Re: [opensource-dev] STORM-243 - simulator version
notifications
>
> It's not gonna be a debug setting. The information's available
to put it on a HUD if you care. We're pulling the feature and
simplifying the viewer.
>
> On Jan 18, 2011, at 4:35 PM, Liny Odell wrote:
>
> > Make that +2 for a debug setting
> >
> > On Tue, Jan 18, 2011 at 1:27 PM, Trilo Byte
mailto:trilobyte5...@gmail.com>> wrote:
> >> +1 for making it a debug setting (to choose whether you see
notifications).
> >>
> >> The server version info would still be available in Help ->
About as well as
> >> World -> Place Profile -> Region/Estate
> >> On Jan 18, 2011, at 11:39 AM, Erin Mallory wrote:
> >>
> >> could even bury the option in the debug console... most
people that would
> >> need to turn it on would not likely keep flipping it I would
think...
> >>
> >> 
> >> Date: Tue, 18 Jan 2011 11:32:53 -0800
> >> From: os...@lindenlab.com 
> >> To: opensource-dev@lists.secondlife.com

> >> Subject: Re: [opensource-dev] STORM-243 - simulator version
notifications
> >>
> >> It does have use for people testing server. I'd say make it
optional, more
> >> informative, and disabled by default.
> >>
> >> __Oskar
> >>
> >> On Tue, Jan 18, 2011 at 11:22 AM, Erin
> >> Mallory mailto:angel_of_crim...@hotmail.com>> wrote:
> >>
> >> to rephrase, yes I like them, thought i'd rather see them on
the chat
> >> history and have more detailed. but i can live without them
if the majority
> >> really want to see them gone altogether. for me it helps me
during certain
> >> testing and stuff to know when ive changed server versions
but that's really
> >> about it.
> >>
> >> 
> >> From: angel_of_crim...@hotmail.com

> >> To: missannoto...@yahoo.com ;
q...@lindenlab.com ;
opensource-dev@lists.secondlife.com

> >> Date: Tue, 18 Jan 2011 12:04:09 -0500
> >> Subject: Re: [opensource-dev] STORM-243 - simulator version
notifications
> >>
> >> I would also like to see the toast moved. it can be useful
and would be
> >> more useful if it had the actual version. but i would like to
see it on the
> >> chat history instead. in fact... it would be nice to have an
option to have
> >> ALL remaining system notifications be optionally shown in
chat history
> >> instead of as toasts. for one thing it would log better i
think, for
> >> another... well toasts bother a rather significant portion of
sl. those
> >> with some forms of epilepsy, migraines, some forms of add...
to name a
> >> few...
> >>
> >> Erin/aka Cummere
> >>
> >> 
> >> Date: Tue, 18 Jan 2011 08:35:01 -0800
> >> From: missannoto...@yahoo.com 
> >> To: q...@lindenlab.com ;
opensource-dev@lists.secondlife.com

> >> Subject: Re: [opensource-dev] STORM-243 - simulator version
notifications
> >>
> >> Doesn't it add some minor overhead to region crossings? I
don't care about
> >> it. The message does not say what server version you just
entered so it is
> >> mostly an annoyance. If I need version info I know where it is

Re: [opensource-dev] Link times

[Aleric Inglewood]

I can confirm that. I'm using a RAM disk (0.08ms random access time)
and that does indeed
drop link time significantly (I measured 8 seconds for viewer 1, not
sure how long it is
for viewer 2).
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] STORM-243 - simulator version notifications

[Carlo Wood]

Delete!

On Tue, Jan 18, 2011 at 10:22:45AM -0500, Kent Quirk (Q Linden) wrote:
> Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
> Another Option to allow suppression of the toast that tells you the simulator 
> version changed when you changed to a new region. 
> 
> I think we should delete it entirely. Does anyone care to still get that 
> notification, now that there are usually 3 different simulator versions live 
> on the grid at any time? I don't mean "I can think of an obscure scenario 
> when someone might care." I mean does anyone really need a notification about 
> this, or can we just delete it?
> 
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

-- 
Carlo Wood 
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

[Aleric Inglewood]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/100/#review196
---

Ship it!


I love it! Thanks, this was stopped me from compiling the tests (since some 
commit not long ago I guess, because I could before).
Just one remark. In one test _PREHASH_AgentID is set to "AgentID" (no doubt a 
place holder), while in the other you set it to 0 (now needed because it's a 
const). Perhaps a more symmetric approach is better?  I'd opt for setting the 
other also to a random string, like "Grumpity Productengine", or "Aleric 
Inglewood" now I think about it. Other options are "All Your Base Are Belong To 
Us" and "Hi mom!". Got be SURE they aren't used though -- don't want any new 
'Grumpity' embarrashments :p


- Aleric


On Jan. 18, 2011, 7:29 a.m., Boroondas Gupte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/100/
> ---
> 
> (Updated Jan. 18, 2011, 7:29 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> For the reason for this change, see 
> https://jira.secondlife.com/browse/VWR-24487 and 
> https://jira.secondlife.com/browse/VWR-24522
> 
> What I did:
> In indra/llmessage/message_prehash.(h|cpp), I turned everything into constant 
> pointers to constants by search/replace. Then I tried to compile and added 
> const qualifiers in dependent code as needed to stop the compiler complaining.
> 
> Note that comments in indra/llmessage/message_prehash.(h|cpp) say these files 
> have been generated from the message template. If this generation wasn't a 
> one-off thing, the generating code must be changed, too, so it won't override 
> this change here when the generation happens the next time.
> 
> 
> This addresses bug VWR-24487.
> http://jira.secondlife.com/browse/VWR-24487
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt fc7e5dcf3059 
>   indra/llmessage/message_prehash.h fc7e5dcf3059 
>   indra/llmessage/message_prehash.cpp fc7e5dcf3059 
>   indra/llprimitive/llprimitive.h fc7e5dcf3059 
>   indra/llprimitive/llprimitive.cpp fc7e5dcf3059 
>   indra/llprimitive/llvolumemessage.h fc7e5dcf3059 
>   indra/llprimitive/llvolumemessage.cpp fc7e5dcf3059 
>   indra/llui/tests/llurlentry_stub.cpp fc7e5dcf3059 
>   indra/newview/tests/llremoteparcelrequest_test.cpp fc7e5dcf3059 
> 
> Diff: http://codereview.secondlife.com/r/100/diff
> 
> 
> Testing
> ---
> 
> Compiled (standalone, 64bit Linux) with and without LL_TESTS.
> Started the viewer, logged in, walked and flew around a bit. Everything seems 
> to work.
> 
> 
> Thanks,
> 
> Boroondas
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

[Aleric Inglewood]

> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote:
> > indra/newview/lltexturecache.cpp, line 1595
> > 
> >
> > validate_idx being used in a test later, it's not just for 
> > (validate_idx == 0) that the behavior will be different. I need to 
> > understand better what that idx is all about or you need to give a bit more 
> > explanation before I approve this diff.

The debug setting CacheValidateCounter is set to 'next_id', which makes clear 
what it's meaning is: namely, the id that we will check next time. next_idx is 
a very local variable that is simply set to the value of CacheValidateCounter 
plus 1, and then that value is stored to CacheValidateCounter again for next 
time.

validate_idx is the ID that is actually being tested this time. Hence, it 
should be the value of CacheValidateCounter before we increase that.

Obviously, those ID's should be in the range 0...255, which is garanteed by 
doing a modulo 256 on next_id before writing it to CacheValidateCounter.

The old code also increases validate_idx *before* it is used. That means that 
it will be in the range 1...256, and 0 is never tested (note that validate_idx 
is just increased, there is no modulo applied, so it's obvious that it 
shouldn't be increased). Even the wording ("next"_id) suggests that 
validate_idx should just be the value of CacheValidateCounter, which is the 
value of the previous next_id...

So, after this patch, we get to the following code with validate_idx in the 
range 0...255, as it should be.


- Aleric


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/90/#review191
---


On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/90/
> ---
> 
> (Updated Jan. 14, 2011, 1:02 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Trivial patch, just removes stupidity.
> 
> 
> This addresses bug VWR-24321.
> http://jira.secondlife.com/browse/VWR-24321
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/lltexturecache.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/90/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] SOCIAL-452

[Erin Mallory]

For what its worth i agree.  the floater is too big.  so is the layout on the 
profiles.  both could be shrunk a bit to make it more usable.   but what 
concerns me is the viewer hanging every time the web profiles are open...  
which i think is a viewer issue... 
Date: Tue, 18 Jan 2011 23:23:40 +
From: hitomi.tip...@yahoo.co.uk
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] SOCIAL-452



oops - apologies for adding on the entire opensource-dev mail in my last 
message.  Forgot to cut it out.





  
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges  
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Storm-236 extra eyes needed.(please forgive for lenght)

[WolfPup Lowenhar]

I'll apologize in advanced for length of this email but I need some extra
eyes on the code for this

 

Diff to show changes being made(also the reason for the length of email):

 

diff --git a/indra/newview/llbottomtray.cpp b/indra/newview/llbottomtray.cpp

--- a/indra/newview/llbottomtray.cpp

+++ b/indra/newview/llbottomtray.cpp

@@ -1528,6 +1528,7 @@

// because it resets chatbar's width according to resize logic.

void LLBottomTray::initButtonsVisibility()

{

+   setVisibleAndFitWidths(RS_BUTTON_SPEAK,
gSavedSettings.getBOOL("EnableVoiceChat"));

 setVisibleAndFitWidths(RS_BUTTON_GESTURES,
gSavedSettings.getBOOL("ShowGestureButton"));

 setVisibleAndFitWidths(RS_BUTTON_MOVEMENT,
gSavedSettings.getBOOL("ShowMoveButton"));

 setVisibleAndFitWidths(RS_BUTTON_CAMERA,
gSavedSettings.getBOOL("ShowCameraButton"));

@@ -1540,6 +1541,7 @@

 void LLBottomTray::setButtonsControlsAndListeners()

{

+
gSavedSettings.getControl("EnableVoiceChat")->getSignal()->connect(boost::bi
nd(&LLBottomTray::toggleShowButton, RS_BUTTON_SPEAK, _2));

 
gSavedSettings.getControl("ShowGestureButton")->getSignal()->connect(boost::
bind(&LLBottomTray::toggleShowButton, RS_BUTTON_GESTURES, _2));

 
gSavedSettings.getControl("ShowMoveButton")->getSignal()->connect(boost::bin
d(&LLBottomTray::toggleShowButton, RS_BUTTON_MOVEMENT, _2));

 
gSavedSettings.getControl("ShowCameraButton")->getSignal()->connect(boost::b
ind(&LLBottomTray::toggleShowButton, RS_BUTTON_CAMERA, _2));

diff --git a/indra/newview/llspeakbutton.cpp
b/indra/newview/llspeakbutton.cpp

--- a/indra/newview/llspeakbutton.cpp

+++ b/indra/newview/llspeakbutton.cpp

@@ -34,6 +34,7 @@

#include "llcallfloater.h"

#include "lloutputmonitorctrl.h"

#include "lltransientfloatermgr.h"

+#include "llviewercontrol.h"

 #include "llspeakbutton.h"

@@ -55,12 +56,15 @@

 void LLSpeakButton::draw()

{

-// LLVoiceClient::getInstance() is the authoritative global source
of info regarding our open-mic state, we merely reflect that state.

-bool openmic = LLVoiceClient::getInstance()->getUserPTTState();

-bool voiceenabled = LLVoiceClient::getInstance()->voiceEnabled();

-mSpeakBtn->setToggleState(openmic && voiceenabled);

-mOutputMonitor->setIsMuted(!voiceenabled);

-LLUICtrl::draw();

+   if ( gSavedSettings.getBOOL("EnableVoiceChat") )

+   {

+ // LLVoiceClient::getInstance() is the authoritative
global source of info regarding our open-mic state, we merely reflect that
state.

+   bool openmic = LLVoiceClient::getInstance()->getUserPTTState();

+   bool voiceenabled =
LLVoiceClient::getInstance()->voiceEnabled();

+   mSpeakBtn->setToggleState(openmic && voiceenabled);

+   mOutputMonitor->setIsMuted(!voiceenabled);

+   LLUICtrl::draw();

+   }

}

void LLSpeakButton::setSpeakBtnEnabled(bool enabled)

{

diff --git a/indra/newview/skins/default/xui/en/menu_bottomtray.xml
b/indra/newview/skins/default/xui/en/menu_bottomtray.xml

--- a/indra/newview/skins/default/xui/en/menu_bottomtray.xml

+++ b/indra/newview/skins/default/xui/en/menu_bottomtray.xml

@@ -9,6 +9,17 @@

  visible="false"

  width="128">

 

+

+ 

+

+

 

with the above code changed the speak button show/hide in accordance to the
voice settings like it should.

 

now for the problem:

 

1 when hiding the speak button(disabling voice) the space it took up is not
freed(visible buttons sliding towards the text input field) this is a
problem.

2 when showing the speak button(enabling voice) I get the following message
in the log file: WARNING: LLToastAlertPanel::LLToastAlertPanel: Alert:
Selected button cannot be shown right now.

The button will be shown when there is enough space for it.

 

Now somewhere in the related files there is a place that sets the space for
the speak button and I feel that if I could locate it and make the needed
changes it should solve both problems as I think the second one is tied to
the fact that the space is not freed up. 

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: VWR-24321: Validate textures starting with 00 too.

[Cron Stardust]

> On Jan. 18, 2011, 12:09 p.m., Merov Linden wrote:
> > indra/newview/lltexturecache.cpp, line 1595
> > 
> >
> > validate_idx being used in a test later, it's not just for 
> > (validate_idx == 0) that the behavior will be different. I need to 
> > understand better what that idx is all about or you need to give a bit more 
> > explanation before I approve this diff.
> 
> Aleric Inglewood wrote:
> The debug setting CacheValidateCounter is set to 'next_id', which makes 
> clear what it's meaning is: namely, the id that we will check next time. 
> next_idx is a very local variable that is simply set to the value of 
> CacheValidateCounter plus 1, and then that value is stored to 
> CacheValidateCounter again for next time.
> 
> validate_idx is the ID that is actually being tested this time. Hence, it 
> should be the value of CacheValidateCounter before we increase that.
> 
> Obviously, those ID's should be in the range 0...255, which is garanteed 
> by doing a modulo 256 on next_id before writing it to CacheValidateCounter.
> 
> The old code also increases validate_idx *before* it is used. That means 
> that it will be in the range 1...256, and 0 is never tested (note that 
> validate_idx is just increased, there is no modulo applied, so it's obvious 
> that it shouldn't be increased). Even the wording ("next"_id) suggests that 
> validate_idx should just be the value of CacheValidateCounter, which is the 
> value of the previous next_id...
> 
> So, after this patch, we get to the following code with validate_idx in 
> the range 0...255, as it should be.
>

Just double checking, as switching from pre-increment to addition can change 
behavior: In both cases next_idx will have the same value after this line is 
executed, however validate_idx will not.

Prediff start state: validate_idx == 0;
Prediff stop state: validate_idx == 1; next_idx == 1;

Postdiff start state: validate_idx == 0;
Postdiff stop state: validate_idx == 0; next_idx == 1;

And another round over at the other end:

Prediff start state: validate_idx == 255;
Prediff stop state: validate_idx == 256; next_idx == 0;

Postdiff start state: validate_idx == 255;
Postdiff stop state: validate_idx == 255; next_idx == 0;

So, yes, validate_idx will only have a 255 in it in this last case, however the 
over-all behavior has changed: validate_idx isn't being incremented at all in 
this line.

WARNING: I have NOT looked at the rest of the diff, only at this one line.  Nor 
do I know if validate_idx should or shouldn't be incremented by this line of 
code.


- Cron


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/90/#review191
---


On Jan. 14, 2011, 1:02 p.m., Aleric Inglewood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/90/
> ---
> 
> (Updated Jan. 14, 2011, 1:02 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> Trivial patch, just removes stupidity.
> 
> 
> This addresses bug VWR-24321.
> http://jira.secondlife.com/browse/VWR-24321
> 
> 
> Diffs
> -
> 
>   doc/contributions.txt b0bd26c5638a 
>   indra/newview/lltexturecache.cpp b0bd26c5638a 
> 
> Diff: http://codereview.secondlife.com/r/90/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleric
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] SOCIAL-452 - new size of web profile floater

[SuezanneC Baskerville]

   http://jira.secondlife.com/browse/STORM-2
> >
> >
> > Diffs
> > -
> >
> >  indra/llui/llfloater.h 422f636c3343
> >  indra/llui/llfloaterreg.h 422f636c3343
> >  indra/newview/CMakeLists.txt 422f636c3343
> >  indra/newview/llbottomtray.h 422f636c3343
> >  indra/newview/llbottomtray.cpp 422f636c3343
> >  indra/newview/llfloaterlayouts.h PRE-CREATION
> >  indra/newview/llfloaterlayouts.cpp PRE-CREATION
> >  indra/newview/llsidetray.h 422f636c3343
> >  indra/newview/llsidetray.cpp 422f636c3343
> >  indra/newview/llviewerfloaterreg.cpp 422f636c3343
> >  indra/newview/llviewermenu.cpp 422f636c3343
> >  indra/newview/skins/default/xui/en/floater_layouts.xml PRE-CREATION
> >  indra/newview/skins/default/xui/en/floater_save_layout.xml PRE-CREATION
> >  indra/newview/skins/default/xui/en/menu_viewer.xml 422f636c3343
> >  indra/newview/skins/default/xui/en/notifications.xml 422f636c3343
> >
> > Diff: http://codereview.secondlife.com/r/98/diff
> >
> >
> > Testing
> > ---
> >
> >
> > Thanks,
> >
> > Andrew
> >
> >
>
> -- next part --
> An HTML attachment was scrubbed...
> URL:
> http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/ea5e4514/attachment-0001.htm
>
> --
>
> Message: 2
> Date: Tue, 18 Jan 2011 10:22:45 -0500
> From: "Kent Quirk (Q Linden)" 
> Subject: [opensource-dev] STORM-243 - simulator version notifications
> To: OpenSource Mailing List 
> Message-ID: <5941ed4a-7d5d-4008-9fc9-a68b33ef2...@lindenlab.com>
> Content-Type: text/plain; charset=us-ascii
>
> Hi, folks. I've just commented on STORM-243, which requests that we have
> Yet Another Option to allow suppression of the toast that tells you the
> simulator version changed when you changed to a new region.
>
> I think we should delete it entirely. Does anyone care to still get that
> notification, now that there are usually 3 different simulator versions live
> on the grid at any time? I don't mean "I can think of an obscure scenario
> when someone might care." I mean does anyone really need a notification
> about this, or can we just delete it?
>
>
>
> --
>
> Message: 3
> Date: Tue, 18 Jan 2011 16:28:21 +0100
> From: Lance Corrimal 
> Subject: Re: [opensource-dev] STORM-243 - simulator version
> notifications
> To: opensource-dev@lists.secondlife.com
> Message-ID: <201101181628.21597.lance.corri...@eregion.de>
> Content-Type: Text/Plain;  charset="iso-8859-1"
>
> Am Dienstag, 18. Januar 2011, 16:22:45 schrieb Kent Quirk (Q Linden):
> > Hi, folks. I've just commented on STORM-243, which requests that we have
> > Yet Another Option to allow suppression of the toast that tells you the
> > simulator version changed when you changed to a new region.
> >
> > I think we should delete it entirely. Does anyone care to still get that
> > notification, now that there are usually 3 different simulator versions
> > live on the grid at any time? I don't mean "I can think of an obscure
> > scenario when someone might care." I mean does anyone really need a
> > notification about this, or can we just delete it?
>
>
> on the contrary, i'm trying to port a patch from henri beauchamps cool
> viewer
> that makes that notification more detailed, as in it tells you the version
> of
> the sim you entered and the version of the sim you left.
>
>
> bye,
> LC
>
>
>
> --
>
> Message: 4
> Date: Tue, 18 Jan 2011 16:28:47 +0100
> From: Opensource Obscure 
> Subject: Re: [opensource-dev] Review Request: STORM-2 As a User, I
> want to set my own default views with specific UI layout so I can
> tailor my Viewer experience to the activities I'm most interested in.
> To: Vadim ProductEngine 
> Cc: Viewer 
> Message-ID:
> 
> Content-Type: text/plain; charset=ISO-8859-1
>
> Just to say this new feature looks very promising!
>
> A question. The 3rd note says
> "the files associated with saved layouts will be LLSD text files, so you
> can
> email or paste layouts into a notecard to share with other users".
> (the note also explains why this is not the ideal behaviour ever,
> and also why we have to deal with it for now)
>
> This sounds even cooler! ...but - how would that process of
> sharing LLSD files exactly work?
> I mean, where will users have to put those LLSD files?
>
> here is the scenario I'm thinking about:
>
> - a "teacher" (o

Re: [opensource-dev] SOCIAL-452 - new size of web profile floater

[Erin Mallory]

 422f636c3343 
>   indra/newview/llfloaterlayouts.h PRE-CREATION 

>   indra/newview/llfloaterlayouts.cpp PRE-CREATION 
>   indra/newview/llsidetray.h 422f636c3343 
>   indra/newview/llsidetray.cpp 422f636c3343 
>   indra/newview/llviewerfloaterreg.cpp 422f636c3343 

>   indra/newview/llviewermenu.cpp 422f636c3343 
>   indra/newview/skins/default/xui/en/floater_layouts.xml PRE-CREATION 
>  
 indra/newview/skins/default/xui/en/floater_save_layout.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/menu_viewer.xml 422f636c3343 
>   indra/newview/skins/default/xui/en/notifications.xml 422f636c3343 

> 
> Diff: http://codereview.secondlife.com/r/98/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,

> 
> Andrew
> 
>

-- next part --
An HTML attachment was scrubbed...
URL: 
http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110118/ea5e4514/attachment-0001.htm
 


--

Message: 2
Date: Tue, 18 Jan 2011 10:22:45 -0500
From: "Kent Quirk (Q Linden)" 
Subject: [opensource-dev] STORM-243 - simulator version notifications

To: OpenSource Mailing List 
Message-ID: <5941ed4a-7d5d-4008-9fc9-a68b33ef2...@lindenlab.com>

Content-Type: text/plain; charset=us-ascii

Hi, folks. I've just commented on STORM-243, which requests that we have Yet 
Another Option to allow suppression of the toast that tells you the simulator 
version changed when you changed to a new region. 


I think we should delete it entirely. Does anyone care to still get that 
notification, now that there are usually 3 different simulator
 versions live on the grid at any time? I don't mean "I can think of an obscure 
scenario when someone might care." I mean does anyone really need a 
notification about this, or can we just delete it?




--

Message: 3
Date: Tue, 18 Jan 2011 16:28:21 +0100
From: Lance Corrimal 

Subject: Re: [opensource-dev] STORM-243 - simulator version
notifications
To: opensource-dev@lists.secondlife.com
Message-ID: <201101181628.21597.lance.corri...@eregion.de>

Content-Type: Text/Plain;  charset="iso-8859-1"

Am
 Dienstag, 18. Januar 2011, 16:22:45 schrieb Kent Quirk (Q Linden):
> Hi, folks. I've just commented on STORM-243, which requests that we have
> Yet Another Option to allow suppression of the toast that tells you the

> simulator version changed when you changed to a new region.
> 
> I think we should delete it entirely. Does anyone care to still get that
> notification, now that there are usually 3 different simulator versions

> live on the grid at any time? I don't mean "I can think of an obscure
> scenario when someone might care." I mean does anyone really need a
> notification about this, or can we just delete it?



on the contrary, i'm trying to port a patch from henri beauchamps cool viewer 
that makes that notification more detailed, as in it tells you the version of 
the sim you entered and the version of the sim you
 left.


bye,
LC



--

Message: 4
Date: Tue, 18 Jan 2011 16:28:47 +0100
From: Opensource Obscure 

Subject: Re: [opensource-dev] Review Request: STORM-2 As a User, I
want to set my own default views with specific UI layout so I can
tailor my Viewer experience to the activities I'm most interested in.

To: Vadim ProductEngine 
Cc: Viewer 

Message-ID:

Content-Type: text/plain; charset=ISO-8859-1


Just to say this new feature looks very promising!

A question. The 3rd note says
"the files associated with saved layouts will be LLSD text files, so you can
email or paste layouts into a notecard to share with other users".

(the note also explains why this is not the ideal behaviour ever,
and also why we have to deal with it for now)

This sounds even cooler! ...but - how would that process of
sharing LLSD files exactly work?

I mean, where will users have to put those LLSD files?

here is the scenario I'm thinking about:

- a "teacher" (or mentor, friend, etc) is explaining to a new user
how to build in SL
- the teacher shares with
 the new user an LLSD file that contains
an ideal layout for building, and says "put this in your SL folder"
- the new user is now confused: many newbies don't know
the difference between the software folder and the settings folder,

and they don't know where those are;
this gets even worst to solve for people trying to help them,
because pathnames are different across different operating systems,
across different releases of the same o.s. - or because of localization.


possible solutions:
- add another option in Preferences to choose the folder where we keep layouts
- add a menu command to choose a specific layout file  - then the viewer
would copy that file into the actual settings folder.


Opensource Obscure

Re: [opensource-dev] STORM-243 - simulator version notifications

[Lance Corrimal]

Am Dienstag, 18. Januar 2011 schrieb Kent Quirk (Q Linden):
> It's not gonna be a debug setting. The information's available to
> put it on a HUD if you care.  We're pulling the feature and
> simplifying the viewer.

then how about getting rid of all the extra and superfluous 
information that the viewer presents that hast to be actively confirm 
by clicking on an OK button, without telling the user anything that 
he/she hasnt seen just a moment ago?



like, for example, every time you get an inventory offer from a 
person, you first click "accept", then you get an additional popup 
that tells you "You have accepted ... from ..." which won't go away 
until you click ok.


https://jira.secondlife.com/browse/STORM-323


bye,
LC
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges