Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Opensource Obscure]

 On Thu, 02 Dec 2010 03:57:24 -, "Oz Linden"  
 wrote:
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
> ---
>
> Review request for Viewer.
>
>
> Summary
> ---
>
> This review is mostly a first test of reviewboard.

 I just want to point out (as a reminder to other list members)
 that the reviewboard is for code contributors only, that is

 "In order to post reviews or comment on them in this system,
 you must have executed a Contribution Agreement".

 I would assume that we non-contributors still can comment
 here in the mailing list, if appropriate.


 Opensource Obscure
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Oz Linden (Scott Lawrence)]

>
> I just want to point out (as a reminder to other list members)
> that the reviewboard is for code contributors only, that is
>
> "In order to post reviews or comment on them in this system,
> you must have executed a Contribution Agreement".
>
> I would assume that we non-contributors still can comment
> here in the mailing list, if appropriate.

Or better yet, become contributors.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] [META][WEB] Registering a SL Review Board account: Jira email address vs. mailing list address (was: Re: Review Request: Restructure loops that use breaks without need (reviewboard te

[Boroondas Gupte]

https://codereview.secondlife.com/account/register/ advises:
> Use the email address that you have associated with that Jira account.
However, as mails automatically generated from my actions on Review
Board get sent to the mailing list, I now changed the address in my SL
Review Board profile to my mailing list address, so that future messages
won't get rejected.

Cheers,
Boroondas


On 12/02/2010 12:40 PM, opensource-dev-ow...@lists.secondlife.com wrote:
> You are not allowed to post to this mailing list, and your message has
> been automatically rejected.  If you think that your messages are
> being rejected in error, contact the mailing list owner at
> opensource-dev-ow...@lists.secondlife.com.
>
>  Attached Email 
> Subject:  Re: Review Request: Restructure loops that use breaks
> without need (reviewboard test)
> Date: Thu, 02 Dec 2010 11:40:12 -
> From: Boroondas Gupte <*[The address I use for jira* (different from
> the one I use for the mailing list and not intended for public
> visibility)*]*>
> To:   Boroondas Gupte <*[...]*>, Oz Linden , Viewer
> 
>
>
>
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
>
>
> indra/newview/llappviewer.cpp
> 
> (Diff revision 1)
> bool LLAppViewer::mainLoop()
> 1188  
>   S32 total_io_pending = 0;   
> 
>   1188
>   S32 total_io_pending = 0;   
> 
>
> While you're at it, please fix the whitespace errors in the touched (and 
> nearby) code. (In a separate changeset, though, if possible)
>
> The Review-Board diff view conveniently highlights them in red, so they are 
> hard to miss ;-)
>
> indra/newview/llappviewer.cpp
> 
> (Diff revision 1)
> bool LLAppViewer::mainLoop()
> 1195  
>   work_pending += 
> LLAppViewer::getTextureCache()->update(1); // unpauses the texture cache 
> thread
>   1199
>   work_pending += 
> LLAppViewer::getTextureCache()->update(1); // unpauses the texture cache 
> thread
>
> e.g. here: spaces before tabs
>
> indra/newview/llappviewer.cpp
> 
> (Diff revision 1)
> bool LLAppViewer::cleanup()
> 1624  
>   if(!pending)
>   1623
> } while ( pending && idle_time < max_idle_time) 
>
> Your change even introduces new whitespace errors (trailing whitespace here)
>
> - Boroondas
>
>
> On December 1st, 2010, 7:57 p.m., Oz Linden wrote:
>
> Review request for Viewer.
> By Oz Linden.
>
> /Updated 2010-12-01 19:57:24/
>
>
>   Description
>
> This review is mostly a first test of reviewboard.
>
> I do have an esthetic dislike for the 'break' statement anywhere but as the 
> end of a case, so I chose to change some instances of break usage that were 
> not justified by any extreme need.
>
>
>   Testing
>
> None at all... have not even compiled it yet.
>
> *Bugs: * storm-606 
>
>
>   Diffs
>
> * indra/newview/llappviewer.cpp (bf98b026bcb1)
>
> View Diff 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Boroondas Gupte]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/2/#review10
---



indra/newview/llappviewer.cpp


e.g. here, some lines are indented by spaces and others by tabs


- Boroondas


On 2010-12-01 19:57:24, Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
> ---
> 
> (Updated 2010-12-01 19:57:24)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This review is mostly a first test of reviewboard.
> 
> I do have an esthetic dislike for the 'break' statement anywhere but as the 
> end of a case, so I chose to change some instances of break usage that were 
> not justified by any extreme need.
> 
> 
> This addresses bug storm-606.
> http://jira.secondlife.com/browse/storm-606
> 
> 
> Diffs
> -
> 
>   indra/newview/llappviewer.cpp bf98b026bcb1 
> 
> Diff: http://codereview.secondlife.com/r/2/diff
> 
> 
> Testing
> ---
> 
> None at all... have not even compiled it yet.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Boroondas Gupte]

> On 2010-12-02 04:52:10, Boroondas Gupte wrote:
> >

EDITED TO ADD: (apparently Review Board can't handle comments on comments on 
lines (sic!) and new comments on lines at the same time)
"The Review-Board diff view conveniently highlights them in red, so they are 
hard to miss ;-)"
Of course, Review Board can't detect all whitespace mistakes:


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/2/#review10
---


On 2010-12-01 19:57:24, Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
> ---
> 
> (Updated 2010-12-01 19:57:24)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This review is mostly a first test of reviewboard.
> 
> I do have an esthetic dislike for the 'break' statement anywhere but as the 
> end of a case, so I chose to change some instances of break usage that were 
> not justified by any extreme need.
> 
> 
> This addresses bug storm-606.
> http://jira.secondlife.com/browse/storm-606
> 
> 
> Diffs
> -
> 
>   indra/newview/llappviewer.cpp bf98b026bcb1 
> 
> Diff: http://codereview.secondlife.com/r/2/diff
> 
> 
> Testing
> ---
> 
> None at all... have not even compiled it yet.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Boroondas Gupte]

> On 2010-12-02 04:52:10, Boroondas Gupte wrote:
> >
> 
> Boroondas Gupte wrote:
> EDITED TO ADD: (apparently Review Board can't handle comments on comments 
> on lines (sic!) and new comments on lines at the same time)
> "The Review-Board diff view conveniently highlights them in red, so they 
> are hard to miss ;-)"
> Of course, Review Board can't detect all whitespace mistakes:

Ah, I guess I should have read 
http://www.reviewboard.org/docs/manual/1.5/users/reviews/reviewing-diffs/#reading-existing-comments
 , first: "It’s important to note that this is meant to be used as a reference 
to see if other people have already said what you plan to say. The comment box 
is not the place to reply to those comments. Instead, you can click the Reply 
link next to the particular comment, which will take you back to the review 
request page and open a reply box."


- Boroondas


---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/2/#review10
---


On 2010-12-01 19:57:24, Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
> ---
> 
> (Updated 2010-12-01 19:57:24)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This review is mostly a first test of reviewboard.
> 
> I do have an esthetic dislike for the 'break' statement anywhere but as the 
> end of a case, so I chose to change some instances of break usage that were 
> not justified by any extreme need.
> 
> 
> This addresses bug storm-606.
> http://jira.secondlife.com/browse/storm-606
> 
> 
> Diffs
> -
> 
>   indra/newview/llappviewer.cpp bf98b026bcb1 
> 
> Diff: http://codereview.secondlife.com/r/2/diff
> 
> 
> Testing
> ---
> 
> None at all... have not even compiled it yet.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Registering a SL Review Board

[Jonathan Welch]

Will the email address we input during the registration process be
visible at any point?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Registering a SL Review Board

[Oz Linden (Scott Lawrence)]

On 2010-12-02 8:23, Jonathan Welch wrote:
> Will the email address we input during the registration process be
> visible at any point?

Yes, since the email that reviewboard sends about whatever you did will 
be the From address.

If you prefer, you can use the email address that you use for the 
opensource list (I'd still suggest that you make both of those addresses 
the same, but the jira address can be changed too).

My main concern is that the usernames be the same, so that if 
ReviewBoard actually does OpenId (it is on their backlog), then we can 
start using that.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] ReviewBoard email to this list?

[Oz Linden (Scott Lawrence)]

As you'll have inferred, we now have a system set up for doing open code 
reviews.  It's not perfect, but it's pretty nice and very easy to use.


It also generates quite a bit of email - one for each newly posted 
request, and one (properly threaded) for each comment or other action on 
that review.


If I understand the capabilities correctly, the software allows each 
'review group' to either:


  1. Configure a single mailing list address for the group (of which at
 present we have only the one 'viewer' group)
  2. Leave that address blank

If a list address is configured, all emails for reviews in that group 
are sent to the list address.  If it is left blank, then individual 
emails are sent to each of the members of the review group.


I chose to configure the opensource-dev list as the mailing list, and 
the messages do get sent there (as From the user, so the address you 
configure for your account needs to match the one you use for the list, 
or that mail will fail).


This will mean a considerable increase in list traffic, I think, since 
every commit to viewer-development should be reviewed.  I think that the 
increase in transparency of what is happening, and the opportunities for 
everyone to learn more about more of the code base makes this increase 
worth it, but am interested in the opinions of other list members.


Note that these emails are easy to set up filters for - not only will 
all of them have 'Review Request' in the Subject lines, there are also a 
couple of custom headers in each message that make them easy to recognize.


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Registering a SL Review Board

[WolfPup Lowenhar]

I would be nice if the review board system had an address that was something
that people that use email programs( I.E. Outlook, Thunderbird, Incredimail)
could much easier filter. Like nore...@codereview.secondlife.com or
something similar that way if they set up a filter it would not interfere
with any other filters they have set up that are for SL.

 

From: opensource-dev-boun...@lists.secondlife.com
[mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Oz Linden
(Scott Lawrence)
Sent: Thursday, December 02, 2010 8:41 AM
To: opensource-dev@lists.secondlife.com
Subject: Re: [opensource-dev] Registering a SL Review Board

 

On 2010-12-02 8:23, Jonathan Welch wrote:
> Will the email address we input during the registration process be
> visible at any point?

Yes, since the email that reviewboard sends about whatever you did will
be the From address.

If you prefer, you can use the email address that you use for the
opensource list (I'd still suggest that you make both of those addresses
the same, but the jira address can be changed too).

My main concern is that the usernames be the same, so that if
ReviewBoard actually does OpenId (it is on their backlog), then we can
start using that.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting
privileges 

  _  

No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1170 / Virus Database: 426/3292 - Release Date: 12/01/10

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] ReviewBoard email to this list?

[Ponzu]

ponzu



On Thu, Dec 2, 2010 at 8:52 AM, Oz Linden (Scott Lawrence)  wrote:

>  As you'll have inferred, we now have a system set up for doing open code
> reviews.  It's not perfect, but it's pretty nice and very easy to use.
>
> It also generates quite a bit of email - one for each newly posted request,
> and one (properly threaded) for each comment or other action on that review.
>
> If I understand the capabilities correctly, the software allows each
> 'review group' to either:
>
>1. Configure a single mailing list address for the group (of which at
>present we have only the one 'viewer' group)
>2. Leave that address blank
>
> If a list address is configured, all emails for reviews in that group are
> sent to the list address.  If it is left blank, then individual emails are
> sent to each of the members of the review group.
>
> I chose to configure the opensource-dev list as the mailing list, and the
> messages do get sent there (as From the user, so the address you configure
> for your account needs to match the one you use for the list, or that mail
> will fail).
>
> This will mean a considerable increase in list traffic, I think, since
> every commit to viewer-development should be reviewed.  I think that the
> increase in transparency of what is happening, and the opportunities for
> everyone to learn more about more of the code base makes this increase worth
> it, but am interested in the opinions of other list members.
>
> Note that these emails are easy to set up filters for - not only will all
> of them have 'Review Request' in the Subject lines, there are also a couple
> of custom headers in each message that make them easy to recognize.
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] ReviewBoard email to this list?

[Boroondas Gupte]

On 12/02/2010 02:52 PM, Oz Linden (Scott Lawrence) wrote:
> Note that these emails are easy to set up filters for - not only will
> all of them have 'Review Request' in the Subject lines, there are also
> a couple of custom headers in each message that make them easy to
> recognize.
On 12/02/2010 02:58 PM, WolfPup Lowenhar wrote:
>
> I would be nice if the review board system had an address that was
> something that people that use email programs( I.E. Outlook,
> Thunderbird, Incredimail) could much easier filter. Like
> nore...@codereview.secondlife.com
>  or something similar that
> way if they set up a filter it would not interfere with any other
> filters they have set up that are for SL.
>

Even easier (for subscribers) would be to have a separate mailing list
for the automatic Review Board emails. Then, everyone can decide
themselves whether to subscribe to that, too (or even only to that).
Non-subscribers would still have the option of seeing the threads on the
list's archive website.

This would be consistent with existing and previous single-purpose lists
like Jira-notify
,
viewer-development-builds
,
viewer-development-commits

and sldev-commits (or whatever the SVN commit notification list was
called back then.)

Cheers,
Boroondas

PS: Is there any reason why the viewer-development-builds Archives

are 'private' (i.e. only available to list members)?
**


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] ReviewBoard email to this list?

[Stickman]

> Even easier (for subscribers) would be to have a separate mailing list for
> the automatic Review Board emails. Then, everyone can decide themselves
> whether to subscribe to that, too (or even only to that). Non-subscribers
> would still have the option of seeing the threads on the list's archive
> website.

The review board emails are closely tied with viewer/opensource
development. I'm not sure splitting them out into a separate list
would work very well as there's too much overlapping content and they
would be constantly spilling back into this list as discussions
started up based on them. Or worse, not spilling back into this list
as discussions pertinent to viewer development started up.

Stickman
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] ReviewBoard email to this list?

[Oz Linden (Scott Lawrence)]

On 2010-12-02 9:41, Boroondas Gupte wrote:


PS: Is there any reason why the viewer-development-builds Archives 
 
are 'private' (i.e. only available to list members)?


No... but I'll have to dig up the admin password to fix it...


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Registering a SL Review Board

[Ricky]

Or if it prefixed the message subjects with a [RB] tag, or similar.
That would provide the same filterability, at least in gmail, while
being easier to implement.

Ricky
Cron Stardust

On Thu, Dec 2, 2010 at 5:58 AM, WolfPup Lowenhar
 wrote:
> I would be nice if the review board system had an address that was something
> that people that use email programs( I.E. Outlook, Thunderbird, Incredimail)
> could much easier filter. Like nore...@codereview.secondlife.com or
> something similar that way if they set up a filter it would not interfere
> with any other filters they have set up that are for SL.
>
>
>
> From: opensource-dev-boun...@lists.secondlife.com
> [mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of Oz Linden
> (Scott Lawrence)
> Sent: Thursday, December 02, 2010 8:41 AM
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Registering a SL Review Board
>
>
>
> On 2010-12-02 8:23, Jonathan Welch wrote:
>> Will the email address we input during the registration process be
>> visible at any point?
>
> Yes, since the email that reviewboard sends about whatever you did will
> be the From address.
>
> If you prefer, you can use the email address that you use for the
> opensource list (I'd still suggest that you make both of those addresses
> the same, but the jira address can be changed too).
>
> My main concern is that the usernames be the same, so that if
> ReviewBoard actually does OpenId (it is on their backlog), then we can
> start using that.
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
> 
>
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1170 / Virus Database: 426/3292 - Release Date: 12/01/10
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] ReviewBoard email to this list?

[Ricky]

I agree, I prefer them here.  However, in such a case, they need to be
a tad easier to filter, which is why I suggested an [RB] (or similar)
subject tag.  This would be consistent with the policies for this
list, and would allow easy filtering.  The string "Review Request:" is
a tad ambiguous, as that might show up in someone's email, and it
inconsistent with the existing list policies of [META], [POLICY], etc.

Ricky
Cron Stardust

On Thu, Dec 2, 2010 at 6:49 AM, Stickman  wrote:
>> Even easier (for subscribers) would be to have a separate mailing list for
>> the automatic Review Board emails. Then, everyone can decide themselves
>> whether to subscribe to that, too (or even only to that). Non-subscribers
>> would still have the option of seeing the threads on the list's archive
>> website.
>
> The review board emails are closely tied with viewer/opensource
> development. I'm not sure splitting them out into a separate list
> would work very well as there's too much overlapping content and they
> would be constantly spilling back into this list as discussions
> started up based on them. Or worse, not spilling back into this list
> as discussions pertinent to viewer development started up.
>
> Stickman
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] How to filter ReviewBoard mail

[Oz Linden (Scott Lawrence)]

On 2010-12-02 8:58, WolfPup Lowenhar wrote:


I would be nice if the review board system had an address that was 
something that people that use email programs( I.E. Outlook, 
Thunderbird, Incredimail) could much easier filter. Like 
nore...@codereview.secondlife.com 
 or something similar that 
way if they set up a filter it would not interfere with any other 
filters they have set up that are for SL.




There are two easy recognizers for these messages; which is better for 
you will vary with what mail systems you're using:


  1. The Subject lines will all begin either 'Review Request:' or 'Re:
 Review Request:'
  2. They all have 'X-ReviewBoard-URL' and 'X-ReviewRequest-URL'
 headers (the contents are URLs to the site and the review
 respectively).


___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review board & lists

[Jonathan Welch]

Oz, there is a flaw in your logic about our ability to filter out
review messages sent to this list.

I receive this list in digest format.  It's easier for me to scan
through it that way, so I have no ability to filter out these review
board messages.

I'm with Boroondas--please set up another mailing list to receive
these messages.

-Jonathan
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review board & lists

[Erin Mallory]

I'm adding my voice to that request as well.  As someone that primarily tests 
builds, finds bugs, and suggests/pushes/begs new features, and who doesnt 
really understand code, these code reviews do nothing but clutter up an email 
address that I already don't have time to give the attention it should.  Please 
consider a new email list. 

> Date: Thu, 2 Dec 2010 11:41:11 -0500
> From: jhwe...@gmail.com
> To: opensource-dev@lists.secondlife.com
> Subject: Re: [opensource-dev] Review board & lists
> 
> Oz, there is a flaw in your logic about our ability to filter out
> review messages sent to this list.
> 
> I receive this list in digest format.  It's easier for me to scan
> through it that way, so I have no ability to filter out these review
> board messages.
> 
> I'm with Boroondas--please set up another mailing list to receive
> these messages.
> 
> -Jonathan
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
  ___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Starting Investigation into Storm-236

[WolfPup Lowenhar]

I have created a repository for https://jira.secondlife.com/browse/STORM-236
to investigate the best way to go about providing this functionality to
those that do not use voice or use it intermittently.

My thoughts are to have one of the following:

1. Have the Speak button follow the Voice Preference setting ( on or off
) and either be visible or not accordingly instead of being just being
grayed out with the indicator showing not available.

2. Include option 1 pulse include in the bottom tray context menu the
ability to toggle Voice off or on as this would then in turn toggle the
Speak buttons visibility and add more accessibility to that setting.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Thickbrick Sleaford]

---
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/2/#review13
---



indra/newview/llappviewer.cpp


Somewhat tangential to this patch: this line is wrong. It should use 
gFrameIntervalSeconds, not gFarmeTimeSeconds. As it is, max_idle_time will 
always be clamped to 0.005.

The comment is also wrong/outdated. It should be something like "50 
ms/second, up to 5 ms/frame."


- Thickbrick


On 2010-12-01 19:57:24, Oz Linden wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
> ---
> 
> (Updated 2010-12-01 19:57:24)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> ---
> 
> This review is mostly a first test of reviewboard.
> 
> I do have an esthetic dislike for the 'break' statement anywhere but as the 
> end of a case, so I chose to change some instances of break usage that were 
> not justified by any extreme need.
> 
> 
> This addresses bug storm-606.
> http://jira.secondlife.com/browse/storm-606
> 
> 
> Diffs
> -
> 
>   indra/newview/llappviewer.cpp bf98b026bcb1 
> 
> Diff: http://codereview.secondlife.com/r/2/diff
> 
> 
> Testing
> ---
> 
> None at all... have not even compiled it yet.
> 
> 
> Thanks,
> 
> Oz
> 
>

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Starting Investigation into Storm-236

[Sarah (Esbee) Kuehnle]

Wolfpup,

Just a heads up - this is not work we've committed to doing yet. I pulled it
into STORM so we could review it internally and decide if it gets pulled
onto our backlog - that's why you'll see it marked as being in the 'Product
Backlog Proposals' version. There is a different internal team who own
Voice, so we'll likely submit this to them so they can decide on its
business and product value.

--Esbee



On Thu, Dec 2, 2010 at 12:00 PM, WolfPup Lowenhar
wrote:

> I have created a repository for
> https://jira.secondlife.com/browse/STORM-236 to investigate the best way
> to go about providing this functionality to those that do not use voice or
> use it intermittently.
>
> My thoughts are to have one of the following:
>
> 1. Have the Speak button follow the Voice Preference setting ( on or
> off ) and either be visible or not accordingly instead of being just being
> grayed out with the indicator showing not available.
>
> 2. Include option 1 pulse include in the bottom tray context menu the
> ability to toggle Voice off or on as this would then in turn toggle the
> Speak buttons visibility and add more accessibility to that setting.
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Gigs]

I'm getting "To protect your privacy, Thunderbird has blocked remote 
content."   Why do the message include external images?  As well because 
the "From" field is a person and not the list, I would have to whitelist 
every contributor to get rid of the message.

On 12/02/2010 12:05 PM, Thickbrick Sleaford wrote:
>
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/2/
>
>
> indra/newview/llappviewer.cpp
> 
> (Diff revision 1)
>
> bool LLAppViewer::mainLoop()
>
> 1184  
>
>   const  F64  max_idle_time  =  
> llmin(.005*10.0*gFrameTimeSeconds,  0.005);  // 5 ms a second
>
>   1184
>
>   const  F64  max_idle_time  =  
> llmin(.005*10.0*gFrameTimeSeconds,  0.005);  // 5 ms a second
>
> Somewhat tangential to this patch: this line is wrong. It should use 
> gFrameIntervalSeconds, not gFarmeTimeSeconds. As it is, max_idle_time will 
> always be clamped to 0.005.
>
> The comment is also wrong/outdated. It should be something like"50 ms/second, 
> up to 5 ms/frame."
>
>
> - Thickbrick
>
>
> On December 1st, 2010, 7:57 p.m., Oz Linden wrote:
>
> Review request for Viewer.
> By Oz Linden.
>
> /Updated 2010-12-01 19:57:24/
>
>
>   Description
>
> This review is mostly a first test of reviewboard.
>
> I do have an esthetic dislike for the'break'  statement anywhere but as the 
> end of a case, so I chose to change some instances of break usage that were 
> not justified by any extreme need.
>
>
>   Testing
>
> None at all... have not even compiled it yet.
>
> *Bugs: * storm-606 
>
>
>   Diffs
>
> * indra/newview/llappviewer.cpp (bf98b026bcb1)
>
> View Diff 
>
>
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Starting Investigation into Storm-236

[Kitty]

I have a patch for that already if you like.

 

The button's visibility will follow the voice preference (visible when voice
is enabled, and invisible when voice is disabled), along with the bottom
tray context menu option to hide it even when voice is enabled (so the same
as your option 2).

 

I've been using it for just under 3 months so there shouldn't be any major
issues with it anymore (I hope :p).

 

Kitty

 

From: opensource-dev-boun...@lists.secondlife.com
[mailto:opensource-dev-boun...@lists.secondlife.com] On Behalf Of WolfPup
Lowenhar
Sent: donderdag 2 december 2010 18:01
To: OpenSource Mailing List
Subject: [opensource-dev] Starting Investigation into Storm-236

 

I have created a repository for https://jira.secondlife.com/browse/STORM-236
to investigate the best way to go about providing this functionality to
those that do not use voice or use it intermittently.

My thoughts are to have one of the following:

1. Have the Speak button follow the Voice Preference setting ( on or off
) and either be visible or not accordingly instead of being just being
grayed out with the indicator showing not available.

2. Include option 1 pulse include in the bottom tray context menu the
ability to toggle Voice off or on as this would then in turn toggle the
Speak buttons visibility and add more accessibility to that setting.

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

[Ricky]

Hmm, it appears to have "background-image:
url('http://codereview.secondlife.comrb/image=s/review_request_box_top_bg.png');"
in the style attribute for one of the tables.  (Don't know why tables
were used instead of divs like the site is built...)

Beyond the fact that it isn't necessary, the URL is also wrong.  The
correct URL is:
https://codereview.secondlife.com/media/rb/images/review_request_box_top_bg.png

Ricky
Cron Stardust

On Thu, Dec 2, 2010 at 12:05 PM, Gigs  wrote:
> I'm getting "To protect your privacy, Thunderbird has blocked remote
> content."   Why do the message include external images?  As well because
> the "From" field is a person and not the list, I would have to whitelist
> every contributor to get rid of the message.
>
> On 12/02/2010 12:05 PM, Thickbrick Sleaford wrote:
>>
>> This is an automatically generated e-mail. To reply, visit:
>> http://codereview.secondlife.com/r/2/
>>
>>
>> indra/newview/llappviewer.cpp
>> 
>> (Diff revision 1)
>>
>> bool LLAppViewer::mainLoop()
>>
>> 1184
>>
>>                               const  F64  max_idle_time  =  
>> llmin(.005*10.0*gFrameTimeSeconds,  0.005);  // 5 ms a second
>>
>>       1184
>>
>>                               const  F64  max_idle_time  =  
>> llmin(.005*10.0*gFrameTimeSeconds,  0.005);  // 5 ms a second
>>
>> Somewhat tangential to this patch: this line is wrong. It should use 
>> gFrameIntervalSeconds, not gFarmeTimeSeconds. As it is, max_idle_time will 
>> always be clamped to 0.005.
>>
>> The comment is also wrong/outdated. It should be something like"50 
>> ms/second, up to 5 ms/frame."
>>
>>
>> - Thickbrick
>>
>>
>> On December 1st, 2010, 7:57 p.m., Oz Linden wrote:
>>
>> Review request for Viewer.
>> By Oz Linden.
>>
>> /Updated 2010-12-01 19:57:24/
>>
>>
>>   Description
>>
>> This review is mostly a first test of reviewboard.
>>
>> I do have an esthetic dislike for the'break'  statement anywhere but as the 
>> end of a case, so I chose to change some instances of break usage that were 
>> not justified by any extreme need.
>>
>>
>>   Testing
>>
>> None at all... have not even compiled it yet.
>>
>> *Bugs: * storm-606 
>>
>>
>>   Diffs
>>
>>     * indra/newview/llappviewer.cpp (bf98b026bcb1)
>>
>> View Diff 
>>
>>
>>
>> ___
>> Policies and (un)subscribe information available here:
>> http://wiki.secondlife.com/wiki/OpenSource-Dev
>> Please read the policies before posting to keep unmoderated posting 
>> privileges
>
> ___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges
>
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Re: [opensource-dev] POTENTIAL SHOW STOPPER

[Trilo Byte]

The latest Mesh Project Snapshot build for Mac (downloaded from LL as Second 
Life Developer, build 215879) was trash for me, though apparently different 
reason.  Major regression, deferred rendering filled the screen with a mix of 
black and glowing chunks of graphics garbage.  I'm thinking it had to be a 
mistake somewhere, as the downloaded file had the name 
"SecondLife_2_1_2_215879_DEVELOPER.dmg" (the 2_1_2 ought to have been a 2_4_0 
or 2_5_0).

TriloByte Zanzibar

On Dec 2, 2010, at 5:44 PM, WolfPup Lowenhar wrote:

> Well it could be for OS devs still working with viewer-development if 
> mesh-development get merged to v-d in its current condition. Attached is the 
> outputs from me trying to get mesh-development to build on my system plust 
> the debug outputs for TWO failing integration test and the generated viewer. 
> All three crash immediately on start. A viewer built on the LL build farms 
> will start just fine, at least the one I had installed a couple of weeks ago.
>  
> My development environment:
> CPU: Intel Pentum D 820 running @ 2.8GHz
> Memory: 2GB
> OS: Windows 7 32-bit
> Graphics card: nVida GForce 8500 GT w/1GB video memory on the card
> IDE: Visual Studio 2005 Pro plus all needed extra programs and SDK’s
>  
> Now I can build viewer-development just fine even though it takes me ~3Hrs to 
> do a full build that includes all test to make sure everything is working the 
> way it should. I can even run my builds of v-d with no problems.
>  mode.txt>___
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting privileges

___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] nametag opacity

[Chuck Baggett]

Are the nametags fixed at 100 per cent opaque or are they of variable
opacity?

By nametags I mean avatar names and group titles.
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] sidebar covering the bottom bar

[Chuck Baggett]

Is there any hope of not having the sidebar cover the bottom bar?
___
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

[opensource-dev] Daily Scrum Summary - Thursday, December 2

[Anya Kanevsky]

 Thursday, December 2, 2010 General Notes
--

   - Merge Monkey of the Day: Oz

Team Status
--
 Merov Linden
--

*PAST*

   - STORM-151: kdu compression: More work on this. Explored some viewer j2c
   compression usage while at it. Started to write doc on all this:
   https://wiki.lindenlab.com/wiki/Kakadu_Update (LL internal for the
   moment).

*FUTURE*

   - STORM-151: kdu compression: Push some compression code into my public
   repo.

*IMPEDIMENTS*

   - none

Oz Linden
--

*PAST*

   - Resize codereview file system
   - Post test review
   - Announce/Open code review system
   - Pulled a bunch of issues for viewer-development
  - turned out some of these should have been beta, so have to re-do
  them

*FUTURE*

   - Merge Monkeying
   - Document code review system on wiki

*IMPEDIMENTS*

   - none

Q Linden
--

   - OOO

Esbee Linden
--

*PAST*

   -
  - OOO - sick
   - Provided default transparency info on STORM-535

*FUTURE*

   - Work on internal reporting documents
   - Get caught up

*IMPEDIMENTS*

   - Still sick and moving a bit slower than I'd like

_ FEEL BETTER ESBEEE!
Paul ProductEngine
--

*PAST*

   - TASK STORM- 622 (Texture picker screws up when multiple textures are
   opened)
  - WIP. Estimate ~ 8 hours

*FUTURE*

   - STORM-684 subtasks (fix transparency in some panels/floaters).

*IMPEDIMENTS*

   - none

Seth Productengine
--

*PAST*

   - BUG (STORM-579) Resident SLURL font color doesn't match Chat
   preferences for plain text Nearby Chat log
  - WIP. Working on using custom style for SLURLs in chat. Looks like it
  may be possible if SLURLs will use custom style only for residents' and
  objects' names, not for any SLURL occurrence in chat.
   - TASK (STORM-584) Fix color and opacity setting for Bubble Chat
  - Got the fix approved and pushed to bitbucket repo.

*FUTURE*

   - BUG (STORM-579) Resident SLURL font color doesn't match Chat
   preferences for plain text Nearby Chat log
   - TASK (STORM-693) Preview thumbnails in the Edit Wearable and Edit Body
   Parts panels do not honor opacity settings

*IMPEDIMENTS*

   - none

Andrew Productengine
--

*PAST*

   - Normal task STORM-34 (As a User, I want a list of my favorite locations
   available on the login screen so i can log in to SL right where I want to
   be).
  - Investigated further. Discussed with Vadim. Started implementing.
  Estimate - 3d, but tomorrow will evaluate what is done and what
is left, and
  depending on it may give part of work to Sergey if I will not be able to
  complete implementation on my own before the sprint ends.

*FUTURE*

   - Normal task STORM-34 (As a User, I want a list of my favorite locations
   available on the login screen so i can log in to SL right where I want to
   be).

*IMPEDIMENTS*

   - STORM-527 needs a new home

_ Q is looking for it
Vadim Productengine
--

*PAST*

   - Made additional fixes for:
  - Task STORM-676 (Color swatches inside transparent floater are not
  transparent).
  - Task STORM-677 (Texture pickers inside transparent floater are not
  transparent).
  - Bug STORM-432 (Trash button in People > My Friends tab can be
  moved).
   - Fixed:
  - Task STORM-687 (Snapshot thumbnail in the Email Snapshot floater
  doesn't honor floater opacity settings).

*FUTURE*

   - Continue with transparency-related fixes.

*IMPEDIMENTS*

   - Our transparency-related work still hasn't been integrated into beta.

_ It's going to be as soon as we release beta 1.

   - Will Esbee take a look at STORM-28?

_ Not in this sprint

   - Is there a way to assign STORM-564 to Monroe Linden?

_ Done. LEAP-20
Andrey Productengine
--

*PAST*

   - re-ran smoke & integrity tests against Beta1 r215703 build
   - verified STORM-667 hotfix for beta
   - 2.4.0 bugfixes verification, see spreadsheet

*FUTURE*

   - switch to the latest v-d build
   - verify integrated tickets and do some regression testing in scope of
   recent changes

*IMPEDIMENTS*

   - none

Jonathan Yap
--

*PAST*

   - Commented on code review system.
   - STORM-713 -- This should be fixed before a viewer is released.
   - STORM-523
  - Could not reproduce myself or with another tester. Need a screen
  shot from the reporter. Reporter says she could reproduce this
with my test
  object. Better way would be to send these notifications to local chat.
   - VWR-24053 (Start Location preference not always obeyed)

*FUTURE*

   - [long range]
  - Update lsl wiki - remove Unsupported icon next to llTextBox. Timing
  of when to make this edit?

*IMPEDIMENTS*

   - I need someone to assign VWR-24053 t