https://codereview.secondlife.com/account/register/ advises: > Use the email address that you have associated with that Jira account. However, as mails automatically generated from my actions on Review Board get sent to the mailing list, I now changed the address in my SL Review Board profile to my mailing list address, so that future messages won't get rejected.
Cheers, Boroondas On 12/02/2010 12:40 PM, opensource-dev-ow...@lists.secondlife.com wrote: > You are not allowed to post to this mailing list, and your message has > been automatically rejected. If you think that your messages are > being rejected in error, contact the mailing list owner at > opensource-dev-ow...@lists.secondlife.com. > > -------- Attached Email -------- > Subject: Re: Review Request: Restructure loops that use breaks > without need (reviewboard test) > Date: Thu, 02 Dec 2010 11:40:12 -0000 > From: Boroondas Gupte <*[The address I use for jira* (different from > the one I use for the mailing list and not intended for public > visibility)*]*> > To: Boroondas Gupte <*[...]*>, Oz Linden <o...@lindenlab.com>, Viewer > <opensource-dev@lists.secondlife.com> > > > > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/2/ > > > indra/newview/llappviewer.cpp > <http://codereview.secondlife.com/r/2/diff/1/?file=8#file8line1188> > (Diff revision 1) > bool LLAppViewer::mainLoop() > 1188 > S32 total_io_pending = 0; > > 1188 > S32 total_io_pending = 0; > > > While you're at it, please fix the whitespace errors in the touched (and > nearby) code. (In a separate changeset, though, if possible) > > The Review-Board diff view conveniently highlights them in red, so they are > hard to miss ;-) > > indra/newview/llappviewer.cpp > <http://codereview.secondlife.com/r/2/diff/1/?file=8#file8line1199> > (Diff revision 1) > bool LLAppViewer::mainLoop() > 1195 > work_pending += > LLAppViewer::getTextureCache()->update(1); // unpauses the texture cache > thread > 1199 > work_pending += > LLAppViewer::getTextureCache()->update(1); // unpauses the texture cache > thread > > e.g. here: spaces before tabs > > indra/newview/llappviewer.cpp > <http://codereview.secondlife.com/r/2/diff/1/?file=8#file8line1631> > (Diff revision 1) > bool LLAppViewer::cleanup() > 1624 > if(!pending) > 1623 > } while ( pending && idle_time < max_idle_time) > > Your change even introduces new whitespace errors (trailing whitespace here) > > - Boroondas > > > On December 1st, 2010, 7:57 p.m., Oz Linden wrote: > > Review request for Viewer. > By Oz Linden. > > /Updated 2010-12-01 19:57:24/ > > > Description > > This review is mostly a first test of reviewboard. > > I do have an esthetic dislike for the 'break' statement anywhere but as the > end of a case, so I chose to change some instances of break usage that were > not justified by any extreme need. > > > Testing > > None at all... have not even compiled it yet. > > *Bugs: * storm-606 <http://jira.secondlife.com/browse/storm-606> > > > Diffs > > * indra/newview/llappviewer.cpp (bf98b026bcb1) > > View Diff <http://codereview.secondlife.com/r/2/diff/> >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
