Re: [PR] Typo fixes [logging-log4j-samples]
avrilfanomar commented on PR #312: URL: https://github.com/apache/logging-log4j-samples/pull/312#issuecomment-2800051345 Maybe SSH keys are not supported since the one I've used is already there on my account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adapt `merge-dependabot` to RTC [logging-log4j2]
vy commented on PR #3603: URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2800065811 @ppkarwasz, please do not proceed with this change – I am DM'ing you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] LoggerContext fires 2 PropertyChangeEvent with 'propertyName' set to 'config' on a single reconfigure [logging-log4j2]
vy commented on issue #3546: URL: https://github.com/apache/logging-log4j2/issues/3546#issuecomment-2800067127 > I am wondering if the `updateLoggers` PropertyChangeEvent should use a different property-name. @JWT007, can you elaborate on this suggestion, please? Would you also mind sharing the (backward) compatibility risks of such a change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adapt `merge-dependabot` to RTC [logging-log4j2]
ppkarwasz commented on PR #3603: URL: https://github.com/apache/logging-log4j2/pull/3603#issuecomment-2800085765 > @ppkarwasz, please do not proceed with this change – I am DM'ing you. This is the magic of RTC: I can not merge any PR unless you or another committer agrees. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump aspectj.version from 1.9.23 to 1.9.24 [logging-log4j-samples]
github-actions[bot] merged PR #317: URL: https://github.com/apache/logging-log4j-samples/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/logging-parent/.github/workflows/build-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 [logging-log4j-scala]
ppkarwasz closed pull request #71: Bump apache/logging-parent/.github/workflows/build-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 URL: https://github.com/apache/logging-log4j-scala/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/logging-parent/.github/workflows/codeql-analysis-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 [logging-log4j-scala]
ppkarwasz closed pull request #74: Bump apache/logging-parent/.github/workflows/codeql-analysis-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 URL: https://github.com/apache/logging-log4j-scala/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Activate `use-apache-snapshots` profile [logging-parent]
ppkarwasz commented on issue #373: URL: https://github.com/apache/logging-parent/issues/373#issuecomment-2800100901 > > We can activate the profile only in the builds that actually need it (e.g. `logging-log4j-samples`) > > I'd be in favor of this approach. Expose it wherever it is needed. For now I did it in apache/logging-log4j-samples#306 and I think it is the only repo that requires it. On the other hand there is a small problem during development: if you work let us say on `log4j-core` and you want to download `log4j-api` from our Snapshots, you need to run: ```bash mvn -pl log4j-core -Puse-apache-snapshots ``` or use a local build instead and make a `mvn install` before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove `merge-dependabot` workflow [logging-log4j-samples]
ppkarwasz commented on PR #311: URL: https://github.com/apache/logging-log4j-samples/pull/311#issuecomment-2800106471 > Along with this change, can you configure dependabot to group the updates, please? So that we just need to approve one dependabot PR per week. Done in https://github.com/apache/logging-log4j-samples/pull/311/commits/dcda7652194b0a7726a06ac68af3e1a88628fef1 and https://github.com/apache/logging-log4j-samples/pull/311/commits/d0870a22d0b8adf25338d130670a9892a9fa0338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add "Sponsor" buttons to repository [logging-log4j2]
ppkarwasz merged PR #3580: URL: https://github.com/apache/logging-log4j2/pull/3580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add missing dependencies [logging-log4j-tools]
vy commented on code in PR #175:
URL:
https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2041192370
##
log4j-tools-parent/pom.xml:
##
@@ -46,6 +46,11 @@
5.12.0
2.1.2
2.10.0
+2.0.0
+
1.1.2
+4.8.6
+1.0.0
+7.0.0
Review Comment:
1. I think some of these versions are out-of-date. Could you update them,
please?
2. Properties are alphanumerically ordered. Could you adhere to that, please?
##
log4j-tools-parent/pom.xml:
##
@@ -140,6 +145,37 @@
${xmlunit.version}
+
+
+org.osgi
+org.osgi.annotation.bundle
+${osgi.annotation.bundle.version}
+
+
+
+org.osgi
+org.osgi.annotation.versioning
+${osgi.annotation.versioning.version}
+
+
+
+com.github.spotbugs
+spotbugs-annotations
+${spotbugs-annotations.version}
+
+
+
+org.jspecify
+jspecify
+${jspecify.version}
+
+
+
+biz.aQute.bnd
+biz.aQute.bnd.annotation
+${bnd.annotation.version}
+
Review Comment:
Dependencies are ordered by `artifactId`. Could you adhere to that, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]
github-actions[bot] commented on PR #3501: URL: https://github.com/apache/logging-log4j2/pull/3501#issuecomment-2800111322 Job Requested goals Build Tool Version Build Outcome Build Scan® build-macos-latest clean install 3.9.8 :x: https://develocity.apache.org/s/x7sovqlqjp574"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> build-ubuntu-latest clean install 3.9.8 :x: https://develocity.apache.org/s/rcppe2gi6qguu"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> build-windows-latest clean install 3.9.8 :x: https://develocity.apache.org/s/zuqals5fqymiu"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> ## Generated by gradle/develocity-actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Activate `use-apache-snapshots` profile [logging-parent]
vy commented on issue #373: URL: https://github.com/apache/logging-parent/issues/373#issuecomment-2800098008 Ugh! This hurts. Thanks for spotting this @ppkarwasz! > the pom adds the Apache snapshot repository (https://repository.apache.org/snapshots) This only happens if the `apache.snapshots` property is set, or the `use-apache-snapshots` profile is active. I guess we can also use the shared property too. > We can activate the profile only in the builds that actually need it (e.g. `logging-log4j-samples`) I'd be in favor of this approach. Expose it wherever it is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Typo fixes [logging-log4j-samples]
ppkarwasz merged PR #312: URL: https://github.com/apache/logging-log4j-samples/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add `log4j.plugin.enableBndAnnotations` option to `PluginProcessor` [logging-log4j2]
ppkarwasz commented on code in PR #3258: URL: https://github.com/apache/logging-log4j2/pull/3258#discussion_r2041203562 ## src/changelog/.3.x.x/3151_plugin_processor_bnd_annotations.xml: ## Review Comment: In the current status, it will have external effects. Users with BND Annotations on the "normal" classpath will get a different class that those without it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add "Sponsor" buttons to repository [logging-log4j2]
ppkarwasz commented on PR #3580: URL: https://github.com/apache/logging-log4j2/pull/3580#issuecomment-2800108229 @vy, This didn't work as expected. I am getting an error: > Some errors were encountered when parsing the `FUNDING.yml` file: > > - You can specify up to 1 organization and 4 users. > > [Learn more about formatting FUNDING.yml](https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository). Needless to say, you were cut out. :cry: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add option to provide URIs to monitor in addition to the config file [logging-log4j2]
vy commented on code in PR #3501:
URL: https://github.com/apache/logging-log4j2/pull/3501#discussion_r2041190519
##
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java:
##
@@ -767,6 +785,18 @@ protected void doConfigure() {
setParents();
}
+private List convertToJavaNetUris(final List uris) {
+final List javaNetUris = new ArrayList<>();
+for (Uri uri : uris) {
+try {
+javaNetUris.add(new URI(uri.getUri()));
+} catch (URISyntaxException e) {
+LOGGER.error("Error parsing monitor URI: " + uri, e);
Review Comment:
Are we sure we want to proceed with (re)configuration obtained from an
invalid configuration? I think we should propagate the exception and let it
fail.
##
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFileWatcher.java:
##
@@ -28,38 +31,57 @@
*/
public class ConfigurationFileWatcher extends AbstractWatcher implements
FileWatcher {
-private File file;
-private long lastModifiedMillis;
+private Map monitoredFiles = new HashMap<>();
public ConfigurationFileWatcher(
final Configuration configuration,
final Reconfigurable reconfigurable,
final List configurationListeners,
long lastModifiedMillis) {
super(configuration, reconfigurable, configurationListeners);
-this.lastModifiedMillis = lastModifiedMillis;
}
@Override
public long getLastModified() {
-return file != null ? file.lastModified() : 0;
+Long lastModifiedMillis = 0L;
+for (final File monitoredFile : monitoredFiles.keySet()) {
+if (monitoredFile.lastModified() > lastModifiedMillis) {
+lastModifiedMillis = monitoredFile.lastModified();
+}
+}
+return lastModifiedMillis;
}
@Override
public void fileModified(final File file) {
-lastModifiedMillis = file.lastModified();
+monitoredFiles.entrySet().stream()
+.forEach(monitoredFile ->
+
monitoredFile.setValue(monitoredFile.getKey().lastModified()));
Review Comment:
Shouldn't you be `monitoredFiles.get(file)` and then...?
##
log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java:
##
@@ -323,10 +325,19 @@ public void start() {
LOGGER.info("Starting configuration {}...", this);
this.setStarting();
if (watchManager.getIntervalSeconds() >= 0) {
-LOGGER.info(
-"Start watching for changes to {} every {} seconds",
-getConfigurationSource(),
-watchManager.getIntervalSeconds());
+if (uris != null && uris.size() > 0) {
+LOGGER.info(
+"Start watching for changes to {} and {} every {}
seconds",
+getConfigurationSource(),
+uris,
+watchManager.getIntervalSeconds());
+watchManager.addMonitorUris(configurationSource.getSource(),
uris);
Review Comment:
Can't we instead for each URI create a new `ConfigurationFileWatcher` and
register it using `watchManager.watch(cfgSource, watcher)`?
##
log4j-core/src/main/java/org/apache/logging/log4j/core/config/ConfigurationFileWatcher.java:
##
@@ -28,38 +31,57 @@
*/
public class ConfigurationFileWatcher extends AbstractWatcher implements
FileWatcher {
-private File file;
-private long lastModifiedMillis;
+private Map monitoredFiles = new HashMap<>();
public ConfigurationFileWatcher(
final Configuration configuration,
final Reconfigurable reconfigurable,
final List configurationListeners,
long lastModifiedMillis) {
super(configuration, reconfigurable, configurationListeners);
-this.lastModifiedMillis = lastModifiedMillis;
}
@Override
public long getLastModified() {
-return file != null ? file.lastModified() : 0;
+Long lastModifiedMillis = 0L;
+for (final File monitoredFile : monitoredFiles.keySet()) {
+if (monitoredFile.lastModified() > lastModifiedMillis) {
+lastModifiedMillis = monitoredFile.lastModified();
+}
+}
+return lastModifiedMillis;
}
@Override
public void fileModified(final File file) {
-lastModifiedMillis = file.lastModified();
+monitoredFiles.entrySet().stream()
+.forEach(monitoredFile ->
+
monitoredFile.setValue(monitoredFile.getKey().lastModified()));
}
@Override
public void watching(final Source source) {
-file = source.getFile();
-lastModifiedMillis = file.lastModified();
+File file = source.getFi
Re: [PR] Add missing dependencies [logging-log4j-tools]
vy commented on code in PR #175: URL: https://github.com/apache/logging-log4j-tools/pull/175#discussion_r2041191985 ## pom.xml: ## @@ -31,7 +31,7 @@ org.apache.logging logging-parent -11.0.0 +12.1.0-SNAPSHOT Review Comment: @ppkarwasz, thanks for your kinds heads up. You're right. I'm the one who told @alan0428a to do it this way, so he can develop locally, and verify his changes without waiting for the next `logging-parent` release to submit a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Log file timestamp not updated on some file systems. Support periodic sync to flush metadata to FS [logging-log4j2]
vy commented on issue #3593: URL: https://github.com/apache/logging-log4j2/issues/3593#issuecomment-2800096836 @roytmana, I am reluctant to push a fix for an OpenJDK bug that will probably be addressed by either the OpenJDK or Azure in the future. Would it be possible for you to repeat the following in a background thread? 1. Programmatically obtain the appender 2. Get your hands on its `FileOutputStream` (via reflection?) 3. Run `FileOutputStream.getFD().sync()` on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [main] Create `DefaultLayout` independent of `PatternLayout` [logging-log4j2]
ppkarwasz merged PR #3584: URL: https://github.com/apache/logging-log4j2/pull/3584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove daily samples build [logging-log4j-samples]
ppkarwasz merged PR #304: URL: https://github.com/apache/logging-log4j-samples/pull/304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/logging-parent/.github/workflows/merge-dependabot-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 [logging-log4j-scala]
ppkarwasz closed pull request #73: Bump apache/logging-parent/.github/workflows/merge-dependabot-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 URL: https://github.com/apache/logging-log4j-scala/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump apache/logging-parent/.github/workflows/deploy-site-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 [logging-log4j-scala]
ppkarwasz closed pull request #72: Bump apache/logging-parent/.github/workflows/deploy-site-reusable.yaml@rel/11.3.0 from 11.3.0 to 12.0.0 URL: https://github.com/apache/logging-log4j-scala/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.junit:junit-bom from 5.12.1 to 5.12.2 in /log4j-samples-graalvm [logging-log4j-samples]
ppkarwasz merged PR #318: URL: https://github.com/apache/logging-log4j-samples/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add `log4j.plugin.enableBndAnnotations` option to `PluginProcessor` [logging-log4j2]
vy commented on code in PR #3258: URL: https://github.com/apache/logging-log4j2/pull/3258#discussion_r2041195036 ## src/changelog/.3.x.x/3151_plugin_processor_bnd_annotations.xml: ## Review Comment: Since this is an internal change and not intended for public consumption, I am inclined to avoid a change log entry. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Exclude certain standard library classes from docgen type exclusion (#3423) [logging-log4j2]
github-actions[bot] commented on PR #3568: URL: https://github.com/apache/logging-log4j2/pull/3568#issuecomment-2800091324 Job Requested goals Build Tool Version Build Outcome Build Scan® build-macos-latest clean install 3.9.8 :x: https://develocity.apache.org/s/e2f5fopgh37j2"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> build-ubuntu-latest clean install 3.9.8 :x: https://develocity.apache.org/s/joxt3jeaxmd7a"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> build-windows-latest clean install 3.9.8 :x: https://develocity.apache.org/s/jdqs3luaq7rm6"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> ## Generated by gradle/develocity-actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Typo fixes [logging-log4j-samples]
ppkarwasz commented on PR #312: URL: https://github.com/apache/logging-log4j-samples/pull/312#issuecomment-2800093867 @avrilfanomar, SSH signatures are probably not supported. I resigned the commits with my GPG key. Thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move JSpecify from `provided` to `compile` scope [logging-log4j2]
ppkarwasz commented on code in PR #3228: URL: https://github.com/apache/logging-log4j2/pull/3228#discussion_r2041080025 ## log4j-api/pom.xml: ## @@ -63,16 +63,19 @@ - org.jspecify - jspecify + org.osgi + org.osgi.core provided + - org.osgi - org.osgi.core - provided + org.jspecify + jspecify Review Comment: Fixed in https://github.com/apache/logging-log4j2/pull/3228/commits/a86d7ca480400de309623c22c7549da14f0c8008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Move JSpecify from `provided` to `compile` scope [logging-log4j2]
ppkarwasz commented on PR #3228: URL: https://github.com/apache/logging-log4j2/pull/3228#issuecomment-2799870211 @rgoers, I moved `jspecify` into the `provided` scope for `log4j-api`. Can you review this PR again? **Note**: The build is expected to fail until #3601 is fixed. I opened #3602 that awaits a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add `collectionName` and `databaseName` attributes to `MongoDbProvider` [logging-log4j2]
ppkarwasz commented on PR #3322: URL: https://github.com/apache/logging-log4j2/pull/3322#issuecomment-2799875695 @jesmith17, Could you address @vy's suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
