[PR] Upgrade Jekyll docker file [logging-site]
ppkarwasz opened a new pull request, #8: URL: https://github.com/apache/logging-site/pull/8 This change upgrades Jekyll's docker file, since the old images are no longer available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.palantir.javaformat:palantir-java-format from 2.58.0 to 2.59.0 [logging-parent]
github-actions[bot] merged PR #352: URL: https://github.com/apache/logging-parent/pull/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Apply Antora styling to main page [logging-site]
ppkarwasz opened a new pull request, #9: URL: https://github.com/apache/logging-site/pull/9 This change applies parts of the [Default Antora stylesheet](https://gitlab.com/antora/antora-ui-default/-/tree/master/src/css?ref_type=heads) and the [Log4j style customizations](https://github.com/apache/logging-log4j2/blob/2.x/antora-playbook.yaml) to the main website. In particular, we change: - The default font to Roboto. - The size of text in paragraphs and admonition boxes, - The font size, weight and style of headers and their margins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] docsImprove String concatenation best practice [logging-log4j2]
ppkarwasz opened a new pull request, #3553:
URL: https://github.com/apache/logging-log4j2/pull/3553
This change splits the "don't use String concatenation" best practice into
two parts:
- A recommendation concerning performance: string concatenation is not
efficient if the logger is off.
- A security recommendation: format string must be constants to prevent `{}`
placeholder injection.
The `${dangerousLookup}` part of the example is removed, since lookups are
not executed since version `2.15.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump com.google.guava:guava from 33.4.0-jre to 33.4.5-jre [logging-log4j-samples]
github-actions[bot] merged PR #296: URL: https://github.com/apache/logging-log4j-samples/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enabled GH discussions [logging-log4j2]
ppkarwasz commented on code in PR #3552: URL: https://github.com/apache/logging-log4j2/pull/3552#discussion_r2003869362 ## .asf.yaml: ## @@ -37,6 +37,7 @@ github: homepage: https://logging.apache.org/log4j/2.x features: issues: true +discussions: true Review Comment: Can you add `projects` too? I would like to have a public TODO list of things to do in Log4j. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enabled GH discussions [logging-log4j2]
swebb2066 commented on PR #3552: URL: https://github.com/apache/logging-log4j2/pull/3552#issuecomment-2739023255 You will also need to add an e-mail in to 'notifications' section like: ``` notifications: jira_options: link label discussions: d...@logging.apache.org ``` or you will encounter this infra error > GitHub discussions can only be enabled if a mailing list target exists for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.5.17 to 1.5.18 [logging-log4j2]
github-actions[bot] merged PR #3550: URL: https://github.com/apache/logging-log4j2/pull/3550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException [logging-log4j2]
pmk75 opened a new issue, #3551: URL: https://github.com/apache/logging-log4j2/issues/3551 ## Description LoggerContext.updateLoggers throws a ConcurrentModificationException randomly when called by javamelody filter initialisation during tomcat startup. Result is that tomcat is incorrectly started, process is there but does not serve any request ## Configuration **Version:** 2.24.2 **Operating system:** Ubuntu 24.04 **JDK:** amazon-corretto-17.0.10.8.1-linux-x64 ## Logs ```java 19-Mar-2025 05:35:40.941 SEVERE [main] org.apache.catalina.core.StandardContext.filterStart Exception starting filter [javamelody] java.util.ConcurrentModificationException at java.base/java.util.HashMap$ValueSpliterator.forEachRemaining(HashMap.java:1784) at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762) at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276) at java.base/java.util.WeakHashMap$ValueSpliterator.forEachRemaining(WeakHashMap.java:1217) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) at org.apache.logging.log4j.core.LoggerContext.updateLoggers(LoggerContext.java:776) at org.apache.logging.log4j.core.LoggerContext.updateLoggers(LoggerContext.java:766) at net.bull.javamelody.Log4J2Appender.register(Log4J2Appender.java:86) at net.bull.javamelody.FilterContext.initLogs(FilterContext.java:333) at net.bull.javamelody.FilterContext.(FilterContext.java:98) at net.bull.javamelody.MonitoringFilter.init(MonitoringFilter.java:148) at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:244) ``` ## Reproduction Randomly appears at startup (every 5 to 10 starts) ## Discussion The related javamelody code is here https://github.com/javamelody/javamelody/blob/6bb2b275b7dc77cded89ac661352094e10449e16/javamelody-core/src/main/java/net/bull/javamelody/Log4J2Appender.java#L86 And the exception is thrown here https://github.com/apache/logging-log4j2/blob/3ffaf76fbd893055d8b60e0d1c319676aa58437e/log4j-core/src/main/java/org/apache/logging/log4j/core/LoggerContext.java#L812 May be it would be safer to wrap the loggerRegistry.getLoggers() collection, in a separate one such as ``` new ArrayList<>(loggerRegistry.getLoggers()).forEach( ``` to avoid potential concurrent modification. Not really sure of the cause and therefore the potential solution. Did anybody else noticed this issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade Jekyll docker file [logging-site]
grobmeier merged PR #8: URL: https://github.com/apache/logging-site/pull/8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException [logging-log4j2]
ppkarwasz closed issue #3551: Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException URL: https://github.com/apache/logging-log4j2/issues/3551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Enabled GH discussions [logging-log4j2]
grobmeier opened a new pull request, #3552: URL: https://github.com/apache/logging-log4j2/pull/3552 A recent change made it necessary to enable GH discussions on .asf.yml: https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#repository-features If we want to continue "discussions", we need to switch the flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Enabled GH discussions [logging-log4j2]
grobmeier commented on code in PR #3552: URL: https://github.com/apache/logging-log4j2/pull/3552#discussion_r2003871677 ## .asf.yaml: ## @@ -37,6 +37,7 @@ github: homepage: https://logging.apache.org/log4j/2.x features: issues: true +discussions: true Review Comment: Same PR? I can certainly, yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add example to test transitive compile-time dependencies in Gradle [logging-log4j-samples]
jjohannes commented on code in PR #279: URL: https://github.com/apache/logging-log4j-samples/pull/279#discussion_r2003199821 ## log4j-samples-gradle-metadata/gradlew: ## @@ -0,0 +1,251 @@ +#!/bin/sh Review Comment: Yes, that would be the drawback. Not sure how important that is for these example projects if they are mainly used for integration testing (?). What we can do as compromise is to move the wrapper to the root of the repo. And configure the action to use that. A user would then need to use a relative path `../gradlew` from inside the sample folder. And IntelliJ won't find the wrapper/version when you open one of the sample projects. But that's maybe acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Possible bug in LoggerContext.updateLoggers throwing ConcurrentModificationException [logging-log4j2]
ppkarwasz commented on issue #3551: URL: https://github.com/apache/logging-log4j2/issues/3551#issuecomment-2736807265 Hi @pmk75, This is a duplicate of #3234 and was fixed in release `2.24.3` (see [release notes](https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-24-3)). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
