Re: [I] MdcPatternConverter - update output format for log process tool friendly and smaller size (logging-log4j2)
vy commented on issue #3435: URL: https://github.com/apache/logging-log4j2/issues/3435#issuecomment-2639652617 > When a log string contains `key=value` format, in modern log search tool, like [Splunk](https://www.splunk.com/) or [ELK](https://www.elastic.co/): @amosshi, it sounds counter intuitive to me to serialize the entire log event into one big string instead of using individual fields wherever necessary. As a matter of fact, both ELK (via its [Elastic Common Schema](https://www.elastic.co/guide/en/ecs/current/ecs-reference.html)) and Splunk (in its [logging best-practices page](https://dev.splunk.com/enterprise/docs/developapps/addsupport/logging/loggingbestpractices/#Use-developer-friendly-formats)) recommend using [structured logging](https://logging.apache.org/log4j/2.x/manual/layouts.html#structured-logging), which is best delivered by [JSON Template Layout](https://logging.apache.org/log4j/2.x/manual/json-template-layout.html). Would you mind helping us to understand your motivation from deviating these standards? Could using a structured layout instead of Pattern Layout be an option for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Publish build scans to develocity.apache.org [logging-parent]
vy commented on PR #313: URL: https://github.com/apache/logging-parent/pull/313#issuecomment-2639113171 @ppkarwasz, will do. @gmcdonald, thanks so much for your kind help and patience. I will try to cut a release either today or sometime Saturday. I will also make sure to ping you, so that you can plug off `ge.a.o`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Provide path of expected .config file in error message (logging-log4net)
FreeAndNil closed issue #227: Provide path of expected .config file in error message URL: https://github.com/apache/logging-log4net/issues/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Show config file path in error message (logging-log4net)
FreeAndNil merged PR #228: URL: https://github.com/apache/logging-log4net/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Provide path of expected .config file in error message (logging-log4net)
FreeAndNil closed issue #227: Provide path of expected .config file in error message URL: https://github.com/apache/logging-log4net/issues/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Provide path of application's .config file in error message (logging-log4net)
FrankNuessle opened a new issue, #227: URL: https://github.com/apache/logging-log4net/issues/227 I got the message: "log4net:ERROR Failed to find configuration section 'log4net' in the **application's .config file**. Check your **.config** file for the and elements. The configuration section should look like: \" It would be helpful to have the name + absolute path of **"application's .config file"** which is used by log4net, in the above error message of log4net. Background: When I'm running my unit tests with "dotnet test ..." I got the above error message and I analyzed and wonder, what's wrong with my _AssemblyName.Test.dll.config_. I had to spend some effort and used then `log4net.Util.LogLog.InternalDebugging = true;` to find out, that when running `"dotnet test ..."` for TFM = net8.0, the expected config file was "**testhost.dll.config**"! If this information would be displayed in the above error message, I (and possibly other users) could save a lot of time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Compiling on Module Path with -Werror and -Xlint:all (logging-log4j2)
ppkarwasz commented on issue #3437: URL: https://github.com/apache/logging-log4j2/issues/3437#issuecomment-2640572981 > This would be in line with the `requires static org.jspecify` you already have and it should do no harm. If you agree and if you give me a pointer how this would be added, I can also provide a PR for that. We use the [BND JPMS Libraries](https://bnd.bndtools.org/chapters/330-jpms.html) to generate our `module-info.class`. I am not sure what is the exact logic it applies to annotations to decide whether they are included or not. I suspect that only annotation with a retention of `RUNTIME` are included. Unless I am mistaken, only JSpecify is retained at runtime, so it is the only one in `module-info.class`. IMHO annotations that are not visible at runtime do not need to be mentioned in the `module-info.class`, but the opinion is not universally shared (see [JDK-8342833](https://bugs.openjdk.org/browse/JDK-8342833) for some counter arguments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bug Fix: Script Resolution fix (logging-log4j2)
Suvrat1629 commented on PR #3394: URL: https://github.com/apache/logging-log4j2/pull/3394#issuecomment-2640140229 I am closing this pr, will open a new one when i am done with the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bug Fix: Script Resolution fix (logging-log4j2)
Suvrat1629 closed pull request #3394: Bug Fix: Script Resolution fix URL: https://github.com/apache/logging-log4j2/pull/3394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bug Fix: Script Resolution fix (logging-log4j2)
ppkarwasz commented on PR #3394: URL: https://github.com/apache/logging-log4j2/pull/3394#issuecomment-2640620357 > Could you verify the log4j-script-ref-test.xml? Also I did try writing the test cases my self and I was getting the ScriptManager == null error everytime. How do i handle this? To enable the ScriptManager, you need to set the [`log4j2.scriptEnableLanguages`](https://logging.apache.org/log4j/2.x/manual/systemproperties.html#log4j2.scriptEnableLanguages) to an non empty value. We have a helper to set a Log4j property for a single test: ```java @SetTestProperty(key = "log4j2.scriptEnableLanguages", value = "groovy") @LoggerContextSource("log4j-script-ref-test.xml") class ScriptConfigurationTest { … }; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bug Fix: Script Resolution fix (logging-log4j2)
ppkarwasz commented on PR #3394: URL: https://github.com/apache/logging-log4j2/pull/3394#issuecomment-2640632320 > Could you verify the log4j-script-ref-test.xml? The `log4j-script-ref-test.xml` does not contain any Log4j plugin that uses scripts (see [the list in my comment above](https://github.com/apache/logging-log4j2/pull/3394#pullrequestreview-2555043675), so we can not test if `ScriptRef`s are resolved correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve configuration error handling of HttpAppender (logging-log4j2)
github-actions[bot] commented on PR #3438: URL: https://github.com/apache/logging-log4j2/pull/3438#issuecomment-2640635798 Job Requested goals Build Tool Version Build Outcome Build Scan® build-macos-latest clean install 3.9.8 :x: https://ge.apache.org/s/ktbot7toczf2g"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> build-ubuntu-latest clean install 3.9.8 :x: https://ge.apache.org/s/momfnkm3uxh2s"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> build-windows-latest clean install 3.9.8 :x: https://ge.apache.org/s/242e4yla4pxyo"; rel="nofollow">https://img.shields.io/badge/Build%20Scan%C2%AE-PUBLISHED-06A0CE?logo=Gradle"; alt="Build Scan PUBLISHED" /> ## Generated by gradle/develocity-actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve configuration error handling of HttpAppender (logging-log4j2)
ppkarwasz commented on PR #3438: URL: https://github.com/apache/logging-log4j2/pull/3438#issuecomment-2640956633 There are formatting errors in your PR. Run: ``` ./mvnw spotless:apply ``` to fix them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)
ppkarwasz commented on PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418#issuecomment-2640302141 Thanks, I added it to the backlog #3161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Improve configuration error handling of HttpAppender (logging-log4j2)
Suvrat1629 opened a new pull request, #3438: URL: https://github.com/apache/logging-log4j2/pull/3438 This PR introduces improvements to HttpAppender and adds a new test class, HttpAppenderBuilderTest, to enhance test coverage. The changes include: Updating HttpAppender.java to improve logging behavior. Adding HttpAppenderBuilderTest.java to verify the builder logic for HttpAppender. Ensuring that missing configurations (e.g., URL, Layout) correctly log errors. ## Checklist * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` otherwise * `./mvnw verify` succeeds (if it fails due to code formatting issues reported by Spotless, simply run `./mvnw spotless:apply` and retry) * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` directory * Tests for the changes are provided * [Commits are signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) (optional, but highly recommended) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Prevent timeout fault running JSONLayoutFuzzer [logging-log4cxx]
swebb2066 merged PR #478: URL: https://github.com/apache/logging-log4cxx/pull/478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Provide path of application's .config file in error message (logging-log4net)
FreeAndNil commented on issue #227: URL: https://github.com/apache/logging-log4net/issues/227#issuecomment-2640157697 @FrankNuessle that's a good idea. I will adjust the error message. You can set the assembly for which log4net searches a config file via ```csharp log4net.Util.SystemInfo.EntryAssemblyLocation = typeof(MyTest).Assembly.Location; ``` That will probably fix your real problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Compiling on Module Path with -Werror and -Xlint:all (logging-log4j2)
jjohannes opened a new issue, #3437: URL: https://github.com/apache/logging-log4j2/issues/3437 This is about getting an error like the following when compiling with a `module-info.java` and the compiler flags `-Xlint:all` and `-Werror`: ``` > Compilation failed; see the compiler output below. log4j-api-2.24.3.jar(/org/apache/logging/log4j/message/ParameterizedMessage.class): warning: Cannot find annotation method 'replacement()' in type 'InlineMe': class file for com.google.errorprone.annotations.InlineMe not found log4j-api-2.24.3.jar(/org/apache/logging/log4j/message/ParameterizedMessage.class): warning: Cannot find annotation method 'imports()' in type 'InlineMe' log4j-api-2.24.3.jar(/org/apache/logging/log4j/status/StatusData.class): warning: Cannot find annotation method 'value()' in type 'SuppressFBWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressFBWarnings not found log4j-api-2.24.3.jar(/org/apache/logging/log4j/status/StatusData.class): warning: Cannot find annotation method 'justification()' in type 'SuppressFBWarnings' log4j-api-2.24.3.jar(/org/apache/logging/log4j/util/SystemPropertiesPropertySource.class): warning: Cannot find annotation method 'value()' in type 'ServiceProvider': class file for aQute.bnd.annotation.spi.ServiceProvider not found log4j-api-2.24.3.jar(/org/apache/logging/log4j/util/SystemPropertiesPropertySource.class): warning: Cannot find annotation method 'resolution()' in type 'ServiceProvider' log4j-api-2.24.3.jar(/org/apache/logging/log4j/util/Activator.class): warning: Cannot find annotation method 'value()' in type 'Headers': class file for org.osgi.annotation.bundle.Headers not found log4j-api-2.24.3.jar(/org/apache/logging/log4j/util/Activator.class): warning: Cannot find annotation method 'name()' in type 'Header': class file for org.osgi.annotation.bundle.Header not found log4j-api-2.24.3.jar(/org/apache/logging/log4j/util/Activator.class): warning: Cannot find annotation method 'value()' in type 'Header' log4j-api-2.24.3.jar(/org/apache/logging/log4j/util/Activator.class): warning: Cannot find annotation method 'name()' in type 'Header' log4j-api-2.24.3.jar(/org/apache/logging/log4j/util/Activator.class): warning: Cannot find annotation method 'value()' in type 'Header' error: warnings found and -Werror specified 1 error 11 warnings ``` The error is triggered by using classes from Log4j that use annotations on public members from the annotation libraries indicated in the error message. There are two _layers_ of missing dependencies that cause this: 1. The annotation library's Jar file (e.g. `com.google.errorprone:error_prone_annotations:2.36.0`) is not on the Classpath/Module Path 2. The annotation library's Java Module (e.g. `com.google.errorprone.annotations`) is not defined as `require static` in the corresponding `module-info.class` of Log4j For (1) it's debatable if it can be fixed in a good way, as POM does not have a scope that resembles [Gradle's compileOnlyApi scope](https://www.baeldung.com/gradle-dependency-management#2-types-of-configuration): visible transitively but ONLY on the compile classpath. For (2) you can argue that it is a bug, because if the code of Log4j would be compiled on the Module Path (i.e. with the compiler checking the `module-info.java`) it would not compile. ### Workarounds for users (1) - Adding the missing dependencies directly as `compileOnly` (``) to your own project. - Patching the POM metadata with a rule (possible in Gradle) (2) - Calling the compiler with additional `--add-reads` arguments - Patching the `module-info.class` itself (possible in Gradle with plugin) ### Possible improvements in Log4j (1) This was already discussed [here](https://github.com/apache/logging-log4j2/issues/3110#issuecomment-2423586754). The dependencies marked as `` [here](https://github.com/apache/logging-log4j2/blob/94d3227165f22993c126c9ec19f3ddc03abe967c/log4j-parent/pom.xml#L829-L858) would need to be switched to ``. But that has the unwanted effect that ALL users will get them as unnecessary RUNTIME dependencies. There is the option to publish additional [Gradle Metadata](https://github.com/gradle/gradle/blob/master/platforms/documentation/docs/src/docs/design/gradle-module-metadata-latest-specification.md) that supports the `compileOnlyApi` scope. If you are interested, I can make a contribution for that as I maintain the [Maven plugin for publishing such metadata with Maven](https://github.com/jjohannes/gradle-module-metadata-maven-plugin) (it's used by Jackson for example). But I can understand if you don't want to have additional complexity in your build setup. (2) Maybe you can check if the additional requires could be added to all `module-info`: ``` requires static transitive com.google.errorprone.annotations;
[PR] Show config file path in error message (logging-log4net)
FreeAndNil opened a new pull request, #228: URL: https://github.com/apache/logging-log4net/pull/228 fixes #227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)
vy commented on PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418#issuecomment-2640286754 @ppkarwasz, ported to `2.x`. `main` needs _some_ work, since #3199 needs to be ported too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Compiling on Module Path with -Werror and -Xlint:all (logging-log4j2)
ppkarwasz commented on issue #3437: URL: https://github.com/apache/logging-log4j2/issues/3437#issuecomment-2640456549 @jjohannes, > (1) This was already discussed [here](https://github.com/apache/logging-log4j2/issues/3110#issuecomment-2423586754). The dependencies marked as `` [here](https://github.com/apache/logging-log4j2/blob/94d3227165f22993c126c9ec19f3ddc03abe967c/log4j-parent/pom.xml#L829-L858) would need to be switched to ``. But that has the unwanted effect that ALL users will get them as unnecessary RUNTIME dependencies. There is the option to publish additional [Gradle Metadata](https://github.com/gradle/gradle/blob/master/platforms/documentation/docs/src/docs/design/gradle-module-metadata-latest-specification.md) that supports the `compileOnlyApi` scope. If you are interested, I can make a contribution for that as I maintain the [Maven plugin for publishing such metadata with Maven](https://github.com/jjohannes/gradle-module-metadata-maven-plugin) (it's used by Jackson for example). But I can understand if you don't want to have additional complexity in your build setup. Please submit a PR, 🥺 . I found out about your `gradle-module-metadata-maven-plugin` a couple of weeks ago, but I didn't have the time to check how it works. > (2) Maybe you can check if the additional requires could be added to all `module-info`: > > ``` > requires static transitive com.google.errorprone.annotations; > requires static transitive com.github.spotbugs.annotations; > requires static transitive biz.aQute.bnd.annotation; > requires static transitive org.osgi.annotation.bundle; > ``` > > *`requires static` works also, but conceptually `requires static transitive` feels more correct as the annotations are transitively visible. A `requires static transitive` statement has some unwanted effects. When you compile using the module path, JPMS recursively enumerates all the modules marked as `transitive` and fails if one is missing. After your changes Gradle users will not be affected by this problem, but Maven users will. See #2929 for example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bug Fix: Script Resolution fix (logging-log4j2)
Suvrat1629 commented on PR #3394: URL: https://github.com/apache/logging-log4j2/pull/3394#issuecomment-2640475379 Could you verify the log4j-script-ref-test.xml? Also I did try writing the test cases my self and I was getting the ScriptManager == null error everytime. How do i handle this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Compiling on Module Path with -Werror and -Xlint:all (logging-log4j2)
jjohannes commented on issue #3437: URL: https://github.com/apache/logging-log4j2/issues/3437#issuecomment-2640495652 Thanks for the quick response @ppkarwasz. I'll prepare a PR for the Gradle Metadata in the next days. > A `requires static transitive` statement has some unwanted effects. Ah yes. I did not think about that. Luckily, if you would add them as `requires static` it is stille enough for the lint check to work (see my reproducer): ``` requires static com.google.errorprone.annotations; requires static com.github.spotbugs.annotations; requires static biz.aQute.bnd.annotation; requires static org.osgi.annotation.bundle; ``` This would be in line with the `requires static org.jspecify` you already have and it should do no harm. If you agree and if you give me a pointer how this would be added, I can also provide a PR for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)
vy merged PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Suspect deadlock in InternalLoggerRegistry (intermittent) (logging-log4j2)
vy closed issue #3399: Suspect deadlock in InternalLoggerRegistry (intermittent) URL: https://github.com/apache/logging-log4j2/issues/3399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Suspect deadlock in InternalLoggerRegistry (intermittent) (logging-log4j2)
vy commented on issue #3399: URL: https://github.com/apache/logging-log4j2/issues/3399#issuecomment-2639959104 Fixed by #3418. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bug Fix: Script Resolution fix (logging-log4j2)
ppkarwasz commented on PR #3394: URL: https://github.com/apache/logging-log4j2/pull/3394#issuecomment-2640358227 @Suvrat1629, I would prefer if you keep this PR open. Due to FOSDEM, I didn't have time to look at this PR, but it is going in the right direction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Minimize lock usage in `InternalLoggerRegistry` (logging-log4j2)
ppkarwasz commented on PR #3418: URL: https://github.com/apache/logging-log4j2/pull/3418#issuecomment-2640091554 @vy, Thanks for merging this. Could you cherry-pick it to `2.x` and `main` too? :pleading_face: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org