ppkarwasz commented on issue #3437: URL: https://github.com/apache/logging-log4j2/issues/3437#issuecomment-2640572981
> This would be in line with the `requires static org.jspecify` you already have and it should do no harm. If you agree and if you give me a pointer how this would be added, I can also provide a PR for that. We use the [BND JPMS Libraries](https://bnd.bndtools.org/chapters/330-jpms.html) to generate our `module-info.class`. I am not sure what is the exact logic it applies to annotations to decide whether they are included or not. I suspect that only annotation with a retention of `RUNTIME` are included. Unless I am mistaken, only JSpecify is retained at runtime, so it is the only one in `module-info.class`. IMHO annotations that are not visible at runtime do not need to be mentioned in the `module-info.class`, but the opinion is not universally shared (see [JDK-8342833](https://bugs.openjdk.org/browse/JDK-8342833) for some counter arguments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
