[llvm-branch-commits] [llvm] release/18.x: [MIPS] Fix the opcode of max.fmt and mina.fmt (#85609) (PR #88337)

2024-04-16 Thread YunQiang Su via llvm-branch-commits

wzssyqa wrote:

Sure. Please go ahead.

https://github.com/llvm/llvm-project/pull/88337
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] release/18.x: [MIPS] Fix the opcode of max.fmt and mina.fmt (#85609) (PR #88337)

2024-04-16 Thread YunQiang Su via llvm-branch-commits

https://github.com/wzssyqa approved this pull request.


https://github.com/llvm/llvm-project/pull/88337
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] release/19.x: [MIPS] Optimize sortRelocs for o32 (PR #106008)

2024-09-02 Thread YunQiang Su via llvm-branch-commits

wzssyqa wrote:

I don't think that it is a bugfix, thus not need to be backported.

https://github.com/llvm/llvm-project/pull/106008
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [llvm] release/19.x: [MIPS] Optimize sortRelocs for o32 (PR #106008)

2024-09-03 Thread YunQiang Su via llvm-branch-commits

wzssyqa wrote:

> Definitely agree it's not a regression, but I think I would quibble a bit 
> with the idea that taking ~1h6min to compile something that normally takes 
> ~3min is not a bug in some sense. 🙂
> 

If so, then I think that it is a real bug ;)

> But ok, philosophical debates aside: Would it be reasonable to at least 
> consider it a [critical performance issue for the purposes of a bug fix 
> release](https://github.com/llvm/llvm-project/blob/main/llvm/docs/HowToReleaseLLVM.rst#release-patch-rules)?
>  I acknowledge that there'd still need to be an assessment as to whether the 
> patch is safe, but it _seems_ like it should at least fit one of the criteria 
> on its face. In regards to safety, perhaps confidence in the patch would 
> increase in the time between 19.1.0-final and the subsequent bug fix releases?



https://github.com/llvm/llvm-project/pull/106008
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits