[Lldb-commits] [PATCH] D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed

[Stephen Hines via Phabricator via lldb-commits]

srhines added a comment.

In D128453#3607129 , @labath wrote:

> In D128453#3606296 , @JDevlieghere 
> wrote:
>
>> This is great, it both guarantees consistently and enforces command objects 
>> registering their arguments. LGTM.
>>
>> For the RenderScript plugin, I remember this at an LLVM social when @labath 
>> was in town. At the time, we were very close to being able to get rid of it, 
>> which is now several years ago. Pavel, do you remember who we spoke to and 
>> if we've reached the point where this can go away?
>
> I don't know what's the state of renderscript, but I think @srhines is the 
> person you have in mind.

The RS-related changes here look fine for now. I'm trying to get confirmation 
on whether we can remove it entirely at this point (but you shouldn't do that 
in this patch anyways).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128453/new/

https://reviews.llvm.org/D128453

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

[Stephen Hines via Phabricator via lldb-commits]

srhines added a comment.

We had some internal Google folks hit this exact issue recently. I don't think 
that the same "default" CPU should be used for debugging tools like 
`llvm-objdump`, and that is the crux of the matter here. Perhaps updating the 
test to specify "generic" as the CPU when passed to `llvm-objdump` for those 
tests is the right pattern? Then the default for disassembly should be to have 
all attributes/features enabled unless the developer specifies on the command 
line that they want a different target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127741/new/

https://reviews.llvm.org/D127741

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D132514: [lldb] Remove obsolete Android-specific definitions

[Stephen Hines via Phabricator via lldb-commits]

srhines accepted this revision.
srhines added a comment.

Thanks for cleaning this up!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132514/new/

https://reviews.llvm.org/D132514

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D142309: [LLDB][NFC] Fix a incorrect use of shared_ptr in RenderScriptRuntime.cpp

[Stephen Hines via Phabricator via lldb-commits]

srhines added a comment.

In D142309#4107170 , @xgupta wrote:

> In D142309#4102284 , @labath wrote:
>
>> In D142309#4075745 , @JDevlieghere 
>> wrote:
>>
>>> LGTM, but I wonder when we'll be able to get rid of RenderScript completely 
>>> (CC @labath)
>>
>> I am not going to stand in your way. I usually redirect these questions to 
>> @srhines, but I understand he's moved on to other things as well.
>
> Thanks, no problem.

RenderScript support can be removed. I don't necessarily have the bandwidth to 
do it immediately, but if someone wants to clean that up, I'd help with 
reviewing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142309/new/

https://reviews.llvm.org/D142309

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

[Stephen Hines via Phabricator via lldb-commits]

srhines accepted this revision.
srhines added a comment.

Per https://developer.android.com/guide/topics/renderscript/migrate, we are 
starting to turn things down as part of the deprecation. I reached out 
internally to the folks helping with that to make sure that we don't cause 
problems by deleting upstream code. I suspect that we'll be able to make more 
progress with adapting upstream soon. In the meantime, this CL is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114111/new/

https://reviews.llvm.org/D114111

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

[Stephen Hines via Phabricator via lldb-commits]

srhines added inline comments.



Comment at: lldb/include/lldb/Host/windows/PosixApi.h:56
 #endif
 #endif // __MINGW32__
 

Update comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65822/new/

https://reviews.llvm.org/D65822



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D64118: [lldb_test_suite] Fix lldb test suite targeting remote Android

[Stephen Hines via Phabricator via lldb-commits]

srhines added inline comments.



Comment at: lldb/packages/Python/lldbsuite/test/make/Android.rules:93
-L$(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH) \
-   
$(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH)/libc++.a
+   
$(NDK_ROOT)/sources/cxx-stl/llvm-libc++/libs/$(STL_ARCH)/libc++_static.a \
+   -lc++abi

This line could just be -lc++_static now for more simplicity (much like the 
next line).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64118/new/

https://reviews.llvm.org/D64118



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits