srhines added a comment. In D128453#3607129 <https://reviews.llvm.org/D128453#3607129>, @labath wrote:
> In D128453#3606296 <https://reviews.llvm.org/D128453#3606296>, @JDevlieghere > wrote: > >> This is great, it both guarantees consistently and enforces command objects >> registering their arguments. LGTM. >> >> For the RenderScript plugin, I remember this at an LLVM social when @labath >> was in town. At the time, we were very close to being able to get rid of it, >> which is now several years ago. Pavel, do you remember who we spoke to and >> if we've reached the point where this can go away? > > I don't know what's the state of renderscript, but I think @srhines is the > person you have in mind. The RS-related changes here look fine for now. I'm trying to get confirmation on whether we can remove it entirely at this point (but you shouldn't do that in this patch anyways). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128453/new/ https://reviews.llvm.org/D128453 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
