[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)
ktraunmueller wrote: Just out of curiosity: I was also surprised by the precondition, which looks unnecessary and, more importantly, very unexpected, to me. How would a caller know (from looking at the API) that passing a non-empty string would be fatal? If there's a preconditions in the code, I would expect it to be reflected in the documentation. But since there's no documentation (also unexpected), does that mean that every method needs to be carefully checked for assertions before using it? https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)
ktraunmueller wrote: Famous last words, haha https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)
ktraunmueller wrote: Thank you! FYI, I created a [bug report](https://github.com/llvm/llvm-project/issues/133904) (which can now be closed) for this problem, but forgot to add that information to the Swift forum post, sorry for that. https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] [lldb] Clear thread name container before writing UTF8 bytes (PR #134150)
ktraunmueller wrote: @compnerd weighed in that assertions [are always there for a reason](https://github.com/swiftlang/llvm-project/issues/10269#issuecomment-2772945096), and I would generally agree on that 100%, but this precondition just doesn't seem to make sense, so I would agree that removing it would seem preferrable in this particular case. I can't see how that would create harm. https://github.com/llvm/llvm-project/pull/134150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
