ktraunmueller wrote: Just out of curiosity: I was also surprised by the precondition, which looks unnecessary and, more importantly, very unexpected, to me.
How would a caller know (from looking at the API) that passing a non-empty string would be fatal? If there's a preconditions in the code, I would expect it to be reflected in the documentation. But since there's no documentation (also unexpected), does that mean that every method needs to be carefully checked for assertions before using it? https://github.com/llvm/llvm-project/pull/134150 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
