date:20230919

[Lldb-commits] [lldb] [InstCombine] Canonicalize `and(zext(A), B)` into `select A, B & 1, 0` (PR #66740)

2023-09-19 Thread Yingwei Zheng via lldb-commits

dtcxzyw wrote:

> We should use rebase instead of merge. And I recommend force push to change 
> the code before the review starts.

I am confused with the LLVM GitHub user guide. I witnessed someone mess up by 
doing rebase + force push.
Examples: #65853 #65543 #65535

https://github.com/llvm/llvm-project/pull/66740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ca723f2 - [lldb][Docs] Document our major differences from the LLVM style (#66345)

2023-09-19 Thread via lldb-commits


Author: David Spickett
Date: 2023-09-19T08:23:00+01:00
New Revision: ca723f2d40baf6c84e4c0907040e0c3f226d6302

URL: 
https://github.com/llvm/llvm-project/commit/ca723f2d40baf6c84e4c0907040e0c3f226d6302
DIFF: 
https://github.com/llvm/llvm-project/commit/ca723f2d40baf6c84e4c0907040e0c3f226d6302.diff

LOG: [lldb][Docs] Document our major differences from the LLVM style (#66345)

Running:
$ clang-format -i $(find -regex "\./lldb/.*\.c") $(find -regex
"\./lldb/.*\.cpp") $(find -regex "\./lldb/.*\.h")

Resulted in:
 1602 files changed, 25090 insertions(+), 25849 deletions(-)
(note: this includes tests which we wouldn't format, just using this as
an example)

The vast majority of which were whitespace changes. So as far as
formatting we're not deviating from llvm for any reason other than not
churning old code.

Formatting aside, the major features of lldb (single line if, early
return) are all reflected in llvm's style. We differ mainly on variable
naming (proposed to change in
https://llvm.org/docs/Proposals/VariableNames.html anyway) and use of
asserts. Which was already documented.

Added: 


Modified: 
lldb/docs/resources/contributing.rst

Removed: 




diff  --git a/lldb/docs/resources/contributing.rst 
b/lldb/docs/resources/contributing.rst
index 54917f1ce8175b3..5ac4afb82a0747a 100644
--- a/lldb/docs/resources/contributing.rst
+++ b/lldb/docs/resources/contributing.rst
@@ -18,19 +18,45 @@ Please refer to the `LLVM Developer Policy
 authoring and uploading a patch. LLDB 
diff ers from the LLVM Developer
 Policy in the following respects.
 
- - **Test infrastructure**: Like LLVM it is  important to submit tests with 
your
-   patches, but note that LLDB uses a 
diff erent system for tests. Refer to the
-   `test documentation `_ for more details and the ``lldb/test``
-   folder on disk for examples.
-
- - **Coding Style**: LLDB's code style 
diff ers from
-   `LLVM's coding style `_.
-   Unfortunately there is no document describing the 
diff erences. Please be
-   consistent with the existing code.
-
 For anything not explicitly listed here, assume that LLDB follows the LLVM
 policy.
 
+Coding Style
+
+
+LLDB's code style 
diff ers from `LLVM's coding style 
`_
+in a few ways. The 2 main ones are:
+
+* `Variable and function naming 
`_:
+
+  * Variables are ``snake_case``.
+
+  * Functions and methods are ``UpperCamelCase``.
+
+  * Static, global and member variables have ``s_``, ``g_`` and ``_m``
+prefixes respectively.
+
+* `Use of asserts 
`_:
+  See the :ref:`section below`.
+
+For any other contradications, consider the
+`golden rule `_
+before choosing to update the style of existing code.
+
+All new code in LLDB should be formatted with clang-format. Existing code may
+not conform and should be updated prior to being modified. Bulk reformatting
+is discouraged.
+
+Test Infrastructure

+
+Like LLVM it is important to submit tests with your patches, but note that  a
+subset of LLDB tests (the API tests) use a 
diff erent system. Refer to the
+`test documentation `_ for more details and the
+`lldb/test `_ folder
+for examples.
+
+.. _Error handling:
 
 Error handling and use of assertions in LLDB
 
@@ -42,14 +68,13 @@ be extra thoughtful about how to handle errors. Below are a 
couple
 rules of thumb:
 
 * Invalid input.  To deal with invalid input, such as malformed DWARF,
-  missing object files, or otherwise inconsistent debug info, LLVM's
+  missing object files, or otherwise inconsistent debug info,
   error handling types such as `llvm::Expected
   `_ or
-  `std::optional
-  `_ should be
-  used. Functions that may fail should return their result using these
-  wrapper types instead of using a bool to indicate success. Returning
-  a default value when an error occurred is also discouraged.
+  ``std::optional`` should be used. Functions that may fail
+  should return their result using these wrapper types instead of
+  using a bool to indicate success. Returning a default value when an
+  error occurred is also discouraged.
 
 * Assertions.  Assertions (from ``assert.h``) should be used liberally
   to assert internal consistency.  Assertions shall **never** be
@@ -71,16 +96,18 @@ rules of thumb:
   behaves like ``assert()``. When asserts are disabled, it will print a
   warning and encourage the user to file a bug report, similar to
   LLVM's crash handler, and the

[Lldb-commits] [lldb] [lldb][Docs] Document our major differences from the LLVM style (PR #66345)

2023-09-19 Thread David Spickett via lldb-commits


https://github.com/DavidSpickett closed 
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

2023-09-19 Thread Muhammad Omair Javaid via Phabricator via lldb-commits

omjavaid added inline comments.



Comment at: 
lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201
+self.runCmd("register write za '{}'".format(za_value))
+self.expect("register read za", substrs=[za_value])

How can we differentiate between disabled ZA (read as all zeros) and enabled ZA 
actually set to all zeros?



Comment at: 
lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py:104
+if mode == Mode.SSVE:
+cflags += " -DUSE_SSVE"
+self.build(dictionary={"CFLAGS_EXTRAS": cflags})

is there a reference somewhere in clang or gcc documentation for USE_SSVE flag?



Comment at: 
lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/Makefile:3
+
+CFLAGS_EXTRAS := -march=armv8-a+sve+sme -lpthread
+

is USE_SSVE a subset of sve+sme? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159505/new/

https://reviews.llvm.org/D159505

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

2023-09-19 Thread David Spickett via lldb-commits


DavidSpickett wrote:

This is failing on Arm 32 bit 
(https://lab.llvm.org/buildbot/#/builders/17/builds/43300), I'll reproduce and 
fix it. I expect it just needs to expect 8 hex characters instead of 16.

https://github.com/llvm/llvm-project/pull/66548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

2023-09-19 Thread David Spickett via Phabricator via lldb-commits

DavidSpickett added inline comments.

Comment at:
lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201
+self.runCmd("register write za '{}'".format(za_value))
+self.expect("register read za", substrs=[za_value])

omjavaid wrote:
> How can we differentiate between disabled ZA (read as all zeros) and enabled
> ZA actually set to all zeros?
In this specific test we write a non-zero value to avoid that issue, but I
assume you mean generally.

The user should refer to the SVCR register, SVCR.ZA specifically, to know if
the value they're seeing is the active ZA or not. You can see an example of
that if you look at the changes to this file in
https://reviews.llvm.org/D154927.

Again, the user has to know what bit to look for but I'll eventually address
that with the register fields work.

Comment at:
lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/Makefile:3
+
+CFLAGS_EXTRAS := -march=armv8-a+sve+sme -lpthread
+

omjavaid wrote:
> is USE_SSVE a subset of sve+sme?
It's a define I made up for the purposes of the test, it's in the existing
tests but not well documented. I'll push something to address that in the
existing tests and check the new ones here for this and other defines I've
added.

72 matches

Mail list logo