[Lldb-commits] [PATCH] D39680: "Fix" concurrent events test for arm
labath created this revision. Herald added subscribers: kristof.beyls, aemerson. The test incremented an atomic varible to trigger the watchpoint event. On arm64 this compiled to a ldaxr/stlxr loop, with the watchpoint being triggered in the middle of the loop. Hitting the watchpoint resets the exclusive monitor, and forces the process to loop one more time, hitting the watchpoint again, etc. While it would be nice if the debugger was able to resume from this situation, this is not trivial, and is not what this test is about. Therefore, I propose to change this to a simple store to a normal variable (which should still trip the watchpoint everywhere, but without atomic loops) and file a bug to investigate the possibilities of handling the watchpoints in atomic loops in a more reasonable way. https://reviews.llvm.org/D39680 Files: packages/Python/lldbsuite/test/decorators.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/breakpoints_delayed_breakpoint_one_watchpoint/TestConcurrentBreakpointsDelayedBreakpointOneWatchpoint.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/crash_with_watchpoint/TestConcurrentCrashWithWatchpoint.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/crash_with_watchpoint_breakpoint_signal/TestConcurrentCrashWithWatchpointBreakpointSignal.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/delay_signal_watch/TestConcurrentDelaySignalWatch.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/delay_watch_break/TestConcurrentDelayWatchBreak.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/delayed_crash_with_breakpoint_watchpoint/TestConcurrentDelayedCrashWithBreakpointWatchpoint.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/main.cpp packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/n_watch_n_break/TestConcurrentNWatchNBreak.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/signal_delay_watch/TestConcurrentSignalDelayWatch.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/signal_n_watch_n_break/TestConcurrentSignalNWatchNBreak.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/signal_watch/TestConcurrentSignalWatch.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/signal_watch_break/TestConcurrentSignalWatchBreak.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/two_breakpoints_one_watchpoint/TestConcurrentTwoBreakpointsOneWatchpoint.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/two_watchpoint_threads/TestConcurrentTwoWatchpointThreads.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/two_watchpoints_one_breakpoint/TestConcurrentTwoWatchpointsOneBreakpoint.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/two_watchpoints_one_delay_breakpoint/TestConcurrentTwoWatchpointsOneDelayBreakpoint.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/two_watchpoints_one_signal/TestConcurrentTwoWatchpointsOneSignal.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watch_break/TestConcurrentWatchBreak.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watch_break_delay/TestConcurrentWatchBreakDelay.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watchpoint_delay_watchpoint_one_breakpoint/TestConcurrentWatchpointDelayWatchpointOneBreakpoint.py packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watchpoint_with_delay_watchpoint_threads/TestConcurrentWatchpointWithDelayWatchpointThreads.py Index: packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watchpoint_with_delay_watchpoint_threads/TestConcurrentWatchpointWithDelayWatchpointThreads.py === --- packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watchpoint_with_delay_watchpoint_threads/TestConcurrentWatchpointWithDelayWatchpointThreads.py +++ packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watchpoint_with_delay_watchpoint_threads/TestConcurrentWatchpointWithDelayWatchpointThreads.py @@ -13,7 +13,6 @@ mydir = ConcurrentEventsBase.compute_mydir(__file__) @skipIfFreeBSD # timing out on buildbot -@skipIfRemoteDueToDeadlock # Atomic sequences are not supported yet for MIPS in LLDB. @skipIf(triple='^mips') @add_test_categories(["watchpoint"]) Index: packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/watchpoint_delay_watchpoint_one_breakpoint/TestConcurrentWatchpointDelayWatchpointOneBreakpoint.py === --- packages/Python/lldbsuite/test/fu
[Lldb-commits] [lldb] r317474 - Extend android xfail in TestTopLevelExprs
Author: labath
Date: Mon Nov 6 04:34:27 2017
New Revision: 317474
URL: http://llvm.org/viewvc/llvm-project?rev=317474&view=rev
Log:
Extend android xfail in TestTopLevelExprs
The test fails on API level 19 as well. I'm going to assume that it
fails on every API level below 23.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExprs.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExprs.py
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExprs.py?rev=317474&r1=317473&r2=317474&view=diff
==
---
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExprs.py
(original)
+++
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopLevelExprs.py
Mon Nov 6 04:34:27 2017
@@ -57,7 +57,7 @@ class TopLevelExpressionsTestCase(TestBa
self.runCmd("run", RUN_SUCCEEDED)
@add_test_categories(['pyapi'])
-@expectedFailureAndroid(api_levels=[21, 22], bugnumber="llvm.org/pr27787")
+@expectedFailureAndroid(api_levels=list(range(22+1)),
bugnumber="llvm.org/pr27787")
@expectedFailureAll(
oslist=["linux"],
archs=[
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le
alexandreyy created this revision.
Herald added subscribers: kbarton, mgorny, nemanjai.
Implement core dump debugging for PPC64le.
https://reviews.llvm.org/D39681
Files:
source/Plugins/Process/Utility/CMakeLists.txt
source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.cpp
source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h
source/Plugins/Process/elf-core/CMakeLists.txt
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/RegisterContextPOSIXCore_ppc64le.cpp
source/Plugins/Process/elf-core/RegisterContextPOSIXCore_ppc64le.h
source/Plugins/Process/elf-core/ThreadElfCore.cpp
source/Plugins/Process/elf-core/ThreadElfCore.h
Index: source/Plugins/Process/elf-core/ThreadElfCore.h
===
--- source/Plugins/Process/elf-core/ThreadElfCore.h
+++ source/Plugins/Process/elf-core/ThreadElfCore.h
@@ -131,6 +131,7 @@
lldb_private::DataExtractor gpregset;
lldb_private::DataExtractor fpregset;
lldb_private::DataExtractor vregset;
+ lldb_private::DataExtractor vsregset; /* For PPC VSX registers. */
lldb::tid_t tid;
int signo = 0;
int prstatus_sig = 0;
@@ -179,6 +180,7 @@
lldb_private::DataExtractor m_gpregset_data;
lldb_private::DataExtractor m_fpregset_data;
lldb_private::DataExtractor m_vregset_data;
+ lldb_private::DataExtractor m_vsregset_data; /* For PPC VSX registers. */
bool CalculateStopInfo() override;
};
Index: source/Plugins/Process/elf-core/ThreadElfCore.cpp
===
--- source/Plugins/Process/elf-core/ThreadElfCore.cpp
+++ source/Plugins/Process/elf-core/ThreadElfCore.cpp
@@ -28,13 +28,15 @@
#include "Plugins/Process/Utility/RegisterContextOpenBSD_x86_64.h"
#include "Plugins/Process/Utility/RegisterInfoPOSIX_arm.h"
#include "Plugins/Process/Utility/RegisterInfoPOSIX_arm64.h"
+#include "Plugins/Process/Utility/RegisterInfoPOSIX_ppc64le.h"
#include "ProcessElfCore.h"
#include "RegisterContextPOSIXCore_arm.h"
#include "RegisterContextPOSIXCore_arm64.h"
#include "RegisterContextPOSIXCore_mips64.h"
#include "RegisterContextPOSIXCore_powerpc.h"
#include "RegisterContextPOSIXCore_s390x.h"
#include "RegisterContextPOSIXCore_x86_64.h"
+#include "RegisterContextPOSIXCore_ppc64le.h"
#include "ThreadElfCore.h"
using namespace lldb;
@@ -46,7 +48,8 @@
ThreadElfCore::ThreadElfCore(Process &process, const ThreadData &td)
: Thread(process, td.tid), m_thread_name(td.name), m_thread_reg_ctx_sp(),
m_signo(td.signo), m_gpregset_data(td.gpregset),
- m_fpregset_data(td.fpregset), m_vregset_data(td.vregset) {}
+ m_fpregset_data(td.fpregset), m_vregset_data(td.vregset),
+ m_vsregset_data(td.vsregset) {}
ThreadElfCore::~ThreadElfCore() { DestroyThread(); }
@@ -142,6 +145,9 @@
case llvm::Triple::mips64:
reg_interface = new RegisterContextLinux_mips64(arch);
break;
+ case llvm::Triple::ppc64le:
+reg_interface = new RegisterInfoPOSIX_ppc64le(arch);
+break;
case llvm::Triple::systemz:
reg_interface = new RegisterContextLinux_s390x(arch);
break;
@@ -213,6 +219,11 @@
*this, reg_interface, m_gpregset_data, m_fpregset_data,
m_vregset_data));
break;
+case llvm::Triple::ppc64le:
+ m_thread_reg_ctx_sp.reset(new RegisterContextCorePOSIX_ppc64le(
+ *this, reg_interface, m_gpregset_data, m_fpregset_data,
+ m_vregset_data, m_vsregset_data));
+ break;
case llvm::Triple::systemz:
m_thread_reg_ctx_sp.reset(new RegisterContextCorePOSIX_s390x(
*this, reg_interface, m_gpregset_data, m_fpregset_data));
@@ -265,6 +276,7 @@
switch (arch.GetCore()) {
case lldb_private::ArchSpec::eCore_s390x_generic:
case lldb_private::ArchSpec::eCore_x86_64_x86_64:
+ case lldb_private::ArchSpec::eCore_ppc64le_generic:
return sizeof(ELFLinuxPrStatus);
case lldb_private::ArchSpec::eCore_x86_32_i386:
case lldb_private::ArchSpec::eCore_x86_32_i486:
Index: source/Plugins/Process/elf-core/RegisterContextPOSIXCore_ppc64le.h
===
--- /dev/null
+++ source/Plugins/Process/elf-core/RegisterContextPOSIXCore_ppc64le.h
@@ -0,0 +1,54 @@
+//===-- RegisterContextPOSIXCore_ppc64le.h --*- C++ -*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===--===//
+
+#ifndef liblldb_RegisterContextCorePOSIX_ppc64le_h_
+#define liblldb_RegisterContextCorePOSIX_ppc64le_h_
+
+// C Includes
+// C++ Includes
+// Other libraries and framework includes
+// Project includes
+#include "Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h"
+#include "lldb/Utility/DataExtractor.h"
+
+cl
[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le
labath added a comment.
We were quite successful in the past in creating tiny core files to test these
register contexts. Could you take a look at
`test/testcases/functionalities/postmortem/elf-core/make-core.sh` to see if you
can do the same for your architecture?
Comment at: source/Plugins/Process/Utility/RegisterContextPOSIX_ppc64le.h:23
+
+class ProcessMonitor;
+class RegisterContextPOSIX_ppc64le : public lldb_private::RegisterContext {
delete this ?
Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:183
lldb_private::DataExtractor m_vregset_data;
+ lldb_private::DataExtractor m_vsregset_data; /* For PPC VSX registers. */
gpregset and fpregset sound fairly generic, but these other two sound really
architecture specific. Since ThreadElfCore does not really do anything with
these, just pass them to the register context, I'm thinking that we could just
have a map of all register sets (something like `DenseMap`). Then we can just pass that to the register context
constructor, and let it figure out what to do with it. What do you think?
https://reviews.llvm.org/D39681
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
davide added a subscriber: zturner. davide added a comment. Not sure lld is the default? I think I always build with bfd (or gold). I'll check later today when I'm in the office. I'm not against this change per se, but adding another dependency seems annoying. cc: @zturner https://reviews.llvm.org/D39689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
This is definitely required, but only on windows. I’d put it behind a check for Windows, and I’d also add a check to print a warning/error if (TARGET lld) returns false on windows On Mon, Nov 6, 2017 at 9:22 AM Davide Italiano via Phabricator < revi...@reviews.llvm.org> wrote: > davide added a subscriber: zturner. > davide added a comment. > > Not sure lld is the default? I think I always build with bfd (or gold). > I'll check later today when I'm in the office. I'm not against this change > per se, but adding another dependency seems annoying. cc: @zturner > > > https://reviews.llvm.org/D39689 > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
sas added a comment. @davide: I agree, the extra dependency is annoying. FWIW, I was trying to run tests on Windows and nothing worked because lld wasn't built. Maybe the behavior is different on Windows and on other hosts? I just assumed this was the new default because I saw a couple of changes to how tests are run recently. https://reviews.llvm.org/D39689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
Makes sense. I'll update the diff. On Mon, Nov 6, 2017 at 9:28 AM Zachary Turner wrote: > This is definitely required, but only on windows. I’d put it behind a > check for Windows, and I’d also add a check to print a warning/error if > (TARGET lld) returns false on windows > On Mon, Nov 6, 2017 at 9:22 AM Davide Italiano via Phabricator < > revi...@reviews.llvm.org> wrote: > >> davide added a subscriber: zturner. >> davide added a comment. >> >> Not sure lld is the default? I think I always build with bfd (or gold). >> I'll check later today when I'm in the office. I'm not against this >> change per se, but adding another dependency seems annoying. cc: @zturner >> >> >> https://reviews.llvm.org/D39689 >> >> >> >> -- -- Stephane Sezer ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. lld is required for building windows inferiors, but that can't be the case elsewhere (I don't even have lld checked out). It's possible it gets somehow auto-selected by clang when you have lld checked out, but if that's the case than you need to detect it, and enable the dependency only then. https://reviews.llvm.org/D39689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
sas updated this revision to Diff 121750.
sas added a comment.
Check only on Windows.
https://reviews.llvm.org/D39689
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -113,6 +113,13 @@
# to run tests.
if (TARGET clang)
add_dependencies(check-lldb clang)
+ if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+if (TARGET lld)
+ add_dependencies(check-lldb lld)
+else ()
+ message(WARNING "lld required to test LLDB on Windows")
+endif ()
+ endif ()
endif()
add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
Index: test/CMakeLists.txt
===
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -113,6 +113,13 @@
# to run tests.
if (TARGET clang)
add_dependencies(check-lldb clang)
+ if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+if (TARGET lld)
+ add_dependencies(check-lldb lld)
+else ()
+ message(WARNING "lld required to test LLDB on Windows")
+endif ()
+ endif ()
endif()
add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39545: Support scoped enums in the DWARF AST parser
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D39545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39681: Implement core dump debugging for PPC64le
clayborg added inline comments. Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:183 lldb_private::DataExtractor m_vregset_data; + lldb_private::DataExtractor m_vsregset_data; /* For PPC VSX registers. */ labath wrote: > gpregset and fpregset sound fairly generic, but these other two sound really > architecture specific. Since ThreadElfCore does not really do anything with > these, just pass them to the register context, I'm thinking that we could > just have a map of all register sets (something like `DenseMap DataExtractor>`). Then we can just pass that to the register context > constructor, and let it figure out what to do with it. What do you think? That sounds like a good idea to me. https://reviews.llvm.org/D39681 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
clayborg accepted this revision. clayborg added a comment. Do we want to add an option to our build system to try LLD where it is supported? Doesn't need to be part of this patch, but it would be great to be able to try it out on ELF based systems. https://reviews.llvm.org/D39689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
zturner accepted this revision. zturner added inline comments. Comment at: test/CMakeLists.txt:116-122 + if (CMAKE_SYSTEM_NAME MATCHES "Windows") +if (TARGET lld) + add_dependencies(check-lldb lld) +else () + message(WARNING "lld required to test LLDB on Windows") +endif () + endif () I would probably move this outside of the `if (TARGET clang)`. This is minor though, as I can think of ways to break this both with the current patch (inside of the check) as well as outside of the check. https://reviews.llvm.org/D39689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
sas updated this revision to Diff 121760.
sas added a comment.
Move check out of if (TARGET clang) block.
https://reviews.llvm.org/D39689
Files:
test/CMakeLists.txt
Index: test/CMakeLists.txt
===
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -115,6 +115,15 @@
add_dependencies(check-lldb clang)
endif()
+# LLD is required to link test executables on Windows.
+if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+ if (TARGET lld)
+add_dependencies(check-lldb lld)
+ else ()
+message(WARNING "lld required to test LLDB on Windows")
+ endif ()
+endif ()
+
add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
# This will add LLDB's test dependencies to the depenednecies for check-all and
# include them in the test-depends target.
Index: test/CMakeLists.txt
===
--- test/CMakeLists.txt
+++ test/CMakeLists.txt
@@ -115,6 +115,15 @@
add_dependencies(check-lldb clang)
endif()
+# LLD is required to link test executables on Windows.
+if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+ if (TARGET lld)
+add_dependencies(check-lldb lld)
+ else ()
+message(WARNING "lld required to test LLDB on Windows")
+ endif ()
+endif ()
+
add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
# This will add LLDB's test dependencies to the depenednecies for check-all and
# include them in the test-depends target.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r317501 - Add a dependency from check-lldb on lld
Author: sas
Date: Mon Nov 6 11:25:33 2017
New Revision: 317501
URL: http://llvm.org/viewvc/llvm-project?rev=317501&view=rev
Log:
Add a dependency from check-lldb on lld
Summary:
This is required when using the in-tree clang for building tests,
because -fuse-ld=lld is used by default.
Subscribers: mgorny
Differential Revision: https://reviews.llvm.org/D39689
Modified:
lldb/trunk/test/CMakeLists.txt
Modified: lldb/trunk/test/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/test/CMakeLists.txt?rev=317501&r1=317500&r2=317501&view=diff
==
--- lldb/trunk/test/CMakeLists.txt (original)
+++ lldb/trunk/test/CMakeLists.txt Mon Nov 6 11:25:33 2017
@@ -115,6 +115,15 @@ if (TARGET clang)
add_dependencies(check-lldb clang)
endif()
+# LLD is required to link test executables on Windows.
+if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+ if (TARGET lld)
+add_dependencies(check-lldb lld)
+ else ()
+message(WARNING "lld required to test LLDB on Windows")
+ endif ()
+endif ()
+
add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
# This will add LLDB's test dependencies to the depenednecies for check-all and
# include them in the test-depends target.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39689: Add a dependency from check-lldb on lld
This revision was automatically updated to reflect the committed changes.
Closed by commit rL317501: Add a dependency from check-lldb on lld (authored by
sas).
Repository:
rL LLVM
https://reviews.llvm.org/D39689
Files:
lldb/trunk/test/CMakeLists.txt
Index: lldb/trunk/test/CMakeLists.txt
===
--- lldb/trunk/test/CMakeLists.txt
+++ lldb/trunk/test/CMakeLists.txt
@@ -115,6 +115,15 @@
add_dependencies(check-lldb clang)
endif()
+# LLD is required to link test executables on Windows.
+if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+ if (TARGET lld)
+add_dependencies(check-lldb lld)
+ else ()
+message(WARNING "lld required to test LLDB on Windows")
+ endif ()
+endif ()
+
add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
# This will add LLDB's test dependencies to the depenednecies for check-all and
# include them in the test-depends target.
Index: lldb/trunk/test/CMakeLists.txt
===
--- lldb/trunk/test/CMakeLists.txt
+++ lldb/trunk/test/CMakeLists.txt
@@ -115,6 +115,15 @@
add_dependencies(check-lldb clang)
endif()
+# LLD is required to link test executables on Windows.
+if (CMAKE_SYSTEM_NAME MATCHES "Windows")
+ if (TARGET lld)
+add_dependencies(check-lldb lld)
+ else ()
+message(WARNING "lld required to test LLDB on Windows")
+ endif ()
+endif ()
+
add_custom_target(lldb-test-depends DEPENDS ${LLDB_TEST_DEPENDS})
# This will add LLDB's test dependencies to the depenednecies for check-all and
# include them in the test-depends target.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39692: Disable tests in lang/c/shared_lib on Windows
clayborg added a comment. Are we planning on getting shared libraries working on windows? Or this is just an expression parser with shared libraries bug? Be nice to file a bug and mention it if it is something we are planning on fixing. https://reviews.llvm.org/D39692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D39692: Disable tests in lang/c/shared_lib on Windows
It’s been a long time since I looked at this but I remember it just being a problem in the Makefiles, not in LLDB. I could be remembering wrong On Mon, Nov 6, 2017 at 1:44 PM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > Are we planning on getting shared libraries working on windows? Or this is > just an expression parser with shared libraries bug? Be nice to file a bug > and mention it if it is something we are planning on fixing. > > > https://reviews.llvm.org/D39692 > > > > ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Re: [Lldb-commits] [PATCH] D39692: Disable tests in lang/c/shared_lib on Windows
I think @zturner is correct. Shared libraries do work with lldb on Windows, just just that these tests are not buildable for Windows. On Mon, Nov 6, 2017 at 1:56 PM Zachary Turner wrote: > It’s been a long time since I looked at this but I remember it just being > a problem in the Makefiles, not in LLDB. I could be remembering wrong > On Mon, Nov 6, 2017 at 1:44 PM Greg Clayton via Phabricator < > revi...@reviews.llvm.org> wrote: > >> clayborg added a comment. >> >> Are we planning on getting shared libraries working on windows? Or this >> is just an expression parser with shared libraries bug? Be nice to file a >> bug and mention it if it is something we are planning on fixing. >> >> >> https://reviews.llvm.org/D39692 >> >> >> >> -- -- Stephane Sezer ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [lldb] r317529 - Disable tests in lang/c/shared_lib on Windows
Author: sas Date: Mon Nov 6 16:14:40 2017 New Revision: 317529 URL: http://llvm.org/viewvc/llvm-project?rev=317529&view=rev Log: Disable tests in lang/c/shared_lib on Windows Summary: These fail because `-fPIC` is not supported on Windows. Reviewers: zturner, jingham, clayborg Reviewed By: clayborg Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D39692 Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py?rev=317529&r1=317528&r2=317529&view=diff == --- lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py (original) +++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py Mon Nov 6 16:14:40 2017 @@ -5,6 +5,7 @@ from __future__ import print_function import unittest2 import lldb +from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * import lldbsuite.test.lldbutil as lldbutil @@ -34,10 +35,12 @@ class SharedLibTestCase(TestBase): "expression GetMeASubFoo(my_foo_ptr)", startstr="(sub_foo *) $") +@expectedFailureAll(oslist=["windows"]) def test_expr(self): """Test that types work when defined in a shared library and forward-declared in the main executable""" self.common_test_expr(True) +@expectedFailureAll(oslist=["windows"]) def test_expr_no_preload(self): """Test that types work when defined in a shared library and forward-declared in the main executable, but with preloading disabled""" self.common_test_expr(False) ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39692: Disable tests in lang/c/shared_lib on Windows
This revision was automatically updated to reflect the committed changes. Closed by commit rL317529: Disable tests in lang/c/shared_lib on Windows (authored by sas). Repository: rL LLVM https://reviews.llvm.org/D39692 Files: lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py Index: lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py === --- lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py +++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py @@ -5,6 +5,7 @@ import unittest2 import lldb +from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * import lldbsuite.test.lldbutil as lldbutil @@ -34,10 +35,12 @@ "expression GetMeASubFoo(my_foo_ptr)", startstr="(sub_foo *) $") +@expectedFailureAll(oslist=["windows"]) def test_expr(self): """Test that types work when defined in a shared library and forward-declared in the main executable""" self.common_test_expr(True) +@expectedFailureAll(oslist=["windows"]) def test_expr_no_preload(self): """Test that types work when defined in a shared library and forward-declared in the main executable, but with preloading disabled""" self.common_test_expr(False) Index: lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py === --- lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py +++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/shared_lib/TestSharedLib.py @@ -5,6 +5,7 @@ import unittest2 import lldb +from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * import lldbsuite.test.lldbutil as lldbutil @@ -34,10 +35,12 @@ "expression GetMeASubFoo(my_foo_ptr)", startstr="(sub_foo *) $") +@expectedFailureAll(oslist=["windows"]) def test_expr(self): """Test that types work when defined in a shared library and forward-declared in the main executable""" self.common_test_expr(True) +@expectedFailureAll(oslist=["windows"]) def test_expr_no_preload(self): """Test that types work when defined in a shared library and forward-declared in the main executable, but with preloading disabled""" self.common_test_expr(False) ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D39315: Correct the start address for exported windows functions in arm
sas added a comment. Friendly ping. https://reviews.llvm.org/D39315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
