[krita] [Bug 369303] New: Krita fails to build in Debug mode
https://bugs.kde.org/show_bug.cgi?id=369303 Bug ID: 369303 Summary: Krita fails to build in Debug mode Product: krita Version: git master Platform: MS Windows OS: MS Windows Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: krita-bugs-n...@kde.org Reporter: bruceoutdo...@gmail.com In the official build instructions krita is built using "RelWithDebInfo", which is a Release build with debugging information. However release builds optimized out certain values (like QStrings), which can be useful for programmers when using a debugger. The problem is that Krita can build in Release and RelWithDebInfo mode, but fails in Debug mode. That still means Krita can be built and packaged, but that doesn't seem like something that should happen. I have replicated this error about 3 times, and the compile errors consistently points to the VC library (I rebuilt VC and Krita from scratch a few times to confirm): C:/dev/install/lib/libVc.a(const.cpp.obj):const.cpp:(.text+0x0): multiple definition of `Vc1::Common::checkLibraryAbi(unsigned int, unsigned int, char const*)' lib/libkritaimage.dll.a(d008809.o):(.text+0x0): first defined here collect2.exe: error: ld returned 1 exit status Reproducible: Always Steps to Reproduce: 1. When configuring krita, set CMAKE_BUILD_TYPE to "Debug" 2. Build krita. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 369303] Krita fails to build in Debug mode
https://bugs.kde.org/show_bug.cgi?id=369303 --- Comment #2 from Lee Zhen Yong --- Owh... that would probably be the reason why. The error messages aren't very helpful in pointing that out. I know how to change the modes for all 3rd party libraries (setting "GLOBAL_BUILD_TYPE" in 3rdparty/CMakeLists.txt), but Qt and Boost has their own build system. Haven't looked to how to change them yet. If the build mode for 3rd party libraries be the case, then there is no issue and therefore no bug. I have to build to double confirm though. Also, if that be the case, I'd like to work towards making it easier to change the build mode of 3rd party libraries easier. It should be the case that if I set CMAKE_BUILD_TYPE in configuring 3rdparty it should affect all libraries. Should be a simple feature to add I hope. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 369303] Krita fails to build in Debug mode
https://bugs.kde.org/show_bug.cgi?id=369303 --- Comment #3 from Lee Zhen Yong --- _drat. I can't edit comments here..._ I meant to say I can change the build modes for all 3rd party libraries except Qt and Boost. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 369303] Krita fails to build in Debug mode
https://bugs.kde.org/show_bug.cgi?id=369303 --- Comment #6 from Lee Zhen Yong --- Aite. As suggested, for Qt I've modified the CMakeLists.txt to replace "-release" with "-debug" in CONFIGURE_COMMAND /configure.bat. For boost CMakeLists.txt, in "BUILD_COMMAND /b2.exe" change variant from "release" to "debug". I left my laptop to build overnight, and here's the result: Good news first: I managed to build debug versions of Qt and boost. Their *.dll names are different so it's easy to spot whether they are different. Bad news: bug doesn't go away, and it's the same error. On the bright side, the compile error messages are more detailed: C:/dev/install/lib/libVc.a(const.cpp.obj): In function `Vc_1::Common::checkLibraryAbi(unsigned int, unsigned int, char const*)': C:/dev/lib-build/ext_vc/ext_vc-prefix/src/ext_vc/src/const.cpp:281: multiple definition of `Vc_1::Common::checkLibraryAbi(unsigned int, unsigned int, char const*) lib/libkritaimage.dll.a(d008829.o):(.text+0x0): first defined here collect2.exe: error: ld returned 1 exit status [147/1938] Linking CXX shared module bin\krita_shape_text.dll ninja: build stopped: subcommand failed. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 369303] Krita fails to build in Debug mode
https://bugs.kde.org/show_bug.cgi?id=369303 --- Comment #7 from Lee Zhen Yong --- You know what, I should paste the full error message: [142/1938] Linking CXX shared library bin\libkritalibbrush.dll FAILED: bin/libkritalibbrush.dll lib/libkritalibbrush.dll.a cmd.exe /C "cd . && C:\TDM-GCC-64\bin\c++.exe -std=c++0x -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-v irtual-dtor -Woverloaded-virtual -Werror=return-type -fext-numeric-literals -fexceptions -std=c++11 -g -Wl,--no-undefined -Wl,--fatal-warnings -Wl,--export-all-symbo ls -shared -o bin\libkritalibbrush.dll -Wl,--out-implib,lib\libkritalibbrush.dll.a -Wl,--major-image-version,15,--minor-image-version,0 libs/brush/CMakeFiles/kritalibbr ush.dir/kis_predefined_brush_factory.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_auto_brush.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_boundary.cc.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_brush.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_scaling_size_brush.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir /kis_brush_registry.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_brush_server.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_gbr_brush.cpp.obj libs/brush/CM akeFiles/kritalibbrush.dir/kis_abr_brush.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_abr_brush_collection.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_im agepipe_brush.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_pipebrush_parasite.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_png_brush.cpp.obj libs/brush/CM akeFiles/kritalibbrush.dir/kis_svg_brush.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_qimage_pyramid.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_text_bru sh.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_auto_brush_factory.cpp.obj libs/brush/CMakeFiles/kritalibbrush.dir/kis_text_brush_factory.cpp.obj libs/brush/CMak eFiles/kritalibbrush.dir/kritalibbrush_automoc.cpp.obj lib/libkritaimage.dll.a -lws2_32 -lnetapi32 C:/dev/install/lib/libVc.a lib/libkritawidgets.dll.a lib/libkritafla ke.dll.a C:/dev/install/lib/libQt5Svgd.a C:/dev/install/lib/libKF5Completion.dll.a lib/libkritapsd.dll.a lib/libkritaodf.dll.a lib/libkritastore.dll.a lib/libkritaversi on.dll.a C:/dev/install/lib/libKF5Archive.dll.a lib/libkritapigment.dll.a -lws2_32 -lnetapi32 lib/libkritaundo2.dll.a lib/libkritawidgetutils.dll.a lib/libkritaglobal.d ll.a C:/dev/install/lib/libQt5PrintSupportd.a C:/dev/install/lib/libKF5ConfigGui.dll.a C:/dev/install/lib/libKF5GuiAddons.dll.a C:/dev/install/lib/libKF5WidgetsAddons.d ll.a C:/dev/install/lib/libQt5Xmld.a lib/libkritaplugin.dll.a C:/dev/install/lib/libKF5CoreAddons.dll.a C:/dev/install/lib/libKF5ConfigCore.dll.a C:/dev/install/lib/lib KF5I18n.dll.a C:/dev/install/lib/libKF5ItemViews.dll.a C:/dev/install/lib/libQt5Widgetsd.a C:/dev/install/lib/libQt5Guid.a C:/dev/install/lib/libQt5Concurrentd.a C:/dev /install/lib/libQt5Cored.a C:/dev/install/lib/libboost_system-mgw51-mt-d-1_61.dll C:/dev/install/lib/libImath.dll C:/dev/install/lib/libIlmImf.dll C:/dev/install/lib/li bIex.dll C:/dev/install/lib/libHalf.dll C:/dev/install/lib/libIlmThread.dll C:/dev/install/lib/libVc.a -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut 32 -luuid -lcomdlg32 -ladvapi32 && cd ." C:/dev/install/lib/libVc.a(const.cpp.obj): In function `Vc_1::Common::checkLibraryAbi(unsigned int, unsigned int, char const*)': C:/dev/lib-build/ext_vc/ext_vc-prefix/src/ext_vc/src/const.cpp:281: multiple definition of `Vc_1::Common::checkLibraryAbi(unsigned int, unsigned int, char const*)' lib/libkritaimage.dll.a(d008829.o):(.text+0x0): first defined here collect2.exe: error: ld returned 1 exit status -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 369303] Krita fails to build in Debug mode
https://bugs.kde.org/show_bug.cgi?id=369303 --- Comment #10 from Lee Zhen Yong --- => Are you sure you're building everything from scratch? Yep. The install and build folder are emptied out before I rebuild. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 368483] Segfault when creating a new document
https://bugs.kde.org/show_bug.cgi?id=368483 Lee Zhen Yong changed: What|Removed |Added CC||bruceoutdo...@gmail.com --- Comment #1 from Lee Zhen Yong --- I've submitted a patch to fix this: https://phabricator.kde.org/D2721 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 368551] KisScreenColorPicker doesn't update secondary color from KoDualColorButton
https://bugs.kde.org/show_bug.cgi?id=368551 --- Comment #1 from Lee Zhen Yong --- Created attachment 101014 --> https://bugs.kde.org/attachment.cgi?id=101014&action=edit screenshot with pointers -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 368551] KisScreenColorPicker doesn't update secondary color from KoDualColorButton
https://bugs.kde.org/show_bug.cgi?id=368551 Lee Zhen Yong changed: What|Removed |Added URL|https://lh3.googleuserconte | |nt.com/UpZhd6rqYyEUeosUsuEL | |dJwPJJNVSN25BAUHNbJ1BUvOstJ | |KfsgsY3kfpb5wWrjZVht9ULXcuX | |-gUTYYrEdfzfyXF7PFEReZd1wTd | |RM9jitxze75b0VBXi96RNRQk261 | |vv2kSsDDcR0OWTlYGRo765zQTgH | |ETDmVZ9YBOA3C9BM5QNzFLIF3Ae | |4LMbf7q5V562pyr2IW1j4bwsoXs | |OjjEmTZDPvaB4sG7873iLGTQTXt | |wgwRLL7urmKxlWOgEFxpNc7n-Oc | |30W21NXWS2JYv_Xzhp3DR80YVtR | |1CySJ0razAqxs4GTiL2s3WBB0PI | |HJaiE5iYGsxPOJgguRyU27GqSGe | |4lOWNk1MzxEFf31fm1HtvRXkhGQ | |LD4fsg2VkhzuC9HW1HbVdq5kcuu | |Us08XCbqpFdIz4w5Alg-hRKJzW6 | |9EWCg-yQfluxjQ8qz3byC58L4_t | |-cmxueJPkDJ8ojduGwGqkSAp5RG | |BIjHVqvaKYLtnKKbLscQvxIfczs | |pW-Lv0fg-iOeGUckBjD1F6xJwCH | |TAjezKNGPfKTwEdOw_dXwUuKlKc | |QazQkRHawnQT64CcIilcgO2N5lM | |rQDU7AM1chmVuie_gKcrK0mk8pY | |OlgfEMZrfw=w583-h526-no | -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 368551] KisScreenColorPicker doesn't update secondary color from KoDualColorButton
https://bugs.kde.org/show_bug.cgi?id=368551 --- Comment #2 from Lee Zhen Yong --- the same dialog appears when selecting "Image Background Color" when creating new file. Oddly, the color picker doesn't update the color, but the color sampling from screen works. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 368551] New: KisScreenColorPicker doesn't update secondary color from KoDualColorButton
https://bugs.kde.org/show_bug.cgi?id=368551 Bug ID: 368551 Summary: KisScreenColorPicker doesn't update secondary color from KoDualColorButton Product: krita Version: git master Platform: MS Windows URL: https://goo.gl/photos/tUVqzPrwzdqzgBf68 OS: MS Windows Status: UNCONFIRMED Severity: normal Priority: NOR Component: color selectors Assignee: krita-bugs-n...@kde.org Reporter: bruceoutdo...@gmail.com In rKRITA93ef7c8 there's a brand new screen color picker that pops up when you click the buttons in the KoDualColorButton widget. But only the primary color button works. When the secondary color button is click, the same color picker dialog appears, but it doesn't update the secondary color when a new color is picked, and selecting color from the screen won't work (it'll stop you from clicking outside the modal dialog). Reproducible: Always Steps to Reproduce: 1. Click secondary color button in KoDualColorButton widget. 2. Try to pick a color from color wheel or pick a sample a pixel color from screen (teardrop icon) Expected Results: The color picker should update the secondary color in KoDualColorButton widget. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 368551] KisScreenColorPicker doesn't update secondary color from KoDualColorButton
https://bugs.kde.org/show_bug.cgi?id=368551 Lee Zhen Yong changed: What|Removed |Added URL|https://goo.gl/photos/tUVqz |https://lh3.googleuserconte |PrwzdqzgBf68|nt.com/UpZhd6rqYyEUeosUsuEL ||dJwPJJNVSN25BAUHNbJ1BUvOstJ ||KfsgsY3kfpb5wWrjZVht9ULXcuX ||-gUTYYrEdfzfyXF7PFEReZd1wTd ||RM9jitxze75b0VBXi96RNRQk261 ||vv2kSsDDcR0OWTlYGRo765zQTgH ||ETDmVZ9YBOA3C9BM5QNzFLIF3Ae ||4LMbf7q5V562pyr2IW1j4bwsoXs ||OjjEmTZDPvaB4sG7873iLGTQTXt ||wgwRLL7urmKxlWOgEFxpNc7n-Oc ||30W21NXWS2JYv_Xzhp3DR80YVtR ||1CySJ0razAqxs4GTiL2s3WBB0PI ||HJaiE5iYGsxPOJgguRyU27GqSGe ||4lOWNk1MzxEFf31fm1HtvRXkhGQ ||LD4fsg2VkhzuC9HW1HbVdq5kcuu ||Us08XCbqpFdIz4w5Alg-hRKJzW6 ||9EWCg-yQfluxjQ8qz3byC58L4_t ||-cmxueJPkDJ8ojduGwGqkSAp5RG ||BIjHVqvaKYLtnKKbLscQvxIfczs ||pW-Lv0fg-iOeGUckBjD1F6xJwCH ||TAjezKNGPfKTwEdOw_dXwUuKlKc ||QazQkRHawnQT64CcIilcgO2N5lM ||rQDU7AM1chmVuie_gKcrK0mk8pY ||OlgfEMZrfw=w583-h526-no -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 368551] KisScreenColorPicker doesn't update secondary color from KoDualColorButton
https://bugs.kde.org/show_bug.cgi?id=368551 Lee Zhen Yong changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #6 from Lee Zhen Yong --- Cool. That fixes it! "you expect the background color-picker to behave exactly like the foreground one?" Shouldn't it? I'm not so sure. I'm actually pretty new to Krita in addition to the source code. Another stuffs I noticed are minor: - the color picker still updates the color when I choose "cancel". Not sure if that's suppose to happen. - when I select a new color the color picker should show a comparison between the new and old color. The old color will always change to white or black depending whether I am changing the foreground or background. - KoDualColorButton's foreground color updates as the color picker is selecting a new color, but the same doesn't apply for KoDualColorButton's background color. Sorry I'm putting it all in a single comment. Lazy to open another bug report. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 349458] JJ:Add workspaces as submenu in the window menu
https://bugs.kde.org/show_bug.cgi?id=349458 Lee Zhen Yong changed: What|Removed |Added CC||bruceoutdo...@gmail.com --- Comment #2 from Lee Zhen Yong --- WIP: https://phabricator.kde.org/D2809 -- You are receiving this mail because: You are watching all bug changes.
