Re: [PR] Bump org.mockito:mockito-core from 5.17.0 to 5.18.0 [maven-clean-plugin]
slawekjaranowski merged PR #253: URL: https://github.com/apache/maven-clean-plugin/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SUREFIRE-2288] Set version for maven-changes-plugin [maven-surefire]
sparsick opened a new pull request, #846: URL: https://github.com/apache/maven-surefire/pull/846 Add maven-changes-plugin to the plugin management section and set its version explicitly. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] JUnitPlatformProvider reruns successful tests [maven-surefire]
Yahmus opened a new issue, #847:
URL: https://github.com/apache/maven-surefire/issues/847
### Affected version
3.5.2
### Bug description
Hello!
maven.surefire.version - 3.5.2
junit.version - 5.12.2
We were using Junit 4 in our project. Then we decided to move to the Junit 5
version, but there are still many Junit 4 tests in our project. We are using
maven surefire to run tests. Since we've migrated to Junit 5, surefire is using
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider to run tests. It
was org.apache.maven.surefire.junit4.JUnit4Provider
while we were using Junit 4 only.
The thing is - now when I'm running tests with rerunFailingTestsCount
mvn surefire:test -B -Dtest=JUnit4Test -Dsurefire.rerunFailingTestsCount=2
if the whole test class fails (in
[@afterclass](https://github.com/afterclass) for example) - surefire reruns all
test classes, even successful test methods.
With JUnitPlatformProvider:
```
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] JUnit4Test.null
[ERROR] Run 1: JUnit4Test.methodThatFailsWholeClass:35
[ERROR] Run 2: JUnit4Test.methodThatFailsWholeClass:35
[ERROR] Run 3: JUnit4Test.methodThatFailsWholeClass:35
[INFO]
[INFO]
[ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0
```
With JUnit4Provider:
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] JUnit4Test.methodThatFailsWholeClass:35
[INFO]
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0
```
I've prepared sample project where this behaviour can be reproduced -
https://github.com/Yahmus/JunitProviderTest
You can run the test class, check the behaviour, then switch the provider by
adding
```
org.apache.maven.surefire
surefire-junit4
${maven.surefire.version}
```
to maven-surefire-plugin in pom.xml and run the test class again.
I've found a little bit of a similar issue but it doesn't really help
[#4026](https://github.com/junit-team/junit5/discussions/4026)
I don't actually understand. Is this a bug or an expected behaviour?
I've tried to raise the issue in your Jira, but no one accepted my account
creation request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.eclipse.sisu:org.eclipse.sisu.plexus from 0.9.0.M3 to 0.9.0.M4 [maven-ear-plugin]
dependabot[bot] opened a new pull request, #137: URL: https://github.com/apache/maven-ear-plugin/pull/137 Bumps [org.eclipse.sisu:org.eclipse.sisu.plexus](https://github.com/eclipse-sisu/sisu-project) from 0.9.0.M3 to 0.9.0.M4. Release notes Sourced from https://github.com/eclipse-sisu/sisu-project/releases";>org.eclipse.sisu:org.eclipse.sisu.plexus's releases. 0.9.0.M4 Most important change: ASM is "demoted" to plain dependency, hence, consumer is able to override/update it the usual "Maven way". This applies to all components: inject, plexus and sisu-maven-plugin as well. Historically, Sisu shaded in ASM just like Guice did. Later Sisu started shipping "main" JAR with shaded ASM but also "no_asm" classified artifact without ASM (just like Guice did with "classes" classified JAR). Starting from this version, Sisu does not shade ASM anymore, it is "demoted" to transitive dependency. Sisu is built with ASM 9.8. Sisu is compatible with range of Guice [3,7). What's Changed Disable shallow clones for sonarcloud analysis by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/145";>eclipse-sisu/sisu-project#145 Remove spurious asserts by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/147";>eclipse-sisu/sisu-project#147 Post release cleanup by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/146";>eclipse-sisu/sisu-project#146 Fix jacoco + code coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/151";>eclipse-sisu/sisu-project#151 Enable code coverage again for all modules by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/153";>eclipse-sisu/sisu-project#153 Use default property for the jacoco agent by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/154";>eclipse-sisu/sisu-project#154 Add documentation on Plexus Configurator API by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/172";>eclipse-sisu/sisu-project#172 Remove about.html as only relevant for Eclipse plugins by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/171";>eclipse-sisu/sisu-project#171 Document Lifecycle support by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/175";>eclipse-sisu/sisu-project#175 Call TypeAwareExpressionEvaluator.evaluate(String,Class) if available by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/161";>eclipse-sisu/sisu-project#161 Pass strict flag also via "discoverComponents" by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/182";>eclipse-sisu/sisu-project#182 Embed/relocate ASM via m-shade-p by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/185";>eclipse-sisu/sisu-project#185 Update to ASM 9.8 by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/186";>eclipse-sisu/sisu-project#186 Increase coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/192";>eclipse-sisu/sisu-project#192 Align subproject names (and naming) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/191";>eclipse-sisu/sisu-project#191 Build infra updates by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/193";>eclipse-sisu/sisu-project#193 More coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/195";>eclipse-sisu/sisu-project#195 More coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/196";>eclipse-sisu/sisu-project#196 Update source header. by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/194";>eclipse-sisu/sisu-project#194 Update headers (no code change) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/199";>eclipse-sisu/sisu-project#199 Reformat (no code change) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/200";>eclipse-sisu/sisu-project#200 Reproducible by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/202";>eclipse-sisu/sisu-project#202 Fix sisu-maven-plugin by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/203";>eclipse-sisu/sisu-project#203 Lax array conve
Re: [PR] [MNG-8734] Make Maven 3.9.10 ignore --raw-streams option [maven]
cstamas merged PR #2361: URL: https://github.com/apache/maven/pull/2361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8734) Simplify scripting like "get project version" cases
[
https://issues.apache.org/jira/browse/MNG-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8734.
Resolution: Fixed
> Simplify scripting like "get project version" cases
> ---
>
> Key: MNG-8734
> URL: https://issues.apache.org/jira/browse/MNG-8734
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.9.9
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.10
>
>
> Currently there is no way to script "get project version" in universal way
> that would work with Maven3 and Maven4. Assume you need construct like this
> to get project version:
> {noformat}
> version=$(./mvnw -q -DforceStdout --raw-streams help:evaluate -N
> -Dexpression=project.version) {noformat}
> But the problem is that Maven3 belly up on unknown {{--raw-streams}} option.
> Basically we have currently:
> * Maven 3.9.9. belly up on {{--raw-streams}}
> * Maven 4 must have, it otherwise construct will not return what you want
> Proposed solution: make Maven 3.9.10 silently ignore this option.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MNG-8734) Simplify scripting like "get project version" cases
[
https://issues.apache.org/jira/browse/MNG-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-8734:
Assignee: Tamas Cservenak
> Simplify scripting like "get project version" cases
> ---
>
> Key: MNG-8734
> URL: https://issues.apache.org/jira/browse/MNG-8734
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.9.9
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.10
>
>
> Currently there is no way to script "get project version" in universal way
> that would work with Maven3 and Maven4. Assume you need construct like this
> to get project version:
> {noformat}
> version=$(./mvnw -q -DforceStdout --raw-streams help:evaluate -N
> -Dexpression=project.version) {noformat}
> But the problem is that Maven3 belly up on unknown {{--raw-streams}} option.
> Basically we have currently:
> * Maven 3.9.9. belly up on {{--raw-streams}}
> * Maven 4 must have, it otherwise construct will not return what you want
> Proposed solution: make Maven 3.9.10 silently ignore this option.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [POC-FIX-PMD] `maven-pmd-plugin`: reactivate `PMD` - Error Prone [maven]
Pankraz76 commented on PR #2331: URL: https://github.com/apache/maven/pull/2331#issuecomment-2897383977 yes, indeed, please excuse my emotional breakout. we aligned on shrinking as its too much. [Error prone](https://pmd.github.io/pmd/pmd_rules_jsp_errorprone.html), the new scope, which is default, only exposes 3 issues, which seem to have real impact. [Best practices](https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html) impact on code shape. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 closed pull request #2364: [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone URL: https://github.com/apache/maven/pull/2364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2288] Set version for maven-changes-plugin [maven-surefire]
slawekjaranowski commented on code in PR #846: URL: https://github.com/apache/maven-surefire/pull/846#discussion_r2099910479 ## pom.xml: ## @@ -376,6 +376,11 @@ + + org.apache.maven.plugins + maven-changes-plugin + 2.12.1 Review Comment: did you check site output ... ? I would like to use 3.0.0-M3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Release 1.0.3? [maven-mvnd]
Tillerino opened a new issue, #1329: URL: https://github.com/apache/maven-mvnd/issues/1329 ### New feature, improvement proposal Hi there, I am writing from downstream where we are having trouble building mvnd 1.0.2 with GraalVM 24: Groovy 4.0.22 does not support Java 24. Now we are discussion all sorts of workarounds in NixOS/nixpkgs#407817, but I was wondering if you could do us a favor and just release mvnd 1.0.3 right now, which would solve our problem without any workarounds: On the `mvnd-1.x` branch Groovy was updated to 4.0.24, which suffices for Java 24. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Using Google Java Conventions XML Config causes failure [maven-checkstyle-plugin]
schl3sch closed issue #176: Using Google Java Conventions XML Config causes failure URL: https://github.com/apache/maven-checkstyle-plugin/issues/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] Using Google Java Conventions XML Config causes failure [maven-checkstyle-plugin]
schl3sch commented on issue #176: URL: https://github.com/apache/maven-checkstyle-plugin/issues/176#issuecomment-2896934983 Thank you, now it works as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8733) mvnenc command not producing any output
[
https://issues.apache.org/jira/browse/MNG-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8733:
-
Description:
Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
just exits with nothing returned. Looks like it succeeds.
When using -X parameter to the command, I can see the output along with the
debug information.
Using mvnenc with mvnsh works correctly.
{code:java}
% mvnenc encrypt
Enter the password to encrypt:
% {code}
{code:java}
% mvnenc diag
[INFO] Configuration validation of MavenSecDispatcher: VALID
[INFO] Configuration file present on path
/Users/software/.m2/settings-security4.xml
[INFO] Default dispatcher configured
[INFO] Configured default dispatcher configuration is valid
[INFO] Legacy dispatcher present in system
[INFO] Legacy dispatcher is operational; transparent fallback possible
[INFO] Configuration validation of MasterDispatcher: VALID
[INFO] Configured Cipher supported
[INFO] Configured Source configuration valid
[INFO] Configuration validation of EnvMasterSource: VALID
[INFO] Configured environment variable exist
[INFO] Configuration validation of LegacyDispatcher: VALID
[INFO] Legacy configuration found with encrypted master password
[INFO] Legacy master password successfully decrypted
{code}
was:
Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
just exits with nothing returned. Looks like it succeeds.
When using -X parameter to the command, I can see the output along with the
debug information.
Using mvnenc with mvnsh works correctly.
{code:java}
% mvnenc encrypt
Enter the password to encrypt:
% {code}
{code:java}
% mvnenc diag
[INFO] Configuration validation of MavenSecDispatcher: VALID
[INFO] Configuration file present on path
/Users/software/.m2/settings-security4.xml [INFO] Default dispatcher configured
[INFO] Configured default dispatcher configuration is valid
[INFO] Legacy dispatcher present in system
[INFO] Legacy dispatcher is operational; transparent fallback possible
[INFO] Configuration validation of MasterDispatcher: VALID
[INFO] Configured Cipher supported
[INFO] Configured Source configuration valid
[INFO] Configuration validation of EnvMasterSource: VALID
[INFO] Configured environment variable exist
[INFO] Configuration validation of LegacyDispatcher: VALID
[INFO] Legacy configuration found with encrypted master password
[INFO] Legacy master password successfully decrypted
{code}
> mvnenc command not producing any output
> ---
>
> Key: MNG-8733
> URL: https://issues.apache.org/jira/browse/MNG-8733
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-rc-3
> Environment: Java 21 and 24
>Reporter: Lenny Primak
>Priority: Minor
>
> Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
> just exits with nothing returned. Looks like it succeeds.
> When using -X parameter to the command, I can see the output along with the
> debug information.
> Using mvnenc with mvnsh works correctly.
>
> {code:java}
> % mvnenc encrypt
> Enter the password to encrypt:
> % {code}
> {code:java}
> % mvnenc diag
> [INFO] Configuration validation of MavenSecDispatcher: VALID
> [INFO] Configuration file present on path
> /Users/software/.m2/settings-security4.xml
> [INFO] Default dispatcher configured
> [INFO] Configured default dispatcher configuration is valid
> [INFO] Legacy dispatcher present in system
> [INFO] Legacy dispatcher is operational; transparent fallback possible
> [INFO] Configuration validation of MasterDispatcher: VALID
> [INFO] Configured Cipher supported
> [INFO] Configured Source configuration valid
> [INFO] Configuration validation of EnvMasterSource: VALID
> [INFO] Configured environment variable exist
> [INFO] Configuration validation of LegacyDispatcher: VALID
> [INFO] Legacy configuration found with encrypted master password
> [INFO] Legacy master password successfully decrypted
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-8733) mvnenc command not producing any output
[
https://issues.apache.org/jira/browse/MNG-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8733:
-
Description:
Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
just exits with nothing returned. Looks like it succeeds.
When using -X parameter to the command, I can see the output along with the
debug information.
Using mvnenc with mvnsh works correctly.
{code:java}
% mvnenc encrypt
Enter the password to encrypt:
% {code}
{code:java}
% mvnenc diag
[INFO] Configuration validation of MavenSecDispatcher: VALID
[INFO] Configuration file present on path
/Users/software/.m2/settings-security4.xml [INFO] Default dispatcher configured
[INFO] Configured default dispatcher configuration is valid
[INFO] Legacy dispatcher present in system
[INFO] Legacy dispatcher is operational; transparent fallback possible
[INFO] Configuration validation of MasterDispatcher: VALID
[INFO] Configured Cipher supported
[INFO] Configured Source configuration valid
[INFO] Configuration validation of EnvMasterSource: VALID
[INFO] Configured environment variable exist
[INFO] Configuration validation of LegacyDispatcher: VALID
[INFO] Legacy configuration found with encrypted master password
[INFO] Legacy master password successfully decrypted
{code}
was:
Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
just exits with nothing returned. Looks like it succeeds.
When using -X parameter to the command, I can see the output along with the
debug information.
Using mvnenc with mvnsh works correctly.
{code:java}
% mvnenc encrypt
Enter the password to encrypt:
% {code}
{code:java}
% mvnenc diag
[INFO] Configuration validation of MavenSecDispatcher: VALID [INFO]
Configuration file present on path /Users/software/.m2/settings-security4.xml
[INFO] Default dispatcher configured [INFO] Configured default dispatcher
configuration is valid [INFO] Legacy dispatcher present in system [INFO] Legacy
dispatcher is operational; transparent fallback possible [INFO] Configuration
validation of MasterDispatcher: VALID [INFO] Configured Cipher supported [INFO]
Configured Source configuration valid [INFO] Configuration validation of
EnvMasterSource: VALID [INFO] Configured environment variable exist [INFO]
Configuration validation of LegacyDispatcher: VALID [INFO] Legacy configuration
found with encrypted master password [INFO] Legacy master password successfully
decrypted
{code}
> mvnenc command not producing any output
> ---
>
> Key: MNG-8733
> URL: https://issues.apache.org/jira/browse/MNG-8733
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-rc-3
> Environment: Java 21 and 24
>Reporter: Lenny Primak
>Priority: Minor
>
> Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
> just exits with nothing returned. Looks like it succeeds.
> When using -X parameter to the command, I can see the output along with the
> debug information.
> Using mvnenc with mvnsh works correctly.
>
> {code:java}
> % mvnenc encrypt
> Enter the password to encrypt:
> % {code}
> {code:java}
> % mvnenc diag
> [INFO] Configuration validation of MavenSecDispatcher: VALID
> [INFO] Configuration file present on path
> /Users/software/.m2/settings-security4.xml [INFO] Default dispatcher
> configured
> [INFO] Configured default dispatcher configuration is valid
> [INFO] Legacy dispatcher present in system
> [INFO] Legacy dispatcher is operational; transparent fallback possible
> [INFO] Configuration validation of MasterDispatcher: VALID
> [INFO] Configured Cipher supported
> [INFO] Configured Source configuration valid
> [INFO] Configuration validation of EnvMasterSource: VALID
> [INFO] Configured environment variable exist
> [INFO] Configuration validation of LegacyDispatcher: VALID
> [INFO] Legacy configuration found with encrypted master password
> [INFO] Legacy master password successfully decrypted
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953102#comment-17953102
]
Tamas Cservenak commented on MNG-8735:
--
With {{-e}} it clearly tells:
{noformat}
Caused by: java.lang.IllegalArgumentException: Invalid Version Range
Request: org.eclipse.ee4j:project:pom:1.0.9 < [hope-repository
(https://nexus.hope.nyc.ny.us/repository/maven-releases, default, releases),
central (https://repo.maven.apache.org/maven2/, default, releases),
sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
at
org.eclipse.aether.internal.impl.DefaultRepositorySystemValidator.mayThrow(DefaultRepositorySystemValidator.java:62)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystemValidator.validateVersionRangeRequest(DefaultRepositorySystemValidator.java:107)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveVersionRange(DefaultRepositorySystem.java:197)
at
org.apache.maven.impl.DefaultVersionRangeResolver.doResolve(DefaultVersionRangeResolver.java:68)
at
org.apache.maven.impl.cache.CachingSupplier.apply(CachingSupplier.java:50)
at
org.apache.maven.impl.cache.AbstractRequestCache.request(AbstractRequestCache.java:63)
at
org.apache.maven.impl.AbstractSession.request(AbstractSession.java:145)
at
org.apache.maven.impl.DefaultVersionRangeResolver.resolve(DefaultVersionRangeResolver.java:60)
at
org.apache.maven.api.services.VersionRangeResolver.resolve(VersionRangeResolver.java:81)
at
org.apache.maven.impl.AbstractSession.resolveHighestVersion(AbstractSession.java:944)
at
org.apache.maven.impl.resolver.DefaultModelResolver.doResolveModel(DefaultModelResolver.java:142)
at
org.apache.maven.impl.resolver.DefaultModelResolver.lambda$resolveModel$0(DefaultModelResolver.java:113)
at
org.apache.maven.impl.cache.CachingSupplier.apply(CachingSupplier.java:50)
at
org.apache.maven.impl.cache.AbstractRequestCache.request(AbstractRequestCache.java:63)
at
org.apache.maven.impl.AbstractSession.request(AbstractSession.java:145)
at
org.apache.maven.impl.resolver.DefaultModelResolver.resolveModel(DefaultModelResolver.java:113)
at
org.apache.maven.impl.resolver.DefaultModelResolver.resolveModel(DefaultModelResolver.java:63)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.resolveAndReadParentExternally(DefaultModelBuilder.java:1023)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.resolveParent(DefaultModelBuilder.java:868)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.readParent(DefaultModelBuilder.java:836)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.doReadAsParentModel(DefaultModelBuilder.java:1535)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.readAsParentModel(DefaultModelBuilder.java:1526)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.resolveAndReadParentExternally(DefaultModelBuilder.java:1052)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.resolveParent(DefaultModelBuilder.java:868)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.readParent(DefaultModelBuilder.java:836)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.readEffectiveModel(DefaultModelBuilder.java:1141)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionState.buildEffectiveModel(DefaultModelBuilder.java:773)
at
org.apache.maven.impl.model.DefaultModelBuilder$ModelBuilderSessionImpl.build(DefaultModelBuilder.java:238)
at
org.apache.maven.impl.resolver.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:210)
at
org.apache.maven.impl.resolver.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:105)
at
org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.resolveCachedArtifactDescriptor(DependencyCollectorDelegate.java:484)
at
org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.resolveDescriptorForVersion(BfDependencyCollector.java:463)
at
org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$1(BfDependencyCollector.java:437)
at
java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1708)
at
java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at
org.eclipse.aether.internal.impl.collect.bf.BfDependencyCollector.lambda$resolveArtifactDescriptorAsync$4(BfDependencyCollector.java:436)
at java.util.concurrent.FutureTask.run(
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953104#comment-17953104
]
Tamas Cservenak commented on MNG-8735:
--
Maven4 implemented MNG-8654, more specifically MNG-8677 that _prevents_
uninterpolated values to enter resolver (as resolver had no "interpolate"
functionality and it handles all strings as opaque). Usually uninterpolated
value is user error.
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump sisu.version from 0.9.0.M3 to 0.9.0.M4 [maven-mvnd]
dependabot[bot] opened a new pull request, #1330: URL: https://github.com/apache/maven-mvnd/pull/1330 Bumps `sisu.version` from 0.9.0.M3 to 0.9.0.M4. Updates `org.eclipse.sisu:org.eclipse.sisu.inject` from 0.9.0.M3 to 0.9.0.M4 Release notes Sourced from https://github.com/eclipse-sisu/sisu-project/releases";>org.eclipse.sisu:org.eclipse.sisu.inject's releases. 0.9.0.M4 Most important change: ASM is "demoted" to plain dependency, hence, consumer is able to override/update it the usual "Maven way". This applies to all components: inject, plexus and sisu-maven-plugin as well. Historically, Sisu shaded in ASM just like Guice did. Later Sisu started shipping "main" JAR with shaded ASM but also "no_asm" classified artifact without ASM (just like Guice did with "classes" classified JAR). Starting from this version, Sisu does not shade ASM anymore, it is "demoted" to transitive dependency. Sisu is built with ASM 9.8. Sisu is compatible with range of Guice [3,7). What's Changed Disable shallow clones for sonarcloud analysis by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/145";>eclipse-sisu/sisu-project#145 Remove spurious asserts by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/147";>eclipse-sisu/sisu-project#147 Post release cleanup by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/146";>eclipse-sisu/sisu-project#146 Fix jacoco + code coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/151";>eclipse-sisu/sisu-project#151 Enable code coverage again for all modules by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/153";>eclipse-sisu/sisu-project#153 Use default property for the jacoco agent by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/154";>eclipse-sisu/sisu-project#154 Add documentation on Plexus Configurator API by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/172";>eclipse-sisu/sisu-project#172 Remove about.html as only relevant for Eclipse plugins by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/171";>eclipse-sisu/sisu-project#171 Document Lifecycle support by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/175";>eclipse-sisu/sisu-project#175 Call TypeAwareExpressionEvaluator.evaluate(String,Class) if available by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/161";>eclipse-sisu/sisu-project#161 Pass strict flag also via "discoverComponents" by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/182";>eclipse-sisu/sisu-project#182 Embed/relocate ASM via m-shade-p by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/185";>eclipse-sisu/sisu-project#185 Update to ASM 9.8 by https://github.com/kwin";>@kwin in https://redirect.github.com/eclipse-sisu/sisu-project/pull/186";>eclipse-sisu/sisu-project#186 Increase coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/192";>eclipse-sisu/sisu-project#192 Align subproject names (and naming) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/191";>eclipse-sisu/sisu-project#191 Build infra updates by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/193";>eclipse-sisu/sisu-project#193 More coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/195";>eclipse-sisu/sisu-project#195 More coverage by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/196";>eclipse-sisu/sisu-project#196 Update source header. by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/194";>eclipse-sisu/sisu-project#194 Update headers (no code change) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/199";>eclipse-sisu/sisu-project#199 Reformat (no code change) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/200";>eclipse-sisu/sisu-project#200 Reproducible by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/202";>eclipse-sisu/sisu-project#202 Fix sisu-maven-plugin by https://github.com/cstamas";>@cstamas in https://redirect.github.com/eclipse-sisu/sisu-project/pull/203";>eclipse-sisu/sisu-project#203 Lax array conve
Re: [I] JUnitPlatformProvider reruns successful tests [maven-surefire]
khmarbaise commented on issue #847: URL: https://github.com/apache/maven-surefire/issues/847#issuecomment-2897488751 You have to use Junit Jupiter Vintage Engine to run your JUnit 4 Tests on JUnit 5 ... adding the junit4 provider for surefire will not help here https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
slachiewicz closed pull request #2364: [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone URL: https://github.com/apache/maven/pull/2364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
slachiewicz commented on PR #2364: URL: https://github.com/apache/maven/pull/2364#issuecomment-2899158675 Too big a list of pmd exclusions. Please avoid opening PR if You see lots of planned updates, to avoid noise and unnecessary notifications. Check if Your build is green before opening PR. Thank you for understanding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] resolve false negative suppression `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 opened a new pull request, #2369: URL: https://github.com/apache/maven/pull/2369 - https://github.com/apache/maven/pull/2365 - https://github.com/apache/maven/pull/2366 - https://github.com/apache/maven/pull/2364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 commented on code in PR #2364: URL: https://github.com/apache/maven/pull/2364#discussion_r2100989741 ## .pmd/exclude.properties: ## @@ -0,0 +1,140 @@ +org.apache.maven.ReactorReader=UselessParentheses +org.apache.maven.api.DependencyScope=UnnecessaryFullyQualifiedName +org.apache.maven.api.JavaPathType=UnnecessaryFullyQualifiedName,UnnecessaryModifier +org.apache.maven.api.MonotonicClock=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.Foo=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.MojoExtension=CollapsibleIfStatements +org.apache.maven.api.plugin.testing.stubs.SessionMock=TooManyStaticImports +org.apache.maven.api.services.ArtifactCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.ArtifactFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.DependencyCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.ArtifactUtils=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.DefaultArtifact=UselessParentheses +org.apache.maven.artifact.deployer.DefaultArtifactDeployer=EmptyControlStatement +org.apache.maven.artifact.handler.manager.DefaultArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.handler.manager.LegacyArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.installer.DefaultArtifactInstaller=EmptyControlStatement +org.apache.maven.artifact.metadata.AbstractArtifactMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.ArtifactRepositoryPolicy=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.DefaultArtifactRepository=UnusedFormalParameter +org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager=CollapsibleIfStatements +org.apache.maven.artifact.repository.metadata.io.xpp3.MetadataXpp3Writer=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.resolver.DaemonThreadCreator=AvoidThreadGroup +org.apache.maven.artifact.resolver.filter.ExclusionArtifactFilter=UnusedPrivateField +org.apache.maven.artifact.versioning.ComparableVersion=UselessParentheses +org.apache.maven.artifact.versioning.ListItem=UselessParentheses +org.apache.maven.artifact.versioning.VersionRange=CollapsibleIfStatements +org.apache.maven.bridge.MavenRepositorySystem=AvoidUsingHardCodedIP,UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.cli.CLIReportingUtils=UselessParentheses +org.apache.maven.cli.MavenCli=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor=UnusedFormalParameter +org.apache.maven.cli.props.MavenProperties=CollapsibleIfStatements +org.apache.maven.cli.props.MavenPropertiesLoader=UselessParentheses +org.apache.maven.cli.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cli.transfer.ConsoleMavenTransferListener=UnusedFormalParameter +org.apache.maven.cli.transfer.Slf4jMavenTransferListener=UselessParentheses +org.apache.maven.cling.executor.embedded.Context=UnusedPrivateField +org.apache.maven.cling.invoker.BaseParser=TooManyStaticImports +org.apache.maven.cling.invoker.LookupInvoker=SimplifiedTernary +org.apache.maven.cling.invoker.mvnenc.CommonsCliEncryptOptions=UnnecessaryFullyQualifiedName +org.apache.maven.cling.invoker.mvnsh.CommonsCliShellOptions=UnnecessaryFullyQualifiedName +org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistry=UnusedFormalParameter +org.apache.maven.cling.logging.Slf4jLoggerManager=UselessParentheses +org.apache.maven.cling.logging.impl.UnsupportedSlf4jBindingConfiguration=UnusedFormalParameter +org.apache.maven.cling.props.MavenProperties=CollapsibleIfStatements +org.apache.maven.cling.props.MavenPropertiesLoader=UselessParentheses +org.apache.maven.cling.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cling.transfer.ConsoleMavenTransferListener=UnusedFormalParameter +org.apache.maven.cling.transfer.Slf4jMavenTransferListener=UselessParentheses +org.apache.maven.cling.utils.CLIReportingUtils=UnusedPrivateField,UselessParentheses +org.apache.maven.configuration.BasedirBeanConfigurationPathTranslator=EmptyControlStatement +org.apache.maven.di.impl.Binding=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.ReflectionUtils=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.SingletonScope=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.Types=JumbledIncrementer,UnnecessaryFullyQualifiedName +org.apache.maven.exception.DefaultExceptionHandler=UselessParentheses +org.apache.maven.execution.MavenSession=UnusedFormalParameter +org.apache.maven.graph.DefaultGraphBuilder=UselessParentheses +org.apache.maven.impl.DefaultNode=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.impl.DefaultRepositoryFactory=UnnecessaryFullyQualifiedName +org.apache.maven.im
[PR] EmptyControlStatement: `PluginParameterExpressionEvaluator` [maven]
Pankraz76 opened a new pull request, #2372: URL: https://github.com/apache/maven/pull/2372 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEPLOY-266) More verbose output for deployment to trace down errors (esp. 401)
[
https://issues.apache.org/jira/browse/MDEPLOY-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953256#comment-17953256
]
Jörg Hohwiller commented on MDEPLOY-266:
[https://github.com/m-m-m/l10n/actions/runs/15172331126/job/42665153423#step:5:239]
{quote}
Error: Failed to execute goal
org.sonatype.central:central-publishing-maven-plugin:0.7.0:publish
(injected-central-publishing) on project mmm-l10n-all:
org.apache.maven.artifact.deployer.ArtifactDeploymentException:
Failed to deploy artifacts: Could not transfer artifact
io.github.m-m-m:mmm-l10n-en:jar:sources:0.0-20250521.205133-10 from/to deploy
([https://s01.oss.sonatype.org/content/repositories/snapshots/]):
status code: 401, reason phrase: Unauthorized (401) -> [Help 1]
{quote}
No further details.
As we can see not the `maven-deploy-plugin` anymore but the problem is a
"general thing" in maven.
You should definitely should not log password and maybe for access token
already the login could be considered as a "secret" for a user token that could
be revealed on github action (I still would not mind if the login would be
printed - at least with -X). But there is a big difference if no credentials
have been found at all or not.
I am just wondering how many OSSRH support requests could already be prevented
by this simple feature, but as it seems I am here at the wrong place...
> More verbose output for deployment to trace down errors (esp. 401)
> --
>
> Key: MDEPLOY-266
> URL: https://issues.apache.org/jira/browse/MDEPLOY-266
> Project: Maven Deploy Plugin (Moved to GitHub Issues)
> Issue Type: Improvement
>Affects Versions: 2.8.2
>Reporter: Jörg Hohwiller
>Priority: Major
>
> There are many reasons why a deployment of maven artifacts can fail:
> * network error
> * error on server side in repo server
> * no login configured
> * wrong login configured
> * no password configured
> * wrong password configured (password may be encrypted so even almost
> impossible to determine)
> * repository ID in distribution-management and server ID in settings.xml do
> not match
> * etc.
> It is really hard to check all the possibilities (please note that the
> distributionManagement may be configured in a parent^N pom and out of sight
> so you need to print the effective-pom. Many Maven users even do not have a
> clue how to do that). However, maven-deploy-plugin only prints that the
> deployment failed and an HTTP status code (typically 401). But this is very
> little information. Tons of users are therefore waisting their own time and
> especially also the time of others (e.g. OSSRH team) to trace down the reason.
> It should be trivial for maven-deploy-plugin to log some more information:
> * ID of repository that deployment is going to use
> * whether a server tag from settings.xml could be resolved for this ID
> * the login that is used for the deployment or a WARNING if login is
> undefined
> * WARNING if password is undefined (obviously you should not log the
> password)
> With this simple information users could save many hours/days of valuable
> time to trace down errors more easily.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] resolve unused assignment to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 commented on code in PR #2367:
URL: https://github.com/apache/maven/pull/2367#discussion_r2100945236
##
compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java:
##
@@ -293,10 +293,9 @@ void testResolveNearestWithRanges() throws
ArtifactResolutionException, InvalidV
}
@Test
-@SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws
ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
-ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
Review Comment:
added test us give field a purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 commented on code in PR #2364: URL: https://github.com/apache/maven/pull/2364#discussion_r2100980955 ## .pmd/exclude.properties: ## @@ -0,0 +1,140 @@ +org.apache.maven.ReactorReader=UselessParentheses +org.apache.maven.api.DependencyScope=UnnecessaryFullyQualifiedName +org.apache.maven.api.JavaPathType=UnnecessaryFullyQualifiedName,UnnecessaryModifier +org.apache.maven.api.MonotonicClock=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.Foo=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.MojoExtension=CollapsibleIfStatements +org.apache.maven.api.plugin.testing.stubs.SessionMock=TooManyStaticImports +org.apache.maven.api.services.ArtifactCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.ArtifactFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.DependencyCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.ArtifactUtils=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.DefaultArtifact=UselessParentheses +org.apache.maven.artifact.deployer.DefaultArtifactDeployer=EmptyControlStatement +org.apache.maven.artifact.handler.manager.DefaultArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.handler.manager.LegacyArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.installer.DefaultArtifactInstaller=EmptyControlStatement +org.apache.maven.artifact.metadata.AbstractArtifactMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.ArtifactRepositoryPolicy=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.DefaultArtifactRepository=UnusedFormalParameter +org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager=CollapsibleIfStatements +org.apache.maven.artifact.repository.metadata.io.xpp3.MetadataXpp3Writer=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.resolver.DaemonThreadCreator=AvoidThreadGroup +org.apache.maven.artifact.resolver.filter.ExclusionArtifactFilter=UnusedPrivateField +org.apache.maven.artifact.versioning.ComparableVersion=UselessParentheses +org.apache.maven.artifact.versioning.ListItem=UselessParentheses +org.apache.maven.artifact.versioning.VersionRange=CollapsibleIfStatements +org.apache.maven.bridge.MavenRepositorySystem=AvoidUsingHardCodedIP,UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.cli.CLIReportingUtils=UselessParentheses +org.apache.maven.cli.MavenCli=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor=UnusedFormalParameter +org.apache.maven.cli.props.MavenProperties=CollapsibleIfStatements +org.apache.maven.cli.props.MavenPropertiesLoader=UselessParentheses +org.apache.maven.cli.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cli.transfer.ConsoleMavenTransferListener=UnusedFormalParameter +org.apache.maven.cli.transfer.Slf4jMavenTransferListener=UselessParentheses +org.apache.maven.cling.executor.embedded.Context=UnusedPrivateField +org.apache.maven.cling.invoker.BaseParser=TooManyStaticImports +org.apache.maven.cling.invoker.LookupInvoker=SimplifiedTernary +org.apache.maven.cling.invoker.mvnenc.CommonsCliEncryptOptions=UnnecessaryFullyQualifiedName +org.apache.maven.cling.invoker.mvnsh.CommonsCliShellOptions=UnnecessaryFullyQualifiedName +org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistry=UnusedFormalParameter +org.apache.maven.cling.logging.Slf4jLoggerManager=UselessParentheses +org.apache.maven.cling.logging.impl.UnsupportedSlf4jBindingConfiguration=UnusedFormalParameter +org.apache.maven.cling.props.MavenProperties=CollapsibleIfStatements +org.apache.maven.cling.props.MavenPropertiesLoader=UselessParentheses +org.apache.maven.cling.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cling.transfer.ConsoleMavenTransferListener=UnusedFormalParameter +org.apache.maven.cling.transfer.Slf4jMavenTransferListener=UselessParentheses +org.apache.maven.cling.utils.CLIReportingUtils=UnusedPrivateField,UselessParentheses +org.apache.maven.configuration.BasedirBeanConfigurationPathTranslator=EmptyControlStatement +org.apache.maven.di.impl.Binding=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.ReflectionUtils=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.SingletonScope=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.Types=JumbledIncrementer,UnnecessaryFullyQualifiedName +org.apache.maven.exception.DefaultExceptionHandler=UselessParentheses +org.apache.maven.execution.MavenSession=UnusedFormalParameter +org.apache.maven.graph.DefaultGraphBuilder=UselessParentheses +org.apache.maven.impl.DefaultNode=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.impl.DefaultRepositoryFactory=UnnecessaryFullyQualifiedName +org.apache.maven.im
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 commented on code in PR #2364:
URL: https://github.com/apache/maven/pull/2364#discussion_r2100984220
##
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##
@@ -95,7 +95,13 @@ public void run() {
getLog().info("[MAVEN-CORE-IT-LOG] Thread " + this + "
uses " + tccl);
Thread.currentThread().setContextClassLoader(tccl);
while (go.isEmpty()) {
-// wait for start
+// [WARNING] PMD Failure: Rule:EmptyControlStatement
Priority:3 Empty while statement.
Review Comment:
- https://github.com/apache/maven/pull/2368
##
its/core-it-support/core-it-plugins/maven-it-plugin-dependency-resolution/src/main/java/org/apache/maven/plugin/coreit/AbstractDependencyMojo.java:
##
@@ -222,11 +222,8 @@ private String calcChecksum(File jarFile) throws
IOException, NoSuchAlgorithmExc
MessageDigest digester = MessageDigest.getInstance("SHA-1");
try (FileInputStream is = new FileInputStream(jarFile)) {
-DigestInputStream dis = new DigestInputStream(is, digester);
-
-for (byte[] buffer = new byte[1024 * 4]; dis.read(buffer) >= 0; ) {
-// just read it
-}
+// [WARNING] PMD Failure: Rule:EmptyControlStatement Priority:3
Empty for statement.
Review Comment:
- https://github.com/apache/maven/pull/2368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 commented on code in PR #2364: URL: https://github.com/apache/maven/pull/2364#discussion_r2100981495 ## .pmd/exclude.properties: ## @@ -0,0 +1,140 @@ +org.apache.maven.ReactorReader=UselessParentheses +org.apache.maven.api.DependencyScope=UnnecessaryFullyQualifiedName +org.apache.maven.api.JavaPathType=UnnecessaryFullyQualifiedName,UnnecessaryModifier +org.apache.maven.api.MonotonicClock=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.Foo=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.MojoExtension=CollapsibleIfStatements +org.apache.maven.api.plugin.testing.stubs.SessionMock=TooManyStaticImports +org.apache.maven.api.services.ArtifactCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.ArtifactFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.DependencyCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.ArtifactUtils=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.DefaultArtifact=UselessParentheses +org.apache.maven.artifact.deployer.DefaultArtifactDeployer=EmptyControlStatement +org.apache.maven.artifact.handler.manager.DefaultArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.handler.manager.LegacyArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.installer.DefaultArtifactInstaller=EmptyControlStatement +org.apache.maven.artifact.metadata.AbstractArtifactMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.ArtifactRepositoryPolicy=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.DefaultArtifactRepository=UnusedFormalParameter +org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager=CollapsibleIfStatements +org.apache.maven.artifact.repository.metadata.io.xpp3.MetadataXpp3Writer=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.resolver.DaemonThreadCreator=AvoidThreadGroup +org.apache.maven.artifact.resolver.filter.ExclusionArtifactFilter=UnusedPrivateField +org.apache.maven.artifact.versioning.ComparableVersion=UselessParentheses +org.apache.maven.artifact.versioning.ListItem=UselessParentheses +org.apache.maven.artifact.versioning.VersionRange=CollapsibleIfStatements +org.apache.maven.bridge.MavenRepositorySystem=AvoidUsingHardCodedIP,UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.cli.CLIReportingUtils=UselessParentheses +org.apache.maven.cli.MavenCli=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor=UnusedFormalParameter +org.apache.maven.cli.props.MavenProperties=CollapsibleIfStatements +org.apache.maven.cli.props.MavenPropertiesLoader=UselessParentheses +org.apache.maven.cli.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cli.transfer.ConsoleMavenTransferListener=UnusedFormalParameter +org.apache.maven.cli.transfer.Slf4jMavenTransferListener=UselessParentheses +org.apache.maven.cling.executor.embedded.Context=UnusedPrivateField +org.apache.maven.cling.invoker.BaseParser=TooManyStaticImports +org.apache.maven.cling.invoker.LookupInvoker=SimplifiedTernary +org.apache.maven.cling.invoker.mvnenc.CommonsCliEncryptOptions=UnnecessaryFullyQualifiedName +org.apache.maven.cling.invoker.mvnsh.CommonsCliShellOptions=UnnecessaryFullyQualifiedName +org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistry=UnusedFormalParameter +org.apache.maven.cling.logging.Slf4jLoggerManager=UselessParentheses +org.apache.maven.cling.logging.impl.UnsupportedSlf4jBindingConfiguration=UnusedFormalParameter +org.apache.maven.cling.props.MavenProperties=CollapsibleIfStatements +org.apache.maven.cling.props.MavenPropertiesLoader=UselessParentheses +org.apache.maven.cling.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cling.transfer.ConsoleMavenTransferListener=UnusedFormalParameter +org.apache.maven.cling.transfer.Slf4jMavenTransferListener=UselessParentheses +org.apache.maven.cling.utils.CLIReportingUtils=UnusedPrivateField,UselessParentheses +org.apache.maven.configuration.BasedirBeanConfigurationPathTranslator=EmptyControlStatement +org.apache.maven.di.impl.Binding=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.ReflectionUtils=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.SingletonScope=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.Types=JumbledIncrementer,UnnecessaryFullyQualifiedName +org.apache.maven.exception.DefaultExceptionHandler=UselessParentheses +org.apache.maven.execution.MavenSession=UnusedFormalParameter +org.apache.maven.graph.DefaultGraphBuilder=UselessParentheses +org.apache.maven.impl.DefaultNode=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.impl.DefaultRepositoryFactory=UnnecessaryFullyQualifiedName +org.apache.maven.im
[PR] EmptyControlStatement: DefaultArtifactDeployer [maven]
Pankraz76 opened a new pull request, #2371: URL: https://github.com/apache/maven/pull/2371 - https://github.com/apache/maven/pull/2370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] EmptyControlStatement: `CheckThreadSafetyMojo` [maven]
desruisseaux commented on code in PR #2370:
URL: https://github.com/apache/maven/pull/2370#discussion_r2101193161
##
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##
@@ -95,7 +95,11 @@ public void run() {
getLog().info("[MAVEN-CORE-IT-LOG] Thread " + this + "
uses " + tccl);
Thread.currentThread().setContextClassLoader(tccl);
while (go.isEmpty()) {
-// wait for start
Review Comment:
I have not checked the context. But maybe
`java.util.concurrent.CountDownLatch` could be used instead of that loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEPLOY-266) More verbose output for deployment to trace down errors (esp. 401)
[ https://issues.apache.org/jira/browse/MDEPLOY-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953258#comment-17953258 ] Tamas Cservenak commented on MDEPLOY-266: - Right, here Maven itself cannot do much, nor resolver in fact (should we log for EVERY remote repository where no auth found, like file:// and so on)? And yes, these should be done in all m-deploy-p and sonatype plugin etc. > More verbose output for deployment to trace down errors (esp. 401) > -- > > Key: MDEPLOY-266 > URL: https://issues.apache.org/jira/browse/MDEPLOY-266 > Project: Maven Deploy Plugin (Moved to GitHub Issues) > Issue Type: Improvement >Affects Versions: 2.8.2 >Reporter: Jörg Hohwiller >Priority: Major > > There are many reasons why a deployment of maven artifacts can fail: > * network error > * error on server side in repo server > * no login configured > * wrong login configured > * no password configured > * wrong password configured (password may be encrypted so even almost > impossible to determine) > * repository ID in distribution-management and server ID in settings.xml do > not match > * etc. > It is really hard to check all the possibilities (please note that the > distributionManagement may be configured in a parent^N pom and out of sight > so you need to print the effective-pom. Many Maven users even do not have a > clue how to do that). However, maven-deploy-plugin only prints that the > deployment failed and an HTTP status code (typically 401). But this is very > little information. Tons of users are therefore waisting their own time and > especially also the time of others (e.g. OSSRH team) to trace down the reason. > It should be trivial for maven-deploy-plugin to log some more information: > * ID of repository that deployment is going to use > * whether a server tag from settings.xml could be resolved for this ID > * the login that is used for the deployment or a WARNING if login is > undefined > * WARNING if password is undefined (obviously you should not log the > password) > With this simple information users could save many hours/days of valuable > time to trace down errors more easily. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MDEPLOY-266) More verbose output for deployment to trace down errors (esp. 401)
[ https://issues.apache.org/jira/browse/MDEPLOY-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953258#comment-17953258 ] Tamas Cservenak edited comment on MDEPLOY-266 at 5/21/25 9:29 PM: -- Right, here Maven itself cannot do much, nor resolver in fact (should we log for EVERY remote repository where no auth found, like [file://|file:///] and so on)? And yes, these should be done in all m-deploy-p and sonatype plugin etc. But this gave me cool ideas for Njord :) was (Author: cstamas): Right, here Maven itself cannot do much, nor resolver in fact (should we log for EVERY remote repository where no auth found, like file:// and so on)? And yes, these should be done in all m-deploy-p and sonatype plugin etc. > More verbose output for deployment to trace down errors (esp. 401) > -- > > Key: MDEPLOY-266 > URL: https://issues.apache.org/jira/browse/MDEPLOY-266 > Project: Maven Deploy Plugin (Moved to GitHub Issues) > Issue Type: Improvement >Affects Versions: 2.8.2 >Reporter: Jörg Hohwiller >Priority: Major > > There are many reasons why a deployment of maven artifacts can fail: > * network error > * error on server side in repo server > * no login configured > * wrong login configured > * no password configured > * wrong password configured (password may be encrypted so even almost > impossible to determine) > * repository ID in distribution-management and server ID in settings.xml do > not match > * etc. > It is really hard to check all the possibilities (please note that the > distributionManagement may be configured in a parent^N pom and out of sight > so you need to print the effective-pom. Many Maven users even do not have a > clue how to do that). However, maven-deploy-plugin only prints that the > deployment failed and an HTTP status code (typically 401). But this is very > little information. Tons of users are therefore waisting their own time and > especially also the time of others (e.g. OSSRH team) to trace down the reason. > It should be trivial for maven-deploy-plugin to log some more information: > * ID of repository that deployment is going to use > * whether a server tag from settings.xml could be resolved for this ID > * the login that is used for the deployment or a WARNING if login is > undefined > * WARNING if password is undefined (obviously you should not log the > password) > With this simple information users could save many hours/days of valuable > time to trace down errors more easily. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] EmptyControlStatement: `CheckThreadSafetyMojo` [maven]
Pankraz76 opened a new pull request, #2370: URL: https://github.com/apache/maven/pull/2370 - https://github.com/apache/maven/pull/2365 - https://github.com/apache/maven/pull/2366 - https://github.com/apache/maven/pull/2364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] `DefaultModelInterpolator` Rule:`EmptyControlStatement - Empty if statement`. [maven]
Pankraz76 opened a new pull request, #2373: URL: https://github.com/apache/maven/pull/2373 this looks like a real bug. test is green meaning blindspot, might use or loose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [FIX] `DefaultModelInterpolator` Rule:`EmptyControlStatement - Empty if statement` [maven]
Pankraz76 commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2101042778
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##
@@ -137,7 +137,7 @@ String callback(
String expression) {
String value = doCallback(model, projectDir, request, problems,
expression);
if (value != null) {
-// value = postProcess(projectDir, request, expression, value);
Review Comment:
- this looks like a real bug.
- test is green meaning blindspot, might use or loose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [FIX] `DefaultModelInterpolator` Rule:`EmptyControlStatement - Empty if statement` [maven]
Pankraz76 commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2101045126
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##
@@ -137,7 +137,7 @@ String callback(
String expression) {
String value = doCallback(model, projectDir, request, problems,
expression);
if (value != null) {
-// value = postProcess(projectDir, request, expression, value);
Review Comment:
is this any good? @gnodet @elharo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] mvnd slow to start [maven-mvnd]
jjlharrison commented on issue #1331: URL: https://github.com/apache/maven-mvnd/issues/1331#issuecomment-2899061313 I worked out the issue... it's [the DNS lookup](https://stackoverflow.com/questions/33289695/inetaddress-getlocalhost-slow-to-run-30-seconds). I'm running on a new Mac, and I forgot to configure my local hostname in `/etc/hosts`. So, not a mvnd bug. Sorry to waste your time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] mvnd slow to start [maven-mvnd]
jjlharrison closed issue #1331: mvnd slow to start URL: https://github.com/apache/maven-mvnd/issues/1331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [RSPEC-S1144] Remove unused private methods [maven]
Pankraz76 opened a new pull request, #2334: URL: https://github.com/apache/maven/pull/2334 enabler: - https://github.com/apache/maven/pull/2310 - https://github.com/apache/maven/pull/2331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 commented on code in PR #2364:
URL: https://github.com/apache/maven/pull/2364#discussion_r2100967000
##
impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java:
##
@@ -392,34 +392,6 @@ private static String getChildCombinationMode(Map attributes) {
return !isEmpty(value) ? value : DEFAULT_CHILDREN_COMBINATION_MODE;
}
-@Nullable
Review Comment:
- https://github.com/apache/maven/pull/2334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] mvnd slow to start [maven-mvnd]
gnodet commented on issue #1331: URL: https://github.com/apache/maven-mvnd/issues/1331#issuecomment-2899012791 It would be nice to have the maven output with the timestamps, but if you say the build is fine after the initial start, it won't bring much. The daemon logs could be interesting too, they are in ~/.m2/mvnd/... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] add test assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
slachiewicz closed pull request #2365: add test assertion to resolve
`@SuppressWarnings("checkstyle:UnusedLocalVariable")`
URL: https://github.com/apache/maven/pull/2365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] resolve unused assignment to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 commented on code in PR #2367:
URL: https://github.com/apache/maven/pull/2367#discussion_r2100360341
##
compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java:
##
@@ -293,10 +293,9 @@ void testResolveNearestWithRanges() throws
ArtifactResolutionException, InvalidV
}
@Test
-@SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws
ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
-ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
Review Comment:
thats always the best of course. Thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.mockito:mockito-core from 3.12.4 to 5.18.0 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #402: URL: https://github.com/apache/maven-plugin-tools/pull/402 Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 3.12.4 to 5.18.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core's releases. v5.18.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 5.18.0 2025-05-20 - https://github.com/mockito/mockito/compare/v5.17.0...v5.18.0";>5 commit(s) by Eugene Platonov, Patrick Doyle, Tim van der Lippe, dependabot[bot] Make vararg checks Scala friendly (for mockito-scala) [(https://redirect.github.com/mockito/mockito/issues/3651";>#3651)](https://redirect.github.com/mockito/mockito/pull/3651";>mockito/mockito#3651) For UnfinishedStubbingException, suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3636";>#3636)](https://redirect.github.com/mockito/mockito/pull/3636";>mockito/mockito#3636) UnfinishedStubbingException ought to suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3635";>#3635)](https://redirect.github.com/mockito/mockito/issues/3635";>mockito/mockito#3635) v5.17.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 5.17.0 2025-04-04 - https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>7 commit(s) by Adrian Roos, Andre Kurait, Jan Ouwens, Rafael Winterhalter, Taeik Lim, Thach Le, Tim van der Lippe Fixes https://redirect.github.com/mockito/mockito/issues/3631";>#3631: Fix broken banner image link [(https://redirect.github.com/mockito/mockito/issues/3632";>#3632)](https://redirect.github.com/mockito/mockito/pull/3632";>mockito/mockito#3632) Banner image is broken [(https://redirect.github.com/mockito/mockito/issues/3631";>#3631)](https://redirect.github.com/mockito/mockito/issues/3631";>mockito/mockito#3631) Update exception message with mockito-inline [(https://redirect.github.com/mockito/mockito/issues/3628";>#3628)](https://redirect.github.com/mockito/mockito/pull/3628";>mockito/mockito#3628) Clarify structure of commit messages [(https://redirect.github.com/mockito/mockito/issues/3626";>#3626)](https://redirect.github.com/mockito/mockito/pull/3626";>mockito/mockito#3626) Fixes https://redirect.github.com/mockito/mockito/issues/3622";>#3622: MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3623";>#3623)](https://redirect.github.com/mockito/mockito/pull/3623";>mockito/mockito#3623) MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3622";>#3622)](https://redirect.github.com/mockito/mockito/issues/3622";>mockito/mockito#3622) Since mockito-inline has been removed, the exception messages with mockito-inline should be modified. [(https://redirect.github.com/mockito/mockito/issues/3621";>#3621)](https://redirect.github.com/mockito/mockito/issues/3621";>mockito/mockito#3621) Fixes https://redirect.github.com/mockito/mockito/issues/3171";>#3171: Fall back to Throwable Location strategy on Android [(https://redirect.github.com/mockito/mockito/issues/3619";>#3619)](https://redirect.github.com/mockito/mockito/pull/3619";>mockito/mockito#3619) Fixes https://redirect.github.com/mockito/mockito/issues/3615";>#3615 : broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3616";>#3616)](https://redirect.github.com/mockito/mockito/pull/3616";>mockito/mockito#3616) Broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3615";>#3615)](https://redirect.github.com/mockito/mockito/issues/3615";>mockito/mockito#3615) Mocks are not working on particular devices after update Android SDK from 33 to 34 [(https://redirect.github.com/mockito/mockito/issues/3171";>#3171)](https://redirect.github.com/mockito/mockito/issues/3171";>mockito/mockito#3171) v5.16.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 5.16.1 2025-03-15 - https://github.com/mockito/mockito/compare/v5.16.0...v5.16.1";>3 commit(s) by Adrian Roos, Jérôme Prinet, Rafael Winterhalter Remove Arrays.asList from critical stubbing path in GenericMetadataSu… [(https://redirect.github.com/mockito/mockito/issues/3610";>#3610)](https://redirect.github.com/mockito/mockito/pull/3610";>mockito/mockito#3610) Rework of injection strategy in the context of modules [(https://redirect.github.com/mockito/mockito/issues/3608";>#3608)](https://redirect.github.com/mockito/mockito/pull/3608";>mockito/mockito#3608) Adjust inline mocking snippet to allow task relocatability [(https://redirect.github.com/mockito/mockito/issues/3606";>#3606)](https://redirect.github.com/mockito/mockito/pull/3606";>mockito/mocki
Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.17.0 [maven-plugin-tools]
dependabot[bot] commented on PR #397: URL: https://github.com/apache/maven-plugin-tools/pull/397#issuecomment-2898095940 Superseded by #402. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.mockito:mockito-core from 3.12.4 to 5.17.0 [maven-plugin-tools]
dependabot[bot] closed pull request #397: Bump org.mockito:mockito-core from 3.12.4 to 5.17.0 URL: https://github.com/apache/maven-plugin-tools/pull/397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.redisson:redisson from 3.46.0 to 3.47.0 [maven-resolver]
dependabot[bot] opened a new pull request, #728: URL: https://github.com/apache/maven-resolver/pull/728 Bumps [org.redisson:redisson](https://github.com/redisson/redisson) from 3.46.0 to 3.47.0. Release notes Sourced from https://github.com/redisson/redisson/releases";>org.redisson:redisson's releases. redisson-3.47.0 Feature - https://redisson.pro/docs/data-and-services/queues/#reliable-fanout";>ReliableFanout object added Feature - https://redisson.pro/docs/data-and-services/queues/#configuration";>processingMode setting added to RReliableQueue config Feature - https://redisson.pro/docs/data-and-services/queues/#listeners";>listeners added to RReliableQueue object Feature - https://redisson.pro/docs/data-and-services/queues/#metrics";>metrics added to RReliableQueue object Feature - disableOperation() and enableOperation() methods added to RReliableQueue object Feature - get() and getAll() methods added to RReliableQueue object Feature - pollBatchSize, visibilityTimeout, negativeAcknowledgeDelay consumer settings added to Spring Cloud Stream Binder Feature - RReliableQueue implements RDestroyable interface Feature - readDiffEntries(), readIntersectionEntries(), readUnionEntries() methods added to RScoredSortedSet (thanks to https://github.com/seakider";>@seakider) Feature - valkeyCapabilities setting added Improvement - script logging in error message if useScriptCache = true Improvement - RReliableQueue data structure optimization Fixed - RClusteredLocalCachedMap.fastPut() method causes netty buffer leak if storeMode = LOCALCACHE Fixed - RReliableQueue.size() method result shouldn't include delayed messages amount Fixed - Spring Cache.getNativeCache() returns incorrect instance Fixed - exessive connections creation for RClusteredLocalCachedMap and RClusteredLocalCachedMapCache if 'reconnectionStrategy = LOAD' Fixed - readUnion(), readIntersection(), readDiff() methods of RSetCache throw exception Fixed - New connection opened for each write operation after failover in Sentinel mode (thanks to https://github.com/seakider";>@seakider) Fixed - Micronaut 4.x connects only to a single node Fixed - RedisURI(String) constructor doesn't set the hashCode Fixed - Spring Data Redis addMessageListener() method hangs if multiple listeners added to the same topic or pattern Fixed - detection of WAIT and WAITAOF commands availability Fixed - JCacheManager does not remove cache instance from map when calling closeCache() (thanks to https://github.com/seakider";>@seakider) Fixed - starvation of pub/sub connections may cause a memory leak Fixed - RMap.loadAll() method may hang in Cluster Fixed - None of slaves were synced exception is thrown Fixed - Spring Data Redis ReactiveZSetCommands.zadd() default param (thanks to https://github.com/lookroot";>@lookroot) Changelog Sourced from https://github.com/redisson/redisson/blob/master/CHANGELOG.md";>org.redisson:redisson's changelog. 21-May-2025 - 3.47.0 released Feature - https://redisson.pro/docs/data-and-services/queues/#reliable-fanout";>ReliableFanout object added Feature - https://redisson.pro/docs/data-and-services/queues/#configuration";>processingMode setting added to RReliableQueue config Feature - https://redisson.pro/docs/data-and-services/queues/#listeners";>listeners added to RReliableQueue object Feature - https://redisson.pro/docs/data-and-services/queues/#metrics";>metrics added to RReliableQueue object Feature - disableOperation() and enableOperation() methods added to RReliableQueue object Feature - get() and getAll() methods added to RReliableQueue object Feature - pollBatchSize, visibilityTimeout, negativeAcknowledgeDelay consumer settings added to Spring Cloud Stream Binder Feature - RReliableQueue implements RDestroyable interface Feature - readDiffEntries(), readIntersectionEntries(), readUnionEntries() methods added to RScoredSortedSet (thanks to https://github.com/seakider";>@seakider) Feature - valkeyCapabilities setting added Improvement - script logging in error message if useScriptCache = true Improvement - RReliableQueue data structure optimization Fixed - RClusteredLocalCachedMap.fastPut() method causes netty buffer leak if storeMode = LOCALCACHE Fixed - RReliableQueue.size() method result shouldn't include delayed messages amount Fixed - Spring Cache.getNativeCache() returns incorrect instance Fixed - exessive connections creation for RClusteredLocalCachedMap and RClusteredLocalCachedMapCache if 'reconnectionStrategy = LOAD' Fixed - readUnion(), readIntersection(), readDiff() methods of RSetCache throw exception Fixed - New connection opened for each write operation after failover in Sentinel mode (thanks to https://github.com/seakider";>@seakider) Fixed - Micronaut 4.x connects only to a single node Fixed - Redis
Re: [PR] [SUREFIRE-2288] Set version for maven-changes-plugin [maven-surefire]
olamy commented on code in PR #846: URL: https://github.com/apache/maven-surefire/pull/846#discussion_r2101694070 ## pom.xml: ## @@ -376,6 +376,11 @@ + + org.apache.maven.plugins + maven-changes-plugin + 2.12.1 Review Comment: How is it configured? Is it grabbing releases from GitHub? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2288] Set version for maven-changes-plugin [maven-surefire]
olamy commented on code in PR #846: URL: https://github.com/apache/maven-surefire/pull/846#discussion_r2101694070 ## pom.xml: ## @@ -376,6 +376,11 @@ + + org.apache.maven.plugins + maven-changes-plugin + 2.12.1 Review Comment: How is it configured? It looks to be Jira, which we are no longer using. Maybe it would be better to grab releases from GitHub? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.redisson:redisson from 3.46.0 to 3.47.0 [maven-resolver]
dependabot[bot] opened a new pull request, #729: URL: https://github.com/apache/maven-resolver/pull/729 Bumps [org.redisson:redisson](https://github.com/redisson/redisson) from 3.46.0 to 3.47.0. Release notes Sourced from https://github.com/redisson/redisson/releases";>org.redisson:redisson's releases. redisson-3.47.0 Feature - https://redisson.pro/docs/data-and-services/queues/#reliable-fanout";>ReliableFanout object added Feature - https://redisson.pro/docs/data-and-services/queues/#configuration";>processingMode setting added to RReliableQueue config Feature - https://redisson.pro/docs/data-and-services/queues/#listeners";>listeners added to RReliableQueue object Feature - https://redisson.pro/docs/data-and-services/queues/#metrics";>metrics added to RReliableQueue object Feature - disableOperation() and enableOperation() methods added to RReliableQueue object Feature - get() and getAll() methods added to RReliableQueue object Feature - pollBatchSize, visibilityTimeout, negativeAcknowledgeDelay consumer settings added to Spring Cloud Stream Binder Feature - RReliableQueue implements RDestroyable interface Feature - readDiffEntries(), readIntersectionEntries(), readUnionEntries() methods added to RScoredSortedSet (thanks to https://github.com/seakider";>@seakider) Feature - valkeyCapabilities setting added Improvement - script logging in error message if useScriptCache = true Improvement - RReliableQueue data structure optimization Fixed - RClusteredLocalCachedMap.fastPut() method causes netty buffer leak if storeMode = LOCALCACHE Fixed - RReliableQueue.size() method result shouldn't include delayed messages amount Fixed - Spring Cache.getNativeCache() returns incorrect instance Fixed - exessive connections creation for RClusteredLocalCachedMap and RClusteredLocalCachedMapCache if 'reconnectionStrategy = LOAD' Fixed - readUnion(), readIntersection(), readDiff() methods of RSetCache throw exception Fixed - New connection opened for each write operation after failover in Sentinel mode (thanks to https://github.com/seakider";>@seakider) Fixed - Micronaut 4.x connects only to a single node Fixed - RedisURI(String) constructor doesn't set the hashCode Fixed - Spring Data Redis addMessageListener() method hangs if multiple listeners added to the same topic or pattern Fixed - detection of WAIT and WAITAOF commands availability Fixed - JCacheManager does not remove cache instance from map when calling closeCache() (thanks to https://github.com/seakider";>@seakider) Fixed - starvation of pub/sub connections may cause a memory leak Fixed - RMap.loadAll() method may hang in Cluster Fixed - None of slaves were synced exception is thrown Fixed - Spring Data Redis ReactiveZSetCommands.zadd() default param (thanks to https://github.com/lookroot";>@lookroot) Changelog Sourced from https://github.com/redisson/redisson/blob/master/CHANGELOG.md";>org.redisson:redisson's changelog. 21-May-2025 - 3.47.0 released Feature - https://redisson.pro/docs/data-and-services/queues/#reliable-fanout";>ReliableFanout object added Feature - https://redisson.pro/docs/data-and-services/queues/#configuration";>processingMode setting added to RReliableQueue config Feature - https://redisson.pro/docs/data-and-services/queues/#listeners";>listeners added to RReliableQueue object Feature - https://redisson.pro/docs/data-and-services/queues/#metrics";>metrics added to RReliableQueue object Feature - disableOperation() and enableOperation() methods added to RReliableQueue object Feature - get() and getAll() methods added to RReliableQueue object Feature - pollBatchSize, visibilityTimeout, negativeAcknowledgeDelay consumer settings added to Spring Cloud Stream Binder Feature - RReliableQueue implements RDestroyable interface Feature - readDiffEntries(), readIntersectionEntries(), readUnionEntries() methods added to RScoredSortedSet (thanks to https://github.com/seakider";>@seakider) Feature - valkeyCapabilities setting added Improvement - script logging in error message if useScriptCache = true Improvement - RReliableQueue data structure optimization Fixed - RClusteredLocalCachedMap.fastPut() method causes netty buffer leak if storeMode = LOCALCACHE Fixed - RReliableQueue.size() method result shouldn't include delayed messages amount Fixed - Spring Cache.getNativeCache() returns incorrect instance Fixed - exessive connections creation for RClusteredLocalCachedMap and RClusteredLocalCachedMapCache if 'reconnectionStrategy = LOAD' Fixed - readUnion(), readIntersection(), readDiff() methods of RSetCache throw exception Fixed - New connection opened for each write operation after failover in Sentinel mode (thanks to https://github.com/seakider";>@seakider) Fixed - Micronaut 4.x connects only to a single node Fixed - Redis
Re: [PR] Fix `aggregate` Javadoc typo [maven-javadoc-plugin]
olamy merged PR #371: URL: https://github.com/apache/maven-javadoc-plugin/pull/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8735.
Resolution: Not A Problem
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] add test assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 commented on PR #2365: URL: https://github.com/apache/maven/pull/2365#issuecomment-2899200375 whats the issue here? is testing not valued? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [chore] resolve violations in `DefaultModelInterpolator` [maven]
Pankraz76 opened a new pull request, #2374: URL: https://github.com/apache/maven/pull/2374 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [fix] `DefaultModelInterpolator` Rule:`EmptyControlStatement - Empty if statement` [maven]
Pankraz76 commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2101157123
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##
@@ -109,8 +109,7 @@ private InnerInterpolator createInterpolator(
Model model, Path projectDir, ModelBuilderRequest request,
ModelProblemCollector problems) {
Map> cache = new HashMap<>();
-Function> ucb =
-v -> Optional.ofNullable(callback(model, projectDir, request,
problems, v));
+Function> ucb = v ->
Optional.ofNullable(doCallback(model, projectDir, request, v));
Review Comment:
```suggestion
Function> ucb = v ->
Optional.ofNullable(callback(model, projectDir, request, v));
```
cleanup in dedicated pr:
- https://github.com/apache/maven/pull/2374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] EmptyControlStatement: `PluginParameterExpressionEvaluator` [maven]
Pankraz76 commented on code in PR #2372:
URL: https://github.com/apache/maven/pull/2372#discussion_r2101027705
##
impl/maven-core/src/main/java/org/apache/maven/plugin/PluginParameterExpressionEvaluator.java:
##
@@ -347,9 +347,7 @@ public File alignToBaseDirectory(File file) {
// TODO Copied from the DefaultInterpolator. We likely want to
resurrect the PathTranslator or at least a
// similar component for re-usage
if (file != null) {
-if (file.isAbsolute()) {
-// path was already absolute, just normalize file separator
and we're done
Review Comment:
How should I preserve this information? Empty business logic as
documentation feels overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] EmptyControlStatement: DefaultArtifactDeployer [maven]
Pankraz76 commented on code in PR #2371:
URL: https://github.com/apache/maven/pull/2371#discussion_r2101022087
##
compat/maven-compat/src/main/java/org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java:
##
@@ -106,9 +104,6 @@ public void deploy(
org.eclipse.aether.artifact.Artifact pomArtifact = new
SubArtifact(mainArtifact, "", "pom");
pomArtifact =
pomArtifact.setFile(projectArtifactMetadata.getFile());
request.addArtifact(pomArtifact);
-} else if (metadata instanceof SnapshotArtifactRepositoryMetadata
-|| metadata instanceof ArtifactRepositoryMetadata) {
-// eaten, handled by repo system
Review Comment:
How should I preserve this information? Empty business logic as
documentation feels overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [I] mvnd slow to start [maven-mvnd]
jjlharrison commented on issue #1331:
URL: https://github.com/apache/maven-mvnd/issues/1331#issuecomment-2899051923
Even just running `mvnd --version` has the problem.
You can see here that we start at `20:40:38`, but the first log in the
daemon logs isn't until `20:40:43.841`.
```
$ date && mvnd --version && cat ~/.m2/mvnd/registry/2.0.0-rc-3/*.log
Wed 21 May 2025 20:40:38 BST
Apache Maven Daemon (mvnd) 2.0.0-rc-3 darwin-aarch64 native client
(f912362c18c9a75faf3e31a4e0e0b921206013b9)
Terminal: org.jline.terminal.impl.PosixSysTerminal with pty
org.jline.terminal.impl.jni.osx.OsXNativePty
Apache Maven 4.0.0-rc-3 (3952d00ce65df6753b63a51e86b1f626c55a8df2)
Maven home: /Users/jjlharrison/.sdkman/candidates/mvnd/2.0.0-rc-3/mvn
Java version: 24, vendor: Eclipse Adoptium, runtime:
/Users/jjlharrison/.sdkman/candidates/java/24-tem
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
20:40:43.841 I Dispatch message: BuildLogMessage{payload='Apache Maven
4.0.0-rc-3 (3952d00ce65df6753b63a51e86b1f626c55a8df2)
Maven home: /Users/jjlharrison/.sdkman/candidates/mvnd/2.0.0-rc-3/mvn
Java version: 24, vendor: Eclipse Adoptium, runtime:
/Users/jjlharrison/.sdkman/candidates/java/24-tem
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"'}
20:40:43.841 I Build finished, finishing message dispatch
20:40:43.841 I Dispatch message: BuildFinished{exitCode=0}
20:40:43.841 I No more message to dispatch
20:40:43.841 I Daemon back to idle
20:40:43.841 I Updating state to: Idle
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [fix] `DefaultModelInterpolator` Rule:`EmptyControlStatement - Empty if statement` [maven]
Pankraz76 commented on code in PR #2373:
URL: https://github.com/apache/maven/pull/2373#discussion_r2101042778
##
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelInterpolator.java:
##
@@ -137,7 +137,7 @@ String callback(
String expression) {
String value = doCallback(model, projectDir, request, problems,
expression);
if (value != null) {
-// value = postProcess(projectDir, request, expression, value);
Review Comment:
- this looks like a real bug.
- test is green meaning blindspot, might use or loose.
having now good test coverage this seems obsolete. Having the line in place
seems not to change the
behaviour so its outdated as comment tells.
100% (1/1) | 100% (11/11) | 98% (78/79) | 91% (55/60)
-- | -- | -- | --
�
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] EmptyControlStatement: `CheckThreadSafetyMojo` [maven]
Pankraz76 commented on code in PR #2370:
URL: https://github.com/apache/maven/pull/2370#discussion_r2101165484
##
its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java:
##
@@ -95,7 +95,11 @@ public void run() {
getLog().info("[MAVEN-CORE-IT-LOG] Thread " + this + "
uses " + tccl);
Thread.currentThread().setContextClassLoader(tccl);
while (go.isEmpty()) {
-// wait for start
Review Comment:
no need for debounce?
potentially `while(true)` cloud max out CPU.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] add test assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 commented on code in PR #2365:
URL: https://github.com/apache/maven/pull/2365#discussion_r2100062822
##
impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java:
##
@@ -79,6 +93,8 @@ void testAptConsistency() throws Exception {
assertEquals(handler.getExtension(), extension, type + "
extension");
// Packaging/Directory is Maven1 remnant!!!
// assertEquals(handler.getPackaging(), packaging, type + "
packaging");
+assertThat(handler.getPackaging()).isNotEmpty();
+assertThat(VALID_PACKAGING_TYPES).contains(packaging);
Review Comment:
resolve `UnusedLocalVariable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] mvnd slow to start [maven-mvnd]
jjlharrison opened a new issue, #1331: URL: https://github.com/apache/maven-mvnd/issues/1331 ### Affected version 1.0.2 and 2.0.0-rc-3 ### Bug description `mvnd` is very slow to start for me. Once the build has started it seems quicker than a normal `mvn` build, but with with slow start, overall it's much slower. Could this somehow be a problem with my configuration?  ``` $ ./mvn-benchmark.sh === Testing mvnd versions === --- mvnd@1.0.0 --- MVND_HOME=/Users/jjlharrison/.sdkman/candidates/mvnd/1.0.0 >>> mvnd --version Apache Maven Daemon (mvnd) 1.0.0 darwin-aarch64 native client (0cb7cbcbed6fad010b14dcd05acdc0a59685d88d) Terminal: org.jline.terminal.impl.PosixSysTerminal with pty org.jline.terminal.impl.jni.osx.OsXNativePty Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256) Maven home: /Users/jjlharrison/.sdkman/candidates/mvnd/1.0.0/mvn Java version: 24, vendor: Eclipse Adoptium, runtime: /Users/jjlharrison/.sdkman/candidates/java/24-tem Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac" Warm-up run (not timed): Measuring mvnd compile for 5 runs under version 1.0.0... Run 1: 6.588 s Run 2: 6.406 s Run 3: 6.607 s Run 4: 6.529 s Run 5: 6.491 s Results for mvnd@1.0.0: min = 6.406s max = 6.607s average = 6.524s median = 6.529s --- mvnd@1.0.2 --- MVND_HOME=/Users/jjlharrison/.sdkman/candidates/mvnd/1.0.2 >>> mvnd --version Apache Maven Daemon (mvnd) 1.0.2 darwin-aarch64 native client (1ec8a5b741c62b29f9fb04d37b1678a029bb) Terminal: org.jline.terminal.impl.PosixSysTerminal with pty org.jline.terminal.impl.jni.osx.OsXNativePty Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) Maven home: /Users/jjlharrison/.sdkman/candidates/mvnd/1.0.2/mvn Java version: 24, vendor: Eclipse Adoptium, runtime: /Users/jjlharrison/.sdkman/candidates/java/24-tem Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac" Warm-up run (not timed): Measuring mvnd compile for 5 runs under version 1.0.2... Run 1: 6.437 s Run 2: 6.543 s Run 3: 6.470 s Run 4: 6.374 s Run 5: 6.580 s Results for mvnd@1.0.2: min = 6.374s max = 6.580s average = 6.480s median = 6.470s --- mvnd@2.0.0-rc-3 --- MVND_HOME=/Users/jjlharrison/.sdkman/candidates/mvnd/2.0.0-rc-3 >>> mvnd --version Apache Maven Daemon (mvnd) 2.0.0-rc-3 darwin-aarch64 native client (f912362c18c9a75faf3e31a4e0e0b921206013b9) Terminal: org.jline.terminal.impl.PosixSysTerminal with pty org.jline.terminal.impl.jni.osx.OsXNativePty Apache Maven 4.0.0-rc-3 (3952d00ce65df6753b63a51e86b1f626c55a8df2) Maven home: /Users/jjlharrison/.sdkman/candidates/mvnd/2.0.0-rc-3/mvn Java version: 24, vendor: Eclipse Adoptium, runtime: /Users/jjlharrison/.sdkman/candidates/java/24-tem Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac" Warm-up run (not timed): Measuring mvnd compile for 5 runs under version 2.0.0-rc-3... Run 1: 6.550 s Run 2: 6.584 s Run 3: 6.458 s Run 4: 6.348 s Run 5: 6.401 s Results for mvnd@2.0.0-rc-3: min = 6.348s max = 6.584s average = 6.468s median = 6.458s === Testing mvn and mvnw === --- mvn --- >>> mvn --version Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937) Maven home: /Users/jjlharrison/.sdkman/candidates/maven/3.9.9 Java version: 24, vendor: Eclipse Adoptium, runtime: /Users/jjlharrison/.sdkman/candidates/java/24-tem Default locale: en_GB, platform encoding: UTF-8 OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac" Warm-up run (not timed): Measuring mvn compile for 5 runs... Run 1: 1.766 s Run 2: 1.805 s Run 3: 1.772 s Run 4: 1.866 s Run 5: 1.802 s Results for mvn: min
Re: [PR] add test assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 commented on code in PR #2365:
URL: https://github.com/apache/maven/pull/2365#discussion_r2100055678
##
impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java:
##
@@ -29,39 +28,54 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.codehaus.plexus.testing.PlexusExtension.getTestFile;
import static org.junit.jupiter.api.Assertions.assertEquals;
@PlexusTest
class ArtifactHandlerTest {
+private static final String[] EXPECTED = new String[] {
+"", "type", "classifier", "extension", "packaging", "language", "added
to classpath", "includesDependencies"
+};
+private static final List VALID_PACKAGING_TYPES = List.of(
+"pom",
+"jar",
+"test-jar",
+"maven-plugin",
+"ejb",
+"war",
+"ear",
+"rar",
+"java-source",
+"javadoc",
+"aar",
+"apk",
+"bundle",
+"eclipse-plugin",
+"eclipse-test-plugin",
+"hpi",
+"jpi",
+"kar",
+"lpkg",
+"maven-archetype",
+"nar",
+"par",
+"sar",
+"swc",
+"swf",
+"zip");
+
@Inject
PlexusContainer container;
@Test
-@SuppressWarnings("checkstyle:UnusedLocalVariable")
void testAptConsistency() throws Exception {
-File apt = getTestFile("src/site/apt/artifact-handlers.apt");
-
-List lines = Files.readAllLines(apt.toPath());
-
-for (String line : lines) {
+for (String line : Files.readAllLines(
+getTestFile("src/site/apt/artifact-handlers.apt").toPath())) {
if (line.startsWith("||")) {
-String[] cols = line.split("\\|\\|");
-String[] expected = new String[] {
-"",
-"type",
-"classifier",
-"extension",
-"packaging",
-"language",
-"added to classpath",
-"includesDependencies",
-""
Review Comment:
this is **not** required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] add test assertion to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 commented on code in PR #2365:
URL: https://github.com/apache/maven/pull/2365#discussion_r2100055206
##
impl/maven-core/src/test/java/org/apache/maven/artifact/handler/ArtifactHandlerTest.java:
##
@@ -29,39 +28,54 @@
import org.codehaus.plexus.testing.PlexusTest;
import org.junit.jupiter.api.Test;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.codehaus.plexus.testing.PlexusExtension.getTestFile;
import static org.junit.jupiter.api.Assertions.assertEquals;
@PlexusTest
class ArtifactHandlerTest {
+private static final String[] EXPECTED = new String[] {
+"", "type", "classifier", "extension", "packaging", "language", "added
to classpath", "includesDependencies"
+};
+private static final List VALID_PACKAGING_TYPES = List.of(
+"pom",
+"jar",
+"test-jar",
+"maven-plugin",
+"ejb",
+"war",
+"ear",
+"rar",
+"java-source",
+"javadoc",
+"aar",
+"apk",
+"bundle",
+"eclipse-plugin",
+"eclipse-test-plugin",
+"hpi",
+"jpi",
+"kar",
+"lpkg",
+"maven-archetype",
+"nar",
+"par",
+"sar",
+"swc",
+"swf",
+"zip");
+
@Inject
PlexusContainer container;
@Test
-@SuppressWarnings("checkstyle:UnusedLocalVariable")
void testAptConsistency() throws Exception {
-File apt = getTestFile("src/site/apt/artifact-handlers.apt");
-
-List lines = Files.readAllLines(apt.toPath());
-
-for (String line : lines) {
+for (String line : Files.readAllLines(
+getTestFile("src/site/apt/artifact-handlers.apt").toPath())) {
if (line.startsWith("||")) {
-String[] cols = line.split("\\|\\|");
-String[] expected = new String[] {
-"",
Review Comment:
this is required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] fix unused `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 opened a new pull request, #2366:
URL: https://github.com/apache/maven/pull/2366
fix unused `@SuppressWarnings("checkstyle:UnusedLocalVariable")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SUREFIRE-2288] Set version for maven-changes-plugin [maven-surefire]
sparsick commented on code in PR #846: URL: https://github.com/apache/maven-surefire/pull/846#discussion_r2100306546 ## pom.xml: ## @@ -376,6 +376,11 @@ + + org.apache.maven.plugins + maven-changes-plugin + 2.12.1 Review Comment: @slawekjaranowski I changed the version to 3.0.0-M3. Javadoc Goal is calling the changes-plugin and reports warning. But I cannot see the JIRA report in my local generated site. Is it a local expected behavior? The original warning of the issue are solved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953200#comment-17953200
]
Tamas Cservenak commented on MNG-8735:
--
Cause: an intermediate POM defines a remote repository with uninterpolated URL:
[https://repo.maven.apache.org/maven2/org/eclipse/persistence/org.eclipse.persistence.parent/4.0.6/org.eclipse.persistence.parent-4.0.6.pom]
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] resolve unused assignment to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
Pankraz76 commented on code in PR #2367:
URL: https://github.com/apache/maven/pull/2367#discussion_r2100180995
##
compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java:
##
@@ -293,10 +293,9 @@ void testResolveNearestWithRanges() throws
ArtifactResolutionException, InvalidV
}
@Test
-@SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws
ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
-ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
Review Comment:
yes, this is unit lvl and can be modified if needed of just give watch. We
all extract code into snippets when debugging, but only then. 9 out of 10 its
reading the code. Once its running, debug mode is the exception.
Therefore should be cleaned up to meet out standards.
Same reasoning applies to any code to we dont leave this raw as well so it
seems inconsequent imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[I] Permissions lost when using attachedOutputs [maven-build-cache-extension]
pn-santos opened a new issue, #214: URL: https://github.com/apache/maven-build-cache-extension/issues/214 ### New feature, improvement proposal When `attachedOutputs` are specified, if the attached files have exec permissions that permission will be lost when restoring from cache. I believe this is a limitation inherent to `zip` (the archive used to keep `attachedOutputs`). Would it be possible to switch the archive to `tar -p`? Not sure how important the compression is as a feature but at the very least make it configurable per attached output? _was unsure whether to open as a bug or feature (since this could very well be "by design") so defaulting to enhancement_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 opened a new pull request, #2364: URL: https://github.com/apache/maven/pull/2364 [Error prone](https://pmd.github.io/pmd/pmd_rules_jsp_errorprone.html), which is default, only exposes 3 issues, which seem to have real impact. [Best practices](https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html) impacts on code shape. - https://github.com/apache/maven/pull/2331 Issues: - [WARNING] PMD Failure: org.apache.maven.internal.xml.DefaultXmlService:396 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 'findNodeById(List, String)'.. - [WARNING] PMD Failure: org.apache.maven.internal.xml.DefaultXmlService:404 Rule:UnusedPrivateMethod Priority:3 Avoid unused private methods such as 'findNodeByKeys(List, XmlNode, String[])'.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone [maven]
Pankraz76 commented on PR #2364: URL: https://github.com/apache/maven/pull/2364#issuecomment-2897818893 wip -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] resolve unused assignment to resolve `@SuppressWarnings("checkstyle:UnusedLocalVariable")` [maven]
desruisseaux commented on code in PR #2367:
URL: https://github.com/apache/maven/pull/2367#discussion_r2100333828
##
compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java:
##
@@ -293,10 +293,9 @@ void testResolveNearestWithRanges() throws
ArtifactResolutionException, InvalidV
}
@Test
-@SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws
ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
-ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
Review Comment:
Alternatively, we can just add `assertSomething(b)`. It may be
`assertSame(a, b)` if the return value is for method call chaining (I didn't
check if it is the case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953208#comment-17953208
]
Lenny Primak commented on MNG-8735:
---
Ugh. That PR should be reverted. This isn't the actual issue
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump mockitoVersion from 5.17.0 to 5.18.0 [maven-deploy-plugin]
dependabot[bot] opened a new pull request, #603: URL: https://github.com/apache/maven-deploy-plugin/pull/603 Bumps `mockitoVersion` from 5.17.0 to 5.18.0. Updates `org.mockito:mockito-junit-jupiter` from 5.17.0 to 5.18.0 Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-junit-jupiter's releases. v5.18.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 5.18.0 2025-05-20 - https://github.com/mockito/mockito/compare/v5.17.0...v5.18.0";>5 commit(s) by Eugene Platonov, Patrick Doyle, Tim van der Lippe, dependabot[bot] Make vararg checks Scala friendly (for mockito-scala) [(https://redirect.github.com/mockito/mockito/issues/3651";>#3651)](https://redirect.github.com/mockito/mockito/pull/3651";>mockito/mockito#3651) For UnfinishedStubbingException, suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3636";>#3636)](https://redirect.github.com/mockito/mockito/pull/3636";>mockito/mockito#3636) UnfinishedStubbingException ought to suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3635";>#3635)](https://redirect.github.com/mockito/mockito/issues/3635";>mockito/mockito#3635) Commits https://github.com/mockito/mockito/commit/06737471ea19ca023581351eeac778ffbce8da74";>0673747 Force Jacoco version for Android https://github.com/mockito/mockito/commit/65388f01eb8a555c4df5dec692ba9abf8a2591b8";>65388f0 Update Jacoco version to 0.8.13 https://github.com/mockito/mockito/commit/60179ca10dbd29ff959d7eae670ce95b3f19f5fd";>60179ca Bump bytebuddy from 1.15.11 to 1.16.1 https://github.com/mockito/mockito/commit/8f15169774cb639b5757f121f27d6c0d8ca18c97";>8f15169 Make vararg checks Scala friendly (https://redirect.github.com/mockito/mockito/issues/3651";>#3651) https://github.com/mockito/mockito/commit/3a631cb87082fff212bc00c00970508b4ce63072";>3a631cb Add hint for multithreading in UnfinishedStubbingException (https://redirect.github.com/mockito/mockito/issues/3636";>#3636) See full diff in https://github.com/mockito/mockito/compare/v5.17.0...v5.18.0";>compare view Updates `org.mockito:mockito-core` from 5.17.0 to 5.18.0 Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core's releases. v5.18.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 5.18.0 2025-05-20 - https://github.com/mockito/mockito/compare/v5.17.0...v5.18.0";>5 commit(s) by Eugene Platonov, Patrick Doyle, Tim van der Lippe, dependabot[bot] Make vararg checks Scala friendly (for mockito-scala) [(https://redirect.github.com/mockito/mockito/issues/3651";>#3651)](https://redirect.github.com/mockito/mockito/pull/3651";>mockito/mockito#3651) For UnfinishedStubbingException, suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3636";>#3636)](https://redirect.github.com/mockito/mockito/pull/3636";>mockito/mockito#3636) UnfinishedStubbingException ought to suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3635";>#3635)](https://redirect.github.com/mockito/mockito/issues/3635";>mockito/mockito#3635) Commits https://github.com/mockito/mockito/commit/06737471ea19ca023581351eeac778ffbce8da74";>0673747 Force Jacoco version for Android https://github.com/mockito/mockito/commit/65388f01eb8a555c4df5dec692ba9abf8a2591b8";>65388f0 Update Jacoco version to 0.8.13 https://github.com/mockito/mockito/commit/60179ca10dbd29ff959d7eae670ce95b3f19f5fd";>60179ca Bump bytebuddy from 1.15.11 to 1.16.1 https://github.com/mockito/mockito/commit/8f15169774cb639b5757f121f27d6c0d8ca18c97";>8f15169 Make vararg checks Scala friendly (https://redirect.github.com/mockito/mockito/issues/3651";>#3651) https://github.com/mockito/mockito/commit/3a631cb87082fff212bc00c00970508b4ce63072";>3a631cb Add hint for multithreading in UnfinishedStubbingException (https://redirect.github.com/mockito/mockito/issues/3636";>#3636) See full diff in https://github.com/mockito/mockito/compare/v5.17.0...v5.18.0";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953210#comment-17953210
]
Piotr Zygielo commented on MNG-8735:
So what is actual issue?
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump mockitoVersion from 5.16.1 to 5.18.0 [maven-filtering]
dependabot[bot] opened a new pull request, #156: URL: https://github.com/apache/maven-filtering/pull/156 Bumps `mockitoVersion` from 5.16.1 to 5.18.0. Updates `org.mockito:mockito-junit-jupiter` from 5.16.1 to 5.18.0 Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-junit-jupiter's releases. v5.18.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 5.18.0 2025-05-20 - https://github.com/mockito/mockito/compare/v5.17.0...v5.18.0";>5 commit(s) by Eugene Platonov, Patrick Doyle, Tim van der Lippe, dependabot[bot] Make vararg checks Scala friendly (for mockito-scala) [(https://redirect.github.com/mockito/mockito/issues/3651";>#3651)](https://redirect.github.com/mockito/mockito/pull/3651";>mockito/mockito#3651) For UnfinishedStubbingException, suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3636";>#3636)](https://redirect.github.com/mockito/mockito/pull/3636";>mockito/mockito#3636) UnfinishedStubbingException ought to suggest the possibility of another thread [(https://redirect.github.com/mockito/mockito/issues/3635";>#3635)](https://redirect.github.com/mockito/mockito/issues/3635";>mockito/mockito#3635) v5.17.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 5.17.0 2025-04-04 - https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>7 commit(s) by Adrian Roos, Andre Kurait, Jan Ouwens, Rafael Winterhalter, Taeik Lim, Thach Le, Tim van der Lippe Fixes https://redirect.github.com/mockito/mockito/issues/3631";>#3631: Fix broken banner image link [(https://redirect.github.com/mockito/mockito/issues/3632";>#3632)](https://redirect.github.com/mockito/mockito/pull/3632";>mockito/mockito#3632) Banner image is broken [(https://redirect.github.com/mockito/mockito/issues/3631";>#3631)](https://redirect.github.com/mockito/mockito/issues/3631";>mockito/mockito#3631) Update exception message with mockito-inline [(https://redirect.github.com/mockito/mockito/issues/3628";>#3628)](https://redirect.github.com/mockito/mockito/pull/3628";>mockito/mockito#3628) Clarify structure of commit messages [(https://redirect.github.com/mockito/mockito/issues/3626";>#3626)](https://redirect.github.com/mockito/mockito/pull/3626";>mockito/mockito#3626) Fixes https://redirect.github.com/mockito/mockito/issues/3622";>#3622: MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3623";>#3623)](https://redirect.github.com/mockito/mockito/pull/3623";>mockito/mockito#3623) MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3622";>#3622)](https://redirect.github.com/mockito/mockito/issues/3622";>mockito/mockito#3622) Since mockito-inline has been removed, the exception messages with mockito-inline should be modified. [(https://redirect.github.com/mockito/mockito/issues/3621";>#3621)](https://redirect.github.com/mockito/mockito/issues/3621";>mockito/mockito#3621) Fixes https://redirect.github.com/mockito/mockito/issues/3171";>#3171: Fall back to Throwable Location strategy on Android [(https://redirect.github.com/mockito/mockito/issues/3619";>#3619)](https://redirect.github.com/mockito/mockito/pull/3619";>mockito/mockito#3619) Fixes https://redirect.github.com/mockito/mockito/issues/3615";>#3615 : broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3616";>#3616)](https://redirect.github.com/mockito/mockito/pull/3616";>mockito/mockito#3616) Broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3615";>#3615)](https://redirect.github.com/mockito/mockito/issues/3615";>mockito/mockito#3615) Mocks are not working on particular devices after update Android SDK from 33 to 34 [(https://redirect.github.com/mockito/mockito/issues/3171";>#3171)](https://redirect.github.com/mockito/mockito/issues/3171";>mockito/mockito#3171) Commits https://github.com/mockito/mockito/commit/06737471ea19ca023581351eeac778ffbce8da74";>0673747 Force Jacoco version for Android https://github.com/mockito/mockito/commit/65388f01eb8a555c4df5dec692ba9abf8a2591b8";>65388f0 Update Jacoco version to 0.8.13 https://github.com/mockito/mockito/commit/60179ca10dbd29ff959d7eae670ce95b3f19f5fd";>60179ca Bump bytebuddy from 1.15.11 to 1.16.1 https://github.com/mockito/mockito/commit/8f15169774cb639b5757f121f27d6c0d8ca18c97";>8f15169 Make vararg checks Scala friendly (https://redirect.github.com/mockito/mockito/issues/3651";>#3651) https://github.com/mockito/mockito/commit/3a631cb87082fff212bc00c00970508b4ce63072";>3a631cb Add hint for multithreading in UnfinishedStubbingException (https://redirect.github.com/mockito/mockito/issues/3636";>#3636) https://github.com/mockito/m
Re: [PR] Bump mockitoVersion from 5.16.1 to 5.17.0 [maven-filtering]
dependabot[bot] closed pull request #149: Bump mockitoVersion from 5.16.1 to 5.17.0 URL: https://github.com/apache/maven-filtering/pull/149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mockitoVersion from 5.16.1 to 5.17.0 [maven-filtering]
dependabot[bot] commented on PR #149: URL: https://github.com/apache/maven-filtering/pull/149#issuecomment-2898689868 Superseded by #156. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953211#comment-17953211
]
Lenny Primak commented on MNG-8735:
---
Actual issue is in EclipseLink:
org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
The EclipseLink POM uses a variable "sonatypeOssDistMgmtStagingUrl" in
which is undefined, and cannot be inherited from the parent ee4j
POM, since resolver will not successfully look it up because
section is processed before by maven
Repository section should be removed by EclipseLink (or not use variables from
parent) and that will solve the issue
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953212#comment-17953212
]
Piotr Zygielo commented on MNG-8735:
{quote}Actual issue is in EclipseLink:
{quote}
If it is, I guess the issue in
[https://github.com/eclipse-ee4j/eclipselink/issues] would be helpful, as I
don't think EL team monitors MNG.
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953213#comment-17953213
]
Lenny Primak commented on MNG-8735:
---
Yes, that is my next step. I'll file the issue
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8733) mvnenc command not producing any output
[
https://issues.apache.org/jira/browse/MNG-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953122#comment-17953122
]
Guillaume Nodet commented on MNG-8733:
--
Upgrading to JLine 3.30.3 will fix the problem.
> mvnenc command not producing any output
> ---
>
> Key: MNG-8733
> URL: https://issues.apache.org/jira/browse/MNG-8733
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-rc-3
> Environment: Java 21 and 24
>Reporter: Lenny Primak
>Assignee: Guillaume Nodet
>Priority: Minor
>
> Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
> just exits with nothing returned. Looks like it succeeds.
> When using -X parameter to the command, I can see the output along with the
> debug information.
> Using mvnenc with mvnsh works correctly.
>
> {code:java}
> % mvnenc encrypt
> Enter the password to encrypt:
> % {code}
> {code:java}
> % mvnenc diag
> [INFO] Configuration validation of MavenSecDispatcher: VALID
> [INFO] Configuration file present on path
> /Users/software/.m2/settings-security4.xml
> [INFO] Default dispatcher configured
> [INFO] Configured default dispatcher configuration is valid
> [INFO] Legacy dispatcher present in system
> [INFO] Legacy dispatcher is operational; transparent fallback possible
> [INFO] Configuration validation of MasterDispatcher: VALID
> [INFO] Configured Cipher supported
> [INFO] Configured Source configuration valid
> [INFO] Configuration validation of EnvMasterSource: VALID
> [INFO] Configured environment variable exist
> [INFO] Configuration validation of LegacyDispatcher: VALID
> [INFO] Legacy configuration found with encrypted master password
> [INFO] Legacy master password successfully decrypted
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MNG-8733) mvnenc command not producing any output
[
https://issues.apache.org/jira/browse/MNG-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8733:
Assignee: Guillaume Nodet
> mvnenc command not producing any output
> ---
>
> Key: MNG-8733
> URL: https://issues.apache.org/jira/browse/MNG-8733
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 4.0.0-rc-3
> Environment: Java 21 and 24
>Reporter: Lenny Primak
>Assignee: Guillaume Nodet
>Priority: Minor
>
> Neither {{mvnenc encrypt}} nor {{mvnenc decrypt}} produce any output. Command
> just exits with nothing returned. Looks like it succeeds.
> When using -X parameter to the command, I can see the output along with the
> debug information.
> Using mvnenc with mvnsh works correctly.
>
> {code:java}
> % mvnenc encrypt
> Enter the password to encrypt:
> % {code}
> {code:java}
> % mvnenc diag
> [INFO] Configuration validation of MavenSecDispatcher: VALID
> [INFO] Configuration file present on path
> /Users/software/.m2/settings-security4.xml
> [INFO] Default dispatcher configured
> [INFO] Configured default dispatcher configuration is valid
> [INFO] Legacy dispatcher present in system
> [INFO] Legacy dispatcher is operational; transparent fallback possible
> [INFO] Configuration validation of MasterDispatcher: VALID
> [INFO] Configured Cipher supported
> [INFO] Configured Source configuration valid
> [INFO] Configuration validation of EnvMasterSource: VALID
> [INFO] Configured environment variable exist
> [INFO] Configuration validation of LegacyDispatcher: VALID
> [INFO] Legacy configuration found with encrypted master password
> [INFO] Legacy master password successfully decrypted
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [ARCHETYPE-548] Resource files without extension missing in create-from-project [maven-archetype]
Harry-Pootha opened a new pull request, #273: URL: https://github.com/apache/maven-archetype/pull/273 - Fixes resource files without extension not being included in mvn archetype:create-from-project - Added integration test for resource file without extension In [ARCHETYPE-548](https://issues.apache.org/jira/browse/ARCHETYPE-548) and [ARCHETYPE-499](https://issues.apache.org/jira/browse/ARCHETYPE-499) it is described how archetypes generated with `mvn archetype:create-from-project` do not include resource files without file extensions. We ran into the same issue with Dockerfile, as did others. This PR generates a `` (e.g. `**/Dockerfile`) for files without extension. In addition the `**/*.`, which was added in case of an empty extension has been removed for this case. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [~] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - [x] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.mockito:mockito-core from 5.17.0 to 5.18.0 [maven-plugin-testing]
Bukama merged PR #101: URL: https://github.com/apache/maven-plugin-testing/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.eclipse.sisu:org.eclipse.sisu.plexus from 0.9.0.M3 to 0.9.0.M4 [maven-ear-plugin]
Bukama merged PR #137: URL: https://github.com/apache/maven-ear-plugin/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Update README.md [maven-plugin-testing]
abdo20898 opened a new pull request, #102: URL: https://github.com/apache/maven-plugin-testing/pull/102 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Your pull request should address just one issue, without pulling in other changes. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: Simplify immutable collections implementation by using standard Java APIs [maven]
Bukama commented on code in PR #2363:
URL: https://github.com/apache/maven/pull/2363#discussion_r2100460591
##
src/mdo/java/ImmutableCollections.java:
##
@@ -79,32 +65,7 @@ public int size() {
};
static List copy(Collection collection) {
-if (collection == null) {
-return emptyList();
-} else if (collection instanceof AbstractImmutableList) {
-return (List) collection;
-} else {
-switch (collection.size()) {
-case 0:
-return emptyList();
-case 1:
-return singletonList(collection.iterator().next());
-case 2:
-Iterator it = collection.iterator();
-return new List2<>(it.next(), it.next());
-default:
-return new ListN<>(collection);
-}
-}
-}
-
-@SuppressWarnings("unchecked")
-static List emptyList() {
-return (List) EMPTY_LIST;
-}
-
-static List singletonList(E element) {
-return new List1<>(element);
+return collection == null ? List.of() : List.copyOf(collection);
Review Comment:
Why not `Collections.emptyList()`? Does the empty list needs to be mutable?
The classname (`ImmutableCollections.java`) says no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] chore: Simplify immutable collections implementation by using standard Java APIs [maven]
Bukama commented on code in PR #2363:
URL: https://github.com/apache/maven/pull/2363#discussion_r2100460591
##
src/mdo/java/ImmutableCollections.java:
##
@@ -79,32 +65,7 @@ public int size() {
};
static List copy(Collection collection) {
-if (collection == null) {
-return emptyList();
-} else if (collection instanceof AbstractImmutableList) {
-return (List) collection;
-} else {
-switch (collection.size()) {
-case 0:
-return emptyList();
-case 1:
-return singletonList(collection.iterator().next());
-case 2:
-Iterator it = collection.iterator();
-return new List2<>(it.next(), it.next());
-default:
-return new ListN<>(collection);
-}
-}
-}
-
-@SuppressWarnings("unchecked")
-static List emptyList() {
-return (List) EMPTY_LIST;
-}
-
-static List singletonList(E element) {
-return new List1<>(element);
+return collection == null ? List.of() : List.copyOf(collection);
Review Comment:
Why not `Collections.emptyList()`? Does the empty list needs to be mutable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-8736) Incorrect profile activation for multi-module concurrent build
[
https://issues.apache.org/jira/browse/MNG-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mateusz Gajewski updated MNG-8736:
--
Attachment: debug.log
> Incorrect profile activation for multi-module concurrent build
> --
>
> Key: MNG-8736
> URL: https://issues.apache.org/jira/browse/MNG-8736
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Mateusz Gajewski
>Priority: Major
> Attachments: debug.log
>
>
> This happens on: *4.0.0-rc3*
> Doesn't happen on: *3.9.9*
> {*}Parent pom{*}:
> https://github.com/airlift/airbase/blob/master/airbase/pom.xml#L1747
> In our base pom we have a profile with activation based on the existence of
> the file in the project module ({{{}.build-airlift{}}}). While building
> project concurrently under maven 4.0.0-rc3, the profile is activated for
> module lacking {{.build-airlift}} file (which is signaled by the enforcer
> maven plugin that checks for the existence of the main-class property).
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-8736) Incorrect profile activation for multi-module concurrent build
[
https://issues.apache.org/jira/browse/MNG-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953182#comment-17953182
]
Mateusz Gajewski edited comment on MNG-8736 at 5/21/25 2:36 PM:
It also fails from to time while building a single module of the multi-module
project. Attaching build logs. As you can see the maven-enforcer-plugin
configuration contains an invalid rule {{requireProperty}} . The interesting
part is that {{help:effective-pom}} sometimes outputs this rule too.
was (Author: JIRAUSER290474):
It also fails from to time while building a single module of the multi-module
project. Attaching build logs. As you can see the maven-enforcer-plugin
configuration contains an invalid rule {{requireProperty}} . The interesting
part is that {{help:effective-pom}} never outputs this rule.
> Incorrect profile activation for multi-module concurrent build
> --
>
> Key: MNG-8736
> URL: https://issues.apache.org/jira/browse/MNG-8736
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Mateusz Gajewski
>Priority: Major
> Attachments: debug.log
>
>
> This happens on: *4.0.0-rc3*
> Doesn't happen on: *3.9.9*
> {*}Parent pom{*}:
> https://github.com/airlift/airbase/blob/master/airbase/pom.xml#L1747
> In our base pom we have a profile with activation based on the existence of
> the file in the project module ({{{}.build-airlift{}}}). While building
> project concurrently under maven 4.0.0-rc3, the profile is activated for
> module lacking {{.build-airlift}} file (which is signaled by the enforcer
> maven plugin that checks for the existence of the main-class property).
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8736) Incorrect profile activation for multi-module concurrent build
[
https://issues.apache.org/jira/browse/MNG-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953182#comment-17953182
]
Mateusz Gajewski commented on MNG-8736:
---
It also fails from to time while building a single module of the multi-module
project. Attaching build logs. As you can see the maven-enforcer-plugin
configuration contains an invalid rule {{requireProperty}} . The interesting
part is that {{help:effective-pom}} never outputs this rule.
> Incorrect profile activation for multi-module concurrent build
> --
>
> Key: MNG-8736
> URL: https://issues.apache.org/jira/browse/MNG-8736
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Mateusz Gajewski
>Priority: Major
> Attachments: debug.log
>
>
> This happens on: *4.0.0-rc3*
> Doesn't happen on: *3.9.9*
> {*}Parent pom{*}:
> https://github.com/airlift/airbase/blob/master/airbase/pom.xml#L1747
> In our base pom we have a profile with activation based on the existence of
> the file in the project module ({{{}.build-airlift{}}}). While building
> project concurrently under maven 4.0.0-rc3, the profile is activated for
> module lacking {{.build-airlift}} file (which is signaled by the enforcer
> maven plugin that checks for the existence of the main-class property).
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-8736) Incorrect profile activation for multi-module concurrent build
Mateusz Gajewski created MNG-8736:
-
Summary: Incorrect profile activation for multi-module concurrent
build
Key: MNG-8736
URL: https://issues.apache.org/jira/browse/MNG-8736
Project: Maven
Issue Type: Bug
Components: Core
Affects Versions: 4.0.0-rc-3
Reporter: Mateusz Gajewski
This happens on: *4.0.0-rc3*
Doesn't happen on: *3.9.9*
{*}Parent pom{*}:
https://github.com/airlift/airbase/blob/master/airbase/pom.xml#L1747
In our base pom we have a profile with activation based on the existence of the
file in the project module ({{{}.build-airlift{}}}). While building project
concurrently under maven 4.0.0-rc3, the profile is activated for module lacking
{{.build-airlift}} file (which is signaled by the enforcer maven plugin that
checks for the existence of the main-class property).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] chore: Simplify immutable collections implementation by using standard Java APIs [maven]
gnodet commented on code in PR #2363:
URL: https://github.com/apache/maven/pull/2363#discussion_r2100473936
##
src/mdo/java/ImmutableCollections.java:
##
@@ -79,32 +65,7 @@ public int size() {
};
static List copy(Collection collection) {
-if (collection == null) {
-return emptyList();
-} else if (collection instanceof AbstractImmutableList) {
-return (List) collection;
-} else {
-switch (collection.size()) {
-case 0:
-return emptyList();
-case 1:
-return singletonList(collection.iterator().next());
-case 2:
-Iterator it = collection.iterator();
-return new List2<>(it.next(), it.next());
-default:
-return new ListN<>(collection);
-}
-}
-}
-
-@SuppressWarnings("unchecked")
-static List emptyList() {
-return (List) EMPTY_LIST;
-}
-
-static List singletonList(E element) {
-return new List1<>(element);
+return collection == null ? List.of() : List.copyOf(collection);
Review Comment:
List.of() also returns an immutable list (although not the same objectas
Collections.emptyList()).
It's a more concise form, and I think the best practice will be to use
List.of() and Map.of() instead of the similar methods from Collections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Update README.md [maven-plugin-testing]
Bukama closed pull request #102: Update README.md URL: https://github.com/apache/maven-plugin-testing/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Don't use empty string as an attached artifact classifier [maven-gpg-plugin]
bstansberry opened a new pull request, #135: URL: https://github.com/apache/maven-gpg-plugin/pull/135 The algorithm GpgSignAttachedMojo follows to attach signed artifacts results in attachments with the empty string as the classifier if the classifier of the artifact that was signed was null. This happens with 'attached' artifacts (MavenProject.getAttachedArtifacts()), not with the 'main' artifact for the project (MavenProject.getArtifact()). We've observed other plugins having problems with attachments with the empty string classifier, so this PR proposes detecting this and using null instead. The plugin where we observed this was Sonatype's nxrm3-maven-plugin, whose deploy or staging-deploy goals fail when processing these 'empty' string artifacts. They have validation logic that rejects the empty string. I've attempted to report this to Sonatype, suggesting they check for and avoid this problem. In case they don't, the fix here may help maven-gpg-plugin users who are migrating to Nexus 3. If you decide not to worry about this and leave it to the Sonatype plugin to fix, I won't be offended. :) One way to create a project that will exhibit this behavior is to use the maven-assembly-plugin in the project and set its appendAssemblyId setting to false. That setting causes the plugin to attach its assembly using a null classifier. The maven-gpg-plugin then attaches an asc file with an empty string as its classifier. I imagine this may be a fairly common pattern in projects that are meant to produce something other than a jar/ear/war/rar. In our case we use it to produce zips. Note that perhaps the correction for this should be in the FilesCollector.Item constructor. That's a public class though so I didn't want to change its behavior. The only use of Item is in GpgSignAttachedMojo though, so it should be safe to change. If you're interested in fixing this I'd be happy to change this PR to do it that way, if you want. Following this checklist to help us incorporate your contribution quickly and easily: - [ X] Your pull request should address just one issue, without pulling in other changes. - [ X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X ] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. Not really practical. - [X ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ X] You have run the integration tests successfully (`mvn -Prun-its verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953217#comment-17953217
]
Lenny Primak commented on MNG-8735:
---
I'm going to close this issue since it's scope is much narrower and it's
EclipseLink that needs the fix.
There is a workaround and it's mvn package -DsonatypeOssDistMgmtStagingUrl=xxx
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8735) Resolver incorrectly thinks a version is a range
[
https://issues.apache.org/jira/browse/MNG-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17953218#comment-17953218
]
Lenny Primak commented on MNG-8735:
---
Actually, [~cstamas] can you close this issue as I can't. Thanks!
> Resolver incorrectly thinks a version is a range
>
>
> Key: MNG-8735
> URL: https://issues.apache.org/jira/browse/MNG-8735
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Lenny Primak
>Priority: Blocker
>
> This is for the latest master build of maven. Maven 4-rc-3 works fine.
> During resolution of transitive dependencies, it looks like maven thinks
> there is a version range, when there is not and fails the build:
> {code:java}
> % mvn package
> ...
> [ERROR] Failed to execute goal on project flowlogix-jee: Could not collect
> dependencies for project com.flowlogix:flowlogix-jee:jar:9.x-SNAPSHOT
> [ERROR] java.lang.IllegalArgumentException: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] Caused by: Invalid Version Range Request:
> org.eclipse.ee4j:project:pom:1.0.9 < [central
> (https://repo.maven.apache.org/maven2, default, releases),
> sonatype-nexus-staging (${sonatypeOssDistMgmtStagingUrl}, default, releases)]
> [ERROR] : Failed to collect dependencies at
> org.eclipse.persistence:org.eclipse.persistence.jpa.modelgen.processor:jar:4.0.6
> {code}
> To reproduce:
> * Clone [https://github.com/flowlogix/flowlogix]
> * mvn package
> You will see the error
>
> {code:java}
> % mvn -v
> Apache Maven 4.0.0-rc-4-SNAPSHOT (96efadee470ff1d39f51848e3d23f338f67b17d6)
> Maven home:
> /Users/lprimak/Applications/maven/apache-maven-4.0.0-rc-4-20250520.132857
> Java version: 24.0.1, vendor: Azul Systems, Inc., runtime:
> /Users/lprimak/.sdkman/candidates/java/24.0.1.fx-zulu/zulu-24.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "15.5", arch: "aarch64", family: "mac"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] fix missing test assertion [maven]
Pankraz76 opened a new pull request, #2365: URL: https://github.com/apache/maven/pull/2365 - - https://github.com/apache/maven/pull/2364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
