slawekjaranowski commented on code in PR #2171:
URL: https://github.com/apache/maven/pull/2171#discussion_r2007273299
##
apache-maven/src/bin/mvn:
##
@@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR
MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@"
export MAVEN_CMD_LINE_ARGS
+# MNG-8248
+ENABLE_NATIVE_ACCESS=""
+if "$JAVACMD" --enable-native-access=ALL-UNNAMED -version >/dev/null 2>&1; then
Review Comment:
here we check if we can use it ... it is available for JDK 17+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Bukama commented on PR #739:
URL: https://github.com/apache/maven-site/pull/739#issuecomment-274375
> Please also change the mvnd 2.x links
oh sure. Didn't pay attention to those. Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
elharo opened a new pull request, #2210:
URL: https://github.com/apache/maven/pull/2210
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
dependabot[bot] opened a new pull request, #258:
URL: https://github.com/apache/maven-archetype/pull/258
Bumps
[org.apache.maven:maven-parent](https://github.com/apache/maven-parent) from 43
to 44.
Release notes
Sourced from https://github.com/apache/maven-parent/releases";>org.apache.maven:maven-parent's
releases.
44
:boom: Breaking changes
Move snapshot repositories in a profile (https://redirect.github.com/apache/maven-parent/pull/451";>#451) https://github.com/slawekjaranowski";>@slawekjaranowski
Check test code by checkstyle (https://redirect.github.com/apache/maven-parent/pull/228";>#228) https://github.com/slawekjaranowski";>@slawekjaranowski
🚀 New features and improvements
Move snapshot repositories in a profile (https://redirect.github.com/apache/maven-parent/pull/451";>#451) https://github.com/slawekjaranowski";>@slawekjaranowski
Introduce property maven.site.path.suffix to allow override site path
(https://redirect.github.com/apache/maven-parent/pull/239";>#239)
https://github.com/slawekjaranowski";>@slawekjaranowski
Use v@{project.version} as tag template for releases (https://redirect.github.com/apache/maven-parent/pull/455";>#455) https://github.com/slawekjaranowski";>@slawekjaranowski
import KEYS history from svn (https://redirect.github.com/apache/maven-parent/pull/240";>#240) https://github.com/hboutemy";>@hboutemy
Add licenseText to modello (https://redirect.github.com/apache/maven-parent/pull/241";>#241) https://github.com/slawekjaranowski";>@slawekjaranowski
Update site descriptor to 2.0 (https://redirect.github.com/apache/maven-parent/pull/232";>#232) https://github.com/slawekjaranowski";>@slawekjaranowski
Check test code by checkstyle (https://redirect.github.com/apache/maven-parent/pull/228";>#228) https://github.com/slawekjaranowski";>@slawekjaranowski
Add issues templates (https://redirect.github.com/apache/maven-parent/pull/226";>#226) https://github.com/slawekjaranowski";>@slawekjaranowski
Accept all line endings with spotless (https://redirect.github.com/apache/maven-parent/pull/217";>#217) https://github.com/kwin";>@kwin
Enable automatic formatter when not on CI (https://redirect.github.com/apache/maven-parent/pull/215";>#215) https://github.com/gnodet";>@gnodet
Bump com.diffplug.spotless:spotless-maven-plugin to enable the
sortpom/quiet option (https://redirect.github.com/apache/maven-parent/pull/213";>#213) https://github.com/gnodet";>@gnodet
🐛 Bug Fixes
Fix asf.yaml syntax (https://redirect.github.com/apache/maven-parent/pull/459";>#459) https://github.com/slawekjaranowski";>@slawekjaranowski
📦 Dependency updates
Bump parent to 34 (https://redirect.github.com/apache/maven-parent/pull/461";>#461) https://github.com/slawekjaranowski";>@slawekjaranowski
Bump org.junit:junit-bom from 5.12.0 to 5.12.1 (https://redirect.github.com/apache/maven-parent/pull/460";>#460) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.junit:junit-bom from 5.11.4 to 5.12.0 (https://redirect.github.com/apache/maven-parent/pull/236";>#236) @https://github.com/apps/dependabot";>dependabot[bot]
Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.2 to 2.44.3
(https://redirect.github.com/apache/maven-parent/pull/234";>#234)
@https://github.com/apps/dependabot";>dependabot[bot]
Bump org.codehaus.mojo:taglist-maven-plugin from 3.1.0 to 3.2.1 (https://redirect.github.com/apache/maven-parent/pull/208";>#208) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.codehaus.mojo:extra-enforcer-rules from 1.8.0 to 1.9.0 (https://redirect.github.com/apache/maven-parent/pull/201";>#201) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.apache.maven.plugins:maven-jxr-plugin from 3.4.0 to 3.6.0 (https://redirect.github.com/apache/maven-parent/pull/210";>#210) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.apache.maven.plugins:maven-pmd-plugin from 3.23.0 to 3.26.0 (https://redirect.github.com/apache/maven-parent/pull/211";>#211) @https://github.com/apps/dependabot";>dependabot[bot]
Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.0.BETA4 to
2.44.2 (https://redirect.github.com/apache/maven-parent/pull/229";>#229) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.junit:junit-bom from 5.11.3 to 5.11.4 (https://redirect.github.com/apache/maven-parent/pull/219";>#219) @https://github.com/apps/dependabot";>dependabot[bot]
https://issues.apache.org/jira/browse/MNG-8453";>[MNG-8453]
- Check dependency declarations by default (https://redirect.github.com/apache/maven-parent/pull/220";>#220) https://github.com/elharo";>@elharo
Bump org.codehaus.plexus:plexus-utils from 4.0.1 to 4.0.2 (https://redirect.github.com/apache/maven-parent/pull/202";>#202) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.cyclonedx:cyclonedx-maven-plugin from 2.9.0 to 2.9.1 (https://redirec
jira-importer commented on issue #166:
URL:
https://github.com/apache/maven-deploy-plugin/issues/166#issuecomment-2771511808
**[Robert
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
commented
Fixed in [r1422245](http://svn.apache.org/viewvc?rev=1422245&view=rev)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #161:
URL:
https://github.com/apache/maven-deploy-plugin/issues/161#issuecomment-2771511405
**[Robert
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
commented
This is most likely a Maven core issue. Which version was used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #161:
URL:
https://github.com/apache/maven-deploy-plugin/issues/161#issuecomment-2771511410
**[Manfred
Schürhoff](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=manfredjs)**
commented
We also used version 2.2.1 of Maven.
But since I reported this issue a lot of configuration has changed and we
are currently using maven 3.0.4.
I'm not aware that this is still a problem for us now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #210:
URL:
https://github.com/apache/maven-deploy-plugin/issues/210#issuecomment-2771515337
**[Allan Q.
Ramirez](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aramirez)**
commented
for review.. not sure if i got it right :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #161:
URL:
https://github.com/apache/maven-deploy-plugin/issues/161#issuecomment-2771511417
**[Robert
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
commented
Upgrading to a more recent version of Maven seems to be the solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
fslevoaca-ionos commented on PR #815:
URL: https://github.com/apache/maven-surefire/pull/815#issuecomment-2765804867
> > Failed tests are no longer displayed inside
`target/surefire-reports/report.txt/xml` Possible the fix for current issue
would have introduced this critical regression bug inside maven-surefire 3.5.3.
>
> please create another issue with a reproducer.
Problem is that I do not have the right to open issues inside
https://github.com/apache/maven-surefire
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/SUREFIRE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940092#comment-17940092
]
Pavlo Shevchenko commented on SUREFIRE-2298:
This change also breaks the reporting of Cucumber tests.
Steps to reproduce:
# Set up the sample Cucumber project using "cucumber-archetype"
([ref|https://cucumber.io/docs/guides/10-minute-tutorial/#create-an-empty-cucumber-project]):
# For Surefire 3.5.2, the console output will be:
{code:java}
[INFO] Running hellocucumber.RunCucumberTestScenario: The example
# hellocucumber/example.feature:3
Given an example scenario #
hellocucumber.StepDefinitions.anExampleScenario()
When all step definitions are implemented #
hellocucumber.StepDefinitions.allStepDefinitionsAreImplemented()
Then the scenario passes #
hellocucumber.StepDefinitions.theScenarioPasses()
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.065 s
-- in hellocucumber.RunCucumberTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 {code}
, and the XML report ("TEST-hellocucumber.RunCucumberTest.xml") will contain a
single test case:
{code:java}
{code}
# With Surefire 3.5.3, on the other hand, the output will say that no tests
were run:
{code:java}
[INFO] Running hellocucumber.RunCucumberTestScenario: The example
# hellocucumber/example.feature:3
Given an example scenario #
hellocucumber.StepDefinitions.anExampleScenario()
When all step definitions are implemented #
hellocucumber.StepDefinitions.allStepDefinitionsAreImplemented()
Then the scenario passes #
hellocucumber.StepDefinitions.theScenarioPasses()
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.078 s
-- in hellocucumber.RunCucumberTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 {code}
, and the XML report will contain no test cases.
> @Nested test classes are not reported properly
> --
>
> Key: SUREFIRE-2298
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2298
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Leonard Brünings
>Priority: Major
>
> Given this example test you can see that the {{@Nested}} test classes are not
> reported correctly. In 3.5.2 and earlier all executions land in the
> {{TEST-BaseNestedTest$Inner.xml}} and with the changes in 3.5.3 they are
> distributed in all files. However, the nested classes belong to the enclosing
> class and the reporting should reflect that, so it would be more accurate to
> report the nested executions as part of the enclosing tests (see below).
> [~marcphilipp] please chime in.
>
> {code:java}
> import org.junit.jupiter.api.*;
> abstract class BaseNestedTest {
> @Test
> void outerTest() {
> }
>
> @Nested
> class Inner {
> @Test
> void innerTest() {
> }
> }
> }
> class FirstNestedTest extends BaseNestedTest {
> }
> class SecondNestedTest extends BaseNestedTest {
> }{code}
> This was most likely caused by
> [https://github.com/apache/maven-surefire/commit/5aeca19716dedc4cbcab8d68dfc74a99f50ce9ee]
> 3.5.2
> {code:java|title=TEST-FirstNestedTest.xml}
>
> http://www.w3.org/2001/XMLSchema-instance";
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd";
> version="3.0.2" name="FirstNestedTest" time="0.019" tests="0" errors="0"
> skipped="0" failures="0">
>
> {code}
> {code:java|title=TEST-SecondNestedTest.xml}
>
> http://www.w3.org/2001/XMLSchema-instance";
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd";
> version="3.0.2" name="SecondNestedTest" time="0.004" tests="0" errors="0"
> skipped="0" failures="0">
>
> {code}
> {code:java|title=TEST-BaseNestedTest$Inner.xml}
>
> http://www.w3.org/2001/XMLSchema-instance";
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd";
> version="3.0.2" name="BaseNestedTest$Inner" time="0.001" tests="2"
> errors="0" skipped="0" failures="0">
>
>
>
>
>
> {code}
> ---
> 3.5.3
> {code:java|title=TEST-FirstNestedTest.xml}
>
> http://www.w3.org/2001/XMLSchema-instance";
> xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd";
> version="3.0.2" name="FirstNestedTest" time="0.019" tests="1" errors="0"
> skipped="0" failures="0">
>
>
> {code}
> {code:java|title=TEST-SecondNestedTest.xml}
>
> http://www.w3.org/2001/XMLSchema-instance";
> xsi:noNamespac
Bukama opened a new pull request, #752:
URL: https://github.com/apache/maven-site/pull/752
Also small rephrasing to the recommendation to not use clean install for
regular builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
manolo commented on PR #37:
URL: https://github.com/apache/maven-help-plugin/pull/37#issuecomment-2777913931
any ETA for this to be available soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MPH-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940904#comment-17940904
]
ASF GitHub Bot commented on MPH-183:
manolo commented on PR #37:
URL: https://github.com/apache/maven-help-plugin/pull/37#issuecomment-2777913931
any ETA for this to be available soon?
> Effective-pom + verbose should show import path to BOM dependencyManagement
> ---
>
> Key: MPH-183
> URL: https://issues.apache.org/jira/browse/MPH-183
> Project: Maven Help Plugin
> Issue Type: Improvement
>Affects Versions: 3.2.0
>Reporter: Robert Scholte
>Assignee: Maarten Mulders
>Priority: Major
> Attachments: mph-183-it.zip
>
>
> The popular spring-boot makes a lot of use of BOMs. Using BOMs is a good
> practice, but right now it is very hard to determine where
> dependencyManagement dependencies and especially their versions are coming
> from.
> Instead of only showing only the final location (from the BOM POM), it should
> also show the import path from the current project to that specific pom
> (where is the BOM POM imported?).
> This way it will be easier to figure out which dependency in which POM needs
> to be upgraded: it's the version in the POM declaring the import of the BOM
> POM, not the version in the imported BOM POM.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
gnodet closed pull request #2235: Create Temp pull
URL: https://github.com/apache/maven/pull/2235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
olamy opened a new pull request, #828:
URL: https://github.com/apache/maven-surefire/pull/828
Signed-off-by: Olivier Lamy
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
marcphilipp commented on code in PR #828:
URL: https://github.com/apache/maven-surefire/pull/828#discussion_r2028462236
##
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire2298IT.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.surefire.its.jiras;
+
+import org.apache.maven.surefire.its.fixture.OutputValidator;
+import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase;
+import org.apache.maven.surefire.its.fixture.TestFile;
+import org.hamcrest.collection.IsIterableWithSize;
+import org.junit.Test;
+import org.w3c.dom.Node;
+import org.xmlunit.builder.Input;
+import org.xmlunit.xpath.JAXPXPathEngine;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+
+/**
+ *
+ */
+@SuppressWarnings("checkstyle:magicnumber")
+public class Surefire2298IT extends SurefireJUnit4IntegrationTestCase {
+@Test
+public void shouldNotCreateFilesForNested() throws Exception {
+OutputValidator outputValidator = unpack("surefire-2298-nested-class")
+.maven()
+.executeTest()
+.verifyTextInLog("BUILD SUCCESS")
+.assertTestSuiteResults(4, 0, 0, 0);
+
+outputValidator
+.getSurefireReportsXmlFile("io.olamy.BaseNestedTest$Inner.txt")
+.assertFileNotExists();
+
+TestFile xmlReportFile =
outputValidator.getSurefireReportsXmlFile("TEST-io.olamy.FirstNestedTest.xml");
+xmlReportFile.assertFileExists();
+
+/**
+ *
+ *
+ *
+ *
+ **/
+Iterable ite = new JAXPXPathEngine()
+.selectNodes(
+"//testcase",
Input.fromFile(xmlReportFile.getFile()).build());
+assertThat(ite, IsIterableWithSize.iterableWithSize(2));
+ite = new JAXPXPathEngine()
+.selectNodes(
+"//testcase[@classname='FirstNestedTest']",
+Input.fromFile(xmlReportFile.getFile()).build());
+assertThat(ite, IsIterableWithSize.iterableWithSize(1));
+ite = new JAXPXPathEngine()
+.selectNodes(
+"//testcase[@classname='BaseNestedTest$Inner']",
+Input.fromFile(xmlReportFile.getFile()).build());
+assertThat(ite, IsIterableWithSize.iterableWithSize(1));
+
+xmlReportFile =
outputValidator.getSurefireReportsXmlFile("TEST-io.olamy.SecondNestedTest.xml");
+/**
+ *
+ *
+ *
+ *
+ */
Review Comment:
Assertions missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
olamy commented on code in PR #828:
URL: https://github.com/apache/maven-surefire/pull/828#discussion_r2028468255
##
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire2298IT.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.surefire.its.jiras;
+
+import org.apache.maven.surefire.its.fixture.OutputValidator;
+import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase;
+import org.apache.maven.surefire.its.fixture.TestFile;
+import org.hamcrest.collection.IsIterableWithSize;
+import org.junit.Test;
+import org.w3c.dom.Node;
+import org.xmlunit.builder.Input;
+import org.xmlunit.xpath.JAXPXPathEngine;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+
+/**
+ *
+ */
+@SuppressWarnings("checkstyle:magicnumber")
+public class Surefire2298IT extends SurefireJUnit4IntegrationTestCase {
+@Test
+public void shouldNotCreateFilesForNested() throws Exception {
+OutputValidator outputValidator = unpack("surefire-2298-nested-class")
+.maven()
+.executeTest()
+.verifyTextInLog("BUILD SUCCESS")
+.assertTestSuiteResults(4, 0, 0, 0);
+
+outputValidator
+.getSurefireReportsXmlFile("io.olamy.BaseNestedTest$Inner.txt")
+.assertFileNotExists();
+
+TestFile xmlReportFile =
outputValidator.getSurefireReportsXmlFile("TEST-io.olamy.FirstNestedTest.xml");
+xmlReportFile.assertFileExists();
+
+/**
+ *
+ *
+ *
+ *
+ **/
+Iterable ite = new JAXPXPathEngine()
+.selectNodes(
+"//testcase",
Input.fromFile(xmlReportFile.getFile()).build());
+assertThat(ite, IsIterableWithSize.iterableWithSize(2));
+ite = new JAXPXPathEngine()
+.selectNodes(
+"//testcase[@classname='FirstNestedTest']",
+Input.fromFile(xmlReportFile.getFile()).build());
+assertThat(ite, IsIterableWithSize.iterableWithSize(1));
+ite = new JAXPXPathEngine()
+.selectNodes(
+"//testcase[@classname='BaseNestedTest$Inner']",
+Input.fromFile(xmlReportFile.getFile()).build());
+assertThat(ite, IsIterableWithSize.iterableWithSize(1));
+
+xmlReportFile =
outputValidator.getSurefireReportsXmlFile("TEST-io.olamy.SecondNestedTest.xml");
+/**
+ *
+ *
+ *
+ *
+ */
Review Comment:
haha you're too fast :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
marcphilipp commented on code in PR #828:
URL: https://github.com/apache/maven-surefire/pull/828#discussion_r2028694671
##
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java:
##
@@ -216,11 +217,25 @@ private SimpleReportEntry createReportEntry(
String reason,
Integer elapsedTime) {
String[] classMethodName = toClassMethodName(testIdentifier);
-String className = classMethodName[0];
+
+Optional classSegment =
testIdentifier.getUniqueIdObject().getSegments().stream()
+.filter(segment -> "class".equals(segment.getType()))
+.findFirst();
Review Comment:
You shouldn't parse the `UniqueId` because it's considered to be an
implementation detail. Instead, you should use
`testPlan.getParent(testIdentifier)` to find the right level. If this should
only support class-based engines, finding the last one with a `TestSource` of
type `ClassSource` should work. If this should also work for file-based engines
like Cucumber, you might want to use a differeny heuristic instead. Maybe
always use the level immediate below the root (engine descriptor)? If it has a
`ClassSource`, use that; otherwise, use the display name (similar to what
`toClassMethodName` does)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Volkan Yazici created MWRAPPER-161:
--
Summary: Fails to run when executed using `sh`
Key: MWRAPPER-161
URL: https://issues.apache.org/jira/browse/MWRAPPER-161
Project: Maven Wrapper
Issue Type: Bug
Components: Maven Wrapper Scripts
Affects Versions: 3.3.2
Reporter: Volkan Yazici
Several projects don't allow executable files in their version control system
due to platform compatibility concerns. For instance, OpenJDK doesn't allow
executables to be committed in Git repositories[1]. Hence, Maven Wrapper should
be runnable as an argument to `sh`, though it is not:
{code}
sh mvnw
mvnw: 109: cannot open mvnw/.mvn/wrapper/maven-wrapper.properties: No such file
{code}
due to the following line:
{code}
"${0%/*}/.mvn/wrapper/maven-wrapper.properties"
{code}
I expect there to be more issues due to `$0` usage assuming the script is
executed as an executable – did not check.
[1] See the `Executable files are not allowed (file: mvnw)` error generated by
the Skara bot of OpenJDK in this PR attempting to integrate Maven Wrapper to
JMH: https://github.com/openjdk/jmh/pull/154
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MNG-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940890#comment-17940890
]
Alexis Tual commented on MNG-8672:
--
I've fixed the bug description to reflect what we see in our regression tests.
We don't know if it's a use case or not; we can adapt our tests, but we just
wanted to report this regression.
> Maven 4 CLI substitutes variable when single quoted
> ---
>
> Key: MNG-8672
> URL: https://issues.apache.org/jira/browse/MNG-8672
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Alexis Tual
>Priority: Major
>
> When executing this command line:
>
> {code:java}
> placeholder=foo mvn clean verify '-DsomeProp=${placeholder}'{code}
>
> Then we get:
> - Maven 3: {{someProp}} equals to {{${placeholder}}}
> - Maven 4.0.0-rc-4-SNAPSHOT (5426073a3655278e58f8a4178faae335b1544fc0) :
> {{someProp}} equals to {{foo}}
> The single quote implies the variable should not be substituted, in that
> sense Maven 3 seems to be the correct behavior.
> It's due to this
> [change|https://github.com/apache/maven/commit/335ba3941c2804704ef11598eb512c305045ab58#diff-7338f8ec18a686d67b8ce118f13744dfd6bb26e92b84c73c8043a946a72283fbR241-R262].
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
gnodet opened a new pull request, #2233:
URL: https://github.com/apache/maven/pull/2233
JIRA issue: [MNG-8674](https://issues.apache.org/jira/browse/MNG-8674)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Guillaume Nodet created MNG-8675:
Summary: Correctly deprecate Resource in the model
Key: MNG-8675
URL: https://issues.apache.org/jira/browse/MNG-8675
Project: Maven
Issue Type: Improvement
Components: API
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
Fix For: 4.0.0-rc-4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MNG-8674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8674:
Assignee: Guillaume Nodet
> Get rid of Resource#mergeId which comes from Maven 2 and is not used
>
>
> Key: MNG-8674
> URL: https://issues.apache.org/jira/browse/MNG-8674
> Project: Maven
> Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 4.0.0-rc-4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
desruisseaux commented on issue #321:
URL:
https://github.com/apache/maven-compiler-plugin/issues/321#issuecomment-2777929646
Thanks for the investigation, and thanks for testing the plugin snapshot as
well. Should we close this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028358504
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns an empty list, which means to apply
a language-dependent pattern.
Review Comment:
Proposed new block of comment:
```
/**
* {@return the list of patterns for the files to include}.
* The path separator is {@code /} on all platforms, including Windows.
* The prefix before the {@code :} character, if present, is the syntax.
* If no syntax is specified, the default is a Maven-specific variation
* of the {@code "glob"} pattern.
*
* The default implementation returns an empty list, which means to
apply a language-dependent pattern.
* For example, for the Java language, the default pattern is {@code
"*.java"}.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
gnodet commented on code in PR #1285:
URL: https://github.com/apache/maven-mvnd/pull/1285#discussion_r2028359494
##
build/publish-on-homebrew.sh:
##
@@ -34,6 +34,8 @@
darwinArmZipUrl="https://downloads.apache.org/maven/mvnd/${VERSION}/maven-mvnd-$
darwinArmSha256="$(curl -L --silent "${darwinArmZipUrl}.sha256")"
linuxZipUrl="https://downloads.apache.org/maven/mvnd/${VERSION}/maven-mvnd-${VERSION}-linux-amd64.zip";
Review Comment:
maybe add the `Amd` prefix to keep things aligned ? similar to what we have
for `darwin`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
gnodet merged PR #2226:
URL: https://github.com/apache/maven/pull/2226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MNG-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8637.
Resolution: Fixed
> Pull out "Standalone API" from UTs
> --
>
> Key: MNG-8637
> URL: https://issues.apache.org/jira/browse/MNG-8637
> Project: Maven
> Issue Type: New Feature
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-rc-4
>
>
> We have means to boot Maven in "Standalone API" (ie. "maven without maven")
> to perform mostly Resolver-only tasks. This code is currently in maven-impl
> UTs.
> This code needs to be pulled out and made reusable, as this should become
> "the proper way" to utilize Maven 4 in 'MIMA-like scenarios'.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MNG-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexis Tual updated MNG-8672:
-
Description:
When executing this command line:
{code:java}
placeholder=foo mvn clean verify '-DsomeProp=${placeholder}'{code}
Then we get:
- Maven 3: {{someProp}} equals to {{${placeholder}}}
- Maven 4.0.0-rc-4-SNAPSHOT (5426073a3655278e58f8a4178faae335b1544fc0) :
{{someProp}} equals to {{foo}}
The single quote implies the variable should not be substituted, in that sense
Maven 3 seems to be the correct behavior.
It's due to this
[change|https://github.com/apache/maven/commit/335ba3941c2804704ef11598eb512c305045ab58#diff-7338f8ec18a686d67b8ce118f13744dfd6bb26e92b84c73c8043a946a72283fbR241-R262].
was:
When executing this command line:
{code:java}
placeholder=foo mvn clean verify '-DsomeProp=${placeholder}'{code}
Then we get:
- Maven 3: {{someProp}} equals to an empty string
- Maven 4.0.0-rc-4-SNAPSHOT (5426073a3655278e58f8a4178faae335b1544fc0) :
{{someProp}} equals to {{foo}}
The single quote implies the variable should not be substituted, in that sense
Maven 3 seems to be the correct behavior.
It's due to this
[change|https://github.com/apache/maven/commit/335ba3941c2804704ef11598eb512c305045ab58#diff-7338f8ec18a686d67b8ce118f13744dfd6bb26e92b84c73c8043a946a72283fbR241-R262].
> Maven 4 CLI substitutes variable when single quoted
> ---
>
> Key: MNG-8672
> URL: https://issues.apache.org/jira/browse/MNG-8672
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 4.0.0-rc-4
>Reporter: Alexis Tual
>Priority: Major
>
> When executing this command line:
>
> {code:java}
> placeholder=foo mvn clean verify '-DsomeProp=${placeholder}'{code}
>
> Then we get:
> - Maven 3: {{someProp}} equals to {{${placeholder}}}
> - Maven 4.0.0-rc-4-SNAPSHOT (5426073a3655278e58f8a4178faae335b1544fc0) :
> {{someProp}} equals to {{foo}}
> The single quote implies the variable should not be substituted, in that
> sense Maven 3 seems to be the correct behavior.
> It's due to this
> [change|https://github.com/apache/maven/commit/335ba3941c2804704ef11598eb512c305045ab58#diff-7338f8ec18a686d67b8ce118f13744dfd6bb26e92b84c73c8043a946a72283fbR241-R262].
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MRESOLVER-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MRESOLVER-569:
-
Assignee: Tamas Cservenak
> DependencyCollectionException.getResult().getExceptions() always returns one
> exception
> --
>
> Key: MRESOLVER-569
> URL: https://issues.apache.org/jira/browse/MRESOLVER-569
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Reporter: Slawomir Jaranowski
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.8
>
>
> The problem is when we have more then one repository in configuration.
> We see only exception from last one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
gnodet commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028387183
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns an empty list, which means to apply
a language-dependent pattern.
Review Comment:
What if on windows we have a drive specified ? We need to differentiate:
```
C:/foo/**
```
So maybe rephrase as: `If the pattern does not start with {@code regex:} or
{@code glob:}, the default variation of the {@code glob} pattern will be used.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028395404
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns an empty list, which means to apply
a language-dependent pattern.
Review Comment:
I have not tested how we can specify a Windows drive to
`java.nio.file.FileSystem.getPathMatcher(String)`. I was hopping that, since
all paths are made relative to the base directory before to be tested for
match, the Windows drive issue would be avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
meet1108 opened a new pull request, #2235:
URL: https://github.com/apache/maven/pull/2235
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`,
where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA
issue.
- [ ] Also format the first line of the commit message like `[MNG-XXX]
SUMMARY`.
Best practice is to use the JIRA issue title in both the pull request
title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028405757
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -50,7 +49,7 @@ default Path directory() {
* The default implementation returns an empty list, which means to apply
a language-dependent pattern.
Review Comment:
Just to complete: "glob:" and "regex:" are the two syntaxes that all
`FileSystem` shall support according NIO Javadoc, but a file system may support
others syntaxes as well. It may be nice to avoid a formulation that restrict
the possibilities to those two syntaxes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MNG-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940953#comment-17940953
]
Raghuram commented on MNG-8471:
---
On my Macbook, {{maven-4.0.0-rc2 }}works fine, but {{maven-4.0.0-rc3}} throws
the error.
Maven-3.9.9
{code:java}
~ % mvn --version
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: /usr/local/Cellar/maven/3.9.9/libexec
Java version: 21.0.5, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home
Default locale: en_IN, platform encoding: UTF-8
OS name: "mac os x", version: "15.4", arch: "x86_64", family: "mac" {code}
Maven-4.0.0-rc2
{code:java}
~ % mvn --version
Apache Maven 4.0.0-rc-2 (273314404f85ec3c089e295d8b4e0cb18c287cf5)
Maven home: /Users/raghu/apache-maven-4.0.0-rc-2
Java version: 21.0.5, vendor: Oracle Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home
Default locale: en_IN, platform encoding: UTF-8
OS name: "mac os x", version: "15.4", arch: "x86_64", family: "mac" {code}
Maven-4.0.0-rc3
{code:java}
~ % mvn --version Apr 04, 2025 5:21:41 PM org.jline.nativ.JLineNativeLoader log
WARNING: Failed to load native library:libjlinenative.jnilib. osinfo:
Mac/x86_64 (caused by: java.lang.UnsatisfiedLinkError:
/Users/raghu/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64/libjlinenative.jnilib:
dlopen(/Users/raghu/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64/libjlinenative.jnilib,
0x0001): tried:
'/Users/raghu/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64/libjlinenative.jnilib'
(code signature in <06FBBCEE-2D03-3491-A017-4904811AB25A>
'/Users/raghu/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64/libjlinenative.jnilib'
not valid for use in process: library load disallowed by system policy),
'/System/Volumes/Preboot/Cryptexes/OS/Users/raghu/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64/libjlinenative.jnilib'
(no such file),
'/Users/raghu/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64/libjlinenative.jnilib'
(code signature in <06FBBCEE-2D03-3491-A017-4904811AB25A>
'/Users/raghu/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64/libjlinenative.jnilib'
not valid for use in process: library load disallowed by system policy),
enable debug logging for stacktrace) Apache Maven 4.0.0-rc-3
(3952d00ce65df6753b63a51e86b1f626c55a8df2) Maven home:
/Users/raghu/apache-maven-4.0.0-rc-3 Java version: 21.0.5, vendor: Oracle
Corporation, runtime:
/Library/Java/JavaVirtualMachines/jdk-21.jdk/Contents/Home Default locale:
en_IN, platform encoding: UTF-8 OS name: "mac os x", version: "15.4", arch:
"x86_64", family: "mac"
{code}
Both rc2 and rc3 and installed side by side in the same home folder and
{{libjlinenative.jnilib}} is identical.
{code:java}
raghu@MacBook-Pro-7 x86_64 % pwd
/Users/raghu/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/x86_64
raghu@MacBook-Pro-7 x86_64 % ls -l
total 32
-rwxr-xr-x 1 raghu staff 14228 14 Dec 04:50 libjlinenative.jnilib
raghu@MacBook-Pro-7 x86_64 % ls -l
~/apache-maven-4.0.0-rc-3/lib/jline-native/Mac/x86_64
total 32
-rwxr-xr-x@ 1 raghu staff 14228 5 Mar 15:11 libjlinenative.jnilib {code}
Both were downloaded from maven.apache.org as tar.gz and gunzip/untarred.
> library load disallowed by system policy on Mac
>
>
> Key: MNG-8471
> URL: https://issues.apache.org/jira/browse/MNG-8471
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-2
>Reporter: Elliotte Rusty Harold
>Priority: Minor
> Attachments: Screenshot 2024-12-25 at 6.10.01 PM.png
>
>
> On a Mac with Sequoia 15.1.1 running the binary 4.0-RC2 release to "mvn clean
> verify" the maven-compiler-plugin
> {code}
> WARNING: Failed to load native library:libjlinenative.jnilib. osinfo:
> Mac/arm64 (caused by: java.lang.UnsatisfiedLinkError:
> /opt/java/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/arm64/libjlinenative.jnilib:
>
> dlopen(/opt/java/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/arm64/libjlinenative.jnilib,
> 0x0001): tried:
> '/opt/java/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/arm64/libjlinenative.jnilib'
> (code signature in
> '/opt/java/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/arm64/libjlinenative.jnilib'
> not valid for use in process: library load disallowed by system policy),
> '/System/Volumes/Preboot/Cryptexes/OS/opt/java/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/arm64/libjlinenative.jnilib'
> (no such file),
> '/opt/java/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/arm64/libjlinenative.jnilib'
> (code signature in
> '/opt/java/apache-maven-4.0.0-rc-2/lib/jline-native/Mac/arm64/libjlinenative.jnilib'
> not valid for use in process: library load disallowed by system policy),
> enable debug logging for stacktrace)
> {code}
> The build still seems to complete
cstamas opened a new pull request, #679:
URL: https://github.com/apache/maven-resolver/pull/679
Ability to "pipe" connectors one onto another in controlled and configured
fashion.
The ide is following:
- first (actually connecting to remote) connector is chosen as today (based
on priority)
- next, new type of factories PipelinedRepositoryConnectorFactory is ordered
(by priority) and they can (but does not have to) wrap the delegate in
configured order.
Factored out existing RRF connector into new factory, and introduced another
OfflinePRCF, as so far, "resolver offline" was in fact managed at different
spots, and user was still able to circumvent offline setting. This now
connector now wraps connector and refuses going remote if session if offline.
Vanilla resolver does this:
`offline( rrf( basic(repo) ) )`
---
https://issues.apache.org/jira/browse/MRESOLVER-685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MRESOLVER-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940928#comment-17940928
]
ASF GitHub Bot commented on MRESOLVER-685:
--
cstamas opened a new pull request, #679:
URL: https://github.com/apache/maven-resolver/pull/679
Ability to "pipe" connectors one onto another in controlled and configured
fashion.
The ide is following:
- first (actually connecting to remote) connector is chosen as today (based
on priority)
- next, new type of factories PipelinedRepositoryConnectorFactory is ordered
(by priority) and they can (but does not have to) wrap the delegate in
configured order.
Factored out existing RRF connector into new factory, and introduced another
OfflinePRCF, as so far, "resolver offline" was in fact managed at different
spots, and user was still able to circumvent offline setting. This now
connector now wraps connector and refuses going remote if session if offline.
Vanilla resolver does this:
`offline( rrf( basic(repo) ) )`
---
https://issues.apache.org/jira/browse/MRESOLVER-685
> Connector pipelining
>
>
> Key: MRESOLVER-685
> URL: https://issues.apache.org/jira/browse/MRESOLVER-685
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.8
>
>
> We need to come up with some solution to "order/pipeline" connectors.
> Currently existing connectors in Resolver are:
> * basic -- handles transport and checksum validation; the only connector
> existing in system so far
> * RRF -- wraps another connector and applies remote repository filter rules;
> if enabled, wraps basic as rrf( basic() )
> Not yet in resolver connector:
> * mimir -- this should be moved into Resolver ("caching-connector"), this
> connector offers global cache (per workstation) and more (LAN wide caches)
> To be done connector:
> * signature -- connector that validates signatures
> Pipelining (or at least wrapping ordering) would be handy, as we want to
> achieve something like this:
> {noformat}
> mimir( signature( rrf( basic() ) ) )
> {noformat}
> Flow:
> * mimir onEnter: check caches, if cache have needed payload, swap it out;
> pass on
> * signature onEnter: pass on (no op)
> * rrf onEnter: check filter rules; if ok pass on
> * basic onEnter: using transport get artifacts
> * basic onExit: validate checksums (according to policies), return result
> * rrf onExit: pass on (no op)
> * signature onExit: validate signatures of artifacts, pass on w/ failure (sig
> check result)
> * mimir onExit: check is there something new to be cached, cache it, pass on
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/SUREFIRE-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940884#comment-17940884
]
Michael Osipov commented on SUREFIRE-2301:
--
[~olamy]
> java.lang.ClassNotFoundException:
> org.junit.platform.engine.reporting.OutputDirectoryProvider
> -
>
> Key: SUREFIRE-2301
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2301
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.5.3
>Reporter: Andreas Höhmann
>Priority: Major
>
> After change from 3.5.2 to 3.5.3 I have such an exception in my build.
> This is the minimal plugin configuration which can show the effect.
> It seems a standard plugin config (no custom settings) break already the
> build.
> {code:xml}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.5.3
>
>
> default-test
> test
>
> test
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.12.1
>
>
>
> {code}
> The output is this:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on
> project util:
> [ERROR]
> [ERROR] See
> D:\Dev\git\coc\spice-configuration-cluster\util\target\surefire-reports for
> the individual test results.
> [ERROR] See dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and
> [date].dumpstream.
> [ERROR] There was an error in the forked process
> [ERROR] org/junit/platform/engine/reporting/OutputDirectoryProvider
> [ERROR] java.lang.NoClassDefFoundError:
> org/junit/platform/engine/reporting/OutputDirectoryProvider
> [ERROR] at
> org.apache.maven.surefire.junitplatform.TestPlanScannerFilter.accept(TestPlanScannerFilter.java:47)
> [ERROR] at
> org.apache.maven.surefire.api.util.DefaultScanResult.applyFilter(DefaultScanResult.java:87)
> [ERROR] at
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.scanClasspath(JUnitPlatformProvider.java:144)
> [ERROR] at
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
> [ERROR] Caused by: java.lang.ClassNotFoundException:
> org.junit.platform.engine.reporting.OutputDirectoryProvider
> [ERROR] at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
> [ERROR] at
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
> [ERROR] at
> java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
> [ERROR] ... 8 more
> [ERROR]
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There
> was an error in the forked process
> [ERROR] org/junit/platform/engine/reporting/OutputDirectoryProvider
> [ERROR] java.lang.NoClassDefFoundError:
> org/junit/platform/engine/reporting/OutputDirectoryProvider
> [ERROR] at
> org.apache.maven.surefire.junitplatform.TestPlanScannerFilter.accept(TestPlanScannerFilter.java:47)
> [ERROR] at
> org.apache.maven.surefire.api.util.DefaultScanResult.applyFilter(DefaultScanResult.java:87)
> [ERROR] at
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.scanClasspath(JUnitPlatformProvider.java:144)
> [ERROR] at
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:507)
> [ERROR] at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:495)
> [ERROR] Caused by: java.lang.ClassNotFoundException:
> org.junit.platform.engine.reporting.OutputDirectoryProvider
> [ERROR] at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
> [ERROR] at
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.j
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028360116
##
api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java:
##
@@ -59,7 +58,7 @@ default List includes() {
* The exclusions are applied after the inclusions.
Review Comment:
Heading comment would become:
```
* {@return the list of patterns for the files to exclude}.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
desruisseaux commented on code in PR #2232:
URL: https://github.com/apache/maven/pull/2232#discussion_r2028362207
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##
@@ -149,8 +145,8 @@ public DefaultSourceRoot(
final ProjectScope scope,
Review Comment:
We can take this opportunity for adding the following missing comments:
```
* @param includes list of patterns for the files to include, or {@code
null} if unspecified
* @param excludes list of patterns for the files to exclude, or {@code
null} if unspecified
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MNG-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940908#comment-17940908
]
Christoph Läubrich commented on MNG-8659:
-
If the mojos share the same configuration you can simply put it outside the
execution block, then you only need to configure in the execution what deviates
from that.
> Allow maven plugins to automatically run a Mojo without an explicit execution.
> --
>
> Key: MNG-8659
> URL: https://issues.apache.org/jira/browse/MNG-8659
> Project: Maven
> Issue Type: Improvement
> Components: Plugin API
>Reporter: Niels Basjes
>Priority: Major
>
> As discussed here
> [https://the-asf.slack.com/archives/C7Q9JB404/p1743258198334339]
> Currently an externally developed Maven plugin NEEDS an explicit execution to
> be specified by the end user. In some cases this explicit execution
> definition makes things needlessly complex.
> The idea is to allow the author of a maven plugin to specify which Mojos are
> to be run automatically if the plugin is included in a project.
> So for example something like this should automatically run a subset of the
> available Mojos during their assigned defaultPhase.
> {code:java}
>
> nl.basjes.maven
> my-special-maven-plugin
> 1.0.0
>
> foo
> bar
>
> {code}
> My proposal is to add an extra optional flag (default should be false) to the
> Mojo annotation that allows the developer to automatically have the Mojo
> started.
> I propose a boolean named {{autoExecution}}
> With the meaning:
> {quote}If set to true then this Mojo will have an implied execution that will
> run the Mojo during the configured defaultPhase. This requires the
> defaultPhase to be configured!
> {quote}
> Then an author can do something like this:
> {code:java}
> @Mojo(name = "generate-main", defaultPhase = LifecyclePhase.GENERATE_SOURCES,
> threadSafe = true, autoExecution = true) {code}
>
> I think this should use the execution ids already documented as the "implied
> execution ids"
> https://maven.apache.org/guides/mini/guide-default-execution-ids.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
cstamas merged PR #2227:
URL: https://github.com/apache/maven/pull/2227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MNG-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940906#comment-17940906
]
Niels Basjes commented on MNG-8659:
---
Let me elaborate a bit about my specific usecase and how I see it right now.
I have a plugin that generates both source code (i.e. 'main') and test code
(i.e. 'test') from an input (Yaml in my case).
This requires the input to be specified and things like language (Java/Kotlin),
a package name and a class name for the code that is to be generated.
These are 2 Mojos each attached to a different phase (generate-sources and
generate-test-sources) and use the exact same configuration as input because
the code and tests must use the same package names and class names to work
correctly.
If I have 1 input to process I now have to configure (simplified the format to
make it easier to explain)
{code:java}
plugin
configuration
input=foo.yaml
executions
execution
generate-main
execution
generate-test{code}
or
{code:java}
plugin
executions
execution
configuration
input=foo.yaml
generate-main
execution
configuration
input=foo.yaml
generate-test{code}
My proposal of Mojos that run implicitly as defined in the plugin would
simplify this to
{code:java}
plugin
configuration
input=foo.yaml{code}
Something I am wondering about is how the case of wanting 2 input-output
combinations in a single project.
Currently that will blow up to this where all configurations must be present
twice making it error prone.
{code:java}
plugin
executions
execution
configuration
input=foo.yaml
generate-main
execution
configuration
input=foo.yaml
generate-test
execution
configuration
input=bar.yaml
generate-main
execution
configuration
input=bar.yaml
generate-test{code}
One possible way to handle this in combination with the automatic running of
the default mojos could be this:
{code:java}
plugin
configurations<--- Note the extra level here which can only be used with
these automatically executing Mojos.
configuration
input=foo.yaml
configuration
input=bar.yaml {code}
> Allow maven plugins to automatically run a Mojo without an explicit execution.
> --
>
> Key: MNG-8659
> URL: https://issues.apache.org/jira/browse/MNG-8659
> Project: Maven
> Issue Type: Improvement
> Components: Plugin API
>Reporter: Niels Basjes
>Priority: Major
>
> As discussed here
> [https://the-asf.slack.com/archives/C7Q9JB404/p1743258198334339]
> Currently an externally developed Maven plugin NEEDS an explicit execution to
> be specified by the end user. In some cases this explicit execution
> definition makes things needlessly complex.
> The idea is to allow the author of a maven plugin to specify which Mojos are
> to be run automatically if the plugin is included in a project.
> So for example something like this should automatically run a subset of the
> available Mojos during their assigned defaultPhase.
> {code:java}
>
> nl.basjes.maven
> my-special-maven-plugin
> 1.0.0
>
> foo
> bar
>
> {code}
> My proposal is to add an extra optional flag (default should be false) to the
> Mojo annotation that allows the developer to automatically have the Mojo
> started.
> I propose a boolean named {{autoExecution}}
> With the meaning:
> {quote}If set to true then this Mojo will have an implied execution that will
> run the Mojo during the configured defaultPhase. This requires the
> defaultPhase to be configured!
> {quote}
> Then an author can do something like this:
> {code:java}
> @Mojo(name = "generate-main", defaultPhase = LifecyclePhase.GENERATE_SOURCES,
> threadSafe = true, autoExecution = true) {code}
>
> I think this should use the execution ids already documented as the "implied
> execution ids"
> https://maven.apache.org/guides/mini/guide-default-execution-ids.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MNG-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939837#comment-17939837
]
Lenny Primak commented on MNG-8657:
---
I also posted [https://github.com/mojohaus/aspectj-maven-plugin/issues/220] in
the mojohouse plugin as well
> GMavenPlus and AspectJ plugins break with 4-rc-3
>
>
> Key: MNG-8657
> URL: https://issues.apache.org/jira/browse/MNG-8657
> Project: Maven
> Issue Type: Bug
>Affects Versions: 4.0.0-rc-3
> Environment: Any
>Reporter: Lenny Primak
>Assignee: Guillaume Nodet
>Priority: Critical
>
> GMavenPlus (latest) and AspectJ plugins are broken with rc-3:
> {code:java}
> [ERROR] Failed to execute goal
> org.codehaus.gmavenplus:gmavenplus-plugin:4.1.1:removeTestStubs (default) on
> project shiro-root: Execution default of goal
> org.codehaus.gmavenplus:gmavenplus-plugin:4.1.1:removeTestStubs failed.:
> UnsupportedOperationException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.codehaus.gmavenplus:gmavenplus-plugin:4.1.1:removeTestStubs
> (default) on project shiro-root: Execution default of goal
> org.codehaus.gmavenplus:gmavenplus-plugin:4.1.1:removeTestStubs failed.
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:346)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:310)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:179)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:168)
> at
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:165)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:110)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:60)
> at
> org.apache.maven.lifecycle.internal.DefaultLifecycleStarter.execute(DefaultLifecycleStarter.java:123)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:311)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:225)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:149)
> at
> org.apache.maven.cling.invoker.mvn.MavenInvoker.doExecute(MavenInvoker.java:462)
> at
> org.apache.maven.cling.invoker.mvn.MavenInvoker.execute(MavenInvoker.java:100)
> at
> org.apache.maven.cling.invoker.mvn.MavenInvoker.execute(MavenInvoker.java:81)
> at
> org.apache.maven.cling.invoker.LookupInvoker.doInvoke(LookupInvoker.java:165)
> at
> org.apache.maven.cling.invoker.LookupInvoker.invoke(LookupInvoker.java:135)
> at org.apache.maven.cling.ClingSupport.run(ClingSupport.java:76)
> at org.apache.maven.cling.MavenCling.main(MavenCling.java:51)
> at
> jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
> at java.lang.reflect.Method.invoke(Method.java:565)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:255)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:201)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:361)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:314)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default of goal
> org.codehaus.gmavenplus:gmavenplus-plugin:4.1.1:removeTestStubs failed.
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:152)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:339)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:310)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:214)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:179)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:168)
> at
> org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute(DefaultMojosExecutionStrategy.java:39)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:165)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:110)
> at
> org.apache
gnodet opened a new pull request, #2165:
URL: https://github.com/apache/maven/pull/2165
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MRESOLVER-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MRESOLVER-685:
-
Assignee: Tamas Cservenak
> Connector pipelining
>
>
> Key: MRESOLVER-685
> URL: https://issues.apache.org/jira/browse/MRESOLVER-685
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.8
>
>
> We need to come up with some solution to "order/pipeline" connectors.
> Currently existing connectors in Resolver are:
> * basic -- handles transport and checksum validation; the only connector
> existing in system so far
> * RRF -- wraps another connector and applies remote repository filter rules;
> if enabled, wraps basic as rrf( basic() )
> Not yet in resolver connector:
> * mimir -- this should be moved into Resolver ("caching-connector"), this
> connector offers global cache (per workstation) and more (LAN wide caches)
> To be done connector:
> * signature -- connector that validates signatures
> Pipelining (or at least wrapping ordering) would be handy, as we want to
> achieve something like this:
> {noformat}
> mimir( signature( rrf( basic() ) ) )
> {noformat}
> Flow:
> * mimir onEnter: check caches, if cache have needed payload, swap it out;
> pass on
> * signature onEnter: pass on (no op)
> * rrf onEnter: check filter rules; if ok pass on
> * basic onEnter: using transport get artifacts
> * basic onExit: validate checksums (according to policies), return result
> * rrf onExit: pass on (no op)
> * signature onExit: validate signatures of artifacts, pass on w/ failure (sig
> check result)
> * mimir onExit: check is there something new to be cached, cache it, pass on
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MRESOLVER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MRESOLVER-456:
--
Fix Version/s: 2.0.9
(was: 2.0.8)
> Fix javadoc warnings
>
>
> Key: MRESOLVER-456
> URL: https://issues.apache.org/jira/browse/MRESOLVER-456
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Labels: up-for-grabs
> Fix For: 2.0.9
>
>
> We have some warnings, those need to be fixed.
> Given build-time Java is 21, maybe we just want to migrate all to new Javadoc
> style? (as many of warnings are missing returns, that basically redundantly
> doubles the doco)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
dependabot[bot] opened a new pull request, #16:
URL: https://github.com/apache/maven-mapping/pull/16
Bumps
[org.apache.maven.shared:maven-shared-components](https://github.com/apache/maven-parent)
from 43 to 44.
Release notes
Sourced from https://github.com/apache/maven-parent/releases";>org.apache.maven.shared:maven-shared-components's
releases.
44
:boom: Breaking changes
Move snapshot repositories in a profile (https://redirect.github.com/apache/maven-parent/pull/451";>#451) https://github.com/slawekjaranowski";>@slawekjaranowski
Check test code by checkstyle (https://redirect.github.com/apache/maven-parent/pull/228";>#228) https://github.com/slawekjaranowski";>@slawekjaranowski
🚀 New features and improvements
Move snapshot repositories in a profile (https://redirect.github.com/apache/maven-parent/pull/451";>#451) https://github.com/slawekjaranowski";>@slawekjaranowski
Introduce property maven.site.path.suffix to allow override site path
(https://redirect.github.com/apache/maven-parent/pull/239";>#239)
https://github.com/slawekjaranowski";>@slawekjaranowski
Use v@{project.version} as tag template for releases (https://redirect.github.com/apache/maven-parent/pull/455";>#455) https://github.com/slawekjaranowski";>@slawekjaranowski
import KEYS history from svn (https://redirect.github.com/apache/maven-parent/pull/240";>#240) https://github.com/hboutemy";>@hboutemy
Add licenseText to modello (https://redirect.github.com/apache/maven-parent/pull/241";>#241) https://github.com/slawekjaranowski";>@slawekjaranowski
Update site descriptor to 2.0 (https://redirect.github.com/apache/maven-parent/pull/232";>#232) https://github.com/slawekjaranowski";>@slawekjaranowski
Check test code by checkstyle (https://redirect.github.com/apache/maven-parent/pull/228";>#228) https://github.com/slawekjaranowski";>@slawekjaranowski
Add issues templates (https://redirect.github.com/apache/maven-parent/pull/226";>#226) https://github.com/slawekjaranowski";>@slawekjaranowski
Accept all line endings with spotless (https://redirect.github.com/apache/maven-parent/pull/217";>#217) https://github.com/kwin";>@kwin
Enable automatic formatter when not on CI (https://redirect.github.com/apache/maven-parent/pull/215";>#215) https://github.com/gnodet";>@gnodet
Bump com.diffplug.spotless:spotless-maven-plugin to enable the
sortpom/quiet option (https://redirect.github.com/apache/maven-parent/pull/213";>#213) https://github.com/gnodet";>@gnodet
🐛 Bug Fixes
Fix asf.yaml syntax (https://redirect.github.com/apache/maven-parent/pull/459";>#459) https://github.com/slawekjaranowski";>@slawekjaranowski
📦 Dependency updates
Bump parent to 34 (https://redirect.github.com/apache/maven-parent/pull/461";>#461) https://github.com/slawekjaranowski";>@slawekjaranowski
Bump org.junit:junit-bom from 5.12.0 to 5.12.1 (https://redirect.github.com/apache/maven-parent/pull/460";>#460) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.junit:junit-bom from 5.11.4 to 5.12.0 (https://redirect.github.com/apache/maven-parent/pull/236";>#236) @https://github.com/apps/dependabot";>dependabot[bot]
Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.2 to 2.44.3
(https://redirect.github.com/apache/maven-parent/pull/234";>#234)
@https://github.com/apps/dependabot";>dependabot[bot]
Bump org.codehaus.mojo:taglist-maven-plugin from 3.1.0 to 3.2.1 (https://redirect.github.com/apache/maven-parent/pull/208";>#208) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.codehaus.mojo:extra-enforcer-rules from 1.8.0 to 1.9.0 (https://redirect.github.com/apache/maven-parent/pull/201";>#201) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.apache.maven.plugins:maven-jxr-plugin from 3.4.0 to 3.6.0 (https://redirect.github.com/apache/maven-parent/pull/210";>#210) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.apache.maven.plugins:maven-pmd-plugin from 3.23.0 to 3.26.0 (https://redirect.github.com/apache/maven-parent/pull/211";>#211) @https://github.com/apps/dependabot";>dependabot[bot]
Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.0.BETA4 to
2.44.2 (https://redirect.github.com/apache/maven-parent/pull/229";>#229) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.junit:junit-bom from 5.11.3 to 5.11.4 (https://redirect.github.com/apache/maven-parent/pull/219";>#219) @https://github.com/apps/dependabot";>dependabot[bot]
https://issues.apache.org/jira/browse/MNG-8453";>[MNG-8453]
- Check dependency declarations by default (https://redirect.github.com/apache/maven-parent/pull/220";>#220) https://github.com/elharo";>@elharo
Bump org.codehaus.plexus:plexus-utils from 4.0.1 to 4.0.2 (https://redirect.github.com/apache/maven-parent/pull/202";>#202) @https://github.com/apps/dependabot";>dependabot[bot]
Bump org.cyclonedx:cyclonedx-maven-plugin from
michael-o commented on code in PR #2171:
URL: https://github.com/apache/maven/pull/2171#discussion_r2007275024
##
apache-maven/src/bin/mvn:
##
@@ -196,9 +196,16 @@ export MAVEN_PROJECTBASEDIR
MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@"
export MAVEN_CMD_LINE_ARGS
+# MNG-8248
+ENABLE_NATIVE_ACCESS=""
+if "$JAVACMD" --enable-native-access=ALL-UNNAMED -version >/dev/null 2>&1; then
Review Comment:
OK, this is what I thought.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #187:
URL:
https://github.com/apache/maven-deploy-plugin/issues/187#issuecomment-2771513574
**[Alexander
Kriegisch](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=kriegaex)**
commented
OK, weirdly enough, in https://issues.apache.org/jira/browse/MSHADE-195
which is was closed long ago and should be resolved in Shade 2.4.3 (I am using
3.2.4), there is a hint for a workaround which works for me:
> Workaround
>
> Configure maven-source-plugin with **`false`**. Then the
shade plugin will find the sources and include them in the shaded sources jar,
but the sources jar won't be attached to the build twice.
I added this option, and finally Maven Install and Maven Deploy behave the
way I want to: Only one source JAR - correctly, the shaded one - is being
installed and deployed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #187:
URL:
https://github.com/apache/maven-deploy-plugin/issues/187#issuecomment-2771513550
**[Robert
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
commented
Maven Deploy Plugin is quite stupid: is deploys all Artifacts attached to
the MavenProject instance. If there are 2 artifacts with the same coordinate,
then figure out which plugins did that.
Known cases are where javadoc:javadoc and javadoc:javadoc-no-fork are both
executed, both attaching the javadoc classified jar. Similar case for
maven-source-plugin.
These is a proposal to fail the build if the same classifier+type is
attached for the second time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
desruisseaux commented on issue #230:
URL:
https://github.com/apache/maven-clean-plugin/issues/230#issuecomment-2767378965
It may be resolved as a side effect of #243. There is two issues that were
addressed. First, they were some codes like below:
```java
try {
...
} catch (IOException e) {
throw new IOException("Cannot delete " + file, e);
}
```
The problem is that the exception subtype (`AccessDeniedException`,
`DirectoryNotEmptyException`, _etc._) become hidden behind the cause of the
`IOException`, making it less easy to see. The message _"Cannot delete file"_
does not really bring value as the original exception usually already had the
file name.
A second issue is that some parts of the code continued its operation
despite the exception, causing another exception of different kind later. For
example, if a file was read-only, Java throws `AccessDeniedException`. But the
code was continuing despite that exception, and throwing
`DirectoryNotEmptyException` later when it tried to delete the directory
containing the read-only file. The exception reported to the user was
`DirectoryNotEmptyException`. The `AccessDeniedException` was available as a
cause or suppressed exception, but it was not obvious to the user that it was
the root cause.
#243 no longer wraps the exceptions. The `IOException` that the user get is
the root cause. In above example with a read-only file, the user gets the
`AccessDeniedException`, there is no longer a `DirectoryNotEmptyException`.
This change can be seen in a change in the JUnit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MWRAPPER-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940983#comment-17940983
]
Piotr Karwasz commented on MWRAPPER-161:
I guess that {{dirname "$0"}} should be used instead of the variable expansion.
It is POSIX-2008, so it should work in all environments.
> Fails to run when executed using `sh`
> -
>
> Key: MWRAPPER-161
> URL: https://issues.apache.org/jira/browse/MWRAPPER-161
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.3.2
>Reporter: Volkan Yazici
>Priority: Major
>
> Several projects don't allow executable files in their version control system
> due to platform compatibility concerns. For instance, OpenJDK doesn't allow
> executables to be committed in Git repositories[1]. Hence, Maven Wrapper
> should be runnable as an argument to `sh`, though it is not:
> {code}
> sh mvnw
> mvnw: 109: cannot open mvnw/.mvn/wrapper/maven-wrapper.properties: No such
> file
> {code}
> due to the following line:
> {code}
> "${0%/*}/.mvn/wrapper/maven-wrapper.properties"
> {code}
> I expect there to be more issues due to `$0` usage assuming the script is
> executed as an executable – did not check.
>
> [1] See the `Executable files are not allowed (file: mvnw)` error generated
> by the Skara bot of OpenJDK in this PR attempting to integrate Maven Wrapper
> to JMH: https://github.com/openjdk/jmh/pull/154
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
dependabot[bot] opened a new pull request, #322:
URL: https://github.com/apache/maven-compiler-plugin/pull/322
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from
5.16.1 to 5.17.0.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core's
releases.
v5.17.0
Changelog generated
by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog
Gradle Plugin
5.17.0
2025-04-04 - https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>7
commit(s) by Adrian Roos, Andre Kurait, Jan Ouwens, Rafael Winterhalter,
Taeik Lim, Thach Le, Tim van der Lippe
Fixes https://redirect.github.com/mockito/mockito/issues/3631";>#3631: Fix
broken banner image link [(https://redirect.github.com/mockito/mockito/issues/3632";>#3632)](https://redirect.github.com/mockito/mockito/pull/3632";>mockito/mockito#3632)
Banner image is broken [(https://redirect.github.com/mockito/mockito/issues/3631";>#3631)](https://redirect.github.com/mockito/mockito/issues/3631";>mockito/mockito#3631)
Update exception message with mockito-inline [(https://redirect.github.com/mockito/mockito/issues/3628";>#3628)](https://redirect.github.com/mockito/mockito/pull/3628";>mockito/mockito#3628)
Clarify structure of commit messages [(https://redirect.github.com/mockito/mockito/issues/3626";>#3626)](https://redirect.github.com/mockito/mockito/pull/3626";>mockito/mockito#3626)
Fixes https://redirect.github.com/mockito/mockito/issues/3622";>#3622:
MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3623";>#3623)](https://redirect.github.com/mockito/mockito/pull/3623";>mockito/mockito#3623)
MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3622";>#3622)](https://redirect.github.com/mockito/mockito/issues/3622";>mockito/mockito#3622)
Since mockito-inline has been removed, the exception messages with
mockito-inline should be modified. [(https://redirect.github.com/mockito/mockito/issues/3621";>#3621)](https://redirect.github.com/mockito/mockito/issues/3621";>mockito/mockito#3621)
Fixes https://redirect.github.com/mockito/mockito/issues/3171";>#3171: Fall
back to Throwable Location strategy on Android [(https://redirect.github.com/mockito/mockito/issues/3619";>#3619)](https://redirect.github.com/mockito/mockito/pull/3619";>mockito/mockito#3619)
Fixes https://redirect.github.com/mockito/mockito/issues/3615";>#3615 :
broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3616";>#3616)](https://redirect.github.com/mockito/mockito/pull/3616";>mockito/mockito#3616)
Broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3615";>#3615)](https://redirect.github.com/mockito/mockito/issues/3615";>mockito/mockito#3615)
Mocks are not working on particular devices after update Android SDK
from 33 to 34 [(https://redirect.github.com/mockito/mockito/issues/3171";>#3171)](https://redirect.github.com/mockito/mockito/issues/3171";>mockito/mockito#3171)
Commits
https://github.com/mockito/mockito/commit/7764992d1250f4e7f6ffd10f650dc89516139c8d";>7764992
Remove mention of mockito-inline from mockmaker exception (https://redirect.github.com/mockito/mockito/issues/3628";>#3628)
https://github.com/mockito/mockito/commit/ee92ad4916d9f3f6ae6836bdba5c30f8404d3d50";>ee92ad4
Fix broken banner image link (https://redirect.github.com/mockito/mockito/issues/3632";>#3632)
https://github.com/mockito/mockito/commit/3edab5283552c3c6c393d8c818c8d6a8fa1f94a5";>3edab52
Clarify structure of commit messages (https://redirect.github.com/mockito/mockito/issues/3626";>#3626)
https://github.com/mockito/mockito/commit/bfab74365e91135b2f88ccb0228372a8799d9279";>bfab743
Fall back to Throwable Location strategy on Android (https://redirect.github.com/mockito/mockito/issues/3619";>#3619)
https://github.com/mockito/mockito/commit/4f469c830b2f6ab0e1f061e9383aff2e6f9f8376";>4f469c8
MockitoExtension fails cleanup when aborted before setup (https://redirect.github.com/mockito/mockito/issues/3623";>#3623)
https://github.com/mockito/mockito/commit/1764e62102f525ff9a82b8166b8596edd25f5b7f";>1764e62
Update links to javadoc.io (https://redirect.github.com/mockito/mockito/issues/3616";>#3616)
https://github.com/mockito/mockito/commit/1e029d767b33ee8de42e58459a2c3e63ab3f7c41";>1e029d7
Add missing requirement to objenesis.
See full diff in https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>compare
view
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-s
Stefan Oehme created MNG-8678:
-
Summary: Concurrent executor ignores java.lang.Error subclasses
Key: MNG-8678
URL: https://issues.apache.org/jira/browse/MNG-8678
Project: Maven
Issue Type: Bug
Components: Core
Affects Versions: 4.0.0-rc-3
Reporter: Stefan Oehme
The
[handleBuildFailure|https://github.com/apache/maven/blob/ba93946cafdaabc725212d43ccf26dadf6088b75/impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/concurrent/BuildPlanExecutor.java#L377]
method only handles Exception instead of Throwable. Things like
OutOfMemoryError are ignored and the build is reported as successful even
though something failed.
This is inconsistent with the old
[LifeCycleModuleBuilder|https://github.com/apache/maven/blob/ba93946cafdaabc725212d43ccf26dadf6088b75/impl/maven-core/src/main/java/org/apache/maven/lifecycle/internal/LifecycleModuleBuilder.java#L122]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MNG-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Oehme updated MNG-8670:
--
Description:
When using the new multithreaded builde, there are no ProjectSkipped events for
projects that were skipped due to previous errors. There is no reference to
ProjectSkipped anywhere in BuildPlanExecutor. Compare that to the old
LifecycleModuleBuilder, which fires ProjectSkipped when the reactor is halted
or the project is blacklisted.
Our extension relies on these events to get a complete picture of what happened
during a build.
was:
When using the new multithreaded builder and --fail-fast, there are no
ProjectSkipped events for projects that were skipped due to --fail-fast. There
is no reference to ProjectSkipped anywhere in BuildPlanExecutor. Compare that
to the old LifecycleModuleBuilder, which fires ProjectSkipped when the reactor
is halted or the project is blacklisted.
Our extension relies on these events to get a complete picture of what happened
during a build.
> Concurrent executor doesn't fire ProjectSkipped events
> --
>
> Key: MNG-8670
> URL: https://issues.apache.org/jira/browse/MNG-8670
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-rc-3
>Reporter: Stefan Oehme
>Priority: Major
>
> When using the new multithreaded builde, there are no ProjectSkipped events
> for projects that were skipped due to previous errors. There is no reference
> to ProjectSkipped anywhere in BuildPlanExecutor. Compare that to the old
> LifecycleModuleBuilder, which fires ProjectSkipped when the reactor is halted
> or the project is blacklisted.
>
> Our extension relies on these events to get a complete picture of what
> happened during a build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MRESOLVER-685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MRESOLVER-685:
--
Issue Type: Improvement (was: Task)
> Connector pipelining
>
>
> Key: MRESOLVER-685
> URL: https://issues.apache.org/jira/browse/MRESOLVER-685
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.8
>
>
> We need to come up with some solution to "order/pipeline" connectors.
> Currently existing connectors in Resolver are:
> * basic -- handles transport and checksum validation; the only connector
> existing in system so far
> * RRF -- wraps another connector and applies remote repository filter rules;
> if enabled, wraps basic as rrf( basic() )
> Not yet in resolver connector:
> * mimir -- this should be moved into Resolver ("caching-connector"), this
> connector offers global cache (per workstation) and more (LAN wide caches)
> To be done connector:
> * signature -- connector that validates signatures
> Pipelining (or at least wrapping ordering) would be handy, as we want to
> achieve something like this:
> {noformat}
> mimir( signature( rrf( basic() ) ) )
> {noformat}
> Flow:
> * mimir onEnter: check caches, if cache have needed payload, swap it out;
> pass on
> * signature onEnter: pass on (no op)
> * rrf onEnter: check filter rules; if ok pass on
> * basic onEnter: using transport get artifacts
> * basic onExit: validate checksums (according to policies), return result
> * rrf onExit: pass on (no op)
> * signature onExit: validate signatures of artifacts, pass on w/ failure (sig
> check result)
> * mimir onExit: check is there something new to be cached, cache it, pass on
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Tamas Cservenak created MNG-8677:
Summary: Bump to Resolver 2.0.8 from 2.0.7
Key: MNG-8677
URL: https://issues.apache.org/jira/browse/MNG-8677
Project: Maven
Issue Type: Dependency upgrade
Components: Artifacts and Repositories
Reporter: Tamas Cservenak
Fix For: 4.0.0-rc-4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MWRAPPER-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940983#comment-17940983
]
Piotr Karwasz edited comment on MWRAPPER-161 at 4/4/25 2:04 PM:
I guess that
{code:sh}
"$(dirname "$0")/.mvn/wrapper/maven-wrapper.properties"
{code}
should be used instead of the variable expansion. It is POSIX-2008, so it
should work in all environments.
was (Author: pkarwasz):
I guess that {{dirname "$0"}} should be used instead of the variable expansion.
It is POSIX-2008, so it should work in all environments.
> Fails to run when executed using `sh`
> -
>
> Key: MWRAPPER-161
> URL: https://issues.apache.org/jira/browse/MWRAPPER-161
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.3.2
>Reporter: Volkan Yazici
>Priority: Major
>
> Several projects don't allow executable files in their version control system
> due to platform compatibility concerns. For instance, OpenJDK doesn't allow
> executables to be committed in Git repositories[1]. Hence, Maven Wrapper
> should be runnable as an argument to `sh`, though it is not:
> {code}
> sh mvnw
> mvnw: 109: cannot open mvnw/.mvn/wrapper/maven-wrapper.properties: No such
> file
> {code}
> due to the following line:
> {code}
> "${0%/*}/.mvn/wrapper/maven-wrapper.properties"
> {code}
> I expect there to be more issues due to `$0` usage assuming the script is
> executed as an executable – did not check.
>
> [1] See the `Executable files are not allowed (file: mvnw)` error generated
> by the Skara bot of OpenJDK in this PR attempting to integrate Maven Wrapper
> to JMH: https://github.com/openjdk/jmh/pull/154
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Bukama merged PR #322:
URL: https://github.com/apache/maven-compiler-plugin/pull/322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
dependabot[bot] opened a new pull request, #148:
URL: https://github.com/apache/maven-filtering/pull/148
Bumps `mavenVersion` from 4.0.0-rc-2 to 4.0.0-rc-3.
Updates `org.apache.maven:maven-api-core` from 4.0.0-rc-2 to 4.0.0-rc-3
Release notes
Sourced from https://github.com/apache/maven/releases";>org.apache.maven:maven-api-core's
releases.
Maven 4.0.0-rc-3
Release notes
Maven has entered the release candidate phase and aims to be finally
released in a few weeks. Please give it a try and report errors.
Upgrading from Maven 3
Maven 4 brings a tons of changes. We've tried hard to maximise
compatibility with Maven 3.x, but in order to have your build work with Maven
4, you will need to upgrade some plugins (such as
maven-enforcer-plugin, maven-remote-resources-plugin,
maven-shade-plugin, etc...) to their most recent versions.
If your build is leveraging Maven extensions, you may very well expect
some breakage. Some extensions may need to be updated:
the useful, but unmaintained, https://github.com/trustin/os-maven-plugin/";>os-maven-plugin
extension has been replaced with at https://github.com/maveniverse/nisse";>nisse
extension.
Contact the extensions' developers team to know their plans regarding
supporting to Maven 4.
Upgrading from Maven 4.0.0-rc-2
Important note about breaking changes: Maven 4.0.0-rc-3
includes changes in the new API that will require updates in plugin targeting
the new API, especially relating to [MNG-8395] which adds a new
element to the model and redirects the
element. Plugin developers will need to
update their code to work with these changes.
Change log
What's Changed
[MNG-8437] mvnsh by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/1982";>apache/maven#1982
[MNG-8438] maven-jline: Migrate to Maven DI (off javax.inject) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/1987";>apache/maven#1987
[MNG-8433] Use the switch expressions syntax by https://github.com/CrazyHZM";>@CrazyHZM in https://redirect.github.com/apache/maven/pull/1983";>apache/maven#1983
[MNG-8436] Fix wrong transfer rates displayed in console by https://github.com/gnodet";>@gnodet in https://redirect.github.com/apache/maven/pull/1985";>apache/maven#1985
Exclude maven-xml and maven-xml-impl (the artifact has been renamed) by
https://github.com/gnodet";>@gnodet in https://redirect.github.com/apache/maven/pull/1992";>apache/maven#1992
[MNG-8446] Project cannot start due to too many warnings by https://github.com/gnodet";>@gnodet in https://redirect.github.com/apache/maven/pull/1993";>apache/maven#1993
[MNG-8447] Lossy ProblemCollector by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/1994";>apache/maven#1994
[MNG-8454] Force the FileSizeFormat UT to US Locale by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2003";>apache/maven#2003
[MNG-8460] Implement flush() by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2006";>apache/maven#2006
[MNG-8463] Update plugins by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2005";>apache/maven#2005
[MNG-8461] Initial settings method must restore context state by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2004";>apache/maven#2004
[MNG-8465] Add support for project.rootDirectory in repositories and fix
other expressions by https://github.com/gnodet";>@gnodet in https://redirect.github.com/apache/maven/pull/2007";>apache/maven#2007
[MNG-8461] Integrate reproducer as IT by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2009";>apache/maven#2009
[MNG-8469] Fix interpolation precedence order by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2011";>apache/maven#2011
[MNG-8487] Completely isolate UTs by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2021";>apache/maven#2021
MNG-8479 - Use 'ejb' not 'ejb3' as type in ReactorReader artifact
resolution for compile phase by https://github.com/scottkurz";>@scottkurz in https://redirect.github.com/apache/maven/pull/2016";>apache/maven#2016
Copy edits in comments, API doc, and messages by https://github.com/elharo";>@elharo in https://redirect.github.com/apache/maven/pull/2020";>apache/maven#2020
Fix comparisons against null in PathSource.equals by https://github.com/elharo";>@elharo in https://redirect.github.com/apache/maven/pull/2026";>apache/maven#2026
[MNG-8502] Embedded executor should obey MAVEN_ARGS env variable by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven/pull/2032";>apache/maven#2032
[MNG-8475] In the loop scena
jira-importer commented on issue #203:
URL:
https://github.com/apache/maven-deploy-plugin/issues/203#issuecomment-2771514778
**[Tamas
Cservenak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cstamas)**
commented
Can you provide some minimal reproducer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
dependabot[bot] opened a new pull request, #149:
URL: https://github.com/apache/maven-filtering/pull/149
Bumps `mockitoVersion` from 5.16.1 to 5.17.0.
Updates `org.mockito:mockito-junit-jupiter` from 5.16.1 to 5.17.0
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-junit-jupiter's
releases.
v5.17.0
Changelog generated
by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog
Gradle Plugin
5.17.0
2025-04-04 - https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>7
commit(s) by Adrian Roos, Andre Kurait, Jan Ouwens, Rafael Winterhalter,
Taeik Lim, Thach Le, Tim van der Lippe
Fixes https://redirect.github.com/mockito/mockito/issues/3631";>#3631: Fix
broken banner image link [(https://redirect.github.com/mockito/mockito/issues/3632";>#3632)](https://redirect.github.com/mockito/mockito/pull/3632";>mockito/mockito#3632)
Banner image is broken [(https://redirect.github.com/mockito/mockito/issues/3631";>#3631)](https://redirect.github.com/mockito/mockito/issues/3631";>mockito/mockito#3631)
Update exception message with mockito-inline [(https://redirect.github.com/mockito/mockito/issues/3628";>#3628)](https://redirect.github.com/mockito/mockito/pull/3628";>mockito/mockito#3628)
Clarify structure of commit messages [(https://redirect.github.com/mockito/mockito/issues/3626";>#3626)](https://redirect.github.com/mockito/mockito/pull/3626";>mockito/mockito#3626)
Fixes https://redirect.github.com/mockito/mockito/issues/3622";>#3622:
MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3623";>#3623)](https://redirect.github.com/mockito/mockito/pull/3623";>mockito/mockito#3623)
MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3622";>#3622)](https://redirect.github.com/mockito/mockito/issues/3622";>mockito/mockito#3622)
Since mockito-inline has been removed, the exception messages with
mockito-inline should be modified. [(https://redirect.github.com/mockito/mockito/issues/3621";>#3621)](https://redirect.github.com/mockito/mockito/issues/3621";>mockito/mockito#3621)
Fixes https://redirect.github.com/mockito/mockito/issues/3171";>#3171: Fall
back to Throwable Location strategy on Android [(https://redirect.github.com/mockito/mockito/issues/3619";>#3619)](https://redirect.github.com/mockito/mockito/pull/3619";>mockito/mockito#3619)
Fixes https://redirect.github.com/mockito/mockito/issues/3615";>#3615 :
broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3616";>#3616)](https://redirect.github.com/mockito/mockito/pull/3616";>mockito/mockito#3616)
Broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3615";>#3615)](https://redirect.github.com/mockito/mockito/issues/3615";>mockito/mockito#3615)
Mocks are not working on particular devices after update Android SDK
from 33 to 34 [(https://redirect.github.com/mockito/mockito/issues/3171";>#3171)](https://redirect.github.com/mockito/mockito/issues/3171";>mockito/mockito#3171)
Commits
https://github.com/mockito/mockito/commit/7764992d1250f4e7f6ffd10f650dc89516139c8d";>7764992
Remove mention of mockito-inline from mockmaker exception (https://redirect.github.com/mockito/mockito/issues/3628";>#3628)
https://github.com/mockito/mockito/commit/ee92ad4916d9f3f6ae6836bdba5c30f8404d3d50";>ee92ad4
Fix broken banner image link (https://redirect.github.com/mockito/mockito/issues/3632";>#3632)
https://github.com/mockito/mockito/commit/3edab5283552c3c6c393d8c818c8d6a8fa1f94a5";>3edab52
Clarify structure of commit messages (https://redirect.github.com/mockito/mockito/issues/3626";>#3626)
https://github.com/mockito/mockito/commit/bfab74365e91135b2f88ccb0228372a8799d9279";>bfab743
Fall back to Throwable Location strategy on Android (https://redirect.github.com/mockito/mockito/issues/3619";>#3619)
https://github.com/mockito/mockito/commit/4f469c830b2f6ab0e1f061e9383aff2e6f9f8376";>4f469c8
MockitoExtension fails cleanup when aborted before setup (https://redirect.github.com/mockito/mockito/issues/3623";>#3623)
https://github.com/mockito/mockito/commit/1764e62102f525ff9a82b8166b8596edd25f5b7f";>1764e62
Update links to javadoc.io (https://redirect.github.com/mockito/mockito/issues/3616";>#3616)
https://github.com/mockito/mockito/commit/1e029d767b33ee8de42e58459a2c3e63ab3f7c41";>1e029d7
Add missing requirement to objenesis.
See full diff in https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>compare
view
Updates `org.mockito:mockito-core` from 5.16.1 to 5.17.0
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core's
releases.
v5.17.0
Changelog generated
by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog
Gradle Plugin
5.17.0
dependabot[bot] opened a new pull request, #596:
URL: https://github.com/apache/maven-deploy-plugin/pull/596
Bumps `mockitoVersion` from 5.16.1 to 5.17.0.
Updates `org.mockito:mockito-junit-jupiter` from 5.16.1 to 5.17.0
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-junit-jupiter's
releases.
v5.17.0
Changelog generated
by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog
Gradle Plugin
5.17.0
2025-04-04 - https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>7
commit(s) by Adrian Roos, Andre Kurait, Jan Ouwens, Rafael Winterhalter,
Taeik Lim, Thach Le, Tim van der Lippe
Fixes https://redirect.github.com/mockito/mockito/issues/3631";>#3631: Fix
broken banner image link [(https://redirect.github.com/mockito/mockito/issues/3632";>#3632)](https://redirect.github.com/mockito/mockito/pull/3632";>mockito/mockito#3632)
Banner image is broken [(https://redirect.github.com/mockito/mockito/issues/3631";>#3631)](https://redirect.github.com/mockito/mockito/issues/3631";>mockito/mockito#3631)
Update exception message with mockito-inline [(https://redirect.github.com/mockito/mockito/issues/3628";>#3628)](https://redirect.github.com/mockito/mockito/pull/3628";>mockito/mockito#3628)
Clarify structure of commit messages [(https://redirect.github.com/mockito/mockito/issues/3626";>#3626)](https://redirect.github.com/mockito/mockito/pull/3626";>mockito/mockito#3626)
Fixes https://redirect.github.com/mockito/mockito/issues/3622";>#3622:
MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3623";>#3623)](https://redirect.github.com/mockito/mockito/pull/3623";>mockito/mockito#3623)
MockitoExtension fails cleanup when aborted before setup [(https://redirect.github.com/mockito/mockito/issues/3622";>#3622)](https://redirect.github.com/mockito/mockito/issues/3622";>mockito/mockito#3622)
Since mockito-inline has been removed, the exception messages with
mockito-inline should be modified. [(https://redirect.github.com/mockito/mockito/issues/3621";>#3621)](https://redirect.github.com/mockito/mockito/issues/3621";>mockito/mockito#3621)
Fixes https://redirect.github.com/mockito/mockito/issues/3171";>#3171: Fall
back to Throwable Location strategy on Android [(https://redirect.github.com/mockito/mockito/issues/3619";>#3619)](https://redirect.github.com/mockito/mockito/pull/3619";>mockito/mockito#3619)
Fixes https://redirect.github.com/mockito/mockito/issues/3615";>#3615 :
broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3616";>#3616)](https://redirect.github.com/mockito/mockito/pull/3616";>mockito/mockito#3616)
Broken links to javadoc.io [(https://redirect.github.com/mockito/mockito/issues/3615";>#3615)](https://redirect.github.com/mockito/mockito/issues/3615";>mockito/mockito#3615)
Mocks are not working on particular devices after update Android SDK
from 33 to 34 [(https://redirect.github.com/mockito/mockito/issues/3171";>#3171)](https://redirect.github.com/mockito/mockito/issues/3171";>mockito/mockito#3171)
Commits
https://github.com/mockito/mockito/commit/7764992d1250f4e7f6ffd10f650dc89516139c8d";>7764992
Remove mention of mockito-inline from mockmaker exception (https://redirect.github.com/mockito/mockito/issues/3628";>#3628)
https://github.com/mockito/mockito/commit/ee92ad4916d9f3f6ae6836bdba5c30f8404d3d50";>ee92ad4
Fix broken banner image link (https://redirect.github.com/mockito/mockito/issues/3632";>#3632)
https://github.com/mockito/mockito/commit/3edab5283552c3c6c393d8c818c8d6a8fa1f94a5";>3edab52
Clarify structure of commit messages (https://redirect.github.com/mockito/mockito/issues/3626";>#3626)
https://github.com/mockito/mockito/commit/bfab74365e91135b2f88ccb0228372a8799d9279";>bfab743
Fall back to Throwable Location strategy on Android (https://redirect.github.com/mockito/mockito/issues/3619";>#3619)
https://github.com/mockito/mockito/commit/4f469c830b2f6ab0e1f061e9383aff2e6f9f8376";>4f469c8
MockitoExtension fails cleanup when aborted before setup (https://redirect.github.com/mockito/mockito/issues/3623";>#3623)
https://github.com/mockito/mockito/commit/1764e62102f525ff9a82b8166b8596edd25f5b7f";>1764e62
Update links to javadoc.io (https://redirect.github.com/mockito/mockito/issues/3616";>#3616)
https://github.com/mockito/mockito/commit/1e029d767b33ee8de42e58459a2c3e63ab3f7c41";>1e029d7
Add missing requirement to objenesis.
See full diff in https://github.com/mockito/mockito/compare/v5.16.1...v5.17.0";>compare
view
Updates `org.mockito:mockito-core` from 5.16.1 to 5.17.0
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockito-core's
releases.
v5.17.0
Changelog generated
by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog
Gradle Plugin
5.17.0
jira-importer commented on issue #194:
URL:
https://github.com/apache/maven-deploy-plugin/issues/194#issuecomment-2771514067
**[Tamas
Cservenak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cstamas)**
commented
The IT does not stir a lot, while functionally the "job" does not happen
here (in deploy plugin), IMHO this is nice "end to end" test covering whole
trail. Unsure do we want really to revert this... (what would it buy us? IT
runtime would be less?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #206:
URL:
https://github.com/apache/maven-deploy-plugin/issues/206#issuecomment-2771515037
**[Claus
Köll](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=c_koell)**
commented
[Karl Heinz
Marbaise](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=khmarbaise)
We have tried with the neweset version but there is still the problem that it
does not generate a own pom.xml file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #203:
URL:
https://github.com/apache/maven-deploy-plugin/issues/203#issuecomment-2771514889
**[Michaël](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=JIRAUSER305673)**
commented
in a multi-module project i need to trigger jar-type modules different than
pom type modules
e.g. two commands
mvn deploy:deploy -pl parent-pom
mvn jar:jar deploy:deploy -pl some-client
if i do deploy:deploy on packaging jar type modules without jar:jar i get:
`Failed to execute goal
org.apache.maven.plugins:maven-deploy-plugin:3.1.1:deploy (default-cli) on
project some-client: The packaging for this project did not assign a file to
the build artifact -> [Help 1]`
i think 3.1.2 will behave the same here.`{}{`}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939963#comment-17939963
]
ASF GitHub Bot commented on SCM-1028:
-
mhoffrog commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2768534099
Fixed issue with @see in JavaDoc of GitUtil.java by recent force push.
> Vulnerability: Clear text password is logged by JGit provider and by gitexe
> remoteinfo on a ls-remote failure
> -
>
> Key: SCM-1028
> URL: https://issues.apache.org/jira/browse/SCM-1028
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe, maven-scm-provider-jgit
>Affects Versions: 2.1.0
>Reporter: Markus Hoffrogge
>Priority: Critical
> Labels: Vulnerability, vulnerabilities, vulnerability
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> *Issue(s):*
> # {*}JGit provider{*}: If the git password contains special characters which
> are differently encoded by the {{URI class}} than {{{}by
> URLEncode.encode{}}}, then the password masking does not become effective and
> the password is logged in clear URI encoded format by the jgit provider.
> # {*}Gitexe remoteinfo{*}: In case ls-remote is failing, then a
> {{ScmException}} is being thrown with the fetch URL passed as error message
> containing the URI encoded clear password.
> *Root cause(s):*
> # The URL encoding used for the credentials within fetch and push URL
> differs from the encoding being used for masking the password at
> [JGitUtils.prepareSession(...)|https://github.com/apache/maven-scm/blob/55186fdf42f65fd3a1be07161bc198f092386f77/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/JGitUtils.java#L149]
> # Password is not masked for the exception message passed to the
> ScmException used at
> [GitRemoteInfoCommand.executeRemoteInfoCommand(...)|https://github.com/apache/maven-scm/blob/55186fdf42f65fd3a1be07161bc198f092386f77/maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/remoteinfo/GitRemoteInfoCommand.java#L59]
> *Solution:*
> [PR #237|https://github.com/apache/maven-scm/pull/237]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
jira-importer commented on issue #170:
URL:
https://github.com/apache/maven-deploy-plugin/issues/170#issuecomment-2771512157
**[Robert
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
commented
What's the value for
[url](http://maven.apache.org/plugins/maven-deploy-plugin/deploy-file-mojo.html#url)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #187:
URL:
https://github.com/apache/maven-deploy-plugin/issues/187#issuecomment-2771513558
**[Tamas
Cservenak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cstamas)**
commented
I see MNG-5868 that should fix this? Is on master, not yet released. Also,
Maven 3.0 rejected duplicates as well, so the "duplication detection" got
removed somewhere between 3 and current master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MRESOLVER-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936882#comment-17936882
]
ASF GitHub Bot commented on MRESOLVER-646:
--
gnodet commented on PR #672:
URL: https://github.com/apache/maven-resolver/pull/672#issuecomment-2737290343
> This cannot work as is: "mvn4 bits" are Maven4 annotated, and bridge is
not here (is in maven-core which we don't want here)...
It may be possible to move the bridge in a separate jar, not sure...
Or do we want to use DI annotations for resolver ?
> Maven4 supplier should use maven-impl
> -
>
> Key: MRESOLVER-646
> URL: https://issues.apache.org/jira/browse/MRESOLVER-646
> Project: Maven Resolver
> Issue Type: Dependency upgrade
> Components: Resolver
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.8
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8490:
-
Description:
Align XmlNode with the rest of the maven 4 API by using an immutable class and
a builder.
=
(was: Single use interfaces are an antipattern. Make everything simpler by
having a single concrete XmlNode class.)
was:
Align XmlNode with the rest of the maven 4 API by using an immutable class and
a builder.
=
Single use interfaces are an antipattern. Make everything simpler by having a
single concrete XmlNode class.
> Add a Builder to XmlNode and provide an XmlService
> --
>
> Key: MNG-8490
> URL: https://issues.apache.org/jira/browse/MNG-8490
> Project: Maven
> Issue Type: Improvement
>Affects Versions: API
>Reporter: Elliotte Rusty Harold
>Assignee: Guillaume Nodet
>Priority: Blocker
> Fix For: 4.0.0-rc-4
>
>
> Align XmlNode with the rest of the maven 4 API by using an immutable class
> and a builder.
> =
> (was: Single use interfaces are an antipattern. Make everything simpler by
> having a single concrete XmlNode class.)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/MNG-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-4559:
-
Fix Version/s: 4.0.x-candidate
> MAVEN_OPTS are incorrectly resolved in Unix
> ---
>
> Key: MNG-4559
> URL: https://issues.apache.org/jira/browse/MNG-4559
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 2.2.1, 3.0.5
> Environment: OS: Linux, 2.6.32-11-generic, amd64.
> Java: 1.6.0_17
> Also Operating System = Mac OS X version 10.9.2 running on x86_64
> Java; VM; Vendor = 1.7.0_51
>Reporter: Maxim Podkolzine
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> I'm trying to pass a quoted parameter through MAVEN_OPTS, e.g.
> MAVEN_OPTS="-Dfoo='bar baz'"
> As a result the quotes are not resolved, causing Java failure:
> Exception in thread "main" java.lang.NoClassDefFoundError: baz'
> ...
> I couldn't figure out a way to make it work.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
slawekjaranowski commented on PR #2171:
URL: https://github.com/apache/maven/pull/2171#issuecomment-2742788091
@michael-o @Bukama or other else can you check on Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #171:
URL:
https://github.com/apache/maven-deploy-plugin/issues/171#issuecomment-2771512257
**[Robert
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
commented
This is not just a deploy-plugin issue, but also an install-plugin issue.
Hence this is not the right place to solve this.
Instead you should use the
[flatten-maven-plugin](http://mojo.codehaus.org/flatten-maven-plugin/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
cstamas commented on PR #2162:
URL: https://github.com/apache/maven/pull/2162#issuecomment-2741617277
If you already have it locally, just push here IMO, but separate PR is ok as
well but that PR will fail as long this one is not merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
mhoffrog opened a new pull request, #238:
URL: https://github.com/apache/maven-scm/pull/238
## JIRA
[SCM-1029](https://issues.apache.org/jira/browse/SCM-1029)
## Changes
- JGitCheckInCommand.java:
- in case of a includes / excludes FileSet is specified then:
- use OR condition of
- status.getAdded().size() > 0
- status.getChanged().size() > 0 - status.getRemoved() > 0 instead of
status.hasUncommittedChanges()
- log info "nothing to commit" if nothing is to be commited
## Test
- All JUnit tests passed
- Tested in a local application
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[
https://issues.apache.org/jira/browse/MNG-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939818#comment-17939818
]
Guillaume Nodet commented on MNG-6049:
--
AFAIK, this has been implemented and is now configurable using
{{{}maven.session.versionFilter{}}}, see
[https://maven.apache.org/ref/4-LATEST/maven-configuration.html]
> Add behavior to filter resolved version ranges of an artifact
> -
>
> Key: MNG-6049
> URL: https://issues.apache.org/jira/browse/MNG-6049
> Project: Maven
> Issue Type: Improvement
> Components: Core, Dependencies
>Reporter: Uwe Barthel
>Priority: Critical
> Fix For: 4.x / Backlog
>
>
> The discussion on issue MNG-3092 shows the seriously needs of different kinds
> of version range resolving in Maven.
> This solution provides a hook for Maven extensions/plugins to change the list
> of resolved version range results as required.
> The {{DefaultVersionRangeResolver}} will be extended with a filter for
> version range results. A new interface {{VersionRangeResultFilter}} is added
> and a non-filtering {{DefaultVersionRangeResultFilter}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[
https://issues.apache.org/jira/browse/SUREFIRE-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939664#comment-17939664
]
Michael Osipov commented on SUREFIRE-2299:
--
Can you share the test XML files?
> Missing tests inside Surefire report for Cucumber scenarios
> ---
>
> Key: SUREFIRE-2299
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2299
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.5.3
>Reporter: Florin Slev
>Priority: Major
>
> It seems Maven Surefire 3.5.3 no longer generates test reports when executing
> Cucumber scenarios.
> Steps:
> 1.) Git clone the following showcase project
> https://github.com/fslev/cucumber-showcase
> 2.) Run Maven command
> {code}
> mvn clean test
> {code}
> Actual:
> Though the scenarios were successfully executed, there is no related
> information inside target/surefire-reports/io.example.CalculatorTest.txt
> Tests run: 0
> {code}
> ---
> Test set: io.example.CalculatorTest
> ---
> Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.17 s -- in
> io.example.CalculatorTest
> {code}
> 3.) Downgrade Maven Surefire to 3.5.2
> Actual:
> Everything works fine now.
> Might be related to https://issues.apache.org/jira/browse/SUREFIRE-2298
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
gnodet merged PR #1300:
URL: https://github.com/apache/maven-mvnd/pull/1300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #188:
URL:
https://github.com/apache/maven-deploy-plugin/issues/188#issuecomment-2771513756
**[Karl Heinz
Marbaise](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=khmarbaise)**
commented
It sounds you like to work around the life cycle which sounds like fighting
against Maven ...which usually is a combat you will loose ...Can you please
make an example project let us discuss about this on a existing project which I
think would make it easier...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #187:
URL:
https://github.com/apache/maven-deploy-plugin/issues/187#issuecomment-2771513566
**[Alexander
Kriegisch](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=kriegaex)**
commented
This still happens with Maven 3.6.3 and Maven Shade with
`true`. The thing is, if I do not
configure Maven Source Plugin to run, I get lots of ugly conflict warnings
during non-clean builds, because Maven Shade tries re-shading an already
existing source JAR. The only way to avoid this is to even configure an
additional
```xml
true
```
But then I get the duplicate uploads during deploy and e.g. on GitHub
Packages an error like:
```java
Transfer failed for (...)xyz-sources.jar 409 Conflict
```
This might be a conceptual problem in Maven itself, a shortcoming in Shade
or Source, I really don't know and have no intention to get philosophical about
something other people here know way more about. what I am sure about, though,
is that this is a real problem many people are struggling with and nothing has
happened to effectively fix it. Just sweeping this under the rug and closing it
as "won't fix" because nobody dares to touch it certainly will not fix the
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Bukama commented on PR #132:
URL: https://github.com/apache/maven-ear-plugin/pull/132#issuecomment-2748955135
Oh. Will do in another. Took one of the PRs linked in the list to be sure
everything is in and made the same changes here (and in the other PRs). After
that my brain said "done" with part 1 🙈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
gnodet opened a new pull request, #2206:
URL: https://github.com/apache/maven/pull/2206
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #208:
URL:
https://github.com/apache/maven-deploy-plugin/issues/208#issuecomment-2771515172
**[Wendy
Smoak](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wsmoak)**
commented
Duplicate of MDEPLOY-45, and already fixed in trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
jira-importer commented on issue #170:
URL:
https://github.com/apache/maven-deploy-plugin/issues/170#issuecomment-2771512172
**[Markus
Karg](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=mkarg)**
commented
Sorry for letting you wait.
What exactly do you want me to do / to post)? Instructions please. :-)
Thanks
-Markus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
sblantipodi commented on issue #317:
URL:
https://github.com/apache/maven-compiler-plugin/issues/317#issuecomment-2757061275
hi @slawekjaranowski, thanks for the answer, it seems that lombok does not
supprot JDK24 yet, this is the cause of my issue.
in the meantime can you confirm me that maven-compiler-plugin 3.14 works
well with maven 3 and JDK24 please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
dependabot[bot] opened a new pull request, #2167:
URL: https://github.com/apache/maven/pull/2167
Bumps com.google.guava:failureaccess from 1.0.2 to 1.0.3.
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that
have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI
passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and
block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it.
You can achieve the same result by closing it manually
- `@dependabot show ignore conditions` will show all of
the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen the PR
or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the PR or
upgrade to it yourself)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
