Re: [PR] [MJAVADOC-798] pass user settings to invoker [maven-javadoc-plugin]
michael-o commented on PR #290: URL: https://github.com/apache/maven-javadoc-plugin/pull/290#issuecomment-2226806469 > Thanks! I actually did have a look, but was unsuccessful in reproducing the issue in a maven-invoker IT. I will have another look when time permits and send another PR. Appreciated! It is a tricky one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-798) Consider passing user settings when using invoker
[
https://issues.apache.org/jira/browse/MJAVADOC-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865647#comment-17865647
]
ASF GitHub Bot commented on MJAVADOC-798:
-
michael-o commented on PR #290:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/290#issuecomment-2226806469
> Thanks! I actually did have a look, but was unsuccessful in reproducing
the issue in a maven-invoker IT. I will have another look when time permits and
send another PR.
Appreciated! It is a tricky one.
> Consider passing user settings when using invoker
> -
>
> Key: MJAVADOC-798
> URL: https://issues.apache.org/jira/browse/MJAVADOC-798
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: fix, javadoc
>Affects Versions: 3.7.0
>Reporter: Carsten Pfeiffer
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.7.1
>
>
> I get this in some of our builds:
> {code}
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.7.0:javadoc'
> has not been previously called for the module:
> 'de.example:myproject:jar:1.0.0-SNAPSHOT'. Trying to invoke it...
> [ERROR] MavenInvocationException: Error when invoking Maven, consult the
> invoker log file:
> /tmp/myproject/myproject-submodule/target/invoker/maven-javadoc-plugin1730810899.txt
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /tmp/myproject/myproject/target/site/apidocs
> [ERROR] Error fetching link: /tmp/myproject/myproject/target/site/apidocs.
> Ignored it.
> {code}
> And looking at the invoker log, I see that some parent pom cannot be found,
> because my custom {{settings.xml}} that I specified with {{mvn -s
> mysettings.xml}} was not considered:
> {code}
> Invoking Maven for the goals:
> [org.apache.maven.plugins:maven-javadoc-plugin:3.7.0:javadoc] with no
> properties
> M2_HOME=/home/gis/.m2/wrapper/dists/apache-maven-3.6-bin/5al0cn3ksttl2pq1n2rbut6jh8/apache-maven-3.6.3
> MAVEN_OPTS=null
> JAVA_HOME=/usr/lib/jvm/java-17-openjdk-amd64
> JAVA_OPTS=null
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [FATAL] Non-resolvable parent POM for
> de.example:myproject-parent:1.0.0-SNAPSHOT: Failure to find
> de.example.other:someparent:pom:1.9.0-I26 in
> https://mynexus/content/groups/releases was cached in the local repository,
> resolution will not be reattempted until the update interval of releases has
> elapsed or updates are forced and 'parent.relativePath' points at wrong local
> POM @ de.example:myproject-parent:1.0.0-SNAPSHOT, /tmp/myproject/pom.xml,
> line 8, column 10
> @
> [ERROR] The build could not read 1 project -> [Help 1]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAVADOC-801] Upgrade to Clirr Maven Plugin 2.8 in fix goals [maven-javadoc-plugin]
asfgit closed pull request #296: [MJAVADOC-801] Upgrade to Clirr Maven Plugin 2.8 in fix goals URL: https://github.com/apache/maven-javadoc-plugin/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJAVADOC-801] Upgrade to Clirr Maven Plugin 2.8 in fix goals [maven-javadoc-plugin]
asfgit merged PR #296: URL: https://github.com/apache/maven-javadoc-plugin/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-801) Upgrade to Clirr Maven Plugin 2.8 in fix goals
[ https://issues.apache.org/jira/browse/MJAVADOC-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865651#comment-17865651 ] ASF GitHub Bot commented on MJAVADOC-801: - asfgit merged PR #296: URL: https://github.com/apache/maven-javadoc-plugin/pull/296 > Upgrade to Clirr Maven Plugin 2.8 in fix goals > -- > > Key: MJAVADOC-801 > URL: https://issues.apache.org/jira/browse/MJAVADOC-801 > Project: Maven Javadoc Plugin > Issue Type: Dependency upgrade > Components: fix >Affects Versions: 3.7.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.7.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-801) Upgrade to Clirr Maven Plugin 2.8 in fix goals
[ https://issues.apache.org/jira/browse/MJAVADOC-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865650#comment-17865650 ] ASF GitHub Bot commented on MJAVADOC-801: - asfgit closed pull request #296: [MJAVADOC-801] Upgrade to Clirr Maven Plugin 2.8 in fix goals URL: https://github.com/apache/maven-javadoc-plugin/pull/296 > Upgrade to Clirr Maven Plugin 2.8 in fix goals > -- > > Key: MJAVADOC-801 > URL: https://issues.apache.org/jira/browse/MJAVADOC-801 > Project: Maven Javadoc Plugin > Issue Type: Dependency upgrade > Components: fix >Affects Versions: 3.7.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.7.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MJAVADOC-801) Upgrade to Clirr Maven Plugin 2.8 in fix goals
[ https://issues.apache.org/jira/browse/MJAVADOC-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MJAVADOC-801. --- Resolution: Fixed Fixed with [a6cff0204363ebcc717c79db86c7d62361f9afb8|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=a6cff0204363ebcc717c79db86c7d62361f9afb8]. > Upgrade to Clirr Maven Plugin 2.8 in fix goals > -- > > Key: MJAVADOC-801 > URL: https://issues.apache.org/jira/browse/MJAVADOC-801 > Project: Maven Javadoc Plugin > Issue Type: Dependency upgrade > Components: fix >Affects Versions: 3.7.0 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.7.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MJAVADOC-802] Set default value of defaultAuthor parameter in fix go… [maven-javadoc-plugin]
asfgit closed pull request #297: [MJAVADOC-802] Set default value of defaultAuthor parameter in fix go… URL: https://github.com/apache/maven-javadoc-plugin/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-802) Set default value of defaultAuthor parameter in fix goals to ${user.name}
[
https://issues.apache.org/jira/browse/MJAVADOC-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865655#comment-17865655
]
ASF GitHub Bot commented on MJAVADOC-802:
-
asfgit closed pull request #297: [MJAVADOC-802] Set default value of
defaultAuthor parameter in fix go…
URL: https://github.com/apache/maven-javadoc-plugin/pull/297
> Set default value of defaultAuthor parameter in fix goals to ${user.name}
> -
>
> Key: MJAVADOC-802
> URL: https://issues.apache.org/jira/browse/MJAVADOC-802
> Project: Maven Javadoc Plugin
> Issue Type: New Feature
> Components: fix
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> This has less code and allows the user to overwrite the value if desired.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJAVADOC-802) Set default value of defaultAuthor parameter in fix goals to ${user.name}
[
https://issues.apache.org/jira/browse/MJAVADOC-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MJAVADOC-802.
---
Resolution: Fixed
Fixed with
[4904e0825ae265f5d152a9f0d7eebbcc038c55c9|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=4904e0825ae265f5d152a9f0d7eebbcc038c55c9].
> Set default value of defaultAuthor parameter in fix goals to ${user.name}
> -
>
> Key: MJAVADOC-802
> URL: https://issues.apache.org/jira/browse/MJAVADOC-802
> Project: Maven Javadoc Plugin
> Issue Type: New Feature
> Components: fix
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> This has less code and allows the user to overwrite the value if desired.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MJAVADOC-803) Add default parameter to force root locale
Michael Osipov created MJAVADOC-803:
---
Summary: Add default parameter to force root locale
Key: MJAVADOC-803
URL: https://issues.apache.org/jira/browse/MJAVADOC-803
Project: Maven Javadoc Plugin
Issue Type: Improvement
Components: jar, javadoc
Affects Versions: 3.7.0
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 3.7.1
Javadoc suffers from the following two problems:
* During HTML generatation {{Locale#getDefault()}} is invoked and all generated
content maybe localized, e.g. German, Japanese. That is a surprise for most
since they expect to see English content. One has to force with
{{en}}
* In the past JDKs Oracle now stated to even localize stdout and stderr output
to those languages (see
https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
even more could come. This cases a regression with MJAVADOC-751 which relies
on English language output to do work.
Therefore, we will introduce a new parameter {{forceRootLocale}} which will add
{{-J-Duser.language= -J-Duser.country=}} which will result in {{Locale#ROOT}}
and force both generated HTML output and std output to be in English. Those who
still need generated content in specific language can pass {{}} and it
will work independently of the std output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-803) Add default parameter to force root locale
[
https://issues.apache.org/jira/browse/MJAVADOC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MJAVADOC-803:
Description:
Javadoc suffers from the following two problems:
* During HTML generatation {{Locale#getDefault()}} is invoked and all generated
content maybe localized, e.g. German, Japanese. That is a surprise for most
since they expect to see English content. One has to force with
{{en}}.
* In the past JDKs Oracle now started to even localize stdout and stderr output
to those languages (see
https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
even more could come. This causes a regression with MJAVADOC-751 which relies
on English language output to work.
Therefore, we will introduce a new parameter {{forceRootLocale}} which will add
{{-J-Duser.language= -J-Duser.country=}} and will result in {{Locale#ROOT}}.
Both will force generated HTML output and std output to be in English. Those
who still need generated content in a specific language can pass {{}}
and it will work independently of the std output.
was:
Javadoc suffers from the following two problems:
* During HTML generatation {{Locale#getDefault()}} is invoked and all generated
content maybe localized, e.g. German, Japanese. That is a surprise for most
since they expect to see English content. One has to force with
{{en}}
* In the past JDKs Oracle now stated to even localize stdout and stderr output
to those languages (see
https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
even more could come. This cases a regression with MJAVADOC-751 which relies
on English language output to do work.
Therefore, we will introduce a new parameter {{forceRootLocale}} which will add
{{-J-Duser.language= -J-Duser.country=}} which will result in {{Locale#ROOT}}
and force both generated HTML output and std output to be in English. Those who
still need generated content in specific language can pass {{}} and it
will work independently of the std output.
> Add default parameter to force root locale
> --
>
> Key: MJAVADOC-803
> URL: https://issues.apache.org/jira/browse/MJAVADOC-803
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> Javadoc suffers from the following two problems:
> * During HTML generatation {{Locale#getDefault()}} is invoked and all
> generated content maybe localized, e.g. German, Japanese. That is a surprise
> for most since they expect to see English content. One has to force with
> {{en}}.
> * In the past JDKs Oracle now started to even localize stdout and stderr
> output to those languages (see
> https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
> even more could come. This causes a regression with MJAVADOC-751 which
> relies on English language output to work.
> Therefore, we will introduce a new parameter {{forceRootLocale}} which will
> add {{-J-Duser.language= -J-Duser.country=}} and will result in
> {{Locale#ROOT}}. Both will force generated HTML output and std output to be
> in English. Those who still need generated content in a specific language can
> pass {{}} and it will work independently of the std output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MJAVADOC-803] Add default parameter to force root locale [maven-javadoc-plugin]
michael-o opened a new pull request, #298: URL: https://github.com/apache/maven-javadoc-plugin/pull/298 This closes #298 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-803) Add default parameter to force root locale
[
https://issues.apache.org/jira/browse/MJAVADOC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865658#comment-17865658
]
ASF GitHub Bot commented on MJAVADOC-803:
-
michael-o opened a new pull request, #298:
URL: https://github.com/apache/maven-javadoc-plugin/pull/298
This closes #298
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Add default parameter to force root locale
> --
>
> Key: MJAVADOC-803
> URL: https://issues.apache.org/jira/browse/MJAVADOC-803
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> Javadoc suffers from the following two problems:
> * During HTML generatation {{Locale#getDefault()}} is invoked and all
> generated content maybe localized, e.g. German, Japanese. That is a surprise
> for most since they expect to see English content. One has to force with
> {{en}}.
> * In the past JDKs Oracle now started to even localize stdout and stderr
> output to those languages (see
> https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
> even more could come. This causes a regression with MJAVADOC-751 which
> relies on English language output to work.
> Therefore, we will introduce a new parameter {{forceRootLocale}} which will
> add {{-J-Duser.language= -J-Duser.country=}} and will result in
> {{Locale#ROOT}}. Both will force generated HTML output and std output to be
> in English. Those who still need generated content in a specific language can
> pass {{}} and it will work independently of the std output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAVADOC-751] No warnings for localized output [maven-javadoc-plugin]
michael-o commented on PR #206: URL: https://github.com/apache/maven-javadoc-plugin/pull/206#issuecomment-2226818768 Superseded by #298. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJAVADOC-751] No warnings for localized output [maven-javadoc-plugin]
michael-o closed pull request #206: [MJAVADOC-751] No warnings for localized output URL: https://github.com/apache/maven-javadoc-plugin/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-751) No warnings for localized output
[ https://issues.apache.org/jira/browse/MJAVADOC-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865659#comment-17865659 ] ASF GitHub Bot commented on MJAVADOC-751: - michael-o commented on PR #206: URL: https://github.com/apache/maven-javadoc-plugin/pull/206#issuecomment-2226818768 Superseded by #298. > No warnings for localized output > > > Key: MJAVADOC-751 > URL: https://issues.apache.org/jira/browse/MJAVADOC-751 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Mario Schäper >Priority: Minor > Labels: easyfix, pull-request-available > Original Estimate: 1h > Remaining Estimate: 1h > > If the output of the javadoc executable is localized the following two errors > occur depending on the exit code: > 1) non-zero: the informational output filter (introduced in MJAVADOC-721) > does not work > 2) zero: no warnings are recognized > > #2 is particularly problematic if `failOnWarnings` is set, since this may > cause a build to fail in english environments, but not on certain others. > > Affected are japanese, chinese and since [JDK > 19|https://github.com/openjdk/jdk/commit/38df5701ff82] german. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-751) No warnings for localized output
[ https://issues.apache.org/jira/browse/MJAVADOC-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865660#comment-17865660 ] ASF GitHub Bot commented on MJAVADOC-751: - michael-o closed pull request #206: [MJAVADOC-751] No warnings for localized output URL: https://github.com/apache/maven-javadoc-plugin/pull/206 > No warnings for localized output > > > Key: MJAVADOC-751 > URL: https://issues.apache.org/jira/browse/MJAVADOC-751 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Mario Schäper >Priority: Minor > Labels: easyfix, pull-request-available > Original Estimate: 1h > Remaining Estimate: 1h > > If the output of the javadoc executable is localized the following two errors > occur depending on the exit code: > 1) non-zero: the informational output filter (introduced in MJAVADOC-721) > does not work > 2) zero: no warnings are recognized > > #2 is particularly problematic if `failOnWarnings` is set, since this may > cause a build to fail in english environments, but not on certain others. > > Affected are japanese, chinese and since [JDK > 19|https://github.com/openjdk/jdk/commit/38df5701ff82] german. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MASFRES-70] Use custom property name for local IT repo [maven-apache-resources]
kwin commented on code in PR #15:
URL:
https://github.com/apache/maven-apache-resources/pull/15#discussion_r1676784431
##
source-release/pom.xml:
##
@@ -135,9 +135,11 @@ under the License.
maven.home
${preparedMavenHome}
+
[jira] [Commented] (MNG-8160) Recreate the transformed artifact if it has been deleted
[ https://issues.apache.org/jira/browse/MNG-8160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865663#comment-17865663 ] Guillaume Nodet commented on MNG-8160: -- [https://github.com/apache/maven/pull/1587] [c3f1cd6|https://github.com/apache/maven/commit/c3f1cd6f76bd296a4e7c552990eff27afa1c4825] > Recreate the transformed artifact if it has been deleted > > > Key: MNG-8160 > URL: https://issues.apache.org/jira/browse/MNG-8160 > Project: Maven > Issue Type: Bug > Components: Core >Affects Versions: 4.0.0-beta-3 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-4 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MASFRES-70] Use custom property name for local IT repo [maven-apache-resources]
kwin merged PR #15: URL: https://github.com/apache/maven-apache-resources/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MASFRES-70) ITs in ASF Jenkins use wrong artifact for testing
[
https://issues.apache.org/jira/browse/MASFRES-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MASFRES-70.
Fix Version/s: apache-resources 1.6
Assignee: Konrad Windszus
Resolution: Fixed
Fixed in
https://github.com/apache/maven-apache-resources/commit/2444289f5a9d0a2ff21e0e52742f2d5dda62007c
> ITs in ASF Jenkins use wrong artifact for testing
> -
>
> Key: MASFRES-70
> URL: https://issues.apache.org/jira/browse/MASFRES-70
> Project: Apache Maven Resource Bundles
> Issue Type: Bug
> Components: apache-source-release-assembly-descriptor
>Affects Versions: apache-resources 1.5
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: apache-resources 1.6
>
>
> In module {{source-release}} the ITs incorrectly use the workspace repository
> location (.repository) instead of using the prepopulated repository
> (containing the previously built artifact) from target/it-repo.
> This only happens in ASF Jenkins (while GitHub Actions use the correct local
> repo in ITs).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-584] JDK transport GOAWAY fix [maven-resolver]
cstamas commented on PR #532: URL: https://github.com/apache/maven-resolver/pull/532#issuecomment-2226852534 This fix is wrong. Tested using reproducer https://issues.apache.org/jira/browse/MNG-8145 (reused same config and all). Maven 4.0.0-beta-3 fails (reproducer reproduces). And this PR built JDK transport works OK. BUT, the reason why it works is due this PR "shortening" the lifespan of JDK HttpClient, and not due "client swap". When I set nginx config from original `keepalive_requests 500;` to `keepalive_requests 100;` (or even 50), this PR fails in very same way. Still, the PR is correct in a way it keeps HttpClient per Transporter instance, and that is _correct change_. Will see in some other solution... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-584) Jetty / JDK transport: HTTP2 GOAWAY handling
[
https://issues.apache.org/jira/browse/MRESOLVER-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865669#comment-17865669
]
ASF GitHub Bot commented on MRESOLVER-584:
--
cstamas commented on PR #532:
URL: https://github.com/apache/maven-resolver/pull/532#issuecomment-2226852534
This fix is wrong.
Tested using reproducer https://issues.apache.org/jira/browse/MNG-8145
(reused same config and all).
Maven 4.0.0-beta-3 fails (reproducer reproduces). And this PR built JDK
transport works OK.
BUT, the reason why it works is due this PR "shortening" the lifespan of JDK
HttpClient, and not due "client swap".
When I set nginx config from original `keepalive_requests 500;` to
`keepalive_requests 100;` (or even 50), this PR fails in very same way.
Still, the PR is correct in a way it keeps HttpClient per Transporter
instance, and that is _correct change_.
Will see in some other solution...
> Jetty / JDK transport: HTTP2 GOAWAY handling
> -
>
> Key: MRESOLVER-584
> URL: https://issues.apache.org/jira/browse/MRESOLVER-584
> Project: Maven Resolver
> Issue Type: Bug
> Components: Resolver
>Affects Versions: 2.0.0-alpha-2, 2.0.0-alpha-3, 2.0.0-alpha-4,
> 2.0.0-alpha-5, 2.0.0-alpha-6, 2.0.0-alpha-7, 2.0.0-alpha-8, 2.0.0,
> 2.0.0-alpha-9, 2.0.0-alpha-10, 2.0.0-alpha-11
>Reporter: Paul Scholz
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 2.0.1
>
> Attachments: exception.log, exception_jetty.log
>
>
> I am encountering a problem with the implementation of JDK transport using
> HTTP/2, specifically related to re-establishing connections after receiving a
> GOAWAY frame. (RFC quote below)
> Just for example a nginx server with default configuration does only allow
> 1000 requests per connection before requiring "establishing a new connection".
> This results in IOException, stopping resolution process: [^exception.log].
> {code:java}
> Caused by: java.io.IOException: /10.8.2.106:51760: GOAWAY received
> at jdk.internal.net.http.HttpClientImpl.send(HttpClientImpl.java:586)
> at jdk.internal.net.http.HttpClientFacade.send(HttpClientFacade.java:123)
> at
> org.eclipse.aether.transport.jdk.JdkTransporter.send(JdkTransporter.java:392)
> at
> org.eclipse.aether.transport.jdk.JdkTransporter.implGet(JdkTransporter.java:271)
> at
> org.eclipse.aether.spi.connector.transport.AbstractTransporter.get(AbstractTransporter.java:64)
> at
> org.eclipse.aether.connector.basic.BasicRepositoryConnector$GetTaskRunner.runTask(BasicRepositoryConnector.java:501)
> at
> org.eclipse.aether.connector.basic.BasicRepositoryConnector$TaskRunner.run(BasicRepositoryConnector.java:433)
> at
> org.eclipse.aether.util.concurrency.RunnableErrorForwarder.lambda$wrap$0(RunnableErrorForwarder.java:66)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at java.lang.Thread.run(Thread.java:840)
> Caused by: java.io.IOException: /10.8.2.106:51760: GOAWAY received
> at
> jdk.internal.net.http.Http2Connection.handleGoAway(Http2Connection.java:1009)
> at
> jdk.internal.net.http.Http2Connection.handleConnectionFrame(Http2Connection.java:874)
> at
> jdk.internal.net.http.Http2Connection.processFrame(Http2Connection.java:749)
> ...
> {code}
> Related to: [How to handle HTTP/2 GOAWAY with
> java.net.HttpClient?|https://stackoverflow.com/a/55092354]
>
> {quote}Sets the maximum number of requests (...) that can be served through
> one HTTP/2 connection, after which the next client request will lead to
> connection closing and the need of establishing a new connection.
> --
> [https://nginx.org/en/docs/http/ngx_http_v2_module.html#http2_max_requests|http://nginx.org/en/docs/http/ngx_http_v2_module.html#http2_max_requests]
> [–
> https://nginx.org/en/docs/http/ngx_http_core_module.html#keepalive_requests|https://nginx.org/en/docs/http/ngx_http_core_module.html#keepalive_requests]
> {quote}
>
> {quote}Once sent, the sender will ignore frames sent on streams initiated by
> the receiver if the stream has an identifier higher than the included last
> stream identifier. Receivers of a GOAWAY frame MUST NOT open additional
> streams on the connection, although a new connection can be established for
> new streams.
> – [RFC 7540 6.7|https://datatracker.ietf.org/doc/html/rfc7540#section-6.8]
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MASFRES-67] Add IT for excluded ".flattened-pom.xml" [maven-apache-resources]
kwin merged PR #14: URL: https://github.com/apache/maven-apache-resources/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MASFRES-69] Allow files/directories with names containing "target" [maven-apache-resources]
kwin merged PR #13: URL: https://github.com/apache/maven-apache-resources/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MASFRES-69) All files having a filename containing "target" are excluded
[
https://issues.apache.org/jira/browse/MASFRES-69?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MASFRES-69.
Resolution: Fixed
Fixed in
https://github.com/apache/maven-apache-resources/commit/52331f14fbeb86839558bca76070711335260295.
> All files having a filename containing "target" are excluded
>
>
> Key: MASFRES-69
> URL: https://issues.apache.org/jira/browse/MASFRES-69
> Project: Apache Maven Resource Bundles
> Issue Type: Bug
> Components: apache-source-release-assembly-descriptor
>Affects Versions: apache-resources 1.5
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: apache-resources 1.6
>
>
> Due to the exclude pattern from
> https://github.com/apache/maven-apache-resources/blame/f609acfd574277be6382ce381f65cab2db895d8d/source-release/src/main/resources/assemblies/source-shared.xml#L30
> every file/directory with a name containing {{target}} is excluded.
> This e.g. affects the file
> https://github.com/apache/jackrabbit-filevault/blob/master/vault-sync/min-target.bndrun
> which is relevant for the build, but is excluded due to having {{target}}
> (${project.build.directory}) in its name. Also the module
> https://github.com/apache/jackrabbit-filevault/tree/master/target-osgi-environment
> including its children are missing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MSHADE-479) Demote logging of shaded files to debug
[ https://issues.apache.org/jira/browse/MSHADE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MSHADE-479: Assignee: Elliotte Rusty Harold > Demote logging of shaded files to debug > --- > > Key: MSHADE-479 > URL: https://issues.apache.org/jira/browse/MSHADE-479 > Project: Maven Shade Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > Output from a recent failing build where I was looking for a test failure: > ``` > [INFO] Including > com.facebook.presto:presto-benchmark-driver:jar:0.289-SNAPSHOT in the shaded > jar. > [INFO] Including com.facebook.presto.scribe:presto-scribe-client:jar:1.16 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-api:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.airlift:concurrent:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:configuration:jar:0.209 in the shaded > jar. > [INFO] Including cglib:cglib-nodep:jar:3.2.5 in the shaded jar. > [INFO] Including com.facebook.airlift:stats:jar:0.209 in the shaded jar. > [INFO] Including org.hdrhistogram:HdrHistogram:jar:2.1.9 in the shaded jar. > [INFO] Including io.airlift:slice:jar:0.38 in the shaded jar. > [INFO] Including org.openjdk.jol:jol-core:jar:0.2 in the shaded jar. > [INFO] Including com.facebook.airlift:event:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:node:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:http-client:jar:0.209 in the shaded jar. > [INFO] Including ch.qos.logback:logback-core:jar:1.2.3 in the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-client:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-io:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-util:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-http:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-common:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-hpack:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-alpn-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.14.v20181114 in the shaded > jar. > [INFO] Including com.facebook.airlift:http-utils:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:trace-token:jar:0.209 in the shaded jar. > [INFO] Including net.jodah:failsafe:jar:2.0.1 in the shaded jar. > [INFO] Including com.facebook.airlift:discovery:jar:0.209 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:json:jar:0.209 in the shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-guava:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:log:jar:0.209 in the shaded jar. > [INFO] Including io.airlift:units:jar:1.3 in the shaded jar. > [INFO] Including org.weakref:jmxutils:jar:1.19 in the shaded jar. > [INFO] Including com.google.inject:guice:jar:4.2.2 in the shaded jar. > [INFO] Including aopalliance:aopalliance:jar:1.0 in the shaded jar. > [INFO] Including javax.inject:javax.inject:jar:1 in the shaded jar. > [INFO] Including javax.annotation:javax.annotation-api:jar:1.3.2 in the > shaded jar. > [INFO] Including javax.validation:validation-api:jar:2.0.1.Final in the > shaded jar. > [INFO] Including joda-time:joda-time:jar:2.12.7 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.11.0 in > the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.11.0 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-codec:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.drift:drift-protocol:jar:1.38 in the shaded jar. > [INFO] Including io.airlif
[jira] [Commented] (MSHADE-479) Demote logging of shaded files to debug
[ https://issues.apache.org/jira/browse/MSHADE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865673#comment-17865673 ] ASF GitHub Bot commented on MSHADE-479: --- elharo opened a new pull request, #233: URL: https://github.com/apache/maven-shade-plugin/pull/233 This removes multiple screens of log cruft from every build that uses the shade plugin. > Demote logging of shaded files to debug > --- > > Key: MSHADE-479 > URL: https://issues.apache.org/jira/browse/MSHADE-479 > Project: Maven Shade Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > Output from a recent failing build where I was looking for a test failure: > ``` > [INFO] Including > com.facebook.presto:presto-benchmark-driver:jar:0.289-SNAPSHOT in the shaded > jar. > [INFO] Including com.facebook.presto.scribe:presto-scribe-client:jar:1.16 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-api:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.airlift:concurrent:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:configuration:jar:0.209 in the shaded > jar. > [INFO] Including cglib:cglib-nodep:jar:3.2.5 in the shaded jar. > [INFO] Including com.facebook.airlift:stats:jar:0.209 in the shaded jar. > [INFO] Including org.hdrhistogram:HdrHistogram:jar:2.1.9 in the shaded jar. > [INFO] Including io.airlift:slice:jar:0.38 in the shaded jar. > [INFO] Including org.openjdk.jol:jol-core:jar:0.2 in the shaded jar. > [INFO] Including com.facebook.airlift:event:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:node:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:http-client:jar:0.209 in the shaded jar. > [INFO] Including ch.qos.logback:logback-core:jar:1.2.3 in the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-client:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-io:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-util:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-http:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-common:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-hpack:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-alpn-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.14.v20181114 in the shaded > jar. > [INFO] Including com.facebook.airlift:http-utils:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:trace-token:jar:0.209 in the shaded jar. > [INFO] Including net.jodah:failsafe:jar:2.0.1 in the shaded jar. > [INFO] Including com.facebook.airlift:discovery:jar:0.209 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:json:jar:0.209 in the shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-guava:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:log:jar:0.209 in the shaded jar. > [INFO] Including io.airlift:units:jar:1.3 in the shaded jar. > [INFO] Including org.weakref:jmxutils:jar:1.19 in the shaded jar. > [INFO] Including com.google.inject:guice:jar:4.2.2 in the shaded jar. > [INFO] Including aopalliance:aopalliance:jar:1.0 in the shaded jar. > [INFO] Including javax.inject:javax.inject:jar:1 in the shaded jar. > [INFO] Including javax.annotation:javax.annotation-api:jar:1.3.2 in the > shaded jar. > [INFO] Including javax.validation:validation-api:jar:2.0.1.Final in the > shaded jar. > [INFO] Including joda-time:joda-time:jar:2.12.7 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.11.0 in > the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.11.0 in > the
Re: [PR] [MSHADE-479] Make the mojo much less noisy [maven-shade-plugin]
elharo commented on PR #233: URL: https://github.com/apache/maven-shade-plugin/pull/233#issuecomment-2226880485 Flakes: [INFO] Error: Failed to execute goal on project shadeMT4: Could not resolve dependencies for project org.apache.maven.its.shade.parallel:shadeMT4:jar:1.0.0-SNAPSHOT: Could not transfer artifact org.springframework:spring-aop:jar:5.3.31 from/to mrm-maven-plugin (http://localhost:50540): D:\a\maven-shade-plugin\maven-shade-plugin\target\local-repo\org\springframework\spring-aop\5.3.31\spring-aop-5.3.31.jar.part.lock (Access is denied) -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project shadeMT4: Could not resolve dependencies for project org.apache.maven.its.shade.parallel:shadeMT4:jar:1.0.0-SNAPSHOT: Could not transfer artifact org.springframework:spring-aop:jar:5.3.31 from/to mrm-maven-plugin (http://localhost:50540): D:\a\maven-shade-plugin\maven-shade-plugin\target\local-repo\org\springframework\spring-aop\5.3.31\spring-aop-5.3.31.jar.part.lock (Access is denied) at org.apache.maven.lifecyc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-479) Demote logging of shaded files to debug
[ https://issues.apache.org/jira/browse/MSHADE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865677#comment-17865677 ] ASF GitHub Bot commented on MSHADE-479: --- elharo commented on PR #233: URL: https://github.com/apache/maven-shade-plugin/pull/233#issuecomment-2226880485 Flakes: [INFO] Error: Failed to execute goal on project shadeMT4: Could not resolve dependencies for project org.apache.maven.its.shade.parallel:shadeMT4:jar:1.0.0-SNAPSHOT: Could not transfer artifact org.springframework:spring-aop:jar:5.3.31 from/to mrm-maven-plugin (http://localhost:50540): D:\a\maven-shade-plugin\maven-shade-plugin\target\local-repo\org\springframework\spring-aop\5.3.31\spring-aop-5.3.31.jar.part.lock (Access is denied) -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project shadeMT4: Could not resolve dependencies for project org.apache.maven.its.shade.parallel:shadeMT4:jar:1.0.0-SNAPSHOT: Could not transfer artifact org.springframework:spring-aop:jar:5.3.31 from/to mrm-maven-plugin (http://localhost:50540): D:\a\maven-shade-plugin\maven-shade-plugin\target\local-repo\org\springframework\spring-aop\5.3.31\spring-aop-5.3.31.jar.part.lock (Access is denied) at org.apache.maven.lifecyc > Demote logging of shaded files to debug > --- > > Key: MSHADE-479 > URL: https://issues.apache.org/jira/browse/MSHADE-479 > Project: Maven Shade Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > Output from a recent failing build where I was looking for a test failure: > ``` > [INFO] Including > com.facebook.presto:presto-benchmark-driver:jar:0.289-SNAPSHOT in the shaded > jar. > [INFO] Including com.facebook.presto.scribe:presto-scribe-client:jar:1.16 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-api:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.airlift:concurrent:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:configuration:jar:0.209 in the shaded > jar. > [INFO] Including cglib:cglib-nodep:jar:3.2.5 in the shaded jar. > [INFO] Including com.facebook.airlift:stats:jar:0.209 in the shaded jar. > [INFO] Including org.hdrhistogram:HdrHistogram:jar:2.1.9 in the shaded jar. > [INFO] Including io.airlift:slice:jar:0.38 in the shaded jar. > [INFO] Including org.openjdk.jol:jol-core:jar:0.2 in the shaded jar. > [INFO] Including com.facebook.airlift:event:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:node:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:http-client:jar:0.209 in the shaded jar. > [INFO] Including ch.qos.logback:logback-core:jar:1.2.3 in the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-client:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-io:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-util:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-http:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-common:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-hpack:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-alpn-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.14.v20181114 in the shaded > jar. > [INFO] Including com.facebook.airlift:http-utils:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:trace-token:jar:0.209 in the shaded jar. > [INFO] Including net.jodah:failsafe:jar:2.0.1 in the shaded jar. > [INFO] Including com.facebook.airlift:discovery:jar:0.209 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:json:jar:0.209 in the shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-guava:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.module:jackson-module-parameter-names
[jira] [Commented] (MSHADE-479) Demote logging of shaded files to debug
[ https://issues.apache.org/jira/browse/MSHADE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865680#comment-17865680 ] ASF GitHub Bot commented on MSHADE-479: --- elharo merged PR #233: URL: https://github.com/apache/maven-shade-plugin/pull/233 > Demote logging of shaded files to debug > --- > > Key: MSHADE-479 > URL: https://issues.apache.org/jira/browse/MSHADE-479 > Project: Maven Shade Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > > Output from a recent failing build where I was looking for a test failure: > ``` > [INFO] Including > com.facebook.presto:presto-benchmark-driver:jar:0.289-SNAPSHOT in the shaded > jar. > [INFO] Including com.facebook.presto.scribe:presto-scribe-client:jar:1.16 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-api:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.airlift:concurrent:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:configuration:jar:0.209 in the shaded > jar. > [INFO] Including cglib:cglib-nodep:jar:3.2.5 in the shaded jar. > [INFO] Including com.facebook.airlift:stats:jar:0.209 in the shaded jar. > [INFO] Including org.hdrhistogram:HdrHistogram:jar:2.1.9 in the shaded jar. > [INFO] Including io.airlift:slice:jar:0.38 in the shaded jar. > [INFO] Including org.openjdk.jol:jol-core:jar:0.2 in the shaded jar. > [INFO] Including com.facebook.airlift:event:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:node:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:http-client:jar:0.209 in the shaded jar. > [INFO] Including ch.qos.logback:logback-core:jar:1.2.3 in the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-client:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-io:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-util:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-http:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-common:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-hpack:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-alpn-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.14.v20181114 in the shaded > jar. > [INFO] Including com.facebook.airlift:http-utils:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:trace-token:jar:0.209 in the shaded jar. > [INFO] Including net.jodah:failsafe:jar:2.0.1 in the shaded jar. > [INFO] Including com.facebook.airlift:discovery:jar:0.209 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:json:jar:0.209 in the shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-guava:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:log:jar:0.209 in the shaded jar. > [INFO] Including io.airlift:units:jar:1.3 in the shaded jar. > [INFO] Including org.weakref:jmxutils:jar:1.19 in the shaded jar. > [INFO] Including com.google.inject:guice:jar:4.2.2 in the shaded jar. > [INFO] Including aopalliance:aopalliance:jar:1.0 in the shaded jar. > [INFO] Including javax.inject:javax.inject:jar:1 in the shaded jar. > [INFO] Including javax.annotation:javax.annotation-api:jar:1.3.2 in the > shaded jar. > [INFO] Including javax.validation:validation-api:jar:2.0.1.Final in the > shaded jar. > [INFO] Including joda-time:joda-time:jar:2.12.7 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.11.0 in > the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.11.0 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-codec:jar:1.38 in the shaded jar. > [INFO] Including com.
[jira] [Updated] (MSHADE-479) Demote logging of shaded files to debug
[ https://issues.apache.org/jira/browse/MSHADE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MSHADE-479: - Fix Version/s: 3.6.1 > Demote logging of shaded files to debug > --- > > Key: MSHADE-479 > URL: https://issues.apache.org/jira/browse/MSHADE-479 > Project: Maven Shade Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.6.1 > > > Output from a recent failing build where I was looking for a test failure: > ``` > [INFO] Including > com.facebook.presto:presto-benchmark-driver:jar:0.289-SNAPSHOT in the shaded > jar. > [INFO] Including com.facebook.presto.scribe:presto-scribe-client:jar:1.16 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-api:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.airlift:concurrent:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:configuration:jar:0.209 in the shaded > jar. > [INFO] Including cglib:cglib-nodep:jar:3.2.5 in the shaded jar. > [INFO] Including com.facebook.airlift:stats:jar:0.209 in the shaded jar. > [INFO] Including org.hdrhistogram:HdrHistogram:jar:2.1.9 in the shaded jar. > [INFO] Including io.airlift:slice:jar:0.38 in the shaded jar. > [INFO] Including org.openjdk.jol:jol-core:jar:0.2 in the shaded jar. > [INFO] Including com.facebook.airlift:event:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:node:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:http-client:jar:0.209 in the shaded jar. > [INFO] Including ch.qos.logback:logback-core:jar:1.2.3 in the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-client:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-io:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-util:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-http:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-common:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-hpack:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-alpn-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.14.v20181114 in the shaded > jar. > [INFO] Including com.facebook.airlift:http-utils:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:trace-token:jar:0.209 in the shaded jar. > [INFO] Including net.jodah:failsafe:jar:2.0.1 in the shaded jar. > [INFO] Including com.facebook.airlift:discovery:jar:0.209 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:json:jar:0.209 in the shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-guava:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:log:jar:0.209 in the shaded jar. > [INFO] Including io.airlift:units:jar:1.3 in the shaded jar. > [INFO] Including org.weakref:jmxutils:jar:1.19 in the shaded jar. > [INFO] Including com.google.inject:guice:jar:4.2.2 in the shaded jar. > [INFO] Including aopalliance:aopalliance:jar:1.0 in the shaded jar. > [INFO] Including javax.inject:javax.inject:jar:1 in the shaded jar. > [INFO] Including javax.annotation:javax.annotation-api:jar:1.3.2 in the > shaded jar. > [INFO] Including javax.validation:validation-api:jar:2.0.1.Final in the > shaded jar. > [INFO] Including joda-time:joda-time:jar:2.12.7 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.11.0 in > the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.11.0 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-codec:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.drift:drift-protocol:jar:1.38 in the shaded jar. > [INFO] Includ
[jira] [Resolved] (MSHADE-479) Demote logging of shaded files to debug
[ https://issues.apache.org/jira/browse/MSHADE-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MSHADE-479. -- Resolution: Fixed > Demote logging of shaded files to debug > --- > > Key: MSHADE-479 > URL: https://issues.apache.org/jira/browse/MSHADE-479 > Project: Maven Shade Plugin > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.6.1 > > > Output from a recent failing build where I was looking for a test failure: > ``` > [INFO] Including > com.facebook.presto:presto-benchmark-driver:jar:0.289-SNAPSHOT in the shaded > jar. > [INFO] Including com.facebook.presto.scribe:presto-scribe-client:jar:1.16 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-api:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.airlift:concurrent:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:configuration:jar:0.209 in the shaded > jar. > [INFO] Including cglib:cglib-nodep:jar:3.2.5 in the shaded jar. > [INFO] Including com.facebook.airlift:stats:jar:0.209 in the shaded jar. > [INFO] Including org.hdrhistogram:HdrHistogram:jar:2.1.9 in the shaded jar. > [INFO] Including io.airlift:slice:jar:0.38 in the shaded jar. > [INFO] Including org.openjdk.jol:jol-core:jar:0.2 in the shaded jar. > [INFO] Including com.facebook.airlift:event:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:node:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:http-client:jar:0.209 in the shaded jar. > [INFO] Including ch.qos.logback:logback-core:jar:1.2.3 in the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-client:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-io:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-util:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty:jetty-http:jar:9.4.14.v20181114 in the > shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-common:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty.http2:http2-hpack:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including org.eclipse.jetty:jetty-alpn-client:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty.http2:http2-http-client-transport:jar:9.4.14.v20181114 in > the shaded jar. > [INFO] Including > org.eclipse.jetty:jetty-alpn-java-client:jar:9.4.14.v20181114 in the shaded > jar. > [INFO] Including com.facebook.airlift:http-utils:jar:0.209 in the shaded jar. > [INFO] Including com.facebook.airlift:trace-token:jar:0.209 in the shaded jar. > [INFO] Including net.jodah:failsafe:jar:2.0.1 in the shaded jar. > [INFO] Including com.facebook.airlift:discovery:jar:0.209 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-core:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:json:jar:0.209 in the shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jdk8:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-guava:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.datatype:jackson-datatype-joda:jar:2.11.0 in the shaded > jar. > [INFO] Including > com.fasterxml.jackson.module:jackson-module-parameter-names:jar:2.11.0 in the > shaded jar. > [INFO] Including > com.fasterxml.jackson.dataformat:jackson-dataformat-smile:jar:2.11.0 in the > shaded jar. > [INFO] Including com.facebook.airlift:log:jar:0.209 in the shaded jar. > [INFO] Including io.airlift:units:jar:1.3 in the shaded jar. > [INFO] Including org.weakref:jmxutils:jar:1.19 in the shaded jar. > [INFO] Including com.google.inject:guice:jar:4.2.2 in the shaded jar. > [INFO] Including aopalliance:aopalliance:jar:1.0 in the shaded jar. > [INFO] Including javax.inject:javax.inject:jar:1 in the shaded jar. > [INFO] Including javax.annotation:javax.annotation-api:jar:1.3.2 in the > shaded jar. > [INFO] Including javax.validation:validation-api:jar:2.0.1.Final in the > shaded jar. > [INFO] Including joda-time:joda-time:jar:2.12.7 in the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-annotations:jar:2.11.0 in > the shaded jar. > [INFO] Including com.fasterxml.jackson.core:jackson-databind:jar:2.11.0 in > the shaded jar. > [INFO] Including com.facebook.drift:drift-codec:jar:1.38 in the shaded jar. > [INFO] Including com.facebook.drift:drift-protocol:jar:1.38 in the shaded jar. > [INFO] Includi
[jira] [Created] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
Guillaume Smet created MRESOLVER-586: Summary: In typical setups, DefaultArtifact copies the same maps over and over again Key: MRESOLVER-586 URL: https://issues.apache.org/jira/browse/MRESOLVER-586 Project: Maven Resolver Issue Type: Improvement Components: Resolver Affects Versions: 1.9.21 Reporter: Guillaume Smet h2. Context This is part of some work we are trying to do to reduce the build time usage memory of Quarkus. We discussed this a bit with Tamas. While this doesn't constitute a fix for our main issue, it should be an easy win. h2. Problem We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, the managed dependencies are copied to the descriptors using the `convert` method that in turn will create a new DefaultArtifact. Most of these DefaultArtifacts contain a copy of the very same `type.getProperties()` as they don't have specific artifact properties. Improving the DefaultArtifact#merge() method to avoid the copy when the artifact doesn't have any specific properties would already be an easy win. PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MRESOLVER-586] Avoid copying the type default properties map [maven-resolver]
gsmet opened a new pull request, #534: URL: https://github.com/apache/maven-resolver/pull/534 When we don't have specific properties for a DefaultArtifact, we can just reuse the type default properties map as it's readonly and immutable. The patch contains some additional changes as I renamed the method and parameters to make them more specific so that the method wouldn't be used for things that wouldn't be safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
[ https://issues.apache.org/jira/browse/MRESOLVER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865688#comment-17865688 ] ASF GitHub Bot commented on MRESOLVER-586: -- gsmet opened a new pull request, #534: URL: https://github.com/apache/maven-resolver/pull/534 When we don't have specific properties for a DefaultArtifact, we can just reuse the type default properties map as it's readonly and immutable. The patch contains some additional changes as I renamed the method and parameters to make them more specific so that the method wouldn't be used for things that wouldn't be safe. > In typical setups, DefaultArtifact copies the same maps over and over again > --- > > Key: MRESOLVER-586 > URL: https://issues.apache.org/jira/browse/MRESOLVER-586 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 1.9.21 >Reporter: Guillaume Smet >Priority: Major > > h2. Context > This is part of some work we are trying to do to reduce the build time usage > memory of Quarkus. > We discussed this a bit with Tamas. > While this doesn't constitute a fix for our main issue, it should be an easy > win. > h2. Problem > We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, > the managed dependencies are copied to the descriptors using the `convert` > method that in turn will create a new DefaultArtifact. > Most of these DefaultArtifacts contain a copy of the very same > `type.getProperties()` as they don't have specific artifact properties. > Improving the DefaultArtifact#merge() method to avoid the copy when the > artifact doesn't have any specific properties would already be an easy win. > PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
[ https://issues.apache.org/jira/browse/MRESOLVER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865689#comment-17865689 ] Guillaume Smet commented on MRESOLVER-586: -- See https://github.com/apache/maven-resolver/pull/534 for a PR fixing the issue. > In typical setups, DefaultArtifact copies the same maps over and over again > --- > > Key: MRESOLVER-586 > URL: https://issues.apache.org/jira/browse/MRESOLVER-586 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 1.9.21 >Reporter: Guillaume Smet >Priority: Major > > h2. Context > This is part of some work we are trying to do to reduce the build time usage > memory of Quarkus. > We discussed this a bit with Tamas. > While this doesn't constitute a fix for our main issue, it should be an easy > win. > h2. Problem > We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, > the managed dependencies are copied to the descriptors using the `convert` > method that in turn will create a new DefaultArtifact. > Most of these DefaultArtifacts contain a copy of the very same > `type.getProperties()` as they don't have specific artifact properties. > Improving the DefaultArtifact#merge() method to avoid the copy when the > artifact doesn't have any specific properties would already be an easy win. > PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MRESOLVER-586] Avoid copying the type default properties map [maven-resolver]
gsmet commented on PR #534: URL: https://github.com/apache/maven-resolver/pull/534#issuecomment-2226920768 BTW, it would be awesome if it could get backported to the `maven-resolver-1.9.x` branch (I can do the grunt work if it's not a clean backport) as we will be stuck on Maven 3.9 for some time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
[ https://issues.apache.org/jira/browse/MRESOLVER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865690#comment-17865690 ] ASF GitHub Bot commented on MRESOLVER-586: -- gsmet commented on PR #534: URL: https://github.com/apache/maven-resolver/pull/534#issuecomment-2226920768 BTW, it would be awesome if it could get backported to the `maven-resolver-1.9.x` branch (I can do the grunt work if it's not a clean backport) as we will be stuck on Maven 3.9 for some time. > In typical setups, DefaultArtifact copies the same maps over and over again > --- > > Key: MRESOLVER-586 > URL: https://issues.apache.org/jira/browse/MRESOLVER-586 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 1.9.21 >Reporter: Guillaume Smet >Priority: Major > > h2. Context > This is part of some work we are trying to do to reduce the build time usage > memory of Quarkus. > We discussed this a bit with Tamas. > While this doesn't constitute a fix for our main issue, it should be an easy > win. > h2. Problem > We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, > the managed dependencies are copied to the descriptors using the `convert` > method that in turn will create a new DefaultArtifact. > Most of these DefaultArtifacts contain a copy of the very same > `type.getProperties()` as they don't have specific artifact properties. > Improving the DefaultArtifact#merge() method to avoid the copy when the > artifact doesn't have any specific properties would already be an easy win. > PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-689] Fixes ignored dependency filtering in go-offline goal [maven-dependency-plugin]
slawekjaranowski commented on code in PR #417:
URL:
https://github.com/apache/maven-dependency-plugin/pull/417#discussion_r1676833449
##
src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java:
##
@@ -152,6 +169,46 @@ protected Set resolvePluginArtifacts() throws
DependencyResolverExcept
return resolveDependableCoordinate(buildingRequest,
dependableCoordinates, "plugins");
}
+protected FilterArtifacts getArtifactsFilter() {
+final FilterArtifacts filter = new FilterArtifacts();
+
Review Comment:
We have the same method in `ResolvePluginsMojo` - we can move it to
`AbstractDependencyFilterMojo`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-689) Dependency filtering are ignored in go-offline
[
https://issues.apache.org/jira/browse/MDEP-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865692#comment-17865692
]
ASF GitHub Bot commented on MDEP-689:
-
slawekjaranowski commented on code in PR #417:
URL:
https://github.com/apache/maven-dependency-plugin/pull/417#discussion_r1676833449
##
src/main/java/org/apache/maven/plugins/dependency/resolvers/GoOfflineMojo.java:
##
@@ -152,6 +169,46 @@ protected Set resolvePluginArtifacts() throws
DependencyResolverExcept
return resolveDependableCoordinate(buildingRequest,
dependableCoordinates, "plugins");
}
+protected FilterArtifacts getArtifactsFilter() {
+final FilterArtifacts filter = new FilterArtifacts();
+
Review Comment:
We have the same method in `ResolvePluginsMojo` - we can move it to
`AbstractDependencyFilterMojo`
> Dependency filtering are ignored in go-offline
> --
>
> Key: MDEP-689
> URL: https://issues.apache.org/jira/browse/MDEP-689
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: go-offline
>Affects Versions: 3.1.2
> Environment: mvn -V
> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/local/share/java/maven3
> Java version: 1.8.0_241, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_241.jdk/Contents/Home/jre
> Default locale: fr_FR, platform encoding: UTF-8
> OS name: "mac os x", version: "10.15.4", arch: "x86_64", family: "mac"
>Reporter: Fabrice Bacchella
>Priority: Major
>
> I'm using a multi-modules project.
> I tried as a work around of bug MDEP-688 to tells go-offline to ignore a
> broken dependency being:
> {code:xml}
>
> org.dojotoolkit
> dojo
> zip
> 1.10.8
> distribution
>
> {code}
> . But whatever I tried, my filter are ignored:
> {code:java}
> mvn -B dependency:go-offline -Psonar,versions -Dmaven.repo.local=/tmp/m2
> -DexcludeGroupIds=org.dojotoolkit -DexcludeClassifiers=distribution
> -DexcludeArtifactIds=org.dojotoolkit:dojo:zip:1.10.8,dojo -DexcludeTypes=zip
> -Dtype=jar,war,pom -X
> ...
> [DEBUG] Configuring mojo
> 'org.apache.maven.plugins:maven-dependency-plugin:3.1.2:go-offline' with
> basic configurator -->
> [DEBUG] (f) appendOutput = false
> [DEBUG] (f) excludeArtifactIds = org.dojotoolkit:dojo:zip:1.10.8,dojo
> [DEBUG] (f) excludeClassifiers = distribution
> [DEBUG] (f) excludeGroupIds = org.dojotoolkit
> [DEBUG] (f) excludeReactor = true
> [DEBUG] (f) excludeTransitive = false
> [DEBUG] (f) excludeTypes = zip
> [DEBUG] (s) markersDirectory =
> .../jrds-webapp/target/dependency-maven-plugin-markers
> [DEBUG] (f) outputAbsoluteArtifactFilename = false
> [DEBUG] (f) overWriteIfNewer = true
> [DEBUG] (f) overWriteReleases = false
> [DEBUG] (f) overWriteSnapshots = false
> [DEBUG] (s) prependGroupId = false
> [DEBUG] (f) project = MavenProject: fr.jrds:jrds-webapp:2020.1 @
> /Users/fa4/Devl/jrds/jrds-webapp/pom.xml
> ...
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-dependency-plugin:3.1.2:go-offline
> (default-cli) on project jrds-webapp:
> org.eclipse.aether.resolution.DependencyResolutionException: Could not find
> artifact org.dojotoolkit:dojo:zip:1.10.8 in central
> (https://repo.maven.apache.org/maven2) -> [Help 1]
> {code}
> So I tried everything to prevent the failing artifact to be resolved, nothing
> succeeded.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] [MRESOLVER-586] Avoid copying the type default properties map [maven-resolver]
gsmet opened a new pull request, #535: URL: https://github.com/apache/maven-resolver/pull/535 > [!NOTE] > I needed a backport for my internal testing and it wasn't clean so here it is. When we don't have specific properties for a DefaultArtifact, we can just reuse the type default properties map as it's readonly and immutable. The patch contains some additional changes as I renamed the method and parameters to make them more specific so that the method wouldn't be used for things that wouldn't be safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MRESOLVER-586] Avoid copying the type default properties map [maven-resolver]
gsmet commented on PR #534: URL: https://github.com/apache/maven-resolver/pull/534#issuecomment-2226940621 Backport for branch 1.9 is here: https://github.com/apache/maven-resolver/pull/535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
[ https://issues.apache.org/jira/browse/MRESOLVER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865696#comment-17865696 ] ASF GitHub Bot commented on MRESOLVER-586: -- gsmet opened a new pull request, #535: URL: https://github.com/apache/maven-resolver/pull/535 > [!NOTE] > I needed a backport for my internal testing and it wasn't clean so here it is. When we don't have specific properties for a DefaultArtifact, we can just reuse the type default properties map as it's readonly and immutable. The patch contains some additional changes as I renamed the method and parameters to make them more specific so that the method wouldn't be used for things that wouldn't be safe. > In typical setups, DefaultArtifact copies the same maps over and over again > --- > > Key: MRESOLVER-586 > URL: https://issues.apache.org/jira/browse/MRESOLVER-586 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 1.9.21 >Reporter: Guillaume Smet >Priority: Major > > h2. Context > This is part of some work we are trying to do to reduce the build time usage > memory of Quarkus. > We discussed this a bit with Tamas. > While this doesn't constitute a fix for our main issue, it should be an easy > win. > h2. Problem > We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, > the managed dependencies are copied to the descriptors using the `convert` > method that in turn will create a new DefaultArtifact. > Most of these DefaultArtifacts contain a copy of the very same > `type.getProperties()` as they don't have specific artifact properties. > Improving the DefaultArtifact#merge() method to avoid the copy when the > artifact doesn't have any specific properties would already be an easy win. > PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
[ https://issues.apache.org/jira/browse/MRESOLVER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865697#comment-17865697 ] ASF GitHub Bot commented on MRESOLVER-586: -- gsmet commented on PR #534: URL: https://github.com/apache/maven-resolver/pull/534#issuecomment-2226940621 Backport for branch 1.9 is here: https://github.com/apache/maven-resolver/pull/535 > In typical setups, DefaultArtifact copies the same maps over and over again > --- > > Key: MRESOLVER-586 > URL: https://issues.apache.org/jira/browse/MRESOLVER-586 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 1.9.21 >Reporter: Guillaume Smet >Priority: Major > > h2. Context > This is part of some work we are trying to do to reduce the build time usage > memory of Quarkus. > We discussed this a bit with Tamas. > While this doesn't constitute a fix for our main issue, it should be an easy > win. > h2. Problem > We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, > the managed dependencies are copied to the descriptors using the `convert` > method that in turn will create a new DefaultArtifact. > Most of these DefaultArtifacts contain a copy of the very same > `type.getProperties()` as they don't have specific artifact properties. > Improving the DefaultArtifact#merge() method to avoid the copy when the > artifact doesn't have any specific properties would already be an easy win. > PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
[ https://issues.apache.org/jira/browse/MRESOLVER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-586: -- Fix Version/s: 2.0.1 1.9.22 > In typical setups, DefaultArtifact copies the same maps over and over again > --- > > Key: MRESOLVER-586 > URL: https://issues.apache.org/jira/browse/MRESOLVER-586 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 2.0.0, 1.9.21 >Reporter: Guillaume Smet >Priority: Major > Fix For: 2.0.1, 1.9.22 > > > h2. Context > This is part of some work we are trying to do to reduce the build time usage > memory of Quarkus. > We discussed this a bit with Tamas. > While this doesn't constitute a fix for our main issue, it should be an easy > win. > h2. Problem > We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, > the managed dependencies are copied to the descriptors using the `convert` > method that in turn will create a new DefaultArtifact. > Most of these DefaultArtifacts contain a copy of the very same > `type.getProperties()` as they don't have specific artifact properties. > Improving the DefaultArtifact#merge() method to avoid the copy when the > artifact doesn't have any specific properties would already be an easy win. > PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MRESOLVER-586) In typical setups, DefaultArtifact copies the same maps over and over again
[ https://issues.apache.org/jira/browse/MRESOLVER-586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-586: -- Affects Version/s: 2.0.0 > In typical setups, DefaultArtifact copies the same maps over and over again > --- > > Key: MRESOLVER-586 > URL: https://issues.apache.org/jira/browse/MRESOLVER-586 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: 2.0.0, 1.9.21 >Reporter: Guillaume Smet >Priority: Major > > h2. Context > This is part of some work we are trying to do to reduce the build time usage > memory of Quarkus. > We discussed this a bit with Tamas. > While this doesn't constitute a fix for our main issue, it should be an easy > win. > h2. Problem > We have a BOM with 2000+ entries and in `ArtifactDescriptorReaderDelegate`, > the managed dependencies are copied to the descriptors using the `convert` > method that in turn will create a new DefaultArtifact. > Most of these DefaultArtifacts contain a copy of the very same > `type.getProperties()` as they don't have specific artifact properties. > Improving the DefaultArtifact#merge() method to avoid the copy when the > artifact doesn't have any specific properties would already be an easy win. > PR to come. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MRESOLVER-587) Memory consumption improvements
Tamas Cservenak created MRESOLVER-587: - Summary: Memory consumption improvements Key: MRESOLVER-587 URL: https://issues.apache.org/jira/browse/MRESOLVER-587 Project: Maven Resolver Issue Type: Improvement Components: Resolver Reporter: Tamas Cservenak Fix For: 2.0.1, 1.9.22 In DataPool, following can be done to reduce memory usage: * ArtifactDescriptor key does not have to be Artifact instance, is really just GACEV needed (is identity) * ArtifactDescriptors could have "interned" the List fields as well -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]
cstamas opened a new pull request, #536: URL: https://github.com/apache/maven-resolver/pull/536 Do not use Artifact instance as keys, and intern the List on artifact descriptors as well. --- https://issues.apache.org/jira/browse/MRESOLVER-587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-587) Memory consumption improvements
[ https://issues.apache.org/jira/browse/MRESOLVER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865701#comment-17865701 ] ASF GitHub Bot commented on MRESOLVER-587: -- cstamas opened a new pull request, #536: URL: https://github.com/apache/maven-resolver/pull/536 Do not use Artifact instance as keys, and intern the List on artifact descriptors as well. --- https://issues.apache.org/jira/browse/MRESOLVER-587 > Memory consumption improvements > --- > > Key: MRESOLVER-587 > URL: https://issues.apache.org/jira/browse/MRESOLVER-587 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.1, 1.9.22 > > > In DataPool, following can be done to reduce memory usage: > * ArtifactDescriptor key does not have to be Artifact instance, is really > just GACEV needed (is identity) > * ArtifactDescriptors could have "interned" the List fields as > well -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]
cstamas opened a new pull request, #537: URL: https://github.com/apache/maven-resolver/pull/537 Do not use Artifact instance as keys, and intern the List on artifact descriptors as well. --- https://issues.apache.org/jira/browse/MRESOLVER-587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-587) Memory consumption improvements
[ https://issues.apache.org/jira/browse/MRESOLVER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865704#comment-17865704 ] ASF GitHub Bot commented on MRESOLVER-587: -- cstamas opened a new pull request, #537: URL: https://github.com/apache/maven-resolver/pull/537 Do not use Artifact instance as keys, and intern the List on artifact descriptors as well. --- https://issues.apache.org/jira/browse/MRESOLVER-587 > Memory consumption improvements > --- > > Key: MRESOLVER-587 > URL: https://issues.apache.org/jira/browse/MRESOLVER-587 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.1, 1.9.22 > > > In DataPool, following can be done to reduce memory usage: > * ArtifactDescriptor key does not have to be Artifact instance, is really > just GACEV needed (is identity) > * ArtifactDescriptors could have "interned" the List fields as > well -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-587) Memory consumption improvements
[ https://issues.apache.org/jira/browse/MRESOLVER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865705#comment-17865705 ] ASF GitHub Bot commented on MRESOLVER-587: -- cstamas opened a new pull request, #1617: URL: https://github.com/apache/maven/pull/1617 Testing https://github.com/apache/maven-resolver/pull/537 > Memory consumption improvements > --- > > Key: MRESOLVER-587 > URL: https://issues.apache.org/jira/browse/MRESOLVER-587 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.1, 1.9.22 > > > In DataPool, following can be done to reduce memory usage: > * ArtifactDescriptor key does not have to be Artifact instance, is really > just GACEV needed (is identity) > * ArtifactDescriptors could have "interned" the List fields as > well -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [Experiment] Leave out dep from depMgmt [maven]
cstamas closed pull request #1613: [Experiment] Leave out dep from depMgmt URL: https://github.com/apache/maven/pull/1613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [Experiment] Leave out dep from depMgmt [maven]
cstamas commented on PR #1613: URL: https://github.com/apache/maven/pull/1613#issuecomment-2226978102 Superseded by https://github.com/apache/maven/pull/1617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [3.9.x] [Experiment] Leave out dep from depMgmt [maven]
cstamas closed pull request #1614: [3.9.x] [Experiment] Leave out dep from depMgmt URL: https://github.com/apache/maven/pull/1614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [3.9.x] [Experiment] Leave out dep from depMgmt [maven]
cstamas commented on PR #1614: URL: https://github.com/apache/maven/pull/1614#issuecomment-2226978273 Superseded by https://github.com/apache/maven/pull/1617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MASFRES-71) Site generation fails with failed to get report for org.apache.maven.plugins:maven-surefire-report-plugin
Konrad Windszus created MASFRES-71:
--
Summary: Site generation fails with failed to get report for
org.apache.maven.plugins:maven-surefire-report-plugin
Key: MASFRES-71
URL: https://issues.apache.org/jira/browse/MASFRES-71
Project: Apache Maven Resource Bundles
Issue Type: Improvement
Components: apache-source-release-assembly-descriptor
Reporter: Konrad Windszus
The following error is reported when executing {{mvn -Preporting site}}
{code}
[INFO] --<
org.apache.apache.resources:apache-source-release-assembly-descriptor >--
[INFO] Building Apache Source Release Assembly Descriptor 1.6-SNAPSHOT[5/7]
[INFO] from source-release/pom.xml
[INFO] [ jar ]-
...
[INFO] --- surefire:3.2.5:test (default-test) @
apache-source-release-assembly-descriptor ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junit4.JUnit4Provider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
[ERROR] org/apache/assembly/it/AppTest (wrong name:
basics/basics-child1/target/test-classes/org/apache/assembly/it/AppTest)
...
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.12.1:site (default-site) on
project apache-source-release-assembly-descriptor: failed to get report for
org.apache.maven.plugins:maven-surefire-report-plugin: Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.2.5:test (default-test) on
project apache-source-release-assembly-descriptor:
[ERROR]
[ERROR] Please refer to
/Users/konradwindszus/git/maven/maven-apache-resources/source-release/target/surefire-reports
for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump,
[date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] There was an error in the forked process
[ERROR] org/apache/assembly/it/AppTest (wrong name:
basics/basics-child1/target/test-classes/org/apache/assembly/it/AppTest)
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was
an error in the forked process
[ERROR] org/apache/assembly/it/AppTest (wrong name:
basics/basics-child1/target/test-classes/org/apache/assembly/it/AppTest)
[ERROR] at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:628)
...
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]
cstamas commented on PR #536: URL: https://github.com/apache/maven-resolver/pull/536#issuecomment-2226999018 This PR causes noticeable slow down: building Quarkus (mvn clean install -Dquickly) went from 9:20 to 11:10. Ideas: * make interning of dependencies configurable, default NO * make interning of dependencyManagement configurable, default YES * maybe intern only over some size limit? The most offender is huge count of depMgt inherited from parent POM, so this above would make sensible defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MRESOLVER-587) Memory consumption improvements
[ https://issues.apache.org/jira/browse/MRESOLVER-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865707#comment-17865707 ] ASF GitHub Bot commented on MRESOLVER-587: -- cstamas commented on PR #536: URL: https://github.com/apache/maven-resolver/pull/536#issuecomment-2226999018 This PR causes noticeable slow down: building Quarkus (mvn clean install -Dquickly) went from 9:20 to 11:10. Ideas: * make interning of dependencies configurable, default NO * make interning of dependencyManagement configurable, default YES * maybe intern only over some size limit? The most offender is huge count of depMgt inherited from parent POM, so this above would make sensible defaults. > Memory consumption improvements > --- > > Key: MRESOLVER-587 > URL: https://issues.apache.org/jira/browse/MRESOLVER-587 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.1, 1.9.22 > > > In DataPool, following can be done to reduce memory usage: > * ArtifactDescriptor key does not have to be Artifact instance, is really > just GACEV needed (is identity) > * ArtifactDescriptors could have "interned" the List fields as > well -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MJAVADOC-803] Add default parameter to force root locale [maven-javadoc-plugin]
asfgit closed pull request #298: [MJAVADOC-803] Add default parameter to force root locale URL: https://github.com/apache/maven-javadoc-plugin/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MJAVADOC-803] Add default parameter to force root locale [maven-javadoc-plugin]
asfgit merged PR #298: URL: https://github.com/apache/maven-javadoc-plugin/pull/298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-803) Add default parameter to force root locale
[
https://issues.apache.org/jira/browse/MJAVADOC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865712#comment-17865712
]
ASF GitHub Bot commented on MJAVADOC-803:
-
asfgit closed pull request #298: [MJAVADOC-803] Add default parameter to force
root locale
URL: https://github.com/apache/maven-javadoc-plugin/pull/298
> Add default parameter to force root locale
> --
>
> Key: MJAVADOC-803
> URL: https://issues.apache.org/jira/browse/MJAVADOC-803
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> Javadoc suffers from the following two problems:
> * During HTML generatation {{Locale#getDefault()}} is invoked and all
> generated content maybe localized, e.g. German, Japanese. That is a surprise
> for most since they expect to see English content. One has to force with
> {{en}}.
> * In the past JDKs Oracle now started to even localize stdout and stderr
> output to those languages (see
> https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
> even more could come. This causes a regression with MJAVADOC-751 which
> relies on English language output to work.
> Therefore, we will introduce a new parameter {{forceRootLocale}} which will
> add {{-J-Duser.language= -J-Duser.country=}} and will result in
> {{Locale#ROOT}}. Both will force generated HTML output and std output to be
> in English. Those who still need generated content in a specific language can
> pass {{}} and it will work independently of the std output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJAVADOC-803) Add default parameter to force root locale
[
https://issues.apache.org/jira/browse/MJAVADOC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MJAVADOC-803.
---
Resolution: Fixed
Fixed with
[d3afd39f63f730f5018e8bb00bbf4226dd0f482f|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=d3afd39f63f730f5018e8bb00bbf4226dd0f482f].
> Add default parameter to force root locale
> --
>
> Key: MJAVADOC-803
> URL: https://issues.apache.org/jira/browse/MJAVADOC-803
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> Javadoc suffers from the following two problems:
> * During HTML generatation {{Locale#getDefault()}} is invoked and all
> generated content maybe localized, e.g. German, Japanese. That is a surprise
> for most since they expect to see English content. One has to force with
> {{en}}.
> * In the past JDKs Oracle now started to even localize stdout and stderr
> output to those languages (see
> https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
> even more could come. This causes a regression with MJAVADOC-751 which
> relies on English language output to work.
> Therefore, we will introduce a new parameter {{forceRootLocale}} which will
> add {{-J-Duser.language= -J-Duser.country=}} and will result in
> {{Locale#ROOT}}. Both will force generated HTML output and std output to be
> in English. Those who still need generated content in a specific language can
> pass {{}} and it will work independently of the std output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-803) Add default parameter to force root locale
[
https://issues.apache.org/jira/browse/MJAVADOC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865713#comment-17865713
]
ASF GitHub Bot commented on MJAVADOC-803:
-
asfgit merged PR #298:
URL: https://github.com/apache/maven-javadoc-plugin/pull/298
> Add default parameter to force root locale
> --
>
> Key: MJAVADOC-803
> URL: https://issues.apache.org/jira/browse/MJAVADOC-803
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
>Affects Versions: 3.7.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> Javadoc suffers from the following two problems:
> * During HTML generatation {{Locale#getDefault()}} is invoked and all
> generated content maybe localized, e.g. German, Japanese. That is a surprise
> for most since they expect to see English content. One has to force with
> {{en}}.
> * In the past JDKs Oracle now started to even localize stdout and stderr
> output to those languages (see
> https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
> even more could come. This causes a regression with MJAVADOC-751 which
> relies on English language output to work.
> Therefore, we will introduce a new parameter {{forceRootLocale}} which will
> add {{-J-Duser.language= -J-Duser.country=}} and will result in
> {{Locale#ROOT}}. Both will force generated HTML output and std output to be
> in English. Those who still need generated content in a specific language can
> pass {{}} and it will work independently of the std output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAVADOC-799] Remove inconsistent `AbstractFixJavadocMojo#defaultVersion` default value [maven-javadoc-plugin]
Marcono1234 commented on PR #295: URL: https://github.com/apache/maven-javadoc-plugin/pull/295#issuecomment-2227101305 Thanks for the adjustments! It seems currently no test covers a custom `defaultVersion` value, unless I am overlooking something. Should I create a follow-up pull request and adjust the unit test or the integration test to use a custom value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-799) Remove inconsistent `AbstractFixJavadocMojo#defaultVersion` default value
[
https://issues.apache.org/jira/browse/MJAVADOC-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865720#comment-17865720
]
ASF GitHub Bot commented on MJAVADOC-799:
-
Marcono1234 commented on PR #295:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/295#issuecomment-2227101305
Thanks for the adjustments! It seems currently no test covers a custom
`defaultVersion` value, unless I am overlooking something. Should I create a
follow-up pull request and adjust the unit test or the integration test to use
a custom value?
> Remove inconsistent `AbstractFixJavadocMojo#defaultVersion` default value
> -
>
> Key: MJAVADOC-799
> URL: https://issues.apache.org/jira/browse/MJAVADOC-799
> Project: Maven Javadoc Plugin
> Issue Type: Task
> Components: fix
>Affects Versions: 3.7.0
>Reporter: Marcono1234
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.7.1
>
>
> The {{defaultVersion}} parameter of the {{javadoc:fix}} has an inconsistent /
> incorrect default value (though I am not sure what the 'correct' value would
> be).
> h3. Inconsistencies
> - The Javadoc says "By default, it is {{$Id:$}}"
> - The actual and documented (on the Mojo help) default is {{$Id: $Id}}
> - The field in the code has the initial value {{$Id: $}}, with a space (using
> Unicode escapes)
> This value seems to have no effect because {{@Parameter#defaultValue}}
> overwrites the initial field value.
> Maybe it would therefore be easiest to:
> - Remove the "By default, it is ..." sentence from the Javadoc
> It is redundant because the Mojo help documents the
> {{@Parameter#defaultValue}}.
> - Remove the initial field value
> - Optionally remove the {{DEFAULT_VERSION_VALUE}} field and directly inline
> the value
> - Optionally change the default to the intended default value (whatever that
> is)
> h3. Historical background
> It seems originally the default value was supposed to be {{$Id$}}, but that
> was apparently causing issues with SVN, so commit
> [0cecfaa|https://github.com/apache/maven-javadoc-plugin/commit/0cecfaac31113f44c7db4c29021fa6f92877e458]
> tried to fix this by using the field initializer and Unicode escapes instead
> of {{default-value=}}. But this caused the first inconsistency because the
> Javadoc said {{$Id:$}} (without space) but the value was {{$Id: $}} (with
> space).
> Later commit
> [3dcd209|https://github.com/apache/maven-javadoc-plugin/commit/3dcd209a1595a95effd824be5a080f1d19f6f37e#diff-987d1364c087fc6899bde7ad2cdeba3e3c883d3c26e9ffbe86ecdce23d7ee1faR204]
> refactored the code to use {{@Parameter}} and added a {{defaultValue}}, but
> that is {{$Id: $Id}} (with duplicate "Id").
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-797) Exclusion rules works differently for Java 8 and Java 11
[
https://issues.apache.org/jira/browse/MJAVADOC-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865721#comment-17865721
]
Michael Osipov edited comment on MJAVADOC-797 at 7/13/24 9:01 PM:
--
Now, I went through the case and your reproducer, thanks for that. First of
all, our {{excludePackageNames}} does not match {{-exclude}}, it is a superset
adding extra features like wildcards. If we put the wildcards aside and read
the behavior of {{-exclude}} in any Java version we see that
{{org.apache.internal}} shall be enough to exclude this package and all of its
subpackages. Java 8 exactly does that, but nothing newer does that. I have
tried:
"C:\Program Files\Eclipse Adoptium\jdk-8.0.412.8-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-11.0.23.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-21.0.3.9-hotspot"
All of them, but 8 fail. They require EVERY single package to be listed. I
would recommend to strip down your sample to bare {{javadoc}} calls and write
to https://mail.openjdk.org/mailman/listinfo/javadoc-dev. For me clearly a bug
in the JDK.
By testing I mean I have passed the same {{@options}} file the javadoc
executable of those listed versions w/o Maven.
was (Author: michael-o):
Now, I went through the case and your reproducer, thanks for that. First of
all, our {{excludePackageNames}} does not match {{-exclude}}, it is a superset
adding extra features like wildcards. If we put the wildcards aside and read
the behavior of {{-exclude}} in any Java version we seen that
{{org.apache.internal}} shall be enough to exclude this package and all of its
subpackages. Java 8 exactly does that, but nothing newer does that. I have
tried:
"C:\Program Files\Eclipse Adoptium\jdk-8.0.412.8-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-11.0.23.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-21.0.3.9-hotspot"
All of them, but 8 fail. They require EVERY single package to be listed. I
would recommend to strip down your sample to bare {{javadoc}} calls and write
to https://mail.openjdk.org/mailman/listinfo/javadoc-dev. For me clearly a bug
in the JDK.
By testing I mean I have passed the same {{@options}} file the javadoc
executable of those listed versions w/o Maven.
> Exclusion rules works differently for Java 8 and Java 11
>
>
> Key: MJAVADOC-797
> URL: https://issues.apache.org/jira/browse/MJAVADOC-797
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Maksim Timonin
>Priority: Major
>
> The behavior of the "-excludePackageNames" differs for java8 and java11 in
> case of using an option "-subpackages".
> Reproducer is available in the PR:
> [1] [https://github.com/apache/maven-javadoc-plugin/pull/289]
> There are possibly, 2 bugs:
> 1. Behavior for "excludePackageNames" is actually depends on whether the
> "subpackages" setting is specified or not - there are different patterns for
> exclusion used, see patterns in *JavadocUtil#getExcludedPackages* and
> *JavadocUtil#getIncludedFiles*
> 2. In case of using "subpackages" the scenario in the PR [1], the plugin
> prepares equal options for the javadoc util for both java versions. But
> actually the output for the javadoc util differs (depends on the java
> version). I'm not sure is it an expected behavior for the javadoc util, but
> I'd expect the maven-javadoc-plugin will adjust for different java versions
> and provides equal exclusion result.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-797) Exclusion rules works differently for Java 8 and Java 11
[
https://issues.apache.org/jira/browse/MJAVADOC-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865721#comment-17865721
]
Michael Osipov edited comment on MJAVADOC-797 at 7/13/24 9:01 PM:
--
Now, I went through the case and your reproducer, thanks for that. First of
all, our {{excludePackageNames}} does not match {{-exclude}}, it is a superset
adding extra features like wildcards. If we put the wildcards aside and read
the behavior of {{-exclude}} in any Java version we see that
{{org.apache.internal}} shall be enough to exclude this package and all of its
subpackages. Java 8 exactly does that, but nothing newer does that. I have
tried:
"C:\Program Files\Eclipse Adoptium\jdk-8.0.412.8-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-11.0.23.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-21.0.3.9-hotspot"
All of them, but 8 fail. They require EVERY single package to be listed. I
would recommend to strip down your sample to bare {{javadoc}} calls and write
to https://mail.openjdk.org/mailman/listinfo/javadoc-dev. For me clearly a bug
in the JDK. Please refer to this JIRA issue as well.
By testing I mean I have passed the same {{@options}} file the javadoc
executable of those listed versions w/o Maven.
was (Author: michael-o):
Now, I went through the case and your reproducer, thanks for that. First of
all, our {{excludePackageNames}} does not match {{-exclude}}, it is a superset
adding extra features like wildcards. If we put the wildcards aside and read
the behavior of {{-exclude}} in any Java version we see that
{{org.apache.internal}} shall be enough to exclude this package and all of its
subpackages. Java 8 exactly does that, but nothing newer does that. I have
tried:
"C:\Program Files\Eclipse Adoptium\jdk-8.0.412.8-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-11.0.23.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-21.0.3.9-hotspot"
All of them, but 8 fail. They require EVERY single package to be listed. I
would recommend to strip down your sample to bare {{javadoc}} calls and write
to https://mail.openjdk.org/mailman/listinfo/javadoc-dev. For me clearly a bug
in the JDK.
By testing I mean I have passed the same {{@options}} file the javadoc
executable of those listed versions w/o Maven.
> Exclusion rules works differently for Java 8 and Java 11
>
>
> Key: MJAVADOC-797
> URL: https://issues.apache.org/jira/browse/MJAVADOC-797
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Maksim Timonin
>Priority: Major
>
> The behavior of the "-excludePackageNames" differs for java8 and java11 in
> case of using an option "-subpackages".
> Reproducer is available in the PR:
> [1] [https://github.com/apache/maven-javadoc-plugin/pull/289]
> There are possibly, 2 bugs:
> 1. Behavior for "excludePackageNames" is actually depends on whether the
> "subpackages" setting is specified or not - there are different patterns for
> exclusion used, see patterns in *JavadocUtil#getExcludedPackages* and
> *JavadocUtil#getIncludedFiles*
> 2. In case of using "subpackages" the scenario in the PR [1], the plugin
> prepares equal options for the javadoc util for both java versions. But
> actually the output for the javadoc util differs (depends on the java
> version). I'm not sure is it an expected behavior for the javadoc util, but
> I'd expect the maven-javadoc-plugin will adjust for different java versions
> and provides equal exclusion result.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-797) Exclusion rules works differently for Java 8 and Java 11
[
https://issues.apache.org/jira/browse/MJAVADOC-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865721#comment-17865721
]
Michael Osipov commented on MJAVADOC-797:
-
Now, I went through the case and your reproducer, thanks for that. First of
all, our {{excludePackageNames}} does not match {{-exclude}}, it is a superset
adding extra features like wildcards. If we put the wildcards aside and read
the behavior of {{-exclude}} in any Java version we seen that
{{org.apache.internal}} shall be enough to exclude this package and all of its
subpackages. Java 8 exactly does that, but nothing newer does that. I have
tried:
"C:\Program Files\Eclipse Adoptium\jdk-8.0.412.8-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-11.0.23.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-17.0.11.9-hotspot"
"C:\Program Files\Eclipse Adoptium\jdk-21.0.3.9-hotspot"
All of them, but 8 fail. They require EVERY single package to be listed. I
would recommend to strip down your sample to bare {{javadoc}} calls and write
to https://mail.openjdk.org/mailman/listinfo/javadoc-dev. For me clearly a bug
in the JDK.
By testing I mean I have passed the same {{@options}} file the javadoc
executable of those listed versions w/o Maven.
> Exclusion rules works differently for Java 8 and Java 11
>
>
> Key: MJAVADOC-797
> URL: https://issues.apache.org/jira/browse/MJAVADOC-797
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Maksim Timonin
>Priority: Major
>
> The behavior of the "-excludePackageNames" differs for java8 and java11 in
> case of using an option "-subpackages".
> Reproducer is available in the PR:
> [1] [https://github.com/apache/maven-javadoc-plugin/pull/289]
> There are possibly, 2 bugs:
> 1. Behavior for "excludePackageNames" is actually depends on whether the
> "subpackages" setting is specified or not - there are different patterns for
> exclusion used, see patterns in *JavadocUtil#getExcludedPackages* and
> *JavadocUtil#getIncludedFiles*
> 2. In case of using "subpackages" the scenario in the PR [1], the plugin
> prepares equal options for the javadoc util for both java versions. But
> actually the output for the javadoc util differs (depends on the java
> version). I'm not sure is it an expected behavior for the javadoc util, but
> I'd expect the maven-javadoc-plugin will adjust for different java versions
> and provides equal exclusion result.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-791) maven-javadoc-plugin not working correctly together with maven-toolchains-plugin
[
https://issues.apache.org/jira/browse/MJAVADOC-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MJAVADOC-791:
Fix Version/s: 3.7.1
> maven-javadoc-plugin not working correctly together with
> maven-toolchains-plugin
>
>
> Key: MJAVADOC-791
> URL: https://issues.apache.org/jira/browse/MJAVADOC-791
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.6.3
>Reporter: Hristo Bozhilov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> We are using maven-javadoc-plugin in conjunction with maven-toolchains-plugin
> and we are facing an unpleasant problem.
> We have defined toolchains.xml file containing jdk versions needed for the
> build.
> For our build automation server we are using jenkins Config File Provider
> plug-in to supply this toolchains.xml file to the build via -t command line
> argument e.g:
> {code:java}
> mvn clean deploy -t plug-in>.{code}
> We have maven multi-module build and some modules use maven-javadoc-plugin to
> generate javadocs for our API. Sometimes we have API modules that refer API
> classes located in another API module. maven-javadoc-plugin tries to link all
> of these but it fails every time with this error: "[ERROR] No toolchain found
> for type jdk".
> I've looked to the source repository of maven-javadoc-plugin on github and I
> noticed that it forks maven process to build dependent javadocs without
> passing info from toolchains.xml to the forked maven which is needed to run
> the javadoc build. Instead the forked process always expects that
> toolchains.xml is located to ~/.m2/toolchains.xml and this doesn't work on
> jenkins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MJAVADOC-791) maven-javadoc-plugin not working correctly together with maven-toolchains-plugin
[
https://issues.apache.org/jira/browse/MJAVADOC-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MJAVADOC-791:
---
Assignee: Michael Osipov
> maven-javadoc-plugin not working correctly together with
> maven-toolchains-plugin
>
>
> Key: MJAVADOC-791
> URL: https://issues.apache.org/jira/browse/MJAVADOC-791
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.6.3
>Reporter: Hristo Bozhilov
>Assignee: Michael Osipov
>Priority: Major
>
> We are using maven-javadoc-plugin in conjunction with maven-toolchains-plugin
> and we are facing an unpleasant problem.
> We have defined toolchains.xml file containing jdk versions needed for the
> build.
> For our build automation server we are using jenkins Config File Provider
> plug-in to supply this toolchains.xml file to the build via -t command line
> argument e.g:
> {code:java}
> mvn clean deploy -t plug-in>.{code}
> We have maven multi-module build and some modules use maven-javadoc-plugin to
> generate javadocs for our API. Sometimes we have API modules that refer API
> classes located in another API module. maven-javadoc-plugin tries to link all
> of these but it fails every time with this error: "[ERROR] No toolchain found
> for type jdk".
> I've looked to the source repository of maven-javadoc-plugin on github and I
> noticed that it forks maven process to build dependent javadocs without
> passing info from toolchains.xml to the forked maven which is needed to run
> the javadoc build. Instead the forked process always expects that
> toolchains.xml is located to ~/.m2/toolchains.xml and this doesn't work on
> jenkins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MJAVADOC-799] Remove inconsistent `AbstractFixJavadocMojo#defaultVersion` default value [maven-javadoc-plugin]
michael-o commented on PR #295: URL: https://github.com/apache/maven-javadoc-plugin/pull/295#issuecomment-2227104630 > Thanks for the adjustments! It seems currently no test covers a custom `defaultVersion` value, unless I am overlooking something. Should I create a follow-up pull request and adjust the unit test or the integration test to use a custom value? That's be great. Currently, we cover that there is no default value for `defaultVersion`. Now we need a test with a custom version set and that the version truly arrives in the modified files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MJAVADOC-791] maven-javadoc-plugin not working correctly together wi… [maven-javadoc-plugin]
michael-o opened a new pull request, #299: URL: https://github.com/apache/maven-javadoc-plugin/pull/299 …th maven-toolchains-plugin This closes #299 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJAVADOC) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-799) Remove inconsistent `AbstractFixJavadocMojo#defaultVersion` default value
[
https://issues.apache.org/jira/browse/MJAVADOC-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865722#comment-17865722
]
ASF GitHub Bot commented on MJAVADOC-799:
-
michael-o commented on PR #295:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/295#issuecomment-2227104630
> Thanks for the adjustments! It seems currently no test covers a custom
`defaultVersion` value, unless I am overlooking something. Should I create a
follow-up pull request and adjust the unit test or the integration test to use
a custom value?
That's be great. Currently, we cover that there is no default value for
`defaultVersion`. Now we need a test with a custom version set and that the
version truly arrives in the modified files.
> Remove inconsistent `AbstractFixJavadocMojo#defaultVersion` default value
> -
>
> Key: MJAVADOC-799
> URL: https://issues.apache.org/jira/browse/MJAVADOC-799
> Project: Maven Javadoc Plugin
> Issue Type: Task
> Components: fix
>Affects Versions: 3.7.0
>Reporter: Marcono1234
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.7.1
>
>
> The {{defaultVersion}} parameter of the {{javadoc:fix}} has an inconsistent /
> incorrect default value (though I am not sure what the 'correct' value would
> be).
> h3. Inconsistencies
> - The Javadoc says "By default, it is {{$Id:$}}"
> - The actual and documented (on the Mojo help) default is {{$Id: $Id}}
> - The field in the code has the initial value {{$Id: $}}, with a space (using
> Unicode escapes)
> This value seems to have no effect because {{@Parameter#defaultValue}}
> overwrites the initial field value.
> Maybe it would therefore be easiest to:
> - Remove the "By default, it is ..." sentence from the Javadoc
> It is redundant because the Mojo help documents the
> {{@Parameter#defaultValue}}.
> - Remove the initial field value
> - Optionally remove the {{DEFAULT_VERSION_VALUE}} field and directly inline
> the value
> - Optionally change the default to the intended default value (whatever that
> is)
> h3. Historical background
> It seems originally the default value was supposed to be {{$Id$}}, but that
> was apparently causing issues with SVN, so commit
> [0cecfaa|https://github.com/apache/maven-javadoc-plugin/commit/0cecfaac31113f44c7db4c29021fa6f92877e458]
> tried to fix this by using the field initializer and Unicode escapes instead
> of {{default-value=}}. But this caused the first inconsistency because the
> Javadoc said {{$Id:$}} (without space) but the value was {{$Id: $}} (with
> space).
> Later commit
> [3dcd209|https://github.com/apache/maven-javadoc-plugin/commit/3dcd209a1595a95effd824be5a080f1d19f6f37e#diff-987d1364c087fc6899bde7ad2cdeba3e3c883d3c26e9ffbe86ecdce23d7ee1faR204]
> refactored the code to use {{@Parameter}} and added a {{defaultValue}}, but
> that is {{$Id: $Id}} (with duplicate "Id").
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-791) maven-javadoc-plugin not working correctly together with maven-toolchains-plugin
[
https://issues.apache.org/jira/browse/MJAVADOC-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865723#comment-17865723
]
ASF GitHub Bot commented on MJAVADOC-791:
-
michael-o opened a new pull request, #299:
URL: https://github.com/apache/maven-javadoc-plugin/pull/299
…th maven-toolchains-plugin
This closes #299
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> maven-javadoc-plugin not working correctly together with
> maven-toolchains-plugin
>
>
> Key: MJAVADOC-791
> URL: https://issues.apache.org/jira/browse/MJAVADOC-791
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.6.3
>Reporter: Hristo Bozhilov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> We are using maven-javadoc-plugin in conjunction with maven-toolchains-plugin
> and we are facing an unpleasant problem.
> We have defined toolchains.xml file containing jdk versions needed for the
> build.
> For our build automation server we are using jenkins Config File Provider
> plug-in to supply this toolchains.xml file to the build via -t command line
> argument e.g:
> {code:java}
> mvn clean deploy -t plug-in>.{code}
> We have maven multi-module build and some modules use maven-javadoc-plugin to
> generate javadocs for our API. Sometimes we have API modules that refer API
> classes located in another API module. maven-javadoc-plugin tries to link all
> of these but it fails every time with this error: "[ERROR] No toolchain found
> for type jdk".
> I've looked to the source repository of maven-javadoc-plugin on github and I
> noticed that it forks maven process to build dependent javadocs without
> passing info from toolchains.xml to the forked maven which is needed to run
> the javadoc build. Instead the forked process always expects that
> toolchains.xml is located to ~/.m2/toolchains.xml and this doesn't work on
> jenkins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-786) Detected links for for dependencies and new JavaDocs on JDK8
[
https://issues.apache.org/jira/browse/MJAVADOC-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865724#comment-17865724
]
Michael Osipov commented on MJAVADOC-786:
-
This seems to be off. SLF4J 2.0 is intended for Java 8, but the Javadoc
uploaded is not compatible with Java 8, this means that the build is not OK,
not the plugin isn't it?
I have tried to build Javadoc from source, but it fails for me:
{noformat}
[INFO] --- maven-javadoc-plugin:3.6.3:aggregate (default-cli) @ slf4j-bom ---
[WARNING] Source files encoding has not been set, using platform encoding
UTF-8, i.e. build is platform dependent!
[INFO] No previous run data found, generating javadoc.
[INFO]
[INFO] Reactor Summary for SLF4J BOM 2.0.14-SNAPSHOT:
[INFO]
[INFO] SLF4J BOM .. FAILURE [ 4.449 s]
[INFO] SLF4J Parent POM ... SUCCESS [ 1.686 s]
[INFO] SLF4J API Module ... SUCCESS [ 5.279 s]
[INFO] SLF4J Simple Provider .. SUCCESS [ 1.134 s]
[INFO] SLF4J NOP Provider . SUCCESS [ 0.532 s]
[INFO] SLF4J JDK14 Provider ... SUCCESS [ 0.601 s]
[INFO] SLF4J JDK Platform Logging Integration . SUCCESS [ 0.709 s]
[INFO] SLF4J LOG4J-12 Binding relocated ... SUCCESS [ 0.031 s]
[INFO] SLF4J Reload4j Provider SUCCESS [ 0.670 s]
[INFO] SLF4J Extensions Module SUCCESS [ 0.965 s]
[INFO] JCL 1.2 implemented over SLF4J . SUCCESS [ 0.655 s]
[INFO] Log4j Implemented Over SLF4J ... SUCCESS [ 0.733 s]
[INFO] JUL to SLF4J bridge SUCCESS [ 0.416 s]
[INFO] OSGi LogService implemented over SLF4J . SUCCESS [ 0.355 s]
[INFO] SLF4J Integration tests SUCCESS [ 2.202 s]
[INFO] SLF4J Migrator . SUCCESS [ 0.570 s]
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 21.620 s
[INFO] Finished at: 2024-07-13T23:51:39+02:00
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:aggregate (default-cli) on
project slf4j-bom: An error has occurred in Javadoc report generation:
[ERROR] Exit code: 2
[ERROR] error: No source files for package org.slf4j.event
[ERROR] 1 error
[ERROR] Command line was: cmd.exe /X /C ""C:\Program Files\Eclipse
Adoptium\jdk-17.0.11.9-hotspot\bin\javadoc.exe" @options @packages"
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'D:\Entwicklung\Projekte\slf4j\target\site\apidocs' dir.
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
D:\Entwicklung\Projekte\slf4j [master ≡ +0 ~1 -0 !]>
{noformat}
and the {{@options}} is looks wrong as well, no source or release flag
provided. It build as if for Java 17, 21, you name it.
> Detected links for for dependencies and new JavaDocs on JDK8
>
>
> Key: MJAVADOC-786
> URL: https://issues.apache.org/jira/browse/MJAVADOC-786
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> When we detect links for dependencies we should check if {{package-list}} is
> present on JDK8
>
> Eg, test: MJAVADOC-427 will fail on JDK8 because only
> {{https://www.slf4j.org/apidocs/element-list}} is present currently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-786) Detected links for for dependencies and new JavaDocs on JDK8
[
https://issues.apache.org/jira/browse/MJAVADOC-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MJAVADOC-786:
Fix Version/s: waiting-for-feedback
> Detected links for for dependencies and new JavaDocs on JDK8
>
>
> Key: MJAVADOC-786
> URL: https://issues.apache.org/jira/browse/MJAVADOC-786
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> When we detect links for dependencies we should check if {{package-list}} is
> present on JDK8
>
> Eg, test: MJAVADOC-427 will fail on JDK8 because only
> {{https://www.slf4j.org/apidocs/element-list}} is present currently.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-751) No warnings for localized output
[ https://issues.apache.org/jira/browse/MJAVADOC-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MJAVADOC-751: Fix Version/s: 3.7.1 > No warnings for localized output > > > Key: MJAVADOC-751 > URL: https://issues.apache.org/jira/browse/MJAVADOC-751 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Mario Schäper >Assignee: Michael Osipov >Priority: Minor > Labels: easyfix, pull-request-available > Fix For: 3.7.1 > > Original Estimate: 1h > Remaining Estimate: 1h > > If the output of the javadoc executable is localized the following two errors > occur depending on the exit code: > 1) non-zero: the informational output filter (introduced in MJAVADOC-721) > does not work > 2) zero: no warnings are recognized > > #2 is particularly problematic if `failOnWarnings` is set, since this may > cause a build to fail in english environments, but not on certain others. > > Affected are japanese, chinese and since [JDK > 19|https://github.com/openjdk/jdk/commit/38df5701ff82] german. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MJAVADOC-751) No warnings for localized output
[ https://issues.apache.org/jira/browse/MJAVADOC-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MJAVADOC-751: --- Assignee: Michael Osipov > No warnings for localized output > > > Key: MJAVADOC-751 > URL: https://issues.apache.org/jira/browse/MJAVADOC-751 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Mario Schäper >Assignee: Michael Osipov >Priority: Minor > Labels: easyfix, pull-request-available > Original Estimate: 1h > Remaining Estimate: 1h > > If the output of the javadoc executable is localized the following two errors > occur depending on the exit code: > 1) non-zero: the informational output filter (introduced in MJAVADOC-721) > does not work > 2) zero: no warnings are recognized > > #2 is particularly problematic if `failOnWarnings` is set, since this may > cause a build to fail in english environments, but not on certain others. > > Affected are japanese, chinese and since [JDK > 19|https://github.com/openjdk/jdk/commit/38df5701ff82] german. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-749) Encounter fatal error while updating javadoc-plugin from 3.2.0 to 3.3.2
[
https://issues.apache.org/jira/browse/MJAVADOC-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865725#comment-17865725
]
Michael Osipov commented on MJAVADOC-749:
-
Ping!
> Encounter fatal error while updating javadoc-plugin from 3.2.0 to 3.3.2
> ---
>
> Key: MJAVADOC-749
> URL: https://issues.apache.org/jira/browse/MJAVADOC-749
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.3.2
>Reporter: ZhangJian He
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> When updating Apache bookkeeper's javadoc-plugin from 3.2.0 to 3.3.2. the pr
> link is here: [https://github.com/apache/bookkeeper/pull/3852]
> And the configuration is:
> ```
>
> org.apache.maven.plugins
> maven-javadoc-plugin
> ${maven-javadoc-plugin.version}
>
> ${javac.target}
> true
>
> none
> org.apache.bookkeeper.client:org.apache.bookkeeper.client.api:org.apache.bookkeeper.common.annotation:org.apache.bookkeeper.conf:org.apache.bookkeeper.feature:org.apache.bookkeeper.stats
>
>
> Bookkeeper Client
> org.apache.bookkeeper.client:org.apache.bookkeeper.common.annotation:org.apache.bookkeeper.conf:org.apache.bookkeeper.feature
>
>
> Bookkeeper Client (New Fluent API - Experimental)
> org.apache.bookkeeper.client.api
>
>
> Bookkeeper Stats API
> org.apache.bookkeeper.stats
>
>
> Bookkeeper Stats Providers
> org.apache.bookkeeper.stats.codahale:org.apache.bookkeeper.stats.prometheus
>
>
> BookKeeper Java API (version ${project.version})
> site/_site/overview/index.html
> package
> false
>
> false
>
>
>
> aggregate
>
> aggregate
>
> site
>
>
>
> ```
> Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.3.2:jar (attach-javadocs) on
> project bookkeeper-stats-api: MavenReportException: Error while generating
> Javadoc: Error: Exit code: 4 - javadoc: error - fatal error encountered:
> java.lang.AssertionError
> [ERROR] java.lang.AssertionError
> [ERROR] at
> jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
> [ERROR] at
> jdk.compiler/com.sun.tools.javac.util.Assert.checkNonNull(Assert.java:62)
> [ERROR] at
> jdk.compiler/com.sun.tools.javac.comp.Modules.allModules(Modules.java:1216)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.ElementsTable.findModuleOfPackageName(ElementsTable.java:857)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.ElementsTable.addPackagesFromLocations(ElementsTable.java:537)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.ElementsTable.computeSubpackages(ElementsTable.java:510)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.ElementsTable.computeSpecifiedPackages(ElementsTable.java:747)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.ElementsTable.analyze(ElementsTable.java:347)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.JavadocTool.getEnvironment(JavadocTool.java:220)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.Start.parseAndExecute(Start.java:546)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.Start.begin(Start.java:393)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.Start.begin(Start.java:342)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.Main.execute(Main.java:63)
> [ERROR] at
> jdk.javadoc/jdk.javadoc.internal.tool.Main.main(Main.java:52)
> [ERROR] 2 个错误
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk-17.0.1.jdk/Contents/Home/bin/javadoc
> @options
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-710) Usage of removed or replaced property does not cause the build to fail
[
https://issues.apache.org/jira/browse/MJAVADOC-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865726#comment-17865726
]
Michael Osipov commented on MJAVADOC-710:
-
Is this issue still valid since the PRs have been closed?
> Usage of removed or replaced property does not cause the build to fail
> --
>
> Key: MJAVADOC-710
> URL: https://issues.apache.org/jira/browse/MJAVADOC-710
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.3.2
>Reporter: Piotr Zygielo
>Priority: Major
>
> Per
> https://issues.apache.org/jira/browse/MJAVADOC-509?focusedCommentId=16581261
> {quote}Yes, additionalParam was replaced by additionalOptions in
> MJAVADOC-475(https://issues.apache.org/jira/browse/MJAVADOC-475) and the
> build will fail with 3.0.0 if this property is used.
> {quote}
> However current implementation does not do that. And as far as I've checked -
> the original implementation didn't do in 3.0.0 neither.
> This is due to {{mojo.getConfiguration()}} in
> {{AbstractJavadocMojo.verifyRemovedParameter}} having only parameters plugin
> committed for, and not all from {{}} element. Not at the
> moment of goal execution, at least.
> This causes problems when upgrading from pre-3 plugin as {{additionalparam}}
> is silently ignored.
> I see similar case is dealt in following way:
> -
> [https://github.com/apache/maven-jar-plugin/blob/0ad60f4f2862bf896b6c0dc57ea5a6999c49b0d4/src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java#L107-L115]
> -
> [https://github.com/apache/maven-deploy-plugin/blob/36a2030c8851e21cd1e0bec01c3cea4dc6055a48/src/main/java/org/apache/maven/plugins/deploy/DeployFileMojo.java#L180-L188]
> - and few others
> which is to have {{@Deprecated}} parameter, and its presence is used for
> breaking the build.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJAVADOC-751) No warnings for localized output
[ https://issues.apache.org/jira/browse/MJAVADOC-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MJAVADOC-751. --- Resolution: Fixed This is fixed by MJAVADOC-803. > No warnings for localized output > > > Key: MJAVADOC-751 > URL: https://issues.apache.org/jira/browse/MJAVADOC-751 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.5.0 >Reporter: Mario Schäper >Assignee: Michael Osipov >Priority: Minor > Labels: easyfix, pull-request-available > Fix For: 3.7.1 > > Original Estimate: 1h > Remaining Estimate: 1h > > If the output of the javadoc executable is localized the following two errors > occur depending on the exit code: > 1) non-zero: the informational output filter (introduced in MJAVADOC-721) > does not work > 2) zero: no warnings are recognized > > #2 is particularly problematic if `failOnWarnings` is set, since this may > cause a build to fail in english environments, but not on certain others. > > Affected are japanese, chinese and since [JDK > 19|https://github.com/openjdk/jdk/commit/38df5701ff82] german. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MJAVADOC-778) Module not visible when creating test javadocs
[
https://issues.apache.org/jira/browse/MJAVADOC-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865728#comment-17865728
]
Michael Osipov edited comment on MJAVADOC-778 at 7/13/24 10:02 PM:
---
Is this one still valid because I was able to build the site from
0df4e6ba2ae503efd7612c17d4f959b69203e3f0:
{noformat}
[INFO] Writing report to:
D:\Entwicklung\Projekte\Validation\target\site\dependency-check-report.html
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 05:27 min
[INFO] Finished at: 2024-07-14T00:00:28+02:00
[INFO]
D:\Entwicklung\Projekte\Validation [master ≡]> mvn site
{noformat}
was (Author: michael-o):
Is this one still valid because I was able to build the site:
{noformat}
[INFO] Writing report to:
D:\Entwicklung\Projekte\Validation\target\site\dependency-check-report.html
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 05:27 min
[INFO] Finished at: 2024-07-14T00:00:28+02:00
[INFO]
D:\Entwicklung\Projekte\Validation [master ≡]> mvn site
{noformat}
> Module not visible when creating test javadocs
> --
>
> Key: MJAVADOC-778
> URL: https://issues.apache.org/jira/browse/MJAVADOC-778
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.0
> Environment: maven, java 17, windows 10
>Reporter: Kai Hofmann
>Priority: Major
> Labels: JavaDoc, Modules, java
> Fix For: waiting-for-feedback
>
>
> I have an open source java project with java module system on github:
> [https://github.com/PowerStat/Validation]
> When doing a
> {code:java}
> mvn site{code}
> This will result in the following:
>
>
> {code:java}
> [INFO] Generating "Test Javadoc" report ---
> maven-javadoc-plugin:3.6.0:test-aggregate-no-fork
> [INFO] Configuration changed, re-generating javadoc.
> [ERROR] Error while creating javadoc report:
> Exit code: 1
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: package org.junit.jupiter.api is not visible
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> (package org.junit.jupiter.api is declared in the unnamed module, but
> module de.powerstat.validation does not read it)
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: static import only from classes and interfaces
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> [...]
> 100 errors
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-17\bin\javadoc.exe" @options @argfile"
>
> Refer to the generated Javadoc files in
> 'C:\Users\PowerStat\Documents\Validation\target\site\testapidocs' dir.
>
> org.apache.maven.reporting.MavenReportException:
> Exit code: 1
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: package org.junit.jupiter.api is not visible
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> (package org.junit.jupiter.api is declared in the unnamed module, but
> module de.powerstat.validation does not read it)
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: static import only from classes and interfaces
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> [...]
> 100 errors
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-17\bin\javadoc.exe" @options @argfile"
>
> Refer to the generated Javadoc files in
> 'C:\Users\PowerStat\Documents\Validation\target\site\testapidocs' dir.
> at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.doExecuteJavadocCommandLine
> (AbstractJavadocMojo.java:5183)
> at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeJavadocCommandLine
> (AbstractJavadocMojo.java:5068)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> (AbstractJavadocMojo.java:2028)
> at org.apache.maven.plugins.javadoc.TestJavadocReport.executeReport
> (TestJavadocReport.java:153)
> at org.apache.maven.plug
[jira] [Commented] (MJAVADOC-778) Module not visible when creating test javadocs
[
https://issues.apache.org/jira/browse/MJAVADOC-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865728#comment-17865728
]
Michael Osipov commented on MJAVADOC-778:
-
Is this one still valid because I was able to build the site:
{noformat}
[INFO] Writing report to:
D:\Entwicklung\Projekte\Validation\target\site\dependency-check-report.html
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 05:27 min
[INFO] Finished at: 2024-07-14T00:00:28+02:00
[INFO]
D:\Entwicklung\Projekte\Validation [master ≡]> mvn site
{noformat}
> Module not visible when creating test javadocs
> --
>
> Key: MJAVADOC-778
> URL: https://issues.apache.org/jira/browse/MJAVADOC-778
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.0
> Environment: maven, java 17, windows 10
>Reporter: Kai Hofmann
>Priority: Major
> Labels: JavaDoc, Modules, java
> Fix For: waiting-for-feedback
>
>
> I have an open source java project with java module system on github:
> [https://github.com/PowerStat/Validation]
> When doing a
> {code:java}
> mvn site{code}
> This will result in the following:
>
>
> {code:java}
> [INFO] Generating "Test Javadoc" report ---
> maven-javadoc-plugin:3.6.0:test-aggregate-no-fork
> [INFO] Configuration changed, re-generating javadoc.
> [ERROR] Error while creating javadoc report:
> Exit code: 1
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: package org.junit.jupiter.api is not visible
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> (package org.junit.jupiter.api is declared in the unnamed module, but
> module de.powerstat.validation does not read it)
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: static import only from classes and interfaces
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> [...]
> 100 errors
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-17\bin\javadoc.exe" @options @argfile"
>
> Refer to the generated Javadoc files in
> 'C:\Users\PowerStat\Documents\Validation\target\site\testapidocs' dir.
>
> org.apache.maven.reporting.MavenReportException:
> Exit code: 1
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: package org.junit.jupiter.api is not visible
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> (package org.junit.jupiter.api is declared in the unnamed module, but
> module de.powerstat.validation does not read it)
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: static import only from classes and interfaces
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> [...]
> 100 errors
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-17\bin\javadoc.exe" @options @argfile"
>
> Refer to the generated Javadoc files in
> 'C:\Users\PowerStat\Documents\Validation\target\site\testapidocs' dir.
> at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.doExecuteJavadocCommandLine
> (AbstractJavadocMojo.java:5183)
> at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeJavadocCommandLine
> (AbstractJavadocMojo.java:5068)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> (AbstractJavadocMojo.java:2028)
> at org.apache.maven.plugins.javadoc.TestJavadocReport.executeReport
> (TestJavadocReport.java:153)
> at org.apache.maven.plugins.javadoc.JavadocReport.generate
> (JavadocReport.java:135)
> at
> org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument
> (ReportDocumentRenderer.java:226)
> at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render
> (DefaultSiteRenderer.java:348)
> at org.apache.maven.plugins.site.render.SiteMojo.renderLocale
> (SiteMojo.java:194)
> at org.apache.maven.plugins.site.render.SiteMojo.execute
> (SiteMojo.java:143)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifec
[jira] [Updated] (MJAVADOC-778) Module not visible when creating test javadocs
[
https://issues.apache.org/jira/browse/MJAVADOC-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MJAVADOC-778:
Fix Version/s: waiting-for-feedback
> Module not visible when creating test javadocs
> --
>
> Key: MJAVADOC-778
> URL: https://issues.apache.org/jira/browse/MJAVADOC-778
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.6.0
> Environment: maven, java 17, windows 10
>Reporter: Kai Hofmann
>Priority: Major
> Labels: JavaDoc, Modules, java
> Fix For: waiting-for-feedback
>
>
> I have an open source java project with java module system on github:
> [https://github.com/PowerStat/Validation]
> When doing a
> {code:java}
> mvn site{code}
> This will result in the following:
>
>
> {code:java}
> [INFO] Generating "Test Javadoc" report ---
> maven-javadoc-plugin:3.6.0:test-aggregate-no-fork
> [INFO] Configuration changed, re-generating javadoc.
> [ERROR] Error while creating javadoc report:
> Exit code: 1
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: package org.junit.jupiter.api is not visible
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> (package org.junit.jupiter.api is declared in the unnamed module, but
> module de.powerstat.validation does not read it)
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: static import only from classes and interfaces
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> [...]
> 100 errors
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-17\bin\javadoc.exe" @options @argfile"
>
> Refer to the generated Javadoc files in
> 'C:\Users\PowerStat\Documents\Validation\target\site\testapidocs' dir.
>
> org.apache.maven.reporting.MavenReportException:
> Exit code: 1
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: package org.junit.jupiter.api is not visible
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> (package org.junit.jupiter.api is declared in the unnamed module, but
> module de.powerstat.validation does not read it)
>
> C:\Users\PowerStat\Documents\Validation\src\test\java\de\powerstat\comparators\test\ComparatorEMailByDomainTests.java:7:
> error: static import only from classes and interfaces
> import static org.junit.jupiter.api.Assertions.assertEquals;
> ^
> [...]
> 100 errors
> Command line was: cmd.exe /X /C ""C:\Program
> Files\Java\jdk-17\bin\javadoc.exe" @options @argfile"
>
> Refer to the generated Javadoc files in
> 'C:\Users\PowerStat\Documents\Validation\target\site\testapidocs' dir.
> at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.doExecuteJavadocCommandLine
> (AbstractJavadocMojo.java:5183)
> at
> org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeJavadocCommandLine
> (AbstractJavadocMojo.java:5068)
> at org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport
> (AbstractJavadocMojo.java:2028)
> at org.apache.maven.plugins.javadoc.TestJavadocReport.executeReport
> (TestJavadocReport.java:153)
> at org.apache.maven.plugins.javadoc.JavadocReport.generate
> (JavadocReport.java:135)
> at
> org.apache.maven.plugins.site.render.ReportDocumentRenderer.renderDocument
> (ReportDocumentRenderer.java:226)
> at org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render
> (DefaultSiteRenderer.java:348)
> at org.apache.maven.plugins.site.render.SiteMojo.renderLocale
> (SiteMojo.java:194)
> at org.apache.maven.plugins.site.render.SiteMojo.execute
> (SiteMojo.java:143)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execut
Re: [PR] [MJAVADOC-791] maven-javadoc-plugin not working correctly together wi… [maven-javadoc-plugin]
asfgit closed pull request #299: [MJAVADOC-791] maven-javadoc-plugin not working correctly together wi… URL: https://github.com/apache/maven-javadoc-plugin/pull/299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-791) maven-javadoc-plugin not working correctly together with maven-toolchains-plugin
[
https://issues.apache.org/jira/browse/MJAVADOC-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865729#comment-17865729
]
ASF GitHub Bot commented on MJAVADOC-791:
-
asfgit closed pull request #299: [MJAVADOC-791] maven-javadoc-plugin not
working correctly together wi…
URL: https://github.com/apache/maven-javadoc-plugin/pull/299
> maven-javadoc-plugin not working correctly together with
> maven-toolchains-plugin
>
>
> Key: MJAVADOC-791
> URL: https://issues.apache.org/jira/browse/MJAVADOC-791
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.6.3
>Reporter: Hristo Bozhilov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> We are using maven-javadoc-plugin in conjunction with maven-toolchains-plugin
> and we are facing an unpleasant problem.
> We have defined toolchains.xml file containing jdk versions needed for the
> build.
> For our build automation server we are using jenkins Config File Provider
> plug-in to supply this toolchains.xml file to the build via -t command line
> argument e.g:
> {code:java}
> mvn clean deploy -t plug-in>.{code}
> We have maven multi-module build and some modules use maven-javadoc-plugin to
> generate javadocs for our API. Sometimes we have API modules that refer API
> classes located in another API module. maven-javadoc-plugin tries to link all
> of these but it fails every time with this error: "[ERROR] No toolchain found
> for type jdk".
> I've looked to the source repository of maven-javadoc-plugin on github and I
> noticed that it forks maven process to build dependent javadocs without
> passing info from toolchains.xml to the forked maven which is needed to run
> the javadoc build. Instead the forked process always expects that
> toolchains.xml is located to ~/.m2/toolchains.xml and this doesn't work on
> jenkins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MJAVADOC-791) maven-javadoc-plugin not working correctly together with maven-toolchains-plugin
[
https://issues.apache.org/jira/browse/MJAVADOC-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MJAVADOC-791.
---
Resolution: Fixed
Fixed with
[3eb47c5081bf6f4158333bd378641bc9b7c9a25f|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=3eb47c5081bf6f4158333bd378641bc9b7c9a25f].
> maven-javadoc-plugin not working correctly together with
> maven-toolchains-plugin
>
>
> Key: MJAVADOC-791
> URL: https://issues.apache.org/jira/browse/MJAVADOC-791
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.6.3
>Reporter: Hristo Bozhilov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.7.1
>
>
> We are using maven-javadoc-plugin in conjunction with maven-toolchains-plugin
> and we are facing an unpleasant problem.
> We have defined toolchains.xml file containing jdk versions needed for the
> build.
> For our build automation server we are using jenkins Config File Provider
> plug-in to supply this toolchains.xml file to the build via -t command line
> argument e.g:
> {code:java}
> mvn clean deploy -t plug-in>.{code}
> We have maven multi-module build and some modules use maven-javadoc-plugin to
> generate javadocs for our API. Sometimes we have API modules that refer API
> classes located in another API module. maven-javadoc-plugin tries to link all
> of these but it fails every time with this error: "[ERROR] No toolchain found
> for type jdk".
> I've looked to the source repository of maven-javadoc-plugin on github and I
> noticed that it forks maven process to build dependent javadocs without
> passing info from toolchains.xml to the forked maven which is needed to run
> the javadoc build. Instead the forked process always expects that
> toolchains.xml is located to ~/.m2/toolchains.xml and this doesn't work on
> jenkins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MJAVADOC-800) Update org.codehaus.plexus:plexus-io to 3.5.0
[ https://issues.apache.org/jira/browse/MJAVADOC-800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MJAVADOC-800: --- Assignee: Sylwester Lachiewicz > Update org.codehaus.plexus:plexus-io to 3.5.0 > - > > Key: MJAVADOC-800 > URL: https://issues.apache.org/jira/browse/MJAVADOC-800 > Project: Maven Javadoc Plugin > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.7.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MJLINK-83] Implement multiple launcher elements [maven-jlink-plugin]
vietj commented on PR #202: URL: https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2227214927 I do support this feature that is useful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJLINK-83) Allow adding multiple launchers to a jlink'ed image
[
https://issues.apache.org/jira/browse/MJLINK-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865750#comment-17865750
]
ASF GitHub Bot commented on MJLINK-83:
--
vietj commented on PR #202:
URL:
https://github.com/apache/maven-jlink-plugin/pull/202#issuecomment-2227214927
I do support this feature that is useful
> Allow adding multiple launchers to a jlink'ed image
> ---
>
> Key: MJLINK-83
> URL: https://issues.apache.org/jira/browse/MJLINK-83
> Project: Maven JLink Plugin
> Issue Type: Improvement
>Affects Versions: 3.2.0
> Environment: (applies to all platforms)
>Reporter: Peter Hull
>Priority: Minor
>
> The {{jlink}} command line tool allows the {{--launcher}} argument to be
> specified multiple times to create multiple launcher scripts in the image.
> However the maven plugin only passes on one {{}} element from its
> configuration section to the tool. If multiple are specified, the last one
> takes precedence. I would like to improve this so the plugin will pass
> multiple launcher specs on to the {{jlink}} tool. I suggest the config should
> look like:
> {noformat}
> command=module/main{noformat}
> (as before, for backward compatibility and the common case where there is
> only one)
> or
>
> {noformat}
>
> command1=module1/main1
> command2=module2/main2
> ...
>
> {noformat}
>
> where {{}} can contain zero or more {{}} elements with
> the same syntax as the existing element.
> One remaining question - what do do if the config specifies both
> {{}} and {{}} - combine the two or signal an error?
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
