[
https://issues.apache.org/jira/browse/MJAVADOC-803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865658#comment-17865658
]
ASF GitHub Bot commented on MJAVADOC-803:
-----------------------------------------
michael-o opened a new pull request, #298:
URL: https://github.com/apache/maven-javadoc-plugin/pull/298
This closes #298
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MJAVADOC-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A
more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Add default parameter to force root locale
> ------------------------------------------
>
> Key: MJAVADOC-803
> URL: https://issues.apache.org/jira/browse/MJAVADOC-803
> Project: Maven Javadoc Plugin
> Issue Type: Improvement
> Components: jar, javadoc
> Affects Versions: 3.7.0
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.7.1
>
>
> Javadoc suffers from the following two problems:
> * During HTML generatation {{Locale#getDefault()}} is invoked and all
> generated content maybe localized, e.g. German, Japanese. That is a surprise
> for most since they expect to see English content. One has to force with
> {{<locale>en</locale>}}.
> * In the past JDKs Oracle now started to even localize stdout and stderr
> output to those languages (see
> https://github.com/openjdk/jdk21u-dev/tree/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources),
> even more could come. This causes a regression with MJAVADOC-751 which
> relies on English language output to work.
> Therefore, we will introduce a new parameter {{forceRootLocale}} which will
> add {{-J-Duser.language= -J-Duser.country=}} and will result in
> {{Locale#ROOT}}. Both will force generated HTML output and std output to be
> in English. Those who still need generated content in a specific language can
> pass {{<locale/>}} and it will work independently of the std output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
