[PR] [MNG-8100] Upgrade default plugin bindings - fix ITs [maven-integration-testing]
slawekjaranowski opened a new pull request, #334: URL: https://github.com/apache/maven-integration-testing/pull/334 https://issues.apache.org/jira/browse/MNG-8100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update GitHub actions to v4 [maven]
slawekjaranowski merged PR #1472: URL: https://github.com/apache/maven/pull/1472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-8100] Upgrade default plugin bindings - fix ITs [maven-integration-testing]
slawekjaranowski opened a new pull request, #335: URL: https://github.com/apache/maven-integration-testing/pull/335 https://issues.apache.org/jira/browse/MNG-8100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]
cstamas commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628217 @wendigo Would be grateful if you build mvnd locally and try it with Trino build, it should now work OOTB. No need for native and all that, just `mvn clean install` and use it on Trino build. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067628962 Will do @cstamas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8101) Upgrade Parent to 42
[ https://issues.apache.org/jira/browse/MNG-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839217#comment-17839217 ] ASF GitHub Bot commented on MNG-8101: - slawekjaranowski opened a new pull request, #1473: URL: https://github.com/apache/maven/pull/1473 https://issues.apache.org/jira/browse/MNG-8101 > Upgrade Parent to 42 > > > Key: MNG-8101 > URL: https://issues.apache.org/jira/browse/MNG-8101 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.7, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
cstamas commented on PR #916: URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067640854 ``` [INFO] [ERROR] class io.takari.maven.builder.smart.DependencyGraph cannot be cast to class io.takari.maven.builder.smart.DependencyGraph (io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @17a7cec2; io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @6a9b0a6f)java.lang.ClassCastException: class io.takari.maven.builder.smart.DependencyGraph cannot be cast to class io.takari.maven.builder.smart.DependencyGraph (io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @17a7cec2; io.takari.maven.builder.smart.DependencyGraph is in unnamed module of loader org.codehaus.plexus.classworlds.realm.ClassRealm @6a9b0a6f) at io.takari.maven.builder.smart.DependencyGraph.fromMaven (DependencyGraph.java:40) at io.takari.maven.builder.smart.SmartBuilder.build (SmartBuilder.java:88) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101) at org.apache.maven.cli.DaemonMavenCli.execute (DaemonMavenCli.java:858) at org.apache.maven.cli.DaemonMavenCli.doMain (DaemonMavenCli.java:253) at org.apache.maven.cli.DaemonMavenCli.main (DaemonMavenCli.java:230) at org.mvndaemon.mvnd.daemon.Server.handle (Server.java:612) at org.mvndaemon.mvnd.daemon.Server.client (Server.java:288) at org.mvndaemon.mvnd.daemon.Server.lambda$accept$2 (Server.java:250) at java.lang.Thread.run (Thread.java:1570) [ERROR] [ERROR] Re-run Maven using the -X switch to enable full debug logging. ``` Also, ``` mvnd clean install -e -Dmvnd.coreExtensionsExclude=io.takari.maven:takari-smart-builder ``` works but seems kinda default value is ignored? @gnodet @ppalaga -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
wendigo commented on PR #916: URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067641748 Just tested the master build with Trino and it seems to ignore the default property value for `MVND_CORE_EXTENSIONS_EXCLUDE` while the explicitly passed `-Dmvnd.coreExtensionsExclude` works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-8100] Upgrade default plugin bindings [maven]
slawekjaranowski opened a new pull request, #1474: URL: https://github.com/apache/maven/pull/1474 https://issues.apache.org/jira/browse/MNG-8100 https://github.com/apache/maven-integration-testing/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8100) Upgrade default plugin bindings
[
https://issues.apache.org/jira/browse/MNG-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839224#comment-17839224
]
ASF GitHub Bot commented on MNG-8100:
-
slawekjaranowski opened a new pull request, #1474:
URL: https://github.com/apache/maven/pull/1474
https://issues.apache.org/jira/browse/MNG-8100
https://github.com/apache/maven-integration-testing/pull/335
> Upgrade default plugin bindings
> ---
>
> Key: MNG-8100
> URL: https://issues.apache.org/jira/browse/MNG-8100
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.7, 4.0.0-alpha-14
>
>
> {noformat}
> 3.9.x
> compiler3.11.0 -> 3.13.0
> surefire3.2.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> 4.x
> compiler3.11.0 -> 3.13.0
> surefire3.1.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Ignore smart-builder core extension, if present. [maven-mvnd]
cstamas commented on PR #916: URL: https://github.com/apache/maven-mvnd/pull/916#issuecomment-2067646317 Def value handling here https://github.com/apache/maven-mvnd/pull/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default value must be manually handled [maven-mvnd]
wendigo commented on PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067647580 That works :) Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Default value must be manually handled [maven-mvnd]
cstamas commented on PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067647961 Am adding IT (something I'd done initially would catch this), and will merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]
wendigo commented on PR #933: URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067647836 @cstamas unfortunately still doesn't work for our case. I've tried reapplying: https://github.com/trinodb/trino/commit/ff1cddbd31d70610952922b19c13bd957e33f00f and that works in mvn but not in mvnd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Align mvnd m39 with Maven 3.9.x re config interpolation [maven-mvnd]
wendigo commented on PR #933:
URL: https://github.com/apache/maven-mvnd/pull/933#issuecomment-2067648142
Adding
`-Dmodernizer.violationsFile=${session.rootDirectory}/.mvn/modernizer/violations.xml`
to the `.mvn/maven.config` ends with the exception:
```
[ERROR] Failed to execute goal
org.gaul:modernizer-maven-plugin:2.7.0:modernizer (modernizer) on project
trino-root: Error opening violation file:
${session.rootDirectory}/.mvn/modernizer/violations.xml:
${session.rootDirectory}/.mvn/modernizer/violations.xml (No such file or
directory) -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Add Release Drafter [maven-apache-parent]
slawekjaranowski opened a new pull request, #215: URL: https://github.com/apache/maven-apache-parent/pull/215 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Add Release Drafter [maven-parent]
slawekjaranowski opened a new pull request, #174: URL: https://github.com/apache/maven-parent/pull/174 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHADE-471] deal with DST [maven-shade-plugin]
hboutemy commented on PR #220: URL: https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067694954 test done with Reproducible Central: https://github.com/hboutemy/reproducible-central/tree/MSHADE-471/MSHADE-471 tests that using UTC does not any more get a different result to using a TZ with a DST proves that the PR fixes the issue sadly I don't see how to change this test (that uses Docker and a lot of side artifacts) into an IT in maven-shade-plugin but no reason there will be a regression in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-471) still timestamp issues with timezones (DST?)
[
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839246#comment-17839246
]
ASF GitHub Bot commented on MSHADE-471:
---
hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067694954
test done with Reproducible Central:
https://github.com/hboutemy/reproducible-central/tree/MSHADE-471/MSHADE-471
tests that using UTC does not any more get a different result to using a TZ
with a DST
proves that the PR fixes the issue
sadly I don't see how to change this test (that uses Docker and a lot of
side artifacts) into an IT in maven-shade-plugin
but no reason there will be a regression in the future
> still timestamp issues with timezones (DST?)
>
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>
> MSHADE-420 is incomplete, problems still appear like
> {noformat}1 / 1
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │ -rw 2.0 fat 50 bl defN 24-Jan-23 12:20
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat 60 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat 60 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ -rw 2.0 fat0 bl defN 24-Apr-11 20:18
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> (fixed since then by using a TZ, but initial UTC shows the issue)
> looks related to DST: probably need to apply what has been done in
> plexus-archiver
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-471) still timestamp issues with timezones (DST?)
[
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839248#comment-17839248
]
ASF GitHub Bot commented on MSHADE-471:
---
rmannibucau commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067699038
* reproducible tests don't check the time is accurate whatever the timezone
is (it is the opposite as shown by the test)
* UTC tests do not use UTC time so they are iso other tests as of today
* proves the time management is wrong in shade dependency inclusion feature
which creates issues so we need to revisit it either enabling to configure the
timezone per dependency or using the UTC time when it is available (indeed it
does not enable reproducible builds if you build under another timezone by
design but it is expected IMHO since otherwise code depending on jar resources
time are just broken)
> still timestamp issues with timezones (DST?)
>
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>
> MSHADE-420 is incomplete, problems still appear like
> {noformat}1 / 1
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │ -rw 2.0 fat 50 bl defN 24-Jan-23 12:20
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat 60 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat 60 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ -rw 2.0 fat0 bl defN 24-Apr-11 20:18
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> (fixed since then by using a TZ, but initial UTC shows the issue)
> looks related to DST: probably need to apply what has been done in
> plexus-archiver
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-471] deal with DST [maven-shade-plugin]
rmannibucau commented on PR #220: URL: https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067699038 * reproducible tests don't check the time is accurate whatever the timezone is (it is the opposite as shown by the test) * UTC tests do not use UTC time so they are iso other tests as of today * proves the time management is wrong in shade dependency inclusion feature which creates issues so we need to revisit it either enabling to configure the timezone per dependency or using the UTC time when it is available (indeed it does not enable reproducible builds if you build under another timezone by design but it is expected IMHO since otherwise code depending on jar resources time are just broken) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHADE-471] deal with DST [maven-shade-plugin]
hboutemy commented on PR #220: URL: https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067704248 disagree: tests show reproducible builds independent from TZ = what they are supposed to be you are looking for something else: detail what you are looking for and work on it if you want that will be another Jira issue, another PR, another review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-471) still timestamp issues with timezones (DST?)
[
https://issues.apache.org/jira/browse/MSHADE-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839250#comment-17839250
]
ASF GitHub Bot commented on MSHADE-471:
---
hboutemy commented on PR #220:
URL:
https://github.com/apache/maven-shade-plugin/pull/220#issuecomment-2067704248
disagree: tests show reproducible builds independent from TZ = what they are
supposed to be
you are looking for something else: detail what you are looking for and work
on it if you want
that will be another Jira issue, another PR, another review
> still timestamp issues with timezones (DST?)
>
>
> Key: MSHADE-471
> URL: https://issues.apache.org/jira/browse/MSHADE-471
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>
> MSHADE-420 is incomplete, problems still appear like
> {noformat}1 / 1
> target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> toolbox/target/toolbox-0.1.5-cli.jar
> --- target/reference/eu.maveniverse.maven.plugins/toolbox-0.1.5-cli.jar
> +++ toolbox/target/toolbox-0.1.5-cli.jar
> ├── zipinfo {}
> │ @@ -735,96 +735,96 @@
> │ -rw 2.0 fat 50 bl defN 24-Jan-23 12:20
> META-INF/maven/org.jline/jline/pom.properties
> │ --rw 2.0 fat0 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/
> │ --rw 2.0 fat12491 bl defN 23-Oct-12 07:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ --rw 2.0 fat17329 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ --rw 2.0 fat 60 bl defN 23-Oct-12 07:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ +-rw 2.0 fat0 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/
> │ +-rw 2.0 fat12491 bl defN 23-Oct-12 06:38
> META-INF/native-image/jansi/jni-config.json
> ...
> │ +-rw 2.0 fat17329 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.xml
> │ +-rw 2.0 fat 60 bl defN 23-Oct-12 06:38
> META-INF/maven/org.fusesource.jansi/jansi/pom.properties
> │ -rw 2.0 fat0 bl defN 24-Apr-11 20:18
> eu/maveniverse/maven/toolbox/shared/
> {noformat}
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/eu/maveniverse/maven/toolbox/README.md
> (fixed since then by using a TZ, but initial UTC shows the issue)
> looks related to DST: probably need to apply what has been done in
> plexus-archiver
> https://github.com/codehaus-plexus/plexus-archiver/commit/b9ea3bf0e4c25c0a5cf1bcbc76e691067003dc36
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MSHADE-472) upgrade parent POM
Herve Boutemy created MSHADE-472: Summary: upgrade parent POM Key: MSHADE-472 URL: https://issues.apache.org/jira/browse/MSHADE-472 Project: Maven Shade Plugin Issue Type: Task Affects Versions: 3.5.2 Reporter: Herve Boutemy Fix For: 3.5.3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHADE-472) upgrade parent POM
[ https://issues.apache.org/jira/browse/MSHADE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839252#comment-17839252 ] ASF GitHub Bot commented on MSHADE-472: --- hboutemy opened a new pull request, #222: URL: https://github.com/apache/maven-shade-plugin/pull/222 (no comment) > upgrade parent POM > -- > > Key: MSHADE-472 > URL: https://issues.apache.org/jira/browse/MSHADE-472 > Project: Maven Shade Plugin > Issue Type: Task >Affects Versions: 3.5.2 >Reporter: Herve Boutemy >Priority: Major > Fix For: 3.5.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHADE-472] upgrade parent POM [maven-shade-plugin]
hboutemy merged PR #222: URL: https://github.com/apache/maven-shade-plugin/pull/222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSHADE-472) upgrade parent POM
[ https://issues.apache.org/jira/browse/MSHADE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MSHADE-472. Assignee: Herve Boutemy Resolution: Fixed > upgrade parent POM > -- > > Key: MSHADE-472 > URL: https://issues.apache.org/jira/browse/MSHADE-472 > Project: Maven Shade Plugin > Issue Type: Task >Affects Versions: 3.5.2 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 3.5.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHADE-472) upgrade parent POM
[ https://issues.apache.org/jira/browse/MSHADE-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839253#comment-17839253 ] ASF GitHub Bot commented on MSHADE-472: --- hboutemy merged PR #222: URL: https://github.com/apache/maven-shade-plugin/pull/222 > upgrade parent POM > -- > > Key: MSHADE-472 > URL: https://issues.apache.org/jira/browse/MSHADE-472 > Project: Maven Shade Plugin > Issue Type: Task >Affects Versions: 3.5.2 >Reporter: Herve Boutemy >Priority: Major > Fix For: 3.5.3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]
CrazyHZM commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1573331701
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 4.0.0
Review Comment:
If we support it in 3.9.7, should it be changed to 3.9.7?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[
https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839257#comment-17839257
]
ASF GitHub Bot commented on MNG-8031:
-
CrazyHZM commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1573331701
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 4.0.0
Review Comment:
If we support it in 3.9.7, should it be changed to 3.9.7?
> Backport: Make Maven transfer listener used with Resolver more concurrent
> friendly
> --
>
> Key: MNG-8031
> URL: https://issues.apache.org/jira/browse/MNG-8031
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7
>
>
> Backport of MNG-8007
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
hboutemy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067720981 @kbuntrock I see you created MBUILDCACHE-86 and renamed the PR title can you also update the Git commit to `[MBUILDCACHE-86]` instead of `[PR-104]` please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839258#comment-17839258 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- hboutemy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067720981 @kbuntrock I see you created MBUILDCACHE-86 and renamed the PR title can you also update the Git commit to `[MBUILDCACHE-86]` instead of `[PR-104]` please? > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated MBUILDCACHE-86: -- Labels: pull-request-available (was: ) > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
hboutemy commented on code in PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#discussion_r1573334304
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -92,16 +92,17 @@
import static
org.apache.maven.buildcache.xml.CacheConfigImpl.CACHE_ENABLED_PROPERTY_NAME;
import static org.apache.maven.buildcache.xml.CacheConfigImpl.CACHE_SKIP;
import static
org.apache.maven.buildcache.xml.CacheConfigImpl.RESTORE_GENERATED_SOURCES_PROPERTY_NAME;
+import static
org.apache.maven.buildcache.xml.CacheConfigImpl.RESTORE_ON_DISK_ARTEFACTS_PROPERTY_NAME;
Review Comment:
s/ARTEFACT/ARTIFACT/
##
src/main/java/org/apache/maven/buildcache/artifact/OutputType.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.buildcache.artifact;
+
+public enum OutputType {
+// generated project artefact
+ARTEFACT(""),
Review Comment:
yes, ARTIFACT in english, not nice french ARTEFACT :)
##
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##
@@ -90,6 +91,7 @@ public class CacheConfigImpl implements
org.apache.maven.buildcache.xml.CacheCon
public static final String FAIL_FAST_PROPERTY_NAME =
"maven.build.cache.failFast";
public static final String BASELINE_BUILD_URL_PROPERTY_NAME =
"maven.build.cache.baselineUrl";
public static final String LAZY_RESTORE_PROPERTY_NAME =
"maven.build.cache.lazyRestore";
+public static final String RESTORE_ON_DISK_ARTEFACTS_PROPERTY_NAME =
"maven.build.cache.restoreOnDiskArtefacts";
Review Comment:
same
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -710,6 +711,18 @@ public static boolean
isRestoreGeneratedSources(MavenProject project) {
project.getProperties().getProperty(RESTORE_GENERATED_SOURCES_PROPERTY_NAME,
"true"));
}
+/**
+ * Allow skipping artefacts restoration on a per-project level via a
property (which defaults to true)
Review Comment:
s/artefacts/artifacts/ (in comment, not critical)
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -112,13 +114,10 @@
@SuppressWarnings("unused")
public class CacheControllerImpl implements CacheController {
-public static final String FILE_SEPARATOR_SUBST = "_";
-/**
- * Prefix for generated sources stored as a separate artifact in cache
- */
-private static final String BUILD_PREFIX = "build" + FILE_SEPARATOR_SUBST;
-
private static final Logger LOGGER =
LoggerFactory.getLogger(CacheControllerImpl.class);
+private static final String DEFAULT_FILE_GLOB = "*";
+public static final String ERROR_MSG_RESTORATION_OUTSIDE_PROJECT =
+"Blocked an attempt to restore files outside of a project
directory : ";
Review Comment:
in english, no space before `:` (yes, french with non-breaking space is much
better, but we must adapt :) )
##
src/main/java/org/apache/maven/buildcache/xml/CacheConfig.java:
##
@@ -131,5 +132,10 @@ public interface CacheConfig {
*/
boolean isRestoreGeneratedSources();
+/**
+ * Flag to restore (default) or not generated artefacts
+ */
+boolean isRestoreOnDiskArtefacts();
Review Comment:
s/artefacts/artifacts/
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -133,6 +132,15 @@ public class CacheControllerImpl implements
CacheController {
private final RestoredArtifactHandler restoreArtifactHandler;
private volatile Scm scm;
+/**
+ * A map dedicated to store the base path of resources stored to the cache
which are not original artefacts
Review Comment:
s/artefacts/artifacts/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[
https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839259#comment-17839259
]
ASF GitHub Bot commented on MBUILDCACHE-86:
---
hboutemy commented on code in PR #104:
URL:
https://github.com/apache/maven-build-cache-extension/pull/104#discussion_r1573334304
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -92,16 +92,17 @@
import static
org.apache.maven.buildcache.xml.CacheConfigImpl.CACHE_ENABLED_PROPERTY_NAME;
import static org.apache.maven.buildcache.xml.CacheConfigImpl.CACHE_SKIP;
import static
org.apache.maven.buildcache.xml.CacheConfigImpl.RESTORE_GENERATED_SOURCES_PROPERTY_NAME;
+import static
org.apache.maven.buildcache.xml.CacheConfigImpl.RESTORE_ON_DISK_ARTEFACTS_PROPERTY_NAME;
Review Comment:
s/ARTEFACT/ARTIFACT/
##
src/main/java/org/apache/maven/buildcache/artifact/OutputType.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.buildcache.artifact;
+
+public enum OutputType {
+// generated project artefact
+ARTEFACT(""),
Review Comment:
yes, ARTIFACT in english, not nice french ARTEFACT :)
##
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##
@@ -90,6 +91,7 @@ public class CacheConfigImpl implements
org.apache.maven.buildcache.xml.CacheCon
public static final String FAIL_FAST_PROPERTY_NAME =
"maven.build.cache.failFast";
public static final String BASELINE_BUILD_URL_PROPERTY_NAME =
"maven.build.cache.baselineUrl";
public static final String LAZY_RESTORE_PROPERTY_NAME =
"maven.build.cache.lazyRestore";
+public static final String RESTORE_ON_DISK_ARTEFACTS_PROPERTY_NAME =
"maven.build.cache.restoreOnDiskArtefacts";
Review Comment:
same
##
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##
@@ -710,6 +711,18 @@ public static boolean
isRestoreGeneratedSources(MavenProject project) {
project.getProperties().getProperty(RESTORE_GENERATED_SOURCES_PROPERTY_NAME,
"true"));
}
+/**
+ * Allow skipping artefacts restoration on a per-project level via a
property (which defaults to true)
Review Comment:
s/artefacts/artifacts/ (in comment, not critical)
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -112,13 +114,10 @@
@SuppressWarnings("unused")
public class CacheControllerImpl implements CacheController {
-public static final String FILE_SEPARATOR_SUBST = "_";
-/**
- * Prefix for generated sources stored as a separate artifact in cache
- */
-private static final String BUILD_PREFIX = "build" + FILE_SEPARATOR_SUBST;
-
private static final Logger LOGGER =
LoggerFactory.getLogger(CacheControllerImpl.class);
+private static final String DEFAULT_FILE_GLOB = "*";
+public static final String ERROR_MSG_RESTORATION_OUTSIDE_PROJECT =
+"Blocked an attempt to restore files outside of a project
directory : ";
Review Comment:
in english, no space before `:` (yes, french with non-breaking space is much
better, but we must adapt :) )
##
src/main/java/org/apache/maven/buildcache/xml/CacheConfig.java:
##
@@ -131,5 +132,10 @@ public interface CacheConfig {
*/
boolean isRestoreGeneratedSources();
+/**
+ * Flag to restore (default) or not generated artefacts
+ */
+boolean isRestoreOnDiskArtefacts();
Review Comment:
s/artefacts/artifacts/
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -133,6 +132,15 @@ public class CacheControllerImpl implements
CacheController {
private final RestoredArtifactHandler restoreArtifactHandler;
private volatile Scm scm;
+/**
+ * A map dedicated to store the base path of resources stored to the cache
which are not original artefacts
Review Comment:
s/artefacts/artifacts/
> Bugfix and enhancements with the restoration of outputs on disk
>
Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]
cstamas commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1573344072
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 4.0.0
Review Comment:
```suggestion
* @since 3.9.7
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[
https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839263#comment-17839263
]
ASF GitHub Bot commented on MNG-8031:
-
cstamas commented on code in PR #1471:
URL: https://github.com/apache/maven/pull/1471#discussion_r1573344072
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/SimplexTransferListener.java:
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.cli.transfer;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.ArrayBlockingQueue;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CountDownLatch;
+import java.util.function.Consumer;
+
+import org.eclipse.aether.transfer.AbstractTransferListener;
+import org.eclipse.aether.transfer.TransferCancelledException;
+import org.eclipse.aether.transfer.TransferEvent;
+import org.eclipse.aether.transfer.TransferListener;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * A {@link TransferListener} implementation that wraps another delegate
{@link TransferListener} but makes it run
+ * on single thread, keeping the listener logic simple. This listener also
blocks on last transfer event to allow
+ * output to perform possible cleanup. It spawns a daemon thread to consume
queued events that may fall in even
+ * concurrently.
+ *
+ * @since 4.0.0
Review Comment:
```suggestion
* @since 3.9.7
```
> Backport: Make Maven transfer listener used with Resolver more concurrent
> friendly
> --
>
> Key: MNG-8031
> URL: https://issues.apache.org/jira/browse/MNG-8031
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.7
>
>
> Backport of MNG-8007
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[I] Make mvnd Java17 [maven-mvnd]
cstamas opened a new issue, #954: URL: https://github.com/apache/maven-mvnd/issues/954 Fully. So both m39 and m40 should require Java17. This is basically this simplify our own lives, and easier maintain. Maven4 is already Java17. If someone must have Java8 to build, should use Maven 3.9.x + smart builder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] Make client thin [maven-mvnd]
cstamas opened a new issue, #955: URL: https://github.com/apache/maven-mvnd/issues/955 Currently there is some heavy logic in client, but IMHO it is superfluous. Instead, make client thin as possible: * it should collect all maven config and create "seed" (ie. by hashing these things opaquely) * based on "seed" select (or start) a daemon * it should collect CWD and CLI params and send those those to daemon * sit and wait, and let m39, m40, mXX decide what it likes or dislikes out of params -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
kwin commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573354321
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) {
*
* @return List of site directories files.
*/
-public List getSiteDirectories() {
+public List getSiteDirectories() {
Review Comment:
Please leave the old method in place, deprecate it and rename the new one
(cannot come up with a good naming proposal right now). But please don't just
break backwards compatibility.
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
Why breaking backwards compatibility? Just leave the old method taking
`File` in place, deprecate it and just delegate to the new `addSiteDirectory`
For the new method please add `@since`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-324] Allow configuration of parsers [maven-doxia-sitetools]
kwin merged PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839264#comment-17839264
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
kwin commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573354321
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) {
*
* @return List of site directories files.
*/
-public List getSiteDirectories() {
+public List getSiteDirectories() {
Review Comment:
Please leave the old method in place, deprecate it and rename the new one
(cannot come up with a good naming proposal right now). But please don't just
break backwards compatibility.
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
Why breaking backwards compatibility? Just leave the old method taking
`File` in place, deprecate it and just delegate to the new `addSiteDirectory`
For the new method please add `@since`.
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-324) Allow configuration of parser per markup
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839265#comment-17839265 ] ASF GitHub Bot commented on DOXIASITETOOLS-324: --- kwin merged PR #140: URL: https://github.com/apache/maven-doxia-sitetools/pull/140 > Allow configuration of parser per markup > > > Key: DOXIASITETOOLS-324 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324 > Project: Maven Doxia Sitetools > Issue Type: New Feature > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently the Doxia parsers being used for the Doxia markup sources have a > fix configuration > (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324). > It would be beneficial to allow to dynamically configure the parsers (based > on a matching markup source path pattern) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Default value must be manually handled [maven-mvnd]
cstamas commented on PR #953: URL: https://github.com/apache/maven-mvnd/pull/953#issuecomment-2067741336 The code change is OK and fixes issue, but something is wrong. Created https://github.com/apache/maven-mvnd/issues/957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (DOXIASITETOOLS-324) Allow configuration of parser per markup
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved DOXIASITETOOLS-324. Fix Version/s: 2.0.0 2.0.0-M18 Resolution: Fixed > Allow configuration of parser per markup > > > Key: DOXIASITETOOLS-324 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-324 > Project: Maven Doxia Sitetools > Issue Type: New Feature > Components: Site renderer >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 2.0.0, 2.0.0-M18 > > > Currently the Doxia parsers being used for the Doxia markup sources have a > fix configuration > (https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L324). > It would be beneficial to allow to dynamically configure the parsers (based > on a matching markup source path pattern) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358753
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
The general question: What is the affected audience? The only known
consumer/caller is Maven Site Plugin. You expect this to break in a combination
you can already forsee?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358826
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
Will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839267#comment-17839267
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358826
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
Will do.
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839266#comment-17839266
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358753
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
The general question: What is the affected audience? The only known
consumer/caller is Maven Site Plugin. You expect this to break in a combination
you can already forsee?
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573361548
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) {
*
* @return List of site directories files.
*/
-public List getSiteDirectories() {
+public List getSiteDirectories() {
Review Comment:
I cannot come up with a better one either, but am willing to take the BC
break on my shoulders given that the scope of usage is quite limited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067747899 @hboutemy Any comments on the binary compat? I am OK to break it since it this is a major version and the sole public user is Maven Site Plugin... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839268#comment-17839268
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573361548
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -271,7 +290,7 @@ public void addSiteDirectory(File siteDirectory) {
*
* @return List of site directories files.
*/
-public List getSiteDirectories() {
+public List getSiteDirectories() {
Review Comment:
I cannot come up with a better one either, but am willing to take the BC
break on my shoulders given that the scope of usage is quite limited.
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] Make client thin [maven-mvnd]
gnodet commented on issue #955: URL: https://github.com/apache/maven-mvnd/issues/955#issuecomment-2067748092 The goal is to fully respect what the user environment as usually loaded by maven. The compatibility is defined by two simple things: * the JVM path (a `String`) * a list of options (`List`) The list of options is known as _discriminating options_. Those are options that actually make the daemon different and thus needs a different daemon. So we can definitely compute a hash of those strings, but that won't really simplify things, as the tricky part is to list and gather those options, not to compare those. For point #3, I think that's what the client roughly does. Why would that be different ? Not sure to understand #4... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839269#comment-17839269
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067747899
@hboutemy Any comments on the binary compat? I am OK to break it since it
this is a major version and the sole public user is Maven Site Plugin...
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [I] Make mvnd Java17 [maven-mvnd]
gnodet commented on issue #954: URL: https://github.com/apache/maven-mvnd/issues/954#issuecomment-2067749362 > Fully. So both m39 and m40 should require Java17. This is basically to simplify our own lives, and easier maintain. Maven4 is already Java17. If someone must have Java8 to build, should use Maven 3.9.x + smart builder. That's not the hard part to maintain. The hard part is the DaemonMavenCli. If you really want to make a difference in term of maintenance, that's where things need to be fixed. People did contribute a bunch of PRs to make mvnd work the very same way than maven does, so that they can be used interchangeably, I'm not really sure we want to loose that for no real benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573364171
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839271#comment-17839271
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on code in PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573364171
##
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
* Add a site directory, expected to have a Doxia Site layout, ie one
directory per Doxia parser module containing
* files with parser extension. Typical values are src/site
or target/generated-site.
*
- * @param siteDirectory a {@link java.io.File} object.
+ * @param siteDirectory a {@link SiteDirectory} object.
*/
-public void addSiteDirectory(File siteDirectory) {
+public void addSiteDirectory(SiteDirectory siteDirectory) {
Review Comment:
Done
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-336] Make SiteRenderingContext#siteDirectories editab… [maven-doxia-sitetools]
michael-o commented on PR #150: URL: https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067752090 Rename to `SiteSourceDirectory`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-336) Make SiteRenderingContext#siteDirectories editable aware
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839272#comment-17839272
]
ASF GitHub Bot commented on DOXIASITETOOLS-336:
---
michael-o commented on PR #150:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/150#issuecomment-2067752090
Rename to `SiteSourceDirectory`?
> Make SiteRenderingContext#siteDirectories editable aware
>
>
> Key: DOXIASITETOOLS-336
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-336
> Project: Maven Doxia Sitetools
> Issue Type: Improvement
> Components: Site renderer
>Affects Versions: 2.0.0-M16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M18
>
>
> Right now you cannot qualify a {{siteDirectory}} whether the content is
> editable or generated. You need to perform multiple calls with distinct
> {{SiteRenderingContexts}}. This causes computational overhead is hacks like
> MSITE-723.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8101] Upgrade Parent to 42 [maven]
slawekjaranowski merged PR #1473: URL: https://github.com/apache/maven/pull/1473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8101) Upgrade Parent to 42
[ https://issues.apache.org/jira/browse/MNG-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839273#comment-17839273 ] ASF GitHub Bot commented on MNG-8101: - slawekjaranowski merged PR #1473: URL: https://github.com/apache/maven/pull/1473 > Upgrade Parent to 42 > > > Key: MNG-8101 > URL: https://issues.apache.org/jira/browse/MNG-8101 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.7, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Make our lives simpler: mvnd is Java17 [maven-mvnd]
cstamas commented on PR #956: URL: https://github.com/apache/maven-mvnd/pull/956#issuecomment-2067756679 But, locally am not building native, so how does mvnd work for me then? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Make our lives simpler: mvnd is Java17 [maven-mvnd]
gnodet commented on PR #956: URL: https://github.com/apache/maven-mvnd/pull/956#issuecomment-2067761716 > But, locally am not building native, so how does mvnd work for me then? The native binary is preferred when available. Then `java-mvnd` is used to run mvnd in JVM mode and JDK >= 11. The `java-fallback` is used in JVM mode when JDK < 11 and basically falls back to plain maven. The goal is to be able to always use mvnd instead of maven. You don't have to care, it will just work whatever your environment is. What your PR propose, is, of course, a simplification of the code, but it will limit the usage of mvnd to a smaller set of supported combinations of platforms + JDK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add Release Drafter [maven-apache-parent]
slawekjaranowski merged PR #215: URL: https://github.com/apache/maven-apache-parent/pull/215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8100] Upgrade default plugin bindings - fix ITs [maven-integration-testing]
slawekjaranowski merged PR #335: URL: https://github.com/apache/maven-integration-testing/pull/335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8100] Upgrade default plugin bindings [maven]
slawekjaranowski merged PR #1474: URL: https://github.com/apache/maven/pull/1474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8100) Upgrade default plugin bindings
[
https://issues.apache.org/jira/browse/MNG-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839277#comment-17839277
]
ASF GitHub Bot commented on MNG-8100:
-
slawekjaranowski merged PR #1474:
URL: https://github.com/apache/maven/pull/1474
> Upgrade default plugin bindings
> ---
>
> Key: MNG-8100
> URL: https://issues.apache.org/jira/browse/MNG-8100
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.7, 4.0.0-alpha-14
>
>
> {noformat}
> 3.9.x
> compiler3.11.0 -> 3.13.0
> surefire3.2.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> 4.x
> compiler3.11.0 -> 3.13.0
> surefire3.1.2 -> 3.2.5
> jar 3.3.0 -> 3.4.1
> plugin 3.9.0 -> 3.12.0
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8031] Backport concurrent friendly transport listener [maven]
cstamas merged PR #1471: URL: https://github.com/apache/maven/pull/1471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839283#comment-17839283 ] ASF GitHub Bot commented on MNG-8031: - cstamas merged PR #1471: URL: https://github.com/apache/maven/pull/1471 > Backport: Make Maven transfer listener used with Resolver more concurrent > friendly > -- > > Key: MNG-8031 > URL: https://issues.apache.org/jira/browse/MNG-8031 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-8007 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8031) Backport: Make Maven transfer listener used with Resolver more concurrent friendly
[ https://issues.apache.org/jira/browse/MNG-8031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8031. Resolution: Fixed > Backport: Make Maven transfer listener used with Resolver more concurrent > friendly > -- > > Key: MNG-8031 > URL: https://issues.apache.org/jira/browse/MNG-8031 > Project: Maven > Issue Type: Improvement > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-8007 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8011] Neuter the README [maven]
cstamas merged PR #1470: URL: https://github.com/apache/maven/pull/1470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8030) Backport: Add ability to ignore dependency repositories: mvn -itr
[ https://issues.apache.org/jira/browse/MNG-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839284#comment-17839284 ] ASF GitHub Bot commented on MNG-8030: - cstamas merged PR #1469: URL: https://github.com/apache/maven/pull/1469 > Backport: Add ability to ignore dependency repositories: mvn -itr > - > > Key: MNG-8030 > URL: https://issues.apache.org/jira/browse/MNG-8030 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-7980 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8011) Minimize and make generic the README.txt
[ https://issues.apache.org/jira/browse/MNG-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8011. Resolution: Fixed > Minimize and make generic the README.txt > > > Key: MNG-8011 > URL: https://issues.apache.org/jira/browse/MNG-8011 > Project: Maven > Issue Type: Task > Components: Bootstrap & Build >Affects Versions: 3.9.6 >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > The current readme is totally outdated: > https://github.com/apache/maven/blob/master/apache-maven/README.txt > Java 1.3? > Cut down this README.txt and ideally just point it to release notes on site, > to lessen maintenance of this file. Less content, less effort needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8030] Backport itr: ignore transitive repositories [maven]
cstamas merged PR #1469: URL: https://github.com/apache/maven/pull/1469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-8030) Backport: Add ability to ignore dependency repositories: mvn -itr
[ https://issues.apache.org/jira/browse/MNG-8030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8030. Resolution: Fixed > Backport: Add ability to ignore dependency repositories: mvn -itr > - > > Key: MNG-8030 > URL: https://issues.apache.org/jira/browse/MNG-8030 > Project: Maven > Issue Type: Improvement > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Backport of MNG-7980 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8011) Minimize and make generic the README.txt
[ https://issues.apache.org/jira/browse/MNG-8011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839285#comment-17839285 ] ASF GitHub Bot commented on MNG-8011: - cstamas merged PR #1470: URL: https://github.com/apache/maven/pull/1470 > Minimize and make generic the README.txt > > > Key: MNG-8011 > URL: https://issues.apache.org/jira/browse/MNG-8011 > Project: Maven > Issue Type: Task > Components: Bootstrap & Build >Affects Versions: 3.9.6 >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > The current readme is totally outdated: > https://github.com/apache/maven/blob/master/apache-maven/README.txt > Java 1.3? > Cut down this README.txt and ideally just point it to release notes on site, > to lessen maintenance of this file. Less content, less effort needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8094] Resolver 1.9.19 [maven]
cstamas merged PR #1468: URL: https://github.com/apache/maven/pull/1468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-8094) Resolver 1.9.19
[ https://issues.apache.org/jira/browse/MNG-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839286#comment-17839286 ] ASF GitHub Bot commented on MNG-8094: - cstamas merged PR #1468: URL: https://github.com/apache/maven/pull/1468 > Resolver 1.9.19 > --- > > Key: MNG-8094 > URL: https://issues.apache.org/jira/browse/MNG-8094 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Resolver 1.9.19 release notes > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8094) Resolver 1.9.19
[ https://issues.apache.org/jira/browse/MNG-8094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8094. Resolution: Fixed > Resolver 1.9.19 > --- > > Key: MNG-8094 > URL: https://issues.apache.org/jira/browse/MNG-8094 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.7 > > > Resolver 1.9.19 release notes > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Add Release Drafter [maven-parent]
slawekjaranowski merged PR #174: URL: https://github.com/apache/maven-parent/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [PR-103] A "mandatory clean" option to enable the caching functionnality [maven-build-cache-extension]
AlexanderAshitkin commented on code in PR #103:
URL:
https://github.com/apache/maven-build-cache-extension/pull/103#discussion_r1573409460
##
src/test/java/org/apache/maven/buildcache/util/LogFileUtils.java:
##
@@ -60,4 +61,32 @@ public static String
findFirstLineContainingTextsInLogs(final Verifier verifier,
return null;
}
+
+/**
+ * Find lines matching all the strings given as parameter in the log file
attached to a verifier
+ * @param verifier the maven verifier instance
+ * @param texts all the matching strings to find
+ * @return a list of matching strings
+ * @throws VerificationException
+ */
+public static List findLinesContainingTextsInLogs(final Verifier
verifier, final String... texts)
+throws VerificationException {
+List lines = verifier.loadFile(verifier.getBasedir(),
verifier.getLogFileName(), false);
+List result = new ArrayList<>();
+Iterator it = lines.iterator();
+
+while (it.hasNext()) {
+String line = verifier.stripAnsi((String) it.next());
+boolean matches = true;
+Iterator toMatchIterator = Arrays.stream(texts).iterator();
Review Comment:
Not a critical piece of code, but it is more elegant and efficient to use
[StringUtils#containsAny](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#containsAny-java.lang.CharSequence-java.lang.CharSequence...-)
and
[Stream#anyMatch](https://docs.oracle.com/en%2Fjava%2Fjavase%2F11%2Fdocs%2Fapi%2F%2F/java.base/java/util/stream/Stream.html#anyMatch(java.util.function.Predicate)):
```java
return Files.lines(filePath) // or lines.stream()
.anyMatch(line -> StringUtils.containsAny(line, texts));
.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [PR-103] A "mandatory clean" option to enable the caching functionnality [maven-build-cache-extension]
AlexanderAshitkin commented on code in PR #103:
URL:
https://github.com/apache/maven-build-cache-extension/pull/103#discussion_r1573409460
##
src/test/java/org/apache/maven/buildcache/util/LogFileUtils.java:
##
@@ -60,4 +61,32 @@ public static String
findFirstLineContainingTextsInLogs(final Verifier verifier,
return null;
}
+
+/**
+ * Find lines matching all the strings given as parameter in the log file
attached to a verifier
+ * @param verifier the maven verifier instance
+ * @param texts all the matching strings to find
+ * @return a list of matching strings
+ * @throws VerificationException
+ */
+public static List findLinesContainingTextsInLogs(final Verifier
verifier, final String... texts)
+throws VerificationException {
+List lines = verifier.loadFile(verifier.getBasedir(),
verifier.getLogFileName(), false);
+List result = new ArrayList<>();
+Iterator it = lines.iterator();
+
+while (it.hasNext()) {
+String line = verifier.stripAnsi((String) it.next());
+boolean matches = true;
+Iterator toMatchIterator = Arrays.stream(texts).iterator();
Review Comment:
Not a critical piece of code, but it is more elegant and efficient to use
[StringUtils#containsAny](https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#containsAny-java.lang.CharSequence-java.lang.CharSequence...-)
and
[Stream#anyMatch](https://docs.oracle.com/en%2Fjava%2Fjavase%2F11%2Fdocs%2Fapi%2F%2F/java.base/java/util/stream/Stream.html#anyMatch(java.util.function.Predicate)):
```java
return Files.lines(filePath) // or lines.stream()
.anyMatch(line -> StringUtils.containsAny(line, texts));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
AlexanderAshitkin commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067786122 Hi, @kbuntrock @hboutemy. This PR looks good. How can we move it from a draft to an open state? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839294#comment-17839294 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- AlexanderAshitkin commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067786122 Hi, @kbuntrock @hboutemy. This PR looks good. How can we move it from a draft to an open state? > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Add option: `maven.build.cache.forceRenew` [maven-build-cache-extension]
AlexanderAshitkin commented on PR #137: URL: https://github.com/apache/maven-build-cache-extension/pull/137#issuecomment-2067799173 Hi @zorglube You are likely looking for the `maven.build.cache.skipCache` property. If the property is set to true, the build doesn't use any of the cached artifacts but writes the results to the cache (if allowed by config), effectively achieving the `forceRenew` functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Enable GitHUb issues [maven-parent]
slawekjaranowski opened a new pull request, #175: URL: https://github.com/apache/maven-parent/pull/175 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Enable GitHUb issues [maven-apache-parent]
slawekjaranowski opened a new pull request, #216: URL: https://github.com/apache/maven-apache-parent/pull/216 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add option: `maven.build.cache.forceRenew` [maven-build-cache-extension]
zorglube commented on PR #137: URL: https://github.com/apache/maven-build-cache-extension/pull/137#issuecomment-2067805611 Damn I didn't understood that. Do you have any examples of the configuration needed to achieve that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-86) Bugfix and enhancements with the restoration of outputs on disk
[ https://issues.apache.org/jira/browse/MBUILDCACHE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839303#comment-17839303 ] ASF GitHub Bot commented on MBUILDCACHE-86: --- olamy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067829609 > you should just search global "artefact" and fix :) > Both are correct it only depends if we consider speaking English from UK or English from US But hey original English is from UK :) > Bugfix and enhancements with the restoration of outputs on disk > --- > > Key: MBUILDCACHE-86 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-86 > Project: Maven Build Cache Extension > Issue Type: Improvement >Reporter: Kevin Buntrock >Priority: Major > Labels: pull-request-available > > *Fixes :* > * Files containing an underscore in their name can't be restored in the > cache directory correctly (not in the same directory location). > * The cache is able to extract/restore files in locations outside the > project. I guess the extraction part is not a vulnerability since someone > with commit permissions can guess other ways to extract data. But the > possibility of restoring at any place on the disk looks pretty dangerous to > me if a remote cache server is compromised. > *Enhancements :* > * Possibility to restore artefacts on disk, with a dedicated property : > maven.build.cache.restoreOnDiskArtefacts (default to true). Meaning in the > project directory, as opposed to the cache directory. > ** IDE integration and use of the cache locally in developement is way > easier. It is now possible to retrieve a cached jar in the "target" directory. > * Introduce "globs" to filter extra attached outputs by filenames. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]
olamy commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2067829609 > you should just search global "artefact" and fix :) > Both are correct it only depends if we consider speaking English from UK or English from US But hey original English is from UK :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MARTIFACT-62] Drop deprecated classes and artifacts [maven-artifact-plugin]
hboutemy merged PR #31: URL: https://github.com/apache/maven-artifact-plugin/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MARTIFACT-62] Drop deprecated classes and artifacts [maven-artifact-plugin]
hboutemy commented on PR #31: URL: https://github.com/apache/maven-artifact-plugin/pull/31#issuecomment-2067924167 thank you @cstamas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump resolverVersion from 1.9.18 to 1.9.19 [maven-artifact-plugin]
dependabot[bot] opened a new pull request, #33: URL: https://github.com/apache/maven-artifact-plugin/pull/33 Bumps `resolverVersion` from 1.9.18 to 1.9.19. Updates `org.apache.maven.resolver:maven-resolver-api` from 1.9.18 to 1.9.19 Release notes Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-api's releases. 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release Notes - Maven Resolver - Version 1.9.19 What's Changed [1.9.x][MRESOLVER-483] Fix path concatenation logic by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/420";>apache/maven-resolver#420 [1.9.x] [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/461";>apache/maven-resolver#461 [1.9.x] Update dependencies by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/462";>apache/maven-resolver#462 [1.9.x] [MRESOLVER-536] Do not belly up if FS does not support setting mtime by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/469";>apache/maven-resolver#469 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19 Commits https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56";>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0";>adadd42 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469";>#469) https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c";>31df8a3 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462";>#462) https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7";>b225076 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) (https://redirect.github.com/apache/maven-resolver/issues/461";>#461) https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c";>fc969c2 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420";>#420) https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde";>a3e620d Use one Maven in CI https://github.com/apache/maven-resolver/commit/fff4bdf92fe10937975623db27a69ced5d1efcd1";>fff4bdf [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19";>compare view Updates `org.apache.maven.resolver:maven-resolver-util` from 1.9.18 to 1.9.19 Release notes Sourced from https://github.com/apache/maven-resolver/releases";>org.apache.maven.resolver:maven-resolver-util's releases. 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12353946";>Release Notes - Maven Resolver - Version 1.9.19 What's Changed [1.9.x][MRESOLVER-483] Fix path concatenation logic by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/420";>apache/maven-resolver#420 [1.9.x] [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455";>#455) by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/461";>apache/maven-resolver#461 [1.9.x] Update dependencies by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/462";>apache/maven-resolver#462 [1.9.x] [MRESOLVER-536] Do not belly up if FS does not support setting mtime by https://github.com/cstamas";>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/469";>apache/maven-resolver#469 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19";>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.19 Commits https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56";>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0";>adadd42 [MRESO
[PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.3 [maven-artifact-plugin]
dependabot[bot] opened a new pull request, #34: URL: https://github.com/apache/maven-artifact-plugin/pull/34 Bumps [org.codehaus.plexus:plexus-xml](https://github.com/codehaus-plexus/plexus-xml) from 3.0.0 to 4.0.3. Release notes Sourced from https://github.com/codehaus-plexus/plexus-xml/releases";>org.codehaus.plexus:plexus-xml's releases. 4.0.1 Fix detection of invalid spaces in prolog (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/20";>#20) https://github.com/gnodet";>@gnodet pom.mxl and site.xml cleanup (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/19";>#19) https://github.com/hboutemy";>@hboutemy Plexus XML 4.0.2 What's Changed Cleanup after parent pom upgrade by https://github.com/slachiewicz";>@slachiewicz in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22 Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17) by https://github.com/gnodet";>@gnodet in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/23";>codehaus-plexus/plexus-xml#23 New Contributors https://github.com/slachiewicz";>@slachiewicz made their first contribution in https://redirect.github.com/codehaus-plexus/plexus-xml/pull/22";>codehaus-plexus/plexus-xml#22 Full Changelog: https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2";>https://github.com/codehaus-plexus/plexus-xml/compare/plexus-xml-4.0.1...plexus-xml-4.0.2 4.0.0 Use spotless (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/8";>#8) https://github.com/gnodet";>@gnodet Fix site generation (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/15";>#15) https://github.com/gnodet";>@gnodet Switch build ci workflow to master branch (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/14";>#14) https://github.com/gnodet";>@gnodet Fix SCM urls (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/13";>#13) https://github.com/gnodet";>@gnodet MXParser tokenization fails when PI is before first tag (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/7";>#7) (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/12";>#12) https://github.com/gnodet";>@gnodet Deprecate Xpp3DomUtils (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/6";>#6) (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/9";>#9) https://github.com/gnodet";>@gnodet Use a ArrayDeque (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/5";>#5) https://github.com/gnodet";>@gnodet Upgrade plugins and clean build warnings (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/4";>#4) https://github.com/gnodet";>@gnodet Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/2";>#2) https://github.com/gnodet";>@gnodet Fix parsing an UTF-8 file without BOM and ISO-8859-1 encoding (https://redirect.github.com/codehaus-plexus/plexus-xml/pull/1";>#1) https://github.com/gnodet";>@gnodet Commits https://github.com/codehaus-plexus/plexus-xml/commit/784ff955e0944bea8b3a15254ad7ce06ae72dc20";>784ff95 [maven-release-plugin] prepare release plexus-xml-4.0.3 https://github.com/codehaus-plexus/plexus-xml/commit/e6a6427dd4c1e0b40832ea027f5c102cd739ef85";>e6a6427 Upgrade to Maven 4.0.0-alpha-9 (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/27";>#27) https://github.com/codehaus-plexus/plexus-xml/commit/aa82ed33a2e8c178fcd2a2106f57023d6947d84e";>aa82ed3 Update dependencies (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/26";>#26) https://github.com/codehaus-plexus/plexus-xml/commit/7bfeb09596b87f4a28add4699bbd663fe6dcbd6e";>7bfeb09 clarify "Maven 4-specific" https://github.com/codehaus-plexus/plexus-xml/commit/07f63919296984b2c5f5d30a433411c0715b2e9e";>07f6391 explain 3 vs 4 https://github.com/codehaus-plexus/plexus-xml/commit/bcf34dcd790955f6381efe442f2d24dbe2b8170e";>bcf34dc describe plexus-xml update to maven-xml-impl https://github.com/codehaus-plexus/plexus-xml/commit/72c06a0a2d0793a79b1ea6b68eb453cc1ee9c867";>72c06a0 [maven-release-plugin] prepare for next development iteration https://github.com/codehaus-plexus/plexus-xml/commit/944197c74386b199857a003160d840fb5593ac29";>944197c [maven-release-plugin] prepare release plexus-xml-4.0.2 https://github.com/codehaus-plexus/plexus-xml/commit/c3d99b433a272d8eb1cc7c799410799e8c16ace3";>c3d99b4 Upgrade to 4.0.0-alpha-7 and exclude dependency to sisu (fixes https://redirect.github.com/codehaus-plexus/plexus-xml/issues/17";>#17) (https://redirect.github.com/codehaus-plexus/plexus-xml/issues/23";>#23) https://github.com/codehaus-plexus/plexus-xml/commit/a83cefa086c9a5bb8b6674a409016f378b19891e";>a83cefa Cleanup after parent pom upgrade Addi
[PR] Bump commons-io:commons-io from 2.15.1 to 2.16.1 [maven-artifact-plugin]
dependabot[bot] opened a new pull request, #35: URL: https://github.com/apache/maven-artifact-plugin/pull/35 Bumps commons-io:commons-io from 2.15.1 to 2.16.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-plugins from 41 to 42 [maven-artifact-plugin]
dependabot[bot] opened a new pull request, #36: URL: https://github.com/apache/maven-artifact-plugin/pull/36 Bumps [org.apache.maven.plugins:maven-plugins](https://github.com/apache/maven-parent) from 41 to 42. Release notes Sourced from https://github.com/apache/maven-parent/releases";>org.apache.maven.plugins:maven-plugins's releases. 42 Bug [https://issues.apache.org/jira/browse/MPOM-449";>MPOM-449] - Remove the leading "1." from source/target properties Improvement [https://issues.apache.org/jira/browse/MPOM-447";>MPOM-447] - activate javac's release flag when building with JDK supporting that feature [https://issues.apache.org/jira/browse/MPOM-453";>MPOM-453] - Disable annotation processing by compiler [https://issues.apache.org/jira/browse/MPOM-454";>MPOM-454] - Warning about usage of deprecated API by compiler [https://issues.apache.org/jira/browse/MPOM-477";>MPOM-477] - Skip empty PMD reports [https://issues.apache.org/jira/browse/MPOM-478";>MPOM-478] - Remove manually maintained history from site [https://issues.apache.org/jira/browse/MPOM-483";>MPOM-483] - Make a separate module for documentation Task [https://issues.apache.org/jira/browse/MPOM-482";>MPOM-482] - Publish site descriptor with new parent Dependency upgrade [https://issues.apache.org/jira/browse/MPOM-448";>MPOM-448] - Update spotless-maven-plugin from 2.40.0 to 2.41.1 [https://issues.apache.org/jira/browse/MPOM-455";>MPOM-455] - Add dependencyManagement for JUnit 5 [https://issues.apache.org/jira/browse/MPOM-459";>MPOM-459] - Bump org.apache.maven.plugins:maven-jxr-plugin from 3.3.1 to 3.3.2 [https://issues.apache.org/jira/browse/MPOM-464";>MPOM-464] - Bump com.diffplug.spotless:spotless-maven-plugin from 2.41.1 to 2.43.0 [https://issues.apache.org/jira/browse/MPOM-473";>MPOM-473] - Bump org.cyclonedx:cyclonedx-maven-plugin from 2.7.10 to 2.7.11 [https://issues.apache.org/jira/browse/MPOM-474";>MPOM-474] - Bump org.codehaus.mojo:extra-enforcer-rules from 1.7.0 to 1.8.0 [https://issues.apache.org/jira/browse/MPOM-485";>MPOM-485] - Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 [https://issues.apache.org/jira/browse/MPOM-487";>MPOM-487] - Bump parent to 32 Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2 [maven-artifact-plugin]
dependabot[bot] opened a new pull request, #37: URL: https://github.com/apache/maven-artifact-plugin/pull/37 Bumps [org.apache.maven:maven-archiver](https://github.com/apache/maven-archiver) from 3.6.1 to 3.6.2. Release notes Sourced from https://github.com/apache/maven-archiver/releases";>org.apache.maven:maven-archiver's releases. 3.6.2 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12353577";>Release Notes - Maven Shared Components - Version maven-archiver-3.6.2 What's Changed Bump org.junit:junit-bom from 5.10.0 to 5.10.1 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/43";>apache/maven-archiver#43 Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/50";>apache/maven-archiver#50 Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/47";>apache/maven-archiver#47 Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.1 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/48";>apache/maven-archiver#48 Bump org.apache.maven.shared:maven-shared-components from 40 to 41 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/45";>apache/maven-archiver#45 Bump org.assertj:assertj-core from 3.25.1 to 3.25.2 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/51";>apache/maven-archiver#51 Bump org.junit:junit-bom from 5.10.1 to 5.10.2 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/52";>apache/maven-archiver#52 Bump apache/maven-gh-actions-shared from 3 to 4 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/54";>apache/maven-archiver#54 [MSHARED-1365] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/55";>apache/maven-archiver#55 Bump org.assertj:assertj-core from 3.25.2 to 3.25.3 by https://github.com/dependabot";>@dependabot in https://redirect.github.com/apache/maven-archiver/pull/53";>apache/maven-archiver#53 [MSHARED-1367] Improvement in unit tests by https://github.com/slawekjaranowski";>@slawekjaranowski in https://redirect.github.com/apache/maven-archiver/pull/56";>apache/maven-archiver#56 Full Changelog: https://github.com/apache/maven-archiver/compare/maven-archiver-3.6.1...maven-archiver-3.6.2";>https://github.com/apache/maven-archiver/compare/maven-archiver-3.6.1...maven-archiver-3.6.2 Commits https://github.com/apache/maven-archiver/commit/8a2e44f48348d52e3653e88275f19233a8de80e0";>8a2e44f [maven-release-plugin] prepare release maven-archiver-3.6.2 https://github.com/apache/maven-archiver/commit/f6a41b58c2a639cd22fb5176e3e1a8467481b2fa";>f6a41b5 [MSHARED-1367] Improvement in unit tests https://github.com/apache/maven-archiver/commit/5b99cd726b20a9fba72c9e699f897abbcef5793c";>5b99cd7 Bump org.assertj:assertj-core from 3.25.2 to 3.25.3 https://github.com/apache/maven-archiver/commit/25396f1d5372a2a70dc048da5adb9c020e84596c";>25396f1 [MSHARED-1365] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 (... https://github.com/apache/maven-archiver/commit/822087d4472fba2208653a89cdadf437f87b37aa";>822087d Bump apache/maven-gh-actions-shared from 3 to 4 https://github.com/apache/maven-archiver/commit/7acb1db4a9754beacde3f21a69e5523ee901abd5";>7acb1db Bump org.junit:junit-bom from 5.10.1 to 5.10.2 https://github.com/apache/maven-archiver/commit/84f8d3bca05fa2eb2361dc389c806c8a6bb270c9";>84f8d3b Cleanup junit dependencies https://github.com/apache/maven-archiver/commit/ee7472176e70371652ad64b73a25e63321d16ca6";>ee74721 Bump org.assertj:assertj-core from 3.25.1 to 3.25.2 https://github.com/apache/maven-archiver/commit/f4f49930f6a38b3855a2a5e2cd8e9801de589dba";>f4f4993 Bump org.apache.maven.shared:maven-shared-components from 40 to 41 (https://redirect.github.com/apache/maven-archiver/issues/45";>#45) https://github.com/apache/maven-archiver/commit/e84ecf2810c0cf2fc87bb0837e495eaf5001f008";>e84ecf2 Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.1 (https://redirect.github.com/apache/maven-archiver/issues/48";>#48) Additional commits viewable in https://github.com/apache/maven-archiver/compare/maven-archiver-3.6.1...maven-archiver-3.6.2";>compare view [ Drop deprecated things, replace them with current ones
[ https://issues.apache.org/jira/browse/MARTIFACT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839328#comment-17839328 ] ASF GitHub Bot commented on MARTIFACT-62: - hboutemy commented on PR #31: URL: https://github.com/apache/maven-artifact-plugin/pull/31#issuecomment-2067924167 thank you @cstamas > Drop deprecated things, replace them with current ones > -- > > Key: MARTIFACT-62 > URL: https://issues.apache.org/jira/browse/MARTIFACT-62 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Labels: pull-request-available > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARTIFACT-62) Drop deprecated things, replace them with current ones
[ https://issues.apache.org/jira/browse/MARTIFACT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839327#comment-17839327 ] ASF GitHub Bot commented on MARTIFACT-62: - hboutemy merged PR #31: URL: https://github.com/apache/maven-artifact-plugin/pull/31 > Drop deprecated things, replace them with current ones > -- > > Key: MARTIFACT-62 > URL: https://issues.apache.org/jira/browse/MARTIFACT-62 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Tamas Cservenak >Priority: Major > Labels: pull-request-available > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MARTIFACT-62) Drop deprecated things, replace them with current ones
[ https://issues.apache.org/jira/browse/MARTIFACT-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MARTIFACT-62. -- Assignee: Tamas Cservenak Resolution: Fixed > Drop deprecated things, replace them with current ones > -- > > Key: MARTIFACT-62 > URL: https://issues.apache.org/jira/browse/MARTIFACT-62 > Project: Maven Artifact Plugin > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Labels: pull-request-available > Fix For: 3.5.2 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
