michael-o commented on code in PR #150:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/150#discussion_r1573358753


##########
doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java:
##########
@@ -260,9 +279,9 @@ public void setTemplateName(String templateName) {
      * Add a site directory, expected to have a Doxia Site layout, ie one 
directory per Doxia parser module containing
      * files with parser extension. Typical values are <code>src/site</code> 
or <code>target/generated-site</code>.
      *
-     * @param siteDirectory a {@link java.io.File} object.
+     * @param siteDirectory a {@link SiteDirectory} object.
      */
-    public void addSiteDirectory(File siteDirectory) {
+    public void addSiteDirectory(SiteDirectory siteDirectory) {

Review Comment:
   The general question: What is the affected audience? The only known 
consumer/caller is Maven Site Plugin. You expect this to break in a combination 
you can already forsee?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to