[jira] [Commented] (ARCHETYPE-647) additional new lines in generated pom.xml
[ https://issues.apache.org/jira/browse/ARCHETYPE-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756307#comment-17756307 ] Wouter Born commented on ARCHETYPE-647: --- This seems very similar to: * https://issues.apache.org/jira/browse/ARCHETYPE-584 * https://issues.apache.org/jira/browse/ARCHETYPE-587 > additional new lines in generated pom.xml > - > > Key: ARCHETYPE-647 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-647 > Project: Maven Archetype > Issue Type: Bug >Affects Versions: 3.2.1 >Reporter: Filip Stachowiak >Priority: Minor > > When generating project from this minimal archetype: > [https://github.com/fistach/maven-archetype-issue] > the top-level pom.xml contains additional new lines. > > Tested on Java 8, 11 and 17. > > When the section is removed from the archetype-metadata.xml, > everything is ok. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-doxia-sitetools] hboutemy commented on pull request #110: Doxia Site Model Rework
hboutemy commented on PR #110: URL: https://github.com/apache/maven-doxia-sitetools/pull/110#issuecomment-1684985751 IIUC, the proposal is (in addition to renaming `project` to `site`): 1. introduction of this `` element to match HTML's `` 2. uniform use of this `` element in ``, ``, `` and `` with `name` and `href` as attributes looks very smart: simple and powerful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MASSEMBLY-995) Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0
Slawomir Jaranowski created MASSEMBLY-995: - Summary: Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 Key: MASSEMBLY-995 URL: https://issues.apache.org/jira/browse/MASSEMBLY-995 Project: Maven Assembly Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MASSEMBLY-995) Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MASSEMBLY-995. - Resolution: Fixed > Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 > > > Key: MASSEMBLY-995 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-995 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-996) Bump zstd-jni from 1.5.5-4 to 1.5.5-5
[ https://issues.apache.org/jira/browse/MASSEMBLY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756322#comment-17756322 ] ASF GitHub Bot commented on MASSEMBLY-996: -- slawekjaranowski merged PR #150: URL: https://github.com/apache/maven-assembly-plugin/pull/150 > Bump zstd-jni from 1.5.5-4 to 1.5.5-5 > - > > Key: MASSEMBLY-996 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-996 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MASSEMBLY-996) Bump zstd-jni from 1.5.5-4 to 1.5.5-5
Slawomir Jaranowski created MASSEMBLY-996: - Summary: Bump zstd-jni from 1.5.5-4 to 1.5.5-5 Key: MASSEMBLY-996 URL: https://issues.apache.org/jira/browse/MASSEMBLY-996 Project: Maven Assembly Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MASSEMBLY-996) Bump zstd-jni from 1.5.5-4 to 1.5.5-5
[ https://issues.apache.org/jira/browse/MASSEMBLY-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MASSEMBLY-996. - Resolution: Fixed > Bump zstd-jni from 1.5.5-4 to 1.5.5-5 > - > > Key: MASSEMBLY-996 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-996 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MENFORCER-484) [Question/Bug?] about requireSameVersion
[
https://issues.apache.org/jira/browse/MENFORCER-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MENFORCER-484:
--
Fix Version/s: waiting-for-feedback
> [Question/Bug?] about requireSameVersion
>
>
> Key: MENFORCER-484
> URL: https://issues.apache.org/jira/browse/MENFORCER-484
> Project: Maven Enforcer Plugin
> Issue Type: Bug
> Components: requireSameVersions
>Reporter: Eugenio Lentini
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Hello,
> I am using the {{requireSameVersion}} rule but it does not print, like the
> dependency convergence, where issues are.
> There is just an error but via {{mvn dependency:tree -Dverbose}} I cannot see
> any conflict.
> Questions:
> * How does it suppose to work this rule?
> * Is it possible to print the tree as in dependencyConvergence?
> * What is the difference between requireSameVersion and
> dependencyConvergence?
> Thanks in advance for the answers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wagon] HannesWell commented on pull request #89: [WAGON-632] Java 8
HannesWell commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1685027066 > For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it. Would it be possible to replace the httpcomponent dependencies by the classes from the `java.net.http` packages which was added in Java-11? If yes, would it then be an option to even go to Java-11? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WAGON-632) Java 8 minimum
[ https://issues.apache.org/jira/browse/WAGON-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756325#comment-17756325 ] ASF GitHub Bot commented on WAGON-632: -- HannesWell commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1685027066 > For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it. Would it be possible to replace the httpcomponent dependencies by the classes from the `java.net.http` packages which was added in Java-11? If yes, would it then be an option to even go to Java-11? > Java 8 minimum > -- > > Key: WAGON-632 > URL: https://issues.apache.org/jira/browse/WAGON-632 > Project: Maven Wagon > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: 4.0.0-M1 > > > Mostly so we can get a recent version of commons IO to replace bugs in Plexus > utils -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wagon] michael-o commented on pull request #89: [WAGON-632] Java 8
michael-o commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1685028242 > > For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it. > > Would it be possible to replace the httpcomponent dependencies by the classes from the `java.net.http` packages which was added in Java-11? If yes, would it then be an option to even go to Java-11? This can be a separate module which someone needs to write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (WAGON-632) Java 8 minimum
[ https://issues.apache.org/jira/browse/WAGON-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756326#comment-17756326 ] ASF GitHub Bot commented on WAGON-632: -- michael-o commented on PR #89: URL: https://github.com/apache/maven-wagon/pull/89#issuecomment-1685028242 > > For this to happen master needs to be moved to 4.0.0-M1-SNAPSHOT and then this issue assigned to it. > > Would it be possible to replace the httpcomponent dependencies by the classes from the `java.net.http` packages which was added in Java-11? If yes, would it then be an option to even go to Java-11? This can be a separate module which someone needs to write. > Java 8 minimum > -- > > Key: WAGON-632 > URL: https://issues.apache.org/jira/browse/WAGON-632 > Project: Maven Wagon > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: 4.0.0-M1 > > > Mostly so we can get a recent version of commons IO to replace bugs in Plexus > utils -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MENFORCER-489) Bump commons-lang3 from 3.12.0 to 3.13.0
Slawomir Jaranowski created MENFORCER-489: - Summary: Bump commons-lang3 from 3.12.0 to 3.13.0 Key: MENFORCER-489 URL: https://issues.apache.org/jira/browse/MENFORCER-489 Project: Maven Enforcer Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.4.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #281: [MENFORCER-489] Bump commons-lang3 from 3.12.0 to 3.13.0
slawekjaranowski opened a new pull request, #281: URL: https://github.com/apache/maven-enforcer/pull/281 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-489) Bump commons-lang3 from 3.12.0 to 3.13.0
[ https://issues.apache.org/jira/browse/MENFORCER-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756328#comment-17756328 ] ASF GitHub Bot commented on MENFORCER-489: -- slawekjaranowski opened a new pull request, #281: URL: https://github.com/apache/maven-enforcer/pull/281 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Bump commons-lang3 from 3.12.0 to 3.13.0 > > > Key: MENFORCER-489 > URL: https://issues.apache.org/jira/browse/MENFORCER-489 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MASSEMBLY-997) Bump commons-io from 2.11.0 to 2.13.0
Slawomir Jaranowski created MASSEMBLY-997: - Summary: Bump commons-io from 2.11.0 to 2.13.0 Key: MASSEMBLY-997 URL: https://issues.apache.org/jira/browse/MASSEMBLY-997 Project: Maven Assembly Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-assembly-plugin] slawekjaranowski opened a new pull request, #152: [MASSEMBLY-997] Bump commons-io from 2.11.0 to 2.13.0
slawekjaranowski opened a new pull request, #152: URL: https://github.com/apache/maven-assembly-plugin/pull/152 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MASSEMBLY-997) Bump commons-io from 2.11.0 to 2.13.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756331#comment-17756331 ] ASF GitHub Bot commented on MASSEMBLY-997: -- slawekjaranowski opened a new pull request, #152: URL: https://github.com/apache/maven-assembly-plugin/pull/152 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Bump commons-io from 2.11.0 to 2.13.0 > - > > Key: MASSEMBLY-997 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-997 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #281: [MENFORCER-489] Bump commons-lang3 from 3.12.0 to 3.13.0
slawekjaranowski merged PR #281: URL: https://github.com/apache/maven-enforcer/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-489) Bump commons-lang3 from 3.12.0 to 3.13.0
[ https://issues.apache.org/jira/browse/MENFORCER-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756333#comment-17756333 ] ASF GitHub Bot commented on MENFORCER-489: -- slawekjaranowski merged PR #281: URL: https://github.com/apache/maven-enforcer/pull/281 > Bump commons-lang3 from 3.12.0 to 3.13.0 > > > Key: MENFORCER-489 > URL: https://issues.apache.org/jira/browse/MENFORCER-489 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MENFORCER-489) Bump commons-lang3 from 3.12.0 to 3.13.0
[ https://issues.apache.org/jira/browse/MENFORCER-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-489. - Resolution: Fixed > Bump commons-lang3 from 3.12.0 to 3.13.0 > > > Key: MENFORCER-489 > URL: https://issues.apache.org/jira/browse/MENFORCER-489 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299218991
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -401,6 +399,26 @@ private Future createDownloadTask(
});
if (!cacheConfig.isLazyRestore()) {
Review Comment:
"LazyRestore" seems fine to me. I would instead replace "download" by
"restore" since there is no downloading involved when working with a local
cache. But it's not something I will do in this PR. :P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build
[
https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756335#comment-17756335
]
ASF GitHub Bot commented on MBUILDCACHE-67:
---
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299218991
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -401,6 +399,26 @@ private Future createDownloadTask(
});
if (!cacheConfig.isLazyRestore()) {
Review Comment:
"LazyRestore" seems fine to me. I would instead replace "download" by
"restore" since there is no downloading involved when working with a local
cache. But it's not something I will do in this PR. :P
> Any error in restoring from the cache should resume the non cache build
> ---
>
> Key: MBUILDCACHE-67
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-67
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.1
>Reporter: Kevin Buntrock
>Priority: Major
> Labels: pull-request-available
>
> If any error arise during the restoration of artefacts from the cache, the
> build should continue as it would usually do without the cache. In fact, it's
> even what the extension says "Cannot restore cache, continuing with normal
> build."
> But it's a lie, the build goes straight to the phase where it saves the
> generated artefact in cache. ;)
> {code:java}
> [DEBUG] Hash calculated, item: dependency, hash: 14eab0591a006938
> [INFO] Project inputs calculated in 97 ms. XX checksum [a0d7876d9bceb494]
> calculated in 50 ms.
> [INFO] Attempting to restore project
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from build cache
> [DEBUG] Checking local build info:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO] Local build found by checksum a0d7876d9bceb494
> [INFO] Found cached build, restoring
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from cache by
> checksum a0d7876d9bceb494
> [DEBUG] Cached build details:
> Build{dto=org.apache.maven.buildcache.xml.build.Build@63cf9de0}
> [DEBUG] Cannot restore cache, continuing with normal build.
> java.lang.RuntimeException: Made-up error : restoring artefact is impossible.
> at
> org.apache.maven.buildcache.CacheControllerImpl.restoreProjectArtifacts
> (CacheControllerImpl.java:312)
> at
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
> (BuildCacheMojosExecutionStrategy.java:171)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:124)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> [INFO] Cannot restore project artifacts, continuing with non cached build
> [INFO] Saved Build to local file:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO]
>
> [I
[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299226304
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -401,6 +399,26 @@ private Future createDownloadTask(
});
if (!cacheConfig.isLazyRestore()) {
downloadTask.run();
+try {
+downloadTask.get();
Review Comment:
As I apprehend the "lazy restore" functionality, there are two approach,
each one with their pros and cons.
**Non lazy restore** (the default) : immediate restoration of artefact and
other build outputs.
Build stability is the main concern. If the restoration fails, the build is
executed normally. (I'm interrogative about the part where you say it can fail
the build. For me it's the exact opposite intend). **Con**: we might restore
stuff not used further in another module build.
**Lazy restore** : restoration of artefacts is done only when used. It can
save some bandwidth and speedup the build when used with a remote cache. (Pros
with a local cache are not so clear to me.) **Con**: If the cache is
corrupted/not accessible and an artefact must be used as a dependency in
another module : the build is doomed and will fail.
Actually, the non lazy restore does not really work as expected since the
restore is done (download is immediately launched when using a remote cache),
but we don't check the result straight away. It might be far too late when
we'll discover the artefact did not restored well.
Am I missing something in the picture?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build
[
https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756339#comment-17756339
]
ASF GitHub Bot commented on MBUILDCACHE-67:
---
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299226304
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -401,6 +399,26 @@ private Future createDownloadTask(
});
if (!cacheConfig.isLazyRestore()) {
downloadTask.run();
+try {
+downloadTask.get();
Review Comment:
As I apprehend the "lazy restore" functionality, there are two approach,
each one with their pros and cons.
**Non lazy restore** (the default) : immediate restoration of artefact and
other build outputs.
Build stability is the main concern. If the restoration fails, the build is
executed normally. (I'm interrogative about the part where you say it can fail
the build. For me it's the exact opposite intend). **Con**: we might restore
stuff not used further in another module build.
**Lazy restore** : restoration of artefacts is done only when used. It can
save some bandwidth and speedup the build when used with a remote cache. (Pros
with a local cache are not so clear to me.) **Con**: If the cache is
corrupted/not accessible and an artefact must be used as a dependency in
another module : the build is doomed and will fail.
Actually, the non lazy restore does not really work as expected since the
restore is done (download is immediately launched when using a remote cache),
but we don't check the result straight away. It might be far too late when
we'll discover the artefact did not restored well.
Am I missing something in the picture?
> Any error in restoring from the cache should resume the non cache build
> ---
>
> Key: MBUILDCACHE-67
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-67
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.1
>Reporter: Kevin Buntrock
>Priority: Major
> Labels: pull-request-available
>
> If any error arise during the restoration of artefacts from the cache, the
> build should continue as it would usually do without the cache. In fact, it's
> even what the extension says "Cannot restore cache, continuing with normal
> build."
> But it's a lie, the build goes straight to the phase where it saves the
> generated artefact in cache. ;)
> {code:java}
> [DEBUG] Hash calculated, item: dependency, hash: 14eab0591a006938
> [INFO] Project inputs calculated in 97 ms. XX checksum [a0d7876d9bceb494]
> calculated in 50 ms.
> [INFO] Attempting to restore project
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from build cache
> [DEBUG] Checking local build info:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO] Local build found by checksum a0d7876d9bceb494
> [INFO] Found cached build, restoring
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from cache by
> checksum a0d7876d9bceb494
> [DEBUG] Cached build details:
> Build{dto=org.apache.maven.buildcache.xml.build.Build@63cf9de0}
> [DEBUG] Cannot restore cache, continuing with normal build.
> java.lang.RuntimeException: Made-up error : restoring artefact is impossible.
> at
> org.apache.maven.buildcache.CacheControllerImpl.restoreProjectArtifacts
> (CacheControllerImpl.java:312)
> at
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
> (BuildCacheMojosExecutionStrategy.java:171)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:124)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.Ma
[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299227649
##
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##
@@ -129,7 +129,8 @@ public void execute(
boolean restored = result.isSuccess(); // if partially restored
need to save increment
if (restorable) {
restored &= restoreProject(result, mojoExecutions,
mojoExecutionRunner, cacheConfig);
-} else {
+}
+if (!restored) {
Review Comment:
Good idea @maximilian-novikov-db.
@AlexanderAshitkin : do you mean we should change the way we restore
artefacts from remote caches? I'm more inclined to the "second clean phase"
idea since it covers any restoration problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build
[
https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756340#comment-17756340
]
ASF GitHub Bot commented on MBUILDCACHE-67:
---
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299227649
##
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##
@@ -129,7 +129,8 @@ public void execute(
boolean restored = result.isSuccess(); // if partially restored
need to save increment
if (restorable) {
restored &= restoreProject(result, mojoExecutions,
mojoExecutionRunner, cacheConfig);
-} else {
+}
+if (!restored) {
Review Comment:
Good idea @maximilian-novikov-db.
@AlexanderAshitkin : do you mean we should change the way we restore
artefacts from remote caches? I'm more inclined to the "second clean phase"
idea since it covers any restoration problem.
> Any error in restoring from the cache should resume the non cache build
> ---
>
> Key: MBUILDCACHE-67
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-67
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.1
>Reporter: Kevin Buntrock
>Priority: Major
> Labels: pull-request-available
>
> If any error arise during the restoration of artefacts from the cache, the
> build should continue as it would usually do without the cache. In fact, it's
> even what the extension says "Cannot restore cache, continuing with normal
> build."
> But it's a lie, the build goes straight to the phase where it saves the
> generated artefact in cache. ;)
> {code:java}
> [DEBUG] Hash calculated, item: dependency, hash: 14eab0591a006938
> [INFO] Project inputs calculated in 97 ms. XX checksum [a0d7876d9bceb494]
> calculated in 50 ms.
> [INFO] Attempting to restore project
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from build cache
> [DEBUG] Checking local build info:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO] Local build found by checksum a0d7876d9bceb494
> [INFO] Found cached build, restoring
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from cache by
> checksum a0d7876d9bceb494
> [DEBUG] Cached build details:
> Build{dto=org.apache.maven.buildcache.xml.build.Build@63cf9de0}
> [DEBUG] Cannot restore cache, continuing with normal build.
> java.lang.RuntimeException: Made-up error : restoring artefact is impossible.
> at
> org.apache.maven.buildcache.CacheControllerImpl.restoreProjectArtifacts
> (CacheControllerImpl.java:312)
> at
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
> (BuildCacheMojosExecutionStrategy.java:171)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:124)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> [INFO] Cannot restore project artifacts, continuing with non
[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299226304
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -401,6 +399,26 @@ private Future createDownloadTask(
});
if (!cacheConfig.isLazyRestore()) {
downloadTask.run();
+try {
+downloadTask.get();
Review Comment:
Hello Alexander, nice to meet you. :)
As I apprehend the "lazy restore" functionality, there are two approach,
each one with their pros and cons.
**Non lazy restore** (the default) : immediate restoration of artefact and
other build outputs.
Build stability is the main concern. If the restoration fails, the build is
executed normally. (I'm interrogative about the part where you say it can fail
the build. For me it's the exact opposite intend). **Con**: we might restore
stuff not used further in another module build.
**Lazy restore** : restoration of artefacts is done only when used. It can
save some bandwidth and speedup the build when used with a remote cache. (Pros
with a local cache are not so clear to me.) **Con**: If the cache is
corrupted/not accessible and an artefact must be used as a dependency in
another module : the build is doomed and will fail.
Actually, the non lazy restore does not really work as expected since the
restore is done (download is immediately launched when using a remote cache),
but we don't check the result straight away. It might be far too late when
we'll discover the artefact did not restored well.
Am I missing something in the picture?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build
[
https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756341#comment-17756341
]
ASF GitHub Bot commented on MBUILDCACHE-67:
---
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299226304
##
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##
@@ -401,6 +399,26 @@ private Future createDownloadTask(
});
if (!cacheConfig.isLazyRestore()) {
downloadTask.run();
+try {
+downloadTask.get();
Review Comment:
Hello Alexander, nice to meet you. :)
As I apprehend the "lazy restore" functionality, there are two approach,
each one with their pros and cons.
**Non lazy restore** (the default) : immediate restoration of artefact and
other build outputs.
Build stability is the main concern. If the restoration fails, the build is
executed normally. (I'm interrogative about the part where you say it can fail
the build. For me it's the exact opposite intend). **Con**: we might restore
stuff not used further in another module build.
**Lazy restore** : restoration of artefacts is done only when used. It can
save some bandwidth and speedup the build when used with a remote cache. (Pros
with a local cache are not so clear to me.) **Con**: If the cache is
corrupted/not accessible and an artefact must be used as a dependency in
another module : the build is doomed and will fail.
Actually, the non lazy restore does not really work as expected since the
restore is done (download is immediately launched when using a remote cache),
but we don't check the result straight away. It might be far too late when
we'll discover the artefact did not restored well.
Am I missing something in the picture?
> Any error in restoring from the cache should resume the non cache build
> ---
>
> Key: MBUILDCACHE-67
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-67
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.1
>Reporter: Kevin Buntrock
>Priority: Major
> Labels: pull-request-available
>
> If any error arise during the restoration of artefacts from the cache, the
> build should continue as it would usually do without the cache. In fact, it's
> even what the extension says "Cannot restore cache, continuing with normal
> build."
> But it's a lie, the build goes straight to the phase where it saves the
> generated artefact in cache. ;)
> {code:java}
> [DEBUG] Hash calculated, item: dependency, hash: 14eab0591a006938
> [INFO] Project inputs calculated in 97 ms. XX checksum [a0d7876d9bceb494]
> calculated in 50 ms.
> [INFO] Attempting to restore project
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from build cache
> [DEBUG] Checking local build info:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO] Local build found by checksum a0d7876d9bceb494
> [INFO] Found cached build, restoring
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from cache by
> checksum a0d7876d9bceb494
> [DEBUG] Cached build details:
> Build{dto=org.apache.maven.buildcache.xml.build.Build@63cf9de0}
> [DEBUG] Cannot restore cache, continuing with normal build.
> java.lang.RuntimeException: Made-up error : restoring artefact is impossible.
> at
> org.apache.maven.buildcache.CacheControllerImpl.restoreProjectArtifacts
> (CacheControllerImpl.java:312)
> at
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
> (BuildCacheMojosExecutionStrategy.java:171)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:124)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenC
[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #92: [MBUILDCACHE-67] Bugfix artefact restoration error not handled properly
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299227649
##
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##
@@ -129,7 +129,8 @@ public void execute(
boolean restored = result.isSuccess(); // if partially restored
need to save increment
if (restorable) {
restored &= restoreProject(result, mojoExecutions,
mojoExecutionRunner, cacheConfig);
-} else {
+}
+if (!restored) {
Review Comment:
Good idea @maximilian-novikov-db.
@AlexanderAshitkin : do you mean we should change the way we restore
artefacts from remote caches? I'm more inclined to the "second clean phase"
idea since it covers any restoration problem (in case "clean" was asked in the
build). For further changes, I guess it could be done in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-67) Any error in restoring from the cache should resume the non cache build
[
https://issues.apache.org/jira/browse/MBUILDCACHE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756342#comment-17756342
]
ASF GitHub Bot commented on MBUILDCACHE-67:
---
kbuntrock commented on code in PR #92:
URL:
https://github.com/apache/maven-build-cache-extension/pull/92#discussion_r1299227649
##
src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java:
##
@@ -129,7 +129,8 @@ public void execute(
boolean restored = result.isSuccess(); // if partially restored
need to save increment
if (restorable) {
restored &= restoreProject(result, mojoExecutions,
mojoExecutionRunner, cacheConfig);
-} else {
+}
+if (!restored) {
Review Comment:
Good idea @maximilian-novikov-db.
@AlexanderAshitkin : do you mean we should change the way we restore
artefacts from remote caches? I'm more inclined to the "second clean phase"
idea since it covers any restoration problem (in case "clean" was asked in the
build). For further changes, I guess it could be done in another PR.
> Any error in restoring from the cache should resume the non cache build
> ---
>
> Key: MBUILDCACHE-67
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-67
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Affects Versions: 1.0.1
>Reporter: Kevin Buntrock
>Priority: Major
> Labels: pull-request-available
>
> If any error arise during the restoration of artefacts from the cache, the
> build should continue as it would usually do without the cache. In fact, it's
> even what the extension says "Cannot restore cache, continuing with normal
> build."
> But it's a lie, the build goes straight to the phase where it saves the
> generated artefact in cache. ;)
> {code:java}
> [DEBUG] Hash calculated, item: dependency, hash: 14eab0591a006938
> [INFO] Project inputs calculated in 97 ms. XX checksum [a0d7876d9bceb494]
> calculated in 50 ms.
> [INFO] Attempting to restore project
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from build cache
> [DEBUG] Checking local build info:
> C:\Users\kbuntrock\.m2\build-cache\v1\io.github.kbuntrock.sample\openapi-plugin-sample-backend\a0d7876d9bceb494\local\buildinfo.xml
> [INFO] Local build found by checksum a0d7876d9bceb494
> [INFO] Found cached build, restoring
> io.github.kbuntrock.sample:openapi-plugin-sample-backend from cache by
> checksum a0d7876d9bceb494
> [DEBUG] Cached build details:
> Build{dto=org.apache.maven.buildcache.xml.build.Build@63cf9de0}
> [DEBUG] Cannot restore cache, continuing with normal build.
> java.lang.RuntimeException: Made-up error : restoring artefact is impossible.
> at
> org.apache.maven.buildcache.CacheControllerImpl.restoreProjectArtifacts
> (CacheControllerImpl.java:312)
> at
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.restoreProject
> (BuildCacheMojosExecutionStrategy.java:171)
> at org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute
> (BuildCacheMojosExecutionStrategy.java:124)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launc
[jira] [Commented] (MRESOLVER-383) java.net.SocketException: Connection reset
[
https://issues.apache.org/jira/browse/MRESOLVER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756344#comment-17756344
]
Tamas Cservenak commented on MRESOLVER-383:
---
Is this issue fixed by latest resolver release? Or is there something more to
be done?
> java.net.SocketException: Connection reset
> --
>
> Key: MRESOLVER-383
> URL: https://issues.apache.org/jira/browse/MRESOLVER-383
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.9.13
>Reporter: Konrad Windszus
>Priority: Major
>
> Although in MRESOLVER-361 the retry handler by default is now using
> https://www.javadoc.io/doc/org.apache.httpcomponents/httpclient/latest/org/apache/http/impl/client/StandardHttpRequestRetryHandler.html
> that one still does not sufficiently deal with Connection resets.
> A regular connection reset leads to an exception like the following (without
> any noticable retry attempts)
> {code}
> [ERROR] Failed to execute goal on project vault-davex: Could not resolve
> dependencies for project
> org.apache.jackrabbit.vault:vault-davex:jar:3.6.9-SNAPSHOT: Failed to collect
> dependencies at org.apache.jackrabbit:jackrabbit-jcr-client:jar:2.20.10:
> Failed to read artifact descriptor for
> org.apache.jackrabbit:jackrabbit-jcr-client:jar:2.20.10: The following
> artifacts could not be resolved:
> org.apache.jackrabbit:jackrabbit-jcr-client:pom:2.20.10 (absent): Could not
> transfer artifact org.apache.jackrabbit:jackrabbit-jcr-client:pom:2.20.10
> from/to central (https://repo.maven.apache.org/maven2): Connection reset ->
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal on project vault-davex: Could not resolve dependencies for project
> org.apache.jackrabbit.vault:vault-davex:jar:3.6.9-SNAPSHOT: Failed to collect
> dependencies at org.apache.jackrabbit:jackrabbit-jcr-client:jar:2.20.10
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies
> (LifecycleDependencyResolver.java:243)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies
> (LifecycleDependencyResolver.java:136)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
> (MojoExecutor.java:355)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:313)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> Caused by: org.apache.maven.project.DependencyResolutionException: Could not
> resolve dependencies for project
> org.apache.jackrabbit.vault:vault-davex:jar:3.6.9-SNAPSHOT: Failed to c
[jira] [Commented] (MNG-6829) Remove commons-lang3 dependency
[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756345#comment-17756345
]
ASF GitHub Bot commented on MNG-6829:
-
timtebeek opened a new pull request, #183:
URL: https://github.com/apache/maven-scm/pull/183
Additional replacements as compared to
https://github.com/apache/maven-scm/pull/169, now also replacing where the
input was trimmed.
@elharo would you mind having look at this one and a few to follow? I want
to start this up again. :)
> Remove commons-lang3 dependency
> ---
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia-book-renderer] timtebeek opened a new pull request, #3: [MNG-6829] Replace StringUtils#isEmpty(String) and #isNotEmpty
timtebeek opened a new pull request, #3: URL: https://github.com/apache/maven-doxia-book-renderer/pull/3 One of the last ones with this iteration of the automated recipe to make these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6829) Remove commons-lang3 dependency
[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756346#comment-17756346
]
ASF GitHub Bot commented on MNG-6829:
-
timtebeek opened a new pull request, #3:
URL: https://github.com/apache/maven-doxia-book-renderer/pull/3
One of the last ones with this iteration of the automated recipe to make
these changes.
> Remove commons-lang3 dependency
> ---
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-scm] timtebeek opened a new pull request, #184: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #184: URL: https://github.com/apache/maven-scm/pull/184 Hi! Found [MNG-6847](https://issues.apache.org/jira/browse/MNG-6847) on the backlog (closed), but that had only been applied to https://github.com/apache/maven/pull/315 itself, not the additional 36 projects that could still use those changes. Figured open this one as a first one to ask if you'd appreciate any more. These PRs are trivial for me to create, but I would not want to cause any review burden. That's why I'm only starting with one, and not creating more unless I get a positive response here. Here's a full list of projects that could still use these changes. ``` 38 apache/maven-scm 20 apache/maven-wagon 19 "apache/maven-shared-utils" 12 "apache/maven-resolver-ant-tasks" 11 "apache/maven-integration-testing" 11 "apache/maven-doxia-sitetools" 11 "apache/maven-apache-resources" 9 apache/maven-shared-io 9 apache/maven-resolver 9 apache/maven-ear-plugin 7 "apache/maven-changelog-plugin" 7 "apache/maven-assembly-plugin" 7 apache/maven 6 apache/maven-ant-tasks 5 apache/maven-site-plugin 5 "apache/maven-dependency-plugin" 4 "apache/maven-plugin-tools" 4 apache/maven-ejb-plugin 4 "apache/maven-doxia-linkcheck" 4 "apache/maven-doxia-book-renderer" 3 "apache/maven-shade-plugin" 3 apache/maven-mvnd 2 "apache/maven-project-info-reports-plugin" 2 "apache/maven-install-plugin" 2 apache/maven-dist-tool 1 "apache/maven-stage-plugin" 1 "apache/maven-remote-resources-plugin" 1 "apache/maven-project-utils" 1 apache/maven-pmd-plugin 1 apache/maven-jmod-plugin 1 "apache/maven-jdeps-plugin" 1 apache/maven-indexer 1 apache/maven-doxia 1 apache/maven-doap-plugin 1 "apache/maven-artifact-transfer" 1 apache/maven-archetype ``` @elharo would this be something you're willing to review as well? Welcome to direct me to others too. For my future self and others; Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756353#comment-17756353 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #184: URL: https://github.com/apache/maven-scm/pull/184 Hi! Found [MNG-6847](https://issues.apache.org/jira/browse/MNG-6847) on the backlog (closed), but that had only been applied to https://github.com/apache/maven/pull/315 itself, not the additional 36 projects that could still use those changes. Figured open this one as a first one to ask if you'd appreciate any more. These PRs are trivial for me to create, but I would not want to cause any review burden. That's why I'm only starting with one, and not creating more unless I get a positive response here. Here's a full list of projects that could still use these changes. ``` 38 apache/maven-scm 20 apache/maven-wagon 19 "apache/maven-shared-utils" 12 "apache/maven-resolver-ant-tasks" 11 "apache/maven-integration-testing" 11 "apache/maven-doxia-sitetools" 11 "apache/maven-apache-resources" 9 apache/maven-shared-io 9 apache/maven-resolver 9 apache/maven-ear-plugin 7 "apache/maven-changelog-plugin" 7 "apache/maven-assembly-plugin" 7 apache/maven 6 apache/maven-ant-tasks 5 apache/maven-site-plugin 5 "apache/maven-dependency-plugin" 4 "apache/maven-plugin-tools" 4 apache/maven-ejb-plugin 4 "apache/maven-doxia-linkcheck" 4 "apache/maven-doxia-book-renderer" 3 "apache/maven-shade-plugin" 3 apache/maven-mvnd 2 "apache/maven-project-info-reports-plugin" 2 "apache/maven-install-plugin" 2 apache/maven-dist-tool 1 "apache/maven-stage-plugin" 1 "apache/maven-remote-resources-plugin" 1 "apache/maven-project-utils" 1 apache/maven-pmd-plugin 1 apache/maven-jmod-plugin 1 "apache/maven-jdeps-plugin" 1 apache/maven-indexer 1 apache/maven-doxia 1 apache/maven-doap-plugin 1 "apache/maven-artifact-transfer" 1 apache/maven-archetype ``` @elharo would this be something you're willing to review as well? Welcome to direct me to others too. For my future self and others; Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756364#comment-17756364 ] ASF GitHub Bot commented on MNG-6847: - timtebeek commented on PR #184: URL: https://github.com/apache/maven-scm/pull/184#issuecomment-1685109662 Thanks for the quick review @slachiewicz ; Would you be ok with me opening let's say six more starting from the top? > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-scm] slachiewicz commented on pull request #184: [MNG-6847] Use diamond operator
slachiewicz commented on PR #184: URL: https://github.com/apache/maven-scm/pull/184#issuecomment-1685110667 Yes, sure. Thx fro help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756366#comment-17756366 ] ASF GitHub Bot commented on MNG-6847: - slachiewicz merged PR #184: URL: https://github.com/apache/maven-scm/pull/184 > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756365#comment-17756365 ] ASF GitHub Bot commented on MNG-6847: - slachiewicz commented on PR #184: URL: https://github.com/apache/maven-scm/pull/184#issuecomment-1685110667 Yes, sure. Thx fro help > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-resolver-ant-tasks] timtebeek opened a new pull request, #27: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #27: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/27 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] timtebeek opened a new pull request, #166: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #166: URL: https://github.com/apache/maven-shared-utils/pull/166 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-resources] timtebeek opened a new pull request, #11: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #11: URL: https://github.com/apache/maven-apache-resources/pull/11 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] timtebeek opened a new pull request, #288: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #288: URL: https://github.com/apache/maven-integration-testing/pull/288 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756367#comment-17756367 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #166: URL: https://github.com/apache/maven-shared-utils/pull/166 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-wagon] timtebeek opened a new pull request, #92: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #92: URL: https://github.com/apache/maven-wagon/pull/92 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-sitetools] timtebeek opened a new pull request, #115: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #115: URL: https://github.com/apache/maven-doxia-sitetools/pull/115 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756369#comment-17756369 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #115: URL: https://github.com/apache/maven-doxia-sitetools/pull/115 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756368#comment-17756368 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #92: URL: https://github.com/apache/maven-wagon/pull/92 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCOMPILER-543) Allow to exclude particular dependency from annotation processor classpath
Alexey Markevich created MCOMPILER-543:
--
Summary: Allow to exclude particular dependency from annotation
processor classpath
Key: MCOMPILER-543
URL: https://issues.apache.org/jira/browse/MCOMPILER-543
Project: Maven Compiler Plugin
Issue Type: Improvement
Reporter: Alexey Markevich
like
[Surefire|https://maven.apache.org/surefire/maven-surefire-plugin/examples/configuring-classpath.html#removing-dependency-classpath-elements]
but for annotationProcessorPaths element. Case is:
- parent module:
{code}
org.apache.maven.plugins
maven-compiler-plugin
grpoup1
artifact1
version1
...
org.apache.maven.plugins
maven-compiler-plugin
group2
artifact2
version2
{code}
- child module:
{code}
org.apache.maven.plugins
maven-compiler-plugin
default-compile
compile
compile
{code}
disable all processors. Goal is exclude only base one to have something like
{code}
org.apache.maven.plugins
maven-compiler-plugin
default-compile
compile
compile
group1:artifact1:version1
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-surefire] timtebeek opened a new pull request, #669: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #669: URL: https://github.com/apache/maven-surefire/pull/669 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756371#comment-17756371 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #669: URL: https://github.com/apache/maven-surefire/pull/669 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-scm] timtebeek commented on pull request #184: [MNG-6847] Use diamond operator
timtebeek commented on PR #184: URL: https://github.com/apache/maven-scm/pull/184#issuecomment-1685114326 Happy to help! I've opened a few more, all linked above, some of which need approval for the pipelines to run. If it's alright with you I'll keep something in the range of five to ten open at a time, such that we get further along. Open to other systems as well; there's a long tail of 1 or 2 cases per repository that might not make sense by itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756372#comment-17756372 ] ASF GitHub Bot commented on MNG-6847: - timtebeek commented on PR #184: URL: https://github.com/apache/maven-scm/pull/184#issuecomment-1685114326 Happy to help! I've opened a few more, all linked above, some of which need approval for the pipelines to run. If it's alright with you I'll keep something in the range of five to ten open at a time, such that we get further along. Open to other systems as well; there's a long tail of 1 or 2 cases per repository that might not make sense by itself. > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-resolver-ant-tasks] slachiewicz merged pull request #27: [MNG-6847] Use diamond operator
slachiewicz merged PR #27: URL: https://github.com/apache/maven-resolver-ant-tasks/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-resources] slachiewicz merged pull request #11: [MNG-6847] Use diamond operator
slachiewicz merged PR #11: URL: https://github.com/apache/maven-apache-resources/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756374#comment-17756374 ] ASF GitHub Bot commented on MNG-6847: - slachiewicz merged PR #92: URL: https://github.com/apache/maven-wagon/pull/92 > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-shared-io] timtebeek opened a new pull request, #23: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #23: URL: https://github.com/apache/maven-shared-io/pull/23 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] timtebeek opened a new pull request, #153: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #153: URL: https://github.com/apache/maven-assembly-plugin/pull/153 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756375#comment-17756375 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #23: URL: https://github.com/apache/maven-shared-io/pull/23 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756376#comment-17756376 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #153: URL: https://github.com/apache/maven-assembly-plugin/pull/153 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-changelog-plugin] timtebeek opened a new pull request, #5: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #5: URL: https://github.com/apache/maven-changelog-plugin/pull/5 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] timtebeek opened a new pull request, #96: [MNG-6847] Use diamond operator
timtebeek opened a new pull request, #96: URL: https://github.com/apache/maven-ear-plugin/pull/96 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756378#comment-17756378 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #96: URL: https://github.com/apache/maven-ear-plugin/pull/96 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756377#comment-17756377 ] ASF GitHub Bot commented on MNG-6847: - timtebeek opened a new pull request, #5: URL: https://github.com/apache/maven-changelog-plugin/pull/5 As discussed on - https://github.com/apache/maven-scm/pull/184 - https://issues.apache.org/jira/browse/MNG-6847 Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-396) Native resolver should retry on http 429
[ https://issues.apache.org/jira/browse/MRESOLVER-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756379#comment-17756379 ] ASF GitHub Bot commented on MRESOLVER-396: -- cstamas opened a new pull request, #326: URL: https://github.com/apache/maven-resolver/pull/326 Provide a way to "back off", and lower the request pace if remote claims "too many requests" --- https://issues.apache.org/jira/projects/MRESOLVER/issues/MRESOLVER-396 > Native resolver should retry on http 429 > > > Key: MRESOLVER-396 > URL: https://issues.apache.org/jira/browse/MRESOLVER-396 > Project: Maven Resolver > Issue Type: Improvement >Reporter: Chris Eldredge >Priority: Minor > Fix For: 1.9.16 > > > The Wagon http transport provider has custom logic to retry with exponential > backoff when putting an artifact to an http endpoint and getting a 429 Too > Many Requests response code from the server: > [https://github.com/apache/maven-wagon/blob/wagon-3.5.3/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java#L828] > The newer "native" http transporter should provide similar retry logic. One > place this could go would be into > [HttpTransporter.implPut|[https://github.com/apache/maven-resolver/blob/master/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java#L427].|https://github.com/apache/maven-resolver/blob/master/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java#L427).] > Ideally the transport could be configured to retry on specific error codes, > perhaps with 429 and 503 being defaults. > The lack of retry support on 429s is exacerbate in Maven 3.9 because it > enables parallel put by default, which increases requests per second making > it more likely that a client would encounter rate limiting or other > throttling and overload scenarios. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SUREFIRE-2191) surefire crashes on a JPMS modularized project that uses junit5
Henning Schmiedehausen created SUREFIRE-2191:
Summary: surefire crashes on a JPMS modularized project that uses
junit5
Key: SUREFIRE-2191
URL: https://issues.apache.org/jira/browse/SUREFIRE-2191
Project: Maven Surefire
Issue Type: Bug
Components: JUnit 5.x support, process forking
Affects Versions: 3.1.2
Reporter: Henning Schmiedehausen
clone this repository: [https://github.com/hgschmie/surefire-2191
|https://github.com/hgschmie/surefire-2191] and build it.
The build fails during testing with a large and cryptic error description. The
code only uses the junit jupiter APIs and imports the with {{ requires
transitive org.junit.jupiter.api;}}
This is the surefireargs file that the plugin creates:
{code}
--module-path
"/Users/henning/scratch/surefire-junit-bug/target/classes:/Users/henning/.m2/repository/org/junit/jupiter/junit-jupiter-api/5.10.0/junit-jupiter-api-5.10.0.jar:/Users/henning/.m2/repository/org/opentest4j/opentest4j/1.3.0/opentest4j-1.3.0.jar:/Users/henning/.m2/repository/org/junit/platform/junit-platform-commons/1.10.0/junit-platform-commons-1.10.0.jar:/Users/henning/.m2/repository/org/apiguardian/apiguardian-api/1.1.2/apiguardian-api-1.1.2.jar"
--class-path
"/Users/henning/.m2/repository/org/apache/maven/surefire/surefire-api/3.1.2/surefire-api-3.1.2.jar:/Users/henning/.m2/repository/org/apache/maven/surefire/surefire-booter/3.1.2/surefire-booter-3.1.2.jar:/Users/henning/.m2/repository/org/apache/maven/surefire/surefire-extensions-spi/3.1.2/surefire-extensions-spi-3.1.2.jar:/Users/henning/.m2/repository/org/apache/maven/surefire/surefire-logger-api/3.1.2/surefire-logger-api-3.1.2.jar:/Users/henning/.m2/repository/org/apache/maven/surefire/surefire-shared-utils/3.1.2/surefire-shared-utils-3.1.2.jar:/Users/henning/scratch/surefire-junit-bug/target/test-classes:/Users/henning/.m2/repository/org/assertj/assertj-core/3.24.2/assertj-core-3.24.2.jar:/Users/henning/.m2/repository/net/bytebuddy/byte-buddy/1.12.21/byte-buddy-1.12.21.jar:/Users/henning/.m2/repository/org/apache/maven/surefire/surefire-junit-platform/3.1.2/surefire-junit-platform-3.1.2.jar:/Users/henning/.m2/repository/org/apache/maven/surefire/common-java5/3.1.2/common-java5-3.1.2.jar:/Users/henning/.m2/repository/org/junit/platform/junit-platform-launcher/1.10.0/junit-platform-launcher-1.10.0.jar:/Users/henning/.m2/repository/org/junit/platform/junit-platform-engine/1.10.0/junit-platform-engine-1.10.0.jar:/Users/henning/.m2/repository/org/junit/jupiter/junit-jupiter-engine/5.10.0/junit-jupiter-engine-5.10.0.jar"
--patch-module
surefire.junit.bug="/Users/henning/scratch/surefire-junit-bug/target/test-classes"
--add-opens
surefire.junit.bug/demo=ALL-UNNAMED
--add-modules
surefire.junit.bug
--add-reads
surefire.junit.bug=ALL-UNNAMED
org.apache.maven.surefire.booter.ForkedBooter
{code}
It is not clear to me on how to fix/mitigate this error. The same build works
fine without JPMS modules or with automatic versioned modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7648) Generated model reader is not setting location information
[
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756421#comment-17756421
]
ASF GitHub Bot commented on MNG-7648:
-
hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137331
Reporting again here, alpha 7 has same issue. Only Alpha 4 of maven works
as expected. Any maven version before 4-alpha-5 and all 3.x as far as I can
remember - like 10 years ago, do not require the version to be additional
restated inside a profile. Its always properly inherited it as far as I'm
aware. As @pavelhoral noted possible plugin definitions are not merged. I
presume they always were before, can anyone confirm? Trying to understand why
now after decade of doing profiles like this, its only an issue now.
> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property -
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
> .-
> Project model does not have location property in plugin execution (potential
> issue when merging model parent configuration?). This causes issues for
> example in Maven Enforcer Plugin which uses this information (see
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hazendaz commented on pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.
hazendaz commented on PR #940: URL: https://github.com/apache/maven/pull/940#issuecomment-1685137746 ``` [INFO] Error: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-clean) on project spotbugs-maven-plugin: Error: Rule 6: org.apache.maven.enforcer.rules.RequirePluginVersions failed with message: Error: Some plugins are missing valid versions or depend on Maven 4.0.0-alpha-5 defaults (LATEST, RELEASE, SNAPSHOT, TIMESTAMP SNAPSHOT as plugin version are not allowed) Error: org.apache.maven.plugins:maven-compiler-plugin. The version currently in use is 3.11.0 via super POM or default lifecycle bindings Error: ] Best Practice is to always define plugin versions! Error: -> [Help 1] Error: Error: To see the full stack trace of the errors, re-run Maven with the '-e' switch Error: Re-run Maven using the '-X' switch to enable verbose output Error: Error: For more information about the errors and possible solutions, please read the following articles: Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException Error: Process completed with exit code 1. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7648) Generated model reader is not setting location information
[
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756423#comment-17756423
]
ASF GitHub Bot commented on MNG-7648:
-
hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137746
```
[INFO]
Error: Failed to execute goal
org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-clean) on
project spotbugs-maven-plugin:
Error: Rule 6: org.apache.maven.enforcer.rules.RequirePluginVersions failed
with message:
Error: Some plugins are missing valid versions or depend on Maven
4.0.0-alpha-5 defaults (LATEST, RELEASE, SNAPSHOT, TIMESTAMP SNAPSHOT as plugin
version are not allowed)
Error: org.apache.maven.plugins:maven-compiler-plugin. The version
currently in use is 3.11.0 via super POM or default lifecycle bindings
Error: ] Best Practice is to always define plugin versions!
Error: -> [Help 1]
Error:
Error: To see the full stack trace of the errors, re-run Maven with the
'-e' switch
Error: Re-run Maven using the '-X' switch to enable verbose output
Error:
Error: For more information about the errors and possible solutions, please
read the following articles:
Error: [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error: Process completed with exit code 1.
```
> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property -
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
> .-
> Project model does not have location property in plugin execution (potential
> issue when merging model parent configuration?). This causes issues for
> example in Maven Enforcer Plugin which uses this information (see
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7648) Generated model reader is not setting location information
[
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756422#comment-17756422
]
ASF GitHub Bot commented on MNG-7648:
-
hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137650
You can see the issue additionally here
https://github.com/spotbugs/spotbugs-maven-plugin/pull/626. Its using same
base parent and maven 3.3.9 and 3.9.4 are working fine. If I use 4 alpha 4 its
fine. Only a problem on 4 afterwards.
> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property -
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
> .-
> Project model does not have location property in plugin execution (potential
> issue when merging model parent configuration?). This causes issues for
> example in Maven Enforcer Plugin which uses this information (see
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] hazendaz commented on pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.
hazendaz commented on PR #940: URL: https://github.com/apache/maven/pull/940#issuecomment-1685137955 And yes my super pom - not maven's defines it in dependency management at 3.11.0. So clearly something is wrong here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7648) Generated model reader is not setting location information
[
https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756424#comment-17756424
]
ASF GitHub Bot commented on MNG-7648:
-
hazendaz commented on PR #940:
URL: https://github.com/apache/maven/pull/940#issuecomment-1685137955
And yes my super pom - not maven's defines it in dependency management at
3.11.0. So clearly something is wrong here.
> Generated model reader is not setting location information
> --
>
> Key: MNG-7648
> URL: https://issues.apache.org/jira/browse/MNG-7648
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.7, 4.0.0-alpha-3
>Reporter: Pavel Horal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.8.8, 3.9.0, 4.0.0-alpha-4, 4.0.0
>
>
> -Generated model reader is not setting {{location}} property -
> [https://github.com/apache/maven/blob/e73a0b00fde80c400a6d854ec0c2ba7436325eed/maven-toolchain-model/src/main/mdo/reader.vm#L683]
> .-
> Project model does not have location property in plugin execution (potential
> issue when merging model parent configuration?). This causes issues for
> example in Maven Enforcer Plugin which uses this information (see
> [MENFORCER-447|https://issues.apache.org/jira/browse/MENFORCER-447?focusedCommentId=17651671&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17651671]).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756433#comment-17756433 ] ASF GitHub Bot commented on MNG-6847: - olamy commented on PR #96: URL: https://github.com/apache/maven-ear-plugin/pull/96#issuecomment-1685160727 this should be MEAR-xxx not MNG as it's plugin change not a core change > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6829) Remove commons-lang3 dependency
[
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756435#comment-17756435
]
ASF GitHub Bot commented on MNG-6829:
-
olamy commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685160977
shouldn't we have a corresponding SCM- issue rather than MNG- as it's not a
core change?
> Remove commons-lang3 dependency
> ---
>
> Key: MNG-6829
> URL: https://issues.apache.org/jira/browse/MNG-6829
> Project: Maven
> Issue Type: Sub-task
> Components: Bootstrap & Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Labels: close-pending
> Fix For: 4.0.x-candidate
>
> Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can
> be implemented very easily (done already to see how it works). Later this
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName, "/" )}} is
> used in {{ConsoleMavenTransferListener}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756436#comment-17756436 ] ASF GitHub Bot commented on MNG-6847: - olamy commented on PR #92: URL: https://github.com/apache/maven-wagon/pull/92#issuecomment-1685161494 need a WAGON issue not MNG > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6847) Explicit type can be replaced by the diamond operator
[ https://issues.apache.org/jira/browse/MNG-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17756449#comment-17756449 ] ASF GitHub Bot commented on MNG-6847: - michael-o commented on PR #92: URL: https://github.com/apache/maven-wagon/pull/92#issuecomment-1685202147 Diamonds are a girl's best friend. > Explicit type can be replaced by the diamond operator > - > > Key: MNG-6847 > URL: https://issues.apache.org/jira/browse/MNG-6847 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Krosheninnikov Artem >Assignee: Michael Osipov >Priority: Trivial > Fix For: 4.0.0-alpha-2, 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > As the title says. It's a small change to reduce unneeded verbosity in the > code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
