[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755389#comment-17755389 ] Michael Osipov commented on MSOURCES-143: - [~ggregory], does it work with 3.8.8? > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-391) Scope mediation improvements
[ https://issues.apache.org/jira/browse/MRESOLVER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755407#comment-17755407 ] perdjesk commented on MRESOLVER-391: In case the dependency mediation of the resolver could not "make a decision" it should either warn or fail on such cases so that users have a chance of catching those before they lead to ClassNotFoundException at runtime. Especially because in the context of test it will not trigger exceptions and thus be silent until it reaches a runtime environment. > Scope mediation improvements > > > Key: MRESOLVER-391 > URL: https://issues.apache.org/jira/browse/MRESOLVER-391 > Project: Maven Resolver > Issue Type: Bug > Components: Resolver >Reporter: Tamas Cservenak >Priority: Major > Fix For: 2.0.0 > > > As per MNG-5988: if an artifact in "test" scope is found nearer, but in scope > "compile" is found deeper in graph, the "test" scope wins. This at runtime > may lead to CNFEx. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[
https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755413#comment-17755413
]
Slawomir Jaranowski commented on MSOURCES-143:
--
For JDK 8 you use {{spdx-maven-plugin}} in version {{0.6.3}} - and execution is
forked again by plugin ... https://github.com/spdx/spdx-maven-plugin/pull/79
> Can't create a source and test jar in Commons using commons-parent
> --
>
> Key: MSOURCES-143
> URL: https://issues.apache.org/jira/browse/MSOURCES-143
> Project: Maven Source Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Gary D. Gregory
>Priority: Major
>
> Steps to reproduce:
> # git clone https://gitbox.apache.org/repos/asf/commons-parent.git
> # cd commons-parent
> # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473
> # mvn clean install
> # cd ..
> # git clone https://gitbox.apache.org/repos/asf/commons-cli.git
> # cd commons-cli
> # git checkout 08f8c5034a8492be6db65b2086341c292489ee53
> # mvn clean package
> [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli ---
> [ERROR] We have duplicated artifacts attached.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 15.233 s
> [INFO] Finished at: 2023-08-15T15:39:45-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork
> (create-source-jar) on project commons-cli: Presumably you have configured
> maven-source-plugn to execute twice times in your build. You have to
> configure a classifier for at least on of them. -> [Help 1]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements
[
https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755419#comment-17755419
]
ASF GitHub Bot commented on MJAVADOC-767:
-
slawekjaranowski commented on code in PR #225:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -4594,12 +4594,14 @@ private void addJavadocOptions(
}
for (Entry> entry : patchModules.entrySet()) {
-addArgIfNotEmpty(
-arguments,
-"--patch-module",
-entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
-false,
-false);
+if (!entry.getValue().isEmpty()) {
+addArgIfNotEmpty(
+arguments,
+"--patch-module",
+entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
+false,
+false);
+}
Review Comment:
Is it possible to add a test (unit or IT) for verifying this change.
> javadoc creates invalid --patch-module statements
> -
>
> Key: MJAVADOC-767
> URL: https://issues.apache.org/jira/browse/MJAVADOC-767
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.5.0
>Reporter: Henning Schmiedehausen
>Priority: Major
>
> Jdbi is a mixed Java/Kotlin multi-module project. We aggregate a final jar
> that contains all the javadocs for all modules in a doc step. This works ok
> for non-JPMS (Java 8 target).
> When introducing JPMS into our project, the javadoc plugin starts adding
> --patch-module options like this:
> {{--patch-module
> org.jdbi.v3.caffeine='/Users/henning/code/jdbi/cache/caffeine-cache/src/main/java:/Users/henning/code/jdbi/cache/caffeine-cache/target/generated-sources/annotations'}}
> However, in our configuration, we exclude the kotlin specific modules:
> {code:xml}
>
> maven-javadoc-plugin
>
>
> javadoc-jar
>
> jar
>
> package
>
> true
> false
>
>
> org.jdbi:*
>
>
>
> org.jdbi:jdbi3-kotlin
>
> org.jdbi:jdbi3-kotlin-sqlobject
>
>
> jdbi3-kotlin,jdbi3-kotlin-sqlobject
> Jdbi3 ${project.version} API
> Jdbi3 ${project.version} API
>
>
>
>
> {code}
> which results in the maven-javadoc-plugin creating command line options like
> this:
> {{--patch-module org.jdbi.v3.kotlin=}}
> which in turn crash the javadoc command.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
slawekjaranowski commented on code in PR #225:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -4594,12 +4594,14 @@ private void addJavadocOptions(
}
for (Entry> entry : patchModules.entrySet()) {
-addArgIfNotEmpty(
-arguments,
-"--patch-module",
-entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
-false,
-false);
+if (!entry.getValue().isEmpty()) {
+addArgIfNotEmpty(
+arguments,
+"--patch-module",
+entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
+false,
+false);
+}
Review Comment:
Is it possible to add a test (unit or IT) for verifying this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on a diff in pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
slawekjaranowski commented on code in PR #225:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -4594,12 +4594,14 @@ private void addJavadocOptions(
}
for (Entry> entry : patchModules.entrySet()) {
-addArgIfNotEmpty(
-arguments,
-"--patch-module",
-entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
-false,
-false);
+if (!entry.getValue().isEmpty()) {
+addArgIfNotEmpty(
+arguments,
+"--patch-module",
+entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
+false,
+false);
+}
Review Comment:
Is it possible to add a test (unit or IT) for verifying this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements
[
https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755420#comment-17755420
]
ASF GitHub Bot commented on MJAVADOC-767:
-
slawekjaranowski commented on code in PR #225:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/225#discussion_r1296852969
##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -4594,12 +4594,14 @@ private void addJavadocOptions(
}
for (Entry> entry : patchModules.entrySet()) {
-addArgIfNotEmpty(
-arguments,
-"--patch-module",
-entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
-false,
-false);
+if (!entry.getValue().isEmpty()) {
+addArgIfNotEmpty(
+arguments,
+"--patch-module",
+entry.getKey() + '=' +
JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())),
+false,
+false);
+}
Review Comment:
Is it possible to add a test (unit or IT) for verifying this change?
> javadoc creates invalid --patch-module statements
> -
>
> Key: MJAVADOC-767
> URL: https://issues.apache.org/jira/browse/MJAVADOC-767
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.5.0
>Reporter: Henning Schmiedehausen
>Priority: Major
>
> Jdbi is a mixed Java/Kotlin multi-module project. We aggregate a final jar
> that contains all the javadocs for all modules in a doc step. This works ok
> for non-JPMS (Java 8 target).
> When introducing JPMS into our project, the javadoc plugin starts adding
> --patch-module options like this:
> {{--patch-module
> org.jdbi.v3.caffeine='/Users/henning/code/jdbi/cache/caffeine-cache/src/main/java:/Users/henning/code/jdbi/cache/caffeine-cache/target/generated-sources/annotations'}}
> However, in our configuration, we exclude the kotlin specific modules:
> {code:xml}
>
> maven-javadoc-plugin
>
>
> javadoc-jar
>
> jar
>
> package
>
> true
> false
>
>
> org.jdbi:*
>
>
>
> org.jdbi:jdbi3-kotlin
>
> org.jdbi:jdbi3-kotlin-sqlobject
>
>
> jdbi3-kotlin,jdbi3-kotlin-sqlobject
> Jdbi3 ${project.version} API
> Jdbi3 ${project.version} API
>
>
>
>
> {code}
> which results in the maven-javadoc-plugin creating command line options like
> this:
> {{--patch-module org.jdbi.v3.kotlin=}}
> which in turn crash the javadoc command.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] slawekjaranowski commented on pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
slawekjaranowski commented on PR #225: URL: https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1681886572 please remember to add jira number in final commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements
[
https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755432#comment-17755432
]
ASF GitHub Bot commented on MJAVADOC-767:
-
slawekjaranowski commented on PR #225:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1681886572
please remember to add jira number in final commit
> javadoc creates invalid --patch-module statements
> -
>
> Key: MJAVADOC-767
> URL: https://issues.apache.org/jira/browse/MJAVADOC-767
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.5.0
>Reporter: Henning Schmiedehausen
>Priority: Major
>
> Jdbi is a mixed Java/Kotlin multi-module project. We aggregate a final jar
> that contains all the javadocs for all modules in a doc step. This works ok
> for non-JPMS (Java 8 target).
> When introducing JPMS into our project, the javadoc plugin starts adding
> --patch-module options like this:
> {{--patch-module
> org.jdbi.v3.caffeine='/Users/henning/code/jdbi/cache/caffeine-cache/src/main/java:/Users/henning/code/jdbi/cache/caffeine-cache/target/generated-sources/annotations'}}
> However, in our configuration, we exclude the kotlin specific modules:
> {code:xml}
>
> maven-javadoc-plugin
>
>
> javadoc-jar
>
> jar
>
> package
>
> true
> false
>
>
> org.jdbi:*
>
>
>
> org.jdbi:jdbi3-kotlin
>
> org.jdbi:jdbi3-kotlin-sqlobject
>
>
> jdbi3-kotlin,jdbi3-kotlin-sqlobject
> Jdbi3 ${project.version} API
> Jdbi3 ${project.version} API
>
>
>
>
> {code}
> which results in the maven-javadoc-plugin creating command line options like
> this:
> {{--patch-module org.jdbi.v3.kotlin=}}
> which in turn crash the javadoc command.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io
[
https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755436#comment-17755436
]
ASF GitHub Bot commented on MSHARED-1297:
-
slawekjaranowski commented on code in PR #42:
URL: https://github.com/apache/maven-archiver/pull/42#discussion_r1296895957
##
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##
@@ -800,6 +800,21 @@ public static Optional
parseBuildOutputTimestamp(String outputTimestamp
}
}
+private static boolean isNumeric(String str) {
+
+if (str.isEmpty()) {
+return false;
+}
+
+for (char c : str.toCharArray()) {
+if (!Character.isDigit(c)) {
Review Comment:
It is simple copy method from plexu-utils ...
https://github.com/codehaus-plexus/plexus-utils/blob/master/src/main/java/org/codehaus/plexus/util/StringUtils.java#L1749
I think it is enough for our case - if user provide a special chars
Long.parseLong simply throw exception if needed.
> Prefer JDK features over plexus-utils, plexus-io
>
>
> Key: MSHARED-1297
> URL: https://issues.apache.org/jira/browse/MSHARED-1297
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-archiver
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-archiver-3.6.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755458#comment-17755458
]
Konrad Windszus commented on MRELEASE-1109:
---
The same is true for {{release:prepare-release}} which is sometimes helpful
even with CI friendly versions (e.g. for automatically updating property
{{project.build.outputTimestamp}},
https://maven.apache.org/guides/mini/guide-reproducible-builds.html)
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MJAVADOC-763) JavadocReportTest.testExceptions is broken
[ https://issues.apache.org/jira/browse/MJAVADOC-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MJAVADOC-763: - Fix Version/s: 3.5.1 > JavadocReportTest.testExceptions is broken > -- > > Key: MJAVADOC-763 > URL: https://issues.apache.org/jira/browse/MJAVADOC-763 > Project: Maven Javadoc Plugin > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: 3.5.1 > > > The Mojo lookup fails. This is hidden by bad exception handling in the test > that catches too broad an exception type. > [ERROR] Errors: > [ERROR] > JavadocReportTest.testExceptions:603->lookupMojo:103->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:426 > » ComponentConfiguration Cannot load implementation hint > 'org.apache.maven.plugins.javadoc.stubs.ExceptionTestMavenProjectStub' -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MJAVADOC-763) JavadocReportTest.testExceptions is broken
[ https://issues.apache.org/jira/browse/MJAVADOC-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755491#comment-17755491 ] Slawomir Jaranowski commented on MJAVADOC-763: -- [~elharo] - please take care about - fix version - assigned user - commit message should contains Jira number > JavadocReportTest.testExceptions is broken > -- > > Key: MJAVADOC-763 > URL: https://issues.apache.org/jira/browse/MJAVADOC-763 > Project: Maven Javadoc Plugin > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: 3.5.1 > > > The Mojo lookup fails. This is hidden by bad exception handling in the test > that catches too broad an exception type. > [ERROR] Errors: > [ERROR] > JavadocReportTest.testExceptions:603->lookupMojo:103->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:426 > » ComponentConfiguration Cannot load implementation hint > 'org.apache.maven.plugins.javadoc.stubs.ExceptionTestMavenProjectStub' -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MJAVADOC-763) JavadocReportTest.testExceptions is broken
[ https://issues.apache.org/jira/browse/MJAVADOC-763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MJAVADOC-763: Assignee: Elliotte Rusty Harold > JavadocReportTest.testExceptions is broken > -- > > Key: MJAVADOC-763 > URL: https://issues.apache.org/jira/browse/MJAVADOC-763 > Project: Maven Javadoc Plugin > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Fix For: 3.5.1 > > > The Mojo lookup fails. This is hidden by bad exception handling in the test > that catches too broad an exception type. > [ERROR] Errors: > [ERROR] > JavadocReportTest.testExceptions:603->lookupMojo:103->AbstractMojoTestCase.lookupMojo:355->AbstractMojoTestCase.lookupMojo:426 > » ComponentConfiguration Cannot load implementation hint > 'org.apache.maven.plugins.javadoc.stubs.ExceptionTestMavenProjectStub' -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io
[
https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755515#comment-17755515
]
ASF GitHub Bot commented on MSHARED-1297:
-
elharo commented on code in PR #42:
URL: https://github.com/apache/maven-archiver/pull/42#discussion_r1297121659
##
src/main/java/org/apache/maven/archiver/MavenArchiver.java:
##
@@ -800,6 +800,21 @@ public static Optional
parseBuildOutputTimestamp(String outputTimestamp
}
}
+private static boolean isNumeric(String str) {
+
+if (str.isEmpty()) {
+return false;
+}
+
+for (char c : str.toCharArray()) {
+if (!Character.isDigit(c)) {
Review Comment:
I guess this is within spec for parseBuildOutputTimestamp, as long as it's
private and not used anywhere else.
> Prefer JDK features over plexus-utils, plexus-io
>
>
> Key: MSHARED-1297
> URL: https://issues.apache.org/jira/browse/MSHARED-1297
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-archiver
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-archiver-3.6.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] elharo commented on a diff in pull request #196: [MRELEASE-1054] Support for excluding submodules changes.
elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1297127776
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -118,6 +125,15 @@ public ReleaseResult execute(
throws ReleaseExecutionException {
ReleaseResult result = new ReleaseResult();
+List additionalExcludes =
releaseDescriptor.getCheckModificationExcludes();
+
+if (additionalExcludes != null) {
+for (String additionalExclude : additionalExcludes) {
+exclusionPatterns.add(
+additionalExclude.replace("\\",
File.separator).replace("/", File.separator));
Review Comment:
I'm having trouble finding that reference. Regardless, we shouldn't be using
plexus for this any more,. Possibly maven-shared-utils but ideally not even
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRELEASE-1054) [Git submodule] Wrong Change on scm submodule after release:prepare and failed on pushChange
[
https://issues.apache.org/jira/browse/MRELEASE-1054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755517#comment-17755517
]
ASF GitHub Bot commented on MRELEASE-1054:
--
elharo commented on code in PR #196:
URL: https://github.com/apache/maven-release/pull/196#discussion_r1297127776
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractMapVersionsPhase.java:
##
@@ -118,6 +125,15 @@ public ReleaseResult execute(
throws ReleaseExecutionException {
ReleaseResult result = new ReleaseResult();
+List additionalExcludes =
releaseDescriptor.getCheckModificationExcludes();
+
+if (additionalExcludes != null) {
+for (String additionalExclude : additionalExcludes) {
+exclusionPatterns.add(
+additionalExclude.replace("\\",
File.separator).replace("/", File.separator));
Review Comment:
I'm having trouble finding that reference. Regardless, we shouldn't be using
plexus for this any more,. Possibly maven-shared-utils but ideally not even
that.
> [Git submodule] Wrong Change on scm submodule after release:prepare and
> failed on pushChange
>
>
> Key: MRELEASE-1054
> URL: https://issues.apache.org/jira/browse/MRELEASE-1054
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: Git, prepare, scm
>Affects Versions: 3.0.0-M1
>Reporter: Cau Ta
>Priority: Major
> Attachments: Screen Shot 2020-07-29 at 13.54.41.png
>
>
> *My project structure:*
> {{parent (git scm repo parent.git)}}
> {{-- git submodule A (git scm repo a.git)}}
> {{-- git submodule B (git scm repo b.git)}}
> {{-- git submodule C (git scm repo c.git)}}
> my maven release plugin config on parent pom.xml:
> __
> _org.apache.maven.plugins_
> _maven-release-plugin_
> _3.0.0-M1_
> __
> __
> _v@\{project.version}_
> _true_
> _true_
> _true_
> _false_
> __
> __
>
> The release was successful but after release:prepare the scm config of all
> submodule has been change.
> [Please take a look at the attachment]
> *--*
> *Another bug i have been faced is:*
> when enable push change (_true_)
> the release:prepare got stuck after push change at the first git submodule
> _[INFO] Executing: /bin/sh -c cd repository/beowulf/beowulf-libs/constant &&
> git push g...@github.com:beowulfchain-libs/beowulf-libs.git
> refs/heads/master:refs/heads/master_
> _[INFO] Working directory: repository/beowulf/beowulf-libs/constant_
> _[INFO]
> _
> _[INFO] Reactor Summary for beowulf 1.0-SNAPSHOT:_
> _[INFO]_
> _[INFO] beowulf FAILURE [
> 42.033 s]_
> _[INFO] constant ... SKIPPED_
> _[INFO] core ... SKIPPED_
> _[INFO] utils .. SKIPPED_
> _[INFO] domain . SKIPPED_
> _[INFO] config . SKIPPED_
> _[INFO] logging SKIPPED_
> _[INFO]
> _
> _[INFO] BUILD FAILURE_
> _[INFO]
> _
> _[INFO] Total time: 42.709 s_
> _[INFO] Finished at: 2020-07-28T17:51:04+07:00_
> _[INFO]
> _
> _[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M1:prepare (default-cli)
> on project beowulf: Unable to commit files_
> _[ERROR] Provider message:_
> _[ERROR] The git-push command failed._
> _[ERROR] Command output:_
> _[ERROR] Warning: Permanently added the RSA host key for IP address
> 'xxx.xxx.xxx.3' to the list of known hosts._
> _[ERROR] To github.com:beowulfchain-libs/beowulf-libs.git_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-454) Shade Plugin does not work with JDK 20
[
https://issues.apache.org/jira/browse/MSHADE-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755521#comment-17755521
]
Patrick Barry commented on MSHADE-454:
--
Thanks Michael and Torsten! Will v 3.5.1 be available soon or will a new
release need to be cut in the future?
> Shade Plugin does not work with JDK 20
> --
>
> Key: MSHADE-454
> URL: https://issues.apache.org/jira/browse/MSHADE-454
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Patrick Barry
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.5.1
>
>
> We are trying to use JDK 20 and this was the only plugin we had to
> work-around because it would not work. Are there plans to update this plugin
> to support JDK 20+? Is there a work-around until changes are made?
>
> Our current work-around is using assembly plugin, but we use shade plugin in
> many of the apps we are migrating and our preference is to continue to use
> Shade-plugin.
> Currently- if you try to use shade plugin with JDK 20, you get : Unsupported
> class file major version 64
>
> {noformat}
> Error creating shaded jar: Unsupported class file major version 64
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.DirectMethodHandleAccessor.invoke
> (DirectMethodHandleAccessor.java:104)
> at java.lang.reflect.Method.invoke (Method.java:578)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error creating
> shaded jar: Unsupported class file major version 64
> at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute
> (ShadeMojo.java:624)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:126)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
> (MojoExecutor.java:328)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:159)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.Si
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755585#comment-17755585
]
Konrad Windszus commented on MRELEASE-1109:
---
The logic for rewriting the version at
https://github.com/apache/maven-release/blob/0fae89df9706788902a1bc65d67cdbfae5f0d1b7/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#L467
needs to be extended to treat ci-friendly ones specially like it is currently
done in
https://github.com/eclipse-tycho/tycho/blob/2fcedecf38bf6244b911d486a6d8abd8c19ce5d8/tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/manipulation/PomManipulator.java#L88
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755585#comment-17755585
]
Konrad Windszus edited comment on MRELEASE-1109 at 8/17/23 2:47 PM:
The logic for rewriting the version at
https://github.com/apache/maven-release/blob/0fae89df9706788902a1bc65d67cdbfae5f0d1b7/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#L443
needs to be extended to treat ci-friendly ones specially like it is currently
done in
https://github.com/eclipse-tycho/tycho/blob/2fcedecf38bf6244b911d486a6d8abd8c19ce5d8/tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/manipulation/PomManipulator.java#L88
was (Author: kwin):
The logic for rewriting the version at
https://github.com/apache/maven-release/blob/0fae89df9706788902a1bc65d67cdbfae5f0d1b7/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java#L467
needs to be extended to treat ci-friendly ones specially like it is currently
done in
https://github.com/eclipse-tycho/tycho/blob/2fcedecf38bf6244b911d486a6d8abd8c19ce5d8/tycho-versions-plugin/src/main/java/org/eclipse/tycho/versions/manipulation/PomManipulator.java#L88
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MRELEASE-1109:
--
Component/s: prepare
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755616#comment-17755616 ] Gary D. Gregory commented on MSOURCES-143: -- I'm not sure what you are asking me or telling me. Where should this be addressed? > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned MRELEASE-1109:
-
Assignee: Konrad Windszus
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755651#comment-17755651
]
ASF GitHub Bot commented on MRELEASE-1109:
--
kwin opened a new pull request, #198:
URL: https://github.com/apache/maven-release/pull/198
(no comment)
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755657#comment-17755657 ] Romain Manni-Bucau commented on MSOURCES-143: - [~ggregory] spdx or parent pom or cli pom.xml, whatever will make the error case no more hit avoiding rebuild of the same mvn mojo execution > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755661#comment-17755661 ] Gary D. Gregory commented on MSOURCES-143: -- Hi [~sjaranowski] I am sorry but I still don't get it. What does the SPDX plugin's PR (removing something that happens at verify?) have to do with creating source and test source jars? I just want to build source jars and I don't need to understand what SPDX does beyond creating it's own custom files. Are you saying that SPDX, as part of it's own execution, causes the source and test source jars to be generated, and that's indeed the issue? Hi [~romain.manni-bucau] "whatever will make the error case no more hit avoiding rebuild of the same mvn mojo execution" So do whatever fixes the problem? Great advice. Sorry for being sarcastic but this is the level of Maven Magic that I find frustrating. I not sure if what I am trying to do is unusual or a stretch or what, but I'm looking for specific help on what to do here. > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755662#comment-17755662 ] Romain Manni-Bucau commented on MSOURCES-143: - [~ggregory] was not really "do whatever fixes the problem" was more "whatever you judge right" - on my side I find commons-parent way too fat and overkill and I don't know spdx plugin enough so I would be keen to drop most of the first and make spdx not rerun what is configured in cli but it can not be the best for the project. You probably don't do something unusual but you have a legacy which was hidden and is not shown - which is good on maven side I think. > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755705#comment-17755705
]
ASF GitHub Bot commented on MRELEASE-1109:
--
michael-o commented on code in PR #198:
URL: https://github.com/apache/maven-release/pull/198#discussion_r1297769497
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -89,6 +93,18 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
*/
private String modelETL = JDomModelETLFactory.NAME;
+/**
+ * Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
+ * The first group selects the property name the expression refers to.
+ */
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+
+/**
+ * All Maven properties allowed to be referenced in parent versions via
expressions
+ * @see https://maven.apache.org/maven-ci-friendly.html";>CI-Friendly Versions
+ */
+private static final List CI_FRIENDLY_PROPERTIES =
Arrays.asList("revision", "sha1", "changelist");
Review Comment:
Was this copied from Core? I remember to have this seen this.
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] michael-o commented on a diff in pull request #198: [MRELEASE-1109] Support CI friendly versions
michael-o commented on code in PR #198:
URL: https://github.com/apache/maven-release/pull/198#discussion_r1297769497
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -89,6 +93,18 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
*/
private String modelETL = JDomModelETLFactory.NAME;
+/**
+ * Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
+ * The first group selects the property name the expression refers to.
+ */
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+
+/**
+ * All Maven properties allowed to be referenced in parent versions via
expressions
+ * @see https://maven.apache.org/maven-ci-friendly.html";>CI-Friendly Versions
+ */
+private static final List CI_FRIENDLY_PROPERTIES =
Arrays.asList("revision", "sha1", "changelist");
Review Comment:
Was this copied from Core? I remember to have this seen this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io
[ https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755709#comment-17755709 ] ASF GitHub Bot commented on MSHARED-1297: - slawekjaranowski merged PR #42: URL: https://github.com/apache/maven-archiver/pull/42 > Prefer JDK features over plexus-utils, plexus-io > > > Key: MSHARED-1297 > URL: https://issues.apache.org/jira/browse/MSHARED-1297 > Project: Maven Shared Components > Issue Type: Task > Components: maven-archiver >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-archiver-3.6.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1297) Prefer JDK features over plexus-utils, plexus-io
[ https://issues.apache.org/jira/browse/MSHARED-1297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1297. Resolution: Fixed > Prefer JDK features over plexus-utils, plexus-io > > > Key: MSHARED-1297 > URL: https://issues.apache.org/jira/browse/MSHARED-1297 > Project: Maven Shared Components > Issue Type: Task > Components: maven-archiver >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-archiver-3.6.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-javadoc-plugin] hgschmie commented on pull request #225: [MJAVADOC-767] javadoc creates invalid --patch-module statements
hgschmie commented on PR #225: URL: https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1683340371 added integration test. To try out, remove this line: https://github.com/apache/maven-javadoc-plugin/pull/225/files#diff-3cc042c3116d0543702076b295213a5b4058ce2f0c342edf234dfd06fefacabfR44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-767) javadoc creates invalid --patch-module statements
[
https://issues.apache.org/jira/browse/MJAVADOC-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755797#comment-17755797
]
ASF GitHub Bot commented on MJAVADOC-767:
-
hgschmie commented on PR #225:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/225#issuecomment-1683340371
added integration test. To try out, remove this line:
https://github.com/apache/maven-javadoc-plugin/pull/225/files#diff-3cc042c3116d0543702076b295213a5b4058ce2f0c342edf234dfd06fefacabfR44
> javadoc creates invalid --patch-module statements
> -
>
> Key: MJAVADOC-767
> URL: https://issues.apache.org/jira/browse/MJAVADOC-767
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.5.0
>Reporter: Henning Schmiedehausen
>Priority: Major
>
> Jdbi is a mixed Java/Kotlin multi-module project. We aggregate a final jar
> that contains all the javadocs for all modules in a doc step. This works ok
> for non-JPMS (Java 8 target).
> When introducing JPMS into our project, the javadoc plugin starts adding
> --patch-module options like this:
> {{--patch-module
> org.jdbi.v3.caffeine='/Users/henning/code/jdbi/cache/caffeine-cache/src/main/java:/Users/henning/code/jdbi/cache/caffeine-cache/target/generated-sources/annotations'}}
> However, in our configuration, we exclude the kotlin specific modules:
> {code:xml}
>
> maven-javadoc-plugin
>
>
> javadoc-jar
>
> jar
>
> package
>
> true
> false
>
>
> org.jdbi:*
>
>
>
> org.jdbi:jdbi3-kotlin
>
> org.jdbi:jdbi3-kotlin-sqlobject
>
>
> jdbi3-kotlin,jdbi3-kotlin-sqlobject
> Jdbi3 ${project.version} API
> Jdbi3 ${project.version} API
>
>
>
>
> {code}
> which results in the maven-javadoc-plugin creating command line options like
> this:
> {{--patch-module org.jdbi.v3.kotlin=}}
> which in turn crash the javadoc command.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MJAVADOC-768) javadoc has a hard time with JPMS and provided or optional module dependencies.
Henning Schmiedehausen created MJAVADOC-768: --- Summary: javadoc has a hard time with JPMS and provided or optional module dependencies. Key: MJAVADOC-768 URL: https://issues.apache.org/jira/browse/MJAVADOC-768 Project: Maven Javadoc Plugin Issue Type: Bug Components: jar, javadoc Affects Versions: 3.5.0 Reporter: Henning Schmiedehausen Check out this project: [https://github.com/hgschmie/mjavadoc768/] run `mvn clean install` in the root. This results in this error: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:aggregate-jar (javadoc-jar) on project doc: MavenReportException: Error while generating Javadoc: [ERROR] Exit code: 1 [ERROR] /Users/henning/scratch/jdbug/thing2/src/main/java/module-info.java:4: error: module not found: jakarta.annotation [ERROR] requires static jakarta.annotation; [ERROR] ^ [ERROR] /Users/henning/scratch/jdbug/thing1/src/main/java/module-info.java:4: error: module not found: jakarta.annotation [ERROR] requires static jakarta.annotation; [ERROR] ^ [ERROR] 2 errors [ERROR] Command line was: /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/javadoc -J-Xmx1024m @options @packages @argfile [ERROR] [ERROR] Refer to the generated Javadoc files in '/Users/henning/scratch/jdbug/doc/target/apidocs' dir. ``` The problem is that both maven modules (thing1 and thing2) declare a compile time dependency on "jakarta-annotation" using either maven `provided` scope or maven `optional`. This is reflected in the JPMS module descriptor by using `required static jakarta.annotation;`. But the javadoc tool, when it wants to generate the aggregation jar, generates an options file that does not contain the jakarta-annotation jar on the module path (which is needed for javadoc to succeed), so the tool reports the error above. The javadoc tool needs to add all provided and optional dependencies to the module path for the aggregated jar. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MJAVADOC-768) javadoc has a hard time with JPMS and provided or optional module dependencies.
[
https://issues.apache.org/jira/browse/MJAVADOC-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henning Schmiedehausen updated MJAVADOC-768:
Description:
Check out this project: [https://github.com/hgschmie/mjavadoc768/]
run {{mvn clean install}} in the root. This results in this error:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:aggregate-jar (javadoc-jar)
on project doc: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1
[ERROR] /Users/henning/scratch/jdbug/thing2/src/main/java/module-info.java:4:
error: module not found: jakarta.annotation
[ERROR] requires static jakarta.annotation;
[ERROR] ^
[ERROR] /Users/henning/scratch/jdbug/thing1/src/main/java/module-info.java:4:
error: module not found: jakarta.annotation
[ERROR] requires static jakarta.annotation;
[ERROR] ^
[ERROR] 2 errors
[ERROR] Command line was:
/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/javadoc
-J-Xmx1024m @options @packages @argfile
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'/Users/henning/scratch/jdbug/doc/target/apidocs' dir.
{code}
The problem is that both maven modules (thing1 and thing2) declare a compile
time dependency on "jakarta-annotation" using either maven {{provided}} scope
or maven {{optional}}. This is reflected in the JPMS module descriptor by using
`required static jakarta.annotation;`.
But the javadoc tool, when it wants to generate the aggregation jar, generates
an options file that does not contain the jakarta-annotation jar on the module
path (which is needed for javadoc to succeed), so the tool reports the error
above. The javadoc tool needs to add all provided and optional dependencies to
the module path for the aggregated jar.
was:
Check out this project: [https://github.com/hgschmie/mjavadoc768/]
run `mvn clean install` in the root. This results in this error:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:aggregate-jar (javadoc-jar)
on project doc: MavenReportException: Error while generating Javadoc:
[ERROR] Exit code: 1
[ERROR] /Users/henning/scratch/jdbug/thing2/src/main/java/module-info.java:4:
error: module not found: jakarta.annotation
[ERROR] requires static jakarta.annotation;
[ERROR] ^
[ERROR] /Users/henning/scratch/jdbug/thing1/src/main/java/module-info.java:4:
error: module not found: jakarta.annotation
[ERROR] requires static jakarta.annotation;
[ERROR] ^
[ERROR] 2 errors
[ERROR] Command line was:
/Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home/bin/javadoc
-J-Xmx1024m @options @packages @argfile
[ERROR]
[ERROR] Refer to the generated Javadoc files in
'/Users/henning/scratch/jdbug/doc/target/apidocs' dir.
```
The problem is that both maven modules (thing1 and thing2) declare a compile
time dependency on "jakarta-annotation" using either maven `provided` scope or
maven `optional`. This is reflected in the JPMS module descriptor by using
`required static jakarta.annotation;`.
But the javadoc tool, when it wants to generate the aggregation jar, generates
an options file that does not contain the jakarta-annotation jar on the module
path (which is needed for javadoc to succeed), so the tool reports the error
above. The javadoc tool needs to add all provided and optional dependencies to
the module path for the aggregated jar.
> javadoc has a hard time with JPMS and provided or optional module
> dependencies.
> ---
>
> Key: MJAVADOC-768
> URL: https://issues.apache.org/jira/browse/MJAVADOC-768
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar, javadoc
>Affects Versions: 3.5.0
>Reporter: Henning Schmiedehausen
>Priority: Major
>
> Check out this project: [https://github.com/hgschmie/mjavadoc768/]
> run {{mvn clean install}} in the root. This results in this error:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.5.0:aggregate-jar
> (javadoc-jar) on project doc: MavenReportException: Error while generating
> Javadoc:
> [ERROR] Exit code: 1
> [ERROR] /Users/henning/scratch/jdbug/thing2/src/main/java/module-info.java:4:
> error: module not found: jakarta.annotation
> [ERROR] requires static jakarta.annotation;
> [ERROR] ^
> [ERROR] /Users/henning/scratch/jdbug/thing1/src/main/java/module-info.java:4:
> error: module not found: jakarta.annotation
> [ERROR] requires static jakarta.annotation;
> [ERROR] ^
> [ERROR] 2 errors
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755816#comment-17755816
]
ASF GitHub Bot commented on MRELEASE-1109:
--
kwin commented on code in PR #198:
URL: https://github.com/apache/maven-release/pull/198#discussion_r1298050608
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -89,6 +93,18 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
*/
private String modelETL = JDomModelETLFactory.NAME;
+/**
+ * Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
+ * The first group selects the property name the expression refers to.
+ */
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+
+/**
+ * All Maven properties allowed to be referenced in parent versions via
expressions
+ * @see https://maven.apache.org/maven-ci-friendly.html";>CI-Friendly Versions
+ */
+private static final List CI_FRIENDLY_PROPERTIES =
Arrays.asList("revision", "sha1", "changelist");
Review Comment:
It is available in
https://github.com/apache/maven/blob/eff2fbf2a9baaa2178825b5745c7f152330c8946/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/DefaultModelVersionProcessor.java#L38
but it has only been introduced with 3.8.5
(https://issues.apache.org/jira/browse/MNG-7407) so I would stick with the
separate copy inside this class.
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-release] kwin commented on a diff in pull request #198: [MRELEASE-1109] Support CI friendly versions
kwin commented on code in PR #198:
URL: https://github.com/apache/maven-release/pull/198#discussion_r1298050608
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -89,6 +93,18 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
*/
private String modelETL = JDomModelETLFactory.NAME;
+/**
+ * Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
+ * The first group selects the property name the expression refers to.
+ */
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+
+/**
+ * All Maven properties allowed to be referenced in parent versions via
expressions
+ * @see https://maven.apache.org/maven-ci-friendly.html";>CI-Friendly Versions
+ */
+private static final List CI_FRIENDLY_PROPERTIES =
Arrays.asList("revision", "sha1", "changelist");
Review Comment:
It is available in
https://github.com/apache/maven/blob/eff2fbf2a9baaa2178825b5745c7f152330c8946/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/DefaultModelVersionProcessor.java#L38
but it has only been introduced with 3.8.5
(https://issues.apache.org/jira/browse/MNG-7407) so I would stick with the
separate copy inside this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #198: [MRELEASE-1109] Support CI friendly versions
michael-o commented on code in PR #198:
URL: https://github.com/apache/maven-release/pull/198#discussion_r1298063440
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -89,6 +93,18 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
*/
private String modelETL = JDomModelETLFactory.NAME;
+/**
+ * Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
+ * The first group selects the property name the expression refers to.
+ */
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+
+/**
+ * All Maven properties allowed to be referenced in parent versions via
expressions
+ * @see https://maven.apache.org/maven-ci-friendly.html";>CI-Friendly Versions
+ */
+private static final List CI_FRIENDLY_PROPERTIES =
Arrays.asList("revision", "sha1", "changelist");
Review Comment:
That's exactly the answer I wanted to hear!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}
[
https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755819#comment-17755819
]
ASF GitHub Bot commented on MRELEASE-1109:
--
michael-o commented on code in PR #198:
URL: https://github.com/apache/maven-release/pull/198#discussion_r1298063440
##
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##
@@ -89,6 +93,18 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
*/
private String modelETL = JDomModelETLFactory.NAME;
+/**
+ * Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
+ * The first group selects the property name the expression refers to.
+ */
+private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+
+/**
+ * All Maven properties allowed to be referenced in parent versions via
expressions
+ * @see https://maven.apache.org/maven-ci-friendly.html";>CI-Friendly Versions
+ */
+private static final List CI_FRIENDLY_PROPERTIES =
Arrays.asList("revision", "sha1", "changelist");
Review Comment:
That's exactly the answer I wanted to hear!
> update-versions removes the CI-friendly ${revisions}
>
>
> Key: MRELEASE-1109
> URL: https://issues.apache.org/jira/browse/MRELEASE-1109
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3, 3.0.0-M7
>Reporter: Marcel Stör
>Assignee: Konrad Windszus
>Priority: Major
>
> Given: a project using CI-friendly versions as per
> [https://maven.apache.org/maven-ci-friendly.html]
> {code:xml}
> ${revision}
> ...
>
> 1.0.0-SNAPSHOT
>
> {code}
> If I run {{mvn release:update-versions}} (with or without
> {{{}-DautoVersionSubmodules=true{}}}) I expect the release plugin to change
> the {{$revision}} property. Instead it blindly replaces
> {{${revision}}} with the hard-coded version set on the CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
