kwin commented on code in PR #198:
URL: https://github.com/apache/maven-release/pull/198#discussion_r1298050608
##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java:
##########
@@ -89,6 +93,18 @@ public abstract class AbstractRewritePomsPhase extends
AbstractReleasePhase impl
*/
private String modelETL = JDomModelETLFactory.NAME;
+ /**
+ * Regular expression pattern matching Maven expressions (i.e. references
to Maven properties).
+ * The first group selects the property name the expression refers to.
+ */
+ private static final Pattern EXPRESSION_PATTERN =
Pattern.compile("\\$\\{(.+)\\}");
+
+ /**
+ * All Maven properties allowed to be referenced in parent versions via
expressions
+ * @see <a
href="https://maven.apache.org/maven-ci-friendly.html";>CI-Friendly Versions</a>
+ */
+ private static final List<String> CI_FRIENDLY_PROPERTIES =
Arrays.asList("revision", "sha1", "changelist");
Review Comment:
It is available in
https://github.com/apache/maven/blob/eff2fbf2a9baaa2178825b5745c7f152330c8946/maven-model-builder/src/main/java/org/apache/maven/model/interpolation/DefaultModelVersionProcessor.java#L38
but it has only been introduced with 3.8.5
(https://issues.apache.org/jira/browse/MNG-7407) so I would stick with the
separate copy inside this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
