[jira] [Updated] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge
[
https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MNG-7625:
-
Summary: Restore compatibility with Maven 3 - SettingsUtils#merge (was:
Restore compatibility with maven 3 - SettingsUtils#merge)
> Restore compatibility with Maven 3 - SettingsUtils#merge
>
>
> Key: MNG-7625
> URL: https://issues.apache.org/jira/browse/MNG-7625
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-3
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Maven 3 has method:
> {code:java}
> void SettingsUtils#merge(org.apache.maven.settings.Settings,
> org.apache.maven.settings.Settings, java.lang.String)
> {code}
> It is used by {{maven-invoker-plugin}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1347905784 maybe incremental is not the right name for this but yes on a 300 modules project not recompiling everything all the makes a big difference at the end of the day -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1347928885 think there are multiple points mixed there: * Default behavior (incremental=true) is to not recompile if upstream didn't change -> we must keep it IMHO * Toggle behavior (incremental=false) is to only recompile what changed (if you have 10 source files and modified 1 then you only recompile this last one). This mode is broken I agree for a lot of reasons in java ecosystem (annot proc being an example). So overall I think it makes sense to keep at least the default behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINVOKER-316) Refresh plugins versions in IT tests
Slawomir Jaranowski created MINVOKER-316: Summary: Refresh plugins versions in IT tests Key: MINVOKER-316 URL: https://issues.apache.org/jira/browse/MINVOKER-316 Project: Maven Invoker Plugin Issue Type: Task Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Preparing for executing by Maven 4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-invoker-plugin] slawekjaranowski opened a new pull request, #156: [MINVOKER-316] Refresh plugins versions in IT tests
slawekjaranowski opened a new pull request, #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MINVOKER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MINVOKER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MINVOKER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] dependabot[bot] commented on pull request #105: Bump slf4jVersion from 1.7.36 to 2.0.5
dependabot[bot] commented on PR #105: URL: https://github.com/apache/maven-pmd-plugin/pull/105#issuecomment-1348200460 Superseded by #106. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request, #106: Bump slf4jVersion from 1.7.36 to 2.0.6
dependabot[bot] opened a new pull request, #106: URL: https://github.com/apache/maven-pmd-plugin/pull/106 Bumps `slf4jVersion` from 1.7.36 to 2.0.6. Updates `slf4j-api` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view Updates `jul-to-slf4j` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view Updates `slf4j-simple` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR
[GitHub] [maven-pmd-plugin] dependabot[bot] closed pull request #105: Bump slf4jVersion from 1.7.36 to 2.0.5
dependabot[bot] closed pull request #105: Bump slf4jVersion from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-pmd-plugin/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348211764 As everyone talks how this is "must to have" but nobody provided any number to support this claim, I tried to convince myself this is "must to have". So... Subject build: Jetty branch `jetty-10.0.x` (6e82e70edf6a106b9fd08ccfacd840efef8a95f9) with 172 modules from https://github.com/eclipse/jetty.project ## Preparations Built this checked out project "as usual" (by the book) using `-DskipTests` as README recommends to prime local repo. After local repo "primed" (to have no remote fetch happens), spotted that asciidoctor-maven-plugin always goes remote, so removed documentation module that uses it, to prevent huge variance (as it goes directly to central, not local MRM). Then, as 2nd (w/o clean) invocation consistently failed, had to remove tests-integration module as well, to be able to test "incremental" use case. This leaves us with 170 modules. Finally,. changed jetty to use locally built 3.11.0-SNAPSHOT of maven-compile-plugin: * master (5be316391ea7c575ee65c3fe83b4c7b30e1174d0) * vs PR (7b59074b400974b57e9c4cd84269acd39d7a7f9a) Full diff of my local changes: https://gist.github.com/cstamas/b637f4bce0967836cf835cf21e105ab9 ## Used Invocations I used following 3 invocations to time: 1st invocation: `mvn clean install -DskipTests` 2nd invocation: `mvn install -DskipTests` 3rd invocation: `mvn verify -DskipTests` Used Maven "total time" output as measure. ## With m-c-p:master 1st master: 02:10 min 2nd master: 01:39 min 3rd master: 01:35 min ## With m-c-p:PR 1st PR: 02:11 min 2nd PR: 01:35 min 3rd PR: 01:36 min ## Conclusion Please, somebody, anybody, repeat these (the numbers cannot be "cross" compared, only can be compared among runs on same HW/env), and as always, "this is not a proper benchmark" type of notice... but. So far, it seems Jetty project (170) modules is not "large" enough to produce noticeable difference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] michael-o commented on a diff in pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests
michael-o commented on code in PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156#discussion_r1047007075 ## src/it/local-repo-path/pom.xml: ## @@ -54,7 +54,9 @@ under the License. src/it/settings.xml -org.apache.maven.plugins:maven-clean-plugin:2.2:clean + +-c + org.apache.maven.plugins:maven-clean-plugin:3.2.0:clean Review Comment: Why no property here? ## pom.xml: ## @@ -357,7 +357,19 @@ under the License. run-its + +3.1.0 +3.2.0 +3.10.1 +3.1.0 +3.3.0 +3.1.0 +3.3.0 +3.7.0 +3.3.0 3.7.1 Review Comment: This should be 3.12.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348235817 as you are using a project which need install this doesn't work because some artifacts are part of the reactor and rebuild (e.g re package) so they are detected as new dependency and so re compiled just look the output and it will say everything is recompiled... I have some work locally which handle this case but never pushed this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348251135 Nope, I removed bits needing install, 3rd invocation is `mvn verify`, please reread. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348260251 Here is a simple project showing the usage: ``` rmannibucau@rmannibucau-yupiik:/opt/rmannibucau/dev/demo-sunny $ mvn clean [INFO] Scanning for projects... [INFO] [INFO] ---< org.example:demo-sunny >--- [INFO] Building demo-sunny 1.0-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ demo-sunny --- [INFO] Deleting /opt/rmannibucau/dev/demo-sunny/target [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 0.158 s [INFO] Finished at: 2022-12-13T12:21:00+01:00 [INFO] rmannibucau@rmannibucau-yupiik:/opt/rmannibucau/dev/demo-sunny $ mvn compile [INFO] Scanning for projects... [INFO] [INFO] ---< org.example:demo-sunny >--- [INFO] Building demo-sunny 1.0-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ demo-sunny --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 0 resource [INFO] [INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ demo-sunny --- [INFO] Changes detected - recompiling the module! [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1.391 s [INFO] Finished at: 2022-12-13T12:21:04+01:00 [INFO] rmannibucau@rmannibucau-yupiik:/opt/rmannibucau/dev/demo-sunny $ mvn compile [INFO] Scanning for projects... [INFO] [INFO] ---< org.example:demo-sunny >--- [INFO] Building demo-sunny 1.0-SNAPSHOT [INFO] [ jar ]- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ demo-sunny --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] Copying 0 resource [INFO] [INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ demo-sunny --- [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 0.572 s [INFO] Finished at: 2022-12-13T12:21:07+01:00 [INFO] ``` as you can see gain is quite huge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348309636 @rmannibucau i hope you understand your example does not make sense? Can you show me a real life example, a full build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on a diff in pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests
slawekjaranowski commented on code in PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156#discussion_r1047049860 ## pom.xml: ## @@ -357,7 +357,19 @@ under the License. run-its + +3.1.0 +3.2.0 +3.10.1 +3.1.0 +3.3.0 +3.1.0 +3.3.0 +3.7.0 +3.3.0 3.7.1 Review Comment: I had a proposition to provided such properties from parent, instead of managing in each projects 😄 https://issues.apache.org/jira/browse/MPOM-289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348339146 > Nope, I removed bits needing install, 3rd invocation is `mvn verify`, please reread. read my comment especially on the reactor and rebuild of artifacts. what do you see in the output `Changes detected - recompiling the module!` or `Nothing to compile - all classes are up to date` because for every build (except the module `jetty-slf4j-impl` everything is recompiled) if not please post the output. > mvn clean install -DskipTests for jetty-10.0.x branch you have 02:10 min?? really?? you have a very very beefy machine so recompiling or not doesn't make any difference for you I know this build and 2:10m for clean install means you have a very beefy machine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348361295 Full logs of `mvn verify -DskipTests` are here (they are huge) https://drive.google.com/file/d/1S8GUWW7C2SC2Wv4_LjxCji_VaJZORGMj/view?usp=share_link -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #89: Bump slf4jVersion from 1.7.36 to 2.0.6
dependabot[bot] opened a new pull request, #89: URL: https://github.com/apache/maven-jxr/pull/89 Bumps `slf4jVersion` from 1.7.36 to 2.0.6. Updates `slf4j-api` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view Updates `slf4j-simple` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] olamy commented on a diff in pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests
olamy commented on code in PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156#discussion_r1047075394 ## pom.xml: ## @@ -357,7 +357,19 @@ under the License. run-its + +3.1.0 +3.2.0 +3.10.1 +3.1.0 +3.3.0 +3.1.0 +3.3.0 +3.7.0 +3.3.0 3.7.1 Review Comment: Oh yes this would be so nice!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
slawekjaranowski commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348400184 My test - Classes in target prod and unit: 4883 - Maven modules: 326 - JDK 1.8 - Os: MacOs 12.6.1 - 2,6 GHz 6-Core Intel Core i7, 32 GB 2667 MHz DDR4 - m-c-p 3.10.1 # Scenario 1 ``` mvn test-compile mvn test-compile | grep -e "Nothing to compile\|Changes detected\|Total time" > 1.txt ``` # Scenario 2 ``` mvn clean mvn test-compile | grep -e "Nothing to compile\|Changes detected\|Total time" > 2.txt ``` # Result 1 ``` grep "Changes detected" 1.txt | wc -l 1 grep "Nothing to compile" 1.txt | wc -l 313 [INFO] Total time: 01:02 min ``` # Result 2 ``` grep "Changes detected" 2.txt | wc -l 314 grep "Nothing to compile" 2.txt | wc -l 0 [INFO] Total time: 05:59 min ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348400764 @rmannibucau a bit of simple math: your "full" compile: 1391ms your "incremental" compile: 572ms difference is: 819ms On "big" build (a 300 module build was mentioned): 300 x 819ms = 245700ms = 245,7s = 4,095min So, the diff you showed _would_ produce on 300 module build total time difference of 4 minutes? Am interested in how much percentage these 4 minutes are of the full build time10%? 1%? 0.05%? Let's find out! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348406757 @slawekjaranowski please compare m-c-p master (or any released) vs this PRl :smile: As your test really compares m-c-p against m-c-p, not m-c-p master/released against PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348410859 @cstamas as Olivier mentionned, your build does not use this feature so you compare twice the same things. Also my example shows the real gain. I tested on a work project - sorry, there I can't share the full outputs but it is similar to the demo I shared but with 31 modules: 17s for the first build, 10s for the second using the command `mvn package -pl '-documentation' -DskipTests` - note that install does not change this +-0.5s - and validating `Nothing to compile - all classes are up to date` is actually used. Finally, doing a bit of simple math the 4mn are ~50% of the build as you can see yourself, now if you add tests and your tests take 10mn I agree with you but it is another problem. If your point is that compilation is always a small amount of time of a full build then this is highly wrong cause you think as a CI but a dev does not always run the full project build but working you often have 'shortcutted' builds to go faster and there, +-1mn is something - human time - so yes 4mn is a lot, means you can build x2 so likely produce way more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348422749 @rmannibucau could you please build locally this PR and try with that same steps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348441207 @cstamas 16s first time then always ~14s so overall the diff logic is worth it even if it costs some time - guess we can make it faster there too tracking files more efficiently in the project but overall this PR has a negative impact on the overall build time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348457823 @rmannibucau ok, thanks for doing this. As I thought: PR is _clearly better_ at "full recompile" case of m-c-p master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348483187 > As I thought: PR is clearly better at "full recompile" case of m-c-p master @cstamas you mean slower and produces the same output? master does by default a full rebuild in 10s whereas your PR does a full rebuild in 14s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348488063 Ok, tried with another project, Maven this time: maven master: 984f73dc7ca2515ee520fbded3382820f62116e9 # Invocations 1st: `mvn clean install -DskipTests` 2nd: `mvn verify -DskipTests` # With master 1st: 49.868s 2nd: 36.577s # With PR 1st: 48.978s 2nd: 41.383s And again, the feature did not work (!) as I understand, as there are inter-dependencies in reactor? What's the point of multi module build if this feature does NOT work with it? Am I right that this feature works on multi module build ONLY if there are no inter project dependencies? I just realized what @olamy was saying -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-javadoc-plugin] elharo commented on a diff in pull request #176: Assorted minor updates
elharo commented on code in PR #176: URL: https://github.com/apache/maven-javadoc-plugin/pull/176#discussion_r1047124908 ## src/site/fml/faq.fml: ## @@ -301,11 +301,11 @@ mvn deploy:deploy-file \ - - On Windows with Sun JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? + + On Windows with Oracle JDK, why javadoc:javadoc goal blows up due to an IllegalArgumentException in sun.net.www.ParseUtil.decode()? - You are on Windows XP with Sun JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, + You are on Windows XP with Oracle JDK 5 or JDK 6 freshly installed, and when you run mvn javadoc:javadoc, Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348501492 > @cstamas you mean slower and produces the same output? master does by default a full rebuild in 10s whereas your PR does a full rebuild in 14s The I don't understand this: "17s for the first build, 10s for the second", isn't first the "full"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348508155 > The I don't understand this: "17s for the first build, 10s for the second", isn't first the "full"? @cstamas the first is the run after a `clean` which means this PR or master will do the same - this is also why it runs in the same time. All consecutive builds are `package`/`install` without `clean` - exact same command than the first run, dev case - and there your PR is significantly slower so you should compare the > 1 build durations and not the first one which is globally the same without the state checking (but this one is almost free as you can see - at least in the error rate). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348510150 Recap what we have so fat: * "incremental" feature may bring 4 minute gain on 300 module build, unless * there are inter-module dependencies, as in that case this feature would work only on "root" modules? Is this right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] rfscholte commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
rfscholte commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1047135097
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
Is the pom an artifact or is it the metadata for the artifact and
subartifacts? Just wondering if the class has the right name. (hence why i
called it FileTransformer to cover both)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646627#comment-17646627
]
ASF GitHub Bot commented on MNG-7622:
-
rfscholte commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1047135097
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
Is the pom an artifact or is it the metadata for the artifact and
subartifacts? Just wondering if the class has the right name. (hence why i
called it FileTransformer to cover both)
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348539648 > "incremental" feature may bring 4 minute gain on 300 module build, unless If we ignore the figures right - highly depends your build, tomee container/openejb-core module for ex, it is 14s -> 4s (1 module so if you do the math you almost save 1h for your example ;)). > there are inter-module dependencies, as in that case this feature would work only on "root" modules? Kind of, "magic" happens there https://github.com/apache/maven-compiler-plugin/blob/master/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L897 and agree the rule can be enhanced to better manage multi-reactor builds, can be a great enhancement/PR to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] cstamas commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
cstamas commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348585346 > If we ignore the figures right - highly depends your build, tomee container/openejb-core module for ex, it is 14s -> 4s (1 module so if you do the math you almost save 1h for your example ;)). Sure, we can come up with numbers as we like, but I will shut up in a moment this very feature saves 1h on a _real life project_ out there. > Kind of, "magic" happens there https://github.com/apache/maven-compiler-plugin/blob/master/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L897 and agree the rule can be enhanced to better manage multi-reactor builds, can be a great enhancement/PR to do. Sure, but this also means that almost no multi module build benefits from this feature, as the sole idea of multi module build is usually to "depend on each other". I can imagine some "lab" project where you have 300 modules that do not depend on each other, but I guess this cannot be called "majority", unless am mistaken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
slawekjaranowski commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348588366 # Master commit 5be316391ea7c575ee65c3fe83b4c7b30e1174d0 ## Result 1 - next execution - rebuild is skipped ``` [INFO] Total time: 01:12 min ``` ## Result 2 - after clean ``` [INFO] Total time: 05:42 min ``` # PR 160 commit 7b59074b400974b57e9c4cd84269acd39d7a7f9a Only scenario 2, many times the same command - `mvn test-compile` on the same workspace, all modules are recompiled everytime, sample of time: ``` [INFO] Total time: 06:25 min [INFO] Total time: 05:34 min [INFO] Total time: 05:24 min ``` take similar time like `mvn clean ...` in my case so difference from 1 to 5 minutes is important for project which I work at usual day, and many time I need to rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #907: [MNG-7622] Maven Transformation and Consumer POM
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1047185218
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
POM is attached as Artifact (but this interface was removed since)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7622) Reimplement Consumer POM feature
[
https://issues.apache.org/jira/browse/MNG-7622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646642#comment-17646642
]
ASF GitHub Bot commented on MNG-7622:
-
cstamas commented on code in PR #907:
URL: https://github.com/apache/maven/pull/907#discussion_r1047185218
##
maven-core/src/main/java/org/apache/maven/internal/transformation/ArtifactTransformer.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.transformation;
+
+import java.io.IOException;
+import org.apache.maven.project.MavenProject;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.deployment.DeployRequest;
+import org.eclipse.aether.installation.InstallRequest;
+
+/**
+ * Artifact transformer component.
+ *
+ * Note: this interface is Maven internal component, subject to change or
removal without notice.
+ *
+ * @since TBD
+ */
+public interface ArtifactTransformer {
Review Comment:
POM is attached as Artifact (but this interface was removed since)
> Reimplement Consumer POM feature
>
>
> Key: MNG-7622
> URL: https://issues.apache.org/jira/browse/MNG-7622
> Project: Maven
> Issue Type: Task
> Components: build/consumer
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> Current implementation relies on deprecated resolver API (is deprecated as it
> is OOM prone), and also renders use cases like m-gpg-p but also checksum-m-p
> broken.
> Reimplement consumer POM feature that:
> * does not use FileTransformer API
> * allows use cases like m-gpg-p
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] slawekjaranowski opened a new pull request, #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge
slawekjaranowski opened a new pull request, #909: URL: https://github.com/apache/maven/pull/909 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge
[
https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646697#comment-17646697
]
ASF GitHub Bot commented on MNG-7625:
-
slawekjaranowski opened a new pull request, #909:
URL: https://github.com/apache/maven/pull/909
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Restore compatibility with Maven 3 - SettingsUtils#merge
>
>
> Key: MNG-7625
> URL: https://issues.apache.org/jira/browse/MNG-7625
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-3
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Maven 3 has method:
> {code:java}
> void SettingsUtils#merge(org.apache.maven.settings.Settings,
> org.apache.maven.settings.Settings, java.lang.String)
> {code}
> It is used by {{maven-invoker-plugin}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge
[
https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646703#comment-17646703
]
Slawomir Jaranowski commented on MNG-7625:
--
[~gnodet]
I used {{org.apache.maven.settings.v4.SettingsMerger}} instead of
{{{}org.apache.maven.settings.merge.MavenSettingsMerger{}}}.
{{MavenSettingsMerger}} set {{sourceLevel}} on recessive Settings, this actions
can be done once for the same instance of object.
{{m-invoker-p}} need call merge {{Setings}} many time for each test project, as
{{recessive Settings}} use copy of current {{Settings}} from running
{{{}Session{}}}.
Copy of {{Setings}} is done by {{{}SettingsUtils#copySettings{}}}, where in the
real we have new {{Maven 3 Settings}} with references to old {{Maven 4
Settings}} as delegate.
So {{MavenSettingsMerger#merge}} will change status of delegate object and
finally current Maven Session.
I don't understand what for is {{TrackableBase#SourceLevel}} it look like is
only used by {{MavenSettingsMerger}}
We also have two implementation of merging settings - {{v4.SettingsMerger}} and
old {{MavenSettingsMerger}} - maybe one should be deprecated, and we should use
one implementation.
In m-invoker-p there is a hack for reset {{sourceLevel}}, but now is not
working because real Session is in delegate field:
https://github.com/apache/maven-invoker-plugin/blob/bfb75f9e52e93478dab710bb7243978c06f48d1a/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1580-L1618
> Restore compatibility with Maven 3 - SettingsUtils#merge
>
>
> Key: MNG-7625
> URL: https://issues.apache.org/jira/browse/MNG-7625
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-3
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Maven 3 has method:
> {code:java}
> void SettingsUtils#merge(org.apache.maven.settings.Settings,
> org.apache.maven.settings.Settings, java.lang.String)
> {code}
> It is used by {{maven-invoker-plugin}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge
gnodet commented on PR #909: URL: https://github.com/apache/maven/pull/909#issuecomment-1348858555 Also related to https://github.com/apache/maven/pull/874, which contains a similar fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge
[
https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646706#comment-17646706
]
ASF GitHub Bot commented on MNG-7625:
-
gnodet commented on PR #909:
URL: https://github.com/apache/maven/pull/909#issuecomment-1348858555
Also related to https://github.com/apache/maven/pull/874, which contains a
similar fix.
> Restore compatibility with Maven 3 - SettingsUtils#merge
>
>
> Key: MNG-7625
> URL: https://issues.apache.org/jira/browse/MNG-7625
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-3
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Maven 3 has method:
> {code:java}
> void SettingsUtils#merge(org.apache.maven.settings.Settings,
> org.apache.maven.settings.Settings, java.lang.String)
> {code}
> It is used by {{maven-invoker-plugin}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge
gnodet commented on code in PR #909:
URL: https://github.com/apache/maven/pull/909#discussion_r1047350107
##
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##
@@ -51,6 +52,25 @@ public static Settings merge(Settings dominant, Settings
recessive, String reces
return new MavenSettingsMerger().merge(dominant, recessive,
recessiveSourceLevel);
}
+/**
+ * @param dominant
+ * @param recessive
+ * @param recessiveSourceLevel
+ * @deprecated please use {@link #merge(Settings, Settings, String)}
+ */
+@Deprecated
+public static void merge(
+org.apache.maven.settings.Settings dominant,
+org.apache.maven.settings.Settings recessive,
+String recessiveSourceLevel) {
+
+if (dominant == null || recessive == null) {
+return;
+}
+
+dominant.delegate = new SettingsMerger().merge(dominant.getDelegate(),
recessive.getDelegate(), true, null);
Review Comment:
I think it should be the same than the method above:
```new MavenSettingsMerger().merge(dominant.getDelegate(),
recessive.getDelegate(), recessiveSourceLevel)``` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge
[
https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646709#comment-17646709
]
ASF GitHub Bot commented on MNG-7625:
-
gnodet commented on code in PR #909:
URL: https://github.com/apache/maven/pull/909#discussion_r1047350107
##
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##
@@ -51,6 +52,25 @@ public static Settings merge(Settings dominant, Settings
recessive, String reces
return new MavenSettingsMerger().merge(dominant, recessive,
recessiveSourceLevel);
}
+/**
+ * @param dominant
+ * @param recessive
+ * @param recessiveSourceLevel
+ * @deprecated please use {@link #merge(Settings, Settings, String)}
+ */
+@Deprecated
+public static void merge(
+org.apache.maven.settings.Settings dominant,
+org.apache.maven.settings.Settings recessive,
+String recessiveSourceLevel) {
+
+if (dominant == null || recessive == null) {
+return;
+}
+
+dominant.delegate = new SettingsMerger().merge(dominant.getDelegate(),
recessive.getDelegate(), true, null);
Review Comment:
I think it should be the same than the method above:
```new MavenSettingsMerger().merge(dominant.getDelegate(),
recessive.getDelegate(), recessiveSourceLevel)``` instead.
> Restore compatibility with Maven 3 - SettingsUtils#merge
>
>
> Key: MNG-7625
> URL: https://issues.apache.org/jira/browse/MNG-7625
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-3
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Maven 3 has method:
> {code:java}
> void SettingsUtils#merge(org.apache.maven.settings.Settings,
> org.apache.maven.settings.Settings, java.lang.String)
> {code}
> It is used by {{maven-invoker-plugin}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-invoker-plugin] slachiewicz closed pull request #153: Bump maven-plugins from 37 to 38
slachiewicz closed pull request #153: Bump maven-plugins from 37 to 38 URL: https://github.com/apache/maven-invoker-plugin/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #153: Bump maven-plugins from 37 to 38
dependabot[bot] commented on PR #153: URL: https://github.com/apache/maven-invoker-plugin/pull/153#issuecomment-1348880323 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #909: [MNG-7625] Restore compatibility with Maven 3 - SettingsUtils#merge
slawekjaranowski commented on code in PR #909:
URL: https://github.com/apache/maven/pull/909#discussion_r1047360970
##
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##
@@ -51,6 +52,25 @@ public static Settings merge(Settings dominant, Settings
recessive, String reces
return new MavenSettingsMerger().merge(dominant, recessive,
recessiveSourceLevel);
}
+/**
+ * @param dominant
+ * @param recessive
+ * @param recessiveSourceLevel
+ * @deprecated please use {@link #merge(Settings, Settings, String)}
+ */
+@Deprecated
+public static void merge(
+org.apache.maven.settings.Settings dominant,
+org.apache.maven.settings.Settings recessive,
+String recessiveSourceLevel) {
+
+if (dominant == null || recessive == null) {
+return;
+}
+
+dominant.delegate = new SettingsMerger().merge(dominant.getDelegate(),
recessive.getDelegate(), true, null);
Review Comment:
I described in issue why I use this methods.
`MavenSettingsMerger().merge()` will not work with m-invoker-p because
change state of `recessive` - which is reused ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7625) Restore compatibility with Maven 3 - SettingsUtils#merge
[
https://issues.apache.org/jira/browse/MNG-7625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646713#comment-17646713
]
ASF GitHub Bot commented on MNG-7625:
-
slawekjaranowski commented on code in PR #909:
URL: https://github.com/apache/maven/pull/909#discussion_r1047360970
##
maven-core/src/main/java/org/apache/maven/settings/SettingsUtils.java:
##
@@ -51,6 +52,25 @@ public static Settings merge(Settings dominant, Settings
recessive, String reces
return new MavenSettingsMerger().merge(dominant, recessive,
recessiveSourceLevel);
}
+/**
+ * @param dominant
+ * @param recessive
+ * @param recessiveSourceLevel
+ * @deprecated please use {@link #merge(Settings, Settings, String)}
+ */
+@Deprecated
+public static void merge(
+org.apache.maven.settings.Settings dominant,
+org.apache.maven.settings.Settings recessive,
+String recessiveSourceLevel) {
+
+if (dominant == null || recessive == null) {
+return;
+}
+
+dominant.delegate = new SettingsMerger().merge(dominant.getDelegate(),
recessive.getDelegate(), true, null);
Review Comment:
I described in issue why I use this methods.
`MavenSettingsMerger().merge()` will not work with m-invoker-p because
change state of `recessive` - which is reused ...
> Restore compatibility with Maven 3 - SettingsUtils#merge
>
>
> Key: MNG-7625
> URL: https://issues.apache.org/jira/browse/MNG-7625
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-3
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> Maven 3 has method:
> {code:java}
> void SettingsUtils#merge(org.apache.maven.settings.Settings,
> org.apache.maven.settings.Settings, java.lang.String)
> {code}
> It is used by {{maven-invoker-plugin}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-compiler-plugin] rmannibucau commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
rmannibucau commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1348932531 > that do not depend on each other, but I guess this cannot be called "majority", unless am mistaken. Depends how you build the multi-modules projects. Often you have some "core" bottleneck in the build graph then a tons of children (think camel if you want, core then most of the modules are children), then if you run a command bypassing the core - built manually before with install - then you get the benefit from it. Fully agree it would be better to not have to handle the commands manually but as of today it works and saves time - at least on some big projects I'm working on, agree it can maybe not be the most ones but since code is there I would rather go in the direction to enhance it instead of dropping it otherwise we drop most of the plugin code and plexus abstraction to purely leverage tool provider and be it for the plugin at the end - can be an option but at the opposite of current design which is to make most cases working by default/convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7626) maven-bom should have the same parent version as project
Slawomir Jaranowski created MNG-7626: Summary: maven-bom should have the same parent version as project Key: MNG-7626 URL: https://issues.apache.org/jira/browse/MNG-7626 Project: Maven Issue Type: Task Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MBUILDCACHE-35) Incorrect pom is put to local repo for module with maven-shade-plugin
Maximilian Novikov created MBUILDCACHE-35:
-
Summary: Incorrect pom is put to local repo for module with
maven-shade-plugin
Key: MBUILDCACHE-35
URL: https://issues.apache.org/jira/browse/MBUILDCACHE-35
Project: Maven Build Cache Extension
Issue Type: Bug
Reporter: Maximilian Novikov
Original reporter: spirin.an...@gmail.com
There is an issue with maven incremental build if module uses maven-shade
plugin. If user executes mvnw clean install command and module is not changed
then wrong pom file will be put into local maven repository and it will break
module dependencies.
Steps to reproduce:
# create a module with dependencies and with maven-shade plugin (see below)
# build module using incremental build: mvnw clean install (install command is
required to put artifact into local maven repo)
# change something in module to trigger incremental build (for instance some
symbols here META-INF/test-run-01.txt)
# build module again: mvnw clean install
# check that local repo has correct dependency reduced pom (ie pom file loaded
into the repo does not have dependencies org.apache.commons:commons-lang3)
{code:java}
[devbox ~/.m2/repository/com/db/test/mvnbuild/mvnbuild-test/1.0]$ ll
-rw-r--r--. 1 devbox users716 Dec 13 09:49 maven-metadata-local.xml
-rw-r--r--. 1 devbox users 584570 Dec 13 09:49 mvnbuild-test-1.0.jar
-rw-r--r--. 1 devbox users 1512 Dec 13 09:49 mvnbuild-test-1.0.pom
-rw-r--r--. 1 devbox users208 Dec 13 09:49 _remote.repositories
[devbox ~/.m2/repository/com/db/test/mvnbuild/mvnbuild-test/1.0]$ less
mvnbuild-test-1.0.pom
{code}
# do not change module and build it again: mvnw clean install
*Expected:* local repositiry should have dependency reduced pom
*Actual:* local repo has a pom file taken from source code ie with all
dependencies
As a result in class path there will be duplicated set of class files:
# from shaded module
# due to this defect from org.apache.commons:commons-lang3
*Original POM*
{code:java}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
4.0.0
com.db.test.mvnbuild
mvnbuild-test
1.0
jar
MvnTest
org.apache.commons
commons-lang3
3.11
org.apache.maven.plugins
maven-shade-plugin
3.4.1
package
shade
true
org.apache.commons:commons-lang3
*:*
META-INF/test-run-01.txt
{code}
*Dependency reduced POM*
{code:java}
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
4.0.0
com.db.test.mvnbuild
mvnbuild-test
MvnTest
1.0
maven-shade-plugin
3.4.1
package
shade
true
org.apache.commons:commons-lang3
*:*
META-INF/test-run-01.txt
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] slawekjaranowski opened a new pull request, #910: [MNG-7626] maven-bom should have the same parent version as project
slawekjaranowski opened a new pull request, #910: URL: https://github.com/apache/maven/pull/910 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-compiler-plugin] bmarwell commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
bmarwell commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1349073554 I agree with @rmannibucau here. It is very dependent of the examples and really changes your output. Let's keep the default behaviour, but maybe rename it. If I am not mistaken, it skips entire modules? In that case name it appropriately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7626) maven-bom should have the same parent version as project
[ https://issues.apache.org/jira/browse/MNG-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646742#comment-17646742 ] ASF GitHub Bot commented on MNG-7626: - slawekjaranowski opened a new pull request, #910: URL: https://github.com/apache/maven/pull/910 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > maven-bom should have the same parent version as project > > > Key: MNG-7626 > URL: https://issues.apache.org/jira/browse/MNG-7626 > Project: Maven > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-filtering] dependabot[bot] opened a new pull request, #59: Bump slf4jVersion from 1.7.36 to 2.0.6
dependabot[bot] opened a new pull request, #59: URL: https://github.com/apache/maven-filtering/pull/59 Bumps `slf4jVersion` from 1.7.36 to 2.0.6. Updates `slf4j-api` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view Updates `slf4j-simple` from 1.7.36 to 2.0.6 Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] dependabot[bot] closed pull request #58: Bump slf4jVersion from 1.7.36 to 2.0.5
dependabot[bot] closed pull request #58: Bump slf4jVersion from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-filtering/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] dependabot[bot] commented on pull request #58: Bump slf4jVersion from 1.7.36 to 2.0.5
dependabot[bot] commented on PR #58: URL: https://github.com/apache/maven-filtering/pull/58#issuecomment-1349076652 Superseded by #59. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] dependabot[bot] opened a new pull request, #128: Bump slf4j-api from 1.7.36 to 2.0.6
dependabot[bot] opened a new pull request, #128: URL: https://github.com/apache/maven-shared-utils/pull/128 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.6. Commits https://github.com/qos-ch/slf4j/commit/5ff6f2c385c36ea4f8b85cacd69f7ca891c37818";>5ff6f2c prepare for release 2.0.6 https://github.com/qos-ch/slf4j/commit/2f4aa754451167e2fef98a07f2e1260cdb08b332";>2f4aa75 fix SLF4J-575 https://github.com/qos-ch/slf4j/commit/363f0a534ea736bb02ced129f3ae27720f95c13f";>363f0a5 remove unused parts https://github.com/qos-ch/slf4j/commit/171679baa87e13cfb8ca471242da6fd0d3acbe53";>171679b SLF4J-574: Add full OSGi headers, especially "uses" clauses https://github.com/qos-ch/slf4j/commit/921b5b31e179d625d349debf15210ed067a5a153";>921b5b3 fix FUNDING file https://github.com/qos-ch/slf4j/commit/e02244c39f11cdcdb07d6b291f157e3687d5b920";>e02244c fix FUNDING file https://github.com/qos-ch/slf4j/commit/441d4584bed16ec8fe54a9c4acb8d289e51005b8";>441d458 fix FUNDING file https://github.com/qos-ch/slf4j/commit/f5e741ba1af6565269499d34c725c32ef8ca467f";>f5e741b add FUNDING file https://github.com/qos-ch/slf4j/commit/2e71327c8ee745927d731e8d9f4e51d331dad138";>2e71327 remove unused log4j dependency in the version definition section of pom.xml https://github.com/qos-ch/slf4j/commit/3ff2a30e05e5825d96ddb54da243df48f1a9d897";>3ff2a30 start work on 2.0.6-SNAPSHOT Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.6";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] dependabot[bot] commented on pull request #126: Bump slf4j-api from 1.7.36 to 2.0.5
dependabot[bot] commented on PR #126: URL: https://github.com/apache/maven-shared-utils/pull/126#issuecomment-1349539063 Superseded by #128. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] dependabot[bot] closed pull request #126: Bump slf4j-api from 1.7.36 to 2.0.5
dependabot[bot] closed pull request #126: Bump slf4j-api from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-shared-utils/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski merged pull request #156: [MINVOKER-316] Refresh plugins versions in IT tests
slawekjaranowski merged PR #156: URL: https://github.com/apache/maven-invoker-plugin/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINVOKER-316) Refresh plugins versions in IT tests
[ https://issues.apache.org/jira/browse/MINVOKER-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-316. Fix Version/s: 3.4.0 Resolution: Fixed > Refresh plugins versions in IT tests > > > Key: MINVOKER-316 > URL: https://issues.apache.org/jira/browse/MINVOKER-316 > Project: Maven Invoker Plugin > Issue Type: Task >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > > Preparing for executing by Maven 4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-compiler-plugin] olamy commented on pull request #160: [MCOMPILER-515] This plugin is not "incremental"
olamy commented on PR #160: URL: https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1349673838 > > If we ignore the figures right - highly depends your build, tomee container/openejb-core module for ex, it is 14s -> 4s (1 module so if you do the math you almost save 1h for your example ;)). > > Sure, we can come up with numbers as we like, but I will shut up in a moment this very feature saves 1h on a _real life project_ out there. > > > Kind of, "magic" happens there https://github.com/apache/maven-compiler-plugin/blob/master/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L897 and agree the rule can be enhanced to better manage multi-reactor builds, can be a great enhancement/PR to do. > > Sure, but this also means that almost no multi module build benefits from this feature, as the sole idea of multi module build is usually to "depend on each other". I can imagine some "lab" project where you have 300 modules that do not depend on each other, but I guess this cannot be called "majority", unless am mistaken. no it depends if you reach install phase or not... I tried to explain previously in this issue and this has already been discussed here https://lists.apache.org/thread/1l87rfqk7k26lgh07vt8w6367qgp3sct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7566) Allow a Maven plugin to require a Java version through its plugin descriptor
[ https://issues.apache.org/jira/browse/MNG-7566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7566. --- > Allow a Maven plugin to require a Java version through its plugin descriptor > > > Key: MNG-7566 > URL: https://issues.apache.org/jira/browse/MNG-7566 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Labels: plugin-descriptor-1.1 > Fix For: 4.0.0, 4.0.0-alpha-3 > > > Currently a Maven plugin can only require a minimum Maven version via pom's > prerequisites (https://maven.apache.org/pom.html#Prerequisites). There is > currently no means to require a minimum Java version. > I would suggest to slightly expand the plugin descriptor to include a > minimumJavaVersion element there as well and evaluate that before executing a > plugin goal and emit a good error message. The default Java version could be > determined by the target class file version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5
[
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7611.
---
> java.lang.IllegalStateException: Required Java version 1.8 is not met by
> current version: 17.0.5
>
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not
> met by current version: 17.0.5
>at
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7609) Clarify documentation of extension descriptor
[
https://issues.apache.org/jira/browse/MNG-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7609.
---
> Clarify documentation of extension descriptor
> -
>
> Key: MNG-7609
> URL: https://issues.apache.org/jira/browse/MNG-7609
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> The extension descriptor is documented in
> https://maven.apache.org/ref/3-LATEST/maven-core/extension.html based on the
> MDO file at
> https://github.com/apache/maven/blob/master/maven-core/src/main/mdo/extension.mdo.
> It is lacking important information such as
> - how are subpackages and wildcards handled in {{exportedPackages}}?
> - how can one export individual classes via {{exportedPackages}} (compare
> with
> https://github.com/apache/maven/blob/c6ecff9923088d854d4621e17d602f1c70dda806/maven-core/src/main/mdo/extension.mdo#L50)
> - how are {{exportedPackages}} and {{exportedArtifacts}} related? Are they
> just merged or are they combined in some other way?
> The better extension descriptor documentation should finally be linked also
> from
> https://github.com/apache/maven/blob/master/maven-core/src/site/apt/core-extensions.apt.vm,
> as well as from
> https://maven.apache.org/guides/mini/guide-maven-classloading.html#API_Classloader
> and https://maven.apache.org/guides/mini/guide-using-extensions.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7597) Infinite loop in PropertiesAsMap
[ https://issues.apache.org/jira/browse/MNG-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7597. --- > Infinite loop in PropertiesAsMap > > > Key: MNG-7597 > URL: https://issues.apache.org/jira/browse/MNG-7597 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #905: [MNG-7621] Parameter '-f' causes ignoring any 'maven.config' (only on…
michael-o commented on PR #905: URL: https://github.com/apache/maven/pull/905#issuecomment-1349699974 Anyone else wants to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7621) Parameter '-f' causes ignoring any 'maven.config' (only on Windows)
[
https://issues.apache.org/jira/browse/MNG-7621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646821#comment-17646821
]
ASF GitHub Bot commented on MNG-7621:
-
michael-o commented on PR #905:
URL: https://github.com/apache/maven/pull/905#issuecomment-1349699974
Anyone else wants to review?
> Parameter '-f' causes ignoring any 'maven.config' (only on Windows)
> ---
>
> Key: MNG-7621
> URL: https://issues.apache.org/jira/browse/MNG-7621
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.6.3, 3.8.6
> Environment: Windows 10 64Bit EE
> Cygwin 64Bit
>Reporter: Oliver Glowa
>Assignee: Michael Osipov
>Priority: Minor
> Labels: maven
> Fix For: 3.8.x-candidate, 3.9.0-candidate, 4.0.x-candidate
>
>
> Hello,
> first of all, I didn't find a ticket, related to the possible bug I found
> (keyword "-f" and "maven.config")
> [https://issues.apache.org/jira/issues/?jql=project%20%3D%20MNG%20AND%20text%20~%20maven.config%20AND%20text%20~%20-f]
> h1. Analysis
> Here the problem I found:
> When executing maven with parameter "-f" without a file name (e.g. "pom.xml")
> any ".mvn\maven.config" is ignored.
> {noformat}
> C:\projects\projects_github>mvn -f maven-test clean verify
> [INFO] Scanning for projects...
> [INFO]
> [INFO] < com.glowanet.appl:maven-test
> >
> [INFO] Building maven-test 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ maven-test ---
> [INFO] Deleting C:\projects\projects_github\maven-test\target
> [INFO]
> [INFO] --- echo-maven-plugin:1.3.2:echo (echo-plugin) @ maven-test ---
> [INFO] plugin active
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> maven-test ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ maven-test
> ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> C:\projects\projects_github\maven-test\target\classes
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
> maven-test ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> C:\projects\projects_github\maven-test\src\test\resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @
> maven-test ---
> [INFO] Nothing to compile - all classes are up to date
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ maven-test ---
> [INFO] No tests to run.
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ maven-test ---
> [INFO] Building jar:
> C:\projects\projects_github\maven-test\target\maven-test-1.0-SNAPSHOT.jar
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 2.063 s
> [INFO] Finished at: 2022-12-07T14:21:45+01:00
> [INFO]
>
> {noformat}
>
> When the filename is added, the "maven.config" will be recognized (the
> parameter in "maven.config" will activated the profile "profile1")
> {noformat}
> C:\projects\projects_github>mvn -f maven-test\pom.xml clean verify
> [INFO] Scanning for projects...
> [INFO]
> [INFO] < com.glowanet.appl:maven-test
> >
> [INFO] Building maven-test 1.0-SNAPSHOT
> [INFO] [ jar
> ]-
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ maven-test ---
> [INFO] Deleting C:\projects\projects_github\maven-test\target
> [INFO]
> [INFO] --- maven-help-plugin:3.3.0:active-profiles (default) @ maven-test ---
> [INFO]
> Active Profiles for Project 'com.glowanet.appl:maven-test:jar:1.0-SNAPSHOT':
> The following profiles are active:
> - profile1 (source: com.glowanet.appl:maven-test:1.0-SNAPSHOT)
> [INFO]
> [INFO] --- echo-maven-plugin:1.3.2:echo (echo-plugin) @ maven-test ---
> [INFO] plugin active
> [INFO]
> [INFO] --- echo-maven-plugin:1.3.2:echo (echo-profile) @ maven-test ---
> [INFO] profile1 active
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> maven-test ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ maven-test
> ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compi
[jira] [Comment Edited] (MNG-7563) User properties now override model properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645645#comment-17645645
]
Michael Osipov edited comment on MNG-7563 at 12/13/22 9:22 PM:
---
Let me crunch on this, [~h...@apteryx.fr]. I think we need also other comitters
to think about this. What I could maybe do is to revert this change for 3.8.7,
but I don't know whether this would be wise since it will be different in 3.9.0
and 4.x anyway. Also consider that doing {{MAVEN_OPTS=-Dver=x}} should yield
the same result even without the change. WDYT?
was (Author: michael-o):
Let me crunch on this, [~h...@apteryx.fr]. I think we need also other comitters
to think about this. What I could maybe do is to revert this change for 3.8.7,
but I don't know whether this would be wise since it will be different in 3.9.0
and 4.x anyway. Also consider that doning {{MAVEN_OPTS=-Dver=x}} should yield
the same result even without the change. WDYT?
> User properties now override model properties in dependencies
> -
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Hervé Guillemet
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing projects b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
> Note that without the setting of the default value for property {{dep}} in
> project b, the build fails with any version of Maven.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] kwin commented on pull request #351: Using an SPDX identifier as the license name in example
kwin commented on PR #351: URL: https://github.com/apache/maven-site/pull/351#issuecomment-1349743139 For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] michael-o commented on pull request #351: Using an SPDX identifier as the license name in example
michael-o commented on PR #351: URL: https://github.com/apache/maven-site/pull/351#issuecomment-1349775831 > For me id is more useful than an arbitrary label. Therefore I think we should stick to using an id in the name element (although the naming of the element is unfortunate) Real men don't wear clothes with labels, they have custom-tailored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7563) User properties now override model properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646830#comment-17646830
]
Michael Osipov commented on MNG-7563:
-
I need to revert my previous statement: {{MAVEN_OPTS}} does not change the
behavior! Looking again at the fix in here:
https://github.com/apache/maven/pull/306/files#diff-ad3fd714d4f142348b18532c5019eb27e2a3d8eb533ca5702247e86758de8db2R219-R220
is the change which cases this to be evaluated:
https://github.com/apache/maven/blob/adf89ef63ffca07e490f5cc550f9411bad1a7bd6/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L1287-L1291
The user property kicks in before your model property kicks in. In the previous
behavior both user and system properties were merged on purpose into system
properties to have a lower precedence compared to model properties.
We need now a canonical decision on how to proceed here and is right or wrong.
Neither is wrong and neither is right at the moment.
> User properties now override model properties in dependencies
> -
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Hervé Guillemet
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing projects b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
> Note that without the setting of the default value for property {{dep}} in
> project b, the build fails with any version of Maven.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MENFORCER-440) Allow 8 as JDK version for requireJavaVersion
[
https://issues.apache.org/jira/browse/MENFORCER-440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MENFORCER-440:
-
Assignee: Slawomir Jaranowski
> Allow 8 as JDK version for requireJavaVersion
> -
>
> Key: MENFORCER-440
> URL: https://issues.apache.org/jira/browse/MENFORCER-440
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
> Components: Standard Rules
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> We can use java version as {{8}} for target maven-compiler-plugin.
> In order to have simplify configuration requireJavaVersion should also
> recognize {{8}} as {{1.8}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] gnodet merged pull request #750: Clean up some warnings during the build
gnodet merged PR #750: URL: https://github.com/apache/maven-mvnd/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] slawekjaranowski merged pull request #351: Using an SPDX identifier as the license name in example
slawekjaranowski merged PR #351: URL: https://github.com/apache/maven-site/pull/351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #730: Build mostly static native image, loose linux glibc requirement to 2.12
gnodet merged PR #730: URL: https://github.com/apache/maven-mvnd/pull/730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #748: Display plugin's goal prefix and version instead of artifactId
gnodet merged PR #748: URL: https://github.com/apache/maven-mvnd/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet merged pull request #581: Support redirecting input from client to daemon, #541
gnodet merged PR #581: URL: https://github.com/apache/maven-mvnd/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-7563) User properties now override model properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646830#comment-17646830
]
Michael Osipov edited comment on MNG-7563 at 12/13/22 10:59 PM:
I need to revert my previous statement: {{MAVEN_OPTS}} does not change the
behavior! Looking again at the fix in here:
https://github.com/apache/maven/pull/306/files#diff-ad3fd714d4f142348b18532c5019eb27e2a3d8eb533ca5702247e86758de8db2R219-R220
is the change which cases this to be evaluated:
https://github.com/apache/maven/blob/adf89ef63ffca07e490f5cc550f9411bad1a7bd6/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L1287-L1291
The user property kicks in before your model property kicks in. In the previous
behavior both user and system properties were merged on purpose into system
properties to have a lower precedence compared to model properties.
We need now a canonical decision on how to proceed here and what is right or
wrong. Neither is wrong and neither is right at the moment.
was (Author: michael-o):
I need to revert my previous statement: {{MAVEN_OPTS}} does not change the
behavior! Looking again at the fix in here:
https://github.com/apache/maven/pull/306/files#diff-ad3fd714d4f142348b18532c5019eb27e2a3d8eb533ca5702247e86758de8db2R219-R220
is the change which cases this to be evaluated:
https://github.com/apache/maven/blob/adf89ef63ffca07e490f5cc550f9411bad1a7bd6/maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java#L1287-L1291
The user property kicks in before your model property kicks in. In the previous
behavior both user and system properties were merged on purpose into system
properties to have a lower precedence compared to model properties.
We need now a canonical decision on how to proceed here and is right or wrong.
Neither is wrong and neither is right at the moment.
> User properties now override model properties in dependencies
> -
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Hervé Guillemet
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing projects b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
> Note that without the setting of the default value for property {{dep}} in
> project b, the build fails with any version of Maven.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7563) User properties now override model properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646857#comment-17646857
]
Hervé Guillemet commented on MNG-7563:
--
I'm not familiar enough with maven internals to have any strong opinion about
what is the right and what is wrong here. I just reported a breaking change
that looks important to me.
But, if it helps, here are two comments:
* if the developer of an artifact wants his artifact to react to some settings
from the end user, he must configure voluntarily for this, so that it won't
happen by accident. I guess the proper way to do this is to define a profile
that could be activated using -P or maybe with a true system property.
* it's difficult for a user to understand how system property and user
property interact. I understand that this will change in Maven 4 but I don't
know how. My expectation would be that user properties somehow only concern the
model written by the user, and that system properties are somehow global to the
system. Keeping these two kind of properties separated would avoid confusion.
Sorry if I'm just stating the obvious.
> User properties now override model properties in dependencies
> -
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Hervé Guillemet
>Assignee: Michael Osipov
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing projects b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
> Note that without the setting of the default value for property {{dep}} in
> project b, the build fails with any version of Maven.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #195: [MENFORCER-440] Allow 8 as JDK version for requireJavaVersion
slawekjaranowski opened a new pull request, #195: URL: https://github.com/apache/maven-enforcer/pull/195 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MENFORCER-441) Bump maven-common-artifact-filters from 3.2.0 to 3.3.2
Slawomir Jaranowski created MENFORCER-441: - Summary: Bump maven-common-artifact-filters from 3.2.0 to 3.3.2 Key: MENFORCER-441 URL: https://issues.apache.org/jira/browse/MENFORCER-441 Project: Maven Enforcer Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #185: [MENFORCER-441] Bump maven-common-artifact-filters from 3.2.0 to 3.3.2
slawekjaranowski merged PR #185: URL: https://github.com/apache/maven-enforcer/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MENFORCER-441) Bump maven-common-artifact-filters from 3.2.0 to 3.3.2
[ https://issues.apache.org/jira/browse/MENFORCER-441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-441. - Resolution: Fixed > Bump maven-common-artifact-filters from 3.2.0 to 3.3.2 > -- > > Key: MENFORCER-441 > URL: https://issues.apache.org/jira/browse/MENFORCER-441 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] gnodet merged pull request #721: Fixup #716 Calculate java home from java command
gnodet merged PR #721: URL: https://github.com/apache/maven-mvnd/pull/721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] slawekjaranowski merged pull request #49: [MINSTALL-186] Use proper repositorySystemSession
slawekjaranowski merged PR #49: URL: https://github.com/apache/maven-install-plugin/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINSTALL-186) install-file fails when the file belongs to the local repository and using a localRepositoryPath
[
https://issues.apache.org/jira/browse/MINSTALL-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MINSTALL-186:
Assignee: Slawomir Jaranowski
> install-file fails when the file belongs to the local repository and using a
> localRepositoryPath
>
>
> Key: MINSTALL-186
> URL: https://issues.apache.org/jira/browse/MINSTALL-186
> Project: Maven Install Plugin
> Issue Type: Bug
> Components: install:install-file
>Affects Versions: 3.0.1, 3.1.0
>Reporter: Romain Bioteau
>Assignee: Slawomir Jaranowski
>Priority: Trivial
>
> To reproduce:
> Assuming maven-deploy-plugin 3.0.0 EXISTS in your local repository:
> {code:bash}
> ❯ mvn org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file
> -Dfile=$HOME/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar
> -DlocalRepositoryPath=/tmp/repo -Dversion=3.0.0
> -DartifactId=maven-deploy-plugin -DgroupId=org.apache.maven.plugins -Dtype=jar
> [INFO] Scanning for projects...
> [INFO]
> [INFO] --< org.apache.maven:standalone-pom
> >---
> [INFO] Building Maven Stub Project (No POM) 1
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- maven-install-plugin:3.1.0:install-file (default-cli) @
> standalone-pom ---
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.164 s
> [INFO] Finished at: 2022-11-25T19:12:32+01:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file
> (default-cli) on project standalone-pom: Cannot install artifact. Artifact is
> already in the local repository.
> [ERROR]
> [ERROR] File in question is:
> /home/romain/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar
> [ERROR]
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MINSTALL-186) install-file fails when the file belongs to the local repository and using a localRepositoryPath
[
https://issues.apache.org/jira/browse/MINSTALL-186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MINSTALL-186.
Fix Version/s: next-release
Resolution: Fixed
> install-file fails when the file belongs to the local repository and using a
> localRepositoryPath
>
>
> Key: MINSTALL-186
> URL: https://issues.apache.org/jira/browse/MINSTALL-186
> Project: Maven Install Plugin
> Issue Type: Bug
> Components: install:install-file
>Affects Versions: 3.0.1, 3.1.0
>Reporter: Romain Bioteau
>Assignee: Slawomir Jaranowski
>Priority: Trivial
> Fix For: next-release
>
>
> To reproduce:
> Assuming maven-deploy-plugin 3.0.0 EXISTS in your local repository:
> {code:bash}
> ❯ mvn org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file
> -Dfile=$HOME/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar
> -DlocalRepositoryPath=/tmp/repo -Dversion=3.0.0
> -DartifactId=maven-deploy-plugin -DgroupId=org.apache.maven.plugins -Dtype=jar
> [INFO] Scanning for projects...
> [INFO]
> [INFO] --< org.apache.maven:standalone-pom
> >---
> [INFO] Building Maven Stub Project (No POM) 1
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- maven-install-plugin:3.1.0:install-file (default-cli) @
> standalone-pom ---
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.164 s
> [INFO] Finished at: 2022-11-25T19:12:32+01:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-install-plugin:3.1.0:install-file
> (default-cli) on project standalone-pom: Cannot install artifact. Artifact is
> already in the local repository.
> [ERROR]
> [ERROR] File in question is:
> /home/romain/.m2/repository/org/apache/maven/plugins/maven-deploy-plugin/3.0.0/maven-deploy-plugin-3.0.0.jar
> [ERROR]
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central
Lenny Primak created MNG-7627: - Summary: Maven release plugin doesn't upload artifacts to maven central Key: MNG-7627 URL: https://issues.apache.org/jira/browse/MNG-7627 Project: Maven Issue Type: Bug Affects Versions: 4.0.0-alpha-2 Reporter: Lenny Primak Maven release plugin not working with 4.0-alpha-2 3.x works fine with the same configuration. Build succeeds but the staging repository on maven central is not uploaded -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646878#comment-17646878 ] Slawomir Jaranowski commented on MNG-7627: -- Can you deploy your project in snapshot version by Maven 4 to remote repository? Can you provide some logs ... errors ... etc > Maven release plugin doesn't upload artifacts to maven central > -- > > Key: MNG-7627 > URL: https://issues.apache.org/jira/browse/MNG-7627 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Lenny Primak >Priority: Blocker > > Maven release plugin not working with 4.0-alpha-2 > 3.x works fine with the same configuration. > Build succeeds but the staging repository on maven central is not uploaded -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central
[
https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646884#comment-17646884
]
Lenny Primak commented on MNG-7627:
---
Yes, snapshots deploy fine with Maven 4.
There are no errors, the nexus-staging-maven-plugin is just not getting invoked
from maven release plugin in Maven 4.
See below, the log from maven 3. Maven 4 just stops (successfully) and doesn't
produce logs like the ones below.
{code:java}
[INFO] [INFO] --- nexus-staging-maven-plugin:1.6.13:deploy
(injected-nexus-deploy) @ jee-examples ---
[INFO] [INFO] Performing local staging (local
stagingDirectory="/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging")...
[INFO] [INFO] + Using server credentials "flowlogix-maven-central" from Maven
settings.
[INFO] [INFO] * Connected to Nexus at https://oss.sonatype.org:443/, is
version 2.15.1-02 and edition "Professional"
[INFO] [INFO] * Using staging profile ID "1019fa80512c9" (matched by Nexus).
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/target/jee-examples-5.2.0-M1.war
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1.war
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/pom.xml
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1.pom
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/target/jee-examples-5.2.0-M1-sources.jar
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1-sources.jar
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/target/jee-examples-5.2.0-M1-javadoc.jar
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1-javadoc.jar
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/target/jee-examples-5.2.0-M1-sources.jar.asc
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1-sources.jar.asc
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/target/jee-examples-5.2.0-M1.pom.asc
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1.pom.asc
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/target/jee-examples-5.2.0-M1-javadoc.jar.asc
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1-javadoc.jar.asc
[INFO] [INFO] Installing
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/jakarta-ee/jee-examples/target/jee-examples-5.2.0-M1.war.asc
to
/Users/software/var/jenkins/workspace/flowlogix-ee-release_main/target/checkout/target/nexus-staging/staging/1019fa80512c9/com/flowlogix/jee-examples/5.2.0-M1/jee-examples-5.2.0-M1.war.asc
[INFO] [INFO] Performing remote staging...
[INFO] [INFO]
[INFO] [INFO] * Remote staging into staging profile ID "1019fa80512c9"
[INFO] [INFO] * Created staging repository with ID "comflowlogix-1164".
[INFO] [INFO] * Staging repository at
https://oss.sonatype.org:443/service/local/staging/deployByRepositoryId/comflowlogix-1164
[INFO] [INFO] * Uploading locally staged artifacts to profile com.flowlogix
[INFO] [INFO] Uploading to flowlogix-maven-central:
https://oss.sonatype.org:443/service/local/staging/deployByRepositoryId/comflowlogix-1164/com/flowlogix/flowlogix-jee/5.2.0-M1/flowlogix-jee-5.2.0-M1.jar.asc
[INFO] [INFO] Uploaded to flowlogix-maven-central:
https://oss.sonatype.org:443/service/local/stagi {code}
> Maven release plugin doesn't upload artifacts to maven central
> --
>
> Key: MNG-7627
> URL: https://issues.apache.org/jira/browse/MNG-7627
> Project: Maven
>
[jira] [Created] (MNG-7628) help:all-profiles doesn't work if there are any profiles in setting.xml
Lenny Primak created MNG-7628:
-
Summary: help:all-profiles doesn't work if there are any profiles
in setting.xml
Key: MNG-7628
URL: https://issues.apache.org/jira/browse/MNG-7628
Project: Maven
Issue Type: Bug
Affects Versions: 4.0.0-alpha-2
Reporter: Lenny Primak
As in title, if any profiles are defined in user's settings.xml, the below
error is produced
{code:java}
% mvn help:all-profiles -N
[INFO] Scanning for projects...
[INFO] Inspecting build with total of 1 modules...
[INFO] Installing Nexus Staging features:
[INFO] ... total of 1 executions of maven-deploy-plugin replaced with
nexus-staging-maven-plugin
[INFO]
[INFO] ---< com.flowlogix:flowlogix
>
[INFO] Building Flow Logix Root 5.x-SNAPSHOT
[INFO] from pom.xml
[INFO] -[ pom
]--
[INFO]
[INFO] --- maven-help-plugin:3.3.0:all-profiles (default-cli) @ flowlogix ---
[INFO]
--
[INFO] BUILD FAILURE
[INFO]
--
[INFO] Total time: 2.041 s
[INFO] Finished at: 2022-12-13T18:51:46-06:00
[INFO]
--
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-help-plugin:3.3.0:all-profiles (default-cli) on
project flowlogix: Execution default-cli of goal
org.apache.maven.plugins:maven-help-plugin:3.3.0:all-profiles failed: An API
incompatibility was encountered while executing
org.apache.maven.plugins:maven-help-plugin:3.3.0:all-profiles:
java.lang.NoSuchMethodError: 'org.apache.maven.model.Profile
org.apache.maven.settings.SettingsUtils.convertFromSettingsProfile(org.apache.maven.settings.Profile)'
[ERROR] -
[ERROR] realm = plugin>org.apache.maven.plugins:maven-help-plugin:3.3.0
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] =
file:/Users/lprimak/.m2/repository/org/apache/maven/plugins/maven-help-plugin/3.3.0/maven-help-plugin-3.3.0.jar
[ERROR] urls[1] =
file:/Users/lprimak/.m2/repository/org/apache/maven/plugin-tools/maven-plugin-tools-generators/3.6.4/maven-plugin-tools-generators-3.6.4.jar
[ERROR] urls[2] =
file:/Users/lprimak/.m2/repository/org/apache/maven/plugin-tools/maven-plugin-tools-api/3.6.4/maven-plugin-tools-api-3.6.4.jar
[ERROR] urls[3] =
file:/Users/lprimak/.m2/repository/org/codehaus/plexus/plexus-velocity/1.2/plexus-velocity-1.2.jar
[ERROR] urls[4] =
file:/Users/lprimak/.m2/repository/commons-collections/commons-collections/3.1/commons-collections-3.1.jar
[ERROR] urls[5] =
file:/Users/lprimak/.m2/repository/org/apache/velocity/velocity/1.7/velocity-1.7.jar
[ERROR] urls[6] =
file:/Users/lprimak/.m2/repository/commons-lang/commons-lang/2.4/commons-lang-2.4.jar
[ERROR] urls[7] =
file:/Users/lprimak/.m2/repository/net/sf/jtidy/jtidy/r938/jtidy-r938.jar
[ERROR] urls[8] =
file:/Users/lprimak/.m2/repository/org/ow2/asm/asm/9.3/asm-9.3.jar
[ERROR] urls[9] =
file:/Users/lprimak/.m2/repository/org/ow2/asm/asm-commons/9.3/asm-commons-9.3.jar
[ERROR] urls[10] =
file:/Users/lprimak/.m2/repository/org/ow2/asm/asm-tree/9.3/asm-tree-9.3.jar
[ERROR] urls[11] =
file:/Users/lprimak/.m2/repository/org/ow2/asm/asm-analysis/9.3/asm-analysis-9.3.jar
[ERROR] urls[12] =
file:/Users/lprimak/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.3.4/maven-shared-utils-3.3.4.jar
[ERROR] urls[13] =
file:/Users/lprimak/.m2/repository/commons-io/commons-io/2.6/commons-io-2.6.jar
[ERROR] urls[14] =
file:/Users/lprimak/.m2/repository/org/apache/maven/reporting/maven-reporting-api/3.1.1/maven-reporting-api-3.1.1.jar
[ERROR] urls[15] =
file:/Users/lprimak/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.11.1/doxia-sink-api-1.11.1.jar
[ERROR] urls[16] =
file:/Users/lprimak/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.11.1/doxia-logging-api-1.11.1.jar
[ERROR] urls[17] =
file:/Users/lprimak/.m2/repository/org/apache/maven/reporting/maven-reporting-exec/1.6.0/maven-reporting-exec-1.6.0.jar
[ERROR] urls[18] =
file:/Users/lprimak/.m2/repository/javax/enterprise/cdi-api/1.2/cdi-api-1.2.jar
[ERROR] urls[19] =
file:/Users/lprimak/.m2/repository/org/eclipse/sisu/org.eclipse.sisu.inject/0.3.5/org.eclipse.sisu.inject-0.3.5.jar
[ERROR] urls[20] =
file:/Users/lprimak/.m2/repository/org/sonatype/sisu/sisu-guice/3.2.3/sisu-guice-3.2.3-no_aop.jar
[ERROR] urls[21] =
file:/Users/lprimak/.m2/repository/aopalliance/aopalliance/1.0/aopalliance-1.0.jar
[ERROR] ur
[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646893#comment-17646893 ] Lenny Primak commented on MNG-7627: --- I have bumped down the priority to minor since there is a workaround > Maven release plugin doesn't upload artifacts to maven central > -- > > Key: MNG-7627 > URL: https://issues.apache.org/jira/browse/MNG-7627 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Lenny Primak >Priority: Minor > > Maven release plugin not working with 4.0-alpha-2 > 3.x works fine with the same configuration. > Build succeeds but the staging repository on maven central is not uploaded -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646892#comment-17646892 ] Lenny Primak commented on MNG-7627: --- It looks like that nexus-staging-maven-plugin has some magic to replace maven deploy plugin to do deferred deploys, and that magic breaks in maven 4. I was able to work around the problem by disabling maven deploy plugin and adding execution steps to the nexus staging plugin to make deferred uploads work > Maven release plugin doesn't upload artifacts to maven central > -- > > Key: MNG-7627 > URL: https://issues.apache.org/jira/browse/MNG-7627 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Lenny Primak >Priority: Blocker > > Maven release plugin not working with 4.0-alpha-2 > 3.x works fine with the same configuration. > Build succeeds but the staging repository on maven central is not uploaded -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7627) Maven release plugin doesn't upload artifacts to maven central
[ https://issues.apache.org/jira/browse/MNG-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lenny Primak updated MNG-7627: -- Priority: Minor (was: Blocker) > Maven release plugin doesn't upload artifacts to maven central > -- > > Key: MNG-7627 > URL: https://issues.apache.org/jira/browse/MNG-7627 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Lenny Primak >Priority: Minor > > Maven release plugin not working with 4.0-alpha-2 > 3.x works fine with the same configuration. > Build succeeds but the staging repository on maven central is not uploaded -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPOM-386) update documentation for previous changes
Herve Boutemy created MPOM-386: -- Summary: update documentation for previous changes Key: MPOM-386 URL: https://issues.apache.org/jira/browse/MPOM-386 Project: Maven POMs Issue Type: Bug Components: asf Affects Versions: ASF-29 Reporter: Herve Boutemy a few updates done in past releases were not updated in the documentation https://maven.apache.org/pom/asf/: - MPOM-378: license identifier - MPOM-347: addition of distMgmtReleases* properties like Snapshots ones - MPOM-243: maven-release-plugin profile configuration -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-apache-parent] hboutemy opened a new pull request, #121: [MPOM-386] update documentation to match previous changes in pom.xml
hboutemy opened a new pull request, #121: URL: https://github.com/apache/maven-apache-parent/pull/121 https://issues.apache.org/jira/browse/MPOM-386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
