[GitHub] [maven] gnodet merged pull request #872: [MNG-7597] Fix infinite loop when iterating PropertiesAsMap
gnodet merged PR #872: URL: https://github.com/apache/maven/pull/872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7597) Infinite loop in PropertiesAsMap
[ https://issues.apache.org/jira/browse/MNG-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636526#comment-17636526 ] ASF GitHub Bot commented on MNG-7597: - gnodet merged PR #872: URL: https://github.com/apache/maven/pull/872 > Infinite loop in PropertiesAsMap > > > Key: MNG-7597 > URL: https://issues.apache.org/jira/browse/MNG-7597 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MNG-7597) Infinite loop in PropertiesAsMap
[ https://issues.apache.org/jira/browse/MNG-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved MNG-7597. -- Resolution: Fixed > Infinite loop in PropertiesAsMap > > > Key: MNG-7597 > URL: https://issues.apache.org/jira/browse/MNG-7597 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #874: [MNG-7598] Enforce binary backwards-compatibility
gnodet commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1321706362 I think it needs to be enabled on not only maven-core. It's missing stuff like https://github.com/apache/maven/pull/841/files#diff-a660bdaa2e580478c65a557fd7001c80e129c0e9d4766840b4072c3b72c1863f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636558#comment-17636558 ] ASF GitHub Bot commented on MNG-7598: - gnodet commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1321706362 I think it needs to be enabled on not only maven-core. It's missing stuff like https://github.com/apache/maven/pull/841/files#diff-a660bdaa2e580478c65a557fd7001c80e129c0e9d4766840b4072c3b72c1863f > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #841: [MNG-7576] Restore compatibility with maven 3.x
gnodet merged PR #841: URL: https://github.com/apache/maven/pull/841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7576) Restore compatibility with maven 3
[
https://issues.apache.org/jira/browse/MNG-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636559#comment-17636559
]
ASF GitHub Bot commented on MNG-7576:
-
gnodet merged PR #841:
URL: https://github.com/apache/maven/pull/841
> Restore compatibility with maven 3
> --
>
> Key: MNG-7576
> URL: https://issues.apache.org/jira/browse/MNG-7576
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {{MavenBuildTimestamp}}
> https://github.com/apache/maven/commit/18eff3baeb899ddd27b34635c8f0d7e47f5c027b
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #852: [MNG-7580] Introduce new SettingsBuilder and ToolchainsBuilder services
gnodet merged PR #852: URL: https://github.com/apache/maven/pull/852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7580) New settings and toolchains builders
[ https://issues.apache.org/jira/browse/MNG-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636560#comment-17636560 ] ASF GitHub Bot commented on MNG-7580: - gnodet merged PR #852: URL: https://github.com/apache/maven/pull/852 > New settings and toolchains builders > > > Key: MNG-7580 > URL: https://issues.apache.org/jira/browse/MNG-7580 > Project: Maven > Issue Type: Task >Affects Versions: 4.0.0-alpha-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-7580) New settings and toolchains builders
[ https://issues.apache.org/jira/browse/MNG-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7580. Resolution: Fixed > New settings and toolchains builders > > > Key: MNG-7580 > URL: https://issues.apache.org/jira/browse/MNG-7580 > Project: Maven > Issue Type: Task >Affects Versions: 4.0.0-alpha-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] cstamas opened a new pull request, #736: Resolver 1.9.0
cstamas opened a new pull request, #736: URL: https://github.com/apache/maven-mvnd/pull/736 Resolver 1.9.0 has a breaking change MRESOLVER-284 that was later undone (in 1.9.1+). Hence, the CLI changes are needd ONLY for 1.9.0 and shall be removed on upgrade to later version. Still, the patch is incomplete, as it merely sets mvnd specific defaults, but does not allow mvnd users to override locking (to HZ/redisson for example). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #876: [MNG-7600] LocalRepositoryManager is created too early
slawekjaranowski commented on PR #876: URL: https://github.com/apache/maven/pull/876#issuecomment-1321713867 > So this basically changes position to have a chance to access all properties... exactly > Does this qualify for 3.9.0? yes, as mentioned in issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early
[
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636562#comment-17636562
]
ASF GitHub Bot commented on MNG-7600:
-
slawekjaranowski commented on PR #876:
URL: https://github.com/apache/maven/pull/876#issuecomment-1321713867
> So this basically changes position to have a chance to access all
properties...
exactly
> Does this qualify for 3.9.0?
yes, as mentioned in issue
> LocalRepositoryManager is created too early
> ---
>
> Key: MNG-7600
> URL: https://issues.apache.org/jira/browse/MNG-7600
> Project: Maven
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations from
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during
> {{LocalRepositoryManager}} preparation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin commented on pull request #874: [MNG-7598] Enforce binary backwards-compatibility
kwin commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1321722446 This is just a start for sure to allow us to incrementally merge. Let us first fix Core and Plugin API and then follow-up with subsequent PRs for the other modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636567#comment-17636567 ] ASF GitHub Bot commented on MNG-7598: - kwin commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1321722446 This is just a start for sure to allow us to incrementally merge. Let us first fix Core and Plugin API and then follow-up with subsequent PRs for the other modules. > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7597) Infinite loop in PropertiesAsMap
[ https://issues.apache.org/jira/browse/MNG-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636571#comment-17636571 ] Hudson commented on MNG-7597: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #132 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/132/ > Infinite loop in PropertiesAsMap > > > Key: MNG-7597 > URL: https://issues.apache.org/jira/browse/MNG-7597 > Project: Maven > Issue Type: Bug >Affects Versions: 4.0.0-alpha-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] cstamas commented on pull request #736: Resolver 1.9.0
cstamas commented on PR #736: URL: https://github.com/apache/maven-mvnd/pull/736#issuecomment-1321743302 Hm, this patch was originally made against mvnd 0.9.0 and it worked well. On master it seems both resolver get into dist (so both, resolver 1.8.2 and 1.9.0) and it causes havoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7576) Restore compatibility with maven 3
[
https://issues.apache.org/jira/browse/MNG-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636580#comment-17636580
]
Hudson commented on MNG-7576:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #133
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/133/
> Restore compatibility with maven 3
> --
>
> Key: MNG-7576
> URL: https://issues.apache.org/jira/browse/MNG-7576
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {{MavenBuildTimestamp}}
> https://github.com/apache/maven/commit/18eff3baeb899ddd27b34635c8f0d7e47f5c027b
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7580) New settings and toolchains builders
[ https://issues.apache.org/jira/browse/MNG-7580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636581#comment-17636581 ] Hudson commented on MNG-7580: - Build failed in Jenkins: Maven » Maven TLP » maven » master #134 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/134/ > New settings and toolchains builders > > > Key: MNG-7580 > URL: https://issues.apache.org/jira/browse/MNG-7580 > Project: Maven > Issue Type: Task >Affects Versions: 4.0.0-alpha-2 >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #843: Move back model version from 5.0 to 4.2 and reactivate modello site generation
gnodet commented on code in PR #843: URL: https://github.com/apache/maven/pull/843#discussion_r1027808865 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -2598,7 +2618,7 @@ - 5.0.0+ + 4.2.0 Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #843: Move back model version from 5.0 to 4.2 and reactivate modello site generation
gnodet commented on code in PR #843: URL: https://github.com/apache/maven/pull/843#discussion_r1027809681 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -434,7 +434,7 @@ - 5.0.0+ + 4.2.0 Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #843: Move back model version from 5.0 to 4.2 and reactivate modello site generation
gnodet commented on code in PR #843: URL: https://github.com/apache/maven/pull/843#discussion_r1027815693 ## maven-model/pom.xml: ## @@ -79,18 +79,38 @@ under the License. modello-plugin-velocity -velocity +velocity-v3 generate-sources velocity - 4.0.0 + 4.1.0 Review Comment: > I would still propose we use 4.0.1 and 4.0.2 to be more in line with semantic versioning as IMHO the API does not change at all! I kinda disagree. If you use the 4.2.0 model removes some additional custom java code which makes the model generated by 4.1.0 and 4.2.0 already incompatible. So the xml schema is compatible, but not the generated model. I would think this warrant at least a minor increment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSITE-914) SiteMojo never populates Doxia Sitetools Site Renderer supportedLocales Velocity context property
[
https://issues.apache.org/jira/browse/MSITE-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSITE-914.
Resolution: Fixed
Fixed with
[867f8ebd884cf2c2463c1bf1eb906ac7a3aab2f6|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=867f8ebd884cf2c2463c1bf1eb906ac7a3aab2f6].
> SiteMojo never populates Doxia Sitetools Site Renderer supportedLocales
> Velocity context property
> -
>
> Key: MSITE-914
> URL: https://issues.apache.org/jira/browse/MSITE-914
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration, internationalization, localization
>Affects Versions: 3.12.1, 4.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M4
>
>
> {{supportedLocales}} is expected to be put in the Velocity context in Doxia
> Sitetools Site Renderer:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/index.html
> site plugin requires to set the value for Site Renderer to use it, it's not
> magic: "support locales" in the case of m-site-p is the list of locales that
> has been configured by the user (it's not the full set of locales the JVM
> supports, for example)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site-plugin] asfgit merged pull request #111: [MSITE-914] SiteMojo never populates supportedLocales Velocity contex…
asfgit merged PR #111: URL: https://github.com/apache/maven-site-plugin/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-914) SiteMojo never populates Doxia Sitetools Site Renderer supportedLocales Velocity context property
[
https://issues.apache.org/jira/browse/MSITE-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636632#comment-17636632
]
ASF GitHub Bot commented on MSITE-914:
--
asfgit merged PR #111:
URL: https://github.com/apache/maven-site-plugin/pull/111
> SiteMojo never populates Doxia Sitetools Site Renderer supportedLocales
> Velocity context property
> -
>
> Key: MSITE-914
> URL: https://issues.apache.org/jira/browse/MSITE-914
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration, internationalization, localization
>Affects Versions: 3.12.1, 4.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M4
>
>
> {{supportedLocales}} is expected to be put in the Velocity context in Doxia
> Sitetools Site Renderer:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/index.html
> site plugin requires to set the value for Site Renderer to use it, it's not
> magic: "support locales" in the case of m-site-p is the list of locales that
> has been configured by the user (it's not the full set of locales the JVM
> supports, for example)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSITE-914) SiteMojo never populates Doxia Sitetools Site Renderer supportedLocales Velocity context property
[
https://issues.apache.org/jira/browse/MSITE-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636633#comment-17636633
]
Hudson commented on MSITE-914:
--
Build succeeded in Jenkins: Maven » Maven TLP » maven-site-plugin » master #46
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site-plugin/job/master/46/
> SiteMojo never populates Doxia Sitetools Site Renderer supportedLocales
> Velocity context property
> -
>
> Key: MSITE-914
> URL: https://issues.apache.org/jira/browse/MSITE-914
> Project: Maven Site Plugin
> Issue Type: Bug
> Components: doxia integration, internationalization, localization
>Affects Versions: 3.12.1, 4.0.0-M3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M4
>
>
> {{supportedLocales}} is expected to be put in the Velocity context in Doxia
> Sitetools Site Renderer:
> https://maven.apache.org/doxia/doxia-sitetools/doxia-site-renderer/index.html
> site plugin requires to set the value for Site Renderer to use it, it's not
> magic: "support locales" in the case of m-site-p is the list of locales that
> has been configured by the user (it's not the full set of locales the JVM
> supports, for example)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIASITETOOLS-272) Remove support for Maven 1.x style site directory layout
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-272: -- Fix Version/s: 2.0.0-M5 (was: 2.0.0-M4) > Remove support for Maven 1.x style site directory layout > > > Key: DOXIASITETOOLS-272 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-272 > Project: Maven Doxia Sitetools > Issue Type: Task > Components: Site renderer >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M5 > > > TBD > (search for 'Maven 1' in source and remove everything related) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MDEP-835) dependency:tree no longer shows optional flag
Chesnay Schepler created MDEP-835:
-
Summary: dependency:tree no longer shows optional flag
Key: MDEP-835
URL: https://issues.apache.org/jira/browse/MDEP-835
Project: Maven Dependency Plugin
Issue Type: Bug
Components: tree
Affects Versions: 3.3.0
Reporter: Chesnay Schepler
In 3.2.0 the optional flag of a dependency was shown in the dependency:tree
output, which is no longer the case in 3.3.0.
3.2.0 behavior:
{code:java}
$ mvn dependency:tree -N
[INFO] org.apache.flink:flink-parent:pom:1.17-SNAPSHOT
[INFO] +- org.apache.flink:flink-shaded-force-shading:jar:15.0:compile
(optional)
{code}
3.3.0 behavior:
{code:java}
$ mvn dependency:tree -N
[INFO] org.apache.flink:flink-parent:pom:1.17-SNAPSHOT
[INFO] +- org.apache.flink:flink-shaded-force-shading:jar:15.0:compile
{code}
Meanwhile, dependency:list/resolve still show the optional flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-895) PropertiesUtil closes streams it doesn't create
[ https://issues.apache.org/jira/browse/MSHARED-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636694#comment-17636694 ] Michael Osipov commented on MSHARED-895: The PR has been merged. Is this one addressed? > PropertiesUtil closes streams it doesn't create > --- > > Key: MSHARED-895 > URL: https://issues.apache.org/jira/browse/MSHARED-895 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Priority: Minor > Labels: intern > > specifically the methods loadOptionalProperties(InputStream inputStream ) and > loadProperties(InputStream inputStream ) > > see discussion on https://github.com/apache/maven-shared-utils/pull/41 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1160) Upgrade Maven Reporting API to 4.0.0-M3
Michael Osipov created MSHARED-1160: --- Summary: Upgrade Maven Reporting API to 4.0.0-M3 Key: MSHARED-1160 URL: https://issues.apache.org/jira/browse/MSHARED-1160 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-impl Reporter: Michael Osipov Fix For: maven-reporting-impl-4.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1161) Upgrade Doxia to 2.0.0-M4
Michael Osipov created MSHARED-1161: --- Summary: Upgrade Doxia to 2.0.0-M4 Key: MSHARED-1161 URL: https://issues.apache.org/jira/browse/MSHARED-1161 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-api Reporter: Michael Osipov Assignee: Michael Osipov Fix For: maven-reporting-api-4.0.0-M3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1161) Upgrade Doxia to 2.0.0-M4
[ https://issues.apache.org/jira/browse/MSHARED-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-1161. --- Resolution: Fixed Fixed with [e3c292a801982306100cbecca92f9a1930ba8ec7|https://gitbox.apache.org/repos/asf?p=maven-reporting-api.git&a=commit&h=e3c292a801982306100cbecca92f9a1930ba8ec7]. > Upgrade Doxia to 2.0.0-M4 > - > > Key: MSHARED-1161 > URL: https://issues.apache.org/jira/browse/MSHARED-1161 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1161) Upgrade Doxia to 2.0.0-M4
[ https://issues.apache.org/jira/browse/MSHARED-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636698#comment-17636698 ] Hudson commented on MSHARED-1161: - Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-api » master #23 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-api/job/master/23/ > Upgrade Doxia to 2.0.0-M4 > - > > Key: MSHARED-1161 > URL: https://issues.apache.org/jira/browse/MSHARED-1161 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-reporting-api >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-reporting-api-4.0.0-M3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1159) Require locale to be not null
[
https://issues.apache.org/jira/browse/MSHARED-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MSHARED-1159.
---
Resolution: Fixed
Fixed with
[861127007c4f331a55fa1f96b3dc46b1ec8cda9f|https://gitbox.apache.org/repos/asf?p=maven-reporting-api.git&a=commit&h=861127007c4f331a55fa1f96b3dc46b1ec8cda9f].
> Require locale to be not null
> -
>
> Key: MSHARED-1159
> URL: https://issues.apache.org/jira/browse/MSHARED-1159
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-reporting-api
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M3
>
>
> Doxia Sitetools changes the behavior to require a locale. If no locale is
> desired the default locale ({{Locale#ROOT}}) will be internally assumed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1159) Require locale to be not null
[
https://issues.apache.org/jira/browse/MSHARED-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636706#comment-17636706
]
Hudson commented on MSHARED-1159:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-api » master #24
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-api/job/master/24/
> Require locale to be not null
> -
>
> Key: MSHARED-1159
> URL: https://issues.apache.org/jira/browse/MSHARED-1159
> Project: Maven Shared Components
> Issue Type: Task
> Components: maven-reporting-api
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-api-4.0.0-M3
>
>
> Doxia Sitetools changes the behavior to require a locale. If no locale is
> desired the default locale ({{Locale#ROOT}}) will be internally assumed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request, #191: Bump maven-dependency-tree from 3.1.1 to 3.2.1
dependabot[bot] opened a new pull request, #191: URL: https://github.com/apache/maven-enforcer/pull/191 Bumps [maven-dependency-tree](https://github.com/apache/maven-dependency-tree) from 3.1.1 to 3.2.1. Release notes Sourced from https://github.com/apache/maven-dependency-tree/releases";>maven-dependency-tree's releases. 3.2.1 🚀 New features and improvements https://issues.apache.org/jira/browse/MSHARED-1158";>[MSHARED-1158] - make DependencyCollectorBuilder more configurable (https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/28";>#28) https://github.com/olamy";>@olamy 3.2.0 Releas notes: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12351759";>https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12351759 Commits https://github.com/apache/maven-dependency-tree/commit/8cc44f65ec4fd29b84403df6b972fc028508aca6";>8cc44f6 [maven-release-plugin] prepare release maven-dependency-tree-3.2.1 https://github.com/apache/maven-dependency-tree/commit/2ef02cecb94fa8b6f17437970040df950da2ba17";>2ef02ce [MSHARED-1158] make DependencyCollectorBuilder nore configurable (https://github-redirect.dependabot.com/apache/maven-dependency-tree/issues/28";>#28) https://github.com/apache/maven-dependency-tree/commit/fa81a70f7c6e3e37b77f57896156051273c0b2f3";>fa81a70 add Reproducible Builds badge https://github.com/apache/maven-dependency-tree/commit/20bd06803749f1689014198b8bdf854aaf36f1b7";>20bd068 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-dependency-tree/commit/a1db75c9da781ab67f508f099f6e74ae921002f2";>a1db75c [maven-release-plugin] prepare release maven-dependency-tree-3.2.0 https://github.com/apache/maven-dependency-tree/commit/fa5a3a10c0ee7c766a67c67b2ac7a3bcc0647598";>fa5a3a1 Use plugins build template on Jenkins https://github.com/apache/maven-dependency-tree/commit/2f88228bfcc191a02a0c17a5dc5bff28a828045f";>2f88228 Bump project version before release https://github.com/apache/maven-dependency-tree/commit/deb4cd1f7f6184c9509a79e77e8ccc6f5e23";>deb4cd1 Update dependabot.yml https://github.com/apache/maven-dependency-tree/commit/80cadf4b910cd3f8b649342ef84477c6b24be4c2";>80cadf4 [MSHARED-1071] Drop maven 3.0 compatibility, Maven 3.2.5, Injects https://github.com/apache/maven-dependency-tree/commit/3f425fead0d4f4624f47472cb4159b45e544ebba";>3f425fe Use GitHub shared action v3 Additional commits viewable in https://github.com/apache/maven-dependency-tree/compare/maven-dependency-tree-3.1.1...maven-dependency-tree-3.2.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] dependabot[bot] commented on pull request #182: Bump maven-dependency-tree from 3.1.1 to 3.2.0
dependabot[bot] commented on PR #182: URL: https://github.com/apache/maven-enforcer/pull/182#issuecomment-139838 Superseded by #191. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] dependabot[bot] closed pull request #182: Bump maven-dependency-tree from 3.1.1 to 3.2.0
dependabot[bot] closed pull request #182: Bump maven-dependency-tree from 3.1.1 to 3.2.0 URL: https://github.com/apache/maven-enforcer/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski merged pull request #876: [MNG-7600] LocalRepositoryManager is created too early
slawekjaranowski merged PR #876: URL: https://github.com/apache/maven/pull/876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early
[
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636743#comment-17636743
]
ASF GitHub Bot commented on MNG-7600:
-
slawekjaranowski merged PR #876:
URL: https://github.com/apache/maven/pull/876
> LocalRepositoryManager is created too early
> ---
>
> Key: MNG-7600
> URL: https://issues.apache.org/jira/browse/MNG-7600
> Project: Maven
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations from
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during
> {{LocalRepositoryManager}} preparation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-reporting-api] michael-o commented on pull request #14: Bump doxia-sink-api from 2.0.0-M3 to 2.0.0-M4
michael-o commented on PR #14: URL: https://github.com/apache/maven-reporting-api/pull/14#issuecomment-1322265791 Superseded by e3c292a801982306100cbecca92f9a1930ba8ec7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-reporting-api] michael-o closed pull request #14: Bump doxia-sink-api from 2.0.0-M3 to 2.0.0-M4
michael-o closed pull request #14: Bump doxia-sink-api from 2.0.0-M3 to 2.0.0-M4 URL: https://github.com/apache/maven-reporting-api/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-reporting-api] dependabot[bot] commented on pull request #14: Bump doxia-sink-api from 2.0.0-M3 to 2.0.0-M4
dependabot[bot] commented on PR #14: URL: https://github.com/apache/maven-reporting-api/pull/14#issuecomment-1322265863 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-835) dependency:tree no longer shows optional flag
[
https://issues.apache.org/jira/browse/MDEP-835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636745#comment-17636745
]
Michael Osipov commented on MDEP-835:
-
Can you verify this also with a snapshot of current master?
> dependency:tree no longer shows optional flag
> -
>
> Key: MDEP-835
> URL: https://issues.apache.org/jira/browse/MDEP-835
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: tree
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> In 3.2.0 the optional flag of a dependency was shown in the dependency:tree
> output, which is no longer the case in 3.3.0.
> 3.2.0 behavior:
> {code:java}
> $ mvn dependency:tree -N
> [INFO] org.apache.flink:flink-parent:pom:1.17-SNAPSHOT
> [INFO] +- org.apache.flink:flink-shaded-force-shading:jar:15.0:compile
> (optional)
> {code}
> 3.3.0 behavior:
> {code:java}
> $ mvn dependency:tree -N
> [INFO] org.apache.flink:flink-parent:pom:1.17-SNAPSHOT
> [INFO] +- org.apache.flink:flink-shaded-force-shading:jar:15.0:compile
> {code}
> Meanwhile, dependency:list/resolve still show the optional flag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early
[
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636788#comment-17636788
]
Hudson commented on MNG-7600:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #135
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/135/
> LocalRepositoryManager is created too early
> ---
>
> Key: MNG-7600
> URL: https://issues.apache.org/jira/browse/MNG-7600
> Project: Maven
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations from
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during
> {{LocalRepositoryManager}} preparation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-895) PropertiesUtil closes streams it doesn't create
[ https://issues.apache.org/jira/browse/MSHARED-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636847#comment-17636847 ] Elliotte Rusty Harold commented on MSHARED-895: --- No, that's just where this issue was first noticed. It's a tricky one to address because it will change behavior. That PR added a warning that behavior is likely to change in the future. > PropertiesUtil closes streams it doesn't create > --- > > Key: MSHARED-895 > URL: https://issues.apache.org/jira/browse/MSHARED-895 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Priority: Minor > Labels: intern > > specifically the methods loadOptionalProperties(InputStream inputStream ) and > loadProperties(InputStream inputStream ) > > see discussion on https://github.com/apache/maven-shared-utils/pull/41 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNGSITE-499) Publish build-cache-extension schemas
Guillaume Nodet created MNGSITE-499: --- Summary: Publish build-cache-extension schemas Key: MNGSITE-499 URL: https://issues.apache.org/jira/browse/MNGSITE-499 Project: Maven Project Web Site Issue Type: New Feature Reporter: Guillaume Nodet Assignee: Guillaume Nodet -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] slawekjaranowski opened a new pull request, #879: [MNG-7600] LocalRepositoryManager is created too early
slawekjaranowski opened a new pull request, #879: URL: https://github.com/apache/maven/pull/879 LocalRepositoryManager needs configurations from RepositorySystemSession so must be created after session configuration is finished. (cherry picked from commit b1c1f7556d6b66d984c4ed2c0eb723c9b99b38be) --- Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early
[
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636874#comment-17636874
]
ASF GitHub Bot commented on MNG-7600:
-
slawekjaranowski opened a new pull request, #879:
URL: https://github.com/apache/maven/pull/879
LocalRepositoryManager needs configurations from RepositorySystemSession so
must be created after session configuration is finished.
(cherry picked from commit b1c1f7556d6b66d984c4ed2c0eb723c9b99b38be)
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> LocalRepositoryManager is created too early
> ---
>
> Key: MNG-7600
> URL: https://issues.apache.org/jira/browse/MNG-7600
> Project: Maven
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations from
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during
> {{LocalRepositoryManager}} preparation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #265: Bump maven-dependency-tree from 3.2.0 to 3.2.1
dependabot[bot] opened a new pull request, #265: URL: https://github.com/apache/maven-dependency-plugin/pull/265 Bumps [maven-dependency-tree](https://github.com/apache/maven-dependency-tree) from 3.2.0 to 3.2.1. Release notes Sourced from https://github.com/apache/maven-dependency-tree/releases";>maven-dependency-tree's releases. 3.2.1 🚀 New features and improvements https://issues.apache.org/jira/browse/MSHARED-1158";>[MSHARED-1158] - make DependencyCollectorBuilder more configurable (https://github-redirect.dependabot.com/apache/maven-dependency-tree/pull/28";>#28) https://github.com/olamy";>@olamy Commits https://github.com/apache/maven-dependency-tree/commit/8cc44f65ec4fd29b84403df6b972fc028508aca6";>8cc44f6 [maven-release-plugin] prepare release maven-dependency-tree-3.2.1 https://github.com/apache/maven-dependency-tree/commit/2ef02cecb94fa8b6f17437970040df950da2ba17";>2ef02ce [MSHARED-1158] make DependencyCollectorBuilder nore configurable (https://github-redirect.dependabot.com/apache/maven-dependency-tree/issues/28";>#28) https://github.com/apache/maven-dependency-tree/commit/fa81a70f7c6e3e37b77f57896156051273c0b2f3";>fa81a70 add Reproducible Builds badge https://github.com/apache/maven-dependency-tree/commit/20bd06803749f1689014198b8bdf854aaf36f1b7";>20bd068 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-dependency-tree/compare/maven-dependency-tree-3.2.0...maven-dependency-tree-3.2.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski merged pull request #879: [MNG-7600] LocalRepositoryManager is created too early
slawekjaranowski merged PR #879: URL: https://github.com/apache/maven/pull/879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early
[
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636919#comment-17636919
]
ASF GitHub Bot commented on MNG-7600:
-
slawekjaranowski merged PR #879:
URL: https://github.com/apache/maven/pull/879
> LocalRepositoryManager is created too early
> ---
>
> Key: MNG-7600
> URL: https://issues.apache.org/jira/browse/MNG-7600
> Project: Maven
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations from
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during
> {{LocalRepositoryManager}} preparation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7600) LocalRepositoryManager is created too early
[
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MNG-7600.
Resolution: Fixed
> LocalRepositoryManager is created too early
> ---
>
> Key: MNG-7600
> URL: https://issues.apache.org/jira/browse/MNG-7600
> Project: Maven
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations from
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during
> {{LocalRepositoryManager}} preparation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] dependabot[bot] opened a new pull request, #341: Bump plantuml from 1.2022.12 to 1.2022.13
dependabot[bot] opened a new pull request, #341: URL: https://github.com/apache/maven-site/pull/341 Bumps plantuml from 1.2022.12 to 1.2022.13. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MDEP-809) Javadoc was not updated to reflect that :tree's verbose option is now ok
[ https://issues.apache.org/jira/browse/MDEP-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MDEP-809: Assignee: Slawomir Jaranowski > Javadoc was not updated to reflect that :tree's verbose option is now ok > > > Key: MDEP-809 > URL: https://issues.apache.org/jira/browse/MDEP-809 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: tree >Affects Versions: 3.3.0 >Reporter: Francois MAROT >Assignee: Slawomir Jaranowski >Priority: Trivial > > The TreeMojo's verbose option has been broken for a while but was corrected a > while ago. Nevertheless, the javadoc has not been updated to reflect that it > is useable again. > Many people, including me, may have been discouraged to use it due to this > broken javadoc. > ThomGeg has wrote here an extensive history analysis to what happened: > https://github.com/CycloneDX/cyclonedx-maven-plugin/pull/187#issuecomment-1130859621 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #257: [MDEP-674] Add IDE build support
slawekjaranowski commented on code in PR #257: URL: https://github.com/apache/maven-dependency-plugin/pull/257#discussion_r1028605831 ## src/main/java/org/apache/maven/plugins/dependency/AbstractDependencyMojo.java: ## @@ -59,6 +60,21 @@ @Component private ArchiverManager archiverManager; + +/** + * For IDE build support + */ +@Component +private BuildContext buildContext; + +/** + * Skip plugin execution during incremental builds (e.g. triggered from M2E). + * + * @since 3.3.1 Review Comment: will be 3.4.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7600) LocalRepositoryManager is created too early
[
https://issues.apache.org/jira/browse/MNG-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636932#comment-17636932
]
Hudson commented on MNG-7600:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #85
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/85/
> LocalRepositoryManager is created too early
> ---
>
> Key: MNG-7600
> URL: https://issues.apache.org/jira/browse/MNG-7600
> Project: Maven
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3
>
>
> {{LocalRepositoryManager}} needs configurations from
> {{RepositorySystemSession}}
> so must be created after session configuration is finished.
> In other case only System properties will be available during
> {{LocalRepositoryManager}} preparation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #265: Bump maven-dependency-tree from 3.2.0 to 3.2.1
slawekjaranowski merged PR #265: URL: https://github.com/apache/maven-dependency-plugin/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MDEP-822) Bump maven-dependency-tree from 3.1.0 to 3.2.1
[ https://issues.apache.org/jira/browse/MDEP-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-822: - Summary: Bump maven-dependency-tree from 3.1.0 to 3.2.1 (was: Bump maven-dependency-tree from 3.1.0 to 3.2.0) > Bump maven-dependency-tree from 3.1.0 to 3.2.1 > -- > > Key: MDEP-822 > URL: https://issues.apache.org/jira/browse/MDEP-822 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-resources-plugin] olamy opened a new pull request, #40: remove specific IDE m2e files
olamy opened a new pull request, #40: URL: https://github.com/apache/maven-resources-plugin/pull/40 those files are specific to m2e they shouldn;t be stored in the Apache Maven sources Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MRESOURCES) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MRESOURCES-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MRESOURCES-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] olamy opened a new pull request, #192: remove specific IDE m2e files
olamy opened a new pull request, #192: URL: https://github.com/apache/maven-enforcer/pull/192 those files are specific to m2e they shouldn;t be stored in the Apache Maven sources! Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] olamy commented on pull request #192: remove specific IDE m2e files
olamy commented on PR #192: URL: https://github.com/apache/maven-enforcer/pull/192#issuecomment-1322916281 cc @HannesWell @kwin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] olamy commented on pull request #40: remove specific IDE m2e files
olamy commented on PR #40: URL: https://github.com/apache/maven-resources-plugin/pull/40#issuecomment-1322915721 cc @HannesWell @kwin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7211) [WARNING] The requested profile "ABCDEF" could not be activated because it does not exist.
[
https://issues.apache.org/jira/browse/MNG-7211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636982#comment-17636982
]
Miroslav Zaťko commented on MNG-7211:
-
same behavior in version 3.8.6
> [WARNING] The requested profile "ABCDEF" could not be activated because it
> does not exist.
> --
>
> Key: MNG-7211
> URL: https://issues.apache.org/jira/browse/MNG-7211
> Project: Maven
> Issue Type: Bug
> Components: Core, Profiles
>Affects Versions: 3.8.1
>Reporter: Miroslav Zaťko
>Assignee: Robert Scholte
>Priority: Major
>
> WARNING comes at end of build log if profile is defined in settings.xml (it
> definitely does exist) and even more, I am deactivating it, not activating...
> {code:bash}
> mvn -P!ABCDEF clean test
> {code}
> in fact, profile is deactivated during build so everything goes as expected,
> except misleading message
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] zhaoyunxing92 opened a new issue, #737: After turning on debug, I hope there will be a hint
zhaoyunxing92 opened a new issue, #737: URL: https://github.com/apache/maven-mvnd/issues/737 I don't know if the startup is successful after I turn it on, and the port is not released after I disconnect it. ### Just like the following ``` shell ➜ todo git:(main) ✗ mvnDebug clean compile Preparing to execute Maven in debug mode Listening for transport dt_socket at address: 8000 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] mbien commented on a diff in pull request #255: [MINDEXER-151] Speed up Index update from remote
mbien commented on code in PR #255:
URL: https://github.com/apache/maven-indexer/pull/255#discussion_r1028796299
##
indexer-core/src/main/java/org/apache/maven/index/updater/IndexDataReader.java:
##
@@ -88,44 +133,175 @@ public IndexDataReadResult readIndex( IndexWriter w,
IndexingContext context )
int n = 0;
Document doc;
-Set rootGroups = new LinkedHashSet<>();
-Set allGroups = new LinkedHashSet<>();
+ConcurrentMap rootGroups = new ConcurrentHashMap<>();
+ConcurrentMap allGroups = new ConcurrentHashMap<>();
while ( ( doc = readDocument() ) != null )
{
-ArtifactInfo ai = IndexUtils.constructArtifactInfo( doc, context );
-if ( ai != null )
+addToIndex( doc, context, w, rootGroups, allGroups );
+n++;
+}
+
+w.commit();
+
+IndexDataReadResult result = new IndexDataReadResult();
+result.setDocumentCount( n );
+result.setTimestamp( date );
+result.setRootGroups( rootGroups.keySet() );
+result.setAllGroups( allGroups.keySet() );
+
+LOGGER.debug( "Reading ST index done in {} sec", Duration.between(
start, Instant.now() ).getSeconds() );
+return result;
+}
+
+private IndexDataReadResult readIndexMT( IndexWriter w, IndexingContext
context )
+throws IOException
+{
+LOGGER.debug( "Reading MT index..." );
+Instant start = Instant.now();
+long timestamp = readHeader();
+
+int n = 0;
+
+final Document theEnd = new Document();
+
+ConcurrentMap rootGroups = new ConcurrentHashMap<>();
+ConcurrentMap allGroups = new ConcurrentHashMap<>();
+ArrayBlockingQueue queue = new ArrayBlockingQueue<>( 1 );
+
+ExecutorService executorService = Executors.newFixedThreadPool(
threads );
+ArrayList errors = new ArrayList<>();
+ArrayList silos = new ArrayList<>( threads );
+for ( int i = 0; i < threads; i++ )
+{
+final int silo = i;
+silos.add( tempWriter( "silo" + i ) );
+executorService.execute( () ->
{
-w.addDocument( IndexUtils.updateDocument( doc, context, false,
ai ) );
+LOGGER.debug( "Starting thread {}",
Thread.currentThread().getName() );
+try
+{
+while ( true )
+{
+try
+{
+Document doc = queue.take();
+if ( doc == theEnd )
+{
+break;
+}
+addToIndex( doc, context, silos.get( silo ),
rootGroups, allGroups );
+}
+catch ( InterruptedException | IOException e )
+{
+errors.add( e );
+break;
+}
+}
+}
+finally
+{
+LOGGER.debug( "Done thread {}",
Thread.currentThread().getName() );
+}
+} );
+}
-rootGroups.add( ai.getRootGroup() );
-allGroups.add( ai.getGroupId() );
-}
-else if ( doc.getField( ArtifactInfo.ALL_GROUPS ) != null
-|| doc.getField( ArtifactInfo.ROOT_GROUPS ) != null )
+try
+{
+Document doc;
+while ( ( doc = readDocument() ) != null )
{
-// skip it
+queue.put( doc );
+n++;
}
-else
+LOGGER.debug( "Signalling END" );
+for ( int i = 0; i < threads; i++ )
{
-w.addDocument( doc );
+queue.put( theEnd );
}
-n++;
+
+LOGGER.debug( "Shutting down threads" );
+executorService.shutdown();
+executorService.awaitTermination( 5L, TimeUnit.MINUTES );
+}
+catch ( InterruptedException e )
+{
+throw new IOException( "Interrupted", e );
+}
+
+if ( !errors.isEmpty() )
+{
+IOException exception = new IOException( "Error during load of
index" );
+errors.forEach( exception::addSuppressed );
+throw exception;
+}
+
+LOGGER.debug( "Silos loaded..." );
+Date date = null;
+if ( timestamp != -1 )
+{
+date = new Date( timestamp );
+IndexUtils.updateTimestamp( w.getDirectory(), date );
}
+LOGGER.debug( "Merging silos..." );
+for ( IndexWriter silo : silos )
+{
+IndexUtils.close( silo );
+w.addIndexes( silo.getDirectory() );
+}
[GitHub] [maven-indexer] mbien commented on a diff in pull request #255: [MINDEXER-151] Speed up Index update from remote
mbien commented on code in PR #255:
URL: https://github.com/apache/maven-indexer/pull/255#discussion_r1028796299
##
indexer-core/src/main/java/org/apache/maven/index/updater/IndexDataReader.java:
##
@@ -88,44 +133,175 @@ public IndexDataReadResult readIndex( IndexWriter w,
IndexingContext context )
int n = 0;
Document doc;
-Set rootGroups = new LinkedHashSet<>();
-Set allGroups = new LinkedHashSet<>();
+ConcurrentMap rootGroups = new ConcurrentHashMap<>();
+ConcurrentMap allGroups = new ConcurrentHashMap<>();
while ( ( doc = readDocument() ) != null )
{
-ArtifactInfo ai = IndexUtils.constructArtifactInfo( doc, context );
-if ( ai != null )
+addToIndex( doc, context, w, rootGroups, allGroups );
+n++;
+}
+
+w.commit();
+
+IndexDataReadResult result = new IndexDataReadResult();
+result.setDocumentCount( n );
+result.setTimestamp( date );
+result.setRootGroups( rootGroups.keySet() );
+result.setAllGroups( allGroups.keySet() );
+
+LOGGER.debug( "Reading ST index done in {} sec", Duration.between(
start, Instant.now() ).getSeconds() );
+return result;
+}
+
+private IndexDataReadResult readIndexMT( IndexWriter w, IndexingContext
context )
+throws IOException
+{
+LOGGER.debug( "Reading MT index..." );
+Instant start = Instant.now();
+long timestamp = readHeader();
+
+int n = 0;
+
+final Document theEnd = new Document();
+
+ConcurrentMap rootGroups = new ConcurrentHashMap<>();
+ConcurrentMap allGroups = new ConcurrentHashMap<>();
+ArrayBlockingQueue queue = new ArrayBlockingQueue<>( 1 );
+
+ExecutorService executorService = Executors.newFixedThreadPool(
threads );
+ArrayList errors = new ArrayList<>();
+ArrayList silos = new ArrayList<>( threads );
+for ( int i = 0; i < threads; i++ )
+{
+final int silo = i;
+silos.add( tempWriter( "silo" + i ) );
+executorService.execute( () ->
{
-w.addDocument( IndexUtils.updateDocument( doc, context, false,
ai ) );
+LOGGER.debug( "Starting thread {}",
Thread.currentThread().getName() );
+try
+{
+while ( true )
+{
+try
+{
+Document doc = queue.take();
+if ( doc == theEnd )
+{
+break;
+}
+addToIndex( doc, context, silos.get( silo ),
rootGroups, allGroups );
+}
+catch ( InterruptedException | IOException e )
+{
+errors.add( e );
+break;
+}
+}
+}
+finally
+{
+LOGGER.debug( "Done thread {}",
Thread.currentThread().getName() );
+}
+} );
+}
-rootGroups.add( ai.getRootGroup() );
-allGroups.add( ai.getGroupId() );
-}
-else if ( doc.getField( ArtifactInfo.ALL_GROUPS ) != null
-|| doc.getField( ArtifactInfo.ROOT_GROUPS ) != null )
+try
+{
+Document doc;
+while ( ( doc = readDocument() ) != null )
{
-// skip it
+queue.put( doc );
+n++;
}
-else
+LOGGER.debug( "Signalling END" );
+for ( int i = 0; i < threads; i++ )
{
-w.addDocument( doc );
+queue.put( theEnd );
}
-n++;
+
+LOGGER.debug( "Shutting down threads" );
+executorService.shutdown();
+executorService.awaitTermination( 5L, TimeUnit.MINUTES );
+}
+catch ( InterruptedException e )
+{
+throw new IOException( "Interrupted", e );
+}
+
+if ( !errors.isEmpty() )
+{
+IOException exception = new IOException( "Error during load of
index" );
+errors.forEach( exception::addSuppressed );
+throw exception;
+}
+
+LOGGER.debug( "Silos loaded..." );
+Date date = null;
+if ( timestamp != -1 )
+{
+date = new Date( timestamp );
+IndexUtils.updateTimestamp( w.getDirectory(), date );
}
+LOGGER.debug( "Merging silos..." );
+for ( IndexWriter silo : silos )
+{
+IndexUtils.close( silo );
+w.addIndexes( silo.getDirectory() );
+}
[GitHub] [maven] kwin commented on a diff in pull request #843: Move back model version from 5.0 to 4.2 and reactivate modello site generation
kwin commented on code in PR #843: URL: https://github.com/apache/maven/pull/843#discussion_r1028897749 ## maven-model/pom.xml: ## @@ -79,18 +79,38 @@ under the License. modello-plugin-velocity -velocity +velocity-v3 generate-sources velocity - 4.0.0 + 4.1.0 Review Comment: I can follow this argument, but this will also change the generated XSD namespace which is IMHO not acceptable (no longer compatible with Maven Central) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #732: MacOS - CTRL + C Will Not Release Port
gnodet commented on issue #732: URL: https://github.com/apache/maven-mvnd/issues/732#issuecomment-1323168406 Which port is not released exactly ? `mvnd` starts reusable daemon processes, so the communication between the client and the server is done through a port. If that's the one you're talking about, that's an expected behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #737: After turning on debug, I hope there will be a hint
gnodet commented on issue #737: URL: https://github.com/apache/maven-mvnd/issues/737#issuecomment-1323174921 I agree a hint would be welcomed. For the port, I also agree that given the port number is fixed, it would be preferable to release it. The problem is that debug mode is turned on at for the JVM and I don't think there's a way to enable/disable remote debugging dynamically, which would mean the daemon would have to be killed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #731: maven dependency plugin missing pom: mvnd gives error <=> stock mvn warning
gnodet commented on issue #731: URL: https://github.com/apache/maven-mvnd/issues/731#issuecomment-1323177006 @taclano could you provide a reproducer ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet commented on a diff in pull request #34: [MBUILDCACHE-25] Fixes N+1 cache processings for forked executions
gnodet commented on code in PR #34: URL: https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1028932294 ## src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java: ## @@ -81,6 +81,7 @@ public class CacheConfigImpl implements org.apache.maven.buildcache.xml.CacheCon public static final String CONFIG_PATH_PROPERTY_NAME = "maven.build.cache.configPath"; public static final String CACHE_ENABLED_PROPERTY_NAME = "maven.build.cache.enabled"; public static final String CACHE_LOCATION_PROPERTY_NAME = "maven.build.cache.location"; +public static final String REMOTE_URL_PROPERTY_NAME = "maven.build.cache.remoteUrl"; Review Comment: Are those changes related to this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-25) Project processed multiple time in presence of forked executions
[
https://issues.apache.org/jira/browse/MBUILDCACHE-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637025#comment-17637025
]
ASF GitHub Bot commented on MBUILDCACHE-25:
---
gnodet commented on code in PR #34:
URL:
https://github.com/apache/maven-build-cache-extension/pull/34#discussion_r1028932294
##
src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java:
##
@@ -81,6 +81,7 @@ public class CacheConfigImpl implements
org.apache.maven.buildcache.xml.CacheCon
public static final String CONFIG_PATH_PROPERTY_NAME =
"maven.build.cache.configPath";
public static final String CACHE_ENABLED_PROPERTY_NAME =
"maven.build.cache.enabled";
public static final String CACHE_LOCATION_PROPERTY_NAME =
"maven.build.cache.location";
+public static final String REMOTE_URL_PROPERTY_NAME =
"maven.build.cache.remoteUrl";
Review Comment:
Are those changes related to this PR ?
> Project processed multiple time in presence of forked executions
>
>
> Key: MBUILDCACHE-25
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-25
> Project: Maven Build Cache Extension
> Issue Type: Bug
>Reporter: Alexander Ashitkin
>Priority: Minor
> Labels: pull-request-available
>
> In forked executions present in build, project goes through full lifecycle
> multiple times - one time for project itself + 1 time for each forked
> execution (could be 5, 10 - depends on configuration):
> * checksum will be calculated multiple times
> * artifacts uploaded multiple times
> The issue is manifested by multiple cache calculation log records for the
> same project:
> {noformat}
> LOGGER.info( "Going to calculate checksum for project [groupId=" +
> project.getGroupId()
> + ", artifactId=" + project.getArtifactId() + "]" );{noformat}
> The issue initially observed with PMD and Spotbugs plugins
> h3. Impact
> No functional impact observed, just unnecessary performance penalty on cache
> h3. Cause
> For every forked execution MojoExecutor clones project per forked execution.
> Each forked project goes through full cache lifecycle:
> {code:java}
> // public List executeForkedExecutions( MojoExecution
> mojoExecution, MavenSession session,
>ProjectIndex projectIndex )
> throws LifecycleExecutionException
> {
> ...
> Map> forkedExecutions =
> mojoExecution.getForkedExecutions();
> if ( !forkedExecutions.isEmpty() )
> {
> ...
> try
> {
> for ( Map.Entry> fork :
> forkedExecutions.entrySet() )
> {
> MavenProject executedProject = forkedProject.clone();
> forkedProject.setExecutionProject( executedProject );
> List mojoExecutions = fork.getValue();
> ...
> try
> {
> ...
> // here cloned project enters cache as a standalone
> project
> execute( session, mojoExecutions, projectIndex );{code}
> Additional notes: the cloning doesn't affect effective pome, so checksum is
> stable and the same in all calculations
> Proposed solution: reuse calculated inputs from cache
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MBUILDCACHE-33) Support remote cache credentials from environment variables
[ https://issues.apache.org/jira/browse/MBUILDCACHE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637030#comment-17637030 ] Guillaume Nodet commented on MBUILDCACHE-33: [~alex_ashitkin] I fail to see how this issue is specific to maven-build-cache-extension. If the credentials mechanism in maven is somehow flawed, it should be fixed in maven, rather than for each specific plugin/extension I'd think. > Support remote cache credentials from environment variables > > > Key: MBUILDCACHE-33 > URL: https://issues.apache.org/jira/browse/MBUILDCACHE-33 > Project: Maven Build Cache Extension > Issue Type: New Feature >Reporter: Alexander Ashitkin >Priority: Major > Labels: pull-request-available > > In my current environment settings.xml are managed by a build team which is > not allowing any modification because the same build service is used by all > teams. Atop of that, maven build runs in a fresh container which doesn't have > any credentials injected for security reasons. Because of that cache cannot > read/deploy build artifacts to an authenticated http server. Still, our build > service allows to inject credentials from environment variables into build > container. Need to support cache setup without settings.xml by injecting > environment variables: > * MAVEN_BUILD_CACHE_DIRECT_CONNECT > * MAVEN_BUILD_CACHE_USER > * MAVEN_BUILD_CACHE_PASSWORD > * MAVEN_BUILD_CACHE_PROXY_USER > * MAVEN_BUILD_CACHE_PROXY_PASSWORD -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MBUILDCACHE-33) Support remote cache credentials from environment variables
[
https://issues.apache.org/jira/browse/MBUILDCACHE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637030#comment-17637030
]
Guillaume Nodet edited comment on MBUILDCACHE-33 at 11/22/22 7:00 AM:
--
[~alex_ashitkin] I fail to see how this issue is specific to
maven-build-cache-extension. If the credentials mechanism in maven is somehow
flawed, it should be fixed in maven, rather than for each specific
plugin/extension I'd think.
I think a per-project {{settings.xml}} has been proposed. Wouldn't that solve
the problem ?
was (Author: gnt):
[~alex_ashitkin] I fail to see how this issue is specific to
maven-build-cache-extension. If the credentials mechanism in maven is somehow
flawed, it should be fixed in maven, rather than for each specific
plugin/extension I'd think.
> Support remote cache credentials from environment variables
>
>
> Key: MBUILDCACHE-33
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-33
> Project: Maven Build Cache Extension
> Issue Type: New Feature
>Reporter: Alexander Ashitkin
>Priority: Major
> Labels: pull-request-available
>
> In my current environment settings.xml are managed by a build team which is
> not allowing any modification because the same build service is used by all
> teams. Atop of that, maven build runs in a fresh container which doesn't have
> any credentials injected for security reasons. Because of that cache cannot
> read/deploy build artifacts to an authenticated http server. Still, our build
> service allows to inject credentials from environment variables into build
> container. Need to support cache setup without settings.xml by injecting
> environment variables:
> * MAVEN_BUILD_CACHE_DIRECT_CONNECT
> * MAVEN_BUILD_CACHE_USER
> * MAVEN_BUILD_CACHE_PASSWORD
> * MAVEN_BUILD_CACHE_PROXY_USER
> * MAVEN_BUILD_CACHE_PROXY_PASSWORD
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #262: Bump mockito-core from 4.8.1 to 4.9.0
slawekjaranowski merged PR #262: URL: https://github.com/apache/maven-dependency-plugin/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MDEP-825) Bump mockito-core from 4.7.0 to 4.9.0
[ https://issues.apache.org/jira/browse/MDEP-825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MDEP-825: - Summary: Bump mockito-core from 4.7.0 to 4.9.0 (was: Bump mockito-core from 4.7.0 to 4.8.0) > Bump mockito-core from 4.7.0 to 4.9.0 > - > > Key: MDEP-825 > URL: https://issues.apache.org/jira/browse/MDEP-825 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
