gnodet commented on code in PR #843:
URL: https://github.com/apache/maven/pull/843#discussion_r1027815693
##########
maven-model/pom.xml:
##########
@@ -79,18 +79,38 @@ under the License.
<artifactId>modello-plugin-velocity</artifactId>
<executions>
<execution>
- <id>velocity</id>
+ <id>velocity-v3</id>
<phase>generate-sources</phase>
<goals>
<goal>velocity</goal>
</goals>
<configuration>
- <version>4.0.0</version>
+ <version>4.1.0</version>
Review Comment:
> I would still propose we use 4.0.1 and 4.0.2 to be more in line with
semantic versioning as IMHO the API does not change at all!
I kinda disagree. If you use the 4.2.0 model removes some additional custom
java code which makes the model generated by 4.1.0 and 4.2.0 already
incompatible. So the xml schema is compatible, but not the generated model. I
would think this warrant at least a minor increment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
