[GitHub] [maven-jdeps-plugin] bmarwell commented on a diff in pull request #6: [MJDEPS-28] replace travisCI with github actions

2022-10-27 Thread GitBox


bmarwell commented on code in PR #6:
URL: https://github.com/apache/maven-jdeps-plugin/pull/6#discussion_r1006515035


##
.github/workflows/maven.yml:
##
@@ -15,19 +15,16 @@
 # specific language governing permissions and limitations
 # under the License.
 
-language: java
-sudo: false
+name: Verify
 
-cache:
-  directories:
-  - "$HOME/.m2"
+on:
+  push:
+  pull_request:
 
 jobs:
-  include:
-  - stage: test
-jdk: openjdk11
-script: mvn verify -Prun-its
-
-branches:
-  only:
-  - master
+  build:
+name: Verify
+uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-plugin-tools] gnodet merged pull request #164: [MPLUGIN-422] Upgrade to plexus-utils 3.5.0

2022-10-27 Thread GitBox


gnodet merged PR #164:
URL: https://github.com/apache/maven-plugin-tools/pull/164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MPLUGIN-422) Upgrade plexus-utils to 3.5.0

2022-10-27 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MPLUGIN-422:

Summary: Upgrade plexus-utils to 3.5.0  (was: Upgrade plexus-utils to 3.4.2)

> Upgrade plexus-utils to 3.5.0
> -
>
> Key: MPLUGIN-422
> URL: https://issues.apache.org/jira/browse/MPLUGIN-422
> Project: Maven Plugin Tools
>  Issue Type: Dependency upgrade
>Reporter: Guillaume Nodet
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPLUGIN-422) Upgrade plexus-utils to 3.5.0

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624943#comment-17624943
 ] 

ASF GitHub Bot commented on MPLUGIN-422:


gnodet merged PR #164:
URL: https://github.com/apache/maven-plugin-tools/pull/164




> Upgrade plexus-utils to 3.5.0
> -
>
> Key: MPLUGIN-422
> URL: https://issues.apache.org/jira/browse/MPLUGIN-422
> Project: Maven Plugin Tools
>  Issue Type: Dependency upgrade
>Reporter: Guillaume Nodet
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] gnodet commented on pull request #165: Use latest m-p-p and m-p-report-p also for the site of m-plugin-tools

2022-10-27 Thread GitBox


gnodet commented on PR #165:
URL: 
https://github.com/apache/maven-plugin-tools/pull/165#issuecomment-1293159998

   > @gnodet Any idea how to make this work?
   
   I have this exception:
   ```
   INFO] 
   [INFO] --- maven-plugin-plugin:3.7.1-SNAPSHOT:helpmojo (generated-helpmojo) 
@ maven-plugin-plugin ---
   [INFO] Downloading from apache.snapshots: 
https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-plugin-plugin/3.7.1-SNAPSHOT/maven-plugin-plugin-3.7.1-20221026.201321-13.pom
   [INFO] Downloaded from apache.snapshots: 
https://repository.apache.org/snapshots/org/apache/maven/plugins/maven-plugin-plugin/3.7.1-SNAPSHOT/maven-plugin-plugin-3.7.1-20221026.201321-13.pom
 (11 kB at 72 kB/s)
   [WARN] The POM for 
org.apache.maven.plugins:maven-plugin-plugin:jar:3.7.1-20221026.201321-13 is 
invalid, transitive dependencies (if any) will not be available, enable verbose 
output (-X) for more details
   [WARN] Error injecting: org.apache.maven.plugin.plugin.HelpGeneratorMojo
   java.lang.NoClassDefFoundError: 
org/apache/maven/tools/plugin/generator/GeneratorException
at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
   ```
   I don't think we can have the plugin being packaged with itself.  Maven has 
to load the jar, but it has not been built yet.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-422) Upgrade plexus-utils to 3.5.0

2022-10-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624946#comment-17624946
 ] 

Hudson commented on MPLUGIN-422:


Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #74

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/74/

> Upgrade plexus-utils to 3.5.0
> -
>
> Key: MPLUGIN-422
> URL: https://issues.apache.org/jira/browse/MPLUGIN-422
> Project: Maven Plugin Tools
>  Issue Type: Dependency upgrade
>Reporter: Guillaume Nodet
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #165: Use latest m-p-p and m-p-report-p also for the site of m-plugin-tools

2022-10-27 Thread GitBox


slawekjaranowski commented on code in PR #165:
URL: 
https://github.com/apache/maven-plugin-tools/pull/165#discussion_r1006550210


##
pom.xml:
##
@@ -325,6 +325,22 @@
 false
   
 
+
+  org.apache.maven.plugins
+  maven-plugin-plugin
+  ${project.version}
+  
+./apidocs/
+
+  
https://docs.oracle.com/javase/8/docs/api/
+
+  
+
+
+  org.apache.maven.plugins
+  maven-plugin-report-plugin
+  ${project.version}
+

Review Comment:
   IMHO we can't use it now in this way ... there is egg and hen problem
   We should use the latest released version
   
   The `maven-plugin-report-plugin` has not been released yet



##
maven-plugin-plugin/pom.xml:
##
@@ -271,7 +271,7 @@
 
   
 org.apache.maven.plugins
-maven-plugin-plugin
+maven-plugin-report-plugin

Review Comment:
   Here we will have a cycle ... `maven-plugin-report-plugin` also requires 
`maven-plugin-plugin`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #165: Use latest m-p-p and m-p-report-p also for the site of m-plugin-tools

2022-10-27 Thread GitBox


slawekjaranowski commented on PR #165:
URL: 
https://github.com/apache/maven-plugin-tools/pull/165#issuecomment-1293172628

   > So this may possible for the site which uses `m-plugin-report-p`, but not 
for `m-plugin-p` which uses... itself.
   
   But we must do it in two steps  first with `install` and second with 
`site` - I would like not to prefer do it in this way


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-plugin-tools] kwin commented on pull request #165: Use latest m-p-p and m-p-report-p also for the site of m-plugin-tools

2022-10-27 Thread GitBox


kwin commented on PR #165:
URL: 
https://github.com/apache/maven-plugin-tools/pull/165#issuecomment-1293229997

   > But we must do it in two steps  first with `install` and second with 
`site` - I would like not to prefer do it in this way
   
   Even if you do that it fails. Please try it locally. But if there is no easy 
way to achieve that, I am fine with sticking to the previous release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


slawekjaranowski commented on code in PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#discussion_r1006646150


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java:
##
@@ -218,6 +218,19 @@
 readonly = true )
 private File enhancedPluginXmlFile;
 
+/**
+ * In case the internal javadoc site has not been generated when running 
this report goal
+ * (e.g. when using an aggregator javadoc report) link validation needs to 
be disabled by setting
+ * this value to {@code true}.
+ * This might have the drawback that some links being generated in the 
report might be broken
+ * in case not all parameter types and javadoc link references are 
resolvable through the sites being given to
+ * {@link DescriptorGeneratorMojo}.
+ * 
+ * @since 3.7.0
+ */
+@Parameter
+private boolean disableInternalJavadocLinkValidation;

Review Comment:
   I would like not to add new parameters to deprecated report - what do you 
think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624992#comment-17624992
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


slawekjaranowski commented on code in PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#discussion_r1006646150


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java:
##
@@ -218,6 +218,19 @@
 readonly = true )
 private File enhancedPluginXmlFile;
 
+/**
+ * In case the internal javadoc site has not been generated when running 
this report goal
+ * (e.g. when using an aggregator javadoc report) link validation needs to 
be disabled by setting
+ * this value to {@code true}.
+ * This might have the drawback that some links being generated in the 
report might be broken
+ * in case not all parameter types and javadoc link references are 
resolvable through the sites being given to
+ * {@link DescriptorGeneratorMojo}.
+ * 
+ * @since 3.7.0
+ */
+@Parameter
+private boolean disableInternalJavadocLinkValidation;

Review Comment:
   I would like not to add new parameters to deprecated report - what do you 
think?





> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


kwin commented on code in PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#discussion_r1006648509


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java:
##
@@ -218,6 +218,19 @@
 readonly = true )
 private File enhancedPluginXmlFile;
 
+/**
+ * In case the internal javadoc site has not been generated when running 
this report goal
+ * (e.g. when using an aggregator javadoc report) link validation needs to 
be disabled by setting
+ * this value to {@code true}.
+ * This might have the drawback that some links being generated in the 
report might be broken
+ * in case not all parameter types and javadoc link references are 
resolvable through the sites being given to
+ * {@link DescriptorGeneratorMojo}.
+ * 
+ * @since 3.7.0
+ */
+@Parameter
+private boolean disableInternalJavadocLinkValidation;

Review Comment:
   A lot of parameters have been added in 3.7.0 (currently both in deprecated 
and new report goal) not only this one. I don't think that this does any harm 
here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624994#comment-17624994
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


kwin commented on code in PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#discussion_r1006648509


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java:
##
@@ -218,6 +218,19 @@
 readonly = true )
 private File enhancedPluginXmlFile;
 
+/**
+ * In case the internal javadoc site has not been generated when running 
this report goal
+ * (e.g. when using an aggregator javadoc report) link validation needs to 
be disabled by setting
+ * this value to {@code true}.
+ * This might have the drawback that some links being generated in the 
report might be broken
+ * in case not all parameter types and javadoc link references are 
resolvable through the sites being given to
+ * {@link DescriptorGeneratorMojo}.
+ * 
+ * @since 3.7.0
+ */
+@Parameter
+private boolean disableInternalJavadocLinkValidation;

Review Comment:
   A lot of parameters have been added in 3.7.0 (currently both in deprecated 
and new report goal) not only this one. I don't think that this does any harm 
here.





> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-5896) Download dependency POMs in parallel

2022-10-27 Thread Fred Bricon (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624995#comment-17624995
 ] 

Fred Bricon commented on MNG-5896:
--

Now that [https://github.com/apache/maven-resolver/pull/178] has been merged, 
can this issue be closed? Which version of Maven will include it? 

> Download dependency POMs in parallel
> 
>
> Key: MNG-5896
> URL: https://issues.apache.org/jira/browse/MNG-5896
> Project: Maven
>  Issue Type: Improvement
>  Components: Dependencies
>Affects Versions: 3.3.3
>Reporter: Harald Wellmann
>Priority: Major
>
> h3. Background
> When building a project with dependencies not yet available in the local 
> repository, I noticed that Maven 3.3.3 first downloads the dependency POMs 
> _sequentially_ and then proceeds downloading the dependency JARs with up to 5 
> threads _in parallel_.
> Due to this, when first building a project with a large number of 
> dependencies, downloading a large number of small POMs may take a lot longer 
> than downloading the much larger JARs, or even longer than building the 
> project itself, especially when a repository manager is used which increases 
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed 
> up initial builds of large projects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MBUILDCACHE-26) Ensure the maven version is >= 3.9

2022-10-27 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reassigned MBUILDCACHE-26:
--

Assignee: Guillaume Nodet

> Ensure the maven version is >= 3.9
> --
>
> Key: MBUILDCACHE-26
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-26
> Project: Maven Build Cache Extension
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0-alpha
>
>
> The {{maven-build-cache-extension}} requires maven >= 3.9.x, so displays a 
> warning if that's not the case and disable the cache.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MBUILDCACHE-26) Ensure the maven version is >= 3.9

2022-10-27 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-26?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MBUILDCACHE-26.
--
Resolution: Fixed

> Ensure the maven version is >= 3.9
> --
>
> Key: MBUILDCACHE-26
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-26
> Project: Maven Build Cache Extension
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.0.0-alpha
>
>
> The {{maven-build-cache-extension}} requires maven >= 3.9.x, so displays a 
> warning if that's not the case and disable the cache.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


slawekjaranowski commented on code in PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#discussion_r1006688605


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java:
##
@@ -218,6 +218,19 @@
 readonly = true )
 private File enhancedPluginXmlFile;
 
+/**
+ * In case the internal javadoc site has not been generated when running 
this report goal
+ * (e.g. when using an aggregator javadoc report) link validation needs to 
be disabled by setting
+ * this value to {@code true}.
+ * This might have the drawback that some links being generated in the 
report might be broken
+ * in case not all parameter types and javadoc link references are 
resolvable through the sites being given to
+ * {@link DescriptorGeneratorMojo}.
+ * 
+ * @since 3.7.0
+ */
+@Parameter
+private boolean disableInternalJavadocLinkValidation;

Review Comment:
   ok, no problem here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625013#comment-17625013
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


slawekjaranowski commented on code in PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#discussion_r1006688605


##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java:
##
@@ -218,6 +218,19 @@
 readonly = true )
 private File enhancedPluginXmlFile;
 
+/**
+ * In case the internal javadoc site has not been generated when running 
this report goal
+ * (e.g. when using an aggregator javadoc report) link validation needs to 
be disabled by setting
+ * this value to {@code true}.
+ * This might have the drawback that some links being generated in the 
report might be broken
+ * in case not all parameter types and javadoc link references are 
resolvable through the sites being given to
+ * {@link DescriptorGeneratorMojo}.
+ * 
+ * @since 3.7.0
+ */
+@Parameter
+private boolean disableInternalJavadocLinkValidation;

Review Comment:
   ok, no problem here





> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


slawekjaranowski commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293318036

   Please also rebase with current codebase ... build should will be ok 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625014#comment-17625014
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


slawekjaranowski commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293318036

   Please also rebase with current codebase ... build should will be ok 😄 




> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] kwin commented on pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


kwin commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293356760

   > Please also rebase with current codebase
   
   Done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625030#comment-17625030
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


kwin commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293356760

   > Please also rebase with current codebase
   
   Done.




> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


slawekjaranowski commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293404350

   What do you think about adding IT test for such options?
   
   By the way we don't have any IT tests for javadoc links ... or I don't see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625058#comment-17625058
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


slawekjaranowski commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293404350

   What do you think about adding IT test for such options?
   
   By the way we don't have any IT tests for javadoc links ... or I don't see.




> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-resolver] cstamas opened a new pull request, #209: [MRESOLVER-278] On session close reworked

2022-10-27 Thread GitBox


cstamas opened a new pull request, #209:
URL: https://github.com/apache/maven-resolver/pull/209

   Key changes:
   * It is not session to register handlers against, but RepositorySystem
   * DefaultRepositorySystemSession class deprecated, but will work as intended 
with a slight semantic change (it's handlers are executed on repo system 
shutdown)
   * introduced MutableRepositorySystemSession and used instead, session 
creation should be done using RepositorySystem and handle it as a resource
   * locking: partially undo PR #196, but do not use System properties but 
container injecter parameters instead (works with SISU only!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MRESOLVER-278) BREAKING: Make Session extend AutoCloseable (and introduce onCloseHandlers)

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MRESOLVER-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625067#comment-17625067
 ] 

ASF GitHub Bot commented on MRESOLVER-278:
--

cstamas opened a new pull request, #209:
URL: https://github.com/apache/maven-resolver/pull/209

   Key changes:
   * It is not session to register handlers against, but RepositorySystem
   * DefaultRepositorySystemSession class deprecated, but will work as intended 
with a slight semantic change (it's handlers are executed on repo system 
shutdown)
   * introduced MutableRepositorySystemSession and used instead, session 
creation should be done using RepositorySystem and handle it as a resource
   * locking: partially undo PR #196, but do not use System properties but 
container injecter parameters instead (works with SISU only!)




> BREAKING: Make Session extend AutoCloseable (and introduce onCloseHandlers)
> ---
>
> Key: MRESOLVER-278
> URL: https://issues.apache.org/jira/browse/MRESOLVER-278
> Project: Maven Resolver
>  Issue Type: New Feature
>  Components: Resolver
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 1.9.0
>
>
> So far, in (vanilla) Maven, the lifecycle of session was on par with 
> lifecycle of SISU container, as Maven does something like this:
>  * boot, create container
>  * create session
>  * work
>  * destroy container
>  * exit JVM
> So, Maven execution is 1 session 1 container, are on par.
> This is not true for cases where container (and resolver components) are 
> reused across several sessions, like mvnd does. Also, current code on master 
> (named locks adapter) uses {{@PreDestroy}} to shut down adapters, that is 
> invoked when container is shut down, while the adapters are created 
> per-session. This means that long-living mvnd daemons will shut down the 
> unused adapter only when daemon itself is shut down, even is session for 
> which adapter was created is long gone/done.
> While Maven has "session scoped" notion, resolver has not. Hence, simplest 
> and cleanest solution is to make RepositorySystemSession have a method to 
> "close", denoting that "this session is done". Also, if we can provide hooks 
> for "onSessionClose", this resolves all the problems, as for example the 
> adapter, that is created per session, could be now cleanly shut down at 
> session end.
> One gotcha: this change implies a {*}breaking change for integrators of 
> resolver{*}:  integrator should make sure they close the session after they 
> are done with it.
> Example changes needed for resolver users: 
> [https://github.com/apache/maven/pull/822]
> The "pattern" to make use of this feature in resolver is following:
>  * stuff something into session data, ideally using computeWhenAbsent
>  * if absent, register a callback hook as well
>  * in callback, get the stuffed thing from session and if present, do 
> something with it
>  
> Example of Maven adopting to this new requirement:
> https://github.com/apache/maven/pull/831



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-resolver] cstamas closed pull request #208: Alternate on-session-end solution

2022-10-27 Thread GitBox


cstamas closed pull request #208: Alternate on-session-end solution
URL: https://github.com/apache/maven-resolver/pull/208


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-mvnd] ppalaga commented on issue #727: build static native image for linux amd64 system

2022-10-27 Thread GitBox


ppalaga commented on issue #727:
URL: https://github.com/apache/maven-mvnd/issues/727#issuecomment-1293519536

   Indeed, this would be nice! 
   
   @gzm55 do you happen to know how much bigger will the native executable 
become?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-plugin-tools] kwin commented on pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


kwin commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293525138

   > By the way we don't have any IT tests for javadoc links ... or I don't see.
   
   Not end2end but there is a lot of unit tests and 
https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocSiteIT.java
 which checks that the links being created actually work against a Javadoc site 
created from JDK8/11/17.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625123#comment-17625123
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


kwin commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293525138

   > By the way we don't have any IT tests for javadoc links ... or I don't see.
   
   Not end2end but there is a lot of unit tests and 
https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-api/src/test/java/org/apache/maven/tools/plugin/javadoc/JavadocSiteIT.java
 which checks that the links being created actually work against a Javadoc site 
created from JDK8/11/17.




> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-mvnd] gzm55 commented on issue #727: build static native image for linux amd64 system

2022-10-27 Thread GitBox


gzm55 commented on issue #727:
URL: https://github.com/apache/maven-mvnd/issues/727#issuecomment-1293547519

   > Indeed, this would be nice!
   > 
   > @gzm55 do you happen to know how much bigger will the native executable 
become?
   
   not yet, i will try it at weekend


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPLUGIN-435) Revert MPLUGIN-410 (@Parameter(implementation))

2022-10-27 Thread Romain Manni-Bucau (Jira)
Romain Manni-Bucau created MPLUGIN-435:
--

 Summary: Revert MPLUGIN-410 (@Parameter(implementation))
 Key: MPLUGIN-435
 URL: https://issues.apache.org/jira/browse/MPLUGIN-435
 Project: Maven Plugin Tools
  Issue Type: Task
  Components: maven-plugin-tools-annotations
Reporter: Romain Manni-Bucau


This usage seems an edge case and bring more ambiguity to the API than it helps 
so saner to keep it handled in the mojo (either binding the implementation, 
using explicit impl as an attribute or using a wrapper binding).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MPLUGIN-436) Deprecate implementation configuration in plugin descriptor

2022-10-27 Thread Romain Manni-Bucau (Jira)
Romain Manni-Bucau created MPLUGIN-436:
--

 Summary: Deprecate implementation configuration in plugin 
descriptor
 Key: MPLUGIN-436
 URL: https://issues.apache.org/jira/browse/MPLUGIN-436
 Project: Maven Plugin Tools
  Issue Type: Task
Reporter: Romain Manni-Bucau






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPLUGIN-436) Deprecate implementation configuration in plugin descriptor

2022-10-27 Thread Romain Manni-Bucau (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Romain Manni-Bucau updated MPLUGIN-436:
---
Description: 
Goal is to align with https://issues.apache.org/jira/browse/MPLUGIN-435.

Likely should be done for 4.x rather than 3.x.

> Deprecate implementation configuration in plugin descriptor
> ---
>
> Key: MPLUGIN-436
> URL: https://issues.apache.org/jira/browse/MPLUGIN-436
> Project: Maven Plugin Tools
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Minor
>
> Goal is to align with https://issues.apache.org/jira/browse/MPLUGIN-435.
> Likely should be done for 4.x rather than 3.x.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] kwin commented on pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


kwin commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293618590

   I now also added a proper IT in 
https://github.com/apache/maven-plugin-tools/pull/162/commits/6b564c8aaf89af4776ffb7898e2a86a4ce400a4f
 with some basic checks on generated links.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625156#comment-17625156
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


kwin commented on PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#issuecomment-1293618590

   I now also added a proper IT in 
https://github.com/apache/maven-plugin-tools/pull/162/commits/6b564c8aaf89af4776ffb7898e2a86a4ce400a4f
 with some basic checks on generated links.




> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-7583) Allow concurrent access to the MavenPluginManager

2022-10-27 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7583:


 Summary: Allow concurrent access to the MavenPluginManager
 Key: MNG-7583
 URL: https://issues.apache.org/jira/browse/MNG-7583
 Project: Maven
  Issue Type: Task
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
 Fix For: 4.0.0-alpha-3






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINSTALL-180) Upgrade Parent to 37

2022-10-27 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINSTALL-180:


 Summary: Upgrade Parent to 37
 Key: MINSTALL-180
 URL: https://issues.apache.org/jira/browse/MINSTALL-180
 Project: Maven Install Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] gnodet opened a new pull request, #855: [MNG-7583] Allow concurrent access to the MavenPluginManager

2022-10-27 Thread GitBox


gnodet opened a new pull request, #855:
URL: https://github.com/apache/maven/pull/855

   This would allow a better integration with mvnd.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7583) Allow concurrent access to the MavenPluginManager

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625190#comment-17625190
 ] 

ASF GitHub Bot commented on MNG-7583:
-

gnodet opened a new pull request, #855:
URL: https://github.com/apache/maven/pull/855

   This would allow a better integration with mvnd.
   
   




> Allow concurrent access to the MavenPluginManager
> -
>
> Key: MNG-7583
> URL: https://issues.apache.org/jira/browse/MNG-7583
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINSTALL-160) generatePom=true with 3.0.0-M1 does not generate minimal POM but copies existing one

2022-10-27 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINSTALL-160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINSTALL-160:
-
Affects Version/s: (was: 3.0.0-M2)

> generatePom=true with 3.0.0-M1 does not generate minimal POM but copies 
> existing one
> 
>
> Key: MINSTALL-160
> URL: https://issues.apache.org/jira/browse/MINSTALL-160
> Project: Maven Install Plugin
>  Issue Type: Bug
>  Components: install:install-file
>Affects Versions: 3.0.0-M1, 3.0.0
>Reporter: Václav Haisman
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.0.1
>
>
> I am using install:install-file with generatePom=true to install JAR with 
> minimal POM file. This has stopped working with 3.0.0-M1. With 3.0.0-M1, it 
> copeis existing project pom.xml instead of generating a minimal one.
>  
> This is easily reproducible with minimal project:
> {code:java}
> 
> http://maven.apache.org/POM/4.0.0"; 
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
>   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
>   4.0.0
>   maven.install.plugin.issue
>   maven.install.plugin.issue
>   1.0-SNAPSHOT
>   jar
>   maven.install.plugin.issue
>   
> 1.6
> 1.6
>   
>   
> 
>   
> 
>   maven-install-plugin
>   
>   3.0.0-M1
>   
> 
>   
> 
> 
>   
> maven-install-plugin
> 
>   
> default-install
> none
> install
>   
>   
> custom-install
> install
> 
>   install-file
> 
> 
>   
> ${project.build.directory}/${project.artifactId}-${project.version}.${project.packaging}
>   true
> 
>   
> 
>   
> 
>   
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINSTALL-181) Require Java 8

2022-10-27 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINSTALL-181:


 Summary: Require Java 8
 Key: MINSTALL-181
 URL: https://issues.apache.org/jira/browse/MINSTALL-181
 Project: Maven Install Plugin
  Issue Type: Task
Reporter: Slawomir Jaranowski






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIA-677) Macro for printing project properties

2022-10-27 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625232#comment-17625232
 ] 

Slawomir Jaranowski commented on DOXIA-677:
---

If the implementation is complicated we can drop the idea.
Or we can wait maybe in the future will be easier.


> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] kwin merged pull request #162: [MPLUGIN-433] Allow to disable link validation

2022-10-27 Thread GitBox


kwin merged PR #162:
URL: https://github.com/apache/maven-plugin-tools/pull/162


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625234#comment-17625234
 ] 

ASF GitHub Bot commented on MPLUGIN-433:


kwin merged PR #162:
URL: https://github.com/apache/maven-plugin-tools/pull/162




> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved MPLUGIN-433.
-
Fix Version/s: 3.7.0
   Resolution: Fixed

Fixed in 
https://github.com/apache/maven-plugin-tools/commit/339fc29d84de0a5cd96ca5d77d0d52d9b6536157.

> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.7.0
>
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPLUGIN-433) Allow to reference aggregator javadoc from plugin report

2022-10-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625237#comment-17625237
 ] 

Hudson commented on MPLUGIN-433:


Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #75

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/75/

> Allow to reference aggregator javadoc from plugin report
> 
>
> Key: MPLUGIN-433
> URL: https://issues.apache.org/jira/browse/MPLUGIN-433
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.7.0
>
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-jdeps-plugin] bmarwell merged pull request #6: [MJDEPS-28] replace travisCI with github actions

2022-10-27 Thread GitBox


bmarwell merged PR #6:
URL: https://github.com/apache/maven-jdeps-plugin/pull/6


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MJDEPS-28) TravisCI builds need to be removed

2022-10-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MJDEPS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625255#comment-17625255
 ] 

Hudson commented on MJDEPS-28:
--

Build succeeded in Jenkins: Maven » Maven TLP » maven-jdeps-plugin » master #12

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-jdeps-plugin/job/master/12/

> TravisCI builds need to be removed
> --
>
> Key: MJDEPS-28
> URL: https://issues.apache.org/jira/browse/MJDEPS-28
> Project: Maven JDeps Plugin
>  Issue Type: Task
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
>
> As to ASF Infra, TravisCI builds need to be removed from Apache projects by 
> the end of the year.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MJDEPS-28) TravisCI builds need to be removed

2022-10-27 Thread Benjamin Marwell (Jira)


 [ 
https://issues.apache.org/jira/browse/MJDEPS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Marwell updated MJDEPS-28:
---
Fix Version/s: 3.1.3

> TravisCI builds need to be removed
> --
>
> Key: MJDEPS-28
> URL: https://issues.apache.org/jira/browse/MJDEPS-28
> Project: Maven JDeps Plugin
>  Issue Type: Task
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
> Fix For: 3.1.3
>
>
> As to ASF Infra, TravisCI builds need to be removed from Apache projects by 
> the end of the year.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (MJDEPS-28) TravisCI builds need to be removed

2022-10-27 Thread Benjamin Marwell (Jira)


 [ 
https://issues.apache.org/jira/browse/MJDEPS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Marwell resolved MJDEPS-28.

Resolution: Fixed

> TravisCI builds need to be removed
> --
>
> Key: MJDEPS-28
> URL: https://issues.apache.org/jira/browse/MJDEPS-28
> Project: Maven JDeps Plugin
>  Issue Type: Task
>Reporter: Benjamin Marwell
>Assignee: Benjamin Marwell
>Priority: Major
>
> As to ASF Infra, TravisCI builds need to be removed from Apache projects by 
> the end of the year.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MNG-7584) The properties-maven-plugin fails to load project properties

2022-10-27 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7584:


 Summary: The properties-maven-plugin fails to load project 
properties
 Key: MNG-7584
 URL: https://issues.apache.org/jira/browse/MNG-7584
 Project: Maven
  Issue Type: Task
Affects Versions: 4.0.0-alpha-2
Reporter: Guillaume Nodet


The {{read-project-properties}} mojo fails with the following exception:
{code:java}
[ERROR] Failed to execute goal 
org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
(init-camel-schema-version-property-from-file) on project camel-spring-xml: 
Execution init-camel-schema-version-property-from-file of goal 
org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
failed.: UnsupportedOperationException -> [Help 
1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
goal 
org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
(init-camel-schema-version-property-from-file) on project camel-spring-xml: 
Execution init-camel-schema-version-property-from-file of goal 
org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
failed.   at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:385)
   at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:361)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:232) 
 at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:188) 
 at 
org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:78)
at 
org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:179)   
 at 
org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrategy.java:132)
  at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174) 
 at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:112)
 at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
  at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:141)
  at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:341)   
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:248)   at 
org.apache.maven.DefaultMaven.execute(DefaultMaven.java:158) at 
org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:682) at 
org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:234)  at 
org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:210)at 
org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at 
org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at 
org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at 
java.base/java.lang.Thread.run(Thread.java:833)Caused by: 
org.apache.maven.plugin.PluginExecutionException: Execution 
init-camel-schema-version-property-from-file of goal 
org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
failed. at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:165)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:380)
   ... 21 common frames omittedCaused by: 
java.lang.UnsupportedOperationException: nullat 
org.apache.maven.model.WrapperProperties.load(WrapperProperties.java:318)at 
org.codehaus.mojo.properties.ReadPropertiesMojo.execute(ReadPropertiesMojo.java:87)
  at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:155)
... 22 common frames omitted
 {code}
 

The {{WrapperProperties}} do not support the {{load}} operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DOXIA-677) Macro for printing project properties

2022-10-27 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625278#comment-17625278
 ] 

Michael Osipov commented on DOXIA-677:
--

Well, Velocity does all the bean handling. Doing it ourselves I see very hard 
atm.

> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MNG-7584) The properties-maven-plugin fails to load project properties

2022-10-27 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet reassigned MNG-7584:


Assignee: Guillaume Nodet

> The properties-maven-plugin fails to load project properties
> 
>
> Key: MNG-7584
> URL: https://issues.apache.org/jira/browse/MNG-7584
> Project: Maven
>  Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>
> The {{read-project-properties}} mojo fails with the following exception:
> {code:java}
> [ERROR] Failed to execute goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed.: UnsupportedOperationException -> [Help 
> 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:385)
>at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:361)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:232)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:188)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:78)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:179) 
>at 
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrategy.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:112)
>  at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:141)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:341)   
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:248)   at 
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:158) at 
> org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:682) at 
> org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:234)  at 
> org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:210)at 
> org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at 
> org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at 
> org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at 
> java.base/java.lang.Thread.run(Thread.java:833)Caused by: 
> org.apache.maven.plugin.PluginExecutionException: Execution 
> init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:165)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:380)
>... 21 common frames omittedCaused by: 
> java.lang.UnsupportedOperationException: nullat 
> org.apache.maven.model.WrapperProperties.load(WrapperProperties.java:318)
> at 
> org.codehaus.mojo.properties.ReadPropertiesMojo.execute(ReadPropertiesMojo.java:87)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:155)
> ... 22 common frames omitted
>  {code}
>  
> The {{WrapperProperties}} do not support the {{load}} operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7584) The properties-maven-plugin fails to load project properties

2022-10-27 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7584:
-
Fix Version/s: 4.0.0-alpha-3

> The properties-maven-plugin fails to load project properties
> 
>
> Key: MNG-7584
> URL: https://issues.apache.org/jira/browse/MNG-7584
> Project: Maven
>  Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The {{read-project-properties}} mojo fails with the following exception:
> {code:java}
> [ERROR] Failed to execute goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed.: UnsupportedOperationException -> [Help 
> 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:385)
>at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:361)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:232)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:188)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:78)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:179) 
>at 
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrategy.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:112)
>  at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:141)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:341)   
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:248)   at 
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:158) at 
> org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:682) at 
> org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:234)  at 
> org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:210)at 
> org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at 
> org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at 
> org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at 
> java.base/java.lang.Thread.run(Thread.java:833)Caused by: 
> org.apache.maven.plugin.PluginExecutionException: Execution 
> init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:165)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:380)
>... 21 common frames omittedCaused by: 
> java.lang.UnsupportedOperationException: nullat 
> org.apache.maven.model.WrapperProperties.load(WrapperProperties.java:318)
> at 
> org.codehaus.mojo.properties.ReadPropertiesMojo.execute(ReadPropertiesMojo.java:87)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:155)
> ... 22 common frames omitted
>  {code}
>  
> The {{WrapperProperties}} do not support the {{load}} operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7584) The properties-maven-plugin fails to load project properties

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625307#comment-17625307
 ] 

ASF GitHub Bot commented on MNG-7584:
-

gnodet opened a new pull request, #856:
URL: https://github.com/apache/maven/pull/856

   JIRA issue: https://issues.apache.org/jira/browse/MNG-7584
   
   




> The properties-maven-plugin fails to load project properties
> 
>
> Key: MNG-7584
> URL: https://issues.apache.org/jira/browse/MNG-7584
> Project: Maven
>  Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The {{read-project-properties}} mojo fails with the following exception:
> {code:java}
> [ERROR] Failed to execute goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed.: UnsupportedOperationException -> [Help 
> 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:385)
>at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:361)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:232)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:188)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:78)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:179) 
>at 
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrategy.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:112)
>  at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:141)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:341)   
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:248)   at 
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:158) at 
> org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:682) at 
> org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:234)  at 
> org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:210)at 
> org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at 
> org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at 
> org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at 
> java.base/java.lang.Thread.run(Thread.java:833)Caused by: 
> org.apache.maven.plugin.PluginExecutionException: Execution 
> init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:165)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:380)
>... 21 common frames omittedCaused by: 
> java.lang.UnsupportedOperationException: nullat 
> org.apache.maven.model.WrapperProperties.load(WrapperProperties.java:318)
> at 
> org.codehaus.mojo.properties.ReadPropertiesMojo.execute(ReadPropertiesMojo.java:87)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:155)
> ... 22 common frames omitted
>  {code}
>  
> The {{WrapperProperties}} do not support the {{load}} operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] gnodet opened a new pull request, #856: [MNG-7584] The properties-maven-plugin fails to load project properties

2022-10-27 Thread GitBox


gnodet opened a new pull request, #856:
URL: https://github.com/apache/maven/pull/856

   JIRA issue: https://issues.apache.org/jira/browse/MNG-7584
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] slawekjaranowski merged pull request #37: Bump maven-plugins from 36 to 37

2022-10-27 Thread GitBox


slawekjaranowski merged PR #37:
URL: https://github.com/apache/maven-install-plugin/pull/37


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MINSTALL-180) Upgrade Parent to 37

2022-10-27 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINSTALL-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINSTALL-180.

Fix Version/s: 3.0.2
 Assignee: Slawomir Jaranowski
   Resolution: Fixed

> Upgrade Parent to 37
> 
>
> Key: MINSTALL-180
> URL: https://issues.apache.org/jira/browse/MINSTALL-180
> Project: Maven Install Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] slawekjaranowski commented on pull request #856: [MNG-7584] The properties-maven-plugin fails to load project properties

2022-10-27 Thread GitBox


slawekjaranowski commented on PR #856:
URL: https://github.com/apache/maven/pull/856#issuecomment-1294038179

   Do we have three the same or similar classes?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7584) The properties-maven-plugin fails to load project properties

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625325#comment-17625325
 ] 

ASF GitHub Bot commented on MNG-7584:
-

slawekjaranowski commented on PR #856:
URL: https://github.com/apache/maven/pull/856#issuecomment-1294038179

   Do we have three the same or similar classes?




> The properties-maven-plugin fails to load project properties
> 
>
> Key: MNG-7584
> URL: https://issues.apache.org/jira/browse/MNG-7584
> Project: Maven
>  Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The {{read-project-properties}} mojo fails with the following exception:
> {code:java}
> [ERROR] Failed to execute goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed.: UnsupportedOperationException -> [Help 
> 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:385)
>at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:361)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:232)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:188)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:78)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:179) 
>at 
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrategy.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:112)
>  at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:141)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:341)   
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:248)   at 
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:158) at 
> org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:682) at 
> org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:234)  at 
> org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:210)at 
> org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at 
> org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at 
> org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at 
> java.base/java.lang.Thread.run(Thread.java:833)Caused by: 
> org.apache.maven.plugin.PluginExecutionException: Execution 
> init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:165)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:380)
>... 21 common frames omittedCaused by: 
> java.lang.UnsupportedOperationException: nullat 
> org.apache.maven.model.WrapperProperties.load(WrapperProperties.java:318)
> at 
> org.codehaus.mojo.properties.ReadPropertiesMojo.execute(ReadPropertiesMojo.java:87)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:155)
> ... 22 common frames omitted
>  {code}
>  
> The {{WrapperProperties}} do not support the {{load}} operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-install-plugin] slawekjaranowski opened a new pull request, #39: [MINSTALL-181] Require Java 8

2022-10-27 Thread GitBox


slawekjaranowski opened a new pull request, #39:
URL: https://github.com/apache/maven-install-plugin/pull/39

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MINSTALL) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MINSTALL-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MINSTALL-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MNG-7585) Get rid if duplicate utility classes

2022-10-27 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7585:


 Summary: Get rid if duplicate utility classes
 Key: MNG-7585
 URL: https://issues.apache.org/jira/browse/MNG-7585
 Project: Maven
  Issue Type: Task
Affects Versions: 4.0.0-alpha-2
Reporter: Guillaume Nodet


We currently have 3 copies of {{WrapperList}} and {{WrapperProperties}} and 4 
copies of {{{}ImmutableCollections{}}}.

It would be nice to find a way to keep a single copy of those.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] gnodet commented on pull request #856: [MNG-7584] The properties-maven-plugin fails to load project properties

2022-10-27 Thread GitBox


gnodet commented on PR #856:
URL: https://github.com/apache/maven/pull/856#issuecomment-1294047030

   > Do we have three the same or similar classes?
   
   We have 3 copies of the `WrapperProperties`, `WrapperList`.  Those are non 
public classes used in the v3 models which wraps the new immutable v4 models.  
I made copies in order to not add dependencies to some _utility_ module.
   We also have 4 copies of `ImmutableCollections` (those are non public 
classes used in the new v4 models).
   I've created https://issues.apache.org/jira/browse/MNG-7585 to try to find a 
way to get rid of those duplicates.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7584) The properties-maven-plugin fails to load project properties

2022-10-27 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625330#comment-17625330
 ] 

ASF GitHub Bot commented on MNG-7584:
-

gnodet commented on PR #856:
URL: https://github.com/apache/maven/pull/856#issuecomment-1294047030

   > Do we have three the same or similar classes?
   
   We have 3 copies of the `WrapperProperties`, `WrapperList`.  Those are non 
public classes used in the v3 models which wraps the new immutable v4 models.  
I made copies in order to not add dependencies to some _utility_ module.
   We also have 4 copies of `ImmutableCollections` (those are non public 
classes used in the new v4 models).
   I've created https://issues.apache.org/jira/browse/MNG-7585 to try to find a 
way to get rid of those duplicates.
   




> The properties-maven-plugin fails to load project properties
> 
>
> Key: MNG-7584
> URL: https://issues.apache.org/jira/browse/MNG-7584
> Project: Maven
>  Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The {{read-project-properties}} mojo fails with the following exception:
> {code:java}
> [ERROR] Failed to execute goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed.: UnsupportedOperationException -> [Help 
> 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> (init-camel-schema-version-property-from-file) on project camel-spring-xml: 
> Execution init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:385)
>at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute(MojoExecutor.java:361)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:232)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:188)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.access$000(MojoExecutor.java:78)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor$1.run(MojoExecutor.java:179) 
>at 
> org.apache.maven.buildcache.BuildCacheMojosExecutionStrategy.execute(BuildCacheMojosExecutionStrategy.java:132)
>   at 
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:174)
>   at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:112)
>  at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
>   at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:64)
> at 
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:141)
>   at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:341)   
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:248)   at 
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:158) at 
> org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:682) at 
> org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:234)  at 
> org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:210)at 
> org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at 
> org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at 
> org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at 
> java.base/java.lang.Thread.run(Thread.java:833)Caused by: 
> org.apache.maven.plugin.PluginExecutionException: Execution 
> init-camel-schema-version-property-from-file of goal 
> org.codehaus.mojo:properties-maven-plugin:1.0-alpha-2:read-project-properties 
> failed. at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:165)
> at 
> org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2(MojoExecutor.java:380)
>... 21 common frames omittedCaused by: 
> java.lang.UnsupportedOperationException: nullat 
> org.apache.maven.model.WrapperProperties.load(WrapperProperties.java:318)
> at 
> org.codehaus.mojo.properties.ReadPropertiesMojo.execute(ReadPropertiesMojo.java:87)
>   at 
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:155)
> ... 22 co

[jira] [Commented] (MNG-6609) Profile activation by packaging

2022-10-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625331#comment-17625331
 ] 

Hudson commented on MNG-6609:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-847 #5

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-847/5/

> Profile activation by packaging 
> 
>
> Key: MNG-6609
> URL: https://issues.apache.org/jira/browse/MNG-6609
> Project: Maven
>  Issue Type: Improvement
>  Components: Profiles
>Affects Versions: 3.6.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.9.0-candidate, 4.0.0
>
>
> Due to the lack of mixins, it is common that modules which use different 
> packagings share the same parent pom. As those often use different 
> dependencies/plugins, it would be nice to have profiles which are activated 
> based on the packaging of a module. That is currently not possible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7582) Reformat apiv4 javadoc according to usual rules

2022-10-27 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625332#comment-17625332
 ] 

Hudson commented on MNG-7582:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-847 #5

See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/PR-847/5/

> Reformat apiv4 javadoc according to usual rules
> ---
>
> Key: MNG-7582
> URL: https://issues.apache.org/jira/browse/MNG-7582
> Project: Maven
>  Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7585) Get rid if duplicate utility classes

2022-10-27 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7585:
-
Description: 
We currently have 3 copies of {{WrapperList}} and {{WrapperProperties}} and 4 
copies of {{{}ImmutableCollections{}}}.

It would be nice to find a way to keep a single copy of those without adding a 
dependency on some utility module, especially for the {{ImmutableCollections}} 
which are non public classes inside the v4 api.

 

One possibility may be to use maven-shade-plugin to include a copy of the 
needed classes as non public classes inside the needed package... ?

  was:
We currently have 3 copies of {{WrapperList}} and {{WrapperProperties}} and 4 
copies of {{{}ImmutableCollections{}}}.

It would be nice to find a way to keep a single copy of those.


> Get rid if duplicate utility classes
> 
>
> Key: MNG-7585
> URL: https://issues.apache.org/jira/browse/MNG-7585
> Project: Maven
>  Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Priority: Major
>
> We currently have 3 copies of {{WrapperList}} and {{WrapperProperties}} and 4 
> copies of {{{}ImmutableCollections{}}}.
> It would be nice to find a way to keep a single copy of those without adding 
> a dependency on some utility module, especially for the 
> {{ImmutableCollections}} which are non public classes inside the v4 api.
>  
> One possibility may be to use maven-shade-plugin to include a copy of the 
> needed classes as non public classes inside the needed package... ?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MBUILDCACHE-28) Change buildinfo model to support separate checksums

2022-10-27 Thread Alexander Ashitkin (Jira)
Alexander Ashitkin created MBUILDCACHE-28:
-

 Summary: Change buildinfo model to support separate checksums
 Key: MBUILDCACHE-28
 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-28
 Project: Maven Build Cache Extension
  Issue Type: Sub-task
Reporter: Alexander Ashitkin


Need to introduce additional fields in build info model to additionally store 
checksums of shared source code, private source code and dependencies

Calculating these checksums is out of scope of this jira



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MBUILDCACHE-29) Change buildinfo model to support separate checksums

2022-10-27 Thread Alexander Ashitkin (Jira)
Alexander Ashitkin created MBUILDCACHE-29:
-

 Summary: Change buildinfo model to support separate checksums
 Key: MBUILDCACHE-29
 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-29
 Project: Maven Build Cache Extension
  Issue Type: Sub-task
Reporter: Alexander Ashitkin


Need to introduce additional fields in build info model to additionally store 
checksums of shared source code, private source code and dependencies

Calculating these checksums is out of scope of this jira



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MBUILDCACHE-30) Change buildinfo model to support separate checksums

2022-10-27 Thread Alexander Ashitkin (Jira)
Alexander Ashitkin created MBUILDCACHE-30:
-

 Summary: Change buildinfo model to support separate checksums
 Key: MBUILDCACHE-30
 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
 Project: Maven Build Cache Extension
  Issue Type: Sub-task
Reporter: Alexander Ashitkin


Need to introduce additional fields in build info model to additionally store 
checksums of shared source code, private source code and dependencies

Calculating these checksums is out of scope of this jira



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-29) Capture separate checksums of test source, dependencies and other code

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-29:
--
Summary: Capture separate checksums of test source, dependencies and other 
code  (was: Change buildinfo model to support separate checksums)

> Capture separate checksums of test source, dependencies and other code
> --
>
> Key: MBUILDCACHE-29
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-29
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Need to introduce additional fields in build info model to additionally store 
> checksums of shared source code, private source code and dependencies
> Calculating these checksums is out of scope of this jira



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-29) Capture separate checksums of test source, dependencies and other code

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-29:
--
Description: 
In process of calculating input need to produce 3 checksum
 * for dependencies
 * for private code (not shared with other models) - typically tests
 * for shared code (typically src/main content)

 

Calculation logic should be as follows:
 * dependencies - leave as know, just capture at the end of calculation
 * private code - by now, consider any code in test folders private (later more 
sophisticated rules could be created)
 * all other discovered code to considered a shared code

Dependencies to be stored in fields introduced in 

  was:
Need to introduce additional fields in build info model to additionally store 
checksums of shared source code, private source code and dependencies

Calculating these checksums is out of scope of this jira


> Capture separate checksums of test source, dependencies and other code
> --
>
> Key: MBUILDCACHE-29
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-29
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> In process of calculating input need to produce 3 checksum
>  * for dependencies
>  * for private code (not shared with other models) - typically tests
>  * for shared code (typically src/main content)
>  
> Calculation logic should be as follows:
>  * dependencies - leave as know, just capture at the end of calculation
>  * private code - by now, consider any code in test folders private (later 
> more sophisticated rules could be created)
>  * all other discovered code to considered a shared code
> Dependencies to be stored in fields introduced in 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-29) Capture separate checksums of test source, dependencies and other code

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-29:
--
Description: 
In process of calculating input need to produce 3 checksum
 * for dependencies
 * for private code (not shared with other models) - typically tests
 * for shared code (typically src/main content)

 

Calculation logic should be as follows:
 * dependencies - leave as know, just capture at the end of calculation
 * private code - by now, consider any code in test folders private (later more 
sophisticated rules could be created)
 * all other discovered code to considered a shared code

Dependencies to be stored in fields introduced in MBUILDCACHE-28

  was:
In process of calculating input need to produce 3 checksum
 * for dependencies
 * for private code (not shared with other models) - typically tests
 * for shared code (typically src/main content)

 

Calculation logic should be as follows:
 * dependencies - leave as know, just capture at the end of calculation
 * private code - by now, consider any code in test folders private (later more 
sophisticated rules could be created)
 * all other discovered code to considered a shared code

Dependencies to be stored in fields introduced in 


> Capture separate checksums of test source, dependencies and other code
> --
>
> Key: MBUILDCACHE-29
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-29
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> In process of calculating input need to produce 3 checksum
>  * for dependencies
>  * for private code (not shared with other models) - typically tests
>  * for shared code (typically src/main content)
>  
> Calculation logic should be as follows:
>  * dependencies - leave as know, just capture at the end of calculation
>  * private code - by now, consider any code in test folders private (later 
> more sophisticated rules could be created)
>  * all other discovered code to considered a shared code
> Dependencies to be stored in fields introduced in MBUILDCACHE-28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-29) Capture separate checksums of test source, dependencies and other code

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-29:
--
Description: 
In process of calculating input need to produce 3 checksum
 * for dependencies
 * for private code (not shared with other models) - typically tests
 * for shared code (typically src/main content)

 

Calculation logic should be as follows:
 * dependencies - leave as know, just capture at the end of calculation
 * private code - by now, consider any code in test folders private (later more 
sophisticated rules could be created)
 * all other discovered code to considered a shared code

Checksums to be stored in fields introduced in MBUILDCACHE-28

  was:
In process of calculating input need to produce 3 checksum
 * for dependencies
 * for private code (not shared with other models) - typically tests
 * for shared code (typically src/main content)

 

Calculation logic should be as follows:
 * dependencies - leave as know, just capture at the end of calculation
 * private code - by now, consider any code in test folders private (later more 
sophisticated rules could be created)
 * all other discovered code to considered a shared code

Dependencies to be stored in fields introduced in MBUILDCACHE-28


> Capture separate checksums of test source, dependencies and other code
> --
>
> Key: MBUILDCACHE-29
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-29
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> In process of calculating input need to produce 3 checksum
>  * for dependencies
>  * for private code (not shared with other models) - typically tests
>  * for shared code (typically src/main content)
>  
> Calculation logic should be as follows:
>  * dependencies - leave as know, just capture at the end of calculation
>  * private code - by now, consider any code in test folders private (later 
> more sophisticated rules could be created)
>  * all other discovered code to considered a shared code
> Checksums to be stored in fields introduced in MBUILDCACHE-28



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-30) Change aware matching in cache restoration process

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-30:
--
Summary: Change aware matching in cache restoration process  (was: Change 
buildinfo model to support separate checksums)

> Change aware matching in cache restoration process
> --
>
> Key: MBUILDCACHE-30
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Need to introduce additional fields in build info model to additionally store 
> checksums of shared source code, private source code and dependencies
> Calculating these checksums is out of scope of this jira



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-30) Change aware matching in cache restoration process

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-30:
--
Description: Need to   (was: Need to introduce additional fields in build 
info model to additionally store checksums of shared source code, private 
source code and dependencies

Calculating these checksums is out of scope of this jira)

> Change aware matching in cache restoration process
> --
>
> Key: MBUILDCACHE-30
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Need to 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-30) Track reactor projects using "api" checksum instead of full

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-30:
--
Summary: Track reactor projects using "api" checksum instead of full  (was: 
Change aware matching in cache restoration process)

> Track reactor projects using "api" checksum instead of full
> ---
>
> Key: MBUILDCACHE-30
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Need to 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-30) Track reactor projects using "api" checksum instead of full

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-30:
--
Description: Currently each project is stored within reactor   (was: Need 
to )

> Track reactor projects using "api" checksum instead of full
> ---
>
> Key: MBUILDCACHE-30
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Currently each project is stored within reactor 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-30) Track reactor projects using "implementation + dependencies" checksum instead of full

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-30:
--
Summary: Track reactor projects using "implementation + dependencies" 
checksum instead of full  (was: Track reactor projects using "api" checksum 
instead of full)

> Track reactor projects using "implementation + dependencies" checksum instead 
> of full
> -
>
> Key: MBUILDCACHE-30
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Currently each project is stored within reactor 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-30) Track reactor projects using "implementation + dependencies" checksum instead of full

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-30:
--
Description: 
Currently each project is stored within reactor using full checksum, which 
includes private files
Instead of that need to use 

  was:Currently each project is stored within reactor 


> Track reactor projects using "implementation + dependencies" checksum instead 
> of full
> -
>
> Key: MBUILDCACHE-30
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Currently each project is stored within reactor using full checksum, which 
> includes private files
> Instead of that need to use 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-30) Track reactor projects using "implementation + dependencies" checksum instead of full

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-30:
--
Description: 
Currently each project is stored within reactor using full checksum, which 
includes private files
Instead of that need to use "implementation + dependencies" checksum and 
exclude private sources which do not have dependencies

that will allow to not invalidate downstream projects if change is in private 
files (eg unit tests)

  was:
Currently each project is stored within reactor using full checksum, which 
includes private files
Instead of that need to use 


> Track reactor projects using "implementation + dependencies" checksum instead 
> of full
> -
>
> Key: MBUILDCACHE-30
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-30
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> Currently each project is stored within reactor using full checksum, which 
> includes private files
> Instead of that need to use "implementation + dependencies" checksum and 
> exclude private sources which do not have dependencies
> that will allow to not invalidate downstream projects if change is in private 
> files (eg unit tests)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-27) Improve efficiency of cache with plugin and source type aware processing

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-27:
--
Description: 
Currently build cache has implementation which checks source code and plugins 
and if it detects mismatch, whole project is rerun. This is is redundant and 
could be optimized in following cases:
 * Test code changed. In that case optimal behavior is to rerun test in an 
affected module and reuse cached artifacts in case of success. Actual behavior: 
change in a test in upstream module invalidates all downstream projects
 * Variation of the situation above is a test library project (aka test-jar) - 
though by convention modification is in production code, because the project is 
used only in test scope - modification of upstream test jar should cause just 
tests rerun 
 * Upstream dependency changed. In that case any plugin which execution is not 
affected by upstream dependency, could be skip. Typically, it could be any of 
linter plugins - like checkstyle, which checks project source code only. 
Current behavior: plugin will rerun

With such granular plugin and sources demarcation, it is possible to 
significantly optimize cached build time.

To address this problem need following changes:
 * changes in build configuration to demarcate plugins as private (no need 
rebuild on dependencies change)
 * split checksum into at least 3 parts - test sources checksum, dependencies 
checksum and  production checksum
 * Take into account changes in every checksum when decision of plugin 
execution is taken. If only dependencies changed, `source-code-only` plugins 
could be skipped
 * When calculating dependencies between reactor projects, take into account 
"production" checksum only. In that case changes in test code will not affect 
downstream projects

Additional challenge is to rerun-tests-only mode - it obviously relies on 
compiled project, but probably that could be worked around by restoring cached 
jar

Summarizing the above and applying ideas of ABI to maven build, need to 
distinguish 3 categories of project inputs:
 * implementation sources - part of the code resembling functionality shared 
within reactor (src/main and similar)
 * private sources - part which is not shared (unit test and similar)
 * dependencies - they change functionality but do not change code

Having this 3 categories correctly represented by a separate cheksums, it is 
possibly to implement optimization mentioned above.

In target state, following behavior is desirable:

 
||Change||Changed project||Downstream Project||
|Test sources|rerun tests + later plugins|Reuse cache|
|Test dependency |rerun tests + later plugins except "source-only" 
plugins|Reuse cache|
|Test library project|rerun everything|rerun tests|
|Prod sources|rerun everything|Rerun everything except "source only plugins"|
|Prod dependency|rerun everything except "source-only" plugins|Rerun everything 
except "source only plugins"|

This behavior could be made opt-in

 

  was:
Currently build cache has implementation which checks source code and plugins 
and if it detects mismatch, whole project is rerun. This is is redundant and 
could be optimized in following cases:
 * Test code changed. In that case optimal behavior is to rerun test in an 
affected module and reuse cached artifacts in case of success. Actual behavior: 
change in a test in upstream module invalidates all downstream projects
 * Variation of the situation above is a test library project (aka test-jar) - 
though by convention modification is in production code, because the project is 
used only in test scope - modification of upstream test jar should cause just 
tests rerun 
 * Upstream dependency changed. In that case any plugin which execution is not 
affected by upstream dependency, could be skip. Typically, it could be any of 
linter plugins - like checkstyle, which checks project source code only. 
Current behavior: plugin will rerun

With such granular plugin and sources demarcation, it is possible to 
significantly optimize cached build time.

To address this problem need following changes:
 * changes in build configuration to demarcate plugins as private (no need 
rebuild on dependencies change)
 * split checksum into at least 3 parts - test sources checksum, dependencies 
checksum and  production checksum
 * Take into account changes in every checksum when decision of plugin 
execution is taken. If only dependencies changed, `source-code-only` plugins 
could be skipped
 * When calculating dependencies between reactor projects, take into account 
"production" checksum only. In that case changes in test code will not affect 
downstream projects


Additional challenge is to rerun-tests-only mode - it obviously relies on 
compiled project, but probably that could be worked around by restoring cached 
jar

Summarizing in target state, following behavior is desir

[jira] [Updated] (MBUILDCACHE-27) Improve efficiency of cache with plugin and source type aware processing

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-27:
--
Description: 
Currently build cache has implementation which checks source code and plugins 
and if it detects mismatch, whole project is rerun. This is is redundant and 
could be optimized in following cases:
 * Test code changed. In that case optimal behavior is to rerun test in an 
affected module and reuse cached artifacts in case of success. Actual behavior: 
change in a test in upstream module invalidates all downstream projects
 * Variation of the situation above is a test library project (aka test-jar) - 
though by convention modification is in production code, because the project is 
used only in test scope - modification of upstream test jar should cause just 
tests rerun 
 * Upstream dependency changed. In that case any plugin which execution is not 
affected by upstream dependency, could be skip. Typically, it could be any of 
linter plugins - like checkstyle, which checks project source code only. 
Current behavior: plugin will rerun

With such granular plugin and sources demarcation, it is possible to 
significantly optimize cached build time.

To address this problem need following changes:
 * changes in build configuration to demarcate plugins as private (no need 
rebuild on dependencies change)
 * split checksum into at least 3 parts - test sources checksum, dependencies 
checksum and  production checksum
 * Take into account changes in every checksum when decision of plugin 
execution is taken. If only dependencies changed, `source-code-only` plugins 
could be skipped
 * When calculating dependencies between reactor projects, take into account 
"production" checksum only. In that case changes in test code will not affect 
downstream projects

Additional challenge is to rerun-tests-only mode - it obviously relies on 
compiled project, but probably that could be worked around by restoring cached 
jar

Summarizing the above and applying ideas of ABI to maven build, need to 
distinguish 3 categories of project inputs:
 * implementation sources - part of the code resembling functionality shared 
within reactor (src/main and similar)
 * private sources - part which is not shared (unit test and similar)
 * dependencies - they change functionality but do not change code

Having this 3 categories correctly represented by a separate checksums, it is 
possibly to implement optimization mentioned above.

In target state, following behavior is desirable:

 
||Change||Changed project||Downstream Project||
|Test sources|rerun tests + later plugins|Reuse cache|
|Test dependency |rerun tests + later plugins except "source-only" 
plugins|Reuse cache|
|Test library project|rerun everything|rerun tests|
|Prod sources|rerun everything|Rerun everything except "source only plugins"|
|Prod dependency|rerun everything except "source-only" plugins|Rerun everything 
except "source only plugins"|

This behavior could be made opt-in

 

  was:
Currently build cache has implementation which checks source code and plugins 
and if it detects mismatch, whole project is rerun. This is is redundant and 
could be optimized in following cases:
 * Test code changed. In that case optimal behavior is to rerun test in an 
affected module and reuse cached artifacts in case of success. Actual behavior: 
change in a test in upstream module invalidates all downstream projects
 * Variation of the situation above is a test library project (aka test-jar) - 
though by convention modification is in production code, because the project is 
used only in test scope - modification of upstream test jar should cause just 
tests rerun 
 * Upstream dependency changed. In that case any plugin which execution is not 
affected by upstream dependency, could be skip. Typically, it could be any of 
linter plugins - like checkstyle, which checks project source code only. 
Current behavior: plugin will rerun

With such granular plugin and sources demarcation, it is possible to 
significantly optimize cached build time.

To address this problem need following changes:
 * changes in build configuration to demarcate plugins as private (no need 
rebuild on dependencies change)
 * split checksum into at least 3 parts - test sources checksum, dependencies 
checksum and  production checksum
 * Take into account changes in every checksum when decision of plugin 
execution is taken. If only dependencies changed, `source-code-only` plugins 
could be skipped
 * When calculating dependencies between reactor projects, take into account 
"production" checksum only. In that case changes in test code will not affect 
downstream projects

Additional challenge is to rerun-tests-only mode - it obviously relies on 
compiled project, but probably that could be worked around by restoring cached 
jar

Summarizing the above and applying ideas of ABI to maven

[jira] [Created] (MBUILDCACHE-31) Implement "source-only" plugin logic

2022-10-27 Thread Alexander Ashitkin (Jira)
Alexander Ashitkin created MBUILDCACHE-31:
-

 Summary: Implement "source-only" plugin logic
 Key: MBUILDCACHE-31
 URL: https://issues.apache.org/jira/browse/MBUILDCACHE-31
 Project: Maven Build Cache Extension
  Issue Type: Sub-task
Reporter: Alexander Ashitkin


* Need to implement following:
add flag to cache config to mark plugin as "sourceOnly" - think of checkstyle
 * if there is a change in dependencies only (eg source code checksums not 
changed)), skip source only plugin


Additional concerns: restore related artifacts (if any)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MBUILDCACHE-31) Implement skipping "source-only" plugin logic

2022-10-27 Thread Alexander Ashitkin (Jira)


 [ 
https://issues.apache.org/jira/browse/MBUILDCACHE-31?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexander Ashitkin updated MBUILDCACHE-31:
--
Summary: Implement skipping "source-only" plugin logic  (was: Implement 
"source-only" plugin logic)

> Implement skipping "source-only" plugin logic
> -
>
> Key: MBUILDCACHE-31
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-31
> Project: Maven Build Cache Extension
>  Issue Type: Sub-task
>Reporter: Alexander Ashitkin
>Priority: Major
>
> * Need to implement following:
> add flag to cache config to mark plugin as "sourceOnly" - think of checkstyle
>  * if there is a change in dependencies only (eg source code checksums not 
> changed)), skip source only plugin
> Additional concerns: restore related artifacts (if any)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-indexer] dependabot[bot] opened a new pull request, #259: Bump maven-shade-plugin from 3.4.0 to 3.4.1

2022-10-27 Thread GitBox


dependabot[bot] opened a new pull request, #259:
URL: https://github.com/apache/maven-indexer/pull/259

   Bumps [maven-shade-plugin](https://github.com/apache/maven-shade-plugin) 
from 3.4.0 to 3.4.1.
   
   Commits
   
   https://github.com/apache/maven-shade-plugin/commit/fbbec08252e8a5a999feaa8652340b1dbfb599f1";>fbbec08
 [maven-release-plugin] prepare release maven-shade-plugin-3.4.1
   https://github.com/apache/maven-shade-plugin/commit/7078d9268b9c37af0ba538360f9c6ca778a8ee08";>7078d92
 [MSHADE-413] Fix endless loop caused by manipulating shared objects (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/124";>#124)
   https://github.com/apache/maven-shade-plugin/commit/0945bcbcefd1144029f86da51a09bd8a805bd158";>0945bcb
 [MSHADE-417] Fix null bytes appended to small files (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/160";>#160)
   https://github.com/apache/maven-shade-plugin/commit/41bd72f0fd0195713f4a4b73af1184ec8a6cc0a3";>41bd72f
 [MSHADE-366] "Access denied" during 'minimizeJar' (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/161";>#161)
   https://github.com/apache/maven-shade-plugin/commit/e342059b991057814a60eb646c312b631ac64167";>e342059
 [MSHADE-432] Duplicate services entries can be generated (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/159";>#159)
   https://github.com/apache/maven-shade-plugin/commit/7603e5778236455c03385e6efa9cf123e82be722";>7603e57
 Bump asmVersion from 9.3 to 9.4 (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/156";>#156)
   https://github.com/apache/maven-shade-plugin/commit/5e955d86b520bdf060d6134eec996685179815dd";>5e955d8
 Bump maven-dependency-tree from 3.0.1 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/148";>#148)
   https://github.com/apache/maven-shade-plugin/commit/5f45ecf5854d335bcf6d3aec14775df76200527e";>5f45ecf
 [MSHADE-431] Use a caching output stream (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/158";>#158)
   https://github.com/apache/maven-shade-plugin/commit/31d350657c205d17aa1e9d9347760f7a329d5cac";>31d3506
 Bump plexus-utils from 3.3.0 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/139";>#139)
   https://github.com/apache/maven-shade-plugin/commit/b039731a87c0b1de82450a8cb0f6b8e72f47cfe9";>b039731
 [MSHADE-430] Remove usage of deprecated ModelBase#getReports()
   Additional commits viewable in https://github.com/apache/maven-shade-plugin/compare/maven-shade-plugin-3.4.0...maven-shade-plugin-3.4.1";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-shade-plugin&package-manager=maven&previous-version=3.4.0&new-version=3.4.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-apache-parent] dependabot[bot] opened a new pull request, #112: Bump maven-shade-plugin from 3.3.0 to 3.4.1

2022-10-27 Thread GitBox


dependabot[bot] opened a new pull request, #112:
URL: https://github.com/apache/maven-apache-parent/pull/112

   Bumps [maven-shade-plugin](https://github.com/apache/maven-shade-plugin) 
from 3.3.0 to 3.4.1.
   
   Commits
   
   https://github.com/apache/maven-shade-plugin/commit/fbbec08252e8a5a999feaa8652340b1dbfb599f1";>fbbec08
 [maven-release-plugin] prepare release maven-shade-plugin-3.4.1
   https://github.com/apache/maven-shade-plugin/commit/7078d9268b9c37af0ba538360f9c6ca778a8ee08";>7078d92
 [MSHADE-413] Fix endless loop caused by manipulating shared objects (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/124";>#124)
   https://github.com/apache/maven-shade-plugin/commit/0945bcbcefd1144029f86da51a09bd8a805bd158";>0945bcb
 [MSHADE-417] Fix null bytes appended to small files (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/160";>#160)
   https://github.com/apache/maven-shade-plugin/commit/41bd72f0fd0195713f4a4b73af1184ec8a6cc0a3";>41bd72f
 [MSHADE-366] "Access denied" during 'minimizeJar' (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/161";>#161)
   https://github.com/apache/maven-shade-plugin/commit/e342059b991057814a60eb646c312b631ac64167";>e342059
 [MSHADE-432] Duplicate services entries can be generated (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/159";>#159)
   https://github.com/apache/maven-shade-plugin/commit/7603e5778236455c03385e6efa9cf123e82be722";>7603e57
 Bump asmVersion from 9.3 to 9.4 (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/156";>#156)
   https://github.com/apache/maven-shade-plugin/commit/5e955d86b520bdf060d6134eec996685179815dd";>5e955d8
 Bump maven-dependency-tree from 3.0.1 to 3.2.0 (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/148";>#148)
   https://github.com/apache/maven-shade-plugin/commit/5f45ecf5854d335bcf6d3aec14775df76200527e";>5f45ecf
 [MSHADE-431] Use a caching output stream (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/158";>#158)
   https://github.com/apache/maven-shade-plugin/commit/31d350657c205d17aa1e9d9347760f7a329d5cac";>31d3506
 Bump plexus-utils from 3.3.0 to 3.4.2 (https://github-redirect.dependabot.com/apache/maven-shade-plugin/issues/139";>#139)
   https://github.com/apache/maven-shade-plugin/commit/b039731a87c0b1de82450a8cb0f6b8e72f47cfe9";>b039731
 [MSHADE-430] Remove usage of deprecated ModelBase#getReports()
   Additional commits viewable in https://github.com/apache/maven-shade-plugin/compare/maven-shade-plugin-3.3.0...maven-shade-plugin-3.4.1";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-shade-plugin&package-manager=maven&previous-version=3.3.0&new-version=3.4.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-apache-parent] dependabot[bot] commented on pull request #105: Bump maven-shade-plugin from 3.3.0 to 3.4.0

2022-10-27 Thread GitBox


dependabot[bot] commented on PR #105:
URL: 
https://github.com/apache/maven-apache-parent/pull/105#issuecomment-1294422427

   Superseded by #112.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-apache-parent] dependabot[bot] closed pull request #105: Bump maven-shade-plugin from 3.3.0 to 3.4.0

2022-10-27 Thread GitBox


dependabot[bot] closed pull request #105: Bump maven-shade-plugin from 3.3.0 to 
3.4.0
URL: https://github.com/apache/maven-apache-parent/pull/105


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #167: Fixes to the plugin descriptor generation

2022-10-27 Thread GitBox


slawekjaranowski commented on PR #167:
URL: 
https://github.com/apache/maven-plugin-tools/pull/167#issuecomment-1294539618

   Can you create issue for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org