[ 
https://issues.apache.org/jira/browse/MPLUGIN-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624992#comment-17624992
 ] 

ASF GitHub Bot commented on MPLUGIN-433:
----------------------------------------

slawekjaranowski commented on code in PR #162:
URL: 
https://github.com/apache/maven-plugin-tools/pull/162#discussion_r1006646150


##########
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report_old/PluginReport.java:
##########
@@ -218,6 +218,19 @@
                 readonly = true )
     private File enhancedPluginXmlFile;
 
+    /**
+     * In case the internal javadoc site has not been generated when running 
this report goal
+     * (e.g. when using an aggregator javadoc report) link validation needs to 
be disabled by setting
+     * this value to {@code true}.
+     * This might have the drawback that some links being generated in the 
report might be broken
+     * in case not all parameter types and javadoc link references are 
resolvable through the sites being given to
+     * {@link DescriptorGeneratorMojo}.
+     * 
+     * @since 3.7.0
+     */
+    @Parameter
+    private boolean disableInternalJavadocLinkValidation;

Review Comment:
   I would like not to add new parameters to deprecated report - what do you 
think?





> Allow to reference aggregator javadoc from plugin report
> --------------------------------------------------------
>
>                 Key: MPLUGIN-433
>                 URL: https://issues.apache.org/jira/browse/MPLUGIN-433
>             Project: Maven Plugin Tools
>          Issue Type: Improvement
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> In some cases (for example in https://github.com/apache/maven-plugin-tools/ 
> itself) the Javadoc is an aggregate being created by the aggregator module 
> (after the plugin report is being executed). Currently those javadoc links 
> are removed on parameter types, as they cannot be validated at the time when 
> "report" is being executed on the individual modules 
> (https://github.com/apache/maven-plugin-tools/blob/14e3d389e08626a52713ae4417e1f4056546a121/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L569).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to