[GitHub] [maven-shade-plugin] gzm55 commented on a diff in pull request #129: [MSHADE-323] make shade plugin compatible with the flatten plugin

2022-09-02 Thread GitBox


gzm55 commented on code in PR #129:
URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843673856


##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set 
artifactsToRemove )
 origDeps = transitiveDeps;
 }
 
-Model model = project.getOriginalModel();
+final Model model = project.getFile() == null

Review Comment:
   hi @rmannibucau , the in Maven, what is `originalModel` defined to be, a 
model of the original pom or a model of the current pom file? If defined as the 
latter one, the global solution of updating originalModel could be done in 
`MavenProject::setPomFile` or `MavenProject::setFile`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] asfgit merged pull request #157: [MJAVADOC-721] Parse stderr output and suppress informational lines

2022-09-02 Thread GitBox


asfgit merged PR #157:
URL: https://github.com/apache/maven-javadoc-plugin/pull/157


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MJAVADOC-721) Parse stderr output and suppress informational lines

2022-09-02 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MJAVADOC-721.
---
Resolution: Fixed

Fixed with 
[139af8ceaedd88d59431575eff21d859ee1548c3|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git&a=commit&h=139af8ceaedd88d59431575eff21d859ee1548c3].

> Parse stderr output and suppress informational lines
> 
>
> Key: MJAVADOC-721
> URL: https://issues.apache.org/jira/browse/MJAVADOC-721
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>  Components: javadoc
>Affects Versions: 3.4.0
>Reporter: Markus Spann
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.4.2
>
>
> From Java 17 the Javadoc tool prints informational output to stderr mixed 
> with actual errors and warnings (see 
> [JDK-8268774|https://bugs.openjdk.org/browse/JDK-8268774], 
> [JDK-8270831|https://bugs.openjdk.org/browse/JDK-8270831]).
> Currently the maven-javadoc-plugin logs the complete content of the tool's 
> stderr as warning or includes it completely in the message of a 
> MavenReportException (in case of an unsuccessful exit code of the tool). This 
> behavior is not optimal with Java 17 onwards.
> The output can be lengthy and the informational messages very distracting. 
> This is particularly true for larger projects.
> This improvement enables the developer/user to focus on the actual warnings 
> or errors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

2022-09-02 Thread GitBox


michael-o commented on code in PR #159:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961384498


##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -183,28 +183,34 @@
 
 /**
  * The options file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String OPTIONS_FILE_NAME = "options";
 
 /**
  * The packages file name in the output directory when 
calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String PACKAGES_FILE_NAME = "packages";
 
 /**
  * The argfile file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String ARGFILE_FILE_NAME = "argfile";
 
 /**
  * The files file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String FILES_FILE_NAME = "files";
 
+/**
+ * The errors file name in the output directory when calling:
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
+ */
+protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   This does not make sense to me. Those files are passed to `javadoc(1)`. 
`errors` isn't passed. It is not related to the set of files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MJAVADOC-721) Parse stderr output and suppress informational lines

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599303#comment-17599303
 ] 

Hudson commented on MJAVADOC-721:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-javadoc-plugin » master 
#36

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-javadoc-plugin/job/master/36/

> Parse stderr output and suppress informational lines
> 
>
> Key: MJAVADOC-721
> URL: https://issues.apache.org/jira/browse/MJAVADOC-721
> Project: Maven Javadoc Plugin
>  Issue Type: Improvement
>  Components: javadoc
>Affects Versions: 3.4.0
>Reporter: Markus Spann
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.4.2
>
>
> From Java 17 the Javadoc tool prints informational output to stderr mixed 
> with actual errors and warnings (see 
> [JDK-8268774|https://bugs.openjdk.org/browse/JDK-8268774], 
> [JDK-8270831|https://bugs.openjdk.org/browse/JDK-8270831]).
> Currently the maven-javadoc-plugin logs the complete content of the tool's 
> stderr as warning or includes it completely in the message of a 
> MavenReportException (in case of an unsuccessful exit code of the tool). This 
> behavior is not optimal with Java 17 onwards.
> The output can be lengthy and the informational messages very distracting. 
> This is particularly true for larger projects.
> This improvement enables the developer/user to focus on the actual warnings 
> or errors.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-integration-testing] michael-o commented on pull request #192: [MNG-7474] Add and fix IT

2022-09-02 Thread GitBox


michael-o commented on PR #192:
URL: 
https://github.com/apache/maven-integration-testing/pull/192#issuecomment-1235239628

   I will review this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] sman-81 commented on pull request #157: [MJAVADOC-721] Parse stderr output and suppress informational lines

2022-09-02 Thread GitBox


sman-81 commented on PR #157:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/157#issuecomment-1235308016

   > Build and compared output. Muss less noise. Nice change.
   
   Thanks! I look forward to this feature in the next release. It was great 
working together @michael-o 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] michael-o commented on pull request #157: [MJAVADOC-721] Parse stderr output and suppress informational lines

2022-09-02 Thread GitBox


michael-o commented on PR #157:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/157#issuecomment-1235327927

   > > Build and compared output. Muss less noise. Nice change.
   > 
   > Thanks! I look forward to this feature in the next release. It was great 
working together @michael-o
   
   Sure, I always appreciate high quality, straightforward patches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #192: [MNG-7474] Add and fix IT

2022-09-02 Thread GitBox


michael-o commented on code in PR #192:
URL: 
https://github.com/apache/maven-integration-testing/pull/192#discussion_r961493115


##
core-it-suite/src/test/resources/mng-7474-session-scope/plugin/pom.xml:
##
@@ -1,20 +1,15 @@
 http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
 4.0.0
 
-
-org.apache.maven.its.mng7474
-parent
-1.0-SNAPSHOT
-
-
+org.apache.maven.its.mng7474
 plugin
 1.0-SNAPSHOT
 maven-plugin
 
 
 1.7
 1.7
-3.1.1
+3.2.1

Review Comment:
   This should be 3.2.5



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] gnodet merged pull request #192: [MNG-7474] Add and fix IT

2022-09-02 Thread GitBox


gnodet merged PR #192:
URL: https://github.com/apache/maven-integration-testing/pull/192


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

2022-09-02 Thread GitBox


alzimmermsft commented on code in PR #159:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961560087


##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -183,28 +183,34 @@
 
 /**
  * The options file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String OPTIONS_FILE_NAME = "options";
 
 /**
  * The packages file name in the output directory when 
calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String PACKAGES_FILE_NAME = "packages";
 
 /**
  * The argfile file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String ARGFILE_FILE_NAME = "argfile";
 
 /**
  * The files file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String FILES_FILE_NAME = "files";
 
+/**
+ * The errors file name in the output directory when calling:
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
+ */
+protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   Just to clarify, is it the Javadoc for the constant that makes no sense or 
the design pattern in general? Asking to know what to change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

2022-09-02 Thread GitBox


michael-o commented on code in PR #159:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961563431


##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -183,28 +183,34 @@
 
 /**
  * The options file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String OPTIONS_FILE_NAME = "options";
 
 /**
  * The packages file name in the output directory when 
calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String PACKAGES_FILE_NAME = "packages";
 
 /**
  * The argfile file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String ARGFILE_FILE_NAME = "argfile";
 
 /**
  * The files file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String FILES_FILE_NAME = "files";
 
+/**
+ * The errors file name in the output directory when calling:
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
+ */
+protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   Those files are designed to be passed as `@arg` files. This new file, does 
not. It does not make logically sense to apply the same documentation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MWRAPPER-77) wrapper:wrapper does not update scripts

2022-09-02 Thread Jira
Tamás Cservenák created MWRAPPER-77:
---

 Summary: wrapper:wrapper does not update scripts
 Key: MWRAPPER-77
 URL: https://issues.apache.org/jira/browse/MWRAPPER-77
 Project: Maven Wrapper
  Issue Type: Bug
  Components: Maven Wrapper Plugin
Reporter: Tamás Cservenák


On my ancient project seems that scripts (mvnw and mvnw.cmd) were not updated 
after I ran {{wrapper:wrapper}} while the rest was okay.

To test my assumption, moved them to mvnw.old and mvnw.cmd.old and re-run 
{{{}wrapper:wrapper{}}}. This time the scripts were written out just fine.

But, they were totally different. This also means that scrpts, once written 
out, will never we updated?

End result I had:
{noformat}
-rwxr-xr-x. 1 cstamas cstamas  9781 máj    8 09.15 mvnw
-rw-r--r--. 1 cstamas cstamas  6889 máj    8 09.15 mvnw.cmd
-rw-r--r--. 1 cstamas cstamas  6607 szept  1 15.55 mvnw.cmd.old
-rwxr-xr-x. 1 cstamas cstamas 10069 szept  1 15.55 mvnw.old {noformat}
 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MWRAPPER-77) wrapper:wrapper does not update scripts

2022-09-02 Thread Jira


[ 
https://issues.apache.org/jira/browse/MWRAPPER-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599426#comment-17599426
 ] 

Tamás Cservenák commented on MWRAPPER-77:
-

May be related https://github.com/codehaus-plexus/plexus-archiver/issues/228

> wrapper:wrapper does not update scripts
> ---
>
> Key: MWRAPPER-77
> URL: https://issues.apache.org/jira/browse/MWRAPPER-77
> Project: Maven Wrapper
>  Issue Type: Bug
>  Components: Maven Wrapper Plugin
>Reporter: Tamás Cservenák
>Priority: Major
>
> On my ancient project seems that scripts (mvnw and mvnw.cmd) were not updated 
> after I ran {{wrapper:wrapper}} while the rest was okay.
> To test my assumption, moved them to mvnw.old and mvnw.cmd.old and re-run 
> {{{}wrapper:wrapper{}}}. This time the scripts were written out just fine.
> But, they were totally different. This also means that scrpts, once written 
> out, will never we updated?
> End result I had:
> {noformat}
> -rwxr-xr-x. 1 cstamas cstamas  9781 máj    8 09.15 mvnw
> -rw-r--r--. 1 cstamas cstamas  6889 máj    8 09.15 mvnw.cmd
> -rw-r--r--. 1 cstamas cstamas  6607 szept  1 15.55 mvnw.cmd.old
> -rwxr-xr-x. 1 cstamas cstamas 10069 szept  1 15.55 mvnw.old {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #193: Disable merge button on GitHub

2022-09-02 Thread GitBox


slawekjaranowski merged PR #193:
URL: https://github.com/apache/maven-integration-testing/pull/193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

2022-09-02 Thread GitBox


alzimmermsft commented on code in PR #159:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r961578775


##
src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java:
##
@@ -183,28 +183,34 @@
 
 /**
  * The options file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String OPTIONS_FILE_NAME = "options";
 
 /**
  * The packages file name in the output directory when 
calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String PACKAGES_FILE_NAME = "packages";
 
 /**
  * The argfile file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String ARGFILE_FILE_NAME = "argfile";
 
 /**
  * The files file name in the output directory when calling:
- * javadoc.exe(or .sh) @options @packages | @argfile 
| @files
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
  */
 protected static final String FILES_FILE_NAME = "files";
 
+/**
+ * The errors file name in the output directory when calling:
+ * javadoc.exe(or .sh) @options @packages | @argfile 
| @files | @errors
+ */
+protected static final String ERRORS_FILE_NAME = "errors";

Review Comment:
   Got it, thanks! I went ahead and updated the Javadocs on the files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MDEP-738) Can't copy dependency from a 3rd party repository

2022-09-02 Thread Delany (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599452#comment-17599452
 ] 

Delany commented on MDEP-738:
-

My requirement was to "download all direct dependencies of a pom at URL to a 
directory". If that pom relies on its parent to configure repositories, and its 
not a SNAPSHOT, its impossible to achieve this using this plugin, either with 3 
cli commands for get/copy/copy-dependencies, or even via a pom.xml

The workaround was to publish the pom with its own repo pointing to the 
third-party repo or a repo to override and block central.

I went with 3 commands each for simplicity. If I'd gone with the pom.xml 
approach, then for each dependency I'd need an execution for the get goal and 
an artifactItem for the copy goal. If I wanted to use the list-repositories 
goal I'd have to specify the dependency yet again as a dependency.

> Can't copy dependency from a 3rd party repository
> -
>
> Key: MDEP-738
> URL: https://issues.apache.org/jira/browse/MDEP-738
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: copy
>Affects Versions: 3.1.2
> Environment: Linux (fc33)
>Reporter: Pawel Veselov
>Priority: Major
> Attachments: copy-X.txt, get-X.txt
>
>
> I can't seem to be able to copy a dependency that I previously downloaded 
> from a 3rd party repository, when referring to it using metaversion.
> This doesn't work, unless I refer to the version directly in the :copy 
> invocation:
> {noformat}
> $ # rm -rf ~/.m2/repository/org/openconext/ # clean up
> $ mvn org.apache.maven.plugins:maven-dependency-plugin:3.1.2:get \
> -DremoteRepositories=excelfore.publichttps://dev-esync.excelfore.com/artifactory/excelfore.public
>  \
> -Dartifact=org.openconext:mujina-idp:LATEST:jar
> $ mvn org.apache.maven.plugins:maven-dependency-plugin:3.1.2:copy \
> -Dartifact=org.openconext:mujina-idp:LATEST:jar -DoutputDirectory=/tmp
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-dependency-plugin:3.1.2:copy (default-cli) on 
> project standalone-pom: Unable to find/resolve artifact.: Failed to read 
> artifact descriptor for org.openconext:mujina-idp:jar:LATEST: Failed to 
> resolve version for org.openconext:mujina-idp:jar:LATEST: Could not find 
> metadata org.openconext:mujina-idp/maven-metadata.xml in local 
> (/home/vps/.m2/repository) -> [Help 1]
> {noformat}
> (this is from a real public repo)
> I figure this has something to do with the fact that plugin has no knowledge 
> of the repository ID, and needs it to find the right metadata file. So maybe 
> the plugin should have "repositoryId" property that can be supplied to it so 
> it knows which metadata file to check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (MDEP-738) Can't copy dependency from a 3rd party repository

2022-09-02 Thread Delany (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599452#comment-17599452
 ] 

Delany edited comment on MDEP-738 at 9/2/22 12:50 PM:
--

My requirement was to "download all direct dependencies of a pom at URL to a 
directory". If that pom relies on its parent to configure repositories, and its 
not a SNAPSHOT, its impossible to achieve this using this plugin, either with 3 
cli commands for get/copy/copy-dependencies, or even via a pom.xml

The workaround was to publish the pom with its own repo pointing to the 
third-party repo, do the get/copy with the pom.xml, and copy-dependencies with 
the command.


was (Author: delany):
My requirement was to "download all direct dependencies of a pom at URL to a 
directory". If that pom relies on its parent to configure repositories, and its 
not a SNAPSHOT, its impossible to achieve this using this plugin, either with 3 
cli commands for get/copy/copy-dependencies, or even via a pom.xml

The workaround was to publish the pom with its own repo pointing to the 
third-party repo or a repo to override and block central.

I went with 3 commands each for simplicity. If I'd gone with the pom.xml 
approach, then for each dependency I'd need an execution for the get goal and 
an artifactItem for the copy goal. If I wanted to use the list-repositories 
goal I'd have to specify the dependency yet again as a dependency.

> Can't copy dependency from a 3rd party repository
> -
>
> Key: MDEP-738
> URL: https://issues.apache.org/jira/browse/MDEP-738
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>  Components: copy
>Affects Versions: 3.1.2
> Environment: Linux (fc33)
>Reporter: Pawel Veselov
>Priority: Major
> Attachments: copy-X.txt, get-X.txt
>
>
> I can't seem to be able to copy a dependency that I previously downloaded 
> from a 3rd party repository, when referring to it using metaversion.
> This doesn't work, unless I refer to the version directly in the :copy 
> invocation:
> {noformat}
> $ # rm -rf ~/.m2/repository/org/openconext/ # clean up
> $ mvn org.apache.maven.plugins:maven-dependency-plugin:3.1.2:get \
> -DremoteRepositories=excelfore.publichttps://dev-esync.excelfore.com/artifactory/excelfore.public
>  \
> -Dartifact=org.openconext:mujina-idp:LATEST:jar
> $ mvn org.apache.maven.plugins:maven-dependency-plugin:3.1.2:copy \
> -Dartifact=org.openconext:mujina-idp:LATEST:jar -DoutputDirectory=/tmp
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-dependency-plugin:3.1.2:copy (default-cli) on 
> project standalone-pom: Unable to find/resolve artifact.: Failed to read 
> artifact descriptor for org.openconext:mujina-idp:jar:LATEST: Failed to 
> resolve version for org.openconext:mujina-idp:jar:LATEST: Could not find 
> metadata org.openconext:mujina-idp/maven-metadata.xml in local 
> (/home/vps/.m2/repository) -> [Help 1]
> {noformat}
> (this is from a real public repo)
> I figure this has something to do with the fact that plugin has no knowledge 
> of the repository ID, and needs it to find the right metadata file. So maybe 
> the plugin should have "repositoryId" property that can be supplied to it so 
> it knows which metadata file to check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request, #141: Bump qdox from 2.0.1 to 2.0.2

2022-09-02 Thread GitBox


dependabot[bot] opened a new pull request, #141:
URL: https://github.com/apache/maven-plugin-tools/pull/141

   Bumps [qdox](https://github.com/paul-hammant/qdox) from 2.0.1 to 2.0.2.
   
   Commits
   
   https://github.com/paul-hammant/qdox/commit/cfa36337df8d48e400e9b02249d6d6491234bcbc";>cfa3633
 [maven-release-plugin] prepare release qdox-2.0.2
   https://github.com/paul-hammant/qdox/commit/c57b152fc8c7b1672a433a271ac59d40cc42812a";>c57b152
 https://github-redirect.dependabot.com/paul-hammant/qdox/issues/99";>#99
 Seems QDox 2.0.1 has issue parsing parameter names named 
"recordList"
   https://github.com/paul-hammant/qdox/commit/c887457779b8b3b41a7226147bcd0bd9163161ff";>c887457
 https://github-redirect.dependabot.com/paul-hammant/qdox/issues/90";>#90
 Seems QDox 2.0.1 has issue parsing parameter names named 
"record"
   https://github.com/paul-hammant/qdox/commit/89461e6a94d3bcddd862b41c32e97ded37bd1f07";>89461e6
 replace travis-ci by GitHub Actions (https://github-redirect.dependabot.com/paul-hammant/qdox/issues/82";>#82)
   https://github.com/paul-hammant/qdox/commit/caa7c92bed4e0fee2c97968ef47c573e2d7df4c1";>caa7c92
 [maven-release-plugin] prepare for next development iteration
   See full diff in https://github.com/paul-hammant/qdox/compare/qdox-2.0.1...qdox-2.0.2";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.thoughtworks.qdox:qdox&package-manager=maven&previous-version=2.0.1&new-version=2.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MSHARED-1124) Add new version of methods filterFile and newDefaultFilterMap

2022-09-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1124:
-
Summary: Add new version of methods filterFile and newDefaultFilterMap  
(was: Remove deprecated methods for next major release)

> Add new version of methods filterFile and newDefaultFilterMap
> -
>
> Key: MSHARED-1124
> URL: https://issues.apache.org/jira/browse/MSHARED-1124
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-verifier] slawekjaranowski merged pull request #39: [MSHARED-1124] Add new version of methods filterFile and newDefaultFilterMap

2022-09-02 Thread GitBox


slawekjaranowski merged PR #39:
URL: https://github.com/apache/maven-verifier/pull/39


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MSHARED-1124) Add new version of methods filterFile and newDefaultFilterMap

2022-09-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1124:
-
Description: 
Deprecated method 
{code}
Verifier#filterFile(java.lang.String, java.lang.String, java.lang.String, 
java.util.Properties)
{code}

is used about 262 times by Maven core integration test, most of case we have 
code, like:

{code}
verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", 
verifier.newDefaultFilterProperties() );
{code}

With a new method can  be replaced by:

{code}
verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8" );
{code}


> Add new version of methods filterFile and newDefaultFilterMap
> -
>
> Key: MSHARED-1124
> URL: https://issues.apache.org/jira/browse/MSHARED-1124
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> Deprecated method 
> {code}
> Verifier#filterFile(java.lang.String, java.lang.String, java.lang.String, 
> java.util.Properties)
> {code}
> is used about 262 times by Maven core integration test, most of case we have 
> code, like:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", 
> verifier.newDefaultFilterProperties() );
> {code}
> With a new method can  be replaced by:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8" );
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1124) Add new version of methods filterFile and newDefaultFilterMap

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599615#comment-17599615
 ] 

Hudson commented on MSHARED-1124:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-verifier » master #32

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-verifier/job/master/32/

> Add new version of methods filterFile and newDefaultFilterMap
> -
>
> Key: MSHARED-1124
> URL: https://issues.apache.org/jira/browse/MSHARED-1124
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> Deprecated method 
> {code}
> Verifier#filterFile(java.lang.String, java.lang.String, java.lang.String, 
> java.util.Properties)
> {code}
> is used about 262 times by Maven core integration test, most of case we have 
> code, like:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", 
> verifier.newDefaultFilterProperties() );
> {code}
> With a new method can  be replaced by:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8" );
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1124) Add new version of methods filterFile and newDefaultFilterMap

2022-09-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1124.

Resolution: Fixed

> Add new version of methods filterFile and newDefaultFilterMap
> -
>
> Key: MSHARED-1124
> URL: https://issues.apache.org/jira/browse/MSHARED-1124
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> Deprecated method 
> {code}
> Verifier#filterFile(java.lang.String, java.lang.String, java.lang.String, 
> java.util.Properties)
> {code}
> is used about 262 times by Maven core integration test, most of case we have 
> code, like:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8", 
> verifier.newDefaultFilterProperties() );
> {code}
> With a new method can  be replaced by:
> {code}
> verifier.filterFile( "settings-template.xml", "settings.xml", "UTF-8" );
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-690) Change package from org.apache.maven.it to org.apache.maven.shared.verifier

2022-09-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-690.
---
  Assignee: Guillaume Nodet  (was: Robert Scholte)
Resolution: Fixed

> Change package from org.apache.maven.it to org.apache.maven.shared.verifier
> ---
>
> Key: MSHARED-690
> URL: https://issues.apache.org/jira/browse/MSHARED-690
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-verifier
>Affects Versions: maven-verifier-1.7.0
>Reporter: Karl Heinz Marbaise
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> I think it makes sense to change the package name from 
> {{org.apache.maven.it}} to {{org.apache.maven.shared.verifier}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-verifier] slawekjaranowski commented on pull request #33: Bump maven-resolver-connector-basic from 1.6.3 to 1.8.2

2022-09-02 Thread GitBox


slawekjaranowski commented on PR #33:
URL: https://github.com/apache/maven-verifier/pull/33#issuecomment-1235725027

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-verifier] slawekjaranowski commented on pull request #34: Bump maven-resolver-transport-http from 1.6.3 to 1.8.2

2022-09-02 Thread GitBox


slawekjaranowski commented on PR #34:
URL: https://github.com/apache/maven-verifier/pull/34#issuecomment-1235725230

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-verifier] slawekjaranowski opened a new pull request, #40: [MSHARED-1127] Remove main method from Verifier

2022-09-02 Thread GitBox


slawekjaranowski opened a new pull request, #40:
URL: https://github.com/apache/maven-verifier/pull/40

   also remove code used by main method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-verifier] slawekjaranowski merged pull request #40: [MSHARED-1127] Remove main method from Verifier

2022-09-02 Thread GitBox


slawekjaranowski merged PR #40:
URL: https://github.com/apache/maven-verifier/pull/40


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MSHARED-1127) Remove main method from Verifier

2022-09-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1127.

  Assignee: Slawomir Jaranowski
Resolution: Fixed

> Remove main method from Verifier
> 
>
> Key: MSHARED-1127
> URL: https://issues.apache.org/jira/browse/MSHARED-1127
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> There is {{main}} method in Verifier, it is undocumented feature and probably 
> not used. 
> Verifier should be called form test code not from command line.
> We can also remove code used only for it.
> Code use in main method parse arguments for command line.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1127) Remove main method from Verifier

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599696#comment-17599696
 ] 

Hudson commented on MSHARED-1127:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-verifier » master #34

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-verifier/job/master/34/

> Remove main method from Verifier
> 
>
> Key: MSHARED-1127
> URL: https://issues.apache.org/jira/browse/MSHARED-1127
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-verifier
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> There is {{main}} method in Verifier, it is undocumented feature and probably 
> not used. 
> Verifier should be called form test code not from command line.
> We can also remove code used only for it.
> Code use in main method parse arguments for command line.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] hgschmie merged pull request #797: [MNG-7529] Maven resolver makes bad repository choices

2022-09-02 Thread GitBox


hgschmie merged PR #797:
URL: https://github.com/apache/maven/pull/797


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7529) Maven resolver makes bad repository choices when resolving version ranges

2022-09-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599766#comment-17599766
 ] 

ASF GitHub Bot commented on MNG-7529:
-

hgschmie merged PR #797:
URL: https://github.com/apache/maven/pull/797




> Maven resolver makes bad repository choices when resolving version ranges
> -
>
> Key: MNG-7529
> URL: https://issues.apache.org/jira/browse/MNG-7529
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.8.6
>Reporter: Henning Schmiedehausen
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> This is the same problem as MRESOLVER-270. The problem is actually in the 
> maven core, not in the resolver. See the description there.
>  
> This bug is a placeholder for the fix PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] hgschmie merged pull request #796: [MNG-7529] Maven resolver makes bad repository choices

2022-09-02 Thread GitBox


hgschmie merged PR #796:
URL: https://github.com/apache/maven/pull/796


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MNG-7529) Maven resolver makes bad repository choices when resolving version ranges

2022-09-02 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599767#comment-17599767
 ] 

ASF GitHub Bot commented on MNG-7529:
-

hgschmie merged PR #796:
URL: https://github.com/apache/maven/pull/796




> Maven resolver makes bad repository choices when resolving version ranges
> -
>
> Key: MNG-7529
> URL: https://issues.apache.org/jira/browse/MNG-7529
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.8.6
>Reporter: Henning Schmiedehausen
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> This is the same problem as MRESOLVER-270. The problem is actually in the 
> maven core, not in the resolver. See the description there.
>  
> This bug is a placeholder for the fix PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7474) SessionScoped beans should be singletons for a given session

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599771#comment-17599771
 ] 

Hudson commented on MNG-7474:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #67

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/67/

> SessionScoped beans should be singletons for a given session
> 
>
> Key: MNG-7474
> URL: https://issues.apache.org/jira/browse/MNG-7474
> Project: Maven
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Investigate an solution different from MNG-7347.
> This is a real problem for maven-build-cache-extension which rely on the 
> {{@SessionScope}} a lot.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7529) Maven resolver makes bad repository choices when resolving version ranges

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599770#comment-17599770
 ] 

Hudson commented on MNG-7529:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #67

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/67/

> Maven resolver makes bad repository choices when resolving version ranges
> -
>
> Key: MNG-7529
> URL: https://issues.apache.org/jira/browse/MNG-7529
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.8.6
>Reporter: Henning Schmiedehausen
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> This is the same problem as MRESOLVER-270. The problem is actually in the 
> maven core, not in the resolver. See the description there.
>  
> This bug is a placeholder for the fix PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7020) Remove Maven 2 WagonExcluder backward compat code

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599774#comment-17599774
 ] 

Hudson commented on MNG-7020:
-

Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #42

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/42/

> Remove Maven 2 WagonExcluder backward compat code
> -
>
> Key: MNG-7020
> URL: https://issues.apache.org/jira/browse/MNG-7020
> Project: Maven
>  Issue Type: Task
>  Components: Class Loading, Dependencies
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-alpha-1, 4.0.0
>
> Attachments: mng5669-log_post-mng7020.txt, mng5669-log_pre-mng7020.txt
>
>
> Maven includes a Wagon Excluder when Maven 2 artifacts are used with Wagon 
> 1.0.x: 
> https://maven.apache.org/ref/3.8.4/maven-core/xref/org/apache/maven/plugin/internal/WagonExcluder.html
> This is ancient Maven 2 backward compat.
> Let's remove it and hope everyone has moved on to Maven 3.x artifacts and 
> Wagon 3.x.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7529) Maven resolver makes bad repository choices when resolving version ranges

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599772#comment-17599772
 ] 

Hudson commented on MNG-7529:
-

Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #42

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/42/

> Maven resolver makes bad repository choices when resolving version ranges
> -
>
> Key: MNG-7529
> URL: https://issues.apache.org/jira/browse/MNG-7529
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.8.6
>Reporter: Henning Schmiedehausen
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> This is the same problem as MRESOLVER-270. The problem is actually in the 
> maven core, not in the resolver. See the description there.
>  
> This bug is a placeholder for the fix PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7353) Add support for "mvn pluginPrefix:version:goal"

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599773#comment-17599773
 ] 

Hudson commented on MNG-7353:
-

Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #42

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/42/

> Add support for "mvn pluginPrefix:version:goal"
> ---
>
> Key: MNG-7353
> URL: https://issues.apache.org/jira/browse/MNG-7353
> Project: Maven
>  Issue Type: New Feature
>  Components: Command Line
>Affects Versions: 3.8.4
>Reporter: Herve Boutemy
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> currently, we can run a simplified 2 parts form {noformat}mvn 
> wrapper:wrapper{noformat}
> but if we want to specify a version, we need to switch to full 4 prts form:
> {noformat}mvn 
> org.apache.maven.plugins:maven-wrapper-plugin:3.1.0-SNAPSHOT:wrapper{noformat}
> it would be nice to be able to write 3 parts simplified {noformat}mvn 
> wrapper:3.1.0-SNAPSHOT:wrapper{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7474) SessionScoped beans should be singletons for a given session

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599775#comment-17599775
 ] 

Hudson commented on MNG-7474:
-

Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #42

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/42/

> SessionScoped beans should be singletons for a given session
> 
>
> Key: MNG-7474
> URL: https://issues.apache.org/jira/browse/MNG-7474
> Project: Maven
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Investigate an solution different from MNG-7347.
> This is a real problem for maven-build-cache-extension which rely on the 
> {{@SessionScope}} a lot.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7517) MavenITmng6391PrintVersionTest tests fail under unknown circumstances

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599776#comment-17599776
 ] 

Hudson commented on MNG-7517:
-

Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #42

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/42/

> MavenITmng6391PrintVersionTest tests fail under unknown circumstances
> -
>
> Key: MNG-7517
> URL: https://issues.apache.org/jira/browse/MNG-7517
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Marc Wrobel
>Assignee: Michael Osipov
>Priority: Minor
> Attachments: build.log, 
> mng-6391-print-version-aggregator-version-log.txt, 
> mng-6391-print-version-version-log.txt
>
>
> When testing PR [https://github.com/apache/maven/pull/772] I could not run 
> the Core IT successfully. The {{MavenITmng6391PrintVersionTest}} tests 
> ({{{}testitShouldPrintVersionAtTopAndAtBottom{}}} and 
> {{{}itShouldPrintVersionInAllLines{}}}) consistently failed on my laptop 
> using the latest build of Maven from [https://github.com/apache/maven] 
> (master branch - find attached the full [^build.log]) :
> {code:java}
> $ mvn -B clean install -l /tmp/build.log -Prun-its 
> -DmavenDistro=/home/mwrobel/projects/oss/maven/apache-maven/target/apache-maven-4.0.0-alpha-1-SNAPSHOT-bin.zip
> ...
> [INFO] Running org.apache.maven.it.IntegrationTestSuite
> Running integration tests for Maven 4.0.0-alpha-1-SNAPSHOT
>     using Maven executable: 
> /home/mwrobel/projects/oss/maven-integration-testing/core-it-suite/target/apache-maven/bin/mvn
>     with verifier.forkMode: not defined == fork
> Bootstrap.Bootstrap() 
> OK (2.8 s)
> mng6506 PackageAnnotation.GetPackageAnnotation(). 
> OK (0.8 s)
> mng6391 PrintVersion.itShouldPrintVersionAtTopAndAtBottom().. 
> FAILURE (0.1 s)
> mng6391 PrintVersion.itShouldPrintVersionInAllLines() 
> FAILURE (0.1 s)
> mng6386 BaseUriProperty.itMNG6386UnicodeChars().. 
> OK (0.0 s)
> ...
> [ERROR] Tests run: 915, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 
> 249.505 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testitShouldPrintVersionAtTopAndAtBottom(org.apache.maven.it.MavenITmng6391PrintVersionTest)
>   Time elapsed: 0.054 s  <<< FAILURE!
> junit.framework.AssertionFailedError
>     at 
> org.apache.maven.it.MavenITmng6391PrintVersionTest.testitShouldPrintVersionAtTopAndAtBottom(MavenITmng6391PrintVersionTest.java:77)[ERROR]
>  
> testitShouldPrintVersionInAllLines(org.apache.maven.it.MavenITmng6391PrintVersionTest)
>   Time elapsed: 0.05 s  <<< FAILURE!
> junit.framework.AssertionFailedError
>     at 
> org.apache.maven.it.MavenITmng6391PrintVersionTest.testitShouldPrintVersionInAllLines(MavenITmng6391PrintVersionTest.java:113)[INFO]
>  
> [INFO] Results:
> [INFO] 
> [ERROR] Failures: 
> [ERROR]   
> MavenITmng6391PrintVersionTest>AbstractMavenIntegrationTestCase.runTest:260->testitShouldPrintVersionAtTopAndAtBottom:77
> [ERROR]   
> MavenITmng6391PrintVersionTest>AbstractMavenIntegrationTestCase.runTest:260->testitShouldPrintVersionInAllLines:113
> [INFO] 
> [ERROR] Tests run: 915, Failures: 2, Errors: 0, Skipped: 0
> {code}
> The failure is due to the Reactor Summary. Here are the expected and the 
> actual summaries for {{testitShouldPrintVersionAtTopAndAtBottom}} :
> {code:java}
> // expected
> [INFO] Reactor Summary for base-project 1.3.0-SNAPSHOT:
> [INFO] base-project ... SUCCESS [
> [INFO] module-1 ... SUCCESS [
> [INFO] module-2 ... SUCCESS [
> [INFO] module-3 ... SUCCESS [
> // actual
> [INFO] Reactor Summary for base-project 1.3.0-SNAPSHOT:
> [INFO] base-project 
> .
>  SUCCESS [
> [INFO] module-1 
> .
>  SUCCESS [
> [INFO] module-2 
> .
>  SUCCESS [
> [INFO] module-3 
> .
>  SUCCESS [
> {code}
> Actual results for both tests are attached.
> I used the following versions for both the Maven build and for launching the 
> Core IT :
> {code:bash}
> $ mvn -v
> Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
> Maven home: /home/mwrobel/.asdf/installs/maven/3.8.6
> Java vers

[jira] [Commented] (MNG-7443) Implement consistent logging between optional projects and optional profiles

2022-09-02 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17599777#comment-17599777
 ] 

Hudson commented on MNG-7443:
-

Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #42

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/42/

> Implement consistent logging between optional projects and optional profiles
> 
>
> Key: MNG-7443
> URL: https://issues.apache.org/jira/browse/MNG-7443
> Project: Maven
>  Issue Type: Improvement
>  Components: Core, Logging
>Affects Versions: 4.0.0-alpha-1
>Reporter: Giovanni van der Schelde
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.0.0-alpha-1, 4.0.0
>
> Attachments: example.png
>
>
> Maven 4 introduces optional profiles and optional projects. However, the 
> feedback provided to the user on whether a project or profile has been 
> skipped is inconsistent between the two (see image attached). 
> For profiles, it will be logged twice: before and after the build.
> For projects, it will be logged once: before the build.
> The idea would be to log the information for skipped optional projects after 
> the build as well.
> !example.png!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)