gzm55 commented on code in PR #129:
URL: https://github.com/apache/maven-shade-plugin/pull/129#discussion_r843673856
##########
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##########
@@ -1090,7 +1092,10 @@ private void createDependencyReducedPom( Set<String>
artifactsToRemove )
origDeps = transitiveDeps;
}
- Model model = project.getOriginalModel();
+ final Model model = project.getFile() == null
Review Comment:
hi @rmannibucau , the in Maven, what is `originalModel` defined to be, a
model of the original pom or a model of the current pom file? If defined as the
latter one, the global solution of updating originalModel could be done in
`MavenProject::setPomFile` or `MavenProject::setFile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
