[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #139: MPLUGIN-417 Descriptor with plain text by default
kwin commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956550981
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -43,12 +42,6 @@
@Parameter( defaultValue = "${project}", readonly = true )
protected MavenProject project;
-/**
- * The goal prefix that will appear before the ":".
- */
-@Parameter
-protected String goalPrefix;
Review Comment:
As I said: " is almost useless". This only affects the comments on the class
which is evaluated by report. I would rather get rid of the prefix in the
comment and and just reference the full Maven coordinates here. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-417) report and descriptor goal need to evaluate Javadoc comments differently
[
https://issues.apache.org/jira/browse/MPLUGIN-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585697#comment-17585697
]
ASF GitHub Bot commented on MPLUGIN-417:
kwin commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956550981
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -43,12 +42,6 @@
@Parameter( defaultValue = "${project}", readonly = true )
protected MavenProject project;
-/**
- * The goal prefix that will appear before the ":".
- */
-@Parameter
-protected String goalPrefix;
Review Comment:
As I said: " is almost useless". This only affects the comments on the class
which is evaluated by report. I would rather get rid of the prefix in the
comment and and just reference the full Maven coordinates here. WDYT?
> report and descriptor goal need to evaluate Javadoc comments differently
>
>
> Key: MPLUGIN-417
> URL: https://issues.apache.org/jira/browse/MPLUGIN-417
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.7.0
>
>
> Currently it is not explicitly specified in
> [https://maven.apache.org/ref/3.8.4/maven-plugin-api/plugin.html] which
> format the {{description}} field on plugin, mojo and parameter level should
> have.
> It partially contains HTML tags (also from converted inline javadoc taglets)
> which is problematic for
> [https://maven.apache.org/plugins/maven-help-plugin/describe-mojo.html]
> (which expects plain text).
> On the other hand, the same plugin descriptor is currently leveraged for goal
> {{report}} which should include all those HTML details from the source
> comment.
> Therefore both goals need to extract metadata from source files differently
> and {{report}} can no longer rely on the previously generated plugin
> descriptor file.
> In addition even the plain text descriptor should contain as many details as
> possible, i.e. it should be converted javadoc taglets -> html -> plain text
> to no loose any detail.
> Currently the plugin descriptor is written with
> {{{}GeneratorUtils.toText(){}}}at
> [https://github.com/apache/maven-plugin-tools/blob/706b1d0b6730d028350f18d8459eee8b123e2f67/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java#L186]
> which has the following flaws
> # Still emits {{ # Does not resolve all javadoc tags
> # Does never emit a proper link for link javadoc taglets
>
> The proposal is that
> # goal {{descriptor}} generates three different descriptor serializations
> (based on the same in-memory HTML descriptor):
> ## one with plain text according to
> [https://maven.apache.org/ref/3.8.4/maven-plugin-api/plugin.html]
> ## one with plain text and additional attributes for {{helpmojo}}
> ## another temporary one to be used from {{report}} containing HTML values
> # goal {{helpmojo}} evaluates the deserialized descriptor from 2 at
> execution time of the resulting "help" mojo
> # goal {{report}} evaluates the deserialized enhanced descriptor from 3.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7156) Parallel build can cause issues between clean and forked goals
[
https://issues.apache.org/jira/browse/MNG-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585700#comment-17585700
]
Michael Osipov commented on MNG-7156:
-
Is your plugin public?
> Parallel build can cause issues between clean and forked goals
> --
>
> Key: MNG-7156
> URL: https://issues.apache.org/jira/browse/MNG-7156
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Running {{mvn -T12 clean verify -Papache-release}} From
> [https://github.com/apache/jackrabbit-filevault] leads to various exceptions
> caused by the invocation of the {{clean}} goal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] kwin commented on a diff in pull request #139: MPLUGIN-417 Descriptor with plain text by default
kwin commented on code in PR #139: URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956553530 ## pom.xml: ## @@ -94,9 +94,13 @@ 8 3.3.0 3.2.5 + Review Comment: Not sure, as even minor versions may introduce new features which are backwards-compatible (i.e. new methods added to API). When you leverage those your code breaks when running with an older SLF4J API dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-417) report and descriptor goal need to evaluate Javadoc comments differently
[
https://issues.apache.org/jira/browse/MPLUGIN-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585705#comment-17585705
]
ASF GitHub Bot commented on MPLUGIN-417:
kwin commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956553530
##
pom.xml:
##
@@ -94,9 +94,13 @@
8
3.3.0
3.2.5
+ report and descriptor goal need to evaluate Javadoc comments differently
>
>
> Key: MPLUGIN-417
> URL: https://issues.apache.org/jira/browse/MPLUGIN-417
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.7.0
>
>
> Currently it is not explicitly specified in
> [https://maven.apache.org/ref/3.8.4/maven-plugin-api/plugin.html] which
> format the {{description}} field on plugin, mojo and parameter level should
> have.
> It partially contains HTML tags (also from converted inline javadoc taglets)
> which is problematic for
> [https://maven.apache.org/plugins/maven-help-plugin/describe-mojo.html]
> (which expects plain text).
> On the other hand, the same plugin descriptor is currently leveraged for goal
> {{report}} which should include all those HTML details from the source
> comment.
> Therefore both goals need to extract metadata from source files differently
> and {{report}} can no longer rely on the previously generated plugin
> descriptor file.
> In addition even the plain text descriptor should contain as many details as
> possible, i.e. it should be converted javadoc taglets -> html -> plain text
> to no loose any detail.
> Currently the plugin descriptor is written with
> {{{}GeneratorUtils.toText(){}}}at
> [https://github.com/apache/maven-plugin-tools/blob/706b1d0b6730d028350f18d8459eee8b123e2f67/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java#L186]
> which has the following flaws
> # Still emits {{ # Does not resolve all javadoc tags
> # Does never emit a proper link for link javadoc taglets
>
> The proposal is that
> # goal {{descriptor}} generates three different descriptor serializations
> (based on the same in-memory HTML descriptor):
> ## one with plain text according to
> [https://maven.apache.org/ref/3.8.4/maven-plugin-api/plugin.html]
> ## one with plain text and additional attributes for {{helpmojo}}
> ## another temporary one to be used from {{report}} containing HTML values
> # goal {{helpmojo}} evaluates the deserialized descriptor from 2 at
> execution time of the resulting "help" mojo
> # goal {{report}} evaluates the deserialized enhanced descriptor from 3.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7156) Parallel build can cause issues between clean and forked goals
[
https://issues.apache.org/jira/browse/MNG-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585714#comment-17585714
]
David Elliott commented on MNG-7156:
No, but I'm willing to create a test case that illustrates the issue.
> Parallel build can cause issues between clean and forked goals
> --
>
> Key: MNG-7156
> URL: https://issues.apache.org/jira/browse/MNG-7156
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Running {{mvn -T12 clean verify -Papache-release}} From
> [https://github.com/apache/jackrabbit-filevault] leads to various exceptions
> caused by the invocation of the {{clean}} goal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7156) Parallel build can cause issues between clean and forked goals
[
https://issues.apache.org/jira/browse/MNG-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585718#comment-17585718
]
Michael Osipov commented on MNG-7156:
-
Would be great. If this is valid, it'd qualify for 3.8.7.
> Parallel build can cause issues between clean and forked goals
> --
>
> Key: MNG-7156
> URL: https://issues.apache.org/jira/browse/MNG-7156
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Running {{mvn -T12 clean verify -Papache-release}} From
> [https://github.com/apache/jackrabbit-filevault] leads to various exceptions
> caused by the invocation of the {{clean}} goal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPLUGIN-419) Allow @Parameter on setters methods
[
https://issues.apache.org/jira/browse/MPLUGIN-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MPLUGIN-419:
Description:
We needn't filed for Mojo parameters.
When setters method exist it is called first by Maven.
We can declare Mojo as:
{code:java}
@Mojo( name = "my-mojo" )
public class MyMojo extends AbstractMojo
{
@Parameter
private String param;
public void execute()
{
}
}
{code}
In some case will be useful to have possibility to declare as:
{code:java}
@Mojo( name = "my-mojo" )
public class MyMojo extends AbstractMojo
{
@Parameter
public void setParam(String param)
{
// do something with param
}
public void execute()
{
}
}
{code}
eg, useful:
- normalization
- validation
- split one input value to more items, the same or other type
was:
We needn't filed for Mojo parameters.
When setters method exist it is called first by Maven.
We can declare Mojo as:
{code:java}
@Mojo( name = "my-mojo" )
public class MyMojo extends AbstractMojo
{
@Parameter
private String param;
public void execute()
{
}
}
{code}
In some case will be useful to have possibility to declare as:
{code:java}
@Mojo( name = "my-mojo" )
public class MyMojo extends AbstractMojo
{
@Parameter
public void setParam(String param)
{
// do something with param
}
public void execute()
{
}
}
{code}
> Allow @Parameter on setters methods
> ---
>
> Key: MPLUGIN-419
> URL: https://issues.apache.org/jira/browse/MPLUGIN-419
> Project: Maven Plugin Tools
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We needn't filed for Mojo parameters.
> When setters method exist it is called first by Maven.
> We can declare Mojo as:
> {code:java}
> @Mojo( name = "my-mojo" )
> public class MyMojo extends AbstractMojo
> {
> @Parameter
> private String param;
> public void execute()
> {
> }
> }
> {code}
> In some case will be useful to have possibility to declare as:
> {code:java}
> @Mojo( name = "my-mojo" )
> public class MyMojo extends AbstractMojo
> {
> @Parameter
> public void setParam(String param)
> {
> // do something with param
> }
> public void execute()
> {
> }
> }
> {code}
> eg, useful:
> - normalization
> - validation
> - split one input value to more items, the same or other type
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-419) Allow @Parameter on setters methods
[
https://issues.apache.org/jira/browse/MPLUGIN-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585719#comment-17585719
]
Slawomir Jaranowski commented on MPLUGIN-419:
-
I added some of case .. :) of course can be done without setters methods
There is documentations about using setters:
[https://maven.apache.org/guides/plugin/guide-java-plugin-development.html#using-setters]
> Allow @Parameter on setters methods
> ---
>
> Key: MPLUGIN-419
> URL: https://issues.apache.org/jira/browse/MPLUGIN-419
> Project: Maven Plugin Tools
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We needn't filed for Mojo parameters.
> When setters method exist it is called first by Maven.
> We can declare Mojo as:
> {code:java}
> @Mojo( name = "my-mojo" )
> public class MyMojo extends AbstractMojo
> {
> @Parameter
> private String param;
> public void execute()
> {
> }
> }
> {code}
> In some case will be useful to have possibility to declare as:
> {code:java}
> @Mojo( name = "my-mojo" )
> public class MyMojo extends AbstractMojo
> {
> @Parameter
> public void setParam(String param)
> {
> // do something with param
> }
> public void execute()
> {
> }
> }
> {code}
> eg, useful:
> - normalization
> - validation
> - split one input value to more items, the same or other type
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #139: MPLUGIN-417 Descriptor with plain text by default
slawekjaranowski commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956563467
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -43,12 +42,6 @@
@Parameter( defaultValue = "${project}", readonly = true )
protected MavenProject project;
-/**
- * The goal prefix that will appear before the ":".
- */
-@Parameter
-protected String goalPrefix;
Review Comment:
It is needed for this change?
If no - can we move such change to separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-417) report and descriptor goal need to evaluate Javadoc comments differently
[
https://issues.apache.org/jira/browse/MPLUGIN-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585727#comment-17585727
]
ASF GitHub Bot commented on MPLUGIN-417:
slawekjaranowski commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956563467
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/AbstractGeneratorMojo.java:
##
@@ -43,12 +42,6 @@
@Parameter( defaultValue = "${project}", readonly = true )
protected MavenProject project;
-/**
- * The goal prefix that will appear before the ":".
- */
-@Parameter
-protected String goalPrefix;
Review Comment:
It is needed for this change?
If no - can we move such change to separate PR?
> report and descriptor goal need to evaluate Javadoc comments differently
>
>
> Key: MPLUGIN-417
> URL: https://issues.apache.org/jira/browse/MPLUGIN-417
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Components: Plugin Plugin
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.7.0
>
>
> Currently it is not explicitly specified in
> [https://maven.apache.org/ref/3.8.4/maven-plugin-api/plugin.html] which
> format the {{description}} field on plugin, mojo and parameter level should
> have.
> It partially contains HTML tags (also from converted inline javadoc taglets)
> which is problematic for
> [https://maven.apache.org/plugins/maven-help-plugin/describe-mojo.html]
> (which expects plain text).
> On the other hand, the same plugin descriptor is currently leveraged for goal
> {{report}} which should include all those HTML details from the source
> comment.
> Therefore both goals need to extract metadata from source files differently
> and {{report}} can no longer rely on the previously generated plugin
> descriptor file.
> In addition even the plain text descriptor should contain as many details as
> possible, i.e. it should be converted javadoc taglets -> html -> plain text
> to no loose any detail.
> Currently the plugin descriptor is written with
> {{{}GeneratorUtils.toText(){}}}at
> [https://github.com/apache/maven-plugin-tools/blob/706b1d0b6730d028350f18d8459eee8b123e2f67/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java#L186]
> which has the following flaws
> # Still emits {{ # Does not resolve all javadoc tags
> # Does never emit a proper link for link javadoc taglets
>
> The proposal is that
> # goal {{descriptor}} generates three different descriptor serializations
> (based on the same in-memory HTML descriptor):
> ## one with plain text according to
> [https://maven.apache.org/ref/3.8.4/maven-plugin-api/plugin.html]
> ## one with plain text and additional attributes for {{helpmojo}}
> ## another temporary one to be used from {{report}} containing HTML values
> # goal {{helpmojo}} evaluates the deserialized descriptor from 2 at
> execution time of the resulting "help" mojo
> # goal {{report}} evaluates the deserialized enhanced descriptor from 3.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #235: Bump maven-dependency-tree from 3.1.0 to 3.2.0
slawekjaranowski merged PR #235: URL: https://github.com/apache/maven-dependency-plugin/pull/235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #239: Bump plexus-utils from 3.4.1 to 3.4.2
dependabot[bot] opened a new pull request, #239: URL: https://github.com/apache/maven-dependency-plugin/pull/239 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.1 to 3.4.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";>plexus-utils's releases. 3.4.2 🚀 New features and improvements Provides a CachingOuptutStream and a CachingWriter (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/184";>#184) https://github.com/gnodet";>@gnodet Use (already) precalculated value (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/186";>#186) https://github.com/pzygielo";>@pzygielo use github shared actions (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/171";>#171) https://github.com/olamy";>@olamy 🐛 Bug Fixes MXParser fixes (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/185";>#185) https://github.com/gnodet";>@gnodet Fix last modified time not being updated on linux (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/203";>#203) https://github.com/gnodet";>@gnodet Fix regression and deprecate: FileUtils.fileAppend should create file… (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/200";>#200) https://github.com/slachiewicz";>@slachiewicz Fix some testing XML files checkout with incorrect eol (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/198";>#198) https://github.com/belingueres";>@belingueres Fixed regressions: https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/163";>#163 and https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/194";>#194 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/195";>#195) https://github.com/belingueres";>@belingueres Don't ignore valid SCM files (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/174";>#174) https://github.com/michael-o";>@michael-o 📦 Dependency updates Bump github/codeql-action from 1 to 2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/202";>#202) https://github.com/dependabot";>@dependabot Bump actions/checkout from 3.0.1 to 3.0.2 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/199";>#199) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.18.1 to 5.19.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/188";>#188) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/189";>#189) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.34 to 1.35 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/190";>#190) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.4.0 to 3.0.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/197";>#197) https://github.com/dependabot";>@dependabot Bump jmh-generator-annprocess from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/175";>#175) https://github.com/dependabot";>@dependabot Bump jmh-core from 1.33 to 1.34 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/176";>#176) https://github.com/dependabot";>@dependabot Bump release-drafter/release-drafter from 5.15.0 to 5.18.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/183";>#183) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2.3.4 to 2.4.0 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/173";>#173) https://github.com/dependabot";>@dependabot Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/170";>#170) https://github.com/dependabot";>@dependabot Commits https://github.com/codehaus-plexus/plexus-utils/commit/01908b2979d4104a1e87f7e1eb0e157c9e1a3f8c";>01908b2 [maven-release-plugin] prepare release plexus-utils-3.4.2 https://github.com/codehaus-plexus/plexus-utils/commit/0d97c8ba8dfa4663e86c5827555f980fd47c27a9";>0d97c8b Fix endless loop caused by aborted subsequent PI or comment (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/124";>#124) https://github.com/codehaus-plexus/plexus-utils/commit/11c749d677176b5b04573a1acd37997ec61dcc05";>11c749d Fix endless loop with invalid PI containing XML (https://github-redirect.dependabot.com/codehaus-plexus/plexus-utils/issues/122";>#122) https://github.com/codehaus-plexus/plexus-utils/commit/2c6fe7e293425795835766319bff524ef47bb94a";>2c6fe7e Fix start position of
[jira] [Created] (MDEP-822) Bump maven-dependency-tree from 3.1.0 to 3.2.0
Slawomir Jaranowski created MDEP-822: Summary: Bump maven-dependency-tree from 3.1.0 to 3.2.0 Key: MDEP-822 URL: https://issues.apache.org/jira/browse/MDEP-822 Project: Maven Dependency Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MDEP-822) Bump maven-dependency-tree from 3.1.0 to 3.2.0
[ https://issues.apache.org/jira/browse/MDEP-822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MDEP-822. Resolution: Fixed > Bump maven-dependency-tree from 3.1.0 to 3.2.0 > -- > > Key: MDEP-822 > URL: https://issues.apache.org/jira/browse/MDEP-822 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MDEP-806) Dependency tree in verbose mode for war is empty
[
https://issues.apache.org/jira/browse/MDEP-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MDEP-806.
Resolution: Fixed
> Dependency tree in verbose mode for war is empty
>
>
> Key: MDEP-806
> URL: https://issues.apache.org/jira/browse/MDEP-806
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: tree
>Affects Versions: 3.3.0
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> To reproduce, in project with {{war}} packaging:
> {code}
> mvn org.apache.maven.plugins:maven-dependency-plugin:3.3.0:tree -Dverbose
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #233: [MDEP-782] - Add ability to strip type
slawekjaranowski commented on code in PR #233:
URL:
https://github.com/apache/maven-dependency-plugin/pull/233#discussion_r956565164
##
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/AbstractFromDependenciesMojo.java:
##
@@ -45,6 +45,12 @@
@Parameter( property = "mdep.stripVersion", defaultValue = "false" )
protected boolean stripVersion = false;
+/**
+ * Strip artifact type during copy
+ */
+@Parameter( property = "mdep.stripType", defaultValue = "false" )
Review Comment:
Please add `@since 3.4.0`
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo2.java:
##
@@ -373,7 +373,50 @@ public void testSubPerArtifactAndTypeRemoveVersion()
for ( Artifact artifact : artifacts )
{
String fileName = DependencyUtil.getFormattedFileName( artifact,
true );
-File folder = DependencyUtil.getFormattedOutputDirectory( false,
true, true, false, true,
+File folder = DependencyUtil.getFormattedOutputDirectory( false,
true, true, false, true, false,
+
mojo.outputDirectory, artifact );
+File file = new File( folder, fileName );
+assertTrue( file.exists() );
+}
+}
+
+public void testSubPerArtifactRemoveType()
+throws Exception
+{
+mojo.useSubDirectoryPerArtifact = true;
+mojo.stripType = true;
+
+mojo.execute();
+
+Set artifacts = mojo.getProject().getArtifacts();
+for ( Artifact artifact : artifacts )
+{
+// TODO fix test
+String fileName = DependencyUtil.getFormattedFileName( artifact,
false );
+File folder = DependencyUtil.getFormattedOutputDirectory( false,
false, true, false, false, true,
+mojo.outputDirectory, artifact );
+File file = new File( folder, fileName );
+assertTrue( file.exists() );
+}
+}
+
+public void testSubPerArtifactAndTypeRemoveType()
+throws Exception
+{
+mojo.getProject().setArtifacts( stubFactory.getTypedArtifacts() );
+mojo.getProject().setDependencyArtifacts( new HashSet() );
+mojo.useSubDirectoryPerArtifact = true;
+mojo.useSubDirectoryPerType = true;
+mojo.stripType = true;
+
+mojo.execute();
+
+Set artifacts = mojo.getProject().getArtifacts();
+for ( Artifact artifact : artifacts )
+{
+// TODO fix test
Review Comment:
?
##
src/test/java/org/apache/maven/plugins/dependency/fromDependencies/TestCopyDependenciesMojo2.java:
##
@@ -373,7 +373,50 @@ public void testSubPerArtifactAndTypeRemoveVersion()
for ( Artifact artifact : artifacts )
{
String fileName = DependencyUtil.getFormattedFileName( artifact,
true );
-File folder = DependencyUtil.getFormattedOutputDirectory( false,
true, true, false, true,
+File folder = DependencyUtil.getFormattedOutputDirectory( false,
true, true, false, true, false,
+
mojo.outputDirectory, artifact );
+File file = new File( folder, fileName );
+assertTrue( file.exists() );
+}
+}
+
+public void testSubPerArtifactRemoveType()
+throws Exception
+{
+mojo.useSubDirectoryPerArtifact = true;
+mojo.stripType = true;
+
+mojo.execute();
+
+Set artifacts = mojo.getProject().getArtifacts();
+for ( Artifact artifact : artifacts )
+{
+// TODO fix test
+String fileName = DependencyUtil.getFormattedFileName( artifact,
false );
+File folder = DependencyUtil.getFormattedOutputDirectory( false,
false, true, false, false, true,
+mojo.outputDirectory, artifact );
+File file = new File( folder, fileName );
+assertTrue( file.exists() );
Review Comment:
We also should check if file name contains type or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-782) Add a option to unpack goals
[
https://issues.apache.org/jira/browse/MDEP-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585733#comment-17585733
]
Slawomir Jaranowski commented on MDEP-782:
--
If you found another problems pleas create or link separate issue.
> Add a option to unpack goals
>
>
> Key: MDEP-782
> URL: https://issues.apache.org/jira/browse/MDEP-782
> Project: Maven Dependency Plugin
> Issue Type: New Feature
> Components: unpack-dependencies
>Affects Versions: 3.2.0
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
>Reporter: Andreas Sewe
>Priority: Major
>
> When using {{unpack-dependencies}} with
> {noformat}
> true
> true
> {noformat}
> dependencies will get unpacked in directories like
> {{{}${outputDirectory}/some-artifactId-{*}jar{*}/{}}}. In other words, the
> artifact's type is always appended; AFAICT from the
> [code|https://maven.apache.org/plugins/maven-dependency-plugin/xref/org/apache/maven/plugins/dependency/utils/DependencyUtil.html#L189],
> there is no way to unpack into a directory whose name is just the
> dependency's {{{}artifactId{}}}.
> It would hence be nice to have a {{}} configuration option to
> mirror
> [{{}}|https://maven.apache.org/plugins/maven-dependency-plugin/unpack-dependencies-mojo.html#stripVersion]
> and
> [{{}}|https://maven.apache.org/plugins/maven-dependency-plugin/unpack-dependencies-mojo.html#stripClassifier]
> (although the later option is also ignored on {{{}unpack-dependencies{}}}. A
> separate bug?).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #218: Feature/mdep 808 restrict dependency analysis by group
slawekjaranowski commented on code in PR #218: URL: https://github.com/apache/maven-dependency-plugin/pull/218#discussion_r956565980 ## src/main/java/org/apache/maven/plugins/dependency/analyze/AbstractAnalyzeMojo.java: ## @@ -215,7 +216,7 @@ * @since 2.10 */ @Parameter -private String[] ignoredUsedUndeclaredDependencies = new String[0]; +private final String[] ignoredUsedUndeclaredDependencies = new String[0]; Review Comment: Please don't use `final` for Mojo parameters. It can be inline by compiler ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #207: [MDEP-799] - improve dependency:tree to add optional JSON output of the results
slawekjaranowski commented on PR #207: URL: https://github.com/apache/maven-dependency-plugin/pull/207#issuecomment-1229166442 > > * why json is created manually? Maybe use FasterXML > > Is it OK to add some dependencies? I thought you might want to keep the dependencies minimal. > It is ok if meets: https://maven.apache.org/developers/dependency-policies.html > > * missing documentation, I propose separate page with output example and description > > OK, will add doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7156) Parallel build can cause issues between clean and forked goals
[
https://issues.apache.org/jira/browse/MNG-7156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17585738#comment-17585738
]
Michael Osipov commented on MNG-7156:
-
[~dfelliott], please file a new ticket.
> Parallel build can cause issues between clean and forked goals
> --
>
> Key: MNG-7156
> URL: https://issues.apache.org/jira/browse/MNG-7156
> Project: Maven
> Issue Type: Bug
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.5, 4.0.0-alpha-1, 4.0.0
>
>
> Running {{mvn -T12 clean verify -Papache-release}} From
> [https://github.com/apache/jackrabbit-filevault] leads to various exceptions
> caused by the invocation of the {{clean}} goal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-archetype] JanMosigItemis opened a new pull request, #118: [ARCHETYPE-626] mvn install deploy does not work with 3.2.1
JanMosigItemis opened a new pull request, #118: URL: https://github.com/apache/maven-archetype/pull/118 Hi there, thought I'd provide a fix for this problem. Although I do not know why writing to output directory (i. e. target/classes) confuses Velocity's template merge algorithm, I do think that writing the archetype-settings.xml to test output directory (i. e. target/test-classes) is a better idea anyway, because it is meant for test stuff. By doing so, the problem seems to be gone and it does not seem to do any harm. Regards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #236: Bump jsoup from 1.15.2 to 1.15.3
slawekjaranowski merged PR #236: URL: https://github.com/apache/maven-dependency-plugin/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #240: Bump slf4j-simple from 1.7.36 to 2.0.0
dependabot[bot] opened a new pull request, #240: URL: https://github.com/apache/maven-dependency-plugin/pull/240 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.0. Commits https://github.com/qos-ch/slf4j/commit/0614d467d7bca81724f45e228f4f871161222b51";>0614d46 prepare release 2.0.0 https://github.com/qos-ch/slf4j/commit/b1afcd01b1092f0dfda12b4502aa202124e24a8e";>b1afcd0 javadoc edits https://github.com/qos-ch/slf4j/commit/20cd3ad0abd25d1837f5b9354c6729cb4a978d69";>20cd3ad start work on 2.0.0-SNAPSHOT https://github.com/qos-ch/slf4j/commit/aeebb6199d412a3883af2d0c414a69fde26b5971";>aeebb61 prepare release 2.0.0-beta1 https://github.com/qos-ch/slf4j/commit/1068cd0eb9fb2460d368e3ba6112517ef3fedd2a";>1068cd0 javadoc changes https://github.com/qos-ch/slf4j/commit/4e4e56a2df730cdb6877449b6341279208f20a78";>4e4e56a add CheckReturnValue annotation in org.slf4j.helpers https://github.com/qos-ch/slf4j/commit/0dcfa19040fb2d7f45dfe00823d15bdff0434d6a";>0dcfa19 check for return value in some oggingEventBuilder methods https://github.com/qos-ch/slf4j/commit/e7ca8d17c8db1fc956019404153cc7b90b8f0c61";>e7ca8d1 start work on 2.0.0-beta1-SNAPSHOPT https://github.com/qos-ch/slf4j/commit/2314de9dd9f9abbef360f5c6240487c0ac7e5fc3";>2314de9 add setMessage and log method to the fluent API https://github.com/qos-ch/slf4j/commit/508a796552640c83d6d814374a9b50a424e88cfa";>508a796 set version to 2.0.0-beta0 Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] dependabot[bot] commented on pull request #240: Bump slf4j-simple from 1.7.36 to 2.0.0
dependabot[bot] commented on PR #240: URL: https://github.com/apache/maven-dependency-plugin/pull/240#issuecomment-1229180315 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski closed pull request #240: Bump slf4j-simple from 1.7.36 to 2.0.0
slawekjaranowski closed pull request #240: Bump slf4j-simple from 1.7.36 to 2.0.0 URL: https://github.com/apache/maven-dependency-plugin/pull/240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #237: Bump maven-dependency-analyzer from 1.12.0 to 1.13.0
slawekjaranowski commented on PR #237: URL: https://github.com/apache/maven-dependency-plugin/pull/237#issuecomment-1229183750 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] Marcono1234 opened a new pull request, #241: [MDEP-714] Add missing 'since' to ignoreUnusedRuntime parameter
Marcono1234 opened a new pull request, #241: URL: https://github.com/apache/maven-dependency-plugin/pull/241 The parameter `ignoreUnusedRuntime` introduced by #123 was missing a `@since` tag. It appears in that case maven-plugin-tools inherits the `@since` from the Mojo, which is quite confusing:  (I will probably also create an issue for maven-plugin-tools-generators, questioning whether that behavior is really a good idea.) Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPLUGIN-420) Parameters documentation inheriting @since from Mojo can be confusing
Marcono1234 created MPLUGIN-420:
---
Summary: Parameters documentation inheriting @since from Mojo can
be confusing
Key: MPLUGIN-420
URL: https://issues.apache.org/jira/browse/MPLUGIN-420
Project: Maven Plugin Tools
Issue Type: Bug
Components: maven-plugin-tools-java
Reporter: Marcono1234
It looks like currently if a parameter is missing a {{@since}} tag, the
documentation for the plugin inherits the {{@since}} from the Mojo (relevant
code seems to be
[here|https://github.com/apache/maven-plugin-tools/blob/2ee1d603e2a71bcd99d58a5e6a4c4b2d2669d9c4/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L491-L504]).
I assume the intention was to avoid having to repeat the {{@since}} tag for
paramters which existed from the beginning. However, this can be quite
confusing when developers forget to add the {{@since}} tag to parameters. In
that case the documentation will claim an incorrect value.
An example for this can be seen in
https://github.com/apache/maven-dependency-plugin/pull/241; the parameter was
added in 3.2.0 but the author forgot to add the {{@since}} tag. Therefore the
documentation erroneously claims the parameter exists since version 2.0 (when
the Mojo was added).
Maybe it would be better to just leave the value blank and not inherit it from
the Mojo. This way if the value is missing users can assume that the parameter
is supported in the version they are using, but won't be that confused when the
parameter is not supported yet. Whereas currently the documentation says the
parameter should be supported and users start troubleshooting their build
configuration until they notice that the documentation is incorrect and they
just have to upgrade the plugin version.
Though this problem will likely become less relevant with MNG-7468.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPLUGIN-420) Parameters documentation inheriting @since from Mojo can be confusing
[
https://issues.apache.org/jira/browse/MPLUGIN-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcono1234 updated MPLUGIN-420:
Priority: Minor (was: Major)
> Parameters documentation inheriting @since from Mojo can be confusing
> -
>
> Key: MPLUGIN-420
> URL: https://issues.apache.org/jira/browse/MPLUGIN-420
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: maven-plugin-tools-java
>Reporter: Marcono1234
>Priority: Minor
>
> It looks like currently if a parameter is missing a {{@since}} tag, the
> documentation for the plugin inherits the {{@since}} from the Mojo (relevant
> code seems to be
> [here|https://github.com/apache/maven-plugin-tools/blob/2ee1d603e2a71bcd99d58a5e6a4c4b2d2669d9c4/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L491-L504]).
> I assume the intention was to avoid having to repeat the {{@since}} tag for
> paramters which existed from the beginning. However, this can be quite
> confusing when developers forget to add the {{@since}} tag to parameters. In
> that case the documentation will claim an incorrect value.
> An example for this can be seen in
> https://github.com/apache/maven-dependency-plugin/pull/241; the parameter was
> added in 3.2.0 but the author forgot to add the {{@since}} tag. Therefore the
> documentation erroneously claims the parameter exists since version 2.0 (when
> the Mojo was added).
> Maybe it would be better to just leave the value blank and not inherit it
> from the Mojo. This way if the value is missing users can assume that the
> parameter is supported in the version they are using, but won't be that
> confused when the parameter is not supported yet. Whereas currently the
> documentation says the parameter should be supported and users start
> troubleshooting their build configuration until they notice that the
> documentation is incorrect and they just have to upgrade the plugin version.
> Though this problem will likely become less relevant with MNG-7468.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-420) Parameters documentation inheriting @since from Mojo can be confusing
[
https://issues.apache.org/jira/browse/MPLUGIN-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17586071#comment-17586071
]
Slawomir Jaranowski commented on MPLUGIN-420:
-
Good catch - {{@since}} tag should not be inherited from Mojo, it can be
confusing as you mentioned.
> Parameters documentation inheriting @since from Mojo can be confusing
> -
>
> Key: MPLUGIN-420
> URL: https://issues.apache.org/jira/browse/MPLUGIN-420
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: maven-plugin-tools-java
>Reporter: Marcono1234
>Priority: Minor
>
> It looks like currently if a parameter is missing a {{@since}} tag, the
> documentation for the plugin inherits the {{@since}} from the Mojo (relevant
> code seems to be
> [here|https://github.com/apache/maven-plugin-tools/blob/2ee1d603e2a71bcd99d58a5e6a4c4b2d2669d9c4/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L491-L504]).
> I assume the intention was to avoid having to repeat the {{@since}} tag for
> paramters which existed from the beginning. However, this can be quite
> confusing when developers forget to add the {{@since}} tag to parameters. In
> that case the documentation will claim an incorrect value.
> An example for this can be seen in
> https://github.com/apache/maven-dependency-plugin/pull/241; the parameter was
> added in 3.2.0 but the author forgot to add the {{@since}} tag. Therefore the
> documentation erroneously claims the parameter exists since version 2.0 (when
> the Mojo was added).
> Maybe it would be better to just leave the value blank and not inherit it
> from the Mojo. This way if the value is missing users can assume that the
> parameter is supported in the version they are using, but won't be that
> confused when the parameter is not supported yet. Whereas currently the
> documentation says the parameter should be supported and users start
> troubleshooting their build configuration until they notice that the
> documentation is incorrect and they just have to upgrade the plugin version.
> Though this problem will likely become less relevant with MNG-7468.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPLUGIN-420) Parameters documentation inheriting @since from Mojo can be confusing
[
https://issues.apache.org/jira/browse/MPLUGIN-420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MPLUGIN-420:
Labels: up-for-grabs (was: )
> Parameters documentation inheriting @since from Mojo can be confusing
> -
>
> Key: MPLUGIN-420
> URL: https://issues.apache.org/jira/browse/MPLUGIN-420
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: maven-plugin-tools-java
>Reporter: Marcono1234
>Priority: Minor
> Labels: up-for-grabs
>
> It looks like currently if a parameter is missing a {{@since}} tag, the
> documentation for the plugin inherits the {{@since}} from the Mojo (relevant
> code seems to be
> [here|https://github.com/apache/maven-plugin-tools/blob/2ee1d603e2a71bcd99d58a5e6a4c4b2d2669d9c4/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L491-L504]).
> I assume the intention was to avoid having to repeat the {{@since}} tag for
> paramters which existed from the beginning. However, this can be quite
> confusing when developers forget to add the {{@since}} tag to parameters. In
> that case the documentation will claim an incorrect value.
> An example for this can be seen in
> https://github.com/apache/maven-dependency-plugin/pull/241; the parameter was
> added in 3.2.0 but the author forgot to add the {{@since}} tag. Therefore the
> documentation erroneously claims the parameter exists since version 2.0 (when
> the Mojo was added).
> Maybe it would be better to just leave the value blank and not inherit it
> from the Mojo. This way if the value is missing users can assume that the
> parameter is supported in the version they are using, but won't be that
> confused when the parameter is not supported yet. Whereas currently the
> documentation says the parameter should be supported and users start
> troubleshooting their build configuration until they notice that the
> documentation is incorrect and they just have to upgrade the plugin version.
> Though this problem will likely become less relevant with MNG-7468.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #237: Bump maven-dependency-analyzer from 1.12.0 to 1.13.0
slawekjaranowski merged PR #237: URL: https://github.com/apache/maven-dependency-plugin/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-823) Bump maven-dependency-analyzer from 1.12.0 to 1.13.0
Slawomir Jaranowski created MDEP-823: Summary: Bump maven-dependency-analyzer from 1.12.0 to 1.13.0 Key: MDEP-823 URL: https://issues.apache.org/jira/browse/MDEP-823 Project: Maven Dependency Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request, #242: Bump maven-reporting-impl from 3.1.0 to 3.2.0
dependabot[bot] opened a new pull request, #242: URL: https://github.com/apache/maven-dependency-plugin/pull/242 Bumps [maven-reporting-impl](https://github.com/apache/maven-reporting-impl) from 3.1.0 to 3.2.0. Commits https://github.com/apache/maven-reporting-impl/commit/967e756d41c00c123c5c545676b5bffd35918970";>967e756 [maven-release-plugin] prepare release maven-reporting-impl-3.2.0 https://github.com/apache/maven-reporting-impl/commit/ecf1b039a76a1b6eeda5e79e0885599e9e573cc8";>ecf1b03 [MSHARED-1099] Render with a skin when report is run in standalone mode https://github.com/apache/maven-reporting-impl/commit/df5e068b2db2945d3c8906fbb2e5bd01864c0e50";>df5e068 [MSHARED-1121] Upgrade plugins and components in project and ITs https://github.com/apache/maven-reporting-impl/commit/ae6a6d127b1a405bfb571811c47b9e30eb2eb5ed";>ae6a6d1 [MSHARED-1120] Upgrade Maven Reporting API to 3.1.1 https://github.com/apache/maven-reporting-impl/commit/b3f28da88871f961f50fd3b274773bb94252736c";>b3f28da Update CI URL https://github.com/apache/maven-reporting-impl/commit/bbddd4d800ce605316add4220b91ad33e5ae7557";>bbddd4d [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-reporting-impl/compare/maven-reporting-impl-3.1.0...maven-reporting-impl-3.2.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MDEP-823) Bump maven-dependency-analyzer from 1.12.0 to 1.13.0
[ https://issues.apache.org/jira/browse/MDEP-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MDEP-823. Resolution: Fixed > Bump maven-dependency-analyzer from 1.12.0 to 1.13.0 > > > Key: MDEP-823 > URL: https://issues.apache.org/jira/browse/MDEP-823 > Project: Maven Dependency Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #242: Bump maven-reporting-impl from 3.1.0 to 3.2.0
slawekjaranowski commented on PR #242: URL: https://github.com/apache/maven-dependency-plugin/pull/242#issuecomment-1229209634 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski merged pull request #241: [MDEP-714] Add missing 'since' to ignoreUnusedRuntime parameter
slawekjaranowski merged PR #241: URL: https://github.com/apache/maven-dependency-plugin/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #241: [MDEP-714] Add missing 'since' to ignoreUnusedRuntime parameter
slawekjaranowski commented on PR #241: URL: https://github.com/apache/maven-dependency-plugin/pull/241#issuecomment-1229209876 Thanks @Marcono1234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-714) Add analyze parameter "ignoreUnusedRuntime"
[ https://issues.apache.org/jira/browse/MDEP-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17586081#comment-17586081 ] Hudson commented on MDEP-714: - Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-plugin » master #41 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master/41/ > Add analyze parameter "ignoreUnusedRuntime" > --- > > Key: MDEP-714 > URL: https://issues.apache.org/jira/browse/MDEP-714 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: analyze >Reporter: Elliotte Rusty Harold >Assignee: Michael Osipov >Priority: Major > Fix For: 3.2.0 > > > Typical output when analyzing the maven-archetype-plugin: > [WARNING] Unused declared dependencies found: > [WARNING]org.apache.ivy:ivy:jar:2.5.0:runtime > However since this is needed at runtime, possibly via reflection, it seems > likely that it is used but the dependency analyzer can't figure this out. > Confirm and consider whether the plugin should simply never report runtime > dependencies as unused. > This is tricky because it's certainly possible that a runtime dependency is > unused, but in practice it seems more likely than not to be a false positive. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-420) Parameters documentation inheriting @since from Mojo can be confusing
[
https://issues.apache.org/jira/browse/MPLUGIN-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17586082#comment-17586082
]
Michael Osipov commented on MPLUGIN-420:
I have noticed this also with m-r-impl 3.2.0 and all reporting plugins.
> Parameters documentation inheriting @since from Mojo can be confusing
> -
>
> Key: MPLUGIN-420
> URL: https://issues.apache.org/jira/browse/MPLUGIN-420
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: maven-plugin-tools-java
>Reporter: Marcono1234
>Priority: Minor
> Labels: up-for-grabs
>
> It looks like currently if a parameter is missing a {{@since}} tag, the
> documentation for the plugin inherits the {{@since}} from the Mojo (relevant
> code seems to be
> [here|https://github.com/apache/maven-plugin-tools/blob/2ee1d603e2a71bcd99d58a5e6a4c4b2d2669d9c4/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java#L491-L504]).
> I assume the intention was to avoid having to repeat the {{@since}} tag for
> paramters which existed from the beginning. However, this can be quite
> confusing when developers forget to add the {{@since}} tag to parameters. In
> that case the documentation will claim an incorrect value.
> An example for this can be seen in
> https://github.com/apache/maven-dependency-plugin/pull/241; the parameter was
> added in 3.2.0 but the author forgot to add the {{@since}} tag. Therefore the
> documentation erroneously claims the parameter exists since version 2.0 (when
> the Mojo was added).
> Maybe it would be better to just leave the value blank and not inherit it
> from the Mojo. This way if the value is missing users can assume that the
> parameter is supported in the version they are using, but won't be that
> confused when the parameter is not supported yet. Whereas currently the
> documentation says the parameter should be supported and users start
> troubleshooting their build configuration until they notice that the
> documentation is incorrect and they just have to upgrade the plugin version.
> Though this problem will likely become less relevant with MNG-7468.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-shade-plugin] slachiewicz closed pull request #147: Bump slf4j.version from 1.7.32 to 2.0.0
slachiewicz closed pull request #147: Bump slf4j.version from 1.7.32 to 2.0.0 URL: https://github.com/apache/maven-shade-plugin/pull/147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shade-plugin] dependabot[bot] commented on pull request #147: Bump slf4j.version from 1.7.32 to 2.0.0
dependabot[bot] commented on PR #147: URL: https://github.com/apache/maven-shade-plugin/pull/147#issuecomment-1229290871 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
