kwin commented on code in PR #139:
URL: https://github.com/apache/maven-plugin-tools/pull/139#discussion_r956553530
##########
pom.xml:
##########
@@ -94,9 +94,13 @@
<javaVersion>8</javaVersion>
<pluginTestingHarnessVersion>3.3.0</pluginTestingHarnessVersion>
<mavenVersion>3.2.5</mavenVersion>
+ <!-- SLF4J version must match the version exported from the mavenVersion,
+
https://github.com/apache/maven/blob/12a6b3acb947671f09b81f49094c53f426d8cea1/pom.xml#L63
-->
Review Comment:
Not sure, as even minor versions may introduce new features which are
backwards-compatible (i.e. new methods added to API). When you leverage those
your code breaks when running with an older SLF4J API dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
