[jira] [Commented] (SUREFIRE-2077) argLine with two spaces doesn't work
[
https://issues.apache.org/jira/browse/SUREFIRE-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541858#comment-17541858
]
Maarten Mulders commented on SUREFIRE-2077:
---
The PR to fix this has been open for one month now. I'd love to fix the issue
at hand since it means 3.0.0-M6 broke something that worked in 3.0.0-M5. Are
there any objections to the changes in the PR?
> argLine with two spaces doesn't work
>
>
> Key: SUREFIRE-2077
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2077
> Project: Maven Surefire
> Issue Type: Bug
> Components: process forking
>Reporter: Maarten Mulders
>Priority: Minor
>
> Reported by [~marcphilipp]:
> The fix for SUREFIRE-2063 breaks valid but questionable use cases such as
> {code:xml}
> "-DpropertyKey=value with 2 spaces"{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRESOURCES-281) allow different encodings for files inside the same resource-directory
[
https://issues.apache.org/jira/browse/MRESOURCES-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541864#comment-17541864
]
Carsten Rohde commented on MRESOURCES-281:
--
Just in case anyone else has the same problem. We finally ended up with the
following:
* create a folder e.g. src/main/filtered-resources-
* use resources:copy-resources with the required encoding encoding to copy
into the output directory
* (Eclipse) use build-helper:add-resource or a resource element to add the
folder as a project resource folder and then exclude everything inside, thus
tricking eclipse into rendering the folder as a first-clas resource-folder
* (Eclipse) ensure that resources:copy-resources is bound by m2e
> allow different encodings for files inside the same resource-directory
> --
>
> Key: MRESOURCES-281
> URL: https://issues.apache.org/jira/browse/MRESOURCES-281
> Project: Maven Resources Plugin
> Issue Type: Improvement
> Components: filtering
>Affects Versions: 3.2.0
>Reporter: Carsten Rohde
>Priority: Major
> Labels: encoding, feature, newbie
>
> Currently each resource-directory has a single encoding, with the recent
> exception of properties (MRESOURCES-171).
> If you need to filter differently encoded files, this can become quite a
> hazzle: The only way (at least that I'm aware of) is to have different
> modules or non-resource directories as the source for copy-resources. Apart
> from bloating the pom, it also forces you to have related files at different
> locations if they are encoded differently.
>
> What I'm suggesting is to generalize what has been done for properties by
> allowing to override the for specific files/patterns.
> Ideally this would be part of the resource-declaration but being able to
> configure the resources plugin accordingly would already help a lot:
> {code:java}
>
>
>
> UTF-16
> **/*.myfile
>
>
>iso-latin-1
>**/*.other
>
>
>
> What do you think?{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-enforcer] subes commented on pull request #140: [MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps
subes commented on PR #140: URL: https://github.com/apache/maven-enforcer/pull/140#issuecomment-1136894194 Done. Dunno how to edit commit message, a squash and merge should use the title of this pull request instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541875#comment-17541875
]
Michael Osipov commented on MNG-7483:
-
If you can't extract, we can't analyze.
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaa
[GitHub] [maven-scm] michael-o commented on a diff in pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881349996
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
@olamy at work:
```
---
Test set:
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest
---
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1,218.536 s
<<< FAILURE! - in
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest
testNotExist(org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest)
Time elapsed: 609.31 s <<< ERROR!
org.apache.maven.scm.ScmException:
cmd.exe /X /C "svn --non-interactive ls
http://svn.apache.org/repos/asf/maven/scm/trunk/foo/bar/beer@".The svn command
failed:svn: E170013: Unable to connect to a repository at URL
'http://svn.apache.org/repos/asf/maven/scm/trunk/foo/bar/beer'
svn: E175012: Connection timed out
at
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest.testNotExist(SvnRemoteInfoCommandTest.java:53)
testExist(org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest)
Time elapsed: 609.226 s <<< ERROR!
org.apache.maven.scm.ScmException:
cmd.exe /X /C "svn --non-interactive ls
http://svn.apache.org/repos/asf/maven/scm/trunk/@".The svn command failed:svn:
E170013: Unable to connect to a repository at URL
'http://svn.apache.org/repos/asf/maven/scm/trunk'
svn: E175012: Connection timed out
at
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest.testExist(SvnRemoteInfoCommandTest.java:42)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541877#comment-17541877
]
ASF GitHub Bot commented on SCM-986:
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881349996
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
@olamy at work:
```
---
Test set:
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest
---
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1,218.536 s
<<< FAILURE! - in
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest
testNotExist(org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest)
Time elapsed: 609.31 s <<< ERROR!
org.apache.maven.scm.ScmException:
cmd.exe /X /C "svn --non-interactive ls
http://svn.apache.org/repos/asf/maven/scm/trunk/foo/bar/beer@".The svn command
failed:svn: E170013: Unable to connect to a repository at URL
'http://svn.apache.org/repos/asf/maven/scm/trunk/foo/bar/beer'
svn: E175012: Connection timed out
at
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest.testNotExist(SvnRemoteInfoCommandTest.java:53)
testExist(org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest)
Time elapsed: 609.226 s <<< ERROR!
org.apache.maven.scm.ScmException:
cmd.exe /X /C "svn --non-interactive ls
http://svn.apache.org/repos/asf/maven/scm/trunk/@".The svn command failed:svn:
E170013: Unable to connect to a repository at URL
'http://svn.apache.org/repos/asf/maven/scm/trunk'
svn: E175012: Connection timed out
at
org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo.SvnRemoteInfoCommandTest.testExist(SvnRemoteInfoCommandTest.java:42)
```
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/re
[jira] [Updated] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7483:
Fix Version/s: waiting-for-feedback
wontfix-candidate
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenva
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #140: [MENFORCER-402] - fix provided dependencies in RequireUpperBoundDeps
slawekjaranowski commented on PR #140: URL: https://github.com/apache/maven-enforcer/pull/140#issuecomment-1136957065 [To edit commit message ](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clement Gaboriau Couanau updated MNG-7483:
--
Attachment: ErrorInvestigationProject.zip
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: ErrorInvestigationProject.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenva
[jira] [Commented] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541892#comment-17541892
]
Clement Gaboriau Couanau commented on MNG-7483:
---
I add a failing project (mvn test shows the problem).
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: ErrorInvestigationProject.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenv
[jira] [Created] (SCM-989) Tests fail if svn is not installed.
Niels Basjes created SCM-989:
Summary: Tests fail if svn is not installed.
Key: SCM-989
URL: https://issues.apache.org/jira/browse/SCM-989
Project: Maven SCM
Issue Type: Test
Reporter: Niels Basjes
If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the
build fails over these tests:
{code:java}
[ERROR] Errors:
[ERROR] SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing svn
command.
[ERROR] SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while executing
svn command.{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (MASSEMBLY-958) transitive dependencies not considered as expected in dependencySet
Carsten Rohde created MASSEMBLY-958: --- Summary: transitive dependencies not considered as expected in dependencySet Key: MASSEMBLY-958 URL: https://issues.apache.org/jira/browse/MASSEMBLY-958 Project: Maven Assembly Plugin Issue Type: Bug Components: dependencySet Affects Versions: 3.3.0 Reporter: Carsten Rohde Attachments: dependency-set-bug-aggregator.zip When using a dependencySet with useTransitiveDependencies set to true, transitive dependencies seem to be determined based on the dependency-tree of the project in which the assembly-plugin is executed and not based on the dependency-set itself. This means: if a transitive dependency of a dependencySet is also present outside of the dependency set, it may be evicted from the dependency set (depending on its depth in the dependecy tree of the project on which the plugin is executed). This results in a rather unexpected behavior as the contents of the archive varies depending on the dependencies that are not part of the assembly. I realize this might be difficult to change since you will probably have to make a resolution request for some sort of virtual project made up by the dependcies matching the dependecy set. At least this behavior should be pointed out in the documentation imho. Example Project attached. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541895#comment-17541895
]
Michael Osipov commented on MNG-7483:
-
Does not work:
{noformat}
osipovmi@deblndw011x:/tmp/ErrorInvestigationProject
$ mvn clean verify
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-parseable POM /tmp/ErrorInvestigationProject/pom.xml: end tag name
must match start tag name from line 28 (position: TEXT seen
...\n... @32:15) @ line 32, column 15
@
[ERROR] The build could not read 1 project -> [Help 1]
[ERROR]
[ERROR] The project (/tmp/ErrorInvestigationProject/pom.xml) has 1 error
[ERROR] Non-parseable POM /tmp/ErrorInvestigationProject/pom.xml: end tag
name must match start tag name from line 28 (position: TEXT
seen ...\n... @32:15) @ line 32, column 15 -> [Help 2]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
[ERROR] [Help 2]
http://cwiki.apache.org/confluence/display/MAVEN/ModelParseException
{noformat}
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
> Attachments: ErrorInvestigationProject.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaa
[jira] [Updated] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7483:
Fix Version/s: (was: wontfix-candidate)
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenva
[jira] [Updated] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clement Gaboriau Couanau updated MNG-7483:
--
Attachment: ErrorInvestigation.zip
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaae
[jira] [Updated] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clement Gaboriau Couanau updated MNG-7483:
--
Attachment: (was: ErrorInvestigationProject.zip)
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenv
[jira] [Commented] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541900#comment-17541900
]
Clement Gaboriau Couanau commented on MNG-7483:
---
My mistake: cleaning up after checking was a bad idea. Now, it should work.
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaae
[jira] [Comment Edited] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541900#comment-17541900
]
Clement Gaboriau Couanau edited comment on MNG-7483 at 5/25/22 8:45 AM:
My mistake: cleaning up after checking was a bad idea. Now, it should work (I
ran the command mvn clean verify).
was (Author: JIRAUSER289953):
My mistake: cleaning up after checking was a bad idea. Now, it should work.
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaa
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881400484
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -466,6 +518,7 @@ public String toString()
{
StringBuilder result = new StringBuilder( author == null ? " null " :
author );
result.append( "\n" ).append( date == null ? "null " : date.toString()
).append( "\n" );
+result.append( "tags:" ).append( getTags() ).append( "\n" );
Review Comment:
Fixed.
I also added similar code to the toXML method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881401005
##
maven-scm-providers/maven-scm-provider-hg/src/test/java/org/apache/maven/scm/provider/hg/command/changelog/HgChangeLogCommandTckTest.java:
##
@@ -44,4 +44,11 @@ public void initRepo()
{
HgRepoUtils.initRepo();
}
+
+@Override
+public boolean aTagIsAnExtraCommit()
Review Comment:
Changed to `isTagAnExtraCommit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7483) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/MNG-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541909#comment-17541909
]
Clement Gaboriau Couanau commented on MNG-7483:
---
By changing the maven-surefire-plugin version, I saw that the problem was not
here in the 3.0.0-M5, it appeared in the 3.0.0-M6.
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: MNG-7483
> URL: https://issues.apache.org/jira/browse/MNG-7483
> Project: Maven
> Issue Type: Bug
> Components: Errors
>Affects Versions: 3.8.4
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenv
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541910#comment-17541910
]
ASF GitHub Bot commented on SCM-977:
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881400484
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -466,6 +518,7 @@ public String toString()
{
StringBuilder result = new StringBuilder( author == null ? " null " :
author );
result.append( "\n" ).append( date == null ? "null " : date.toString()
).append( "\n" );
+result.append( "tags:" ).append( getTags() ).append( "\n" );
Review Comment:
Fixed.
I also added similar code to the toXML method.
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541911#comment-17541911
]
ASF GitHub Bot commented on SCM-977:
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881401005
##
maven-scm-providers/maven-scm-provider-hg/src/test/java/org/apache/maven/scm/provider/hg/command/changelog/HgChangeLogCommandTckTest.java:
##
@@ -44,4 +44,11 @@ public void initRepo()
{
HgRepoUtils.initRepo();
}
+
+@Override
+public boolean aTagIsAnExtraCommit()
Review Comment:
Changed to `isTagAnExtraCommit`
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541903#comment-17541903
]
ASF GitHub Bot commented on SCM-986:
asfgit closed pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand
incorrectly implemented
URL: https://github.com/apache/maven-scm/pull/145
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.13.0, 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] asfgit closed pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
asfgit closed pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented URL: https://github.com/apache/maven-scm/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SCM-986.
--
Resolution: Fixed
Fixed with
[5447abdbd58d9e888229ba9d3cefe0db1c088e6f|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=5447abdbd58d9e888229ba9d3cefe0db1c088e6f].
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SCM-985) Drop/replace usage of Commons Lang 2
[ https://issues.apache.org/jira/browse/SCM-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-985: --- Fix Version/s: (was: 1.13.0) > Drop/replace usage of Commons Lang 2 > > > Key: SCM-985 > URL: https://issues.apache.org/jira/browse/SCM-985 > Project: Maven SCM > Issue Type: Task >Affects Versions: 1.12.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M2 > > > It is used only a few times and can be replaced with Plexus Utils. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-986:
---
Fix Version/s: (was: 1.13.0)
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Moved] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski moved MNG-7483 to SUREFIRE-2089:
Component/s: (was: Errors)
Fix Version/s: (was: waiting-for-feedback)
Key: SUREFIRE-2089 (was: MNG-7483)
Affects Version/s: (was: 3.8.4)
Project: Maven Surefire (was: Maven)
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaa
[jira] [Updated] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated SUREFIRE-2089:
--
Affects Version/s: 3.0.0-M6
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaae
[jira] [Commented] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541917#comment-17541917
]
Slawomir Jaranowski commented on SUREFIRE-2089:
---
Please retest with the latest development version of surefire
{{3.0.0-M7-SNAPSHOT}}
https://maven.apache.org/guides/development/guide-testing-development-plugins.html
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaa
[jira] [Commented] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541919#comment-17541919
]
Clement Gaboriau Couanau commented on SUREFIRE-2089:
The _3.0.0-M7-SNAPSHOT_ solves the problem (it fails as expected). Therefore,
was it something identified as a problem in the. {_}3.0.0-M6{_}? I haven't
found any related issue in your Jira backlog.
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.Assertion
[GitHub] [maven-scm] michael-o opened a new pull request, #148: [SCM-985] Drop/replace usage of Commons Lang 2
michael-o opened a new pull request, #148: URL: https://github.com/apache/maven-scm/pull/148 This closes #148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-985) Drop/replace usage of Commons Lang 2
[ https://issues.apache.org/jira/browse/SCM-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541920#comment-17541920 ] ASF GitHub Bot commented on SCM-985: michael-o opened a new pull request, #148: URL: https://github.com/apache/maven-scm/pull/148 This closes #148 > Drop/replace usage of Commons Lang 2 > > > Key: SCM-985 > URL: https://issues.apache.org/jira/browse/SCM-985 > Project: Maven SCM > Issue Type: Task >Affects Versions: 1.12.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M2 > > > It is used only a few times and can be replaced with Plexus Utils. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541924#comment-17541924
]
Slawomir Jaranowski commented on SUREFIRE-2089:
---
Probably this one: SUREFIRE-2058
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenva
[jira] [Commented] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541925#comment-17541925
]
Clement Gaboriau Couanau commented on SUREFIRE-2089:
Yes, it seems related. When the new version is released, I will update it.
Thank you.
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaafff
[jira] [Commented] (SCM-989) Tests fail if svn is not installed.
[
https://issues.apache.org/jira/browse/SCM-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541927#comment-17541927
]
Michael Osipov commented on SCM-989:
Indeed, did you check for Git also?
> Tests fail if svn is not installed.
> ---
>
> Key: SCM-989
> URL: https://issues.apache.org/jira/browse/SCM-989
> Project: Maven SCM
> Issue Type: Test
>Reporter: Niels Basjes
>Priority: Major
>
> If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the
> build fails over these tests:
> {code:java}
> [ERROR] Errors:
> [ERROR] SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing
> svn command.
> [ERROR] SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while
> executing svn command.{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541928#comment-17541928
]
Slawomir Jaranowski commented on SUREFIRE-2089:
---
Please follow dev list:
[https://lists.apache.org/thread/r86q92w8pfb1g3rg8tzbt810cjt6vdcq]
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaa
[jira] [Closed] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed SUREFIRE-2089.
-
Fix Version/s: 3.0.0-M7
Resolution: Fixed
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.0-M7
>
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenve
[jira] [Assigned] (SUREFIRE-2089) Fail message with one non-ASCII characters and a lot of characters lead to corruption
[
https://issues.apache.org/jira/browse/SUREFIRE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned SUREFIRE-2089:
-
Assignee: Slawomir Jaranowski
> Fail message with one non-ASCII characters and a lot of characters lead to
> corruption
> -
>
> Key: SUREFIRE-2089
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2089
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
> Environment: Java openjdk 15.0.5
> MacOS Monterey 12.4
>Reporter: Clement Gaboriau Couanau
>Assignee: Slawomir Jaranowski
>Priority: Major
> Attachments: ErrorInvestigation.zip
>
>
> I have a problem when running my tests with Maven.
> When running this test:
> {code:java}
> @Test
> public void testFail() {
> fail(
>
> "¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv");
> }{code}
> From IntelliJ, it fails as expected.
> From the command line, it does not fail, I obtain the following result
> {code:java}
> > mvn test -pl com/xx -Dtest=MyClass
> [INFO] Running com.xx.MyClass
> [ERROR]
> aaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv::j:¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:�:MyClass.testFail:666
>
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenv:
> �:org.opentest4j.AssertionFailedError:
> ¸aaaenvaaaffavaaenvenvaaaenvaaaffavaaenvenvaaaenvaaaenvaaaenvaaaenvaa
[GitHub] [maven-scm] asfgit merged pull request #148: [SCM-985] Drop/replace usage of Commons Lang 2
asfgit merged PR #148: URL: https://github.com/apache/maven-scm/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-scm] asfgit closed pull request #148: [SCM-985] Drop/replace usage of Commons Lang 2
asfgit closed pull request #148: [SCM-985] Drop/replace usage of Commons Lang 2 URL: https://github.com/apache/maven-scm/pull/148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-985) Drop/replace usage of Commons Lang 2
[ https://issues.apache.org/jira/browse/SCM-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541937#comment-17541937 ] ASF GitHub Bot commented on SCM-985: asfgit closed pull request #148: [SCM-985] Drop/replace usage of Commons Lang 2 URL: https://github.com/apache/maven-scm/pull/148 > Drop/replace usage of Commons Lang 2 > > > Key: SCM-985 > URL: https://issues.apache.org/jira/browse/SCM-985 > Project: Maven SCM > Issue Type: Task >Affects Versions: 1.12.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M2 > > > It is used only a few times and can be replaced with Plexus Utils. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SCM-985) Drop/replace usage of Commons Lang 2
[ https://issues.apache.org/jira/browse/SCM-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541938#comment-17541938 ] ASF GitHub Bot commented on SCM-985: asfgit merged PR #148: URL: https://github.com/apache/maven-scm/pull/148 > Drop/replace usage of Commons Lang 2 > > > Key: SCM-985 > URL: https://issues.apache.org/jira/browse/SCM-985 > Project: Maven SCM > Issue Type: Task >Affects Versions: 1.12.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M2 > > > It is used only a few times and can be replaced with Plexus Utils. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (SCM-985) Drop/replace usage of Commons Lang 2
[ https://issues.apache.org/jira/browse/SCM-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SCM-985. -- Resolution: Fixed Fixed with [087c1b350a92cfa8537b0d9d0b0993dc2bd66873|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=087c1b350a92cfa8537b0d9d0b0993dc2bd66873]. > Drop/replace usage of Commons Lang 2 > > > Key: SCM-985 > URL: https://issues.apache.org/jira/browse/SCM-985 > Project: Maven SCM > Issue Type: Task >Affects Versions: 1.12.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M2 > > > It is used only a few times and can be replaced with Plexus Utils. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (SCM-985) Drop/replace usage of Commons Lang 2
[ https://issues.apache.org/jira/browse/SCM-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541939#comment-17541939 ] Michael Osipov edited comment on SCM-985 at 5/25/22 9:48 AM: - Fixed with [087c1b350a92cfa8537b0d9d0b0993dc2bd66873|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=087c1b350a92cfa8537b0d9d0b0993dc2bd66873]. was (Author: michael-o): Fixed with [087c1b350a92cfa8537b0d9d0b0993dc2bd66873|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=087c1b350a92cfa8537b0d9d0b0993dc2bd66873]. > Drop/replace usage of Commons Lang 2 > > > Key: SCM-985 > URL: https://issues.apache.org/jira/browse/SCM-985 > Project: Maven SCM > Issue Type: Task >Affects Versions: 1.12.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M2 > > > It is used only a few times and can be replaced with Plexus Utils. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541904#comment-17541904
]
Michael Osipov edited comment on SCM-986 at 5/25/22 9:49 AM:
-
Fixed with
[5447abdbd58d9e888229ba9d3cefe0db1c088e6f|https://gitbox.apache.org/repos/asf?p=maven-scm.git;a=commit;h=5447abdbd58d9e888229ba9d3cefe0db1c088e6f].
was (Author: michael-o):
Fixed with
[5447abdbd58d9e888229ba9d3cefe0db1c088e6f|https://gitbox.apache.org/repos/asf?p=maven-site-plugin.git;a=commit;h=5447abdbd58d9e888229ba9d3cefe0db1c088e6f].
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-989) Tests fail if svn is not installed.
[
https://issues.apache.org/jira/browse/SCM-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541946#comment-17541946
]
Michael Osipov commented on SCM-989:
{noformat}
[INFO]
[ERROR] Failures:
[ERROR]
SvnExeListCommandTckTest>ScmTckTestCase.setUp:144->SvnListCommandTckTest.initRepo:47->ScmTestCase.execute:266
Exit value wasn't 0, was:1
[ERROR]
SvnExeListCommandTckTest>ScmTckTestCase.setUp:144->SvnListCommandTckTest.initRepo:47->ScmTestCase.execute:266
Exit value wasn't 0, was:1
[ERROR]
SvnExeListCommandTckTest>ScmTckTestCase.setUp:144->SvnListCommandTckTest.initRepo:47->ScmTestCase.execute:266
Exit value wasn't 0, was:1
[ERROR] Errors:
[ERROR] SvnRemoteInfoCommandTest.testExist:42 � Scm cmd.exe /X /C "svn
--non-interacti...
[ERROR] SvnRemoteInfoCommandTest.testNotExist:53 � Scm cmd.exe /X /C "svn
--non-intera...
[INFO]
[ERROR] Tests run: 93, Failures: 3, Errors: 2, Skipped: 29
{noformat}
and
{noformat}
[ERROR] Errors:
[ERROR] GitInfoCommandTest.testInfoCommand:52 � ScmRepository Error creating
the scm r...
[ERROR] GitInfoCommandTest.testInfoCommandWithNegativeShortRevision:85 �
ScmRepository
[ERROR] GitInfoCommandTest.testInfoCommandWithShortRevision:68 �
ScmRepository Error c...
[ERROR] GitInfoCommandTest.testInfoCommandWithZeroShortRevision:102 �
ScmRepository Er...
[INFO]
[ERROR] Tests run: 95, Failures: 0, Errors: 4, Skipped: 21
{noformat}
> Tests fail if svn is not installed.
> ---
>
> Key: SCM-989
> URL: https://issues.apache.org/jira/browse/SCM-989
> Project: Maven SCM
> Issue Type: Test
>Reporter: Niels Basjes
>Priority: Major
>
> If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the
> build fails over these tests:
> {code:java}
> [ERROR] Errors:
> [ERROR] SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing
> svn command.
> [ERROR] SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while
> executing svn command.{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SCM-989) Tests fail if svn and git commands are not available
[
https://issues.apache.org/jira/browse/SCM-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-989:
---
Summary: Tests fail if svn and git commands are not available (was: Tests
fail if svn is not installed.)
> Tests fail if svn and git commands are not available
>
>
> Key: SCM-989
> URL: https://issues.apache.org/jira/browse/SCM-989
> Project: Maven SCM
> Issue Type: Test
>Reporter: Niels Basjes
>Priority: Major
>
> If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the
> build fails over these tests:
> {code:java}
> [ERROR] Errors:
> [ERROR] SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing
> svn command.
> [ERROR] SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while
> executing svn command.{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] olamy commented on a diff in pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
olamy commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881486866
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
yup maybe something with testcontainers using such image
https://hub.docker.com/r/elleflorio/svn-server/
but frankly no much motivation to maintain more longer svn :(
why not if really nothing else to do :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541952#comment-17541952
]
ASF GitHub Bot commented on SCM-986:
olamy commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881486866
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
yup maybe something with testcontainers using such image
https://hub.docker.com/r/elleflorio/svn-server/
but frankly no much motivation to maintain more longer svn :(
why not if really nothing else to do :)
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881488429
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
No, it jus thas to be `file:///`. It is more than sufficient for a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a diff in pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881488429
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
No, it just has to be `file:///`. It is more than sufficient for a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541954#comment-17541954
]
ASF GitHub Bot commented on SCM-986:
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881488429
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
No, it jus thas to be `file:///`. It is more than sufficient for a test.
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541956#comment-17541956
]
ASF GitHub Bot commented on SCM-986:
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881488429
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
No, it just has to be `file:///`. It is more than sufficient for a test.
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881492574
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I don't know how much this matters, but this returns an unmodifiable list
while `new ArrayList()` does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541959#comment-17541959
]
ASF GitHub Bot commented on SCM-977:
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881492574
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I don't know how much this matters, but this returns an unmodifiable list
while `new ArrayList()` does not.
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881494161
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I don't think it matters too much. If I were to change it I would make all
return an unmodifiable list. I would simply leave it like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541960#comment-17541960
]
ASF GitHub Bot commented on SCM-977:
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881494161
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I don't think it matters too much. If I were to change it I would make all
return an unmodifiable list. I would simply leave it like this.
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881493091
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -466,6 +518,11 @@ public String toString()
{
StringBuilder result = new StringBuilder( author == null ? " null " :
author );
result.append( "\n" ).append( date == null ? "null " : date.toString()
).append( "\n" );
+List tags = getTags();
+if ( tags != null && !tags.isEmpty() )
Review Comment:
The null check is redudant, see your new code.
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -552,6 +609,16 @@ public String toXML()
buffer.append( "\t\t\n" );
+List tags = getTags();
+if ( tags != null && !tags.isEmpty() )
Review Comment:
The null check is redudant, see your new code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541961#comment-17541961
]
ASF GitHub Bot commented on SCM-977:
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881493091
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -466,6 +518,11 @@ public String toString()
{
StringBuilder result = new StringBuilder( author == null ? " null " :
author );
result.append( "\n" ).append( date == null ? "null " : date.toString()
).append( "\n" );
+List tags = getTags();
+if ( tags != null && !tags.isEmpty() )
Review Comment:
The null check is redudant, see your new code.
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -552,6 +609,16 @@ public String toXML()
buffer.append( "\t\t\n" );
+List tags = getTags();
+if ( tags != null && !tags.isEmpty() )
Review Comment:
The null check is redudant, see your new code.
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] olamy commented on a diff in pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
olamy commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881498188
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
`file://` for remote info? not sure this will test remote access. except a
`file://` mounted on NTFS but hey that could be worst 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541963#comment-17541963
]
ASF GitHub Bot commented on SCM-986:
olamy commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881498188
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
`file://` for remote info? not sure this will test remote access. except a
`file://` mounted on NTFS but hey that could be worst 🤣
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881500861
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
From a Subversion perspective everything with a URL is remote because it is
not a working copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-scm] michael-o commented on a diff in pull request #145: [SCM-986] SvnExe's SvnRemoteInfoCommand incorrectly implemented
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881501140
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
http://localhost/dsssdf is local also. Makes not difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541965#comment-17541965
]
ASF GitHub Bot commented on SCM-986:
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881500861
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
From a Subversion perspective everything with a URL is remote because it is
not a working copy.
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-986) SvnExe's SvnRemoteInfoCommand incorrectly implemented
[
https://issues.apache.org/jira/browse/SCM-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541966#comment-17541966
]
ASF GitHub Bot commented on SCM-986:
michael-o commented on code in PR #145:
URL: https://github.com/apache/maven-scm/pull/145#discussion_r881501140
##
maven-scm-providers/maven-scm-providers-svn/maven-scm-provider-svnexe/src/test/java/org/apache/maven/scm/provider/svn/svnexe/command/remoteinfo/SvnExeRemoteInfoCommandTrailingSlashTckTest.java:
##
@@ -0,0 +1,39 @@
+package org.apache.maven.scm.provider.svn.svnexe.command.remoteinfo;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.scm.provider.ScmProviderRepository;
+import org.apache.maven.scm.provider.svn.repository.SvnScmProviderRepository;
+
+/**
+ * @author Bertrand Paquet
+ */
+public class SvnExeRemoteInfoCommandTrailingSlashTckTest
+extends AbstractSvnExeRemoteInfoCommandTckTest
+{
+
+@Override
+protected ScmProviderRepository getScmProviderRepository()
+throws Exception
+{
+return new SvnScmProviderRepository(
"http://svn.apache.org/repos/asf/maven/maven-3/trunk/"; );
Review Comment:
http://localhost/dsssdf is local also. Makes not difference.
> SvnExe's SvnRemoteInfoCommand incorrectly implemented
> -
>
> Key: SCM-986
> URL: https://issues.apache.org/jira/browse/SCM-986
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-svn
>Affects Versions: 2.0.0-M1, 1.12.2
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M2
>
>
> Several bugs:
> 1st bug:
> This class claims to process the following URLs:
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk}}
> * {{http://svn.apache.org/repos/asf/maven/maven-3/trunk/}}
> to {{http://svn.apache.org/repos/asf/maven/maven-3}}. The first URL works,
> but the second is processed to
> {{/svn.apache.org/repos/asf/maven/maven-3/trunk}}.
> 2nd bug:
> Extracting branches happens with {{cl.createArg().setValue( baseUrl + "/tags"
> + "@" );}} instead of {{cl.createArg().setValue( baseUrl + "/branches" + "@"
> );}}
> 3rd bug:
> {{new LsConsumer()}} receives the new, reduced base URL as constructor arg
> and contructs the final tag/branch URLs as:
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.0}} and
> {{http://svn.apache.org/repos/asf/maven/maven-3/maven-3.x}}. The path
> segments {{tags}} and {{branches}} are never passed.
> Branch SCM-986 includes an extended TCK test to verify this faulty behavior.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881523119
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
What would you like me to do here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
nielsbasjes commented on code in PR #135: URL: https://github.com/apache/maven-scm/pull/135#discussion_r881523526 ## maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java: ## @@ -552,6 +609,16 @@ public String toXML() buffer.append( "\t\t\n" ); +List tags = getTags(); +if ( tags != null && !tags.isEmpty() ) Review Comment: Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[ https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541976#comment-17541976 ] ASF GitHub Bot commented on SCM-977: nielsbasjes commented on code in PR #135: URL: https://github.com/apache/maven-scm/pull/135#discussion_r881523526 ## maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java: ## @@ -552,6 +609,16 @@ public String toXML() buffer.append( "\t\t\n" ); +List tags = getTags(); +if ( tags != null && !tags.isEmpty() ) Review Comment: Fixed > Retrieve the tags on commits using the changelog command. > - > > Key: SCM-977 > URL: https://issues.apache.org/jira/browse/SCM-977 > Project: Maven SCM > Issue Type: New Feature > Components: maven-scm-api, maven-scm-provider-gitexe, > maven-scm-provider-jgit, maven-scm-provider-mercurial (hg) >Reporter: Niels Basjes >Priority: Major > > My aim is to support having something like > [https://www.conventionalcommits.org/] in the maven-release-plugin. > This simply means that the next version of a release is calculated from the > last tag in the version history and the patterns in the commit messages since > that tag. > To support this idea the maven-scm should be extended to also retrieve the > tags with the changelog command on SCM implementations that support this idea. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541975#comment-17541975
]
ASF GitHub Bot commented on SCM-977:
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881523119
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
What would you like me to do here?
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SCM-989) Tests fail if svn and/or git are not installed.
[
https://issues.apache.org/jira/browse/SCM-989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Niels Basjes updated SCM-989:
-
Summary: Tests fail if svn and/or git are not installed. (was: Tests fail
if svn and git commands are not available)
> Tests fail if svn and/or git are not installed.
> ---
>
> Key: SCM-989
> URL: https://issues.apache.org/jira/browse/SCM-989
> Project: Maven SCM
> Issue Type: Test
>Reporter: Niels Basjes
>Priority: Major
>
> If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the
> build fails over these tests:
> {code:java}
> [ERROR] Errors:
> [ERROR] SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing
> svn command.
> [ERROR] SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while
> executing svn command.{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (SCM-989) Tests fail if svn and/or git are not installed.
[
https://issues.apache.org/jira/browse/SCM-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541986#comment-17541986
]
Niels Basjes commented on SCM-989:
--
I just ran a check and indeed the same happens if git is missing.
I found the same list you just posted.
Perhaps the check if the commandline tool has been installed check should be
moved 1 class up so it can be used in all tests?
Or are these tests really TCK tests and should be changed in that direction?
> Tests fail if svn and/or git are not installed.
> ---
>
> Key: SCM-989
> URL: https://issues.apache.org/jira/browse/SCM-989
> Project: Maven SCM
> Issue Type: Test
>Reporter: Niels Basjes
>Priority: Major
>
> If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the
> build fails over these tests:
> {code:java}
> [ERROR] Errors:
> [ERROR] SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing
> svn command.
> [ERROR] SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while
> executing svn command.{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881536034
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I'd just use a mutuable list for consistency. Later, when properly discussed
immutable objects should be made immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541992#comment-17541992
]
ASF GitHub Bot commented on SCM-977:
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881536034
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I'd just use a mutuable list for consistency. Later, when properly discussed
immutable objects should be made immutable.
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] michael-o commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881536034
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I'd just use a mutuable list for consistency. Later, when properly discussed
immutuable objects should be made immutuable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541993#comment-17541993
]
ASF GitHub Bot commented on SCM-977:
michael-o commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881536034
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
I'd just use a mutuable list for consistency. Later, when properly discussed
immutuable objects should be made immutuable.
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-scm] nielsbasjes commented on a diff in pull request #135: [SCM-977] Support for retrieving tags from the changelog
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881542491
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-977) Retrieve the tags on commits using the changelog command.
[
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541998#comment-17541998
]
ASF GitHub Bot commented on SCM-977:
nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881542491
##
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##
@@ -414,6 +419,53 @@ public String getTimeFormatted()
return TIME_FORMAT.format( getDate() );
}
+/**
+ * Getter for property tags.
+ *
+ * @return Value of property author.
+ */
+public List getTags()
+{
+if ( tags == null )
+{
+return Collections.emptyList();
Review Comment:
Ok
> Retrieve the tags on commits using the changelog command.
> -
>
> Key: SCM-977
> URL: https://issues.apache.org/jira/browse/SCM-977
> Project: Maven SCM
> Issue Type: New Feature
> Components: maven-scm-api, maven-scm-provider-gitexe,
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>Reporter: Niels Basjes
>Priority: Major
>
> My aim is to support having something like
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the
> last tag in the version history and the patterns in the commit messages since
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the
> tags with the changelog command on SCM implementations that support this idea.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven] slawekjaranowski commented on pull request #741: [MNG-7468] Check unsupported plugins parameters in configuration
slawekjaranowski commented on PR #741: URL: https://github.com/apache/maven/pull/741#issuecomment-1137364553 @michael-o any comments after merge I will cherry-pick to 3.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542079#comment-17542079
]
ASF GitHub Bot commented on MNG-7468:
-
slawekjaranowski commented on PR #741:
URL: https://github.com/apache/maven/pull/741#issuecomment-1137364553
@michael-o any comments
after merge I will cherry-pick to 3.9
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #219: [MDEP-602] - Log dependency warnings as errors when failOnWarning is set
slawekjaranowski commented on code in PR #219: URL: https://github.com/apache/maven-dependency-plugin/pull/219#discussion_r881752957 ## src/it/projects/mdep-602-log-on-error-level-when-failOnWarning/pom.xml: ## @@ -0,0 +1,55 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.plugins.dependency + mdep-602-log-on-error-level-when-failOnWarning + 1.0.0-SNAPSHOT + + Test that dependency:analyze logs dependency warnings as errors when failOnWarning is set to true + + +UTF-8 + + + + + org.apache.maven + maven-project + 2.0.6 Review Comment: please use something newer - 3.2.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] kwin commented on pull request #130: scm tag is added to child module
kwin commented on PR #130: URL: https://github.com/apache/maven-release/pull/130#issuecomment-1137389263 @hboutemy Can you also check the remotely related #86? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] hisener commented on a diff in pull request #219: [MDEP-602] - Log dependency warnings as errors when failOnWarning is set
hisener commented on code in PR #219: URL: https://github.com/apache/maven-dependency-plugin/pull/219#discussion_r881782507 ## src/it/projects/mdep-602-log-on-error-level-when-failOnWarning/pom.xml: ## @@ -0,0 +1,55 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.plugins.dependency + mdep-602-log-on-error-level-when-failOnWarning + 1.0.0-SNAPSHOT + + Test that dependency:analyze logs dependency warnings as errors when failOnWarning is set to true + + +UTF-8 + + + + + org.apache.maven + maven-project + 2.0.6 Review Comment: I copy-pasted this from another test. :grimacing: I can bump the version, but 3.2.5 doesn't seem available on Maven Central. :eyes: https://search.maven.org/artifact/org.apache.maven/maven-project -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet closed pull request #19: Add an IT for remote build cache using webdav
gnodet closed pull request #19: Add an IT for remote build cache using webdav URL: https://github.com/apache/maven-build-cache-extension/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on a diff in pull request #219: [MDEP-602] - Log dependency warnings as errors when failOnWarning is set
slawekjaranowski commented on code in PR #219: URL: https://github.com/apache/maven-dependency-plugin/pull/219#discussion_r881792406 ## src/it/projects/mdep-602-log-on-error-level-when-failOnWarning/pom.xml: ## @@ -0,0 +1,55 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.plugins.dependency + mdep-602-log-on-error-level-when-failOnWarning + 1.0.0-SNAPSHOT + + Test that dependency:analyze logs dependency warnings as errors when failOnWarning is set to true + + +UTF-8 + + + + + org.apache.maven + maven-project + 2.0.6 Review Comment: ok, leave as is. It will be different task to upgrade Maven version in tests 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-build-cache-extension] gnodet opened a new pull request, #21: Add a remote cache IT
gnodet opened a new pull request, #21: URL: https://github.com/apache/maven-build-cache-extension/pull/21 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542099#comment-17542099
]
ASF GitHub Bot commented on MNG-7468:
-
michael-o commented on PR #741:
URL: https://github.com/apache/maven/pull/741#issuecomment-1137445728
Will check tomorrow, today is full
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven] michael-o commented on pull request #741: [MNG-7468] Check unsupported plugins parameters in configuration
michael-o commented on PR #741: URL: https://github.com/apache/maven/pull/741#issuecomment-1137445728 Will check tomorrow, today is full -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] hisener commented on pull request #219: [MDEP-602] - Log dependency warnings as errors when failOnWarning is set
hisener commented on PR #219: URL: https://github.com/apache/maven-dependency-plugin/pull/219#issuecomment-1137466806 Added a commit for adding assertions, PTAL. Shall I squash commits into one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #219: [MDEP-602] - Log dependency warnings as errors when failOnWarning is set
slawekjaranowski commented on PR #219: URL: https://github.com/apache/maven-dependency-plugin/pull/219#issuecomment-1137468915 > > Shall I squash commits into one? yes - please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7481) [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> [Help 1]
[ https://issues.apache.org/jira/browse/MNG-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542185#comment-17542185 ] Simon Matthews commented on MNG-7481: - Updating to 3.8.5 was simple and fixed the problem. > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > --- > > Key: MNG-7481 > URL: https://issues.apache.org/jira/browse/MNG-7481 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.5 > Environment: CentOS 7 > $ mvn --version > Apache Maven 3.0.5 (Red Hat 3.0.5-17) > Maven home: /usr/share/maven > Java version: 1.8.0_332, vendor: Red Hat, Inc. > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.332.b09-1.el7_9.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.10.0-1160.15.2.el7.x86_64", arch: "amd64", > family: "unix" >Reporter: Simon Matthews >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > I get this message when I run "mvn install" on the unaltered source for the > Jenkins plugin "analysis model": > [https://github.com/jenkinsci/analysis-model] > > $ mvn install > [INFO] Scanning for projects... > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > org.apache.maven.InternalErrorException: Internal error: > java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) > Caused by: java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2470) > at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1257) > at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1105) > at org.codehaus.plexus.util.xml.pull.MXParser.nextTag(MXParser.java:1090) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePluginExecution(MavenXpp3ReaderEx.java:3541) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePlugin(MavenXpp3ReaderEx.java:3336) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseBuildBase(MavenXpp3ReaderEx.java:1398) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseProfile(MavenXpp3ReaderEx.java:3751) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseModel(MavenXpp3ReaderEx.java:2809) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:4627) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:837) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:118) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:91) > at > org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:77) > at > org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:456) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:261) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:410) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:379) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:343) > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:636) > at > org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:585) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:234) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > ... 11 more > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to
[jira] [Commented] (MNG-7481) [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> [Help 1]
[ https://issues.apache.org/jira/browse/MNG-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542187#comment-17542187 ] Karl Heinz Marbaise commented on MNG-7481: -- Thank you for your feedback. > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > --- > > Key: MNG-7481 > URL: https://issues.apache.org/jira/browse/MNG-7481 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.5 > Environment: CentOS 7 > $ mvn --version > Apache Maven 3.0.5 (Red Hat 3.0.5-17) > Maven home: /usr/share/maven > Java version: 1.8.0_332, vendor: Red Hat, Inc. > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.332.b09-1.el7_9.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.10.0-1160.15.2.el7.x86_64", arch: "amd64", > family: "unix" >Reporter: Simon Matthews >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > I get this message when I run "mvn install" on the unaltered source for the > Jenkins plugin "analysis model": > [https://github.com/jenkinsci/analysis-model] > > $ mvn install > [INFO] Scanning for projects... > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > org.apache.maven.InternalErrorException: Internal error: > java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) > Caused by: java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2470) > at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1257) > at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1105) > at org.codehaus.plexus.util.xml.pull.MXParser.nextTag(MXParser.java:1090) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePluginExecution(MavenXpp3ReaderEx.java:3541) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePlugin(MavenXpp3ReaderEx.java:3336) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseBuildBase(MavenXpp3ReaderEx.java:1398) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseProfile(MavenXpp3ReaderEx.java:3751) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseModel(MavenXpp3ReaderEx.java:2809) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:4627) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:837) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:118) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:91) > at > org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:77) > at > org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:456) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:261) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:410) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:379) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:343) > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:636) > at > org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:585) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:234) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > ... 11 more > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full
[jira] [Closed] (MNG-7481) [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> [Help 1]
[ https://issues.apache.org/jira/browse/MNG-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-7481. Resolution: Fixed > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > --- > > Key: MNG-7481 > URL: https://issues.apache.org/jira/browse/MNG-7481 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.5 > Environment: CentOS 7 > $ mvn --version > Apache Maven 3.0.5 (Red Hat 3.0.5-17) > Maven home: /usr/share/maven > Java version: 1.8.0_332, vendor: Red Hat, Inc. > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.332.b09-1.el7_9.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.10.0-1160.15.2.el7.x86_64", arch: "amd64", > family: "unix" >Reporter: Simon Matthews >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > I get this message when I run "mvn install" on the unaltered source for the > Jenkins plugin "analysis model": > [https://github.com/jenkinsci/analysis-model] > > $ mvn install > [INFO] Scanning for projects... > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > org.apache.maven.InternalErrorException: Internal error: > java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) > Caused by: java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2470) > at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1257) > at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1105) > at org.codehaus.plexus.util.xml.pull.MXParser.nextTag(MXParser.java:1090) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePluginExecution(MavenXpp3ReaderEx.java:3541) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePlugin(MavenXpp3ReaderEx.java:3336) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseBuildBase(MavenXpp3ReaderEx.java:1398) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseProfile(MavenXpp3ReaderEx.java:3751) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseModel(MavenXpp3ReaderEx.java:2809) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:4627) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:837) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:118) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:91) > at > org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:77) > at > org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:456) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:261) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:410) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:379) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:343) > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:636) > at > org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:585) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:234) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > ... 11 more > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the
[jira] [Commented] (SCM-989) Tests fail if svn and/or git are not installed.
[
https://issues.apache.org/jira/browse/SCM-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542194#comment-17542194
]
Michael Osipov commented on SCM-989:
This, I need to check. Frankly, I don't know the reason between TCK and UT.
> Tests fail if svn and/or git are not installed.
> ---
>
> Key: SCM-989
> URL: https://issues.apache.org/jira/browse/SCM-989
> Project: Maven SCM
> Issue Type: Test
>Reporter: Niels Basjes
>Priority: Major
>
> If svn is not installled (As is the case in Ubuntu in WSL2 in Windows 11) the
> build fails over these tests:
> {code:java}
> [ERROR] Errors:
> [ERROR] SvnRemoteInfoCommandTest.testExist:42 » Scm Error while executing
> svn command.
> [ERROR] SvnRemoteInfoCommandTest.testNotExist:53 » Scm Error while
> executing svn command.{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Reopened] (MNG-7481) [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> [Help 1]
[ https://issues.apache.org/jira/browse/MNG-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MNG-7481: - > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > --- > > Key: MNG-7481 > URL: https://issues.apache.org/jira/browse/MNG-7481 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.5 > Environment: CentOS 7 > $ mvn --version > Apache Maven 3.0.5 (Red Hat 3.0.5-17) > Maven home: /usr/share/maven > Java version: 1.8.0_332, vendor: Red Hat, Inc. > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.332.b09-1.el7_9.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.10.0-1160.15.2.el7.x86_64", arch: "amd64", > family: "unix" >Reporter: Simon Matthews >Priority: Major > Fix For: waiting-for-feedback, wontfix-candidate > > > I get this message when I run "mvn install" on the unaltered source for the > Jenkins plugin "analysis model": > [https://github.com/jenkinsci/analysis-model] > > $ mvn install > [INFO] Scanning for projects... > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > org.apache.maven.InternalErrorException: Internal error: > java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) > Caused by: java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2470) > at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1257) > at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1105) > at org.codehaus.plexus.util.xml.pull.MXParser.nextTag(MXParser.java:1090) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePluginExecution(MavenXpp3ReaderEx.java:3541) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePlugin(MavenXpp3ReaderEx.java:3336) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseBuildBase(MavenXpp3ReaderEx.java:1398) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseProfile(MavenXpp3ReaderEx.java:3751) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseModel(MavenXpp3ReaderEx.java:2809) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:4627) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:837) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:118) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:91) > at > org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:77) > at > org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:456) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:261) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:410) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:379) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:343) > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:636) > at > org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:585) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:234) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > ... 11 more > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solution
[jira] [Closed] (MNG-7481) [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> [Help 1]
[ https://issues.apache.org/jira/browse/MNG-7481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-7481. --- Fix Version/s: (was: waiting-for-feedback) (was: wontfix-candidate) Resolution: Information Provided > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > --- > > Key: MNG-7481 > URL: https://issues.apache.org/jira/browse/MNG-7481 > Project: Maven > Issue Type: Bug >Affects Versions: 3.0.5 > Environment: CentOS 7 > $ mvn --version > Apache Maven 3.0.5 (Red Hat 3.0.5-17) > Maven home: /usr/share/maven > Java version: 1.8.0_332, vendor: Red Hat, Inc. > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.332.b09-1.el7_9.x86_64/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.10.0-1160.15.2.el7.x86_64", arch: "amd64", > family: "unix" >Reporter: Simon Matthews >Priority: Major > > I get this message when I run "mvn install" on the unaltered source for the > Jenkins plugin "analysis model": > [https://github.com/jenkinsci/analysis-model] > > $ mvn install > [INFO] Scanning for projects... > [ERROR] Internal error: java.lang.ArrayIndexOutOfBoundsException: 20081 -> > [Help 1] > org.apache.maven.InternalErrorException: Internal error: > java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168) > at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537) > at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196) > at org.apache.maven.cli.MavenCli.main(MavenCli.java:141) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290) > at > org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230) > at > org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414) > at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357) > Caused by: java.lang.ArrayIndexOutOfBoundsException: 20081 > at org.codehaus.plexus.util.xml.pull.MXParser.parsePI(MXParser.java:2470) > at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl(MXParser.java:1257) > at org.codehaus.plexus.util.xml.pull.MXParser.next(MXParser.java:1105) > at org.codehaus.plexus.util.xml.pull.MXParser.nextTag(MXParser.java:1090) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePluginExecution(MavenXpp3ReaderEx.java:3541) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parsePlugin(MavenXpp3ReaderEx.java:3336) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseBuildBase(MavenXpp3ReaderEx.java:1398) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseProfile(MavenXpp3ReaderEx.java:3751) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.parseModel(MavenXpp3ReaderEx.java:2809) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:4627) > at > org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read(MavenXpp3ReaderEx.java:837) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:118) > at > org.apache.maven.model.io.DefaultModelReader.read(DefaultModelReader.java:91) > at > org.apache.maven.model.building.DefaultModelProcessor.read(DefaultModelProcessor.java:77) > at > org.apache.maven.model.building.DefaultModelBuilder.readModel(DefaultModelBuilder.java:456) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:261) > at > org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:232) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:410) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:379) > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:343) > at org.apache.maven.DefaultMaven.collectProjects(DefaultMaven.java:636) > at > org.apache.maven.DefaultMaven.getProjectsForMavenReactor(DefaultMaven.java:585) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:234) > at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156) > ... 11 more > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the -e > switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR]
[GitHub] [maven] michael-o commented on a diff in pull request #741: [MNG-7468] Check unsupported plugins parameters in configuration
michael-o commented on code in PR #741:
URL: https://github.com/apache/maven/pull/741#discussion_r882048013
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -40,6 +51,7 @@
public class DefaultMojoExecutionConfigurator
implements MojoExecutionConfigurator
{
+private Logger logger = LoggerFactory.getLogger( getClass() );
Review Comment:
Make it final, good habit.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -108,4 +122,75 @@ private PluginExecution findPluginExecution( String
executionId, Collection parametersNamesGoal =
mojoDescriptor.getParameters().stream()
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+Set unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesGoal );
+
+if ( unknownParameters.isEmpty() )
+{
+return;
+}
+
+// second step get parameter names of all plugin goals
+Set parametersNamesAll =
mojoDescriptor.getPluginDescriptor().getMojos().stream()
+.flatMap( m -> m.getParameters().stream() )
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
Review Comment:
Why do you compare with all other goals too?
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -76,6 +88,8 @@ else if ( allowPluginLevelConfig )
mojoConfiguration = Xpp3Dom.mergeXpp3Dom(
mojoExecution.getConfiguration(), mojoConfiguration );
mojoExecution.setConfiguration( mojoConfiguration );
+
+checkUnKnownMojoConfigurationParameters( mojoExecution );
Review Comment:
`Unknown`
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -108,4 +122,75 @@ private PluginExecution findPluginExecution( String
executionId, Collection parametersNamesGoal =
mojoDescriptor.getParameters().stream()
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+Set unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesGoal );
+
+if ( unknownParameters.isEmpty() )
+{
+return;
+}
+
+// second step get parameter names of all plugin goals
+Set parametersNamesAll =
mojoDescriptor.getPluginDescriptor().getMojos().stream()
+.flatMap( m -> m.getParameters().stream() )
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesAll );
+
+unknownParameters.forEach(
+name ->
+{
+MessageBuilder messageBuilder = MessageUtils.buffer()
+.warning( "Parameter '" )
+.warning( name )
+.warning( "' is unknown for plugin: '" )
+.warning( mojoExecution.getArtifactId() ).warning( ":" )
+.warning( mojoExecution.getVersion() ).warning( ":" )
+.warning( mojoExecution.getGoal() );
Review Comment:
Is this consistent with other formats we use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7468) Unsupported plugins parameters in configuration should be verified
[
https://issues.apache.org/jira/browse/MNG-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542221#comment-17542221
]
ASF GitHub Bot commented on MNG-7468:
-
michael-o commented on code in PR #741:
URL: https://github.com/apache/maven/pull/741#discussion_r882048013
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -40,6 +51,7 @@
public class DefaultMojoExecutionConfigurator
implements MojoExecutionConfigurator
{
+private Logger logger = LoggerFactory.getLogger( getClass() );
Review Comment:
Make it final, good habit.
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -108,4 +122,75 @@ private PluginExecution findPluginExecution( String
executionId, Collection parametersNamesGoal =
mojoDescriptor.getParameters().stream()
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+Set unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesGoal );
+
+if ( unknownParameters.isEmpty() )
+{
+return;
+}
+
+// second step get parameter names of all plugin goals
+Set parametersNamesAll =
mojoDescriptor.getPluginDescriptor().getMojos().stream()
+.flatMap( m -> m.getParameters().stream() )
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
Review Comment:
Why do you compare with all other goals too?
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -76,6 +88,8 @@ else if ( allowPluginLevelConfig )
mojoConfiguration = Xpp3Dom.mergeXpp3Dom(
mojoExecution.getConfiguration(), mojoConfiguration );
mojoExecution.setConfiguration( mojoConfiguration );
+
+checkUnKnownMojoConfigurationParameters( mojoExecution );
Review Comment:
`Unknown`
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -108,4 +122,75 @@ private PluginExecution findPluginExecution( String
executionId, Collection parametersNamesGoal =
mojoDescriptor.getParameters().stream()
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+Set unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesGoal );
+
+if ( unknownParameters.isEmpty() )
+{
+return;
+}
+
+// second step get parameter names of all plugin goals
+Set parametersNamesAll =
mojoDescriptor.getPluginDescriptor().getMojos().stream()
+.flatMap( m -> m.getParameters().stream() )
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesAll );
+
+unknownParameters.forEach(
+name ->
+{
+MessageBuilder messageBuilder = MessageUtils.buffer()
+.warning( "Parameter '" )
+.warning( name )
+.warning( "' is unknown for plugin: '" )
+.warning( mojoExecution.getArtifactId() ).warning( ":" )
+.warning( mojoExecution.getVersion() ).warning( ":" )
+.warning( mojoExecution.getGoal() );
Review Comment:
Is this consistent with other formats we use?
> Unsupported plugins parameters in configuration should be verified
> --
>
> Key: MNG-7468
> URL: https://issues.apache.org/jira/browse/MNG-7468
> Project: Maven
> Issue Type: New Feature
> Components: Plugins and Lifecycle
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.9.0, 4.0.0-alpha-1, 4.0.0
>
>
> Currently we can provide any xml tags in plugin configuration even if plugin
> Mojo doesn't support specific parameters.
> eg we can have:
> {code:xml}
>
> example-maven-plugin
> 1.1.1
>
>
>
>
> {code}
> With example configuration Mojo is executed without any warning.
> Simply if parameters is not supported - build should break with some of
> invalid plugin configuration exception ...
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven] michael-o commented on a diff in pull request #741: [MNG-7468] Check unsupported plugins parameters in configuration
michael-o commented on code in PR #741:
URL: https://github.com/apache/maven/pull/741#discussion_r882052375
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DefaultMojoExecutionConfigurator.java:
##
@@ -108,4 +122,75 @@ private PluginExecution findPluginExecution( String
executionId, Collection parametersNamesGoal =
mojoDescriptor.getParameters().stream()
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+Set unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesGoal );
+
+if ( unknownParameters.isEmpty() )
+{
+return;
+}
+
+// second step get parameter names of all plugin goals
+Set parametersNamesAll =
mojoDescriptor.getPluginDescriptor().getMojos().stream()
+.flatMap( m -> m.getParameters().stream() )
+.flatMap( this::getParameterNames )
+.collect( Collectors.toSet() );
+
+unknownParameters = getUnknownParameters( mojoExecution,
parametersNamesAll );
+
+unknownParameters.forEach(
+name ->
+{
+MessageBuilder messageBuilder = MessageUtils.buffer()
+.warning( "Parameter '" )
+.warning( name )
+.warning( "' is unknown for plugin: '" )
Review Comment:
Single quote is unbalanced. Combining single quote and colon doesn't really
make sense, no? I'd drop the colon and use single quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
