[ 
https://issues.apache.org/jira/browse/SCM-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541960#comment-17541960
 ] 

ASF GitHub Bot commented on SCM-977:
------------------------------------

nielsbasjes commented on code in PR #135:
URL: https://github.com/apache/maven-scm/pull/135#discussion_r881494161


##########
maven-scm-api/src/main/java/org/apache/maven/scm/ChangeSet.java:
##########
@@ -414,6 +419,53 @@ public String getTimeFormatted()
         return TIME_FORMAT.format( getDate() );
     }
 
+    /**
+     * Getter for property tags.
+     *
+     * @return Value of property author.
+     */
+    public List<String> getTags()
+    {
+        if ( tags == null )
+        {
+            return Collections.emptyList();

Review Comment:
   I don't think it matters too much. If I were to change it I would make all 
return an unmodifiable list. I would simply leave it like this.





> Retrieve the tags on commits using the changelog command.
> ---------------------------------------------------------
>
>                 Key: SCM-977
>                 URL: https://issues.apache.org/jira/browse/SCM-977
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-api, maven-scm-provider-gitexe, 
> maven-scm-provider-jgit, maven-scm-provider-mercurial (hg)
>            Reporter: Niels Basjes
>            Priority: Major
>
> My aim is to support having something like 
> [https://www.conventionalcommits.org/] in the maven-release-plugin.
> This simply means that the next version of a release is calculated from the 
> last tag in the version history and the patterns in the commit messages since 
> that tag.
> To support this idea the maven-scm should be extended to also retrieve the 
> tags with the changelog command on SCM implementations that support this idea.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to