[jira] [Updated] (MRESOLVER-247) Avoid unnecessary dependency resolution by a Skip solution based on BFS
[
https://issues.apache.org/jira/browse/MRESOLVER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wei cai updated MRESOLVER-247:
--
Description:
h1. *Background*
This Jira is related with MRESOLVER-240 and MRESOLVER-228
There were discussions about the DFS or BFS algorithm for maven resolver in
MRESOLVER-228, Changing to BFS would make MRESOLVER-228 & MRESOLVER-7 much
easier to implement. Here is the plan for multiple changes requested recently:
* DFS > BFS - preparation for parallel download
* Skip approach - avoid unnecessary version resolution （Covered in this JIRA）
* Download descriptors in parallel (MRESOLVER-7)
h1. *The phenomenon*
When comes to resolve the huge amount of dependencies of an enterprise level
project, the maven resolver is very slow to resolve the dependency graph/tree.
Take one of our app as example, it could take *10minutes+ and 16G memory* to
print out the result of {*}mvn dependency:tree{*}.
This is because there are many dependencies declared in the project, and some
of the dependencies would introduce *600+* transitive dependencies, and
exclusions are widely used to solve dependency conflicts.
By checking the
[code|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L500],
we know the exclusion is also part of the cache key. This means when the
exclusions up the tree differs, the cached resolution result for the same GAV
won't be picked up and need s to be recalculated.
!exclusion-matters.png!
>From above figure, we know:
* In 1st case, D will be resolved only once as there are no exclusions/same
exclusions up the tree.
* In 2nd case, the B and C have different exclusions and D needs to be
recalculated, if D is a heavy dependency which introduce many transitive
dependencies, all D and its children (D & E in this case) need to be
recalculated. Recalculating all of these nodes introduces 2 issues:
** Slow in resolving dependencies.
** Lots of DependencyNodes cached (all calculated/recalculated nodes would be
cached) and will consume huge memory.
h1. Solution
To improve the speed of maven resolver's dependency resolution, I implemented
a skip approach to avoid unnecessary dependency resolution.
h2. *CASE 1: Skip duplicate node (omitted duplicate case in dependency tree)*
!skip-duplicate.png!
>From above figure:
* The R#3 is resolved at depth 2, in the BFS solution, we already know R#3 is
the winner.
* The R#5 won't be the winner, however here we force resolved this node as it
is more left than the last resolved R#3 node. This is because maven picks up
widest scope present among conflicting dependencies (scopes of the conflicts
may differ), we need to *retain the conflict paths* by using a strategy like:
** R#3 locates in coordinate (2 - depth, 2 - sequence in given depth) while
R#5 locates in (3,1), R#5 is more left than R#3, so we need to force resolve
R#5.
** If there is a R#6 which is more left than R#5, then need to force resolve
R#6.
* The R#8 is at depth 3 and the R#12 at depth 4 are simply skipped as R#3 is
already resolved at depth 2. This is because the same node with deeper depth
won't be picked up by maven as maven employs a "nearest transitive dependency
in the tree depth and the first in resolution" strategy.
h2. *CASE 2: Skip version conflict (omitted conflict case in dependency tree)*
*!skip-version-conflicts.png!*
In above figure.
* The D1 (D with version 1, #4) is resolved, in the BFS solution, we already
know D1 is the winner
* When comes to resolve D2 (D with version 2, after #4), we know D2 is having
a different version and it conflicts with D1, D2 will be skipped as it won't be
picked up by maven, all D2's children *won't be resolved* then.
After we enabled the resolver patch in maven, we are seeing 10% ~70% build time
reduced for different projects depend on how complex the dependencies are, and
the result of *mvn dependency:tree* and *mvn dependency:list* remain the same.
We've verified the resolver performance patch leveraging an automation solution
to certify 2000+ apps of our company by comparing the *mvn dependency:tree*
and *mvn dependency:list* result with/without the performance patch.
Please help review the PR.
https://github.com/apache/maven-resolver/pull/158
was:
h1. *Background*
This Jira is related with MRESOLVER-240 and MRESOLVER-228
There were discussions about the DFS or BFS algorithm for maven resolver in
MRESOLVER-228, Changing to BFS would make MRESOLVER-228 & MRESOLVER-7 much
easier to implement. Here is the plan for multiple changes requested recently:
* DFS > BFS - preparation for parallel download
* Skip approach - avoid unnecessary version resolution （Covered in this JIRA）
* Download descriptors in parallel (MRESOLVER-7)
h1. *The phenomenon*
When comes to resolve the hug
[jira] [Assigned] (MRESOLVER-247) Avoid unnecessary dependency resolution by a Skip solution based on BFS
[
https://issues.apache.org/jira/browse/MRESOLVER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MRESOLVER-247:
Assignee: Michael Osipov
> Avoid unnecessary dependency resolution by a Skip solution based on BFS
> ---
>
> Key: MRESOLVER-247
> URL: https://issues.apache.org/jira/browse/MRESOLVER-247
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.7.3
>Reporter: wei cai
>Assignee: Michael Osipov
>Priority: Major
> Attachments: exclusion-matters.png, skip-duplicate.png,
> skip-version-conflicts.png
>
>
> h1. *Background*
> This Jira is related with MRESOLVER-240 and MRESOLVER-228
> There were discussions about the DFS or BFS algorithm for maven resolver in
> MRESOLVER-228, Changing to BFS would make MRESOLVER-228 & MRESOLVER-7 much
> easier to implement. Here is the plan for multiple changes requested recently:
> * DFS > BFS - preparation for parallel download
> * Skip approach - avoid unnecessary version resolution （Covered in this JIRA）
> * Download descriptors in parallel (MRESOLVER-7)
> h1. *The phenomenon*
> When comes to resolve the huge amount of dependencies of an enterprise level
> project, the maven resolver is very slow to resolve the dependency
> graph/tree. Take one of our app as example, it could take *10minutes+ and 16G
> memory* to print out the result of {*}mvn dependency:tree{*}.
> This is because there are many dependencies declared in the project, and some
> of the dependencies would introduce *600+* transitive dependencies, and
> exclusions are widely used to solve dependency conflicts.
> By checking the
> [code|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L500],
> we know the exclusion is also part of the cache key. This means when the
> exclusions up the tree differs, the cached resolution result for the same GAV
> won't be picked up and need s to be recalculated.
>
> !exclusion-matters.png!
>
> From above figure, we know:
> * In 1st case, D will be resolved only once as there are no exclusions/same
> exclusions up the tree.
> * In 2nd case, the B and C have different exclusions and D needs to be
> recalculated, if D is a heavy dependency which introduce many transitive
> dependencies, all D and its children (D & E in this case) need to be
> recalculated. Recalculating all of these nodes introduces 2 issues:
> ** Slow in resolving dependencies.
> ** Lots of DependencyNodes cached (all calculated/recalculated nodes would
> be cached) and will consume huge memory.
> h1. Solution
> To improve the speed of maven resolver's dependency resolution, I
> implemented a skip approach to avoid unnecessary dependency resolution.
> h2. *CASE 1: Skip duplicate node (omitted duplicate case in dependency tree)*
> !skip-duplicate.png!
> From above figure:
> * The R#3 is resolved at depth 2, in the BFS solution, we already know R#3
> is the winner.
> * The R#5 won't be the winner, however here we force resolved this node as
> it is more left than the last resolved R#3 node. This is because maven picks
> up widest scope present among conflicting dependencies (scopes of the
> conflicts may differ), we need to *retain the conflict paths* by using a
> strategy like:
> ** R#3 locates in coordinate (2 - depth, 2 - sequence in given depth) while
> R#5 locates in (3,1), R#5 is more left than R#3, so we need to force resolve
> R#5.
> ** If there is a R#6 which is more left than R#5, then need to force resolve
> R#6.
> * The R#8 is at depth 3 and the R#12 at depth 4 are simply skipped as R#3 is
> already resolved at depth 2. This is because the same node with deeper depth
> won't be picked up by maven as maven employs a "nearest transitive dependency
> in the tree depth and the first in resolution" strategy.
> h2. *CASE 2: Skip version conflict (omitted conflict case in dependency tree)*
> *!skip-version-conflicts.png!*
> In above figure.
> * The D1 (D with version 1, #4) is resolved, in the BFS solution, we already
> know D1 is the winner
> * When comes to resolve D2 (D with version 2, after #4), we know D2 is
> having a different version and it conflicts with D1, D2 will be skipped as it
> won't be picked up by maven, all D2's children *won't be resolved* then.
> After we enabled the resolver patch in maven, we are seeing 10% ~70% build
> time reduced for different projects depend on how complex the dependencies
> are, and the result of *mvn dependency:tree* and *mvn dependency:list* remain
> the same.
> We've verified the resolver performance patch leveraging an automation
> solution to certify 2000+ apps of our
[jira] [Closed] (MRESOLVER-228) Improve the maven dependency resolution speed by a skip & reconcile approach
[
https://issues.apache.org/jira/browse/MRESOLVER-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MRESOLVER-228.
Fix Version/s: (was: 1.8.0)
Assignee: Michael Osipov
Resolution: Duplicate
> Improve the maven dependency resolution speed by a skip & reconcile approach
>
>
> Key: MRESOLVER-228
> URL: https://issues.apache.org/jira/browse/MRESOLVER-228
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.7.2
>Reporter: wei cai
>Assignee: Michael Osipov
>Priority: Major
> Attachments: Screen Shot 2021-11-27 at 12.58.26 PM.png, Screen Shot
> 2021-11-27 at 12.58.59 PM.png, Screen Shot 2021-11-27 at 12.59.32 PM.png
>
>
> When comes to resolve the huge amount of dependencies of an enterprise level
> project, the maven resolver is very slow to resolve the dependency
> graph/tree. Take one of our app as example, it could take *10minutes+ and 16G
> memory* to print out the result of {*}mvn dependency:tree{*}.
> This is because there are many dependencies declared in the project, and some
> of the dependencies would introduce *600+* transitive dependencies, and
> exclusions are widely used to solve dependency conflicts.
> By checking the
> [code|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L500],
> we know the exclusion is also part of the cache key. This means when the
> exclusions up the tree differs, the cached resolution result for the same GAV
> won't be picked up and need s to be recalculated.
> !Screen Shot 2021-11-27 at 12.58.26 PM.png!
> From above figure, we know:
> * In 1st case, D will be resolved only once as there are no exclusions/same
> exclusions up the tree.
> * In 2nd case, the B and C have different exclusions and D needs to be
> recalculated, if D is a heavy dependency which introduce many transitive
> dependencies, all D and its children needs to be recalculated. Recalculating
> all of these nodes introduces 2 issues:
> ** Slow in resolving dependencies.
> ** Lots of DependencyNodes cached (all calculated/recalculated nodes would
> be cached) and will consume huge memory.
> To improve the speed of maven resolver's dependency resolution, I
> implemented a skip & reconcile approach. Here is the *skip* part.
> !Screen Shot 2021-11-27 at 12.58.59 PM.png!
> From above figure, the 1st R is resolved at depth 3, and the 2nd R is
> resolved again because the depth is at 2 which is lower, the 3rd R at depth 3
> and the 4th R at depth 4 are simply skipped as R is already resolved at depth
> 2. This is because the same node with deeper depth is most likely won't be
> picked up by maven as maven employs a "{*}nearest{*} transitive dependency in
> the tree depth and the *first* in resolution" strategy.
> The 3rd R and 4th R will have children set as zero and marked as skipped by
> the R at depth 2 in 2nd tree path.
>
> Here is the *reconcile* part:
> !Screen Shot 2021-11-27 at 12.59.32 PM.png!
> When there are dependency conflicts, some of the skipped nodes need to be
> reconciled.
> In above figure, there are 4 tree paths.
> * The D1 (D with version 1) in the 1st tree path is get resolved, children
> of E and R at depth 3 are resolved and cached.
> * In the 2nd tree path, when resolving E & R of H, we simply skip these 2
> nodes as they are in deeper depth (depth: 4) than the E & R in 1st tree path.
> * In the 3rd tree path, a R node with lower path is resolved, and a E node
> at depth 5 is skipped.
> * In the 4th path, a D2 (D with version 2) node is resolved, as the depth is
> lower than D1, so maven will pick D2, this means the E & R's children cached
> in tree depth 1 should be {*}discarded{*}.
> Thus we might need to reconcile the E & R nodes in 2nd, 3rd and 4th tree
> paths. Here only E in 2nd tree path needs to be reconciled. This is because:
> * R in 3rd tree path won't be picked up as there is already a R in 2nd tree
> path with a lower depth.
> * E in 3rd tree path won't be picked up as it is enough to reconcile the E
> in 2nd tree path as the E in 2nd tree path is deeper than E in 3rd tree path.
> Here is what we've updated in the maven-resolver logic:
> # Resolve dependencies by leveraging a skip approach. The node in deeper
> depth will be skipped if a node with same GAV has been resolved with a lower
> depth.
> # Cloned the nodes in step 1.
> Use maven's ConflictResolver (Transformer) to transform the cloned nodes and
> find out the conflict winners & the nodes to reconcile.
> Ex, D1 conflicts with D2 in above digram.
> E in 2nd tree path will be reconciled.
> # Reconcile all skipped nod
[jira] [Updated] (MRESOLVER-247) Avoid unnecessary dependency resolution by a Skip solution based on BFS
[
https://issues.apache.org/jira/browse/MRESOLVER-247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-247:
-
Fix Version/s: 1.8.0
> Avoid unnecessary dependency resolution by a Skip solution based on BFS
> ---
>
> Key: MRESOLVER-247
> URL: https://issues.apache.org/jira/browse/MRESOLVER-247
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
>Affects Versions: 1.7.3
>Reporter: wei cai
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.8.0
>
> Attachments: exclusion-matters.png, skip-duplicate.png,
> skip-version-conflicts.png
>
>
> h1. *Background*
> This Jira is related with MRESOLVER-240 and MRESOLVER-228
> There were discussions about the DFS or BFS algorithm for maven resolver in
> MRESOLVER-228, Changing to BFS would make MRESOLVER-228 & MRESOLVER-7 much
> easier to implement. Here is the plan for multiple changes requested recently:
> * DFS > BFS - preparation for parallel download
> * Skip approach - avoid unnecessary version resolution （Covered in this JIRA）
> * Download descriptors in parallel (MRESOLVER-7)
> h1. *The phenomenon*
> When comes to resolve the huge amount of dependencies of an enterprise level
> project, the maven resolver is very slow to resolve the dependency
> graph/tree. Take one of our app as example, it could take *10minutes+ and 16G
> memory* to print out the result of {*}mvn dependency:tree{*}.
> This is because there are many dependencies declared in the project, and some
> of the dependencies would introduce *600+* transitive dependencies, and
> exclusions are widely used to solve dependency conflicts.
> By checking the
> [code|https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L500],
> we know the exclusion is also part of the cache key. This means when the
> exclusions up the tree differs, the cached resolution result for the same GAV
> won't be picked up and need s to be recalculated.
>
> !exclusion-matters.png!
>
> From above figure, we know:
> * In 1st case, D will be resolved only once as there are no exclusions/same
> exclusions up the tree.
> * In 2nd case, the B and C have different exclusions and D needs to be
> recalculated, if D is a heavy dependency which introduce many transitive
> dependencies, all D and its children (D & E in this case) need to be
> recalculated. Recalculating all of these nodes introduces 2 issues:
> ** Slow in resolving dependencies.
> ** Lots of DependencyNodes cached (all calculated/recalculated nodes would
> be cached) and will consume huge memory.
> h1. Solution
> To improve the speed of maven resolver's dependency resolution, I
> implemented a skip approach to avoid unnecessary dependency resolution.
> h2. *CASE 1: Skip duplicate node (omitted duplicate case in dependency tree)*
> !skip-duplicate.png!
> From above figure:
> * The R#3 is resolved at depth 2, in the BFS solution, we already know R#3
> is the winner.
> * The R#5 won't be the winner, however here we force resolved this node as
> it is more left than the last resolved R#3 node. This is because maven picks
> up widest scope present among conflicting dependencies (scopes of the
> conflicts may differ), we need to *retain the conflict paths* by using a
> strategy like:
> ** R#3 locates in coordinate (2 - depth, 2 - sequence in given depth) while
> R#5 locates in (3,1), R#5 is more left than R#3, so we need to force resolve
> R#5.
> ** If there is a R#6 which is more left than R#5, then need to force resolve
> R#6.
> * The R#8 is at depth 3 and the R#12 at depth 4 are simply skipped as R#3 is
> already resolved at depth 2. This is because the same node with deeper depth
> won't be picked up by maven as maven employs a "nearest transitive dependency
> in the tree depth and the first in resolution" strategy.
> h2. *CASE 2: Skip version conflict (omitted conflict case in dependency tree)*
> *!skip-version-conflicts.png!*
> In above figure.
> * The D1 (D with version 1, #4) is resolved, in the BFS solution, we already
> know D1 is the winner
> * When comes to resolve D2 (D with version 2, after #4), we know D2 is
> having a different version and it conflicts with D1, D2 will be skipped as it
> won't be picked up by maven, all D2's children *won't be resolved* then.
> After we enabled the resolver patch in maven, we are seeing 10% ~70% build
> time reduced for different projects depend on how complex the dependencies
> are, and the result of *mvn dependency:tree* and *mvn dependency:list* remain
> the same.
> We've verified the resolver performance patch leveraging an automation
> solution to certif
[GitHub] [maven-surefire] imonteroperez commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile
imonteroperez commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1061525312 > @imonteroperez Thank You for your reply, I am very glad. I want to cut two release versions 3.0.0-M5 and 2.22.3, including your feature request to make the users happy. > > There was 6 days between two messages [#460 (comment)](https://github.com/apache/maven-surefire/pull/460#issuecomment-1047736732) and [#460 (comment)](https://github.com/apache/maven-surefire/pull/460#issuecomment-1053984089) and with the like +1 so it was a signal for me that we can shift the changes to the target module immediately. > > @imonteroperez Thank you for contributing. Glad to see you! Now this new feature has been merged, I want to drop here my last comment and thoughts about what happened here: - First of all, thank you all for your support and help in making this happen. The final main goal here is to deliver a new feature to users to make it feasible to perform method filtering on excludesFile and includesFile which is great. - Although main goal was reached, FMPOV as newbie contributor in the plugin I would say I'm still shocked by how things went in terms of keeping author credit, and for sure, this is totally outside what my brain model says about contributing to OSS projects is about. In addition, it makes me more sad to see that comments like [this](https://github.com/apache/maven-surefire/pull/440#issuecomment-1059594016) are totally ignored. I did not expect this behaviour here TBH. Given said that, please fix this internal situation as soon as possible. This is a bad symptom for Apache community health and contribution culture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o commented on a change in pull request #158:
URL: https://github.com/apache/maven-resolver/pull/158#discussion_r821418647
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyResolveSkipper.java
##
@@ -0,0 +1,260 @@
+package org.eclipse.aether.internal.impl.collect;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.util.artifact.ArtifactIdUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+final class DependencyResolveSkipper
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
DependencyResolveSkipper.class );
+
+private Map resolveResults = new
LinkedHashMap<>( 256 );
+private CacheManager cacheManager = new CacheManager();
+private CoordinateManager coordinateManager = new CoordinateManager();
+
+DependencyResolveSkipper()
+{
+// enables default constructor
+}
+
+Map report()
+{
+LOGGER.trace( "Skipped {} nodes as having deeper depth.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().skippedAsDeeper ).count() );
+LOGGER.trace( "Skipped {} nodes as having version conflict.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().skippedAsVersionConflict ).count() );
+LOGGER.trace( "Resolved {} nodes.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().resolve ).count() );
+LOGGER.trace( "Force resolved {} nodes for scope selection.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().forceResolve ).count() );
+
+return resolveResults;
+}
Review comment:
Should this rather be `getResults()`?
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -277,6 +278,7 @@ public CollectResult collectDependencies(
RepositorySystemSession session, Colle
false );
}
+args.skipper.report();
Review comment:
Isn't it code smell? I mean you abuse this method to log, but never
evaluate the output
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyResolveSkipper.java
##
@@ -0,0 +1,260 @@
+package org.eclipse.aether.internal.impl.collect;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.util.artifact.ArtifactIdUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+final class DependencyResolveSkipper
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
DependencyResolveSkipper.class );
+
+private Map resolveResults = new
LinkedHashMap<>( 256 );
+private CacheManager cacheManager = new CacheManager();
+private CoordinateManager coordinateManager = new CoordinateManager();
+
+
[jira] [Commented] (SUREFIRE-2033) Regression: 3.0.0-M5 misidentifies JUnit 5 configuration as JUnit 4
[
https://issues.apache.org/jira/browse/SUREFIRE-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502813#comment-17502813
]
Robert James Oxspring commented on SUREFIRE-2033:
-
... and that blows up with a {{NullPointerException}} at the moment. I have a
fix for that though, will open a PR shortly.
We have a product that works with JUnit tests and needs to run them. Our
customers use a variety of JUnit 4-5 versions and so we use
junit-platform-runner to run them. But the tests _of_ our product primarily use
JUnit 5. We want to upgrade to Surefire 3.0.0-M5 to take advantage of
SUREFIRE-1797 but are currently blocked because Surefire is chosing the wrong
runner.
> Regression: 3.0.0-M5 misidentifies JUnit 5 configuration as JUnit 4
> ---
>
> Key: SUREFIRE-2033
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2033
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M5
>Reporter: Robert James Oxspring
>Priority: Major
> Attachments: example.zip
>
>
> 3.0.0-M5 misidentifies a clearly JUnit 5 configuration and attempts to run
> using JUnit 4.
> In particular the attached project only has JUnit 5 dependencies:
> {code:java}
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.6.2
> test
>
>
> org.junit.platform
> junit-platform-runner
> 1.6.2
> test
>
> {code}
> and a JUnit 5 test:
> {code:java}
> package pkg;
> import org.junit.jupiter.api.Test;
> class JUnit5Test {
> @Test
> public void test() {
> }
> }{code}
> When the project is run with with older version (as far back as 2.22.0) the
> test is found and run, but 3.0.0-M5 fails to run any test:
> {code:java}
> % mvn test -Dsurefire.version=2.22.0 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.337 s
> [INFO] Finished at: 2022-03-03T09:42:27Z
> [INFO]
>
> {code}
>
> {code:java}
> % mvn test -Dsurefire.version=3.0.0-M1 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.708 s
> [INFO] Finished at: 2022-03-03T09:34:58Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M2 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.701 s
> [INFO] Finished at: 2022-03-03T09:36:26Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M3 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.612 s
> [INFO] Finished at: 2022-03-03T09:37:02Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M4 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.619 s
> [INFO] Finished at: 2022-03-03T09:37:37Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M5 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.344 s
> [INFO] Finished at: 2022-03-03T09:38:01Z
> [INFO]
> ---
[GitHub] [maven-resolver] caiwei-ebay commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
caiwei-ebay commented on a change in pull request #158:
URL: https://github.com/apache/maven-resolver/pull/158#discussion_r821487414
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyResolveSkipper.java
##
@@ -0,0 +1,260 @@
+package org.eclipse.aether.internal.impl.collect;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.util.artifact.ArtifactIdUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+final class DependencyResolveSkipper
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
DependencyResolveSkipper.class );
+
+private Map resolveResults = new
LinkedHashMap<>( 256 );
+private CacheManager cacheManager = new CacheManager();
+private CoordinateManager coordinateManager = new CoordinateManager();
+
+DependencyResolveSkipper()
+{
+// enables default constructor
+}
+
+Map report()
+{
+LOGGER.trace( "Skipped {} nodes as having deeper depth.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().skippedAsDeeper ).count() );
+LOGGER.trace( "Skipped {} nodes as having version conflict.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().skippedAsVersionConflict ).count() );
+LOGGER.trace( "Resolved {} nodes.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().resolve ).count() );
+LOGGER.trace( "Force resolved {} nodes for scope selection.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().forceResolve ).count() );
+
+return resolveResults;
+}
Review comment:
split into report() and getResults(). Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] caiwei-ebay commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
caiwei-ebay commented on a change in pull request #158:
URL: https://github.com/apache/maven-resolver/pull/158#discussion_r821488802
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DependencyResolveSkipper.java
##
@@ -0,0 +1,260 @@
+package org.eclipse.aether.internal.impl.collect;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.graph.DependencyNode;
+import org.eclipse.aether.util.artifact.ArtifactIdUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.HashMap;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+final class DependencyResolveSkipper
+{
+private static final Logger LOGGER = LoggerFactory.getLogger(
DependencyResolveSkipper.class );
+
+private Map resolveResults = new
LinkedHashMap<>( 256 );
+private CacheManager cacheManager = new CacheManager();
+private CoordinateManager coordinateManager = new CoordinateManager();
+
+DependencyResolveSkipper()
+{
+// enables default constructor
+}
+
+Map report()
+{
+LOGGER.trace( "Skipped {} nodes as having deeper depth.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().skippedAsDeeper ).count() );
+LOGGER.trace( "Skipped {} nodes as having version conflict.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().skippedAsVersionConflict ).count() );
+LOGGER.trace( "Resolved {} nodes.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().resolve ).count() );
+LOGGER.trace( "Force resolved {} nodes for scope selection.",
+resolveResults.entrySet().stream().filter( n ->
n.getValue().forceResolve ).count() );
+
+return resolveResults;
+}
+
+
+boolean skipResolve( DependencyNode node, List parents )
+{
+DependencyResolveResult resolveResult = new DependencyResolveResult(
node );
+resolveResults.put( node, resolveResult );
+
+int depth = parents.size() + 1;
+coordinateManager.createCoordinate( node, depth );
+
+if ( cacheManager.isVersionConflict( node ) )
+{
+//skip resolving version conflict losers (omitted conflict)
+resolveResult.skippedAsVersionConflict = true;
+LOGGER.trace( "Skipped resolving node: {} as version conflict",
+ArtifactIdUtils.toId( node.getArtifact() ) );
+}
+else if ( coordinateManager.isLeftmost( node, parents ) )
+{
+/*
+ * Force resolving the node to retain conflict paths when its
coordinate is more left than last resolved.
+ * This is because maven picks the widest scope present among
conflicting dependencies.
+ */
+resolveResult.forceResolve = true;
+LOGGER.trace( "Force resolving node: {} for scope selection",
+ArtifactIdUtils.toId( node.getArtifact() ) );
+}
+else if ( cacheManager.getWinnerDepth( node ) <= depth )
+{
+//skip resolve if depth deeper (omitted duplicate)
+resolveResult.skippedAsDeeper = true;
+LOGGER.trace( "Skipped resolving node: {} as the node's depth is
deeper than winner",
+ArtifactIdUtils.toId( node.getArtifact() ) );
+}
+else
+{
+resolveResult.resolve = true;
+LOGGER.trace( "Resolving node: {}",
+ArtifactIdUtils.toId( node.getArtifact() ) );
+}
+
+if ( resolveResult.toResolve() )
+{
+coordinateManager.updateLeftmost( node );
+return false;
+}
+
+return true;
+}
+
+void cacheWithDepth( DependencyNode node, List parents )
+{
+boolean parentForceResolve = parents.stream()
+.anyMatch( n -> resolveResults.containsKey( n ) &&
resolveResults.get( n ).forceResolve );
+if ( parentForceResolve )
+{
+LOGGER.trace(
+
[GitHub] [maven-resolver] michael-o commented on a change in pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
michael-o commented on a change in pull request #158:
URL: https://github.com/apache/maven-resolver/pull/158#discussion_r821489218
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##
@@ -500,15 +505,19 @@ private void doRecurse( Args args,
DependencyProcessingContext parentContext,
List children = args.pool.getChildren( key );
if ( children == null )
{
-args.pool.putChildren( key, child.getChildren() );
-
List parents = new ArrayList<>(
parentContext.parents );
-parents.add( child );
-for ( Dependency dependency : descriptorResult.getDependencies() )
+boolean skipResolve = args.skipper.skipResolution( child, parents
);
Review comment:
Leftover: `skipResolution`
##
File path:
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollectorTest.java
##
@@ -101,6 +102,12 @@ private Dependency newDep( String coords, String scope )
return new Dependency( new DefaultArtifact( coords ), scope );
}
+private Dependency newDep( String coords, String scope,
Collection exclusions )
+{
+Dependency d = new Dependency( new DefaultArtifact( coords ), scope );
+return d.setExclusions(exclusions);
+}
+
Review comment:
Please reformat
##
File path:
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollectorTest.java
##
@@ -222,6 +229,26 @@ public void testMissingDependencyDescription()
}
}
+@Test
+public void testExclusion1()
+throws DependencyCollectionException {
+collector.setArtifactDescriptorReader(newReader("managed/"));
+parser = new DependencyGraphParser("artifact-descriptions/managed/");
+session.setDependencyManager(new TransitiveDependencyManager());
+
+ExclusionDependencySelector exclSel1 = new
ExclusionDependencySelector();
+session.setDependencySelector(exclSel1);
+
+Dependency root1 = newDep("gid:root:ext:ver", "compile",
Collections.singleton(new Exclusion("gid", "transitive-1", "", "ext")));
+Dependency root2 = newDep("gid:root:ext:ver", "compile",
Collections.singleton(new Exclusion("gid", "transitive-2", "", "ext")));
+List dependencies = Arrays.asList(root1, root2);
+CollectRequest request = new CollectRequest(dependencies, null,
Arrays.asList(repository));
+
request.addManagedDependency(newDep("gid:direct:ext:managed-by-dominant-request"));
+request.addManagedDependency( newDep(
"gid:transitive-1:ext:managed-by-root" ) );
+CollectResult result = collector.collectDependencies(session, request);
+System.err.println(result);
+}
Review comment:
Please reformat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] caiwei-ebay commented on pull request #158: MRESOLVER-247: Introduce skipper to avoid unnecessary dependency reso…
caiwei-ebay commented on pull request #158: URL: https://github.com/apache/maven-resolver/pull/158#issuecomment-1061589984 @ibabiankou Please also help check the PR to see if it is good for you to apply your changes in MRESOLVER-7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a change in pull request #157: [MRESOLVER-245] Isolate and update tests
cstamas commented on a change in pull request #157:
URL: https://github.com/apache/maven-resolver/pull/157#discussion_r821514970
##
File path:
maven-resolver-named-locks-hazelcast/src/main/java/org/eclipse/aether/named/hazelcast/HazelcastSemaphoreProvider.java
##
@@ -0,0 +1,44 @@
+package org.eclipse.aether.named.hazelcast;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.hazelcast.core.HazelcastInstance;
+import com.hazelcast.cp.ISemaphore;
+
+/**
+ * Support class for providers of {@link ISemaphore} instances.
+ */
+public abstract class HazelcastSemaphoreProvider
+{
+/**
+ * Name prefix recommended using for simpler configuration of Hazelcast.
+ */
+protected static final String NAME_PREFIX = "mvn:resolver:";
Review comment:
Why does prefix matter? IMHO, even this above `mvn:resolver:...` is just
redundant bytes per each semaphore created. Also, naming the HZ semaphore has
no effect on anything else, nor is expected for people to "browse" HZ cluster
for semaphores... so unsure why does an implementation detail (how a HZ backed
named lock module names HZ semaphore) matters at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] rfscholte commented on pull request #689: [NOT FOR MERGE] Example of Maven BOMs
rfscholte commented on pull request #689: URL: https://github.com/apache/maven/pull/689#issuecomment-1061640064 To me a BOM represents only the set of modules of a multimodule, that contain the versions that work together. This should prevent issues with dependency depth/distance which could pull in an unexpected version. Ideally all multimodules also provide a BOM. Other dependencies don't belong here, as they should be upgradable/downgradable independent of the BOM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] roxspring opened a new pull request #485: [SUREFIRE-2033] Fix JUnit 5 with configured provider
roxspring opened a new pull request #485: URL: https://github.com/apache/maven-surefire/pull/485 Modified getJUnit5Artifact() to care _only_ about JUnit 5 artifacts Added getJUnitPlatformRunnerArtifact() to care about the JUnit Platform Runner artifact JUnitPlatformProviderInfo is enabled by default based on a combination of above Avoids NullPointerException when explicitly configured provider needs to know the available JUnit5 artifact Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2033) Regression: 3.0.0-M5 misidentifies JUnit 5 configuration as JUnit 4
[
https://issues.apache.org/jira/browse/SUREFIRE-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502855#comment-17502855
]
Robert James Oxspring commented on SUREFIRE-2033:
-
Fix for the NullPointerException:
https://github.com/apache/maven-surefire/pull/485
> Regression: 3.0.0-M5 misidentifies JUnit 5 configuration as JUnit 4
> ---
>
> Key: SUREFIRE-2033
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2033
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M5
>Reporter: Robert James Oxspring
>Priority: Major
> Attachments: example.zip
>
>
> 3.0.0-M5 misidentifies a clearly JUnit 5 configuration and attempts to run
> using JUnit 4.
> In particular the attached project only has JUnit 5 dependencies:
> {code:java}
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.6.2
> test
>
>
> org.junit.platform
> junit-platform-runner
> 1.6.2
> test
>
> {code}
> and a JUnit 5 test:
> {code:java}
> package pkg;
> import org.junit.jupiter.api.Test;
> class JUnit5Test {
> @Test
> public void test() {
> }
> }{code}
> When the project is run with with older version (as far back as 2.22.0) the
> test is found and run, but 3.0.0-M5 fails to run any test:
> {code:java}
> % mvn test -Dsurefire.version=2.22.0 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.337 s
> [INFO] Finished at: 2022-03-03T09:42:27Z
> [INFO]
>
> {code}
>
> {code:java}
> % mvn test -Dsurefire.version=3.0.0-M1 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.708 s
> [INFO] Finished at: 2022-03-03T09:34:58Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M2 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.701 s
> [INFO] Finished at: 2022-03-03T09:36:26Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M3 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.612 s
> [INFO] Finished at: 2022-03-03T09:37:02Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M4 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.619 s
> [INFO] Finished at: 2022-03-03T09:37:37Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M5 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.344 s
> [INFO] Finished at: 2022-03-03T09:38:01Z
> [INFO]
> {code}
> Note the final run above using 3.0.0-M5 and logging: {{Tests run: 0}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2033) Regression: 3.0.0-M5 misidentifies JUnit 5 configuration as JUnit 4
[
https://issues.apache.org/jira/browse/SUREFIRE-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502867#comment-17502867
]
Slawomir Jaranowski commented on SUREFIRE-2033:
---
[~roxspring] - thanks for PR
For next release note to be clean and show what we delivered I propose to
create new issue for resolving NPE when junit platform is manually selected
with platform-runner on dependency.
Or simple change title of current issue to show what we do :-)
> Regression: 3.0.0-M5 misidentifies JUnit 5 configuration as JUnit 4
> ---
>
> Key: SUREFIRE-2033
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2033
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.0.0-M5
>Reporter: Robert James Oxspring
>Priority: Major
> Attachments: example.zip
>
>
> 3.0.0-M5 misidentifies a clearly JUnit 5 configuration and attempts to run
> using JUnit 4.
> In particular the attached project only has JUnit 5 dependencies:
> {code:java}
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.6.2
> test
>
>
> org.junit.platform
> junit-platform-runner
> 1.6.2
> test
>
> {code}
> and a JUnit 5 test:
> {code:java}
> package pkg;
> import org.junit.jupiter.api.Test;
> class JUnit5Test {
> @Test
> public void test() {
> }
> }{code}
> When the project is run with with older version (as far back as 2.22.0) the
> test is found and run, but 3.0.0-M5 fails to run any test:
> {code:java}
> % mvn test -Dsurefire.version=2.22.0 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.337 s
> [INFO] Finished at: 2022-03-03T09:42:27Z
> [INFO]
>
> {code}
>
> {code:java}
> % mvn test -Dsurefire.version=3.0.0-M1 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.708 s
> [INFO] Finished at: 2022-03-03T09:34:58Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M2 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.701 s
> [INFO] Finished at: 2022-03-03T09:36:26Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M3 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.612 s
> [INFO] Finished at: 2022-03-03T09:37:02Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M4 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.619 s
> [INFO] Finished at: 2022-03-03T09:37:37Z
> [INFO]
>
> % mvn test -Dsurefire.version=3.0.0-M5 | tail
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1.344 s
> [INFO] Finished at: 2022-03-03T09:38:01Z
> [INFO]
> {code}
> Note the final run above using 3.0.0-M5 and logging: {{Tests run: 0}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-pmd-plugin] dependabot[bot] opened a new pull request #58: Bump release-drafter/release-drafter from 5.18.1 to 5.19.0
dependabot[bot] opened a new pull request #58: URL: https://github.com/apache/maven-pmd-plugin/pull/58 Bumps [release-drafter/release-drafter](https://github.com/release-drafter/release-drafter) from 5.18.1 to 5.19.0. Release notes Sourced from https://github.com/release-drafter/release-drafter/releases";>release-drafter/release-drafter's releases. v5.19.0 What's Changed New Add a collapse-after option for categories (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1095";>#1095) https://github.com/robbinjanssen";>@robbinjanssen Tag prefix (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1092";>#1092) https://github.com/blast-hardcheese";>@blast-hardcheese include-paths: Permit filtering only PRs that modify path prefixes (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1084";>#1084) https://github.com/blast-hardcheese";>@blast-hardcheese Unify commit search and release targeting around commitish/ref (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1065";>#1065) https://github.com/mikeroll";>@mikeroll Bug Fixes Regenerate schema after https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1084";>#1084 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1094";>#1094) https://github.com/blast-hardcheese";>@blast-hardcheese Filter by commitish regardless of the refs/heads prefix (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1089";>#1089) https://github.com/mikeroll";>@mikeroll Cap evaluated release limit at 1000 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1085";>#1085) https://github.com/eddmann";>@eddmann Provide sane defaults if we have no prior releases (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1067";>#1067) https://github.com/jetersen";>@jetersen Maintenance Sync docker/action.yml with action.yml (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1062";>#1062) https://github.com/mkurz";>@mkurz Documentation Improve contribution docs and remove unused package script (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1066";>#1066) https://github.com/masashi-sutou";>@masashi-sutou Dependency Updates Bump lint-staged from 12.3.4 to 12.3.5 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1096";>#1096) https://github.com/dependabot";>@dependabot Bump eslint from 8.9.0 to 8.10.0 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1086";>#1086) https://github.com/dependabot";>@dependabot Bump actions/setup-node from 2 to 3 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1087";>#1087) https://github.com/dependabot";>@dependabot Bump node from 17.5.0-alpine to 17.6.0-alpine (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1080";>#1080) https://github.com/dependabot";>@dependabot Bump actions/checkout from 2 to 3 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1090";>#1090) https://github.com/dependabot";>@dependabot Bump eslint-config-prettier from 8.3.0 to 8.5.0 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1091";>#1091) https://github.com/dependabot";>@dependabot Bump url-parse from 1.5.7 to 1.5.10 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1088";>#1088) https://github.com/dependabot";>@dependabot Bump eslint-plugin-unicorn from 40.1.0 to 41.0.0 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1074";>#1074) https://github.com/dependabot";>@dependabot Bump url-parse from 1.5.4 to 1.5.7 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1075";>#1075) https://github.com/dependabot";>@dependabot Bump eslint from 8.8.0 to 8.9.0 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1071";>#1071) https://github.com/dependabot";>@dependabot Bump lint-staged from 12.3.3 to 12.3.4 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1070";>#1070) https://github.com/dependabot";>@dependabot Bump @vercel/ncc from 0.33.1 to 0.33.3 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1069";>#1069) https://github.com/dependabot";>@dependabot Bump node from 17.4.0-alpine to 17.5.0-alpine (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1072";>#1072) https://github.com/dependabot";>@dependabot Bump jest from 27.5.0 to 27.5.1 (https://github-redirect.dependabot.com/release-drafter/release-drafter/issues/1063";>#1063) https://gi
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #485: [SUREFIRE-2033] Fix JUnit 5 with configured provider
slawekjaranowski commented on pull request #485: URL: https://github.com/apache/maven-surefire/pull/485#issuecomment-1061691307 Please rebase your branch with current master codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski merged pull request #10: fix Jenkins link
slawekjaranowski merged pull request #10: URL: https://github.com/apache/maven-verifier/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-298) Upgrade Maven Reporting to 3.1.0
[ https://issues.apache.org/jira/browse/MINVOKER-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502925#comment-17502925 ] Hudson commented on MINVOKER-298: - Build succeeded in Jenkins: Maven » Maven TLP » maven-invoker-plugin » PR-107 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker-plugin/job/PR-107/2/ > Upgrade Maven Reporting to 3.1.0 > > > Key: MINVOKER-298 > URL: https://issues.apache.org/jira/browse/MINVOKER-298 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MINVOKER-297) NPE when non-existing Maven Home is provided in configuration
[
https://issues.apache.org/jira/browse/MINVOKER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502924#comment-17502924
]
Hudson commented on MINVOKER-297:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-invoker-plugin » PR-107 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker-plugin/job/PR-107/2/
> NPE when non-existing Maven Home is provided in configuration
> -
>
> Key: MINVOKER-297
> URL: https://issues.apache.org/jira/browse/MINVOKER-297
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> when non existing Maven Home is provided in configuration we have:
> {code}
> ...
> Caused by: java.lang.NullPointerException
> at org.apache.maven.plugins.invoker.SelectorUtils.getMavenVersion
> (SelectorUtils.java:132)
> at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuilds
> (AbstractInvokerMojo.java:1302)
> at org.apache.maven.plugins.invoker.AbstractInvokerMojo.execute
> (AbstractInvokerMojo.java:829)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MINVOKER-297) NPE when non-existing Maven Home is provided in configuration
[
https://issues.apache.org/jira/browse/MINVOKER-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502931#comment-17502931
]
Hudson commented on MINVOKER-297:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-invoker-plugin » PR-106 #2
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker-plugin/job/PR-106/2/
> NPE when non-existing Maven Home is provided in configuration
> -
>
> Key: MINVOKER-297
> URL: https://issues.apache.org/jira/browse/MINVOKER-297
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Affects Versions: 3.2.2
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>
> when non existing Maven Home is provided in configuration we have:
> {code}
> ...
> Caused by: java.lang.NullPointerException
> at org.apache.maven.plugins.invoker.SelectorUtils.getMavenVersion
> (SelectorUtils.java:132)
> at org.apache.maven.plugins.invoker.AbstractInvokerMojo.runBuilds
> (AbstractInvokerMojo.java:1302)
> at org.apache.maven.plugins.invoker.AbstractInvokerMojo.execute
> (AbstractInvokerMojo.java:829)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MINVOKER-298) Upgrade Maven Reporting to 3.1.0
[ https://issues.apache.org/jira/browse/MINVOKER-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502932#comment-17502932 ] Hudson commented on MINVOKER-298: - Build succeeded in Jenkins: Maven » Maven TLP » maven-invoker-plugin » PR-106 #2 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker-plugin/job/PR-106/2/ > Upgrade Maven Reporting to 3.1.0 > > > Key: MINVOKER-298 > URL: https://issues.apache.org/jira/browse/MINVOKER-298 > Project: Maven Invoker Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-verifier] elharo commented on a change in pull request #9: [MSHARED-1043] Deprecate methods leveraging JUnit4 assertions
elharo commented on a change in pull request #9:
URL: https://github.com/apache/maven-verifier/pull/9#discussion_r821702522
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -1007,11 +1007,22 @@ public Properties newDefaultFilterProperties()
return filterProperties;
}
+public void verifyFilePresent( String file ) throws VerificationException
+{
+verifyFilePresence( file, true );
+}
+
+/**
+ *
+ * @param file
Review comment:
document or remove the comment
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -1025,30 +1036,63 @@ public void assertFilePresent( String file )
*
* @param file the file to check.
* @param regex a regular expression.
+ * @throws VerificationException
* @see Pattern
*/
-public void assertFileMatches( String file, String regex )
+public void verifyFileContentMatches( String file, String regex ) throws
VerificationException
{
-assertFilePresent( file );
+verifyFilePresent( file );
try
{
String content = FileUtils.fileRead( file );
if ( !Pattern.matches( regex, content ) )
{
-Assert.fail( "Content of " + file + " does not match " + regex
);
+throw new VerificationException( "Content of " + file + " does
not match " + regex );
}
}
catch ( IOException e )
+{
+throw new VerificationException( "Could not read from " + file +
":" + e.getMessage(), e );
+}
+}
+
+/**
+ * Check that given file's content matches an regular expression. Note
this method also checks that the file exists
+ * and is readable.
+ *
+ * @param file the file to check.
Review comment:
nit: no period at end of doc comments that are not complete sentecnes
per Oracle guidelines
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -1025,30 +1036,63 @@ public void assertFilePresent( String file )
*
* @param file the file to check.
* @param regex a regular expression.
+ * @throws VerificationException
* @see Pattern
*/
-public void assertFileMatches( String file, String regex )
+public void verifyFileContentMatches( String file, String regex ) throws
VerificationException
{
-assertFilePresent( file );
+verifyFilePresent( file );
try
{
String content = FileUtils.fileRead( file );
if ( !Pattern.matches( regex, content ) )
{
-Assert.fail( "Content of " + file + " does not match " + regex
);
+throw new VerificationException( "Content of " + file + " does
not match " + regex );
}
}
catch ( IOException e )
+{
+throw new VerificationException( "Could not read from " + file +
":" + e.getMessage(), e );
+}
+}
+
+/**
+ * Check that given file's content matches an regular expression. Note
this method also checks that the file exists
+ * and is readable.
+ *
+ * @param file the file to check.
+ * @param regex a regular expression.
+ * @see Pattern
+ * @deprecated Use {@link #verifyFileContentMatches(String, String)}
instead.
+ */
+@Deprecated
+public void assertFileMatches( String file, String regex )
+{
+try
+{
+verifyFileContentMatches( file, regex );
+}
+catch ( VerificationException e )
{
Assert.fail( e.getMessage() );
}
}
+public void verifyFileNotPresent( String file ) throws
VerificationException
+{
+verifyFilePresence( file, false );
+}
+
+/**
+ *
+ * @param file
Review comment:
document or remove the comment
##
File path: src/main/java/org/apache/maven/it/Verifier.java
##
@@ -1057,31 +1101,67 @@ public void assertFileNotPresent( String file )
}
private void verifyArtifactPresence( boolean wanted, String org, String
name, String version, String ext )
+throws VerificationException
{
List files = getArtifactFileNameList( org, name, version, ext
);
for ( String fileName : files )
{
-try
-{
-verifyExpectedResult( fileName, wanted );
-}
-catch ( VerificationException e )
-{
-Assert.fail( e.getMessage() );
-}
+verifyFilePresence( fileName, wanted );
}
}
-public void assertArtifactPresent( String org, String name, String
version, String ext )
+public void verifyArtifactPresent( String org, String name, String
version, String ext )
+throws VerificationException
{
verifyArtifactPresence( true,
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #485: [SUREFIRE-2033] Fix JUnit 5 with configured provider
slawekjaranowski commented on a change in pull request #485:
URL: https://github.com/apache/maven-surefire/pull/485#discussion_r821625665
##
File path:
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##
@@ -93,6 +93,18 @@ public void selectJUnit5()
"Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
}
+@Test
+public void selectJUnit5UsingConfiguredProvider()
+{
+unpack( "junit-4-5" )
Review comment:
We can put example project in separate directory, like surefire- :-)
without profile.
##
File path:
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##
@@ -93,6 +93,18 @@ public void selectJUnit5()
"Using auto detected provider
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
}
+@Test
+public void selectJUnit5UsingConfiguredProvider()
Review comment:
maybe `selectJUnit5UsingConfiguredProviderWithPlatformRunner`
We can also put this test in separate class with name corresponding to issue
number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-enforcer] dependabot[bot] commented on pull request #138: Bump mockito.version from 4.2.0 to 4.3.1
dependabot[bot] commented on pull request #138: URL: https://github.com/apache/maven-enforcer/pull/138#issuecomment-1061927814 Superseded by #142. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request #142: Bump mockito.version from 4.2.0 to 4.4.0
dependabot[bot] opened a new pull request #142: URL: https://github.com/apache/maven-enforcer/pull/142 Bumps `mockito.version` from 4.2.0 to 4.4.0. Updates `mockito-core` from 4.2.0 to 4.4.0 Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.4.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.4.0 2022-03-08 - https://github.com/mockito/mockito/compare/v4.3.1...v4.4.0";>16 commit(s) by Andrew Kozel, Brice Dutheil, Jean-Baptiste Mille, Mirko Alicastro, dependabot[bot] Bump groovy from 3.0.9 to 3.0.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2586";>#2586)](https://github-redirect.dependabot.com/mockito/mockito/pull/2586";>mockito/mockito#2586) Bump google-java-format from 1.14.0 to 1.15.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2585";>#2585)](https://github-redirect.dependabot.com/mockito/mockito/pull/2585";>mockito/mockito#2585) Bump actions/checkout from 2.4.0 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2582";>#2582)](https://github-redirect.dependabot.com/mockito/mockito/pull/2582";>mockito/mockito#2582) Bump shipkit-auto-version from 1.1.19 to 1.1.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2580";>#2580)](https://github-redirect.dependabot.com/mockito/mockito/pull/2580";>mockito/mockito#2580) Bump biz.aQute.bnd.builder from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2579";>#2579)](https://github-redirect.dependabot.com/mockito/mockito/pull/2579";>mockito/mockito#2579) Bump biz.aQute.bnd.gradle from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2578";>#2578)](https://github-redirect.dependabot.com/mockito/mockito/pull/2578";>mockito/mockito#2578) Adds a Google Java Format for JDK17 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2572";>#2572)](https://github-redirect.dependabot.com/mockito/mockito/pull/2572";>mockito/mockito#2572) Clean up JUnit3 references [(https://github-redirect.dependabot.com/mockito/mockito/issues/2570";>#2570)](https://github-redirect.dependabot.com/mockito/mockito/pull/2570";>mockito/mockito#2570) Bump com.diffplug.spotless from 6.2.2 to 6.3.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2567";>#2567)](https://github-redirect.dependabot.com/mockito/mockito/pull/2567";>mockito/mockito#2567) Bump google-java-format from 1.13.0 to 1.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2565";>#2565)](https://github-redirect.dependabot.com/mockito/mockito/pull/2565";>mockito/mockito#2565) Bump versions.bytebuddy from 1.12.7 to 1.12.8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2564";>#2564)](https://github-redirect.dependabot.com/mockito/mockito/pull/2564";>mockito/mockito#2564) Bump com.diffplug.spotless from 6.2.1 to 6.2.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2562";>#2562)](https://github-redirect.dependabot.com/mockito/mockito/pull/2562";>mockito/mockito#2562) Bump com.github.ben-manes.versions from 0.41.0 to 0.42.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2559";>#2559)](https://github-redirect.dependabot.com/mockito/mockito/pull/2559";>mockito/mockito#2559) Bump com.diffplug.spotless from 6.2.0 to 6.2.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2556";>#2556)](https://github-redirect.dependabot.com/mockito/mockito/pull/2556";>mockito/mockito#2556) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548 : Makes InOrder able to verify static methods [(https://github-redirect.dependabot.com/mockito/mockito/issues/2549";>#2549)](https://github-redirect.dependabot.com/mockito/mockito/pull/2549";>mockito/mockito#2549) [PR open] Add feature to verify static methods calls in order [(https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548)](https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>mockito/mockito#2548) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201 : Fixed checking of declared exceptions. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2547";>#2547)](https://github-redirect.dependabot.com/mockito/mockito/pull/2547";>mockito/mockito#2547) Calling getExceptionTypes() on concrete object that is used as interface doesn't return exception types from interface [(https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201)](https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>mockito/mockito#2201) v4.3.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.3.1 2022-01-25 - https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1";>1 commit(s) by Stefano Cordio Add mo
[GitHub] [maven-enforcer] dependabot[bot] closed pull request #138: Bump mockito.version from 4.2.0 to 4.3.1
dependabot[bot] closed pull request #138: URL: https://github.com/apache/maven-enforcer/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] DaGeRe commented on a change in pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
DaGeRe commented on a change in pull request #476:
URL: https://github.com/apache/maven-surefire/pull/476#discussion_r821839957
##
File path:
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire2010ParameterizedSelectionDoesNotWorkIT.java
##
@@ -0,0 +1,36 @@
+package org.apache.maven.surefire.its.jiras;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.surefire.its.fixture.OutputValidator;
+import org.apache.maven.surefire.its.fixture.SurefireJUnit4IntegrationTestCase;
+import org.junit.Test;
+
+public class Surefire2010ParameterizedSelectionDoesNotWorkIT extends
SurefireJUnit4IntegrationTestCase
+{
+ @Test
+ public void testJUnit4() {
+ OutputValidator validator =
unpack("surefire-2010-parameterized-selection-does-not-work").executeTest();
Review comment:
Yes, this was only for starting. The plan is to run it once with all
tests and than with a selector.
Now, I've added
```
TestFile surefireReportsFile = validator.getSurefireReportsFile(
"de.dagere.peass.ExampleTestJUnit4.txt" );
surefireReportsFile.assertContainsText( "Tests run: 2" );
```
which unfortunately fails.
##
File path:
surefire-its/src/test/resources/surefire-2010-parameterized-selection-does-not-work/pom.xml
##
@@ -0,0 +1,65 @@
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
Review comment:
Thanks, I've added the `forkMode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] DaGeRe commented on a change in pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
DaGeRe commented on a change in pull request #476: URL: https://github.com/apache/maven-surefire/pull/476#discussion_r821840505 ## File path: surefire-its/src/test/resources/surefire-2010-parameterized-selection-does-not-work/src/test/java/de/dagere/peass/ExampleTestJUnit4.java ## @@ -0,0 +1,36 @@ +package de.dagere.peass; + +import java.util.Arrays; +import java.util.Collection; + +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import org.junit.runners.Parameterized.Parameters; + +@RunWith(Parameterized.class) Review comment: Thank, I've imported the style and hopefully reformatted it correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] DaGeRe commented on pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
DaGeRe commented on pull request #476: URL: https://github.com/apache/maven-surefire/pull/476#issuecomment-1061966185 Thanks for the hints. I adapted the code, but have two questions: - Is there a guide how to debug this? I can start the test on command line and see it failing, but not in eclipse. This makes debugging much harder. - Is there any part of the maven launcher which allows to pass something like `-Dtest=MySelector`, or do I have to call it myself? Just adding it as goal ends in ``` [ERROR] Unknown lifecycle phase "test -Dtest=ExampleTestJUnit4". You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, g enerate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-cle an, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] DaGeRe edited a comment on pull request #476: [SUREFIRE-2010] Parameterized Selection Does not Work
DaGeRe edited a comment on pull request #476: URL: https://github.com/apache/maven-surefire/pull/476#issuecomment-1061966185 Thanks for the hints. I adapted the code, but is there any part of the maven launcher which allows to pass something like `-Dtest=MySelector`, or do I have to call it myself? Just adding it as goal ends in ``` [ERROR] Unknown lifecycle phase "test -Dtest=ExampleTestJUnit4". You must specify a valid lifecycle phase or a goal in the format : or :[:]:. Available lifecycle phases are: validate, initialize, generate-sources, process-sources, generate-resources, process-resources, compile, process-classes, generate-test-sources, process-test-sources, g enerate-test-resources, process-test-resources, test-compile, process-test-classes, test, prepare-package, package, pre-integration-test, integration-test, post-integration-test, verify, install, deploy, pre-cle an, clean, post-clean, pre-site, site, post-site, site-deploy. -> [Help 1] ``` I can debug this with `-Dmaven.surefire.debug=true`, but that does not help to create the process correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (WAGON-625) Upgrade To commons-io 2.7
Ryan Baxter created WAGON-625: - Summary: Upgrade To commons-io 2.7 Key: WAGON-625 URL: https://issues.apache.org/jira/browse/WAGON-625 Project: Maven Wagon Issue Type: Dependency upgrade Affects Versions: 3.5.1 Reporter: Ryan Baxter commons-io 2.6 is effected by CVE-2021-29425 which is addressed in 2.7 https://nvd.nist.gov/vuln/detail/CVE-2021-29425 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-resolver] michael-o commented on a change in pull request #157: [MRESOLVER-245] Isolate and update tests
michael-o commented on a change in pull request #157:
URL: https://github.com/apache/maven-resolver/pull/157#discussion_r821915174
##
File path:
maven-resolver-named-locks-hazelcast/src/main/java/org/eclipse/aether/named/hazelcast/HazelcastSemaphoreProvider.java
##
@@ -0,0 +1,44 @@
+package org.eclipse.aether.named.hazelcast;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.hazelcast.core.HazelcastInstance;
+import com.hazelcast.cp.ISemaphore;
+
+/**
+ * Support class for providers of {@link ISemaphore} instances.
+ */
+public abstract class HazelcastSemaphoreProvider
+{
+/**
+ * Name prefix recommended using for simpler configuration of Hazelcast.
+ */
+protected static final String NAME_PREFIX = "mvn:resolver:";
Review comment:
That true, simple consistency with the rest as with the previous impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (WAGON-625) Upgrade To commons-io 2.7
[ https://issues.apache.org/jira/browse/WAGON-625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503108#comment-17503108 ] Michael Osipov commented on WAGON-625: -- Not possible, Commons IO requires Java 8, Wagon 3.x will remain on Java 7. > Upgrade To commons-io 2.7 > - > > Key: WAGON-625 > URL: https://issues.apache.org/jira/browse/WAGON-625 > Project: Maven Wagon > Issue Type: Dependency upgrade >Affects Versions: 3.5.1 >Reporter: Ryan Baxter >Priority: Major > > commons-io 2.6 is effected by CVE-2021-29425 which is addressed in 2.7 > https://nvd.nist.gov/vuln/detail/CVE-2021-29425 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MSHARED-1015) Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory system property is not set"
[
https://issues.apache.org/jira/browse/MSHARED-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503120#comment-17503120
]
Slawomir Jaranowski commented on MSHARED-1015:
--
The same way was done in maven-integration-testing:
https://github.com/apache/maven-integration-testing/blob/master/core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java#L597
> Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory
> system property is not set"
>
>
> Key: MSHARED-1015
> URL: https://issues.apache.org/jira/browse/MSHARED-1015
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-verifier
>Affects Versions: maven-verifier-1.7.2
>Reporter: Konrad Windszus
>Priority: Major
>
> When trying to use an embedded launcher created from the classpath
> (https://github.com/apache/maven-verifier/blob/17ebffa2467caa59f1e47c302ac03d9e00d8c314/src/main/java/org/apache/maven/it/Embedded3xLauncher.java#L124),
> launching fails with
> {code}
> -Dmaven.multiModuleProjectDirectory system property is not set
> {code}
> A similar issue was once reported and fixed for m2e at
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=462944.
> The reason is
> https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L351
> which now requires this property to be set. This has been introduced by
> https://issues.apache.org/jira/browse/MNG-5767 in Maven 3.3.1
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-jar-plugin] focbenz opened a new pull request #34: Updated create-test-jar.apt.vm removing 'and' in Maven site Create Test JAR documentation
focbenz opened a new pull request #34: URL: https://github.com/apache/maven-jar-plugin/pull/34 Updates create-test-jar.apt.vm removing 'and' which was either missing something additional to the test-scoped dependencies or was left unintentionally. No JIRA issues linked because this is a trivial change similar to a typo making up for a better example description. Improves the description on the Maven site here: https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-verifier] slawekjaranowski merged pull request #6: [MSHARED-1015] correctly set system property
slawekjaranowski merged pull request #6: URL: https://github.com/apache/maven-verifier/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MSHARED-1015) Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory system property is not set"
[
https://issues.apache.org/jira/browse/MSHARED-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski reassigned MSHARED-1015:
Assignee: Slawomir Jaranowski
> Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory
> system property is not set"
>
>
> Key: MSHARED-1015
> URL: https://issues.apache.org/jira/browse/MSHARED-1015
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-verifier
>Affects Versions: maven-verifier-1.7.2
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
>
> When trying to use an embedded launcher created from the classpath
> (https://github.com/apache/maven-verifier/blob/17ebffa2467caa59f1e47c302ac03d9e00d8c314/src/main/java/org/apache/maven/it/Embedded3xLauncher.java#L124),
> launching fails with
> {code}
> -Dmaven.multiModuleProjectDirectory system property is not set
> {code}
> A similar issue was once reported and fixed for m2e at
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=462944.
> The reason is
> https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L351
> which now requires this property to be set. This has been introduced by
> https://issues.apache.org/jira/browse/MNG-5767 in Maven 3.3.1
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MSHARED-1015) Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory system property is not set"
[
https://issues.apache.org/jira/browse/MSHARED-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MSHARED-1015.
Fix Version/s: maven-verifier-2.0.0
Resolution: Fixed
> Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory
> system property is not set"
>
>
> Key: MSHARED-1015
> URL: https://issues.apache.org/jira/browse/MSHARED-1015
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-verifier
>Affects Versions: maven-verifier-1.7.2
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> When trying to use an embedded launcher created from the classpath
> (https://github.com/apache/maven-verifier/blob/17ebffa2467caa59f1e47c302ac03d9e00d8c314/src/main/java/org/apache/maven/it/Embedded3xLauncher.java#L124),
> launching fails with
> {code}
> -Dmaven.multiModuleProjectDirectory system property is not set
> {code}
> A similar issue was once reported and fixed for m2e at
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=462944.
> The reason is
> https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L351
> which now requires this property to be set. This has been introduced by
> https://issues.apache.org/jira/browse/MNG-5767 in Maven 3.3.1
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MSHARED-1015) Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory system property is not set"
[
https://issues.apache.org/jira/browse/MSHARED-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503126#comment-17503126
]
Hudson commented on MSHARED-1015:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-verifier » master #5
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-verifier/job/master/5/
> Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory
> system property is not set"
>
>
> Key: MSHARED-1015
> URL: https://issues.apache.org/jira/browse/MSHARED-1015
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-verifier
>Affects Versions: maven-verifier-1.7.2
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-2.0.0
>
>
> When trying to use an embedded launcher created from the classpath
> (https://github.com/apache/maven-verifier/blob/17ebffa2467caa59f1e47c302ac03d9e00d8c314/src/main/java/org/apache/maven/it/Embedded3xLauncher.java#L124),
> launching fails with
> {code}
> -Dmaven.multiModuleProjectDirectory system property is not set
> {code}
> A similar issue was once reported and fixed for m2e at
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=462944.
> The reason is
> https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L351
> which now requires this property to be set. This has been introduced by
> https://issues.apache.org/jira/browse/MNG-5767 in Maven 3.3.1
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-verifier] slawekjaranowski merged pull request #4: [MSHARED-1010] Allow to set dedicated Maven home directory
slawekjaranowski merged pull request #4: URL: https://github.com/apache/maven-verifier/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MSHARED-1010) Allow to customize Maven home
[ https://issues.apache.org/jira/browse/MSHARED-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MSHARED-1010: Assignee: Slawomir Jaranowski > Allow to customize Maven home > - > > Key: MSHARED-1010 > URL: https://issues.apache.org/jira/browse/MSHARED-1010 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-verifier >Reporter: Konrad Windszus >Assignee: Slawomir Jaranowski >Priority: Major > > In order to run ITs against multiple versions of Maven, it would be > beneficial, if the Maven version cannot only be customised implicitly via > System properties > (https://github.com/apache/maven-verifier/blob/246edfd46a2953f18099864cffb61257c0f2d698/src/main/java/org/apache/maven/it/Verifier.java#L200-L215), > but also more explicitly via a constructor argument. > This is particularly crucial when multiple verifier instances are used in > multiple threads, as each may leverage a different Maven home directory. > In case a Maven home directory is explicitly set it should take precedence > over mvnw. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MSHARED-1010) Allow to customize Maven home
[ https://issues.apache.org/jira/browse/MSHARED-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1010. Fix Version/s: maven-verifier-2.0.0 Resolution: Fixed > Allow to customize Maven home > - > > Key: MSHARED-1010 > URL: https://issues.apache.org/jira/browse/MSHARED-1010 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-verifier >Reporter: Konrad Windszus >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-verifier-2.0.0 > > > In order to run ITs against multiple versions of Maven, it would be > beneficial, if the Maven version cannot only be customised implicitly via > System properties > (https://github.com/apache/maven-verifier/blob/246edfd46a2953f18099864cffb61257c0f2d698/src/main/java/org/apache/maven/it/Verifier.java#L200-L215), > but also more explicitly via a constructor argument. > This is particularly crucial when multiple verifier instances are used in > multiple threads, as each may leverage a different Maven home directory. > In case a Maven home directory is explicitly set it should take precedence > over mvnw. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MSHARED-1011) Ease extension of Verifier
[
https://issues.apache.org/jira/browse/MSHARED-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MSHARED-1011.
Resolution: Feedback Received
> Ease extension of Verifier
> --
>
> Key: MSHARED-1011
> URL: https://issues.apache.org/jira/browse/MSHARED-1011
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-verifier
>Reporter: Konrad Windszus
>Priority: Major
>
> {{Verifier}} is not a final class but extending custom classes from it is
> hard as crucial functionality is hidden in private methods. Particularly the
> methods
> # {{getMavenLauncher}}
> # {{findLocalRepo}} and
> # {{findDefaultMavenHome}}
> should be made protected to allow to override them in extended Verifier
> classes.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MSHARED-1010) Allow to customize Maven home
[ https://issues.apache.org/jira/browse/MSHARED-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503139#comment-17503139 ] Hudson commented on MSHARED-1010: - Build succeeded in Jenkins: Maven » Maven TLP » maven-verifier » master #6 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-verifier/job/master/6/ > Allow to customize Maven home > - > > Key: MSHARED-1010 > URL: https://issues.apache.org/jira/browse/MSHARED-1010 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-verifier >Reporter: Konrad Windszus >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-verifier-2.0.0 > > > In order to run ITs against multiple versions of Maven, it would be > beneficial, if the Maven version cannot only be customised implicitly via > System properties > (https://github.com/apache/maven-verifier/blob/246edfd46a2953f18099864cffb61257c0f2d698/src/main/java/org/apache/maven/it/Verifier.java#L200-L215), > but also more explicitly via a constructor argument. > This is particularly crucial when multiple verifier instances are used in > multiple threads, as each may leverage a different Maven home directory. > In case a Maven home directory is explicitly set it should take precedence > over mvnw. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MSHARED-1010) Allow to customize Maven home
[ https://issues.apache.org/jira/browse/MSHARED-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1010: - Fix Version/s: maven-verifier-1.8.0 (was: maven-verifier-2.0.0) > Allow to customize Maven home > - > > Key: MSHARED-1010 > URL: https://issues.apache.org/jira/browse/MSHARED-1010 > Project: Maven Shared Components > Issue Type: New Feature > Components: maven-verifier >Reporter: Konrad Windszus >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-verifier-1.8.0 > > > In order to run ITs against multiple versions of Maven, it would be > beneficial, if the Maven version cannot only be customised implicitly via > System properties > (https://github.com/apache/maven-verifier/blob/246edfd46a2953f18099864cffb61257c0f2d698/src/main/java/org/apache/maven/it/Verifier.java#L200-L215), > but also more explicitly via a constructor argument. > This is particularly crucial when multiple verifier instances are used in > multiple threads, as each may leverage a different Maven home directory. > In case a Maven home directory is explicitly set it should take precedence > over mvnw. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MSHARED-1015) Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory system property is not set"
[
https://issues.apache.org/jira/browse/MSHARED-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MSHARED-1015:
-
Fix Version/s: maven-verifier-1.8.0
(was: maven-verifier-2.0.0)
> Using Embedded3xLauncher fails with "-Dmaven.multiModuleProjectDirectory
> system property is not set"
>
>
> Key: MSHARED-1015
> URL: https://issues.apache.org/jira/browse/MSHARED-1015
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-verifier
>Affects Versions: maven-verifier-1.7.2
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-verifier-1.8.0
>
>
> When trying to use an embedded launcher created from the classpath
> (https://github.com/apache/maven-verifier/blob/17ebffa2467caa59f1e47c302ac03d9e00d8c314/src/main/java/org/apache/maven/it/Embedded3xLauncher.java#L124),
> launching fails with
> {code}
> -Dmaven.multiModuleProjectDirectory system property is not set
> {code}
> A similar issue was once reported and fixed for m2e at
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=462944.
> The reason is
> https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java#L351
> which now requires this property to be set. This has been introduced by
> https://issues.apache.org/jira/browse/MNG-5767 in Maven 3.3.1
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-dependency-plugin] dependabot[bot] opened a new pull request #206: Bump mockito-core from 4.3.1 to 4.4.0
dependabot[bot] opened a new pull request #206: URL: https://github.com/apache/maven-dependency-plugin/pull/206 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.3.1 to 4.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.4.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.4.0 2022-03-08 - https://github.com/mockito/mockito/compare/v4.3.1...v4.4.0";>16 commit(s) by Andrew Kozel, Brice Dutheil, Jean-Baptiste Mille, Mirko Alicastro, dependabot[bot] Bump groovy from 3.0.9 to 3.0.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2586";>#2586)](https://github-redirect.dependabot.com/mockito/mockito/pull/2586";>mockito/mockito#2586) Bump google-java-format from 1.14.0 to 1.15.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2585";>#2585)](https://github-redirect.dependabot.com/mockito/mockito/pull/2585";>mockito/mockito#2585) Bump actions/checkout from 2.4.0 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2582";>#2582)](https://github-redirect.dependabot.com/mockito/mockito/pull/2582";>mockito/mockito#2582) Bump shipkit-auto-version from 1.1.19 to 1.1.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2580";>#2580)](https://github-redirect.dependabot.com/mockito/mockito/pull/2580";>mockito/mockito#2580) Bump biz.aQute.bnd.builder from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2579";>#2579)](https://github-redirect.dependabot.com/mockito/mockito/pull/2579";>mockito/mockito#2579) Bump biz.aQute.bnd.gradle from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2578";>#2578)](https://github-redirect.dependabot.com/mockito/mockito/pull/2578";>mockito/mockito#2578) Adds a Google Java Format for JDK17 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2572";>#2572)](https://github-redirect.dependabot.com/mockito/mockito/pull/2572";>mockito/mockito#2572) Clean up JUnit3 references [(https://github-redirect.dependabot.com/mockito/mockito/issues/2570";>#2570)](https://github-redirect.dependabot.com/mockito/mockito/pull/2570";>mockito/mockito#2570) Bump com.diffplug.spotless from 6.2.2 to 6.3.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2567";>#2567)](https://github-redirect.dependabot.com/mockito/mockito/pull/2567";>mockito/mockito#2567) Bump google-java-format from 1.13.0 to 1.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2565";>#2565)](https://github-redirect.dependabot.com/mockito/mockito/pull/2565";>mockito/mockito#2565) Bump versions.bytebuddy from 1.12.7 to 1.12.8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2564";>#2564)](https://github-redirect.dependabot.com/mockito/mockito/pull/2564";>mockito/mockito#2564) Bump com.diffplug.spotless from 6.2.1 to 6.2.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2562";>#2562)](https://github-redirect.dependabot.com/mockito/mockito/pull/2562";>mockito/mockito#2562) Bump com.github.ben-manes.versions from 0.41.0 to 0.42.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2559";>#2559)](https://github-redirect.dependabot.com/mockito/mockito/pull/2559";>mockito/mockito#2559) Bump com.diffplug.spotless from 6.2.0 to 6.2.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2556";>#2556)](https://github-redirect.dependabot.com/mockito/mockito/pull/2556";>mockito/mockito#2556) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548 : Makes InOrder able to verify static methods [(https://github-redirect.dependabot.com/mockito/mockito/issues/2549";>#2549)](https://github-redirect.dependabot.com/mockito/mockito/pull/2549";>mockito/mockito#2549) [PR open] Add feature to verify static methods calls in order [(https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548)](https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>mockito/mockito#2548) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201 : Fixed checking of declared exceptions. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2547";>#2547)](https://github-redirect.dependabot.com/mockito/mockito/pull/2547";>mockito/mockito#2547) Calling getExceptionTypes() on concrete object that is used as interface doesn't return exception types from interface [(https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201)](https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>mockito/mockito#2201) Commits https://github.com/mockito/mockito/commit/813add00ecd9a78ea9dcfccfc7797ea242be9ca9";>813add0 Bump groovy from 3.0.9 to 3.0.10 (https://github-redirect.dependabot.com/mockito/mockito/issues/2586";>#2586) https://github
[jira] [Created] (MPOM-301) mohands...@gmail.com
mohandsedu created MPOM-301: --- Summary: mohands...@gmail.com Key: MPOM-301 URL: https://issues.apache.org/jira/browse/MPOM-301 Project: Maven POMs Issue Type: Test Reporter: mohandsedu -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-wrapper] dependabot[bot] commented on pull request #20: Bump mockito-core from 4.1.0 to 4.3.1
dependabot[bot] commented on pull request #20: URL: https://github.com/apache/maven-wrapper/pull/20#issuecomment-1062472007 Superseded by #27. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wrapper] dependabot[bot] closed pull request #20: Bump mockito-core from 4.1.0 to 4.3.1
dependabot[bot] closed pull request #20: URL: https://github.com/apache/maven-wrapper/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wrapper] dependabot[bot] opened a new pull request #27: Bump mockito-core from 4.2.0 to 4.4.0
dependabot[bot] opened a new pull request #27: URL: https://github.com/apache/maven-wrapper/pull/27 Bumps [mockito-core](https://github.com/mockito/mockito) from 4.2.0 to 4.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.4.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.4.0 2022-03-08 - https://github.com/mockito/mockito/compare/v4.3.1...v4.4.0";>16 commit(s) by Andrew Kozel, Brice Dutheil, Jean-Baptiste Mille, Mirko Alicastro, dependabot[bot] Bump groovy from 3.0.9 to 3.0.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2586";>#2586)](https://github-redirect.dependabot.com/mockito/mockito/pull/2586";>mockito/mockito#2586) Bump google-java-format from 1.14.0 to 1.15.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2585";>#2585)](https://github-redirect.dependabot.com/mockito/mockito/pull/2585";>mockito/mockito#2585) Bump actions/checkout from 2.4.0 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2582";>#2582)](https://github-redirect.dependabot.com/mockito/mockito/pull/2582";>mockito/mockito#2582) Bump shipkit-auto-version from 1.1.19 to 1.1.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2580";>#2580)](https://github-redirect.dependabot.com/mockito/mockito/pull/2580";>mockito/mockito#2580) Bump biz.aQute.bnd.builder from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2579";>#2579)](https://github-redirect.dependabot.com/mockito/mockito/pull/2579";>mockito/mockito#2579) Bump biz.aQute.bnd.gradle from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2578";>#2578)](https://github-redirect.dependabot.com/mockito/mockito/pull/2578";>mockito/mockito#2578) Adds a Google Java Format for JDK17 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2572";>#2572)](https://github-redirect.dependabot.com/mockito/mockito/pull/2572";>mockito/mockito#2572) Clean up JUnit3 references [(https://github-redirect.dependabot.com/mockito/mockito/issues/2570";>#2570)](https://github-redirect.dependabot.com/mockito/mockito/pull/2570";>mockito/mockito#2570) Bump com.diffplug.spotless from 6.2.2 to 6.3.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2567";>#2567)](https://github-redirect.dependabot.com/mockito/mockito/pull/2567";>mockito/mockito#2567) Bump google-java-format from 1.13.0 to 1.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2565";>#2565)](https://github-redirect.dependabot.com/mockito/mockito/pull/2565";>mockito/mockito#2565) Bump versions.bytebuddy from 1.12.7 to 1.12.8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2564";>#2564)](https://github-redirect.dependabot.com/mockito/mockito/pull/2564";>mockito/mockito#2564) Bump com.diffplug.spotless from 6.2.1 to 6.2.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2562";>#2562)](https://github-redirect.dependabot.com/mockito/mockito/pull/2562";>mockito/mockito#2562) Bump com.github.ben-manes.versions from 0.41.0 to 0.42.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2559";>#2559)](https://github-redirect.dependabot.com/mockito/mockito/pull/2559";>mockito/mockito#2559) Bump com.diffplug.spotless from 6.2.0 to 6.2.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2556";>#2556)](https://github-redirect.dependabot.com/mockito/mockito/pull/2556";>mockito/mockito#2556) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548 : Makes InOrder able to verify static methods [(https://github-redirect.dependabot.com/mockito/mockito/issues/2549";>#2549)](https://github-redirect.dependabot.com/mockito/mockito/pull/2549";>mockito/mockito#2549) [PR open] Add feature to verify static methods calls in order [(https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548)](https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>mockito/mockito#2548) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201 : Fixed checking of declared exceptions. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2547";>#2547)](https://github-redirect.dependabot.com/mockito/mockito/pull/2547";>mockito/mockito#2547) Calling getExceptionTypes() on concrete object that is used as interface doesn't return exception types from interface [(https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201)](https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>mockito/mockito#2201) v4.3.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.3.1 2022-01-25 - https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1";>1 commit(s) by Stefano Cordio Add mockito-core to th
[GitHub] [maven-jar-plugin] dependabot[bot] opened a new pull request #35: Bump maven-plugins from 34 to 35
dependabot[bot] opened a new pull request #35: URL: https://github.com/apache/maven-jar-plugin/pull/35 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request #108: Bump groovy-all from 3.0.9 to 3.0.10
dependabot[bot] opened a new pull request #108: URL: https://github.com/apache/maven-invoker-plugin/pull/108 Bumps [groovy-all](https://github.com/apache/groovy) from 3.0.9 to 3.0.10. Commits See full diff in https://github.com/apache/groovy/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-script-interpreter] dependabot[bot] opened a new pull request #64: Bump maven-shared-components from 34 to 35
dependabot[bot] opened a new pull request #64: URL: https://github.com/apache/maven-script-interpreter/pull/64 Bumps [maven-shared-components](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] dependabot[bot] commented on pull request #52: Bump mockito-core from 2.28.2 to 4.3.1
dependabot[bot] commented on pull request #52: URL: https://github.com/apache/maven-assembly-plugin/pull/52#issuecomment-1062572765 Superseded by #53. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-assembly-plugin] dependabot[bot] opened a new pull request #53: Bump mockito-core from 2.28.2 to 4.4.0
dependabot[bot] opened a new pull request #53: URL: https://github.com/apache/maven-assembly-plugin/pull/53 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.4.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases. v4.4.0 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.4.0 2022-03-08 - https://github.com/mockito/mockito/compare/v4.3.1...v4.4.0";>16 commit(s) by Andrew Kozel, Brice Dutheil, Jean-Baptiste Mille, Mirko Alicastro, dependabot[bot] Bump groovy from 3.0.9 to 3.0.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2586";>#2586)](https://github-redirect.dependabot.com/mockito/mockito/pull/2586";>mockito/mockito#2586) Bump google-java-format from 1.14.0 to 1.15.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2585";>#2585)](https://github-redirect.dependabot.com/mockito/mockito/pull/2585";>mockito/mockito#2585) Bump actions/checkout from 2.4.0 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2582";>#2582)](https://github-redirect.dependabot.com/mockito/mockito/pull/2582";>mockito/mockito#2582) Bump shipkit-auto-version from 1.1.19 to 1.1.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2580";>#2580)](https://github-redirect.dependabot.com/mockito/mockito/pull/2580";>mockito/mockito#2580) Bump biz.aQute.bnd.builder from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2579";>#2579)](https://github-redirect.dependabot.com/mockito/mockito/pull/2579";>mockito/mockito#2579) Bump biz.aQute.bnd.gradle from 6.1.0 to 6.2.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2578";>#2578)](https://github-redirect.dependabot.com/mockito/mockito/pull/2578";>mockito/mockito#2578) Adds a Google Java Format for JDK17 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2572";>#2572)](https://github-redirect.dependabot.com/mockito/mockito/pull/2572";>mockito/mockito#2572) Clean up JUnit3 references [(https://github-redirect.dependabot.com/mockito/mockito/issues/2570";>#2570)](https://github-redirect.dependabot.com/mockito/mockito/pull/2570";>mockito/mockito#2570) Bump com.diffplug.spotless from 6.2.2 to 6.3.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2567";>#2567)](https://github-redirect.dependabot.com/mockito/mockito/pull/2567";>mockito/mockito#2567) Bump google-java-format from 1.13.0 to 1.14.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2565";>#2565)](https://github-redirect.dependabot.com/mockito/mockito/pull/2565";>mockito/mockito#2565) Bump versions.bytebuddy from 1.12.7 to 1.12.8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2564";>#2564)](https://github-redirect.dependabot.com/mockito/mockito/pull/2564";>mockito/mockito#2564) Bump com.diffplug.spotless from 6.2.1 to 6.2.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2562";>#2562)](https://github-redirect.dependabot.com/mockito/mockito/pull/2562";>mockito/mockito#2562) Bump com.github.ben-manes.versions from 0.41.0 to 0.42.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2559";>#2559)](https://github-redirect.dependabot.com/mockito/mockito/pull/2559";>mockito/mockito#2559) Bump com.diffplug.spotless from 6.2.0 to 6.2.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2556";>#2556)](https://github-redirect.dependabot.com/mockito/mockito/pull/2556";>mockito/mockito#2556) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548 : Makes InOrder able to verify static methods [(https://github-redirect.dependabot.com/mockito/mockito/issues/2549";>#2549)](https://github-redirect.dependabot.com/mockito/mockito/pull/2549";>mockito/mockito#2549) [PR open] Add feature to verify static methods calls in order [(https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>#2548)](https://github-redirect.dependabot.com/mockito/mockito/issues/2548";>mockito/mockito#2548) Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201 : Fixed checking of declared exceptions. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2547";>#2547)](https://github-redirect.dependabot.com/mockito/mockito/pull/2547";>mockito/mockito#2547) Calling getExceptionTypes() on concrete object that is used as interface doesn't return exception types from interface [(https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>#2201)](https://github-redirect.dependabot.com/mockito/mockito/issues/2201";>mockito/mockito#2201) v4.3.1 Changelog generated by https://github.com/shipkit/shipkit-changelog";>Shipkit Changelog Gradle Plugin 4.3.1 2022-01-25 - https://github.com/mockito/mockito/compare/v4.3.0...v4.3.1";>1 commit(s) by Stefano Cordio Add mockito-
[GitHub] [maven-assembly-plugin] dependabot[bot] closed pull request #52: Bump mockito-core from 2.28.2 to 4.3.1
dependabot[bot] closed pull request #52: URL: https://github.com/apache/maven-assembly-plugin/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-checkstyle-plugin] dependabot[bot] opened a new pull request #71: Bump maven-plugins from 34 to 35
dependabot[bot] opened a new pull request #71: URL: https://github.com/apache/maven-checkstyle-plugin/pull/71 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy merged pull request #483: no need to notify build failure for working branch this generate a lot of noise
olamy merged pull request #483: URL: https://github.com/apache/maven-surefire/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2035) Main artifact jar not present on test class path for tests
Christopher Tubbs created SUREFIRE-2035:
---
Summary: Main artifact jar not present on test class path for tests
Key: SUREFIRE-2035
URL: https://issues.apache.org/jira/browse/SUREFIRE-2035
Project: Maven Surefire
Issue Type: Bug
Components: Maven Failsafe Plugin
Affects Versions: 3.0.0-M5
Reporter: Christopher Tubbs
While trying to troubleshoot https://github.com/apache/accumulo/issues/2555, I
noticed that there was a behavior change between 3.0.0-M4 and 3.0.0-M5 that
causes the main artifact jar to be missing from the class path in test cases. I
was able to verify that by printing out
{{System.getProperty("java.class.path")}} before and after switching to M5, and
confirmed that the jar was missing after switching.
For some reason, tests still seem to work okay, though I can't figure out why.
However, if I try to launch a process using Java's ProcessBuilder using the
same class path from {{System.getProperty("java.class.path")}}, that process
fails with ClassNotFoundException, failing to find classes that should
definitely be present on the class path from the main artifact.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (SUREFIRE-2035) Main artifact jar not present on test class path for tests
[
https://issues.apache.org/jira/browse/SUREFIRE-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503320#comment-17503320
]
Christopher Tubbs commented on SUREFIRE-2035:
-
I even tried explicitly adding the main jar artifact onto the class path using
{{additionalClasspathElements}}, but that didn't work. The jar was still
missing when I printed {{System.getProperty("java.class.path")}}
> Main artifact jar not present on test class path for tests
> --
>
> Key: SUREFIRE-2035
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2035
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 3.0.0-M5
>Reporter: Christopher Tubbs
>Priority: Critical
>
> While trying to troubleshoot https://github.com/apache/accumulo/issues/2555,
> I noticed that there was a behavior change between 3.0.0-M4 and 3.0.0-M5 that
> causes the main artifact jar to be missing from the class path in test cases.
> I was able to verify that by printing out
> {{System.getProperty("java.class.path")}} before and after switching to M5,
> and confirmed that the jar was missing after switching.
> For some reason, tests still seem to work okay, though I can't figure out
> why. However, if I try to launch a process using Java's ProcessBuilder using
> the same class path from {{System.getProperty("java.class.path")}}, that
> process fails with ClassNotFoundException, failing to find classes that
> should definitely be present on the class path from the main artifact.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MPOM-301) mohands...@gmail.com
[ https://issues.apache.org/jira/browse/MPOM-301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maarten Mulders closed MPOM-301. Resolution: Invalid > mohands...@gmail.com > > > Key: MPOM-301 > URL: https://issues.apache.org/jira/browse/MPOM-301 > Project: Maven POMs > Issue Type: Test >Reporter: mohandsedu >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] olamy commented on a change in pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true
olamy commented on a change in pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#discussion_r822350092
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireHelper.java
##
@@ -154,7 +155,11 @@ public static void reportExecution(
SurefireReportParameters reportParameters, R
return;
}
-if ( reportParameters.isTestFailureIgnore() )
+if ( firstForkException instanceof SurefireBooterForkException )
+{
+throwException( reportParameters, result, firstForkException );
Review comment:
no need of distinction between both exception maven core doesn't handle
for very long time https://github.com/apache/maven/pull/632
this mean we can simplify the surefire code even more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true
olamy commented on pull request #478: URL: https://github.com/apache/maven-surefire/pull/478#issuecomment-1062624043 @Tibor17 I hope I answered all your concerns and we can now merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] SebastianKuehn commented on a change in pull request #73: [MPLUGIN-394] Respect input encoding
SebastianKuehn commented on a change in pull request #73: URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r822365765 ## File path: maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +invoker.goals = -Dfile.encoding=CP1252 plugin:report Review comment: Hallo @michael-o, this was my reproduction of the problem (on a Windows system which has CP1252 as System-Encoding). My goal was to set the default encoding to CP1252, regardless of the system (Linux, Mac etc.). In hindsight you are right, that this test might not work as expected an non Windows machine (i.e. it never fails because the encoding is always UTF-8). Can you propose another way to safely accomplish a default/system/native encoding not equal to utf8 while running this integration test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-394) Report-Mojo doesn't respect input encoding
[
https://issues.apache.org/jira/browse/MPLUGIN-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503349#comment-17503349
]
ASF GitHub Bot commented on MPLUGIN-394:
SebastianKuehn commented on a change in pull request #73:
URL: https://github.com/apache/maven-plugin-tools/pull/73#discussion_r822365765
##
File path:
maven-plugin-plugin/src/it/mplugin-394_report-encoding/invoker.properties
##
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals = -Dfile.encoding=CP1252 plugin:report
Review comment:
Hallo @michael-o,
this was my reproduction of the problem (on a Windows system which has
CP1252 as System-Encoding). My goal was to set the default encoding to CP1252,
regardless of the system (Linux, Mac etc.). In hindsight you are right, that
this test might not work as expected an non Windows machine (i.e. it never
fails because the encoding is always UTF-8). Can you propose another way to
safely accomplish a default/system/native encoding not equal to utf8 while
running this integration test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Report-Mojo doesn't respect input encoding
> --
>
> Key: MPLUGIN-394
> URL: https://issues.apache.org/jira/browse/MPLUGIN-394
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Sebastian Kühn
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.7.0
>
>
> {{plugin:report}} reads the Plugin-XML-File with with the platform encoding
> instead of the specified input encoding. This results in an broken generated
> XDoc and finally Site.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
