slawekjaranowski commented on a change in pull request #485:
URL: https://github.com/apache/maven-surefire/pull/485#discussion_r821625665



##########
File path: 
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##########
@@ -93,6 +93,18 @@ public void selectJUnit5()
                 "Using auto detected provider 
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
     }
 
+    @Test
+    public void selectJUnit5UsingConfiguredProvider()
+    {
+        unpack( "junit-4-5" )

Review comment:
       We can put example project in separate directory, like surefire-xxxx :-) 
without profile.

##########
File path: 
surefire-its/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1787JUnit5IT.java
##########
@@ -93,6 +93,18 @@ public void selectJUnit5()
                 "Using auto detected provider 
org.apache.maven.surefire.junitplatform.JUnitPlatformProvider" );
     }
 
+    @Test
+    public void selectJUnit5UsingConfiguredProvider()

Review comment:
       maybe `selectJUnit5UsingConfiguredProviderWithPlatformRunner`
   
   We can also put this test in separate class with name corresponding to issue 
number




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to