[GitHub] [maven-surefire] Tibor17 commented on pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 commented on pull request #482: URL: https://github.com/apache/maven-surefire/pull/482#issuecomment-1055132926 @slachiewicz Remains only SUREFIRE-2014 to close SUREFIRE-1860. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MEAR-302) jakarta EE 9 EAR compatibility
[ https://issues.apache.org/jira/browse/MEAR-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499404#comment-17499404 ] Moci commented on MEAR-302: --- Any update on this? Jakarta EE 9.1 is supported in multiple application servers by now. > jakarta EE 9 EAR compatibility > -- > > Key: MEAR-302 > URL: https://issues.apache.org/jira/browse/MEAR-302 > Project: Maven EAR Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.2.0 > Environment: windows > glassfish 6.1 > jdk-15.0.0.36-hotspot >Reporter: Dionysos >Assignee: Olivier Lamy >Priority: Major > Attachments: testapp.zip > > > Hi! I've created this issue and attached a sample project as asked. > On this one the war is getting packaged but again I cannot deploy it whatever > I tried. > > Relative correspondence in users mailing list here: > https://lists.apache.org/thread.html/r498322ab35e9e703f9e9735cf10c31959654f54ec85717cbd7aa84d7%40 > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-toolchains-plugin] Bananeweizen commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
Bananeweizen commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055190387 Can someone with the necessary powers please retrigger the build? To me the change seems perfectly valid, so this is probably rather a hickup in the infrastructure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-toolchains-plugin] michael-o commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
michael-o commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055191626 How will this flag make it threadsafe? Did you review the code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-toolchains-plugin] ThomasReinhardt commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
ThomasReinhardt commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055204424 This plugin is already threadsafe (see below). It probably was since a very long time but nobody cared to investigate. This change is only marking the plugin as threadsafe. It changes absolutely nothing execution-wise. Why do I think it is threadsafe? As I wrote on the jira page it does not hold any state and gets instantiated PER_LOOKUP. So there is no way it can share state across instantiations. Which also means there are no collisions, races etc. In fact, the plugin should most likely be optimized, because now every invokation reads toolchains.xml which is quite inefficient. But it is threadsafe and this is what this PR is about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-toolchains-plugin] Bananeweizen commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
Bananeweizen commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055207088 Yes, I reviewed the code. When making a maven plugin thread-safe, typical issues are the following: * static fields being used in the plugin. Since those are accessed from all concurrent invocations of the plugin simultaneously, they need proper synchronization. There is no such field here. * calling methods from the Maven core or Maven utility classes that are not thread-safe on their own, and therefore again would need proper synchronization per call in this plugin. The 3 Java files of this plugin look okay. There is one where I'm not perfectly sure, the call to ToolchainManagerPrivate.storeToolchainToBuildContext(...). If you still have a bad feeling about the change, there would be a simple alternative implementation to _definitely_ make it thread safe: The plugin would declare an additional lock object, and nest the complete code of the "execute" method via that lock object. That would lead to any additional concurrent invocation of this plugin waiting for the already running first invocation of the same plugin. That means Maven would still be able to execute all kinds of _other_ maven plugin mojos in parallel, only if this plugin would be called 2 times in parallel, one of those would wait for the other to finish. I can provide a sample implementation if necessary (from other maven plugins). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-toolchains-plugin] Bananeweizen commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
Bananeweizen commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055210977 An example change to use a local lock object for synchronization can be seen in the first file change of https://github.com/eclipse/tycho/commit/8afcd612364f9a47bc7bfb0ef013104069769cf9. That's not the only maven plugin where this technique has been applied, so it can be trusted for sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6965) Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499419#comment-17499419
]
Konrad Windszus commented on MNG-6965:
--
Although plexus-utils is mostly part of the Core Classloader
(https://github.com/apache/maven/blob/9b656c72d54e5bacbed989b64718c159fe39b537/maven-core/src/main/resources/META-INF/maven/extension.xml#L79-L83)
and therefore should only be referenced with "provided" scope according to
https://issues.apache.org/jira/browse/MNG-7097, the
https://github.com/apache/maven/blob/maven-3.8.4/maven-core/src/main/java/org/apache/maven/plugin/internal/PlexusUtilsInjector.java
does not consider "provided" dependencies, and therefore references
plexus-utils 1.1 whenever the plexus-utils in some newer version is referenced
with "provided" scope.
As this seems pretty severe, I would strongly recommend backporting this to 3.9.
> Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their
> classpath
>
>
> Key: MNG-6965
> URL: https://issues.apache.org/jira/browse/MNG-6965
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.6.0, 3.6.3
> Environment: Win7, Win10, at least one variant of Linux (not sure
> which)
>Reporter: Mark Nolan
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: archetype
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
> Attachments: pom.xml
>
>
> A simple minimal archetype pom following the manual pages downloads
> plexus-utils 1.1, even though it is not (apparently) declared anywhere. This
> version is banned at my organization (edited to add: due to vulnerabilities),
> meaning such a pom always fails.
>
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> 0.0.1-SNAPSHOT
> maven-archetype
> test
>
>
>
> org.apache.maven.archetype
> archetype-packaging
> 3.1.2
>
>
>
>
>
> org.apache.maven.plugins
> maven-archetype-plugin
> 3.1.2
>
>
>
>
>
> {code}
> Running any goal, such as mvn -X clean, produces the following before the
> goal is executed:
> {code}
> [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=952800,
> ConflictMarker.markTime=586900, ConflictMarker.nodeCount=1,
> ConflictIdSorter.graphTime=549200, ConflictIdSorter.topsortTime=586700,
> ConflictIdSorter.conflictIdCount=1, ConflictIdSorter.conflictIdCycleCount=0,
> ConflictResolver.totalTime=3313100, ConflictResolver.conflictItemCount=1,
> DefaultDependencyCollector.collectTime=66890900,
> DefaultDependencyCollector.transformTime=8523500}
> [DEBUG] org.apache.maven.archetype:archetype-packaging:jar:3.1.2:
> [DEBUG]org.codehaus.plexus:plexus-utils:jar:1.1:runtime
> {code}
>
> As far as I can see, there is no declared dependency on plexus-utils:1.1.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-toolchains-plugin] ThomasReinhardt commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
ThomasReinhardt commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055246280 Thanks @Bananeweizen. I added a synchronized block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] commented on pull request #50: Bump maven-project-info-reports-plugin from 3.1.1 to 3.2.1
dependabot[bot] commented on pull request #50: URL: https://github.com/apache/maven-ear-plugin/pull/50#issuecomment-1055248694 Superseded by #51. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] closed pull request #50: Bump maven-project-info-reports-plugin from 3.1.1 to 3.2.1
dependabot[bot] closed pull request #50: URL: https://github.com/apache/maven-ear-plugin/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] dependabot[bot] opened a new pull request #51: Bump maven-project-info-reports-plugin from 3.1.1 to 3.2.2
dependabot[bot] opened a new pull request #51: URL: https://github.com/apache/maven-ear-plugin/pull/51 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.1.1 to 3.2.2. Commits https://github.com/apache/maven-project-info-reports-plugin/commit/ca84755a9d1f58f6bd39e70457fb0d36ce3755c4";>ca84755 [maven-release-plugin] prepare release maven-project-info-reports-plugin-3.2.2 https://github.com/apache/maven-project-info-reports-plugin/commit/d28e98b8cfedbe179a1017d1a221871919841415";>d28e98b [MPIR-413] Plugin repositories defined in project are not used by plugin mana... https://github.com/apache/maven-project-info-reports-plugin/commit/99bfaef54bbff120317a7adfb7ca9cf0f883075c";>99bfaef [MPIR-414] Upgrade Maven Reporting API/Impl to 3.1.0 https://github.com/apache/maven-project-info-reports-plugin/commit/d1bd10325e2cddf1cdf41f799d1407282006e067";>d1bd103 Upgrade Maven Site Plugin for IT to 3.11.0 https://github.com/apache/maven-project-info-reports-plugin/commit/547314f7cd71bad658ecad07a8195e8bd5e5dbcc";>547314f Replace usage of deprecated expressions https://github.com/apache/maven-project-info-reports-plugin/commit/517662c10b1e817a91c11f8433f3c832f5ad1601";>517662c [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-project-info-reports-plugin/commit/8c25c66593f488f6609910b95ae2b246c196d734";>8c25c66 [maven-release-plugin] prepare release maven-project-info-reports-plugin-3.2.1 https://github.com/apache/maven-project-info-reports-plugin/commit/d85aec37c385d64196f7db5c3c27b400b46032ca";>d85aec3 [MPIR-412] Dependency report generates non-well-formed output if the POM of a... https://github.com/apache/maven-project-info-reports-plugin/commit/3c155a8231fac8b018c257d6dbe6bff0902633a2";>3c155a8 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-project-info-reports-plugin/commit/b130e220569301f89c58bfd10bf9de36efa20b1e";>b130e22 [maven-release-plugin] prepare release maven-project-info-reports-plugin-3.2.0 Additional commits viewable in https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.1.1...maven-project-info-reports-plugin-3.2.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-toolchains-plugin] michael-o commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
michael-o commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055302463 Remove the swap file please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-toolchains-plugin] ThomasReinhardt commented on pull request #8: [MTOOLCHAINS-31] - Not threadsafe for parallel execution
ThomasReinhardt commented on pull request #8: URL: https://github.com/apache/maven-toolchains-plugin/pull/8#issuecomment-1055308434 Sorry. Its gone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 edited a comment on pull request #482: URL: https://github.com/apache/maven-surefire/pull/482#issuecomment-1055132926 @slachiewicz Now only SUREFIRE-2014 remains to complete the entire SUREFIRE-1860. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] slawekjaranowski commented on pull request #52: [MEAR-302] Support JakartaEE 9 schema
slawekjaranowski commented on pull request #52: URL: https://github.com/apache/maven-ear-plugin/pull/52#issuecomment-1055337307 please add test to EarMojoIT -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MWAR-448) packaging dependencies fails with "mvn install" but not "mvn package"
Kari J. Niemi created MWAR-448: -- Summary: packaging dependencies fails with "mvn install" but not "mvn package" Key: MWAR-448 URL: https://issues.apache.org/jira/browse/MWAR-448 Project: Maven WAR Plugin Issue Type: Bug Affects Versions: 3.3.2 Environment: maven 3.6.3 ( later versions have bugs which we can't take in) Reporter: Kari J. Niemi I think we discovered a minor odd difference with war-packaging between "mvn package" or "mvn install". We would expect that only difference between the two is that the latter also installs the produced stuff in the local maven repository. We are packaging a few jars to a war. We have a parent pom with some modules, and that is defined as a dependency in the pom.xml that produces a war-package. Like this: my-war-thingie:pom.xml (packaging:war) * dependency: some-parent some-parent:pom.xml (packaging:pom) * module1 (packaging:jar) * module2 (packaging:jar) Earlier we had a different structure and everything was just fine: we did not the have the child-modules but the parent-pom produced the jar. When we changed the structure to the one described above: our CI was still OK, some developers building OK as well -but some developers had failing maven builds because of missing "some-parent.jar". It was bit of devastating hunt, but finally we discovered that "mvn package" was building OK, but "mvn install" looks for "some-parent.jar". We don't actually mind if the above scenario would fail in both cases, or if it was successful - we would just expect that it works the same way for both. If this is intended behaviour, it would be nice to have it documented. FWIW: in our case, we anyway wanted to define direct dependencies from the war-packaging to the child-modules. So actually, we are OK wih our builds already. But the difference caused so may doubts about our builds reproducibility - and also, it seems like a bug - so I wanted to be good citizen and report the problem. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-ear-plugin] slawekjaranowski commented on pull request #52: [MEAR-302] Support JakartaEE 9 schema
slawekjaranowski commented on pull request #52: URL: https://github.com/apache/maven-ear-plugin/pull/52#issuecomment-1055368813 something like src/test/resources/projects/project-082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWAR-448) packaging dependencies fails with "mvn install" but not "mvn package"
[ https://issues.apache.org/jira/browse/MWAR-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499499#comment-17499499 ] Slawomir Jaranowski commented on MWAR-448: -- please attach minimal project, which can reproduce your problem. > packaging dependencies fails with "mvn install" but not "mvn package" > - > > Key: MWAR-448 > URL: https://issues.apache.org/jira/browse/MWAR-448 > Project: Maven WAR Plugin > Issue Type: Bug >Affects Versions: 3.3.2 > Environment: maven 3.6.3 ( later versions have bugs which we can't > take in) >Reporter: Kari J. Niemi >Priority: Minor > > I think we discovered a minor odd difference with war-packaging between "mvn > package" or "mvn install". We would expect that only difference between the > two is that the latter also installs the produced stuff in the local maven > repository. > > We are packaging a few jars to a war. We have a parent pom with some modules, > and that is defined as a dependency in the pom.xml that produces a > war-package. Like this: > my-war-thingie:pom.xml (packaging:war) > * dependency: some-parent > some-parent:pom.xml (packaging:pom) > * module1 (packaging:jar) > * module2 (packaging:jar) > Earlier we had a different structure and everything was just fine: we did not > the have the child-modules but the parent-pom produced the jar. When we > changed the structure to the one described above: our CI was still OK, some > developers building OK as well -but some developers had failing maven builds > because of missing "some-parent.jar". > > It was bit of devastating hunt, but finally we discovered that "mvn package" > was building OK, but "mvn install" looks for "some-parent.jar". > We don't actually mind if the above scenario would fail in both cases, or if > it was successful - we would just expect that it works the same way for both. > If this is intended behaviour, it would be nice to have it documented. > FWIW: in our case, we anyway wanted to define direct dependencies from the > war-packaging to the child-modules. So actually, we are OK wih our builds > already. But the difference caused so may doubts about our builds > reproducibility - and also, it seems like a bug - so I wanted to be good > citizen and report the problem. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MWAR-448) packaging dependencies fails with "mvn install" but not "mvn package"
[ https://issues.apache.org/jira/browse/MWAR-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kari J. Niemi updated MWAR-448: --- Description: I think we discovered a minor odd difference with war-packaging between "mvn package" or "mvn install". We would expect that only difference between the two is that the latter also installs the produced stuff in the local maven repository. We are packaging a few jars to a war. We have a parent pom with some modules, and that is defined as a dependency in the pom.xml that produces a war-package. Like this: my-war-thingie:pom.xml (packaging:war) * dependency: some-parent some-parent:pom.xml (packaging:pom) * module1 (packaging:jar) * module2 (packaging:jar) Earlier we had a different structure and everything was just fine: we did not the have the child-modules but the parent-pom produced the jar. When we changed the structure to the one described above: our CI was still OK, some developers building OK as well -but some developers had failing maven builds because of missing "some-parent.jar". It was bit of devastating hunt, but finally we discovered that "mvn package" was building OK, but "mvn install" looks for "some-parent.jar". We don't actually mind if the above scenario would fail in both cases, or if it was successful - we would just expect that it works the same way for both. If this is intended behaviour, it would be nice to have it documented. FWIW: in our case, we anyway wanted to define direct dependencies from the war-packaging to the child-modules. So actually, we are OK wih our builds already. But the difference caused so may doubts about our builds reproducibility - and also, it seems like a bug - so I wanted to be good citizen and report the problem. Edit: further note from our troubleshooting sessions: we don't have the "type" for the dependency at all in my-war-thingie:pom.xml. Yesterday, we did experiment setting the type as "pom" -and as a consequence, both "mvn package" and "mvn install" were successful. The default as we know, should/would be "jar". Maybe the missing dependency type is for some odd reason resolved differently for "maven package" and "maven install"? was: I think we discovered a minor odd difference with war-packaging between "mvn package" or "mvn install". We would expect that only difference between the two is that the latter also installs the produced stuff in the local maven repository. We are packaging a few jars to a war. We have a parent pom with some modules, and that is defined as a dependency in the pom.xml that produces a war-package. Like this: my-war-thingie:pom.xml (packaging:war) * dependency: some-parent some-parent:pom.xml (packaging:pom) * module1 (packaging:jar) * module2 (packaging:jar) Earlier we had a different structure and everything was just fine: we did not the have the child-modules but the parent-pom produced the jar. When we changed the structure to the one described above: our CI was still OK, some developers building OK as well -but some developers had failing maven builds because of missing "some-parent.jar". It was bit of devastating hunt, but finally we discovered that "mvn package" was building OK, but "mvn install" looks for "some-parent.jar". We don't actually mind if the above scenario would fail in both cases, or if it was successful - we would just expect that it works the same way for both. If this is intended behaviour, it would be nice to have it documented. FWIW: in our case, we anyway wanted to define direct dependencies from the war-packaging to the child-modules. So actually, we are OK wih our builds already. But the difference caused so may doubts about our builds reproducibility - and also, it seems like a bug - so I wanted to be good citizen and report the problem. > packaging dependencies fails with "mvn install" but not "mvn package" > - > > Key: MWAR-448 > URL: https://issues.apache.org/jira/browse/MWAR-448 > Project: Maven WAR Plugin > Issue Type: Bug >Affects Versions: 3.3.2 > Environment: maven 3.6.3 ( later versions have bugs which we can't > take in) >Reporter: Kari J. Niemi >Priority: Minor > > I think we discovered a minor odd difference with war-packaging between "mvn > package" or "mvn install". We would expect that only difference between the > two is that the latter also installs the produced stuff in the local maven > repository. > > We are packaging a few jars to a war. We have a parent pom with some modules, > and that is defined as a dependency in the pom.xml that produces a > war-package. Like this: > my-war-thingie:pom.xml (packaging:war) > * dependency: some-parent > some-parent:pom.xml (packaging:pom) > * module1 (packaging:jar) > * module2 (packaging:jar)
[GitHub] [maven-ear-plugin] slawekjaranowski commented on pull request #52: [MEAR-302] Support JakartaEE 9 schema
slawekjaranowski commented on pull request #52: URL: https://github.com/apache/maven-ear-plugin/pull/52#issuecomment-1055433650 please also rebase with the latest master codebase 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 commented on pull request #482: URL: https://github.com/apache/maven-surefire/pull/482#issuecomment-1055440535 @slachiewicz If a Javadoc is missing somewhere, I can add one of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker] slawekjaranowski merged pull request #43: [MSHARED-1019] Allow pass raw cli option to Maven process
slawekjaranowski merged pull request #43: URL: https://github.com/apache/maven-invoker/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MSHARED-1019) Allow pass raw cli option to Maven process
[
https://issues.apache.org/jira/browse/MSHARED-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MSHARED-1019.
Fix Version/s: maven-invoker-3.2.0
Resolution: Fixed
> Allow pass raw cli option to Maven process
> --
>
> Key: MSHARED-1019
> URL: https://issues.apache.org/jira/browse/MSHARED-1019
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.2.0
>
>
> Something like {{addCliOption}} in {{Verifier}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MSHARED-1019) Allow pass raw cli option to Maven process
[
https://issues.apache.org/jira/browse/MSHARED-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499586#comment-17499586
]
Hudson commented on MSHARED-1019:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-invoker » master #8
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-invoker/job/master/8/
> Allow pass raw cli option to Maven process
> --
>
> Key: MSHARED-1019
> URL: https://issues.apache.org/jira/browse/MSHARED-1019
> Project: Maven Shared Components
> Issue Type: New Feature
> Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.2.0
>
>
> Something like {{addCliOption}} in {{Verifier}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-ear-plugin] pzygielo commented on pull request #52: [MEAR-302] Support JakartaEE 9 schema
pzygielo commented on pull request #52: URL: https://github.com/apache/maven-ear-plugin/pull/52#issuecomment-1055537769 @slawekjaranowski - `EarMojoIT` updated with new test as suggested, changes rebased on current master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slachiewicz commented on pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
slachiewicz commented on pull request #482: URL: https://github.com/apache/maven-surefire/pull/482#issuecomment-1055548258 @slawekjaranowski ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2028) ShadeFire is missing org.apache.maven.surefire:common-java5
[ https://issues.apache.org/jira/browse/SUREFIRE-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-2028: --- Fix Version/s: (was: 3.0.0-M6) > ShadeFire is missing org.apache.maven.surefire:common-java5 > --- > > Key: SUREFIRE-2028 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2028 > Project: Maven Surefire > Issue Type: Improvement > Components: surefire-shadefire >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SUREFIRE-2028) ShadeFire is missing org.apache.maven.surefire:common-java5
[ https://issues.apache.org/jira/browse/SUREFIRE-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-2028. -- Resolution: Duplicate > ShadeFire is missing org.apache.maven.surefire:common-java5 > --- > > Key: SUREFIRE-2028 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2028 > Project: Maven Surefire > Issue Type: Improvement > Components: surefire-shadefire >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true
Tibor17 commented on a change in pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#discussion_r816873091
##
File path:
surefire-its/src/test/resources/surefire-1426-ignore-fail-jvm-crash/pom.xml
##
@@ -0,0 +1,49 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+ org.apache.maven.plugins.surefire
+ SUREFIRE-1426
+ 1.0-SNAPSHOT
+ SUREFIRE-1426
+
+
+1.8
+1.8
+
+
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+${surefire.version}
+
+ -Dfile.encoding=UTF-8 -Duser.language=en -XFFOOOBEEER
-Duser.region=US -showversion -Xmx6g -Xms2g -XX:+PrintGCDetails
Review comment:
There are multiple use cases for `maven.test.failure.ignore`.
This test with `-XFFOOOBEEER` already exists in
`Surefire735ForkFailWithRedirectConsoleOutputIT`. Of course it must not be
modified. You can only add a new test method and add the system property
`maven.test.failure.ignore`.
And why `-Xmx6g -Xms2g`? No idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 commented on pull request #482: URL: https://github.com/apache/maven-surefire/pull/482#issuecomment-1055563132 @slachiewicz Sorry for typo. My bad! May I ask you for having a look since you are already here? Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-6981) Project list also includes its (child) modules
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters updated MNG-6981:
Summary: Project list also includes its (child) modules (was: Add
--recursive option)
> Project list also includes its (child) modules
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6981) --project-list should also include its (child) modules
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte updated MNG-6981:
Summary: --project-list should also include its (child) modules (was:
--project-list should also includes its (child) modules)
> --project-list should also include its (child) modules
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6981) --project-list should also includes its (child) modules
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte updated MNG-6981:
Summary: --project-list should also includes its (child) modules (was:
Project list also includes its (child) modules)
> --project-list should also includes its (child) modules
> ---
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #481: Add release-drafter to create gh releases
Tibor17 commented on pull request #481: URL: https://github.com/apache/maven-surefire/pull/481#issuecomment-1055774193 @olamy @slawekjaranowski It does not have config for the JIRA URL? These release notes are built upon pull requests only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #481: Add release-drafter to create gh releases
Tibor17 edited a comment on pull request #481: URL: https://github.com/apache/maven-surefire/pull/481#issuecomment-1055774193 @olamy @slawekjaranowski It does not have any config of the JIRA URL? These release notes are built upon pull requests only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-6981) --projects should also include its (child) modules
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters updated MNG-6981:
Summary: --projects should also include its (child) modules (was:
--project-list should also include its (child) modules)
> --projects should also include its (child) modules
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6118) Allow resolving inter-module dependencies when using --file
[
https://issues.apache.org/jira/browse/MNG-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters updated MNG-6118:
Summary: Allow resolving inter-module dependencies when using --file (was:
Add option to execute goals on a specific module while building a multimodule
project)
> Allow resolving inter-module dependencies when using --file
> ---
>
> Key: MNG-6118
> URL: https://issues.apache.org/jira/browse/MNG-6118
> Project: Maven
> Issue Type: Improvement
> Components: Command Line, Plugins and Lifecycle
>Reporter: Robert Scholte
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> Suppose we have a multimodule which results in a war. In the end we want to
> run this war in a container like jetty. Up until now the {{jetty:run}} is
> executed on every module, which doesn't make sense for the other modules.
> This is just one of several examples where you want to control on which
> module to execute a specific goal. In case of wars, the plugin could check
> for the packaging type, but in case of jars this won't work.
> There should be a generic solution to mark goals for a specific module.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #479: test hacking depedencies and build plan to be able to use -T3 or mvnd
Tibor17 commented on pull request #479: URL: https://github.com/apache/maven-surefire/pull/479#issuecomment-1055780469 @olamy This does not make sense. First of all the Maven should have very stable **Resolver** avoiding file locking in the Maven local repo. I used ParallelParameterized tests, I can do it again, but due to the Maven 3.2.x locks artifacts, ParallelParameterized won't be used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Tibor17 commented on a change in pull request #480: URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817109165 ## File path: Jenkinsfile ## @@ -30,7 +30,7 @@ properties( ] ) final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x'] Review comment: This change is not acceptable. We want to and we will accept the range Maven 3.2+. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6965) Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their classpath
[
https://issues.apache.org/jira/browse/MNG-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499735#comment-17499735
]
Michael Osipov commented on MNG-6965:
-
[~kwin], I have already assigned this to 3.9.0-candidate. As soon as I have
applied my patches to 3.9.0 and [~gnodet], we can start discussing candidates.
I guess last trimester of March.
> Extensions suddenly have org.codehaus.plexus:plexus-utils:jar:1.1 on their
> classpath
>
>
> Key: MNG-6965
> URL: https://issues.apache.org/jira/browse/MNG-6965
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 3.6.0, 3.6.3
> Environment: Win7, Win10, at least one variant of Linux (not sure
> which)
>Reporter: Mark Nolan
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: archetype
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
> Attachments: pom.xml
>
>
> A simple minimal archetype pom following the manual pages downloads
> plexus-utils 1.1, even though it is not (apparently) declared anywhere. This
> version is banned at my organization (edited to add: due to vulnerabilities),
> meaning such a pom always fails.
>
> {code:xml}
> http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> test
> test
> 0.0.1-SNAPSHOT
> maven-archetype
> test
>
>
>
> org.apache.maven.archetype
> archetype-packaging
> 3.1.2
>
>
>
>
>
> org.apache.maven.plugins
> maven-archetype-plugin
> 3.1.2
>
>
>
>
>
> {code}
> Running any goal, such as mvn -X clean, produces the following before the
> goal is executed:
> {code}
> [DEBUG] Dependency collection stats: {ConflictMarker.analyzeTime=952800,
> ConflictMarker.markTime=586900, ConflictMarker.nodeCount=1,
> ConflictIdSorter.graphTime=549200, ConflictIdSorter.topsortTime=586700,
> ConflictIdSorter.conflictIdCount=1, ConflictIdSorter.conflictIdCycleCount=0,
> ConflictResolver.totalTime=3313100, ConflictResolver.conflictItemCount=1,
> DefaultDependencyCollector.collectTime=66890900,
> DefaultDependencyCollector.transformTime=8523500}
> [DEBUG] org.apache.maven.archetype:archetype-packaging:jar:3.1.2:
> [DEBUG]org.codehaus.plexus:plexus-utils:jar:1.1:runtime
> {code}
>
> As far as I can see, there is no declared dependency on plexus-utils:1.1.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
Tibor17 commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817111492
##
File path: Jenkinsfile
##
@@ -174,7 +174,7 @@ def buildProcess(String stageKey, String jdkName, String
mvnName, goals, options
try {
if (makeReports) {
jacoco(changeBuildStatus: false,
-execPattern: '**/*.exec',
+execPattern: '**/target/jacoco*.exec',
Review comment:
Why you change this line?
It does not make any difference!
Do we have any other tools which produce `exec` files? No, we don't!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] asfgit closed pull request #685: [MNG-6960] Use RuntimeInformation instead of reading properties
asfgit closed pull request #685: URL: https://github.com/apache/maven/pull/685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-6960) Use RuntimeInformation instead of reading properties
[
https://issues.apache.org/jira/browse/MNG-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6960.
---
Resolution: Fixed
Fixed with
[833cfbd334eaba21475bb71addaf103cb267|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=833cfbd334eaba21475bb71addaf103cb267]
and with
[f0caf9c9b31e31abb91ca986fe8168867cd0ded2|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=f0caf9c9b31e31abb91ca986fe8168867cd0ded2]
for {{maven-3.8.x}} branch.
> Use RuntimeInformation instead of reading properties
>
>
> Key: MNG-6960
> URL: https://issues.apache.org/jira/browse/MNG-6960
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MNG-6960) Use RuntimeInformation instead of reading properties
[ https://issues.apache.org/jira/browse/MNG-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499748#comment-17499748 ] Hudson commented on MNG-6960: - Build failed in Jenkins: Maven » Maven TLP » maven » maven-3.8.x #4 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.8.x/4/ > Use RuntimeInformation instead of reading properties > > > Key: MNG-6960 > URL: https://issues.apache.org/jira/browse/MNG-6960 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Minor > Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MNG-6960) Use RuntimeInformation instead of reading properties
[ https://issues.apache.org/jira/browse/MNG-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499749#comment-17499749 ] Hudson commented on MNG-6960: - Build failed in Jenkins: Maven » Maven TLP » maven » master #5 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/5/ > Use RuntimeInformation instead of reading properties > > > Key: MNG-6960 > URL: https://issues.apache.org/jira/browse/MNG-6960 > Project: Maven > Issue Type: Improvement > Components: Core >Affects Versions: 3.6.3 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Minor > Fix For: 4.0.0, 4.0.0-alpha-1, 3.8.5 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
slawekjaranowski commented on a change in pull request #482:
URL: https://github.com/apache/maven-surefire/pull/482#discussion_r81691
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
##
@@ -282,13 +281,6 @@ public void testExecutionSkippedByUser()
{
}
-public RunMode markAs( RunMode currentRunMode )
-{
-RunMode runMode = this.runMode;
-this.runMode = requireNonNull( currentRunMode );
Review comment:
private field `runMode` can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
slawekjaranowski commented on a change in pull request #480: URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817134239 ## File path: Jenkinsfile ## @@ -30,7 +30,7 @@ properties( ] ) final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x'] Review comment: current used Maven api is 3.2.5 ... so we need check with it. 3.8.x is ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #481: Add release-drafter to create gh releases
slawekjaranowski commented on pull request #481: URL: https://github.com/apache/maven-surefire/pull/481#issuecomment-1055853459 yes build release notes only based on PR, but all important issue should have PR. it prepare only release draft - which can be edited/removed/published -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on pull request #481: Add release-drafter to create gh releases
olamy commented on pull request #481: URL: https://github.com/apache/maven-surefire/pull/481#issuecomment-1055855527 > @olamy @slawekjaranowski It does not have any config of the JIRA URL? These release notes are built upon pull requests only? the file have the following configuration `_extends: maven-gh-actions-shared` which means this inherits the configuration from https://github.com/apache/maven-gh-actions-shared/blob/main/.github/release-drafter.yml -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
olamy commented on a change in pull request #480: URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817139797 ## File path: Jenkinsfile ## @@ -30,7 +30,7 @@ properties( ] ) final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x'] Review comment: @slawekjaranowski sounds a good explanation to change that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
olamy commented on a change in pull request #480:
URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817140781
##
File path: Jenkinsfile
##
@@ -174,7 +174,7 @@ def buildProcess(String stageKey, String jdkName, String
mvnName, goals, options
try {
if (makeReports) {
jacoco(changeBuildStatus: false,
-execPattern: '**/*.exec',
+execPattern: '**/target/jacoco*.exec',
Review comment:
it's to avoid a deep scanning which have a very poor performance where
we know exactly file names we are looking for `jacoco*.exec` and directories.
scanning everything is a waste of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
olamy commented on a change in pull request #480: URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817141822 ## File path: Jenkinsfile ## @@ -30,7 +30,7 @@ properties( ] ) final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.8.x'] : ['3.8.x'] Review comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on pull request #479: test hacking depedencies and build plan to be able to use -T3 or mvnd
olamy commented on pull request #479: URL: https://github.com/apache/maven-surefire/pull/479#issuecomment-1055863568 > @olamy This does not make sense. First of all the Maven should have very stable **Resolver** avoiding file locking in the Maven local repo. I used ParallelParameterized tests, I can do it again, but due to the Maven 3.2.x locks artifacts, ParallelParameterized won't be used. There is nothing to do with Resolver or whatever. As explained in the description the goal is to be able to use `mvn -Tx` or `mvnd` to have a faster build (some modules can definitely be build in parallel). But doing that `surefire-its` is build from the start as it doesn't have any dependencies declared to the modules it will test! Which definitely doesn't reflect what the module needs to be build first. As far I can tell the surefire-its test modules which test the maven-surefire-plugin and maven-failsafe-plugin definitely depends on the plugins to be build first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy edited a comment on pull request #479: test hacking depedencies and build plan to be able to use -T3 or mvnd
olamy edited a comment on pull request #479: URL: https://github.com/apache/maven-surefire/pull/479#issuecomment-1055863568 > @olamy This does not make sense. First of all the Maven should have very stable **Resolver** avoiding file locking in the Maven local repo. I used ParallelParameterized tests, I can do it again, but due to the Maven 3.2.x locks artifacts, ParallelParameterized won't be used. Dear @Tibor17 There is nothing to do with Resolver or whatever. As explained in the description the goal is to be able to use `mvn -Tx` or `mvnd` to have a faster build (some modules can definitely be build in parallel). But doing that `surefire-its` is build from the start as it doesn't have any dependencies declared to the modules it will test! Which definitely doesn't reflect what the module needs to be build first. As far I can tell the surefire-its test modules which test the maven-surefire-plugin and maven-failsafe-plugin definitely depends on the plugins to be build first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #478: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true
olamy commented on a change in pull request #478:
URL: https://github.com/apache/maven-surefire/pull/478#discussion_r817166587
##
File path:
surefire-its/src/test/resources/surefire-1426-ignore-fail-jvm-crash/pom.xml
##
@@ -0,0 +1,49 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ 4.0.0
+
+ org.apache.maven.plugins.surefire
+ SUREFIRE-1426
+ 1.0-SNAPSHOT
+ SUREFIRE-1426
+
+
+1.8
+1.8
+
+
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+${surefire.version}
+
+ -Dfile.encoding=UTF-8 -Duser.language=en -XFFOOOBEEER
-Duser.region=US -showversion -Xmx6g -Xms2g -XX:+PrintGCDetails
Review comment:
> There are multiple use cases for `maven.test.failure.ignore`. This
test with `-XFFOOOBEEER` already exists in
`Surefire735ForkFailWithRedirectConsoleOutputIT`. Of course it must not be
modified. You can only add a new test method and add the system property
`maven.test.failure.ignore`.
none with both `maven.test.failure.ignore` and jvm crash.
is there a real problem adding a new test and name it with the JIra ID?
> And why `-Xmx6g -Xms2g`? No idea!
why? the jvm doesn't even start because of a wrong parameter.
It could have been even `-Xmx128g -Xms64g` **THE JVM DO NOT START ON PURPOSE
FOR THE TEST**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 commented on a change in pull request #482:
URL: https://github.com/apache/maven-surefire/pull/482#discussion_r817167667
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
##
@@ -282,13 +281,6 @@ public void testExecutionSkippedByUser()
{
}
-public RunMode markAs( RunMode currentRunMode )
-{
-RunMode runMode = this.runMode;
-this.runMode = requireNonNull( currentRunMode );
Review comment:
Thx, done :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 commented on a change in pull request #482:
URL: https://github.com/apache/maven-surefire/pull/482#discussion_r817169311
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
##
@@ -282,13 +281,6 @@ public void testExecutionSkippedByUser()
{
}
-public RunMode markAs( RunMode currentRunMode )
-{
-RunMode runMode = this.runMode;
-this.runMode = requireNonNull( currentRunMode );
Review comment:
The RunMode will be finally removed in AbstractStandardStreamEvent and
EventChannelEncoder in the SUREFIRE-2014.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 commented on pull request #482: URL: https://github.com/apache/maven-surefire/pull/482#issuecomment-1055895652 @slawekjaranowski Javadoc was added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MDEP-795) Update Jetty to 9.4.45.v20220203
Jorge Solórzano created MDEP-795: Summary: Update Jetty to 9.4.45.v20220203 Key: MDEP-795 URL: https://issues.apache.org/jira/browse/MDEP-795 Project: Maven Dependency Plugin Issue Type: Task Affects Versions: 3.2.0 Reporter: Jorge Solórzano New release of Jetty -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (SUREFIRE-2015) Implement testRunId and RunMode in the SimpleReportEntry
[ https://issues.apache.org/jira/browse/SUREFIRE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-2015: --- Description: This ticketis the most important in SUREFIRE-1860 because it implements RunMode and testRunId in the ReportEntry, TestSetReportEntry, SimpleReportEntry, CategorizedReportEntry and WrappedReportEntry in appropriate implementation form. Additionally, we should distinguish between two events (OutputReportEntry, TestOutputReportEntry) and therefore the interface TestReportListener handles them via generics dependeing on the situation. The first situation happens when provider's listeners handles the event OutputReportEntry from System.out and System.err via the ConsoleOutputCapture. The ConsoleOutputCapture does not have any notion about runMode and testRunId, and therefore the only provider's listener would add runMode and testRunId to a recreated entry which would be finally propagated to the ForkingRunListener and TestSetRunListener. The runMode and testRunId are determined opon the events testStarted and any test end and Thread local. The second situation happens when ForkingRunListener and TestSetRunListener handles TestOutputReportEntry which contains runMode and testRunId. Some classes are deprecated in the module surefire-junit47 and can be freely removed after the XML Reporter would be fully capable of parallel tests (must support events chaos in one thread). That's the reason why parallel tests are badly handled in JUnit5 reports. The provider surefire-junit47 also supports parallel tests and we do not see the problem with undeterministic XML report, but the reason is that the provider has a cache, eats the memory including the std/out logs and all the messages and test events are replayed in a sequence as if the tests were executed in one thread. > Implement testRunId and RunMode in the SimpleReportEntry > > > Key: SUREFIRE-2015 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2015 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > > This ticketis the most important in SUREFIRE-1860 because it implements > RunMode and testRunId in the ReportEntry, TestSetReportEntry, > SimpleReportEntry, CategorizedReportEntry and WrappedReportEntry in > appropriate implementation form. > Additionally, we should distinguish between two events (OutputReportEntry, > TestOutputReportEntry) and therefore the interface TestReportListener handles > them via generics dependeing on the situation. > The first situation happens when provider's listeners handles the event > OutputReportEntry from System.out and System.err via the > ConsoleOutputCapture. The ConsoleOutputCapture does not have any notion about > runMode and testRunId, and therefore the only provider's listener would add > runMode and testRunId to a recreated entry which would be finally propagated > to the ForkingRunListener and TestSetRunListener. The runMode and testRunId > are determined opon the events testStarted and any test end and Thread local. > The second situation happens when ForkingRunListener and TestSetRunListener > handles TestOutputReportEntry which contains runMode and testRunId. > Some classes are deprecated in the module surefire-junit47 and can be freely > removed after the XML Reporter would be fully capable of parallel tests (must > support events chaos in one thread). That's the reason why parallel tests are > badly handled in JUnit5 reports. The provider surefire-junit47 also supports > parallel tests and we do not see the problem with undeterministic XML report, > but the reason is that the provider has a cache, eats the memory including > the std/out logs and all the messages and test events are replayed in a > sequence as if the tests were executed in one thread. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-dependency-plugin] jorsol opened a new pull request #202: [MDEP-795] - Update Jetty to 9.4.45.v20220203
jorsol opened a new pull request #202: URL: https://github.com/apache/maven-dependency-plugin/pull/202 Update Jetty to 9.4.45.v20220203 and also ignore in `dependabot.yml` the versions >= 10 of Jetty as are Java 11+ only (dependabot should open PRs only for versions 9.x that are compatible with Java 8) Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #97: Bump actions/checkout from 2 to 3
dependabot[bot] opened a new pull request #97: URL: https://github.com/apache/maven-jlink-plugin/pull/97 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v3.0.0 Update default runtime to node16 v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies v2.3.4 https://github-redirect.dependabot.com/actions/checkout/pull/379";>Add missing awaits https://github-redirect.dependabot.com/actions/checkout/pull/360";>Swap to Environment Files v2.3.3 https://github-redirect.dependabot.com/actions/checkout/pull/345";>Remove Unneeded commit information from build logs https://github-redirect.dependabot.com/actions/checkout/pull/326";>Add Licensed to verify third party dependencies v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320";>Add Third Party License Information to Dist Files v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284";>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278";>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258";>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236";>here and https://github-redirect.dependabot.com/actions/checkout/pull/248";>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191";>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199";>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184";>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163";>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179";>Convert submodule SSH URL to HTTPS, when not using SSH https://github-redirect.dependabot.com/actions/checkout/pull/157";>Add submodule support https://github-redirect.dependabot.com/actions/checkout/pull/144";>Follow proxy settings https://github-redirect.dependabot.com/actions/checkout/pull/141";>Fix ref for pr closed event when a pr is merged https://github-redirect.dependabot.com/actions/checkout/pull/128";>Fix issue checking detached when git less than 2.22 Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md";>actions/checkout's changelog. Changelog v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284";>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278";>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258";>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236";>here and https://github-redirect.dependabot.com/actions/checkout/pull/248";>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191";>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199";>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184";>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163";>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179";>Convert submodule SSH URL to HTTPS, when not using SSH https://github-redirect.dependabot.com/actions/checkout/pull/157";>Add submodule support https://github-redirect.dependabot.com/actions/checkout/pull/144";>Follow proxy settings https://github-redirect.dependabot.com/actions/checkout/pull/141";>Fix ref for pr closed event when a pr is merged https://github-redirect.dependabot.com/actions/checkout/pull/128";>Fix issue checking detached when git less than 2.22 v2.0.0 https://github-redirect.dependabot.com/actions/checkout/pull/108";>Do not pass cred on command line https://github-redirect.dependabot.com/actions/checkout/pull/107";>Add input persist-credentials https://github-redirect.dependabot.com/actions/checkout/pull/104";>Fallback to REST API to download repo Commits https://github.com/actions/checkout/commit/a12a3943b4bdde767164f792f33f40b04645d846";>a12a394 update readme for v3 (https://github-redirect.dependabot.com/actions/checkout/issues/708";>#708) https://github.co
[GitHub] [maven-surefire] Tibor17 commented on pull request #460: Add some javadoc and unit tests to includesFile and excludesFile
Tibor17 commented on pull request #460: URL: https://github.com/apache/maven-surefire/pull/460#issuecomment-1055917275 @imonteroperez I am working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MSHARED-1040) Require Java 8
[ https://issues.apache.org/jira/browse/MSHARED-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MSHARED-1040: Assignee: Slawomir Jaranowski > Require Java 8 > -- > > Key: MSHARED-1040 > URL: https://issues.apache.org/jira/browse/MSHARED-1040 > Project: Maven Shared Components > Issue Type: Task > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] slawekjaranowski commented on pull request #479: test hacking depedencies and build plan to be able to use -T3 or mvnd
slawekjaranowski commented on pull request #479: URL: https://github.com/apache/maven-surefire/pull/479#issuecomment-1055921121 related issue https://issues.apache.org/jira/browse/SUREFIRE-1956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] bmarwell commented on a change in pull request #291: Example alignment for methods arguments
bmarwell commented on a change in pull request #291: URL: https://github.com/apache/maven-site/pull/291#discussion_r817193582 ## File path: content/resources/developers/maven-idea-codestyle.xml ## @@ -92,6 +92,7 @@ under the License. + Review comment: ` ` to chop down parameters on method declarations if too long for a single line. and maybe ` ` for calls. At least METHOD_PARAMETERS_WRAP is missing anyway, set it to something like "wrap" (I don't know which number though). ## File path: content/apt/developers/conventions/code.apt ## @@ -126,11 +126,26 @@ public class MyMojo // -- ... +// multiline arguments should be aligned for method declaration +protected void methodOne( String arg1, String arg2, + String arg3, String arg4 ) Review comment: I'd prefer to "chop down" all. Either they fit in one line, or they don't. This is a suggestion to mix, which might result in more diff than needed (when refactoring). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker] slawekjaranowski opened a new pull request #45: [MSHARED-1040] Require Java 8
slawekjaranowski opened a new pull request #45: URL: https://github.com/apache/maven-invoker/pull/45 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/MSHARED) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on pull request #479: test hacking depedencies and build plan to be able to use -T3 or mvnd
olamy commented on pull request #479: URL: https://github.com/apache/maven-surefire/pull/479#issuecomment-1056003349 > related issue https://issues.apache.org/jira/browse/SUREFIRE-1956 definitely related @Tibor17 just run `mvn clean verify -pl :surefire-its -am` and you will see dependencies are not declared correctly with master ``` ➜ maven-surefire git:(master) mvn clean verify -pl :surefire-its -am [INFO] Scanning for projects... [INFO] [INFO] Reactor Build Order: [INFO] [INFO] Apache Maven Surefire [pom] [INFO] Maven Surefire Integration Tests [jar] [INFO] [INFO] -< org.apache.maven.surefire:surefire >- [INFO] Building Apache Maven Surefire 3.0.0-M6-SNAPSHOT [1/2] [INFO] [ pom ]- ``` with this branch: ``` ➜ maven-surefire git:(multithread-build-possible) mvn clean verify -pl :surefire-its -am [INFO] Scanning for projects... [INFO] [INFO] Reactor Build Order: [INFO] [INFO] Apache Maven Surefire [pom] [INFO] Surefire Shared Utils [jar] [INFO] SureFire Logger API [jar] [INFO] SureFire API [jar] [INFO] Surefire Extensions API [jar] [INFO] Surefire Extensions SPI [jar] [INFO] SureFire Booter [jar] [INFO] Maven Surefire Common [jar] [INFO] Surefire Report Parser [jar] [INFO] Maven Surefire Plugin [maven-plugin] [INFO] Maven Failsafe Plugin [maven-plugin] [INFO] Maven Surefire Report Plugin [maven-plugin] [INFO] Maven Surefire Integration Tests [jar] ``` it is more correct but still wrong as this should include everything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request #35: Bump actions/checkout from 2.4.0 to 3
dependabot[bot] opened a new pull request #35: URL: https://github.com/apache/maven-gh-actions-shared/pull/35 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v3.0.0 Update default runtime to node16 Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md";>actions/checkout's changelog. Changelog v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284";>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278";>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258";>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236";>here and https://github-redirect.dependabot.com/actions/checkout/pull/248";>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191";>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199";>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184";>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163";>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179";>Convert submodule SSH URL to HTTPS, when not using SSH https://github-redirect.dependabot.com/actions/checkout/pull/157";>Add submodule support https://github-redirect.dependabot.com/actions/checkout/pull/144";>Follow proxy settings https://github-redirect.dependabot.com/actions/checkout/pull/141";>Fix ref for pr closed event when a pr is merged https://github-redirect.dependabot.com/actions/checkout/pull/128";>Fix issue checking detached when git less than 2.22 v2.0.0 https://github-redirect.dependabot.com/actions/checkout/pull/108";>Do not pass cred on command line https://github-redirect.dependabot.com/actions/checkout/pull/107";>Add input persist-credentials https://github-redirect.dependabot.com/actions/checkout/pull/104";>Fallback to REST API to download repo v2 (beta) Improved fetch performance The default behavior now fetches only the SHA being checked-out Script authenticated git commands Persists with.token in the local git config Enables your scripts to run authenticated git commands Post-job cleanup removes the token Coming soon: Opt out by setting with.persist-credentials to false Creates a local branch No longer detached HEAD when checking out a branch A local branch is created with the corresponding upstream branch set Improved layout ... (truncated) Commits https://github.com/actions/checkout/commit/a12a3943b4bdde767164f792f33f40b04645d846";>a12a394 update readme for v3 (https://github-redirect.dependabot.com/actions/checkout/issues/708";>#708) https://github.com/actions/checkout/commit/8f9e05e482293f862823fcca12d9eddfb3723131";>8f9e05e Update to node 16 (https://github-redirect.dependabot.com/actions/checkout/issues/689";>#689) https://github.com/actions/checkout/commit/230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7";>230611d Change secret name for PAT to not start with GITHUB_ (https://github-redirect.dependabot.com/actions/checkout/issues/623";>#623) See full diff in https://github.com/actions/checkout/compare/v2.4.0...v3";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` wil
[GitHub] [maven-gh-actions-shared] dependabot[bot] opened a new pull request #36: Bump actions/checkout from 2.4.0 to 3
dependabot[bot] opened a new pull request #36: URL: https://github.com/apache/maven-gh-actions-shared/pull/36 Bumps [actions/checkout](https://github.com/actions/checkout) from 2.4.0 to 3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v3.0.0 Update default runtime to node16 Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md";>actions/checkout's changelog. Changelog v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284";>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278";>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258";>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236";>here and https://github-redirect.dependabot.com/actions/checkout/pull/248";>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191";>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199";>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184";>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163";>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179";>Convert submodule SSH URL to HTTPS, when not using SSH https://github-redirect.dependabot.com/actions/checkout/pull/157";>Add submodule support https://github-redirect.dependabot.com/actions/checkout/pull/144";>Follow proxy settings https://github-redirect.dependabot.com/actions/checkout/pull/141";>Fix ref for pr closed event when a pr is merged https://github-redirect.dependabot.com/actions/checkout/pull/128";>Fix issue checking detached when git less than 2.22 v2.0.0 https://github-redirect.dependabot.com/actions/checkout/pull/108";>Do not pass cred on command line https://github-redirect.dependabot.com/actions/checkout/pull/107";>Add input persist-credentials https://github-redirect.dependabot.com/actions/checkout/pull/104";>Fallback to REST API to download repo v2 (beta) Improved fetch performance The default behavior now fetches only the SHA being checked-out Script authenticated git commands Persists with.token in the local git config Enables your scripts to run authenticated git commands Post-job cleanup removes the token Coming soon: Opt out by setting with.persist-credentials to false Creates a local branch No longer detached HEAD when checking out a branch A local branch is created with the corresponding upstream branch set Improved layout ... (truncated) Commits https://github.com/actions/checkout/commit/a12a3943b4bdde767164f792f33f40b04645d846";>a12a394 update readme for v3 (https://github-redirect.dependabot.com/actions/checkout/issues/708";>#708) https://github.com/actions/checkout/commit/8f9e05e482293f862823fcca12d9eddfb3723131";>8f9e05e Update to node 16 (https://github-redirect.dependabot.com/actions/checkout/issues/689";>#689) https://github.com/actions/checkout/commit/230611dbd0eb52da1e1f4f7bc8bb0c3a339fc8b7";>230611d Change secret name for PAT to not start with GITHUB_ (https://github-redirect.dependabot.com/actions/checkout/issues/623";>#623) See full diff in https://github.com/actions/checkout/compare/v2.4.0...v3";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` wil
[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request #122: Bump actions/checkout from 2 to 3
dependabot[bot] opened a new pull request #122: URL: https://github.com/apache/maven-javadoc-plugin/pull/122 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. Release notes Sourced from https://github.com/actions/checkout/releases";>actions/checkout's releases. v3.0.0 Update default runtime to node16 v2.4.0 Convert SSH URLs like org-@github.com: to https://github.com/ - https://github-redirect.dependabot.com/actions/checkout/pull/621";>pr v2.3.5 Update dependencies v2.3.4 https://github-redirect.dependabot.com/actions/checkout/pull/379";>Add missing awaits https://github-redirect.dependabot.com/actions/checkout/pull/360";>Swap to Environment Files v2.3.3 https://github-redirect.dependabot.com/actions/checkout/pull/345";>Remove Unneeded commit information from build logs https://github-redirect.dependabot.com/actions/checkout/pull/326";>Add Licensed to verify third party dependencies v2.3.2 https://github-redirect.dependabot.com/actions/checkout/pull/320";>Add Third Party License Information to Dist Files v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284";>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278";>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258";>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236";>here and https://github-redirect.dependabot.com/actions/checkout/pull/248";>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191";>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199";>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184";>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163";>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179";>Convert submodule SSH URL to HTTPS, when not using SSH https://github-redirect.dependabot.com/actions/checkout/pull/157";>Add submodule support https://github-redirect.dependabot.com/actions/checkout/pull/144";>Follow proxy settings https://github-redirect.dependabot.com/actions/checkout/pull/141";>Fix ref for pr closed event when a pr is merged https://github-redirect.dependabot.com/actions/checkout/pull/128";>Fix issue checking detached when git less than 2.22 Changelog Sourced from https://github.com/actions/checkout/blob/main/CHANGELOG.md";>actions/checkout's changelog. Changelog v2.3.1 https://github-redirect.dependabot.com/actions/checkout/pull/284";>Fix default branch resolution for .wiki and when using SSH v2.3.0 https://github-redirect.dependabot.com/actions/checkout/pull/278";>Fallback to the default branch v2.2.0 https://github-redirect.dependabot.com/actions/checkout/pull/258";>Fetch all history for all tags and branches when fetch-depth=0 v2.1.1 Changes to support GHES (https://github-redirect.dependabot.com/actions/checkout/pull/236";>here and https://github-redirect.dependabot.com/actions/checkout/pull/248";>here) v2.1.0 https://github-redirect.dependabot.com/actions/checkout/pull/191";>Group output https://github-redirect.dependabot.com/actions/checkout/pull/199";>Changes to support GHES alpha release https://github-redirect.dependabot.com/actions/checkout/pull/184";>Persist core.sshCommand for submodules https://github-redirect.dependabot.com/actions/checkout/pull/163";>Add support ssh https://github-redirect.dependabot.com/actions/checkout/pull/179";>Convert submodule SSH URL to HTTPS, when not using SSH https://github-redirect.dependabot.com/actions/checkout/pull/157";>Add submodule support https://github-redirect.dependabot.com/actions/checkout/pull/144";>Follow proxy settings https://github-redirect.dependabot.com/actions/checkout/pull/141";>Fix ref for pr closed event when a pr is merged https://github-redirect.dependabot.com/actions/checkout/pull/128";>Fix issue checking detached when git less than 2.22 v2.0.0 https://github-redirect.dependabot.com/actions/checkout/pull/108";>Do not pass cred on command line https://github-redirect.dependabot.com/actions/checkout/pull/107";>Add input persist-credentials https://github-redirect.dependabot.com/actions/checkout/pull/104";>Fallback to REST API to download repo Commits https://github.com/actions/checkout/commit/a12a3943b4bdde767164f792f33f40b04645d846";>a12a394 update readme for v3 (https://github-redirect.dependabot.com/actions/checkout/issues/708";>#708) https://githu
[GitHub] [maven-parent] dependabot[bot] opened a new pull request #57: Bump maven-pmd-plugin from 3.15.0 to 3.16.0
dependabot[bot] opened a new pull request #57: URL: https://github.com/apache/maven-parent/pull/57 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.15.0 to 3.16.0. Release notes Sourced from https://github.com/apache/maven-pmd-plugin/releases";>maven-pmd-plugin's releases. 3.16.0 🐛 Bug Fixes https://issues.apache.org/jira/browse/MPMD-325";>[MPMD-325] Could not find class due to IncompatibleClassChangeError warning https://issues.apache.org/jira/browse/MPMD-324";>[MPMD-324] Ruleset URLs have hyphen replaced with forwardslash https://issues.apache.org/jira/browse/MPMD-323";>[MPMD-323] ResourceManager should use project base dir instead of pom location 🔧 Build https://issues.apache.org/jira/browse/MPMD-328";>[MPMD-328] Shared GitHub Actions 🚀 New features and improvements https://issues.apache.org/jira/browse/MPMD-327";>[MPMD-327] Upgrade to PMD 6.42.0 📦 Dependency updates https://issues.apache.org/jira/browse/MPMD-326";>[MPMD-326] Set Maven 3.1.1 as minimum version Commits https://github.com/apache/maven-pmd-plugin/commit/b8a794e37e4cb3bb986ce044f3ef8df0dd392ed1";>b8a794e [maven-release-plugin] prepare release maven-pmd-plugin-3.16.0 https://github.com/apache/maven-pmd-plugin/commit/6fc39ec2428a9fd68319da39f89d2191ac3ad25b";>6fc39ec [MPMD-323] ResourceManager should use project base dir instead of pom https://github.com/apache/maven-pmd-plugin/commit/4eae72c6c6f394c0c65fc4994eead9d06a6544f2";>4eae72c [MPMD-324] Ruleset URLs have hyphen replaced with forwardslash https://github.com/apache/maven-pmd-plugin/commit/64e35f73c27107c192b33b856f549fa66953b305";>64e35f7 Make maven core provided scope https://github.com/apache/maven-pmd-plugin/commit/1dd8d0007fcf5d48571b9483bd3865a57d8e5383";>1dd8d00 [MPMD-327] Upgrade to PMD 6.42.0 https://github.com/apache/maven-pmd-plugin/commit/fae45251df926bb2e91ac14914b374c5f0ed28ed";>fae4525 [MPMD-327] Upgrade to PMD 6.41.0 https://github.com/apache/maven-pmd-plugin/commit/80e8aabe537063ddb64887c4dc18ca6c91be19e8";>80e8aab (doc) Update README.md https://github.com/apache/maven-pmd-plugin/commit/3fffd9cc7c0bea9ddd8489c9a7b4fee264d2d2c0";>3fffd9c [MPMD-328] Shared Github Actions (https://github-redirect.dependabot.com/apache/maven-pmd-plugin/issues/48";>#48) https://github.com/apache/maven-pmd-plugin/commit/2175d5e3936d0f4718da6f890a442cfc60cd617e";>2175d5e [MPMD-327] Upgrade to PMD 6.40.0 https://github.com/apache/maven-pmd-plugin/commit/b8ac1fbc41b2b7e69bb6d8c0a336119e8fdd2d26";>b8ac1fb [MPMD-327] Upgrade to PMD 6.39.0 Additional commits viewable in https://github.com/apache/maven-pmd-plugin/compare/maven-pmd-plugin-3.15.0...maven-pmd-plugin-3.16.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service,
[GitHub] [maven-jlink-plugin] dependabot[bot] commented on pull request #90: Bump maven-compiler-plugin from 3.8.1 to 3.9.0
dependabot[bot] commented on pull request #90: URL: https://github.com/apache/maven-jlink-plugin/pull/90#issuecomment-1056205761 Superseded by #98. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] closed pull request #90: Bump maven-compiler-plugin from 3.8.1 to 3.9.0
dependabot[bot] closed pull request #90: URL: https://github.com/apache/maven-jlink-plugin/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #98: Bump maven-compiler-plugin from 3.8.1 to 3.10.0
dependabot[bot] opened a new pull request #98: URL: https://github.com/apache/maven-jlink-plugin/pull/98 Bumps [maven-compiler-plugin](https://github.com/apache/maven-compiler-plugin) from 3.8.1 to 3.10.0. Release notes Sourced from https://github.com/apache/maven-compiler-plugin/releases";>maven-compiler-plugin's releases. 3.10.0 🚨 Removed https://issues.apache.org/jira/browse/MCOMPILER-484";>[MCOMPILER-484] - Remove deprecated mojos (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/87";>#87) https://github.com/gnodet";>@gnodet 🚀 New features and improvements https://issues.apache.org/jira/browse/MCOMPILER-205";>[MCOMPILER-205] - Add a boolean to generate missing package-info classes by default (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/88";>#88) https://github.com/gnodet";>@gnodet https://issues.apache.org/jira/browse/MCOMPILER-474";>[MCOMPILER-474] - Also check jar files when determining if dependencies changed (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/73";>#73) https://github.com/Powerrr";>@Powerrr 🐛 Bug Fixes https://issues.apache.org/jira/browse/MCOMPILER-225";>[MCOMPILER-225] - javac.sh/javac.bat added to archive (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/91";>#91) https://github.com/olamy";>@olamy https://issues.apache.org/jira/browse/MCOMPILER-481";>[MCOMPILER-481] - compiler plugin should include static module for compilation (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/82";>#82) https://github.com/olamy";>@olamy https://issues.apache.org/jira/browse/MCOMPILER-470";>[MCOMPILER-470] -parameters doesn't work with --release https://issues.apache.org/jira/browse/MCOMPILER-460";>[MCOMPILER-460] - Compiler doesn't show detailed information with the Maven Toolchains 📦 Dependency updates use plexus-compiler 2.10.0 (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/92";>#92) https://github.com/olamy";>@olamy Bump mockito-core from 4.2.0 to 4.3.1 (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/83";>#83) https://github.com/dependabot";>@dependabot 📝 Documentation updates https://issues.apache.org/jira/browse/MCOMPILER-479";>[MCOMPILER-479] - Clarify compiler arguments Javadoc (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/90";>#90) https://github.com/hisener";>@hisener (doc) Fix typo and follow xml block style used for other parameters (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/89";>#89) https://github.com/pzygielo";>@pzygielo 🔧 Build add more jdk for testing (https://github-redirect.dependabot.com/apache/maven-compiler-plugin/issues/93";>#93) https://github.com/olamy";>@olamy 3.9.0 Content might be not complete What's Changed [MCOMPILER-341] Compile module descriptors with TestCompilerMojo by https://github.com/sormuras";>@sormuras in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/4";>apache/maven-compiler-plugin#4 [MCOMPILER-349] - changed dependency detection. by https://github.com/atsyganenko";>@atsyganenko in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/6";>apache/maven-compiler-plugin#6 [MCOMPILER-360] nullpointer exception by https://github.com/brychcy";>@brychcy in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/7";>apache/maven-compiler-plugin#7 [MCOMPILER-306] Fix compilerArgs example usage by https://github.com/Stephan202";>@Stephan202 in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/9";>apache/maven-compiler-plugin#9 (doc) Fixed broken links to scm, issue tracker, and mailing list page. by https://github.com/hendriks73";>@hendriks73 in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/15";>apache/maven-compiler-plugin#15 Fix typos by https://github.com/geoand";>@geoand in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/16";>apache/maven-compiler-plugin#16 Miscellaneous code cleanups by https://github.com/rhowe";>@rhowe in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/17";>apache/maven-compiler-plugin#17 [MCOMPILER-349] cleanups by https://github.com/rhowe";>@rhowe in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/18";>apache/maven-compiler-plugin#18 (doc) Use !isEmpty() instead of size() > 0 by https://github.com/rhowe";>@rhowe in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/20";>apache/maven-compiler-plugin#20 Cleanup debug log handling by https://github.com/rhowe";>@rhowe in https://github-redirect.dependabot.com/apache/maven-compiler-plugin/pull/21";>apache/maven-compiler-plugin#21
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
slawekjaranowski commented on a change in pull request #480: URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817379420 ## File path: Jenkinsfile ## @@ -30,7 +30,7 @@ properties( ] ) final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.2.x', '3.8.x'] : ['3.8.x'] Review comment: the first version of maven will be used to deploy artifacts - maybe better is use the latest version to deploy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #480: Test only with 2 last Maven core 3.6.x and 3.8.x, avoid deep scanning to find jacoco files
olamy commented on a change in pull request #480: URL: https://github.com/apache/maven-surefire/pull/480#discussion_r817391997 ## File path: Jenkinsfile ## @@ -30,7 +30,7 @@ properties( ] ) final def oses = ['linux':'ubuntu && maven', 'windows':'windows-he'] -final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.2.x'] +final def mavens = env.BRANCH_NAME == 'master' ? ['3.2.x', '3.8.x'] : ['3.8.x'] Review comment: good point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #479: test hacking depedencies and build plan to be able to use -T3 or mvnd
slawekjaranowski commented on a change in pull request #479:
URL: https://github.com/apache/maven-surefire/pull/479#discussion_r817394759
##
File path: surefire-its/pom.xml
##
@@ -241,6 +262,27 @@
+
+org.apache.maven.plugins
+maven-invoker-plugin
+
+
${settings.localRepository}
+
+
org.apache.maven.plugins:maven-surefire-report-plugin:${project.version}
+
org.apache.maven.plugins:maven-surefire-plugin:${project.version}
+
org.apache.maven.plugins:maven-failsafe-plugin:${project.version}
+
Review comment:
invoker:install also install all project dependencies with transitive
with scope compile + runtime to local-repo,
so we can skip extraArtifacts if change scope to runtime of those
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] olamy commented on a change in pull request #479: test hacking depedencies and build plan to be able to use -T3 or mvnd
olamy commented on a change in pull request #479:
URL: https://github.com/apache/maven-surefire/pull/479#discussion_r817414558
##
File path: surefire-its/pom.xml
##
@@ -241,6 +262,27 @@
+
+org.apache.maven.plugins
+maven-invoker-plugin
+
+
${settings.localRepository}
+
+
org.apache.maven.plugins:maven-surefire-report-plugin:${project.version}
+
org.apache.maven.plugins:maven-surefire-plugin:${project.version}
+
org.apache.maven.plugins:maven-failsafe-plugin:${project.version}
+
Review comment:
correct.
Ideally I'd like to run those IT tests with an empty repo.
So still a bit of work but on it ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MWAR-448) packaging dependencies fails with "mvn install" but not "mvn package"
[ https://issues.apache.org/jira/browse/MWAR-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MWAR-448: Fix Version/s: waiting-for-feedback > packaging dependencies fails with "mvn install" but not "mvn package" > - > > Key: MWAR-448 > URL: https://issues.apache.org/jira/browse/MWAR-448 > Project: Maven WAR Plugin > Issue Type: Bug >Affects Versions: 3.3.2 > Environment: maven 3.6.3 ( later versions have bugs which we can't > take in) >Reporter: Kari J. Niemi >Priority: Minor > Fix For: waiting-for-feedback > > > I think we discovered a minor odd difference with war-packaging between "mvn > package" or "mvn install". We would expect that only difference between the > two is that the latter also installs the produced stuff in the local maven > repository. > > We are packaging a few jars to a war. We have a parent pom with some modules, > and that is defined as a dependency in the pom.xml that produces a > war-package. Like this: > my-war-thingie:pom.xml (packaging:war) > * dependency: some-parent > some-parent:pom.xml (packaging:pom) > * module1 (packaging:jar) > * module2 (packaging:jar) > Earlier we had a different structure and everything was just fine: we did not > the have the child-modules but the parent-pom produced the jar. When we > changed the structure to the one described above: our CI was still OK, some > developers building OK as well -but some developers had failing maven builds > because of missing "some-parent.jar". > > It was bit of devastating hunt, but finally we discovered that "mvn package" > was building OK, but "mvn install" looks for "some-parent.jar". > We don't actually mind if the above scenario would fail in both cases, or if > it was successful - we would just expect that it works the same way for both. > If this is intended behaviour, it would be nice to have it documented. > FWIW: in our case, we anyway wanted to define direct dependencies from the > war-packaging to the child-modules. So actually, we are OK wih our builds > already. But the difference caused so may doubts about our builds > reproducibility - and also, it seems like a bug - so I wanted to be good > citizen and report the problem. > Edit: further note from our troubleshooting sessions: we don't have the > "type" for the dependency at all in my-war-thingie:pom.xml. Yesterday, we did > experiment setting the type as "pom" -and as a consequence, both "mvn > package" and "mvn install" were successful. The default as we know, > should/would be "jar". Maybe the missing dependency type is for some odd > reason resolved differently for "maven package" and "maven install"? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #291: Example alignment for methods arguments
slawekjaranowski commented on a change in pull request #291: URL: https://github.com/apache/maven-site/pull/291#discussion_r817424824 ## File path: content/apt/developers/conventions/code.apt ## @@ -126,11 +126,26 @@ public class MyMojo // -- ... +// multiline arguments should be aligned for method declaration +protected void methodOne( String arg1, String arg2, + String arg3, String arg4 ) Review comment: it is only example show position if wrapping, of course if args fit in one line shouldn't be wrap -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #291: Example alignment for methods arguments
slawekjaranowski commented on a change in pull request #291: URL: https://github.com/apache/maven-site/pull/291#discussion_r817426608 ## File path: content/resources/developers/maven-idea-codestyle.xml ## @@ -92,6 +92,7 @@ under the License. + Review comment: I see that Intellij don't export default values ... 😄 i will try mentioned configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6806) Provide Maven BOM
[
https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499945#comment-17499945
]
Konrad Windszus commented on MNG-6806:
--
This would be really helpful to backport also to 3.8.x/3.9.x, as Maven plugins
only supporting Maven 4 won't appear anytime soon I guess.
> Provide Maven BOM
> -
>
> Key: MNG-6806
> URL: https://issues.apache.org/jira/browse/MNG-6806
> Project: Maven
> Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> Maven libraries should always have the same version to ensure they work as
> expected, hence the preferred way to manage that is with a bom.
> Let's introduce the {{maven-dependencies}}, a
> [bom|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies]
> for Maven dependencies. We will likely need the same for plugins.
> See https://www.baeldung.com/spring-maven-bom about how to write and use the
> bom.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-ear-plugin] slawekjaranowski merged pull request #52: [MEAR-302] Support JakartaEE 9 schema
slawekjaranowski merged pull request #52: URL: https://github.com/apache/maven-ear-plugin/pull/52 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MEAR-302) jakarta EE 9 EAR compatibility
[ https://issues.apache.org/jira/browse/MEAR-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MEAR-302: Assignee: Slawomir Jaranowski (was: Olivier Lamy) > jakarta EE 9 EAR compatibility > -- > > Key: MEAR-302 > URL: https://issues.apache.org/jira/browse/MEAR-302 > Project: Maven EAR Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.2.0 > Environment: windows > glassfish 6.1 > jdk-15.0.0.36-hotspot >Reporter: Dionysos >Assignee: Slawomir Jaranowski >Priority: Major > Attachments: testapp.zip > > > Hi! I've created this issue and attached a sample project as asked. > On this one the war is getting packaged but again I cannot deploy it whatever > I tried. > > Relative correspondence in users mailing list here: > https://lists.apache.org/thread.html/r498322ab35e9e703f9e9735cf10c31959654f54ec85717cbd7aa84d7%40 > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MEAR-302) jakarta EE 9 EAR compatibility
[ https://issues.apache.org/jira/browse/MEAR-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MEAR-302. Fix Version/s: 3.3.0 Resolution: Fixed > jakarta EE 9 EAR compatibility > -- > > Key: MEAR-302 > URL: https://issues.apache.org/jira/browse/MEAR-302 > Project: Maven EAR Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.2.0 > Environment: windows > glassfish 6.1 > jdk-15.0.0.36-hotspot >Reporter: Dionysos >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.3.0 > > Attachments: testapp.zip > > > Hi! I've created this issue and attached a sample project as asked. > On this one the war is getting packaged but again I cannot deploy it whatever > I tried. > > Relative correspondence in users mailing list here: > https://lists.apache.org/thread.html/r498322ab35e9e703f9e9735cf10c31959654f54ec85717cbd7aa84d7%40 > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (MNG-6806) Provide Maven BOM
[
https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499945#comment-17499945
]
Konrad Windszus edited comment on MNG-6806 at 3/2/22, 7:55 AM:
---
This would be really helpful to backport also to 3.8.x/3.9.x, as Maven plugins
only supporting Maven 4 won't appear anytime soon I guess.
It should manage all dependencies being exposed by the Core class loader
(https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml),
this includes third party dependencies like Slf4j API.
was (Author: kwin):
This would be really helpful to backport also to 3.8.x/3.9.x, as Maven plugins
only supporting Maven 4 won't appear anytime soon I guess.
> Provide Maven BOM
> -
>
> Key: MNG-6806
> URL: https://issues.apache.org/jira/browse/MNG-6806
> Project: Maven
> Issue Type: Improvement
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> Maven libraries should always have the same version to ensure they work as
> expected, hence the preferred way to manage that is with a bom.
> Let's introduce the {{maven-dependencies}}, a
> [bom|https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies]
> for Maven dependencies. We will likely need the same for plugins.
> See https://www.baeldung.com/spring-maven-bom about how to write and use the
> bom.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
