bmarwell commented on a change in pull request #291:
URL: https://github.com/apache/maven-site/pull/291#discussion_r817193582
##########
File path: content/resources/developers/maven-idea-codestyle.xml
##########
@@ -92,6 +92,7 @@ under the License.
<option name="ELSE_ON_NEW_LINE" value="true" />
<option name="CATCH_ON_NEW_LINE" value="true" />
<option name="FINALLY_ON_NEW_LINE" value="true" />
+ <option name="ALIGN_MULTILINE_PARAMETERS_IN_CALLS" value="true" />
Review comment:
` <option name="METHOD_PARAMETERS_WRAP" value="5" />`
to chop down parameters on method declarations if too long for a single line.
and maybe
` <option name="CALL_PARAMETERS_WRAP" value="5" />`
for calls.
At least METHOD_PARAMETERS_WRAP is missing anyway, set it to something like
"wrap" (I don't know which number though).
##########
File path: content/apt/developers/conventions/code.apt
##########
@@ -126,11 +126,26 @@ public class MyMojo
// ----------------------------------------------------------------------
...
+ // multiline arguments should be aligned for method declaration
+ protected void methodOne( String arg1, String arg2,
+ String arg3, String arg4 )
Review comment:
I'd prefer to "chop down" all. Either they fit in one line, or they
don't. This is a suggestion to mix, which might result in more diff than needed
(when refactoring).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
