date:20180818

Guillermo González de Agüero created MJLINK-23:
--

 Summary: Allow setting additional modulepaths
 Key: MJLINK-23
 URL: https://issues.apache.org/jira/browse/MJLINK-23
 Project: Maven JLink Plugin
  Issue Type: Bug
Affects Versions: 3.0.0-alpha-2
Reporter: Guillermo González de Agüero


There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ggam opened a new pull request #2: [MJLINK-23] Allow setting additional modulepaths

ggam opened a new pull request #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   There's a modulePaths property but it's missing the @Parameter annotation.
   
   
   I hereby declare this contribution to be licenced under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584714#comment-16584714
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

ggam opened a new pull request #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   There's a modulePaths property but it's missing the @Parameter annotation.
   
   
   I hereby declare this contribution to be licenced under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] erikhakansson commented on a change in pull request #49: [MNG-2802] Concurrent-safe access to local Maven repository

erikhakansson commented on a change in pull request #49: [MNG-2802] 
Concurrent-safe access to local Maven repository
URL: https://github.com/apache/maven-wagon/pull/49#discussion_r211069493
 
 

 ##
 File path: 
wagon-providers/wagon-file-test/src/main/java/org/apache/maven/wagon/providers/file/LazyLockableFileOutputStreamTestDriver.java
 ##
 @@ -0,0 +1,75 @@
+package org.apache.maven.wagon.providers.file;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Test driver for LazyLockableFileOutputStreamIntegrationTest
+ */
+public class LazyLockableFileOutputStreamTestDriver
+{
+public static void main( String[] args ) throws Exception
+{
+File file = new File( args[0] );
+long timeout = Long.parseLong( args[1] );
+long startTime = System.currentTimeMillis();
+OutputStream outputStream = new LazyLockableFileOutputStream( file, 
timeout, TimeUnit.SECONDS );
+try
+{
+outputStream.write( 1 );
+}
+catch ( IOException e )
+{
+if ( e.getMessage().equals( "Can't write file, lock " + 
file.getAbsolutePath() + ".lck exists" ) )
+{
+System.out.println( "ready" );
+// CHECKSTYLE_OFF: MagicNumber
+System.exit( 126 );
+// CHECKSTYLE_ON: MagicNumber
+}
+else if ( e.getMessage().equals( "Failed to create lockfile " + 
file.getAbsolutePath()
++ ".lck after waiting " + timeout + " seconds. File 
already exists." ) )
+{
+long diff = System.currentTimeMillis() - startTime;
+if ( diff < TimeUnit.SECONDS.toMillis( timeout ) )
+{
+throw new Exception( "We were supposed to wait for " + 
timeout
++ " seconds, but Exception came early at " + diff 
+ " milliseconds." );
+}
+System.out.println( "ready" );
+// CHECKSTYLE_OFF: MagicNumber
+System.exit( 127 );
 
 Review comment:
   Ah, I was not aware of that! But since the 
LazyLockableFileOutputStreamTestDriver isn't directly managed by surefire, but 
instead launched in a separate JVM, shouldn't it be quite safe anyway?
   
   It's a very convenient way of reporting results out to the actual test 
without having to read the output stream. Which would be the alternative 
solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-2802) Concurrent-safe access to local Maven repository



[ 
https://issues.apache.org/jira/browse/MNG-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584715#comment-16584715
 ] 

ASF GitHub Bot commented on MNG-2802:
-

erikhakansson commented on a change in pull request #49: [MNG-2802] 
Concurrent-safe access to local Maven repository
URL: https://github.com/apache/maven-wagon/pull/49#discussion_r211069493
 
 

 ##
 File path: 
wagon-providers/wagon-file-test/src/main/java/org/apache/maven/wagon/providers/file/LazyLockableFileOutputStreamTestDriver.java
 ##
 @@ -0,0 +1,75 @@
+package org.apache.maven.wagon.providers.file;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.util.concurrent.TimeUnit;
+
+/**
+ * Test driver for LazyLockableFileOutputStreamIntegrationTest
+ */
+public class LazyLockableFileOutputStreamTestDriver
+{
+public static void main( String[] args ) throws Exception
+{
+File file = new File( args[0] );
+long timeout = Long.parseLong( args[1] );
+long startTime = System.currentTimeMillis();
+OutputStream outputStream = new LazyLockableFileOutputStream( file, 
timeout, TimeUnit.SECONDS );
+try
+{
+outputStream.write( 1 );
+}
+catch ( IOException e )
+{
+if ( e.getMessage().equals( "Can't write file, lock " + 
file.getAbsolutePath() + ".lck exists" ) )
+{
+System.out.println( "ready" );
+// CHECKSTYLE_OFF: MagicNumber
+System.exit( 126 );
+// CHECKSTYLE_ON: MagicNumber
+}
+else if ( e.getMessage().equals( "Failed to create lockfile " + 
file.getAbsolutePath()
++ ".lck after waiting " + timeout + " seconds. File 
already exists." ) )
+{
+long diff = System.currentTimeMillis() - startTime;
+if ( diff < TimeUnit.SECONDS.toMillis( timeout ) )
+{
+throw new Exception( "We were supposed to wait for " + 
timeout
++ " seconds, but Exception came early at " + diff 
+ " milliseconds." );
+}
+System.out.println( "ready" );
+// CHECKSTYLE_OFF: MagicNumber
+System.exit( 127 );
 
 Review comment:
   Ah, I was not aware of that! But since the 
LazyLockableFileOutputStreamTestDriver isn't directly managed by surefire, but 
instead launched in a separate JVM, shouldn't it be quite safe anyway?
   
   It's a very convenient way of reporting results out to the actual test 
without having to read the output stream. Which would be the alternative 
solution.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Concurrent-safe access to local Maven repository
> 
>
> Key: MNG-2802
> URL: https://issues.apache.org/jira/browse/MNG-2802
> Project: Maven
>  Issue Type: Improvement
>  Components: Artifacts and Repositories
>Reporter: Stepan Roh
>Assignee: John Casey
>Priority: Major
> Fix For: Issues to be reviewed for 3.x
>
>
> It seems that access to local Maven repository is not concurrent-safe that is 
> multiple Mavens running in parallel may damage contents of local Maven 
> repository. It would be a nice improvement, because sharing of local 
> repository will lower the need for contacting any other repository. I know 
> that Maven proxy can be used, but that adds another layer which may 
> unnecessarily stress the machine it runs on.
> *NOTE:* 
> http://takari.io/book/30-team-maven.html#concurrent-safe-local-repository is 
> a Takari Extension for Apache Maven that introduces a concurrent-safe 
> local-re

[GitHub] khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional modulepaths

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414061396
 
 
   It would be helpful if you used the templates as they are provided during 
the creation of the pull request...
   Apart from that would you please squash your commits into a single commit


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584786#comment-16584786
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414061396
 
 
   It would be helpful if you used the templates as they are provided during 
the creation of the pull request...
   Apart from that would you please squash your commits into a single commit


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ggam closed pull request #2: [MJLINK-23] Allow setting additional modulepaths

ggam closed pull request #2: [MJLINK-23] Allow setting additional modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):



 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584788#comment-16584788
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

ggam closed pull request #2: [MJLINK-23] Allow setting additional modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):



 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ggam opened a new pull request #2: [MJLINK-23] Allow setting additional modulepaths

ggam opened a new pull request #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   There's a modulePaths property but it's missing the @parameter annotation.
   
   -
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MJLINK) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [X] Format the pull request title like `[MJLINK-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584789#comment-16584789
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

ggam opened a new pull request #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   There's a modulePaths property but it's missing the @parameter annotation.
   
   -
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MJLINK) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [X] Format the pull request title like `[MJLINK-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MJLINK-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ggam commented on issue #2: [MJLINK-23] Allow setting additional modulepaths

ggam commented on issue #2: [MJLINK-23] Allow setting additional modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414062386
 
 
   Sorry I thought the template was just for contributors to make sure we do 
the needed checks. I didn't think it was needed at all since all the checks 
need to be marked before it can be approved.
   
   The commits are squashed now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584791#comment-16584791
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

ggam commented on issue #2: [MJLINK-23] Allow setting additional modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414062386
 
 
   Sorry I thought the template was just for contributors to make sure we do 
the needed checks. I didn't think it was needed at all since all the checks 
need to be marked before it can be approved.
   
   The commits are squashed now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional modulepaths

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414062810
 
 
   First many thanks that you followed the guide lines. This makes my work 
easier. 
   And yes the templates make it easy to follow them (for contributors as well 
as committers) and will create an email to the developers and furthermore it 
will create an entry into the appropriate [JIRA 
issue](https://issues.apache.org/jira/browse/MJLINK-23) which also contains the 
filled template with all information needed for a committer(s).
   
   I will merge as soon as possible but currently we have some issues with our 
CI systems at the moment so it could take some time..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional modulepaths

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414062872
 
 
   It will take some time see here: 
https://builds.apache.org/job/maven-box/job/maven-jlink-plugin/job/MJLINK-23/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584794#comment-16584794
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414062810
 
 
   First many thanks that you followed the guide lines. This makes my work 
easier. 
   And yes the templates make it easy to follow them (for contributors as well 
as committers) and will create an email to the developers and furthermore it 
will create an entry into the appropriate [JIRA 
issue](https://issues.apache.org/jira/browse/MJLINK-23) which also contains the 
filled template with all information needed for a committer(s).
   
   I will merge as soon as possible but currently we have some issues with our 
CI systems at the moment so it could take some time..


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584796#comment-16584796
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414062872
 
 
   It will take some time see here: 
https://builds.apache.org/job/maven-box/job/maven-jlink-plugin/job/MJLINK-23/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (MJLINK-23) Allow setting additional modulepaths



 [ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise reassigned MJLINK-23:
-

Assignee: Karl Heinz Marbaise

> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584817#comment-16584817
 ] 

Karl Heinz Marbaise commented on MJLINK-23:
---

Done in 
[09527d6cd7c9f397fbca498b4fc0f0df797fa280|https://gitbox.apache.org/repos/asf?p=maven-jlink-plugin.git;a=commitdiff;h=09527d6cd7c9f397fbca498b4fc0f0df797fa280]

> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
> Fix For: 3.0.0
>
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MJLINK-23) Allow setting additional modulepaths



 [ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise updated MJLINK-23:
--
Fix Version/s: 3.0.0

> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MJLINK-23) Allow setting additional modulepaths



 [ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MJLINK-23.
-
Resolution: Done

> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Priority: Major
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional modulepaths

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414065811
 
 
   I will thank you our INFRA Team cause they fixed the issue on the CI system 
very fast...So the results looks Ok. I have merged into master.
   Many thanks for your contribution. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] khmarbaise closed pull request #2: [MJLINK-23] Allow setting additional modulepaths

khmarbaise closed pull request #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java 
b/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
index ccc82a6..79691a5 100644
--- a/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
+++ b/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
@@ -168,6 +168,11 @@
 @Parameter
 private String endian;
 
+/**
+ * Include additional paths on the --module-path option.
+ * Project dedependencies and JDK modules are automatically added.
+ */
+@Parameter
 private List modulePaths;
 
 /**


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584819#comment-16584819
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

khmarbaise closed pull request #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java 
b/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
index ccc82a6..79691a5 100644
--- a/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
+++ b/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
@@ -168,6 +168,11 @@
 @Parameter
 private String endian;
 
+/**
+ * Include additional paths on the --module-path option.
+ * Project dedependencies and JDK modules are automatically added.
+ */
+@Parameter
 private List modulePaths;
 
 /**


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584818#comment-16584818
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

khmarbaise commented on issue #2: [MJLINK-23] Allow setting additional 
modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414065811
 
 
   I will thank you our INFRA Team cause they fixed the issue on the CI system 
very fast...So the results looks Ok. I have merged into master.
   Many thanks for your contribution. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584821#comment-16584821
 ] 

Hudson commented on MJLINK-23:
--

Build succeeded in Jenkins: Maven TLP » maven-jlink-plugin » master #24

See 
https://builds.apache.org/job/maven-box/job/maven-jlink-plugin/job/master/24/

> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] ggam commented on issue #2: [MJLINK-23] Allow setting additional modulepaths

ggam commented on issue #2: [MJLINK-23] Allow setting additional modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414066080
 
 
   Thanks for all the explanations. Great to see all working.
   
   El sáb., 18 ago. 2018 17:26, Karl Heinz Marbaise 
   escribió:
   
   > I will thank you our INFRA Team cause they fixed the issue on the CI
   > system very fast...So the results looks Ok. I have merged into master.
   > Many thanks for your contribution.
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJLINK-23) Allow setting additional modulepaths



[ 
https://issues.apache.org/jira/browse/MJLINK-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584822#comment-16584822
 ] 

ASF GitHub Bot commented on MJLINK-23:
--

ggam commented on issue #2: [MJLINK-23] Allow setting additional modulepaths
URL: https://github.com/apache/maven-jlink-plugin/pull/2#issuecomment-414066080
 
 
   Thanks for all the explanations. Great to see all working.
   
   El sáb., 18 ago. 2018 17:26, Karl Heinz Marbaise 
   escribió:
   
   > I will thank you our INFRA Team cause they fixed the issue on the CI
   > system very fast...So the results looks Ok. I have merged into master.
   > Many thanks for your contribution.
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting additional modulepaths
> 
>
> Key: MJLINK-23
> URL: https://issues.apache.org/jira/browse/MJLINK-23
> Project: Maven JLink Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-alpha-2
>Reporter: Guillermo González de Agüero
>Assignee: Karl Heinz Marbaise
>Priority: Major
> Fix For: 3.0.0
>
>
> There's a modulePaths property but it's missing the @Parameter annotation.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] asfgit closed pull request #5: [MJAVADOC-528] - Invalid 'expires' attribute

asfgit closed pull request #5: [MJAVADOC-528] - Invalid 'expires' attribute
URL: https://github.com/apache/maven-javadoc-plugin/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/it/projects/MJAVADOC-528/invoker.properties 
b/src/it/projects/MJAVADOC-528/invoker.properties
new file mode 100644
index 000..a4e250d
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/invoker.properties
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals=clean javadoc:javadoc
diff --git a/src/it/projects/MJAVADOC-528/pom.xml 
b/src/it/projects/MJAVADOC-528/pom.xml
new file mode 100644
index 000..c14787f
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/pom.xml
@@ -0,0 +1,55 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  4.0.0
+
+  org.apache.maven.plugins.maven-javadoc-plugin.it
+  mjavadoc-528
+  1.0-SNAPSHOT
+
+  
+UTF-8
+  
+
+  
+
+  
+
+  org.apache.maven.plugins
+  maven-javadoc-plugin
+  @pom.version@
+  
+true
+  
+
+  
+
+  
+
+  
+ 
+   com.google.code.gson
+   gson
+   2.5
+ 
+  
+
diff --git a/src/it/projects/MJAVADOC-528/src/main/java/foo/bar/MyClass.java 
b/src/it/projects/MJAVADOC-528/src/main/java/foo/bar/MyClass.java
new file mode 100644
index 000..e5960e3
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/src/main/java/foo/bar/MyClass.java
@@ -0,0 +1,24 @@
+package foo.bar;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+public class MyClass
+{
+}
diff --git a/src/it/projects/MJAVADOC-528/verify.groovy 
b/src/it/projects/MJAVADOC-528/verify.groovy
new file mode 100644
index 000..66dfbd1
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/verify.groovy
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+File log = new File( basedir, 'build.log' )
+assert !( log.text =~ /.*Invalid cookie header:[^\r\n]+\. Invalid 'expires' 
attribute:.*/ )
diff --git a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java 
b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
index a740c6e..c96d12a 100644
--- a/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java
+++ b/src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.ja

[jira] [Commented] (MJAVADOC-528) Invalid 'expires' attribute



[ 
https://issues.apache.org/jira/browse/MJAVADOC-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584833#comment-16584833
 ] 

ASF GitHub Bot commented on MJAVADOC-528:
-

asfgit closed pull request #5: [MJAVADOC-528] - Invalid 'expires' attribute
URL: https://github.com/apache/maven-javadoc-plugin/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/it/projects/MJAVADOC-528/invoker.properties 
b/src/it/projects/MJAVADOC-528/invoker.properties
new file mode 100644
index 000..a4e250d
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/invoker.properties
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals=clean javadoc:javadoc
diff --git a/src/it/projects/MJAVADOC-528/pom.xml 
b/src/it/projects/MJAVADOC-528/pom.xml
new file mode 100644
index 000..c14787f
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/pom.xml
@@ -0,0 +1,55 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+  4.0.0
+
+  org.apache.maven.plugins.maven-javadoc-plugin.it
+  mjavadoc-528
+  1.0-SNAPSHOT
+
+  
+UTF-8
+  
+
+  
+
+  
+
+  org.apache.maven.plugins
+  maven-javadoc-plugin
+  @pom.version@
+  
+true
+  
+
+  
+
+  
+
+  
+ 
+   com.google.code.gson
+   gson
+   2.5
+ 
+  
+
diff --git a/src/it/projects/MJAVADOC-528/src/main/java/foo/bar/MyClass.java 
b/src/it/projects/MJAVADOC-528/src/main/java/foo/bar/MyClass.java
new file mode 100644
index 000..e5960e3
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/src/main/java/foo/bar/MyClass.java
@@ -0,0 +1,24 @@
+package foo.bar;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * 
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ * 
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+public class MyClass
+{
+}
diff --git a/src/it/projects/MJAVADOC-528/verify.groovy 
b/src/it/projects/MJAVADOC-528/verify.groovy
new file mode 100644
index 000..66dfbd1
--- /dev/null
+++ b/src/it/projects/MJAVADOC-528/verify.groovy
@@ -0,0 +1,21 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+File log = new File( basedir, 'build.log' )
+assert !( log.text =~ /.*Invalid cookie header:[^\r\n]+\. Invalid 'expires' 
attribute:.*/ )
diff --git a/src/main/java/org/apache/maven/plug

[jira] [Commented] (MJAVADOC-528) Invalid 'expires' attribute



[ 
https://issues.apache.org/jira/browse/MJAVADOC-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584834#comment-16584834
 ] 

Guillaume Boué commented on MJAVADOC-528:
-

Fixed in 
[b651443bba06fdf469b730024489c3f02629e50c|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=b651443bba06fdf469b730024489c3f02629e50c].

> Invalid 'expires' attribute
> ---
>
> Key: MJAVADOC-528
> URL: https://issues.apache.org/jira/browse/MJAVADOC-528
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.0.1
>Reporter: Roberto Benedetti
>Priority: Major
>  Labels: detectLinks
> Attachments: cookie.patch
>
>
> When detectLinks is enabled and the plugin checks if the url is valid, 
> warnings like this
> {code:java}
> Invalid cookie header: "Set-Cookie: logged_in=no; domain=.github.com; path=/; 
> expires=Sun, 06 Jun 2038 14:02:43 -; secure; HttpOnly". Invalid 'expires' 
> attribute: Sun, 06 Jun 2038 14:02:43 -
> {code}
> may appear.
> Previous warning was due to {{com.google.code.gson:gson:jar:2.5}} dependency 
> and is raised by HttpClient which does not expect 'expires' values compliant 
> to RFC 6265.
>  The attachment is a patch which makes HttpClient ignore cookies. Maybe a 
> better solution would be upgrading to the latest HttpComponents API which 
> supports RFC 6265.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MJAVADOC-528) Invalid 'expires' attribute



 [ 
https://issues.apache.org/jira/browse/MJAVADOC-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Boué closed MJAVADOC-528.
---
   Resolution: Fixed
 Assignee: Guillaume Boué
Fix Version/s: 3.0.2

> Invalid 'expires' attribute
> ---
>
> Key: MJAVADOC-528
> URL: https://issues.apache.org/jira/browse/MJAVADOC-528
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.0.1
>Reporter: Roberto Benedetti
>Assignee: Guillaume Boué
>Priority: Major
>  Labels: detectLinks
> Fix For: 3.0.2
>
> Attachments: cookie.patch
>
>
> When detectLinks is enabled and the plugin checks if the url is valid, 
> warnings like this
> {code:java}
> Invalid cookie header: "Set-Cookie: logged_in=no; domain=.github.com; path=/; 
> expires=Sun, 06 Jun 2038 14:02:43 -; secure; HttpOnly". Invalid 'expires' 
> attribute: Sun, 06 Jun 2038 14:02:43 -
> {code}
> may appear.
> Previous warning was due to {{com.google.code.gson:gson:jar:2.5}} dependency 
> and is raised by HttpClient which does not expect 'expires' values compliant 
> to RFC 6265.
>  The attachment is a patch which makes HttpClient ignore cookies. Maybe a 
> better solution would be upgrading to the latest HttpComponents API which 
> supports RFC 6265.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJAVADOC-528) Invalid 'expires' attribute



[ 
https://issues.apache.org/jira/browse/MJAVADOC-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584835#comment-16584835
 ] 

Hudson commented on MJAVADOC-528:
-

Build succeeded in Jenkins: Maven TLP » maven-javadoc-plugin » master #59

See 
https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/job/master/59/

> Invalid 'expires' attribute
> ---
>
> Key: MJAVADOC-528
> URL: https://issues.apache.org/jira/browse/MJAVADOC-528
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>  Components: javadoc
>Affects Versions: 3.0.1
>Reporter: Roberto Benedetti
>Assignee: Guillaume Boué
>Priority: Major
>  Labels: detectLinks
> Fix For: 3.0.2
>
> Attachments: cookie.patch
>
>
> When detectLinks is enabled and the plugin checks if the url is valid, 
> warnings like this
> {code:java}
> Invalid cookie header: "Set-Cookie: logged_in=no; domain=.github.com; path=/; 
> expires=Sun, 06 Jun 2038 14:02:43 -; secure; HttpOnly". Invalid 'expires' 
> attribute: Sun, 06 Jun 2038 14:02:43 -
> {code}
> may appear.
> Previous warning was due to {{com.google.code.gson:gson:jar:2.5}} dependency 
> and is raised by HttpClient which does not expect 'expires' values compliant 
> to RFC 6265.
>  The attachment is a patch which makes HttpClient ignore cookies. Maybe a 
> better solution would be upgrading to the latest HttpComponents API which 
> supports RFC 6265.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MJAVADOC-535) Upgrade to parent pom 32

Guillaume Boué created MJAVADOC-535:
---

 Summary: Upgrade to parent pom 32
 Key: MJAVADOC-535
 URL: https://issues.apache.org/jira/browse/MJAVADOC-535
 Project: Maven Javadoc Plugin
  Issue Type: Dependency upgrade
Affects Versions: 3.0.1
Reporter: Guillaume Boué
Assignee: Guillaume Boué
 Fix For: 3.0.2






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJAVADOC-535) Upgrade to parent pom 32



[ 
https://issues.apache.org/jira/browse/MJAVADOC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584842#comment-16584842
 ] 

Guillaume Boué commented on MJAVADOC-535:
-

Fixed in 
[033ce3a46b7fdf3ed6a9075192d6e3b4dd2800ec|https://gitbox.apache.org/repos/asf?p=maven-javadoc-plugin.git;a=commit;h=033ce3a46b7fdf3ed6a9075192d6e3b4dd2800ec].

> Upgrade to parent pom 32
> 
>
> Key: MJAVADOC-535
> URL: https://issues.apache.org/jira/browse/MJAVADOC-535
> Project: Maven Javadoc Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.1
>Reporter: Guillaume Boué
>Assignee: Guillaume Boué
>Priority: Minor
> Fix For: 3.0.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MJAVADOC-535) Upgrade to parent pom 32



 [ 
https://issues.apache.org/jira/browse/MJAVADOC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Boué closed MJAVADOC-535.
---
Resolution: Fixed

> Upgrade to parent pom 32
> 
>
> Key: MJAVADOC-535
> URL: https://issues.apache.org/jira/browse/MJAVADOC-535
> Project: Maven Javadoc Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.1
>Reporter: Guillaume Boué
>Assignee: Guillaume Boué
>Priority: Minor
> Fix For: 3.0.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJAVADOC-535) Upgrade to parent pom 32



[ 
https://issues.apache.org/jira/browse/MJAVADOC-535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584848#comment-16584848
 ] 

Hudson commented on MJAVADOC-535:
-

Build succeeded in Jenkins: Maven TLP » maven-javadoc-plugin » master #60

See 
https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/job/master/60/

> Upgrade to parent pom 32
> 
>
> Key: MJAVADOC-535
> URL: https://issues.apache.org/jira/browse/MJAVADOC-535
> Project: Maven Javadoc Plugin
>  Issue Type: Dependency upgrade
>Affects Versions: 3.0.1
>Reporter: Guillaume Boué
>Assignee: Guillaume Boué
>Priority: Minor
> Fix For: 3.0.2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPOM-205) create SHA-512 checksum for source-release archive(s) in target/ during release



 [ 
https://issues.apache.org/jira/browse/MPOM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MPOM-205:
---
Description: 
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it "normal" artifacts or source 
release)

while source release archive and its signature are available in target/ (or 
target/checkout/target during release with Maven Release Plugin), checksums are 
not there: this gives people the bad habit to download everything (not only 
checksums) from Apache Nexus repository after deploy to copy to Apache /dist/

it would be useful to have the checksums for source release available in 
target/ (then in target/checkout/target during release)

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories (and even not supported: 
they are considered as artifacts, not checksums, then require md5 and sha1 
checksum files...), but they are required for Apache source release distribution

  was:
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it normal artifacts or source 
release)

while source release archive and its signature are available in target/, 
checksums are not there: this gives people the bad habit to download everything 
(not only checksums) from Apache Nexus repository after deploy to copy to 
Apache /dist/

it would be useful to have the checksums for source release available in target/

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories, but they are required 
for Apache source release distribution


> create SHA-512 checksum for source-release archive(s) in target/ during 
> release
> ---
>
> Key: MPOM-205
> URL: https://issues.apache.org/jira/browse/MPOM-205
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-20
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: ASF-21
>
>
> currently, during Apache release, checksums are not created in target/ 
> directory: checksums are created on the fly during deploy to the Maven 
> repository (for absolutely every artifact, be it "normal" artifacts or source 
> release)
> while source release archive and its signature are available in target/ (or 
> target/checkout/target during release with Maven Release Plugin), checksums 
> are not there: this gives people the bad habit to download everything (not 
> only checksums) from Apache Nexus repository after deploy to copy to Apache 
> /dist/
> it would be useful to have the checksums for source release available in 
> target/ (then in target/checkout/target during release)
> this would also prepare having new Apache checksums requirements for Apache 
> mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
> sha256 and sha512 are not used for Maven repositories (and even not 
> supported: they are considered as artifacts, not checksums, then require md5 
> and sha1 checksum files...), but they are required for Apache source release 
> distribution



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPOM-134) Add profile to use a different resource bundle for incubator projects



 [ 
https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MPOM-134:
---
Fix Version/s: (was: ASF-21)
   ASF-22

> Add profile to use a different resource bundle for incubator projects
> -
>
> Key: MPOM-134
> URL: https://issues.apache.org/jira/browse/MPOM-134
> Project: Maven POMs
>  Issue Type: Improvement
>Affects Versions: ASF-18
>Reporter: Christopher Tubbs
>Priority: Major
> Fix For: ASF-22
>
>
> The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently 
> specified in the parent POM does not handle the DISCLAIMER file for incubator 
> projects.
> It would be nice if there were an incubation profile, which could be 
> activated for incubating projects, to use an incubating resource bundle which 
> did handle this DISCLAIMER file.
> This could be done in several ways:
> # An optional second execution of the {{maven-remote-resources-plugin}} could 
> run when the profile is activated, which handles a second resource bundle for 
> the DISCLAIMER file.
> # The current resourceBundle could be turned into a property, which is 
> overridden when the profile is activated, using a resourceBundle which 
> handles everything the current one does, plus the DISCLAIMER file.
> # The current {{maven-remote-resources-plugin}} execution could have the 
> {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional 
> {{}} to handle the DISCLAIMER file, for the same execution id 
> of {{maven-remote-resources-plugin}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPOM-168) JDK 9 requires updates to plugins



 [ 
https://issues.apache.org/jira/browse/MPOM-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MPOM-168:
---
Fix Version/s: (was: ASF-21)
   ASF-22

> JDK 9 requires updates to plugins
> -
>
> Key: MPOM-168
> URL: https://issues.apache.org/jira/browse/MPOM-168
> Project: Maven POMs
>  Issue Type: Improvement
>  Components: asf
>Affects Versions: ASF-19
>Reporter: Karl Heinz Marbaise
>Priority: Minor
> Fix For: ASF-22
>
>
> The following plugins needed to be updated to work with JDK 9:
> * The maven-enforcer-plugin should be updated to final 3.0.0 release to make 
> the pom working with JDK 9...
> * maven-shade-plugin should be upgraded to 3.0.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPOM-205) create SHA-512 checksum for source-release archive(s) in target/checkout/target/ during release



 [ 
https://issues.apache.org/jira/browse/MPOM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MPOM-205:
---
Summary: create SHA-512 checksum for source-release archive(s) in 
target/checkout/target/ during release  (was: create SHA-512 checksum for 
source-release archive(s) in target/ during release)

> create SHA-512 checksum for source-release archive(s) in 
> target/checkout/target/ during release
> ---
>
> Key: MPOM-205
> URL: https://issues.apache.org/jira/browse/MPOM-205
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-20
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: ASF-21
>
>
> currently, during Apache release, checksums are not created in target/ 
> directory: checksums are created on the fly during deploy to the Maven 
> repository (for absolutely every artifact, be it "normal" artifacts or source 
> release)
> while source release archive and its signature are available in target/ (or 
> target/checkout/target during release with Maven Release Plugin), checksums 
> are not there: this gives people the bad habit to download everything (not 
> only checksums) from Apache Nexus repository after deploy to copy to Apache 
> /dist/
> it would be useful to have the checksums for source release available in 
> target/ (then in target/checkout/target during release)
> this would also prepare having new Apache checksums requirements for Apache 
> mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
> sha256 and sha512 are not used for Maven repositories (and even not 
> supported: they are considered as artifacts, not checksums, then require md5 
> and sha1 checksum files...), but they are required for Apache source release 
> distribution



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPOM-205) create SHA-512 checksum for source-release archive(s) in target/checkout/target/ during release



 [ 
https://issues.apache.org/jira/browse/MPOM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MPOM-205:
---
Description: 
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it "normal" artifacts or source 
release)

while source release archive and its signature are available in target/ (or 
target/checkout/target during release with Maven Release Plugin), checksums are 
not there: this gives people the bad habit to download everything (not only 
checksums) from Apache Nexus repository after deploy to copy to Apache /dist/

it would be useful to have the checksums for source release available in 
target/ (then in target/checkout/target during release)

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories (and even not supported: 
they are considered as artifacts, not checksums, then require md5 and sha1 
checksum files and ..asc detached signature...), but they are required for 
Apache source release distribution

  was:
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it "normal" artifacts or source 
release)

while source release archive and its signature are available in target/ (or 
target/checkout/target during release with Maven Release Plugin), checksums are 
not there: this gives people the bad habit to download everything (not only 
checksums) from Apache Nexus repository after deploy to copy to Apache /dist/

it would be useful to have the checksums for source release available in 
target/ (then in target/checkout/target during release)

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories (and even not supported: 
they are considered as artifacts, not checksums, then require md5 and sha1 
checksum files...), but they are required for Apache source release distribution


> create SHA-512 checksum for source-release archive(s) in 
> target/checkout/target/ during release
> ---
>
> Key: MPOM-205
> URL: https://issues.apache.org/jira/browse/MPOM-205
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-20
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: ASF-21
>
>
> currently, during Apache release, checksums are not created in target/ 
> directory: checksums are created on the fly during deploy to the Maven 
> repository (for absolutely every artifact, be it "normal" artifacts or source 
> release)
> while source release archive and its signature are available in target/ (or 
> target/checkout/target during release with Maven Release Plugin), checksums 
> are not there: this gives people the bad habit to download everything (not 
> only checksums) from Apache Nexus repository after deploy to copy to Apache 
> /dist/
> it would be useful to have the checksums for source release available in 
> target/ (then in target/checkout/target during release)
> this would also prepare having new Apache checksums requirements for Apache 
> mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
> sha256 and sha512 are not used for Maven repositories (and even not 
> supported: they are considered as artifacts, not checksums, then require md5 
> and sha1 checksum files and ..asc detached signature...), but they are 
> required for Apache source release distribution



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPOM-205) create SHA-512 checksum for source-release archive(s) in target/checkout/target/ during release



 [ 
https://issues.apache.org/jira/browse/MPOM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MPOM-205:
---
Description: 
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it "normal" artifacts or source 
release)

while source release archive and its signature are available in target/ (or 
target/checkout/target during release with Maven Release Plugin), checksums are 
not there: this gives people the bad habit to download everything (not only 
checksums) from Apache Nexus repository after deploy to copy to Apache /dist/

it would be useful to have the checksums for source release available in 
target/ (then in target/checkout/target during release)

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories, but they are required 
for Apache source release distribution

Notice: .sha256 and .sha512 files are not only not supported for Maven 
repositories, but even not supported: they are considered as artifacts, not 
checksums, then require md5 and sha1 checksum files and .asc detached 
signature...

  was:
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it "normal" artifacts or source 
release)

while source release archive and its signature are available in target/ (or 
target/checkout/target during release with Maven Release Plugin), checksums are 
not there: this gives people the bad habit to download everything (not only 
checksums) from Apache Nexus repository after deploy to copy to Apache /dist/

it would be useful to have the checksums for source release available in 
target/ (then in target/checkout/target during release)

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories (and even not supported: 
they are considered as artifacts, not checksums, then require md5 and sha1 
checksum files and ..asc detached signature...), but they are required for 
Apache source release distribution


> create SHA-512 checksum for source-release archive(s) in 
> target/checkout/target/ during release
> ---
>
> Key: MPOM-205
> URL: https://issues.apache.org/jira/browse/MPOM-205
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-20
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: ASF-21
>
>
> currently, during Apache release, checksums are not created in target/ 
> directory: checksums are created on the fly during deploy to the Maven 
> repository (for absolutely every artifact, be it "normal" artifacts or source 
> release)
> while source release archive and its signature are available in target/ (or 
> target/checkout/target during release with Maven Release Plugin), checksums 
> are not there: this gives people the bad habit to download everything (not 
> only checksums) from Apache Nexus repository after deploy to copy to Apache 
> /dist/
> it would be useful to have the checksums for source release available in 
> target/ (then in target/checkout/target during release)
> this would also prepare having new Apache checksums requirements for Apache 
> mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
> sha256 and sha512 are not used for Maven repositories, but they are required 
> for Apache source release distribution
> Notice: .sha256 and .sha512 files are not only not supported for Maven 
> repositories, but even not supported: they are considered as artifacts, not 
> checksums, then require md5 and sha1 checksum files and .asc detached 
> signature...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPOM-205) create SHA-512 checksum for source-release archive(s) in target/checkout/target/ during release



 [ 
https://issues.apache.org/jira/browse/MPOM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hervé Boutemy updated MPOM-205:
---
Description: 
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it "normal" artifacts or source 
release)

while source release archive and its signature are available in target/ (or 
target/checkout/target during release with Maven Release Plugin), checksums are 
not there: this gives people the bad habit to download everything (not only 
checksums) from Apache Nexus repository after deploy to copy to Apache /dist/

it would be useful to have the checksums for source release available in 
target/ (then in target/checkout/target during release)

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories, but they are required 
for Apache source release distribution

Notice: .sha256 and .sha512 files are not only not supported for Maven 
repositories, but even not supported: they are considered as artifacts, not 
checksums, then require md5 and sha1 checksum files and .asc detached 
signature...
Then the .sha512 file is not to be deployed to the Maven repository, only 
Apache /dist/

  was:
currently, during Apache release, checksums are not created in target/ 
directory: checksums are created on the fly during deploy to the Maven 
repository (for absolutely every artifact, be it "normal" artifacts or source 
release)

while source release archive and its signature are available in target/ (or 
target/checkout/target during release with Maven Release Plugin), checksums are 
not there: this gives people the bad habit to download everything (not only 
checksums) from Apache Nexus repository after deploy to copy to Apache /dist/

it would be useful to have the checksums for source release available in 
target/ (then in target/checkout/target during release)

this would also prepare having new Apache checksums requirements for Apache 
mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
sha256 and sha512 are not used for Maven repositories, but they are required 
for Apache source release distribution

Notice: .sha256 and .sha512 files are not only not supported for Maven 
repositories, but even not supported: they are considered as artifacts, not 
checksums, then require md5 and sha1 checksum files and .asc detached 
signature...


> create SHA-512 checksum for source-release archive(s) in 
> target/checkout/target/ during release
> ---
>
> Key: MPOM-205
> URL: https://issues.apache.org/jira/browse/MPOM-205
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-20
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: ASF-21
>
>
> currently, during Apache release, checksums are not created in target/ 
> directory: checksums are created on the fly during deploy to the Maven 
> repository (for absolutely every artifact, be it "normal" artifacts or source 
> release)
> while source release archive and its signature are available in target/ (or 
> target/checkout/target during release with Maven Release Plugin), checksums 
> are not there: this gives people the bad habit to download everything (not 
> only checksums) from Apache Nexus repository after deploy to copy to Apache 
> /dist/
> it would be useful to have the checksums for source release available in 
> target/ (then in target/checkout/target during release)
> this would also prepare having new Apache checksums requirements for Apache 
> mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
> sha256 and sha512 are not used for Maven repositories, but they are required 
> for Apache source release distribution
> Notice: .sha256 and .sha512 files are not only not supported for Maven 
> repositories, but even not supported: they are considered as artifacts, not 
> checksums, then require md5 and sha1 checksum files and .asc detached 
> signature...
> Then the .sha512 file is not to be deployed to the Maven repository, only 
> Apache /dist/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MPOM-205) create SHA-512 checksum for source-release archive(s) in target/checkout/target/ during release



[ 
https://issues.apache.org/jira/browse/MPOM-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584856#comment-16584856
 ] 

Hudson commented on MPOM-205:
-

Build succeeded in Jenkins: Maven TLP » maven-apache-parent » master #38

See 
https://builds.apache.org/job/maven-box/job/maven-apache-parent/job/master/38/

> create SHA-512 checksum for source-release archive(s) in 
> target/checkout/target/ during release
> ---
>
> Key: MPOM-205
> URL: https://issues.apache.org/jira/browse/MPOM-205
> Project: Maven POMs
>  Issue Type: New Feature
>  Components: asf
>Affects Versions: ASF-20
>Reporter: Hervé Boutemy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: ASF-21
>
>
> currently, during Apache release, checksums are not created in target/ 
> directory: checksums are created on the fly during deploy to the Maven 
> repository (for absolutely every artifact, be it "normal" artifacts or source 
> release)
> while source release archive and its signature are available in target/ (or 
> target/checkout/target during release with Maven Release Plugin), checksums 
> are not there: this gives people the bad habit to download everything (not 
> only checksums) from Apache Nexus repository after deploy to copy to Apache 
> /dist/
> it would be useful to have the checksums for source release available in 
> target/ (then in target/checkout/target during release)
> this would also prepare having new Apache checksums requirements for Apache 
> mirroring: http://www.apache.org/dev/release-distribution#sigs-and-sums
> sha256 and sha512 are not used for Maven repositories, but they are required 
> for Apache source release distribution
> Notice: .sha256 and .sha512 files are not only not supported for Maven 
> repositories, but even not supported: they are considered as artifacts, not 
> checksums, then require md5 and sha1 checksum files and .asc detached 
> signature...
> Then the .sha512 file is not to be deployed to the Maven repository, only 
> Apache /dist/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSITE-639) sub-project tries to fetch a site_en.xml even though no locales are configured

2018-08-18 Thread Stephen Colebourne (JIRA)



[ 
https://issues.apache.org/jira/browse/MSITE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584858#comment-16584858
 ] 

Stephen Colebourne commented on MSITE-639:
--

I can't reopen this (as I don't have permission), but I believe it is still a 
problem with the latest plugins. However it is transient - it does not happen 
every time. I haven't tried the projects above, but can point you at Joda-Money 
for example. [https://github.com/JodaOrg/joda-money] as of the 18th August.

I suspect that it does not always fail the first time as the failure is due to 
network issues of some kind, such as Maven Central being flaky. This is 
particularly a problem if multiple repos are being queried. Without 
investigating further, my gut feeling is that the code only determines that the 
file is missing if  _all_ the remote repos say its not there. Thus if one repo 
is slow, or returns something other than 404 (eg. a security access failure)

I've seen the problem on Java 8, 9 and 10 builds on Travis. For example, I 
pushed three separate Joda projects in the last hour which performed 9 builds 
on Travis - with two Java 9 failures and one Java 10. ie. the same commit in 
the same Travis build failing on 10 but working on 9 and vice versa). My next 
set of 9 builds saw 4 fail and 5 succeed.

This is the section of the build in my case when it succeeds, as can be seen it 
queries multiple repos:
 
{noformat}
[INFO] Done SpotBugs Analysis [INFO] Rendering site with default locale 
English (en) [INFO] Downloading from sonatype: 
https://oss.sonatype.org/content/repositories/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
 [INFO] Downloading from sonatype-apache: 
https://repository.apache.org/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
 [INFO] Downloading from central: 
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
 [INFO] Downloaded from central: 
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
 (87 B at 4.1 kB/s) [INFO] Relativizing decoration links with respect to 
localized project URL: http://www.joda.org/joda-beans/{noformat}
 
Note that until these most recent builds, my parent project had no `site.xml`. 
The purpose of my change today was to publish site.xml using 
site:attach-descriptor to avoid this problem. However, since it is still 
looking for site_en.xml which is not published, I still get the error, which is 
a pain.

For the logs produced when it fails, see here: 
[https://travis-ci.org/JodaOrg/joda-convert/jobs/417679434] As can be seen, the 
"connection timed out", but the real question is why is it trying to query the 
_en file in the first place?

 

> sub-project tries to fetch a site_en.xml even though no locales are configured
> --
>
> Key: MSITE-639
> URL: https://issues.apache.org/jira/browse/MSITE-639
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.0
> Environment: Windows 7 64bit,  Sun JDK 1.6.0_27
>Reporter: Martin Goldhahn
>Priority: Major
> Attachments: parent-project.zip, sub-project.zip
>
>
> I have a parent project that has a site descriptor and a pom project that has 
> the parent project as parent. Neither of them defines the locales parameter 
> of the site plugin.
> When I try to build the sub-project, I get an error that Maven cannot find 
> the site_en.xml descriptor of the parent project. Why doesn't it just use the 
> site.xml?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (MSITE-639) sub-project tries to fetch a site_en.xml even though no locales are configured

2018-08-18 Thread Stephen Colebourne (JIRA)

[
https://issues.apache.org/jira/browse/MSITE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584858#comment-16584858
]

Stephen Colebourne edited comment on MSITE-639 at 8/18/18 5:55 PM:
---

I can't reopen this (as I don't have permission), but I believe it is still a
problem with the latest plugins. However it is transient - it does not happen
every time. I haven't tried the projects above, but can point you at Joda-Money
for example. [https://github.com/JodaOrg/joda-money] as of the 18th August.

I suspect that it does not always fail the first time as the failure is due to
network issues of some kind, such as Maven Central being flaky. This is
particularly a problem if multiple repos are being queried. Without
investigating further, my gut feeling is that the code only determines that the
file is missing if _all_ the remote repos say its not there. Thus if one repo
is slow, or returns something other than 404 (eg. a security access failure)

I've seen the problem on Java 8, 9 and 10 builds on Travis. For example, I
pushed three separate Joda projects in the last hour which performed 9 builds
on Travis - with two Java 9 failures and one Java 10. ie. the same commit in
the same Travis build failing on 10 but working on 9 and vice versa). My next
set of 9 builds saw 4 fail and 5 succeed.

This is the section of the build in my case when it succeeds, as can be seen it
queries multiple repos:
{noformat}
[INFO] Done SpotBugs Analysis [INFO] Rendering site with default locale
English (en) [INFO] Downloading from sonatype:
https://oss.sonatype.org/content/repositories/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
[INFO] Downloading from sonatype-apache:
https://repository.apache.org/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
[INFO] Downloading from central:
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
[INFO] Downloaded from central:
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
(87 B at 4.1 kB/s) [INFO] Relativizing decoration links with respect to
localized project URL: http://www.joda.org/joda-beans/{noformat}
Note that until these most recent builds, my parent project had no `site.xml`.
The purpose of my change today was to publish site.xml using
site:attach-descriptor to avoid this problem. However, since it is still
looking for site_en.xml which is not published, I still get the error, which is
a pain.

For the logs produced when it fails, see here:
[https://travis-ci.org/JodaOrg/joda-convert/jobs/417679434] As can be seen, the
"connection timed out", but the real question is why is it trying to query the
_en file in the first place?

PS. When both site_en.xml and site.xml are present, mvn site:attach-descriptor
only attaches the _en variant!

was (Author: scolebou...@joda.org):
I can't reopen this (as I don't have permission), but I believe it is still a
problem with the latest plugins. However it is transient - it does not happen
every time. I haven't tried the projects above, but can point you at Joda-Money
for example. [https://github.com/JodaOrg/joda-money] as of the 18th August.

[jira] [Commented] (MSITE-639) sub-project tries to fetch a site_en.xml even though no locales are configured



[ 
https://issues.apache.org/jira/browse/MSITE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584860#comment-16584860
 ] 

Karl Heinz Marbaise commented on MSITE-639:
---

Commenting on closed issue is not a good idea better creating a new one with 
the reference to this one (via Link)

> sub-project tries to fetch a site_en.xml even though no locales are configured
> --
>
> Key: MSITE-639
> URL: https://issues.apache.org/jira/browse/MSITE-639
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.0
> Environment: Windows 7 64bit,  Sun JDK 1.6.0_27
>Reporter: Martin Goldhahn
>Priority: Major
> Attachments: parent-project.zip, sub-project.zip
>
>
> I have a parent project that has a site descriptor and a pom project that has 
> the parent project as parent. Neither of them defines the locales parameter 
> of the site plugin.
> When I try to build the sub-project, I get an error that Maven cannot find 
> the site_en.xml descriptor of the parent project. Why doesn't it just use the 
> site.xml?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (MSITE-639) sub-project tries to fetch a site_en.xml even though no locales are configured



[ 
https://issues.apache.org/jira/browse/MSITE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584860#comment-16584860
 ] 

Karl Heinz Marbaise edited comment on MSITE-639 at 8/18/18 6:06 PM:


Commenting on closed issue is not a good idea better creating a new one with 
the reference to this one (via Link)Apart from that this looks like a issue 
on travis side cause I observed that as well a few hours ago.


was (Author: khmarbaise):
Commenting on closed issue is not a good idea better creating a new one with 
the reference to this one (via Link)

> sub-project tries to fetch a site_en.xml even though no locales are configured
> --
>
> Key: MSITE-639
> URL: https://issues.apache.org/jira/browse/MSITE-639
> Project: Maven Site Plugin
>  Issue Type: Bug
>Affects Versions: 3.0
> Environment: Windows 7 64bit,  Sun JDK 1.6.0_27
>Reporter: Martin Goldhahn
>Priority: Major
> Attachments: parent-project.zip, sub-project.zip
>
>
> I have a parent project that has a site descriptor and a pom project that has 
> the parent project as parent. Neither of them defines the locales parameter 
> of the site plugin.
> When I try to build the sub-project, I get an error that Maven cannot find 
> the site_en.xml descriptor of the parent project. Why doesn't it just use the 
> site.xml?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (MSITE-639) sub-project tries to fetch a site_en.xml even though no locales are configured