[ 
https://issues.apache.org/jira/browse/MSITE-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584858#comment-16584858
 ] 

Stephen Colebourne edited comment on MSITE-639 at 8/18/18 6:22 PM:
-------------------------------------------------------------------

I can't reopen this (as I don't have permission), but I believe it is still a 
problem with the latest plugins. However it is transient - it does not happen 
every time. I haven't tried the projects above, but can point you at Joda-Money 
for example. [https://github.com/JodaOrg/joda-money] as of the 18th August.

I suspect that it does not always fail the first time as the failure is due to 
network issues of some kind, such as Maven Central being flaky. This is 
particularly a problem if multiple repos are being queried. Without 
investigating further, my gut feeling is that the code only determines that the 
file is missing if  _all_ the remote repos say its not there. Thus if one repo 
is slow, or returns something other than 404 (eg. a security access failure)

I've seen the problem on Java 8, 9 and 10 builds on Travis. For example, I 
pushed three separate Joda projects in the last hour which performed 9 builds 
on Travis - with two Java 9 failures and one Java 10. ie. the same commit in 
the same Travis build failing on 10 but working on 9 and vice versa). My next 
set of 9 builds saw 4 fail and 5 succeed.

This is the section of the build in my case when it succeeds, as can be seen it 
queries multiple repos:
  
{noformat}
[INFO] Done SpotBugs Analysis.... [INFO] Rendering site with default locale 
English (en) [INFO] Downloading from sonatype: 
https://oss.sonatype.org/content/repositories/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
 [INFO] Downloading from sonatype-apache: 
https://repository.apache.org/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
 [INFO] Downloading from central: 
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
 [INFO] Downloaded from central: 
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
 (87 B at 4.1 kB/s) [INFO] Relativizing decoration links with respect to 
localized project URL: http://www.joda.org/joda-beans/{noformat}
 
 Note that until these most recent builds, my parent project had no `site.xml`. 
The purpose of my change today was to publish site.xml using 
site:attach-descriptor to avoid this problem. However, since it is still 
looking for site_en.xml which is not published, I still get the error, which is 
a pain.

For the logs produced when it fails, see here: 
[https://travis-ci.org/JodaOrg/joda-convert/jobs/417679434] As can be seen, the 
"connection timed out", but the real question is why is it trying to query the 
_en file in the first place?

PS. When both site_en.xml and site.xml are present, mvn site:attach-descriptor 
only attaches the _en variant! But there is a workaround - declare 
configuration in site:attach-descriptor of <locales>en,de<locales> (de chosen 
at random). This causes both files to get uploaded, which avoids the need for 
Maven to rely on HTTP 404.


was (Author: scolebou...@joda.org):
I can't reopen this (as I don't have permission), but I believe it is still a 
problem with the latest plugins. However it is transient - it does not happen 
every time. I haven't tried the projects above, but can point you at Joda-Money 
for example. [https://github.com/JodaOrg/joda-money] as of the 18th August.

I suspect that it does not always fail the first time as the failure is due to 
network issues of some kind, such as Maven Central being flaky. This is 
particularly a problem if multiple repos are being queried. Without 
investigating further, my gut feeling is that the code only determines that the 
file is missing if  _all_ the remote repos say its not there. Thus if one repo 
is slow, or returns something other than 404 (eg. a security access failure)

I've seen the problem on Java 8, 9 and 10 builds on Travis. For example, I 
pushed three separate Joda projects in the last hour which performed 9 builds 
on Travis - with two Java 9 failures and one Java 10. ie. the same commit in 
the same Travis build failing on 10 but working on 9 and vice versa). My next 
set of 9 builds saw 4 fail and 5 succeed.

This is the section of the build in my case when it succeeds, as can be seen it 
queries multiple repos:
  
{noformat}
[INFO] Done SpotBugs Analysis.... [INFO] Rendering site with default locale 
English (en) [INFO] Downloading from sonatype: 
https://oss.sonatype.org/content/repositories/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
 [INFO] Downloading from sonatype-apache: 
https://repository.apache.org/releases/org/joda/joda-parent/1.3/joda-parent-1.3-site_en.xml
 [INFO] Downloading from central: 
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
 [INFO] Downloaded from central: 
http://repo.maven.apache.org/maven2/org/joda/joda-parent/1.3/joda-parent-1.3-site.xml
 (87 B at 4.1 kB/s) [INFO] Relativizing decoration links with respect to 
localized project URL: http://www.joda.org/joda-beans/{noformat}
 
 Note that until these most recent builds, my parent project had no `site.xml`. 
The purpose of my change today was to publish site.xml using 
site:attach-descriptor to avoid this problem. However, since it is still 
looking for site_en.xml which is not published, I still get the error, which is 
a pain.

For the logs produced when it fails, see here: 
[https://travis-ci.org/JodaOrg/joda-convert/jobs/417679434] As can be seen, the 
"connection timed out", but the real question is why is it trying to query the 
_en file in the first place?

PS. When both site_en.xml and site.xml are present, mvn site:attach-descriptor 
only attaches the _en variant!

> sub-project tries to fetch a site_en.xml even though no locales are configured
> ------------------------------------------------------------------------------
>
>                 Key: MSITE-639
>                 URL: https://issues.apache.org/jira/browse/MSITE-639
>             Project: Maven Site Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0
>         Environment: Windows 7 64bit,  Sun JDK 1.6.0_27
>            Reporter: Martin Goldhahn
>            Priority: Major
>         Attachments: parent-project.zip, sub-project.zip
>
>
> I have a parent project that has a site descriptor and a pom project that has 
> the parent project as parent. Neither of them defines the locales parameter 
> of the site plugin.
> When I try to build the sub-project, I get an error that Maven cannot find 
> the site_en.xml descriptor of the parent project. Why doesn't it just use the 
> site.xml?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to